net: netmem: fix skb_ensure_writable with unreadable skbs
Subsystems (2)
PATCH 1/1 net: netmem: fix skb_ensure_writable with unreadable skbs
skb_ensure_writable should succeed when it's trying to write to the header of the unreadable skbs, so it doesn't need an unconditional skb_frags_readable check. The preceding pskb_may_pull() call will succeed if write_len is within the head and fail if we're trying to write to the unreadable payload, so we don't need an additional check.
Removing this check restores DSCP functionality with unreadable skbs as it's called from dscp_tg.
--- net/core/skbuff.c | 3 --- 1 file changed, 3 deletions(-)
net/core/skbuff.c +0 -3
@@ -6261,9 +6261,6 @@ int skb_ensure_writable(struct sk_buff *skb, unsigned int write_len)if (!pskb_may_pull (skb, write_len))return -ENOMEM ; -if (!skb_frags_readable (skb)) -return -EFAULT ; -if (!skb_cloned (skb) ||skb_clone_writable (skb, write_len))return 0 ;
base-commit: 5466491c9e3309ed5c7adbb8fad6e93fcc9a8fe9
Signature · 1 line
2.50.0.rc1.591.g9c95f17f64-goog
Quoted 8 lines · Mina Almasry
skb_ensure_writableshould succeed when it's trying to write to the header of the unreadable skbs, so it doesn't need an unconditionalskb_frags_readablecheck. The precedingpskb_may_pull()call will succeed ifwrite_lenis within the head and fail if we're trying to write to the unreadable payload, so we don't need an additional check.Removing this check restores DSCP functionality with unreadable skbs as it's called from
dscp_tg.
Can you share more info on which use-case (or which call sites) you're trying to fix?
Quoted 8 lines · Stanislav Fomichev
Quoted 6 lines · Mina Almasry
skb_ensure_writableshould succeed when it's trying to write to the header of the unreadable skbs, so it doesn't need an unconditionalskb_frags_readablecheck. The precedingpskb_may_pull()call will succeed ifwrite_lenis within the head and fail if we're trying to write to the unreadable payload, so we don't need an additional check.
Quoted 5 lines
Quoted 2 lines
Removing this check restores DSCP functionality with unreadable skbs as it's called from
dscp_tg.Can you share more info on which use-case (or which call sites) you're trying to fix?
Hi Stan,
It's the use case of setting a DSCP header, and the call site is dscp_tg() -> skb_ensure_writable.
Repro steps should roughly be:
# Set DSCP header
sudo iptables -tmangle -A POSTROUTING -p tcp -m comment --comment "foo" -j DSCP --set-dscp 0x08
# then run some unreadable netmem workload.
Before this change you should see 0 throughput, after this change the unreadable netmem workload should work as expected.
Signature · 2 lines
Thanks, Mina
Stanislav Fomichev
Acked-byQuoted 22 lines · Mina Almasry
Quoted 8 lines · Stanislav Fomichev
Quoted 6 lines · Mina Almasry
skb_ensure_writableshould succeed when it's trying to write to the header of the unreadable skbs, so it doesn't need an unconditionalskb_frags_readablecheck. The precedingpskb_may_pull()call will succeed ifwrite_lenis within the head and fail if we're trying to write to the unreadable payload, so we don't need an additional check.Quoted 5 lines
Quoted 2 lines
Removing this check restores DSCP functionality with unreadable skbs as it's called from
dscp_tg.Can you share more info on which use-case (or which call sites) you're trying to fix?
Hi Stan,
It's the use case of setting a DSCP header, and the call site is
dscp_tg()->skb_ensure_writable.Repro steps should roughly be:
Quoted 8 lines
# Set DSCP header
sudo iptables -tmangle -A POSTROUTING -p tcp -m comment --comment "foo" -j DSCP --set-dscp0x08# then run some unreadable netmem workload.Before this change you should see 0 throughput, after this change the unreadable netmem workload should work as expected.
Ah, so this is basically all netfilter, makes sense, thanks!
This patch was applied to netdev/net.git (main) by Jakub Kicinski <[email protected]>:
Hello:
This patch was applied to netdev/net.git (main)
by Jakub Kicinski <[email protected]>:
Quoted 10 lines · On Sun, 15 Jun 2025 20:07:33 +0000 you wrote:
skb_ensure_writableshould succeed when it's trying to write to the header of the unreadable skbs, so it doesn't need an unconditionalskb_frags_readablecheck. The precedingpskb_may_pull()call will succeed ifwrite_lenis within the head and fail if we're trying to write to the unreadable payload, so we don't need an additional check.Removing this check restores DSCP functionality with unreadable skbs as it's called from
dscp_tg.[...]
Here is the summary with links:
- [net,v1] net: netmem: fix skb_ensure_writable with unreadable skbs
https://git.kernel.org/netdev/net/c/6f793a1d0537
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html