Skip to contentSkip to conversation

net: mana: Record doorbell physical address in PF mode

PATCH Applied [email protected] 3 participants 3 messages Jun 18, 2025 – Jun 19, 2025

Subsystems (5)
lore
Share & tools
lore
#0 lore raw

PATCH v3 1/1 net: mana: Record doorbell physical address in PF mode

From: Long Li <[email protected]>

MANA supports RDMA in PF mode. The driver should record the doorbell physical address when in PF mode.

The doorbell physical address is used by the RDMA driver to map doorbell pages of the device to user-mode applications through RDMA verbs interface. In the past, they have been mapped to user-mode while the device is in VF mode. With the support for PF mode implemented, also expose those pages in PF mode.

Support for PF mode is implemented in
290e5d3c49f6 ("net: mana: Add support for Multi Vports on Bare metal")

---
Changes
v2: add more details in commit message on how the doorbell physical address is used
v3: add the early commit detail where the support for PF mode is implemented

 drivers/net/ethernet/microsoft/mana/gdma_main.c | 3 +++
 1 file changed, 3 insertions(+)
drivers/net/ethernet/microsoft/mana/gdma_main.c +3 -0
index 3504507477c6..52cf7112762c 100644
@@ -31,6 +31,9 @@ static void mana_gd_init_pf_regs(struct pci_dev *pdev)
 	gc->db_page_base = gc->bar0_va +
 				mana_gd_r64(gc, GDMA_PF_REG_DB_PAGE_OFF);
 
+	gc->phys_db_page_base = gc->bar0_pa +
+				mana_gd_r64(gc, GDMA_PF_REG_DB_PAGE_OFF);
+
 	sriov_base_off = mana_gd_r64(gc, GDMA_SRIOV_REG_CFG_BASE_OFF);
 
 	sriov_base_va = gc->bar0_va + sriov_base_off;
Signature · 1 line
2.25.1
reviewer Reviewed-by on v3 1/1
#1 lore raw
Quoted 11 lines · On Tue, Jun 17, 2025 at 06:36:46PM -0700, [email protected] wrote:

From: Long Li <[email protected]>

MANA supports RDMA in PF mode. The driver should record the doorbell physical address when in PF mode.

The doorbell physical address is used by the RDMA driver to map doorbell pages of the device to user-mode applications through RDMA verbs interface. In the past, they have been mapped to user-mode while the device is in VF mode. With the support for PF mode implemented, also expose those pages in PF mode.

Quoted 8 lines

Support for PF mode is implemented in
290e5d3c49f6 ("net: mana: Add support for Multi Vports on Bare metal")

---
Changes
v2: add more details in commit message on how the doorbell physical address is used
v3: add the early commit detail where the support for PF mode is implemented

Thanks for the updates.

I agree that this revision address Jakub's feedback on v2. Which in turn addressed his feedback on v1.

#2 lore raw
In reply to [email protected]
This patch was applied to netdev/net.git (main) by Jakub Kicinski <[email protected]>:

Hello:

This patch was applied to netdev/net.git (main)
by Jakub Kicinski <[email protected]>:

Quoted 5 lines · On Tue, 17 Jun 2025 18:36:46 -0700 you wrote:

From: Long Li <[email protected]>

MANA supports RDMA in PF mode. The driver should record the doorbell physical address when in PF mode.

Quoted 7 lines

The doorbell physical address is used by the RDMA driver to map doorbell pages of the device to user-mode applications through RDMA verbs interface. In the past, they have been mapped to user-mode while the device is in VF mode. With the support for PF mode implemented, also expose those pages in PF mode.

[...]

Here is the summary with links:
- [net-next,v3] net: mana: Record doorbell physical address in PF mode
https://git.kernel.org/netdev/net/c/e0fca6f2cebf

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html