Skip to contentSkip to conversation

Octeontx2-pf: Fix Backpresure configuration

net Applied Hariprasad Kelam 3 participants 3 messages Jun 17, 2025 – Jun 18, 2025

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

NIX block can receive packets from multiple links such as MAC (RPM), LBK and CPT.

       -----------------
 RPM --|     NIX       |
       -----------------
             |
             |
            LBK

Each link supports multiple channels for example RPM link supports 16 channels. In case of link oversubsribe, NIX will assert backpressure on receive channels.

The previous patch considered a single channel per link, resulting in backpressure not being enabled on the remaining channels

Fixes a7ef63dbd588 ("octeontx2-af: Disable backpressure between CPT and NIX")
---
 drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.c +2 -2
index 6f572589f1e5..6b5c9536d26d 100644
@@ -1822,7 +1822,7 @@ int otx2_nix_config_bp(struct otx2_nic *pfvf, bool enable)
 		req->chan_cnt = IEEE_8021QAZ_MAX_TCS;
 		req->bpid_per_chan = 1;
 	} else {
-		req->chan_cnt = 1;
+		req->chan_cnt = pfvf->hw.rx_chan_cnt;
 		req->bpid_per_chan = 0;
 	}
 
@@ -1847,7 +1847,7 @@ int otx2_nix_cpt_config_bp(struct otx2_nic *pfvf, bool enable)
 		req->chan_cnt = IEEE_8021QAZ_MAX_TCS;
 		req->bpid_per_chan = 1;
 	} else {
-		req->chan_cnt = 1;
+		req->chan_cnt = pfvf->hw.rx_chan_cnt;
 		req->bpid_per_chan = 0;
 	}
 
Signature · 1 line
2.34.1
reviewer Reviewed-by
#1 lore raw
Quoted 14 lines · Hariprasad Kelam

NIX block can receive packets from multiple links such as MAC (RPM), LBK and CPT.

       -----------------
 RPM --|     NIX       |
       -----------------
             |
             |
            LBK

Each link supports multiple channels for example RPM link supports 16 channels. In case of link oversubsribe, NIX will assert backpressure on receive channels.

Quoted 5 lines

The previous patch considered a single channel per link, resulting in backpressure not being enabled on the remaining channels

Fixes a7ef63dbd588 ("octeontx2-af: Disable backpressure between CPT and NIX")
#2 lore raw
In reply to Hariprasad Kelam
This patch was applied to netdev/net.git (main) by Jakub Kicinski <[email protected]>:

Hello:

This patch was applied to netdev/net.git (main)
by Jakub Kicinski <[email protected]>:

Quoted 11 lines · On Tue, 17 Jun 2025 12:04:02 +0530 you wrote:

NIX block can receive packets from multiple links such as MAC (RPM), LBK and CPT.

       -----------------
 RPM --|     NIX       |
       -----------------
             |
             |
            LBK

[...]

Here is the summary with links:
- [net] Octeontx2-pf: Fix Backpresure configuration

    https://git.kernel.org/netdev/net/c/9ac8d0c640a1

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html