bond: fix stack smash in xstats
Subsystems (2)
PATCH 1/1 bond: fix stack smash in xstats
Building with stack smashing detection finds an off by one in the bond xstats attribute parsing.
$ ip link xstats type bond dev bond0
[Thread debugging using libthread_db enabled]
Using host libthread_db library "/lib/x86_64-linux-gnu/libthread_db.so.1".
bond0
LACPDU Rx 0
LACPDU Tx 0
LACPDU Unknown type Rx 0
LACPDU Illegal Rx 0
Marker Rx 0
Marker Tx 0
Marker response Rx 0
Marker response Tx 0
Marker unknown type Rx 0
*** stack smashing detected ***: terminatedProgram received signal SIGABRT, Aborted.
Reported-by z30015464 <[email protected]>
Fixes 440c5075d662 ("ip: bond: add xstats support")
Signed-off-by Stephen Hemminger <[email protected]>
--- ip/iplink_bond.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
ip/iplink_bond.c +1 -1
@@ -852,7 +852,7 @@ static void bond_print_stats_attr(struct rtattr *attr, int ifindex)const char *ifname ="" ;int rem; -parse_rtattr (bondtb,LINK_XSTATS_TYPE_MAX +1 ,RTA_DATA (attr), +parse_rtattr (bondtb,LINK_XSTATS_TYPE_MAX ,RTA_DATA (attr),RTA_PAYLOAD (attr));if (!bondtb[LINK_XSTATS_TYPE_BOND ])return ;
Signature · 1 line
2.47.2
Quoted 33 lines · Stephen Hemminger
Building with stack smashing detection finds an off by one in the bond xstats attribute parsing.
$ ip link xstats type bond dev bond0 [Thread debugging using libthread_db enabled] Using host libthread_db library "/lib/x86_64-linux-gnu/libthread_db.so.1". bond0 LACPDU Rx 0 LACPDU Tx 0 LACPDU Unknown type Rx 0 LACPDU Illegal Rx 0 Marker Rx 0 Marker Tx 0 Marker response Rx 0 Marker response Tx 0 Marker unknown type Rx 0 *** stack smashing detected ***: terminatedProgram received signal SIGABRT, Aborted.
Reported-by z30015464 <[email protected]>Fixes 440c5075d662 ("ip: bond: add xstats support")Signed-off-by Stephen Hemminger <[email protected]>--- ip/iplink_bond.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)ip/iplink_bond.c +0
-0
ip/iplink_bond.c static void bond_print_stats_attr(struct rtattr *attr, int ifindex) · line 858
Quoted 8 lines
ip/iplink_bond.c +1
-1@@ -852,7 +852,7 @@ static void bond_print_stats_attr(struct rtattr *attr, int ifindex)const char *ifname ="" ;int rem; -parse_rtattr (bondtb,LINK_XSTATS_TYPE_MAX +1 ,RTA_DATA (attr), +parse_rtattr (bondtb,LINK_XSTATS_TYPE_MAX ,RTA_DATA (attr),RTA_PAYLOAD (attr));if (!bondtb[LINK_XSTATS_TYPE_BOND ])return ;
Oops :)
This patch was applied to iproute2/iproute2.git (main) by Stephen Hemminger <[email protected]>:
Hello:
This patch was applied to iproute2/iproute2.git (main) by Stephen Hemminger <[email protected]>:
Quoted 18 lines · On Thu, 26 Jun 2025 07:01:25 -0700 you wrote:
Building with stack smashing detection finds an off by one in the bond xstats attribute parsing.
$ ip link xstats type bond dev bond0 [Thread debugging using libthread_db enabled] Using host libthread_db library "/lib/x86_64-linux-gnu/libthread_db.so.1". bond0 LACPDU Rx 0 LACPDU Tx 0 LACPDU Unknown type Rx 0 LACPDU Illegal Rx 0 Marker Rx 0 Marker Tx 0 Marker response Rx 0 Marker response Tx 0 Marker unknown type Rx 0 *** stack smashing detected ***: terminated
Quoted 1 line
[...]
Here is the summary with links:
- [iproute2] bond: fix stack smash in xstats
https://git.kernel.org/pub/scm/network/iproute2/iproute2.git/commit/?id=ede5e0b67c13
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html