Skip to contentSkip to conversation

rust: Ignore preserve-most functions

PATCH Applied Matthew Maurer 4 participants 4 messages Oct 31, 2023 – Dec 13, 2023 Rust

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 rust: Ignore preserve-most functions

Neither bindgen nor Rust know about the preserve-most calling convention, and Clang describes it as unstable. Since we aren't using functions with this calling convention from Rust, blocklist them.

These functions are only added to the build when list hardening is enabled, which is likely why others didn't notice this yet.

---
 rust/bindgen_parameters | 4 ++++
 1 file changed, 4 insertions(+)
rust/bindgen_parameters +4 -0
index 552d9a85925b..8d9f82d350b8 100644
@@ -20,3 +20,7 @@
 
 # `seccomp`'s comment gets understood as a doctest
 --no-doc-comments
+
+# These functions use the __preserve_most calling convention, which neither bindgen
+# nor Rust currently understand, and which Clang currently declares to be unstable.
+--blocklist-function __list_.*_report
Signature · 1 line
2.42.0.820.g83a721a137-goog
reviewer Reviewed-by on v1 1/1
#1 lore raw
Quoted 9 lines · Matthew Maurer

Neither bindgen nor Rust know about the preserve-most calling convention, and Clang describes it as unstable. Since we aren't using functions with this calling convention from Rust, blocklist them.

These functions are only added to the build when list hardening is enabled, which is likely why others didn't notice this yet.

Reviewed-by on v1 1/1
#2 lore raw
In reply to Matthew Maurer
Quoted 10 lines · Matthew Maurer

Neither bindgen nor Rust know about the preserve-most calling convention, and Clang describes it as unstable. Since we aren't using functions with this calling convention from Rust, blocklist them.

These functions are only added to the build when list hardening is enabled, which is likely why others didn't notice this yet.

---
[...]

Applied
#3 lore raw
In reply to Matthew Maurer
Quoted 9 lines · Matthew Maurer

Neither bindgen nor Rust know about the preserve-most calling convention, and Clang describes it as unstable. Since we aren't using functions with this calling convention from Rust, blocklist them.

These functions are only added to the build when list hardening is enabled, which is likely why others didn't notice this yet.

Applied to rust-next (used Markdown for consistency with the other comments in the file).

Thanks everyone!

Cheers,
Miguel