hv_sock: Return the readable bytes in hvs_stream_has_data()
Subsystems (6)
Dexuan Cui
maintainerPATCH 1/1 hv_sock: Return the readable bytes in hvs_stream_has_data()
When hv_sock was originally added, __vsock_stream_recvmsg() and vsock_stream_has_data() actually only needed to know whether there is any readable data or not, so hvs_stream_has_data() was written to return 1 or 0 for simplicity.
However, now hvs_stream_has_data() should return the readable bytes because vsock_data_ready() -> vsock_stream_has_data() needs to know the actual bytes rather than a boolean value of 1 or 0.
The SIOCINQ ioctl support also needs hvs_stream_has_data() to return the readable bytes.
Let hvs_stream_has_data() return the readable bytes of the payload in the next host-to-guest VMBus hv_sock packet.
Note: there may be multpile incoming hv_sock packets pending in the VMBus channel's ringbuffer, but so far there is not a VMBus API that allows us to know all the readable bytes in total without reading and caching the payload of the multiple packets, so let's just return the readable bytes of the next single packet. In the future, we'll either add a VMBus API that allows us to know the total readable bytes without touching the data in the ringbuffer, or the hv_sock driver needs to understand the VMBus packet format and parse the packets directly.
---
Hi maintainers, please don't take the patch for now.
Hi Xuewei Niu, please help to re-post this patch with the next version of your patchset "vsock: Introduce SIOCINQ ioctl support". See
https://lore.kernel.org/virtualization/BL1PR21MB3115F69C544B0FAA145FA4EABF7BA@BL1PR21MB3115.namprd21.prod.outlook.com/#t
https://lore.kernel.org/virtualization/[email protected]/
Feel free to add your Signed-off-by, if you need.
net/vmw_vsock/hyperv_transport.c | 16 +++++++++++++--- 1 file changed, 13 insertions(+), 3 deletions(-)
net/vmw_vsock/hyperv_transport.c +13 -3
@@ -694,15 +694,25 @@ static ssize_t hvs_stream_enqueue(struct vsock_sock *vsk, struct msghdr *msg,static s64 hvs_stream_has_data (struct vsock_sock *vsk) {struct hvsock *hvs = vsk->trans; +bool need_refill = !hvs->recv_desc;s64 ret;if (hvs->recv_data_len >0 ) -return 1 ; +return hvs->recv_data_len;switch (hvs_channel_readable_payload (hvs->chan)) {case 1 : - ret =1 ; -break ; +if (!need_refill) +return -EIO ; + + hvs->recv_desc =hv_pkt_iter_first (hvs->chan); +if (!hvs->recv_desc) +return -ENOBUFS ; + + ret =hvs_update_recv_data (hvs); +if (ret) +return ret; +return hvs->recv_data_len;case 0 : vsk->peer_shutdown |=SEND_SHUTDOWN ; ret =0 ;
Signature · 1 line
2.49.0
Paolo Abeni
maintainerQuoted 43 lines · Dexuan Cui
When
hv_sockwas originally added,__vsock_stream_recvmsg()andvsock_stream_has_data()actually only needed to know whether there is any readable data or not, sohvs_stream_has_data()was written to return 1 or 0 for simplicity.However, now
hvs_stream_has_data()should return the readable bytes becausevsock_data_ready()->vsock_stream_has_data()needs to know the actual bytes rather than a boolean value of 1 or 0.The SIOCINQ ioctl support also needs
hvs_stream_has_data()to return the readable bytes.Let
hvs_stream_has_data()return the readable bytes of the payload in the next host-to-guest VMBushv_sockpacket.Note: there may be multpile incoming
hv_sockpackets pending in the VMBus channel's ringbuffer, but so far there is not a VMBus API that allows us to know all the readable bytes in total without reading and caching the payload of the multiple packets, so let's just return the readable bytes of the next single packet. In the future, we'll either add a VMBus API that allows us to know the total readable bytes without touching the data in the ringbuffer, or thehv_sockdriver needs to understand the VMBus packet format and parse the packets directly.Signed-off-by Dexuan Cui <[email protected]>---
Hi maintainers, please don't take the patch for now.
Hi Xuewei Niu, please help to re-post this patch with the next version of your patchset "vsock: Introduce SIOCINQ ioctl support". See
https://lore.kernel.org/virtualization/BL1PR21MB3115F69C544B0FAA145FA4EABF7BA@BL1PR21MB3115.namprd21.prod.outlook.com/#t
https://lore.kernel.org/virtualization/[email protected]/
Feel free to add your Signed-off-by, if you need.net/vmw_vsock/hyperv_transport.c | 16 +++++++++++++--- 1 file changed, 13 insertions(+), 3 deletions(-)net/vmw_vsock/hyperv_transport.c +0
-0
net/vmw_vsock/hyperv_transport.c static ssize_t hvs_stream_enqueue(struct vsock_sock *vsk, struct msghdr *msg, · line 698
Quoted 5 lines
net/vmw_vsock/hyperv_transport.c +1
-0@@ -694,15 +694,25 @@ static ssize_t hvs_stream_enqueue(struct vsock_sock *vsk, struct msghdr *msg,static s64 hvs_stream_has_data (struct vsock_sock *vsk) {struct hvsock *hvs = vsk->trans; +bool need_refill = !hvs->recv_desc;s64 ret;
Minor nit: when reposting please respect the reverse christmas tree order above moving 'need_refill' initialization after the following 'if' statement.
/P
Dexuan Cui
maintainerQuoted 13 lines
From: Paolo Abeni <[email protected]>
Sent: Tuesday, July 1, 2025 6:05 AM
...net/vmw_vsock/hyperv_transport.c static ssize_t hvs_stream_enqueue(struct vsock_sock *vsk, struct msghdr *msg, · line 698
Quoted 5 lines
static s64
hvs_stream_has_data(struct vsock_sock *vsk){net/vmw_vsock/hyperv_transport.c +1
-0struct hvsock *hvs = vsk->trans; +bool need_refill = !hvs->recv_desc;s64 ret;Minor nit: when reposting please respect the reverse christmas tree order above moving '
need_refill' initialization after the following 'if' statement.
Quoted 1 line
/P
Thanks! Will do.