ata: libata-eh: use bool for fastdrain in ata_eh_set_pending()
Damien Le Moal
maintainerPATCH 1/1 ata: libata-eh: use bool for fastdrain in ata_eh_set_pending()
Use the bool type for the fastdrain argmuent of ata_eh_set_pending(), as it should be.
No functional changes.
Signed-off-by Damien Le Moal <[email protected]>
--- drivers/ata/libata-eh.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
drivers/ata/libata-eh.c +4 -4
@@ -907,7 +907,7 @@ void ata_eh_fastdrain_timerfn(struct timer_list *t)* LOCKING: * spin_lock_irqsave(host lock) */ -static void ata_eh_set_pending (struct ata_port *ap,int fastdrain) +static void ata_eh_set_pending (struct ata_port *ap,bool fastdrain) {unsigned int cnt;
@@ -947,7 +947,7 @@ void ata_qc_schedule_eh(struct ata_queued_cmd *qc)struct ata_port *ap = qc->ap; qc->flags |=ATA_QCFLAG_EH ; -ata_eh_set_pending (ap,1 ); +ata_eh_set_pending (ap, true);/* The following will fail if timeout has already expired. * ata_scsi_error() takes care of such scmds on EH entry.
@@ -969,7 +969,7 @@ void ata_std_sched_eh(struct ata_port *ap)if (ap->pflags &ATA_PFLAG_INITIALIZING )return ; -ata_eh_set_pending (ap,1 ); +ata_eh_set_pending (ap, true);scsi_schedule_eh (ap->scsi_host);trace_ata_std_sched_eh (ap);
@@ -1020,7 +1020,7 @@ static int ata_do_link_abort(struct ata_port *ap, struct ata_link *link)int tag, nr_aborted =0 ;/* we're gonna abort all commands, no need for fast drain */ -ata_eh_set_pending (ap,0 ); +ata_eh_set_pending (ap, false);/* include internal tag in iteration */ ata_qc_for_each_with_internal (ap, qc, tag) {
Signature · 1 line
2.50.0
Quoted 1 line · Damien Le Moal
Use the bool type for the fastdrain argmuent of
ata_eh_set_pending(), as
s/argmuent/argument/
Quoted 5 lines
it should be.
No functional changes.
Signed-off-by Damien Le Moal <[email protected]>
Reviewed-by Niklas Cassel <[email protected]>
Quoted 6 lines · Damien Le Moal
Use the bool type for the fastdrain argmuent of
ata_eh_set_pending(), as it should be.No functional changes.
Applied to libata/linux.git (for-6.17), thanks!
[1/1] ata: libata-eh: use bool for fastdrain in ata_eh_set_pending()
https://git.kernel.org/libata/linux/c/c5fccfe9
Kind regards,
Niklas