f2fs: check the generic conditions first
Jaegeuk Kim
maintainerPATCH 1/1 f2fs: check the generic conditions first
Let's return errors caught by the generic checks. This fixes generic/494 where it expects to see EBUSY by setattr_prepare instead of EINVAL by f2fs for active swapfile.
--- fs/f2fs/file.c | 24 ++++++++++++------------ 1 file changed, 12 insertions(+), 12 deletions(-)
fs/f2fs/file.c +12 -12
@@ -1048,6 +1048,18 @@ int f2fs_setattr(struct mnt_idmap *idmap, struct dentry *dentry,if (unlikely (f2fs_cp_error (sbi)))return -EIO ; + err =setattr_prepare (idmap, dentry, attr); +if (err) +return err; + + err =fscrypt_prepare_setattr (dentry, attr); +if (err) +return err; + + err =fsverity_prepare_setattr (dentry, attr); +if (err) +return err; +if (unlikely (IS_IMMUTABLE (inode)))return -EPERM ;
@@ -1077,18 +1089,6 @@ int f2fs_setattr(struct mnt_idmap *idmap, struct dentry *dentry,return -EINVAL ; } - err =setattr_prepare (idmap, dentry, attr); -if (err) -return err; - - err =fscrypt_prepare_setattr (dentry, attr); -if (err) -return err; - - err =fsverity_prepare_setattr (dentry, attr); -if (err) -return err; -if (is_quota_modification (idmap, inode, attr)) { err =f2fs_dquot_initialize (inode);if (err)
Signature · 1 line
2.50.0.727.gbf7dc18ff4-goog
Quoted 5 lines · On 7/1/25 00:08, Jaegeuk Kim via Linux-f2fs-devel wrote:
Let's return errors caught by the generic checks. This fixes generic/494 where it expects to see EBUSY by
setattr_prepareinstead of EINVAL by f2fs for active swapfile.Signed-off-by Jaegeuk Kim <[email protected]>
Thanks,
This patch was applied to jaegeuk/f2fs.git (dev) by Jaegeuk Kim <[email protected]>:
Hello:
This patch was applied to jaegeuk/f2fs.git (dev)
by Jaegeuk Kim <[email protected]>:
Quoted 8 lines · On Mon, 30 Jun 2025 16:08:38 +0000 you wrote:
Let's return errors caught by the generic checks. This fixes generic/494 where it expects to see EBUSY by
setattr_prepareinstead of EINVAL by f2fs for active swapfile.Signed-off-by Jaegeuk Kim <[email protected]>--- fs/f2fs/file.c | 24 ++++++++++++------------ 1 file changed, 12 insertions(+), 12 deletions(-)
Here is the summary with links:
- [f2fs-dev] f2fs: check the generic conditions first
https://git.kernel.org/jaegeuk/f2fs/c/e23ab8028de0
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html