selftests/net: packetdrill: add --mss option to three tests
Subsystems (3)
PATCH 1/1 selftests/net: packetdrill: add --mss option to three tests
Three tests are cooking GSO packets but do not provide gso_size information to the kernel, triggering this message:
TCP: tun0: Driver has suspect GRO implementation, TCP performance may be compromised.
Add --mss option to avoid this warning.
--- .../selftests/net/packetdrill/tcp_blocking_blocking-read.pkt | 2 ++ tools/testing/selftests/net/packetdrill/tcp_inq_client.pkt | 3 +++ tools/testing/selftests/net/packetdrill/tcp_inq_server.pkt | 3 +++ 3 files changed, 8 insertions(+)
tools/testing/selftests/net/packetdrill/tcp_blocking_blocking-read.pkt +2 -0
@@ -1,6 +1,8 @@ // SPDX-License-Identifier: GPL-2.0 // Test for blocking read. + --tolerance_usecs=10000 +--mss=1000 `./defaults.sh`
tools/testing/selftests/net/packetdrill/tcp_inq_client.pkt +3 -0
@@ -1,5 +1,8 @@ // SPDX-License-Identifier: GPL-2.0 // Test TCP_INQ and TCP_CM_INQ on the client side. + +--mss=1000 + `./defaults.sh `
tools/testing/selftests/net/packetdrill/tcp_inq_server.pkt +3 -0
@@ -1,5 +1,8 @@ // SPDX-License-Identifier: GPL-2.0 // Test TCP_INQ and TCP_CM_INQ on the server side. + +--mss=1000 + `./defaults.sh `
Signature · 1 line
2.50.0.727.gbf7dc18ff4-goog
Quoted 8 lines · Eric Dumazet
Three tests are cooking GSO packets but do not provide
gso_sizeinformation to the kernel, triggering this message:TCP: tun0: Driver has suspect GRO implementation, TCP performance may be compromised.
Add --mss option to avoid this warning.
Signed-off-by Eric Dumazet <[email protected]>
This is because of this in packetdrill linux_tun_write, I suppose:
if (packet->tcp && packet->mss) {
if (packet->ipv4)
gso.gso_type = VIRTIO_NET_HDR_GSO_TCPV4;
else
gso.gso_type = VIRTIO_NET_HDR_GSO_TCPV6;
gso.gso_size = packet->mss;
}Which seems to imply that setting mss means that all generated packets use GRO. Which tracks with the commit that introduced it: commit 58a7865c47e3 ("net-test: packetdrill: add GRO support to packetdrill"). Which includes
+++ b/gtests/net/packetdrill/config.h
@@ -73,6 +73,7 @@ struct config {
u32 speed; /* speed reported by tun driver;
* may require special tun driver
*/
+ int mss; /* gso_size for GRO packets to tun device */This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <[email protected]>:
Hello:
This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <[email protected]>:
Quoted 8 lines · On Thu, 10 Jul 2025 15:56:41 +0000 you wrote:
Three tests are cooking GSO packets but do not provide
gso_sizeinformation to the kernel, triggering this message:TCP: tun0: Driver has suspect GRO implementation, TCP performance may be compromised.
Add --mss option to avoid this warning.
[...]
Here is the summary with links:
- [net-next] selftests/net: packetdrill: add --mss option to three tests
https://git.kernel.org/netdev/net-next/c/f0600fe94986
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html