selftests/bpf: Fix build error due to certain uninitialized variables
Subsystems (3)
Yonghong Song
reviewerPATCH 1/1 selftests/bpf: Fix build error due to certain uninitialized variables
With the latest llvm21 compiler, I hit several errors when building bpf selftests. Some of errors look like below:
test_maps.c:565:40: error: variable 'val' is uninitialized when passed as a
const pointer argument here [-Werror,-Wuninitialized-const-pointer]
565 | assert(bpf_map_update_elem(fd, NULL, &val, 0) < 0 &&
| ^~~
prog_tests/bpf_iter.c:400:25: error: variable 'c' is uninitialized when passed
as a const pointer argument here [-Werror,-Wuninitialized-const-pointer]
400 | write(finish_pipe[1], &c, 1);
| ^
Some other errors have similar the pattern as the above.
These errors are fixed by initializing those variables properly.
--- tools/testing/selftests/bpf/prog_tests/bloom_filter_map.c | 2 +- tools/testing/selftests/bpf/prog_tests/bpf_iter.c | 2 +- tools/testing/selftests/bpf/prog_tests/uprobe_syscall.c | 2 +- tools/testing/selftests/bpf/prog_tests/verify_pkcs7_sig.c | 2 +- tools/testing/selftests/bpf/test_maps.c | 4 ++-- 5 files changed, 6 insertions(+), 6 deletions(-)
tools/testing/selftests/bpf/prog_tests/bloom_filter_map.c +1 -1
@@ -13,7 +13,7 @@static void test_fail_cases (void ) {LIBBPF_OPTS (bpf_map_create_opts, opts); -__u32 value; +__u32 value =0 ;int fd, err;/* Invalid key size */
tools/testing/selftests/bpf/prog_tests/bpf_iter.c +1 -1
@@ -323,7 +323,7 @@ static void test_task_pidfd(void)static void test_task_sleepable (void ) {struct bpf_iter_tasks *skel; -int pid, status, err, data_pipe[2 ], finish_pipe[2 ], c; +int pid, status, err, data_pipe[2 ], finish_pipe[2 ], c =0 ;char *test_data =NULL ;char *test_data_long =NULL ;char *data[2 ];
tools/testing/selftests/bpf/prog_tests/uprobe_syscall.c +1 -1
@@ -251,7 +251,7 @@ static void test_uretprobe_syscall_call(void) .retprobe = true, );struct uprobe_syscall_executed *skel; -int pid, status, err, go[2 ], c; +int pid, status, err, go[2 ], c =0 ;if (!ASSERT_OK (pipe (go),"pipe" ))return ;
tools/testing/selftests/bpf/prog_tests/verify_pkcs7_sig.c +1 -1
@@ -268,7 +268,7 @@ static void test_verify_pkcs7_sig_from_map(void)char *tmp_dir;struct test_verify_pkcs7_sig *skel =NULL ;struct bpf_map *map; -struct data data; +struct data data = {};int ret, zero =0 ;/* Trigger creation of session keyring. */
tools/testing/selftests/bpf/test_maps.c +2 -2
@@ -535,7 +535,7 @@ static void test_devmap_hash(unsigned int task, void *data)static void test_queuemap (unsigned int task,void *data) {const int MAP_SIZE =32 ; -__u32 vals[MAP_SIZE +MAP_SIZE /2 ], val; +__u32 vals[MAP_SIZE +MAP_SIZE /2 ], val =0 ;int fd, i;/* Fill test values to be used */
@@ -591,7 +591,7 @@ static void test_queuemap(unsigned int task, void *data)static void test_stackmap (unsigned int task,void *data) {const int MAP_SIZE =32 ; -__u32 vals[MAP_SIZE +MAP_SIZE /2 ], val; +__u32 vals[MAP_SIZE +MAP_SIZE /2 ], val =0 ;int fd, i;/* Fill test values to be used */
Signature · 1 line
2.47.1
This patch was applied to bpf/bpf-next.git (master) by Andrii Nakryiko <[email protected]>:
Hello:
This patch was applied to bpf/bpf-next.git (master) by Andrii Nakryiko <[email protected]>:
Quoted 9 lines · On Tue, 15 Jul 2025 11:59:10 -0700 you wrote:
With the latest llvm21 compiler, I hit several errors when building bpf selftests. Some of errors look like below:
test_maps.c:565:40: error: variable 'val' is uninitialized when passed as a
const pointer argument here [-Werror,-Wuninitialized-const-pointer]
565 | assert(bpf_map_update_elem(fd, NULL, &val, 0) < 0 &&
| ^~~[...]
Here is the summary with links:
- [bpf-next] selftests/bpf: Fix build error due to certain uninitialized variables
https://git.kernel.org/bpf/bpf-next/c/e860a98c8aeb
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html