Skip to contentSkip to conversation

usb: net: sierra: check for no status endpoint

PATCH Applied Oliver Neukum 2 participants 2 messages Jul 14, 2025 – Jul 15, 2025

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 usb: net: sierra: check for no status endpoint

The driver checks for having three endpoints and having bulk in and out endpoints, but not that the third endpoint is interrupt input.
Rectify the omission.

Reported-by [email protected]
Fixes eb4fd8cd355c8 ("net/usb: add sierra_net.c driver")
---
 drivers/net/usb/sierra_net.c | 4 ++++
 1 file changed, 4 insertions(+)
drivers/net/usb/sierra_net.c +4 -0
index c30ca415d1d3..36c73db44f77 100644
@@ -689,6 +689,10 @@ static int sierra_net_bind(struct usbnet *dev, struct usb_interface *intf)
 			status);
 		return -ENODEV;
 	}
+	if (!dev->status) {
+		dev_err(&dev->udev->dev, "No status endpoint found");
+		return -ENODEV;
+	}
 	/* Initialize sierra private data */
 	priv = kzalloc(sizeof *priv, GFP_KERNEL);
 	if (!priv)
Signature · 1 line
2.50.0
#1 lore raw
This patch was applied to netdev/net.git (main) by Jakub Kicinski <[email protected]>:

Hello:

This patch was applied to netdev/net.git (main)
by Jakub Kicinski <[email protected]>:

Quoted 5 lines · On Mon, 14 Jul 2025 13:12:56 +0200 you wrote:

The driver checks for having three endpoints and having bulk in and out endpoints, but not that the third endpoint is interrupt input.
Rectify the omission.

Quoted 7 lines
Reported-by [email protected]
Fixes eb4fd8cd355c8 ("net/usb: add sierra_net.c driver")

[...]

Here is the summary with links:
- [net] usb: net: sierra: check for no status endpoint

    https://git.kernel.org/netdev/net/c/4c4ca3c46167

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html