Bluetooth: hci_sync: Avoid adding default advertising on startup
Subsystems (2)
PATCH 1/1 Bluetooth: hci_sync: Avoid adding default advertising on startup
list_empty(&hdev->adv_instances) is always true during startup, so an advertising instance is added by default.
Call trace: dump_backtrace+0x94/0xec show_stack+0x18/0x24 dump_stack_lvl+0x48/0x60 dump_stack+0x18/0x24 hci_setup_ext_adv_instance_sync+0x17c/0x328 hci_powered_update_adv_sync+0xb4/0x12c hci_powered_update_sync+0x54/0x70 hci_power_on_sync+0xe4/0x278 hci_set_powered_sync+0x28/0x34 set_powered_sync+0x40/0x58 hci_cmd_sync_work+0x94/0x100 process_one_work+0x168/0x444 worker_thread+0x378/0x3f4 kthread+0x108/0x10c ret_from_fork+0x10/0x20
--- net/bluetooth/hci_sync.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
net/bluetooth/hci_sync.c +1 -1
@@ -3344,7 +3344,7 @@ static int hci_powered_update_adv_sync(struct hci_dev *hdev)* advertising data. This also applies to the case * where BR/EDR was toggled during the AUTO_OFF phase. */ -if (hci_dev_test_flag (hdev,HCI_ADVERTISING ) || +if (hci_dev_test_flag (hdev,HCI_ADVERTISING ) &&list_empty (&hdev->adv_instances)) {if (ext_adv_capable (hdev)) { err =hci_setup_ext_adv_instance_sync (hdev,0x00 );
---
base-commit: d1b3de23042b0aac0145fdf071d6ac81ec3727b4
change-id: 20250728-default_adv-c5547ad3bcd2
Best regards,
Signature · 1 line
Yang Li <[email protected]>
This is automated email and please do not reply to this email!
Dear submitter,
Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=986353
---Test result---
Test Summary:
CheckPatch PENDING 0.30 seconds GitLint PENDING 0.22 seconds SubjectPrefix PASS 0.12 seconds BuildKernel PASS 24.29 seconds CheckAllWarning PASS 26.85 seconds CheckSparse PASS 30.32 seconds BuildKernel32 PASS 24.24 seconds TestRunnerSetup PASS 479.76 seconds TestRunner_l2cap-tester PASS 25.20 seconds TestRunner_iso-tester PASS 37.78 seconds TestRunner_bnep-tester PASS 6.07 seconds TestRunner_mgmt-tester PASS 129.69 seconds TestRunner_rfcomm-tester PASS 9.38 seconds TestRunner_sco-tester PASS 14.65 seconds TestRunner_ioctl-tester PASS 9.96 seconds TestRunner_mesh-tester FAIL 11.57 seconds TestRunner_smp-tester PASS 8.61 seconds TestRunner_userchan-tester PASS 6.26 seconds IncrementalBuild PENDING 0.84 seconds
Details
##############################
Test: CheckPatch - PENDING
Desc: Run checkpatch.pl script Output:
##############################
Test: GitLint - PENDING
Desc: Run gitlint
Output:
##############################
Test: TestRunner_mesh-tester - FAIL
Desc: Run mesh-tester with test-runner Output:
Total: 10, Passed: 8 (80.0%), Failed: 2, Not Run: 0
Failed Test Cases
Mesh - Send cancel - 1 Timed out 2.116 seconds Mesh - Send cancel - 2 Timed out 1.998 seconds
##############################
Test: IncrementalBuild - PENDING
Desc: Incremental build with the patches in the series Output:
---
Regards,
Linux Bluetooth
This patch was applied to bluetooth/bluetooth-next.git (master) by Luiz Augusto von Dentz <[email protected]>:
Hello:
This patch was applied to bluetooth/bluetooth-next.git (master) by Luiz Augusto von Dentz <[email protected]>:
Quoted 22 lines · On Mon, 28 Jul 2025 17:08:44 +0800 you wrote:
From: Yang Li <[email protected]>
list_empty(&hdev->adv_instances)is always true during startup, so an advertising instance is added by default.Call trace: dump_backtrace+0x94/0xec show_stack+0x18/0x24 dump_stack_lvl+0x48/0x60 dump_stack+0x18/0x24 hci_setup_ext_adv_instance_sync+0x17c/0x328 hci_powered_update_adv_sync+0xb4/0x12c hci_powered_update_sync+0x54/0x70 hci_power_on_sync+0xe4/0x278 hci_set_powered_sync+0x28/0x34 set_powered_sync+0x40/0x58 hci_cmd_sync_work+0x94/0x100 process_one_work+0x168/0x444 worker_thread+0x378/0x3f4 kthread+0x108/0x10c ret_from_fork+0x10/0x20
Quoted 1 line
[...]
Here is the summary with links:
- Bluetooth: hci_sync: Avoid adding default advertising on startup
https://git.kernel.org/bluetooth/bluetooth-next/c/b88313f2a6c3
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html