x86/hyperv: Cosmetic changes for hv_utils_transport.c
Subsystems (2)
PATCH 1/1 x86/hyperv: Cosmetic changes for hv_utils_transport.c
Fix issues reported by checkpatch.pl script for hv_utils_transport.c file
- Update pr_warn() calls to use __func__ for consistent logging context.
- else should follow close brace '}'
No functional changes intended.
--- drivers/hv/hv_utils_transport.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)
drivers/hv/hv_utils_transport.c +5 -5
@@ -129,8 +129,7 @@ static int hvt_op_open(struct inode *inode, struct file *file)* device gets released. */ hvt->mode =HVUTIL_TRANSPORT_CHARDEV ; - } -else if (hvt->mode ==HVUTIL_TRANSPORT_NETLINK ) { + }else if (hvt->mode ==HVUTIL_TRANSPORT_NETLINK ) {/* * We're switching from netlink communication to using char * device. Issue the reset first.
@@ -195,7 +194,7 @@ static void hvt_cn_callback(struct cn_msg *msg, struct netlink_skb_parms *nsp) }spin_unlock (&hvt_list_lock);if (!hvt_found) { -pr_warn ("hvt_cn_callback: spurious message received!\n" ); +pr_warn ("%s: spurious message received!\n" , __func__);return ; }
@@ -210,7 +209,7 @@ static void hvt_cn_callback(struct cn_msg *msg, struct netlink_skb_parms *nsp)if (hvt->mode ==HVUTIL_TRANSPORT_NETLINK ) hvt_found->on_msg (msg->data, msg->len);else -pr_warn ("hvt_cn_callback: unexpected netlink message!\n" ); +pr_warn ("%s: unexpected netlink message!\n" , __func__);mutex_unlock (&hvt->lock); }
@@ -260,8 +259,9 @@ int hvutil_transport_send(struct hvutil_transport *hvt, void *msg, int len, hvt->outmsg_len = len; hvt->on_read = on_read_cb;wake_up_interruptible (&hvt->outmsg_q); - }else + }else { ret = -ENOMEM ; + } out_unlock:mutex_unlock (&hvt->lock);return ret;
Signature · 1 line
2.43.0
Quoted 7 lines · Abhishek Tiwari
Fix issues reported by checkpatch.pl script for
hv_utils_transport.cfile
- Updatepr_warn()calls to use__func__for consistent logging context.
- else should follow close brace '}'No functional changes intended.
Signed-off-by Abhishek Tiwari <[email protected]>
Please use a different prefix for Subject.
Replace "x86/hyperv:" with "Drivers: hv: util:"
We generally follow the naming practice used for a file, which can be seen in git log <file_path>.
Rest LGTM. Post above change:
Regards,
Naman
Quoted 14 lines · Naman Jain
Quoted 7 lines · Abhishek Tiwari
Fix issues reported by checkpatch.pl script for
hv_utils_transport.cfile
- Updatepr_warn()calls to use__func__for consistent logging context.
- else should follow close brace '}'No functional changes intended.
Signed-off-by Abhishek Tiwari <[email protected]>Please use a different prefix for Subject.
Replace "x86/hyperv:" with "Drivers: hv: util:"
Quoted 8 lines
We generally follow the naming practice used for a file, which can be seen in git log <
file_path>.Rest LGTM. Post above change:
Reviewed-by Naman Jain <[email protected]>Regards,
Naman
Sure, thanks.
I will do the suggested commit message changes in the v2 patch.
Regards,
Abhishek.