Skip to contentSkip to conversation

netlink: specs: ethtool: fix module EEPROM input/output arguments

PATCH Applied Jakub Kicinski 3 participants 3 messages Jul 30, 2025 – Jul 31, 2025

Subsystems (4)
lore
Share & tools
lore

Jakub Kicinski

author maintainer
#0 lore raw

PATCH 1/1 netlink: specs: ethtool: fix module EEPROM input/output arguments

Module (SFP) eeprom GET has a lot of input params, they are all mistakenly listed as output in the spec. Looks like kernel doesn't output them at all. Correct what are the inputs and what the outputs.

Fixes a353318ebf24 ("tools: ynl: populate most of the ethtool spec")

---
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]

---
 Documentation/netlink/specs/ethtool.yaml | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
Documentation/netlink/specs/ethtool.yaml +3 -3
index 1063d5d32fea..1bc1bd7d33c2 100644
@@ -2342,9 +2342,6 @@ c-version-name: ethtool-genl-version
 
       do: &module-eeprom-get-op
         request:
-          attributes:
-            - header
-        reply:
           attributes:
             - header
             - offset
@@ -2352,6 +2349,9 @@ c-version-name: ethtool-genl-version
             - page
             - bank
             - i2c-address
+        reply:
+          attributes:
+            - header
             - data
       dump: *module-eeprom-get-op
     -
Signature · 1 line
2.50.1
Acked-by on v1 1/1
#1 lore raw
Quoted 7 lines · Jakub Kicinski

Module (SFP) eeprom GET has a lot of input params, they are all mistakenly listed as output in the spec. Looks like kernel doesn't output them at all. Correct what are the inputs and what the outputs.

Fixes a353318ebf24 ("tools: ynl: populate most of the ethtool spec")

(seems to match what eeprom_parse_request and eeprom_fill_reply are doing)

#2 lore raw
In reply to Jakub Kicinski
This patch was applied to netdev/net.git (main) by Jakub Kicinski <[email protected]>:

Hello:

This patch was applied to netdev/net.git (main)
by Jakub Kicinski <[email protected]>:

Quoted 9 lines · On Wed, 30 Jul 2025 10:21:37 -0700 you wrote:

Module (SFP) eeprom GET has a lot of input params, they are all mistakenly listed as output in the spec. Looks like kernel doesn't output them at all. Correct what are the inputs and what the outputs.

Fixes a353318ebf24 ("tools: ynl: populate most of the ethtool spec")

[...]

Here is the summary with links:
- [net] netlink: specs: ethtool: fix module EEPROM input/output arguments

    https://git.kernel.org/netdev/net/c/010510128873

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html