Skip to contentSkip to conversation

sfc: unfix not-a-typo in comment

PATCH Applied [email protected] 3 participants 3 messages Jul 31, 2025 – Aug 1, 2025

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 sfc: unfix not-a-typo in comment

From: Edward Cree <[email protected]>

Cited commit removed duplicated word 'fallback', but this was not a
typo and change altered the semantic meaning of the comment.
Partially revert, using the phrase 'fallback of the fallback' to make
the meaning more clear to future readers so that they won't try to change it again.

Fixes fe09560f8241 ("net: Fix typos")
---
 drivers/net/ethernet/sfc/tc_encap_actions.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/ethernet/sfc/tc_encap_actions.c +1 -1
index 2258f854e5be..e872f926e438 100644
@@ -442,7 +442,7 @@ static void efx_tc_update_encap(struct efx_nic *efx,
 			rule = container_of(acts, struct efx_tc_flow_rule, acts);
 			if (rule->fallback)
 				fallback = rule->fallback;
-			else /* fallback: deliver to PF */
+			else /* fallback of the fallback: deliver to PF */
 				fallback = &efx->tc->facts.pf;
 			rc = efx_mae_update_rule(efx, fallback->fw_id,
 						 rule->fw_id);
reviewer Reviewed-by on v1 1/1
#1 lore raw
Quoted 10 lines · On Thu, Jul 31, 2025 at 03:41:38PM +0100, [email protected] wrote:

From: Edward Cree <[email protected]>

Cited commit removed duplicated word 'fallback', but this was not a
typo and change altered the semantic meaning of the comment.
Partially revert, using the phrase 'fallback of the fallback' to make
the meaning more clear to future readers so that they won't try to change it again.

Fixes fe09560f8241 ("net: Fix typos")

Thanks Edward,

And sorry for not noticing this in my review of the cited commit.

#2 lore raw
In reply to [email protected]
This patch was applied to netdev/net.git (main) by Jakub Kicinski <[email protected]>:

Hello:

This patch was applied to netdev/net.git (main)
by Jakub Kicinski <[email protected]>:

Quoted 9 lines · On Thu, 31 Jul 2025 15:41:38 +0100 you wrote:

From: Edward Cree <[email protected]>

Cited commit removed duplicated word 'fallback', but this was not a
typo and change altered the semantic meaning of the comment.
Partially revert, using the phrase 'fallback of the fallback' to make
the meaning more clear to future readers so that they won't try to change it again.

[...]

Here is the summary with links:
- [net-next] sfc: unfix not-a-typo in comment

    https://git.kernel.org/netdev/net/c/60bda1ba062a

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html