net/sched: mqprio: fix stack out-of-bounds write in tc entry parsing
Subsystems (3)
Jakub Kicinski
maintainerPATCH v3 1/1 net/sched: mqprio: fix stack out-of-bounds write in tc entry parsing
From: Maher Azzouzi <[email protected]>
TCA_MQPRIO_TC_ENTRY_INDEX is validated using NLA_POLICY_MAX(NLA_U32, TC_QOPT_MAX_QUEUE), which allows the value TC_QOPT_MAX_QUEUE (16). This leads to a 4-byte out-of-bounds stack write in the fp[] array, which only has room for 16 elements (0–15).
Fix this by changing the policy to allow only up to TC_QOPT_MAX_QUEUE - 1.
---
v3: repost for Maher, email problems..
v2: https://lore.kernel.org/CAFQ-Uc-5ucm+Dyt2s4vV5AyJKjamF=7E_wCWFROYubR5E1PMUg@mail.gmail.com
v2: https://lore.kernel.org/CANn89iJNKR8uBNrRCdqs-M6RspvgSK9+vxzfvXe3xUvDT538Lw@mail.gmail.com
v1: https://lore.kernel.org/[email protected]
--- net/sched/sch_mqprio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
net/sched/sch_mqprio.c +1 -1
@@ -152,7 +152,7 @@ static int mqprio_parse_opt(struct net_device *dev, struct tc_mqprio_qopt *qopt,static const struct nla_policy mqprio_tc_entry_policy[TCA_MQPRIO_TC_ENTRY_MAX +1 ] = { [TCA_MQPRIO_TC_ENTRY_INDEX ] =NLA_POLICY_MAX (NLA_U32 , -TC_QOPT_MAX_QUEUE ), +TC_QOPT_MAX_QUEUE -1 ), [TCA_MQPRIO_TC_ENTRY_FP ] =NLA_POLICY_RANGE (NLA_U32 ,TC_FP_EXPRESS ,TC_FP_PREEMPTIBLE ),
Signature · 1 line
2.50.1
Quoted 13 lines · Jakub Kicinski
From: Maher Azzouzi <[email protected]>
TCA_MQPRIO_TC_ENTRY_INDEXis validated usingNLA_POLICY_MAX(NLA_U32, TC_QOPT_MAX_QUEUE), which allows the valueTC_QOPT_MAX_QUEUE(16). This leads to a 4-byte out-of-bounds stack write in the fp[] array, which only has room for 16 elements (0–15).Fix this by changing the policy to allow only up to
TC_QOPT_MAX_QUEUE- 1.Fixes f62af20bed2d ("net/sched: mqprio: allow per-TC user input of FP adminStatus")Reviewed-by Eric Dumazet <[email protected]>Signed-off-by Maher Azzouzi <[email protected]>Signed-off-by Jakub Kicinski <[email protected]>
Quoted 5 lines
---
v3: repost for Maher, email problems..
v2: https://lore.kernel.org/CAFQ-Uc-5ucm+Dyt2s4vV5AyJKjamF=7E_wCWFROYubR5E1PMUg@mail.gmail.com
v2: https://lore.kernel.org/CANn89iJNKR8uBNrRCdqs-M6RspvgSK9+vxzfvXe3xUvDT538Lw@mail.gmail.com
v1: https://lore.kernel.org/[email protected]
This patch was applied to netdev/net.git (main) by Jakub Kicinski <[email protected]>:
Hello:
This patch was applied to netdev/net.git (main)
by Jakub Kicinski <[email protected]>:
Quoted 8 lines · On Fri, 1 Aug 2025 17:18:57 -0700 you wrote:
From: Maher Azzouzi <[email protected]>
TCA_MQPRIO_TC_ENTRY_INDEXis validated usingNLA_POLICY_MAX(NLA_U32, TC_QOPT_MAX_QUEUE), which allows the valueTC_QOPT_MAX_QUEUE(16). This leads to a 4-byte out-of-bounds stack write in the fp[] array, which only has room for 16 elements (0–15).[...]
Here is the summary with links:
- [net,v3] net/sched: mqprio: fix stack out-of-bounds write in tc entry parsing
https://git.kernel.org/netdev/net/c/ffd2dc4c6c49
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html