caif: Replace memset(0) + strscpy() with strscpy_pad()
Subsystems (2)
PATCH 1/1 caif: Replace memset(0) + strscpy() with strscpy_pad()
Replace memset(0) followed by strscpy() with strscpy_pad() to improve cfctrl_linkup_request(). This avoids zeroing the memory before copying the string and ensures the destination buffer is only written to once, simplifying the code and improving efficiency.
--- net/caif/cfctrl.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
net/caif/cfctrl.c +1 -3
@@ -257,9 +257,7 @@ int cfctrl_linkup_request(struct cflayer *layer,cfpkt_add_body (pkt, &tmp16,2 ); tmp16 =cpu_to_le16 (param->u.utility.fifosize_bufs);cfpkt_add_body (pkt, &tmp16,2 ); -memset (utility_name,0 ,sizeof (utility_name)); -strscpy (utility_name, param->u.utility.name, -UTILITY_NAME_LENGTH ); +strscpy_pad (utility_name, param->u.utility.name);cfpkt_add_body (pkt, utility_name,UTILITY_NAME_LENGTH ); tmp8 = param->u.utility.paramlen;cfpkt_add_body (pkt, &tmp8,1 );
Signature · 1 line
2.50.1
This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <[email protected]>:
Hello:
This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <[email protected]>:
Quoted 8 lines · On Mon, 11 Aug 2025 11:34:40 +0200 you wrote:
Replace memset(0) followed by
strscpy()withstrscpy_pad()to improvecfctrl_linkup_request(). This avoids zeroing the memory before copying the string and ensures the destination buffer is only written to once, simplifying the code and improving efficiency.Signed-off-by Thorsten Blum <[email protected]>[...]
Here is the summary with links:
- [net-next] caif: Replace memset(0) + strscpy() with strscpy_pad()
https://git.kernel.org/netdev/net-next/c/63fe077c21d3
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html