Skip to contentSkip to conversation

net: libwx: Fix the size in RSS hash key population

PATCH Applied Chandra Mohan Sundar 2 participants 2 messages Aug 14, 2025 – Aug 15, 2025

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 net: libwx: Fix the size in RSS hash key population

While trying to fill a random RSS key, the size of the pointer is being used rather than the actual size of the RSS key.

Fix by passing an appropriate value of the RSS key. This issue was reported by static coverity analyser.

Fixes eb4898fde1de8 ("net: libwx: add wangxun vf common api")
---
 drivers/net/ethernet/wangxun/libwx/wx_vf_lib.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/ethernet/wangxun/libwx/wx_vf_lib.c +1 -1
index 5d48df7a849f..3023ea2732ef 100644
@@ -192,7 +192,7 @@ void wx_setup_vfmrqc_vf(struct wx *wx)
 	u8 i, j;
 
 	/* Fill out hash function seeds */
-	netdev_rss_key_fill(wx->rss_key, sizeof(wx->rss_key));
+	netdev_rss_key_fill(wx->rss_key, WX_RSS_KEY_SIZE);
 	for (i = 0; i < WX_RSS_KEY_SIZE / 4; i++)
 		wr32(wx, WX_VXRSSRK(i), wx->rss_key[i]);
 
Signature · 1 line
2.43.0
#1 lore raw
This patch was applied to netdev/net.git (main) by Jakub Kicinski <[email protected]>:

Hello:

This patch was applied to netdev/net.git (main)
by Jakub Kicinski <[email protected]>:

Quoted 10 lines · On Thu, 14 Aug 2025 22:00:10 +0530 you wrote:

While trying to fill a random RSS key, the size of the pointer is being used rather than the actual size of the RSS key.

Fix by passing an appropriate value of the RSS key. This issue was reported by static coverity analyser.

Fixes eb4898fde1de8 ("net: libwx: add wangxun vf common api")

[...]

Here is the summary with links:
- [net] net: libwx: Fix the size in RSS hash key population

    https://git.kernel.org/netdev/net/c/12da2b92ad50

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html