Skip to contentSkip to conversation

ppp: mppe: Use SHA-1 library instead of crypto_shash

PATCH Applied Eric Biggers 2 participants 2 messages Aug 15, 2025 – Aug 19, 2025

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ppp: mppe: Use SHA-1 library instead of crypto_shash

Now that a SHA-1 library API is available, use it instead of crypto_shash. This is simpler and faster.

---
 drivers/net/ppp/Kconfig    |   3 +-
 drivers/net/ppp/ppp_mppe.c | 108 +++++++------------------------------
 2 files changed, 19 insertions(+), 92 deletions(-)
drivers/net/ppp/Kconfig +1 -2
index 8c9ed1889d1af..a1806b4b84beb 100644
@@ -83,13 +83,12 @@ config PPP_FILTER
 	  If unsure, say N.
 
 config PPP_MPPE
 	tristate "PPP MPPE compression (encryption)"
 	depends on PPP
-	select CRYPTO
-	select CRYPTO_SHA1
 	select CRYPTO_LIB_ARC4
+	select CRYPTO_LIB_SHA1
 	help
 	  Support for the MPPE Encryption protocol, as employed by the
 	  Microsoft Point-to-Point Tunneling Protocol.
 
 	  See http://pptpclient.sourceforge.net/ for information on
drivers/net/ppp/ppp_mppe.c +18 -90

214 lines not on this page · raw message

base-commit: 8f5ae30d69d7543eee0d70083daf4de8fe15d585

Signature · 1 line
2.50.1
#1 lore raw
This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <[email protected]>:

Hello:

This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <[email protected]>:

Quoted 10 lines · On Thu, 14 Aug 2025 19:07:05 -0700 you wrote:

Now that a SHA-1 library API is available, use it instead of crypto_shash. This is simpler and faster.

---
 drivers/net/ppp/Kconfig    |   3 +-
 drivers/net/ppp/ppp_mppe.c | 108 +++++++------------------------------
 2 files changed, 19 insertions(+), 92 deletions(-)

[...]

Here is the summary with links:
- [net-next] ppp: mppe: Use SHA-1 library instead of crypto_shash

    https://git.kernel.org/netdev/net-next/c/b55f7295d600

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html