Skip to contentSkip to conversation

docs: netdev: refine the clean-up patch examples

PATCH Applied Jakub Kicinski 2 participants 2 messages Aug 15, 2025 – Aug 19, 2025

Subsystems (4)
lore
Share & tools
lore

Jakub Kicinski

author maintainer
#0 lore raw

PATCH 1/1 docs: netdev: refine the clean-up patch examples

We discourage sending trivial patches to clean up checkpatch warnings. There are other tools which lead to patches of similarly low value like some coccicheck warnings. The warnings are useful for new code but fixing them in the existing code base is a waste of review time.

Broaden the example given in the doc a little bit.

---
CC: [email protected]
CC: [email protected]
CC: [email protected]

---
 Documentation/process/maintainer-netdev.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Documentation/process/maintainer-netdev.rst +1 -1
index e1755610b4bc..989192421cc9 100644
@@ -407,7 +407,7 @@ Clean-up patches
 Netdev discourages patches which perform simple clean-ups, which are not in
 the context of other work. For example:
 
-* Addressing ``checkpatch.pl`` warnings
+* Addressing ``checkpatch.pl``, and other trivial coding style warnings
 * Addressing :ref:`Local variable ordering<rcs>` issues
 * Conversions to device-managed APIs (``devm_`` helpers)
 
Signature · 1 line
2.50.1
#1 lore raw
This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <[email protected]>:

Hello:

This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <[email protected]>:

Quoted 8 lines · On Fri, 15 Aug 2025 09:52:42 -0700 you wrote:

We discourage sending trivial patches to clean up checkpatch warnings. There are other tools which lead to patches of similarly low value like some coccicheck warnings. The warnings are useful for new code but fixing them in the existing code base is a waste of review time.

Broaden the example given in the doc a little bit.

[...]

Here is the summary with links:
- [net-next] docs: netdev: refine the clean-up patch examples

    https://git.kernel.org/netdev/net-next/c/ab4ee77ed9bd

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html