profiles/audio: Fix uninitialized params.subgroup_data warning
PATCH 1/3 profiles/audio: Fix uninitialized params.subgroup_data warning
profiles/audio/bass.c:923:2: uninit_use_in_call: Using uninitialized value "params". Field "params.subgroup_data" is uninitialized when calling "util_iov_append".
--- profiles/audio/bass.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
profiles/audio/bass.c +1 -1
@@ -918,7 +918,7 @@ static DBusMessage *push(DBusConnection *conn, DBusMessage *msg, {struct bass_assistant *assistant = user_data;struct bt_bass_bcast_audio_scan_cp_hdr hdr; -struct bt_bass_add_src_params params; +struct bt_bass_add_src_params params = {0 };struct iovec iov = {0 };uint32_t bis_sync =0 ;uint8_t meta_len =0 ;
Signature · 1 line
2.50.1
PATCH 2/3 tools/tester: Fix fd leaks
tools/tester.h:314:3: leaked_handle: Handle variable "sk" going out of scope leaks the handle. tools/l2cap-tester.c:1957:4: leaked_handle: Handle variable "sk" going out of scope leaks the handle.
--- tools/l2cap-tester.c | 1 + tools/tester.h | 1 + 2 files changed, 2 insertions(+)
tools/l2cap-tester.c +1 -0
@@ -1954,6 +1954,7 @@ static int connect_socket(const uint8_t *client_bdaddr, GIOFunc connect_cb,tester_print ("Can't enable deferred setup: %s (%d)" ,strerror (errno), errno);tester_test_failed (); +close (sk);return -1 ; } }
tools/tester.h +1 -0
@@ -334,6 +334,7 @@ static inline void test_ethtool_get_ts_info(unsigned int index, int proto,if (ioctl (sk,SIOCETHTOOL , &ifr) ==-1 ) {tester_warn ("SIOCETHTOOL failed" );tester_test_failed (); +close (sk);return ; }close (sk);
Signature · 1 line
2.50.1
PATCH 3/3 input: Fix incorrect destructors being used
In reply to Bastien Nocerag_key_file_get_string() expects its value to be freed with g_free(), not free().
Fixes:profiles/input/manager.c:118:2: leaked_storage: Variable "uhid_enabled" going out of scope leaks the storage it points to. profiles/input/hog.c:267:1: leaked_storage: Variable "uhid_enabled" going out of scope leaks the storage it points to.
--- profiles/input/hog.c | 2 +- profiles/input/manager.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
profiles/input/hog.c +1 -1
@@ -259,7 +259,7 @@ static void hog_read_config(void)if (!err) {DBG ("input.conf: UserspaceHID=%s" , uhid_enabled); uhid_state_persist =strcasecmp (uhid_enabled,"persist" ) ==0 ; -free (uhid_enabled); +g_free (uhid_enabled); }else g_clear_error (&err);
profiles/input/manager.c +1 -1
@@ -101,7 +101,7 @@ static int input_init(void)if (!err) {DBG ("input.conf: UserspaceHID=%s" , uhid_enabled);input_set_userspace_hid (uhid_enabled); -free (uhid_enabled); +g_free (uhid_enabled); }else g_clear_error (&err);
Signature · 1 line
2.50.1
This is automated email and please do not reply to this email!
Dear submitter,
Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=993547
---Test result---
Test Summary:
CheckPatch PENDING 0.27 seconds GitLint PENDING 0.35 seconds BuildEll PASS 20.01 seconds BluezMake PASS 2580.20 seconds MakeCheck PASS 20.06 seconds MakeDistcheck PASS 184.29 seconds CheckValgrind PASS 232.98 seconds CheckSmatch PASS 304.47 seconds bluezmakeextell PASS 128.14 seconds IncrementalBuild PENDING 0.33 seconds ScanBuild PASS 901.25 seconds
Details
##############################
Test: CheckPatch - PENDING
Desc: Run checkpatch.pl script
Output:
##############################
Test: GitLint - PENDING
Desc: Run gitlint
Output:
##############################
Test: IncrementalBuild - PENDING
Desc: Incremental build with the patches in the series Output:
---
Regards,
Linux Bluetooth
This series was applied to bluetooth/bluez.git (master) by Luiz Augusto von Dentz <[email protected]>:
Hello:
This series was applied to bluetooth/bluez.git (master) by Luiz Augusto von Dentz <[email protected]>:
Quoted 4 lines · On Wed, 20 Aug 2025 16:15:44 +0200 you wrote:
profiles/audio/bass.c:923:2:uninit_use_in_call: Using uninitialized value "params". Field "params.subgroup_data" is uninitialized when calling "util_iov_append".--- profiles/audio/bass.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Here is the summary with links:
- [BlueZ,1/3] profiles/audio: Fix uninitialized params.subgroup_data warning
https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=c773fd53c953 - [BlueZ,2/3] tools/tester: Fix fd leaks https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=bb14a8b18f94 - [BlueZ,3/3] input: Fix incorrect destructors being used https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=4784f58ff0ec
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html