bpf: Remove preempt_disable in bpf_try_get_buffers
PATCH 1/1 bpf: Remove preempt_disable in bpf_try_get_buffers
Now BPF program will run with migration disabled, so it is safe to access this_cpu_inc_return(bpf_bprintf_nest_level).
Fixes d9c9e4db186a ("bpf: Factorize bpf_trace_printk and bpf_seq_printf")
Signed-off-by Tao Chen <[email protected]>
--- kernel/bpf/helpers.c | 3 --- 1 file changed, 3 deletions(-)
kernel/bpf/helpers.c +0 -3
@@ -774,11 +774,9 @@ int bpf_try_get_buffers(struct bpf_bprintf_buffers **bufs) {int nest_level; -preempt_disable (); nest_level =this_cpu_inc_return (bpf_bprintf_nest_level);if (WARN_ON_ONCE (nest_level >MAX_BPRINTF_NEST_LEVEL )) {this_cpu_dec (bpf_bprintf_nest_level); -preempt_enable ();return -EBUSY ; } *bufs =this_cpu_ptr (&bpf_bprintf_bufs[nest_level -1 ]);
@@ -791,7 +789,6 @@ void bpf_put_buffers(void)if (WARN_ON_ONCE (this_cpu_read (bpf_bprintf_nest_level) ==0 ))return ;this_cpu_dec (bpf_bprintf_nest_level); -preempt_enable (); }void bpf_bprintf_cleanup (struct bpf_bprintf_data *data)
Signature · 1 line
2.48.1
This patch was applied to bpf/bpf-next.git (master) by Andrii Nakryiko <[email protected]>:
Hello:
This patch was applied to bpf/bpf-next.git (master) by Andrii Nakryiko <[email protected]>:
Quoted 8 lines · On Tue, 19 Aug 2025 20:56:38 +0800 you wrote:
Now BPF program will run with migration disabled, so it is safe to access
this_cpu_inc_return(bpf_bprintf_nest_level).Fixes d9c9e4db186a ("bpf: Factorize bpf_trace_printk and bpf_seq_printf")Signed-off-by Tao Chen <[email protected]>--- kernel/bpf/helpers.c | 3 --- 1 file changed, 3 deletions(-)
Here is the summary with links:
- [bpf-next] bpf: Remove preempt_disable in bpf_try_get_buffers
https://git.kernel.org/bpf/bpf-next/c/4223bf833c84
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html