net: phy: fixed_phy: let fixed_phy_unregister free the phy_device
Subsystems (4)
Heiner Kallweit
maintainerPATCH 1/1 net: phy: fixed_phy: let fixed_phy_unregister free the phy_device
fixed_phy_register() creates and registers the phy_device. To be symmetric, we should not only unregister, but also free the phy_device in fixed_phy_unregister(). This allows to simplify code in users.
Note wrt of_phy_deregister_fixed_link():put_device(&phydev->mdio.dev) and phy_device_free(phydev) are identical.
--- drivers/net/dsa/dsa_loop.c | 9 +++------ drivers/net/mdio/of_mdio.c | 1 - drivers/net/phy/fixed_phy.c | 1 + 3 files changed, 4 insertions(+), 7 deletions(-)
drivers/net/dsa/dsa_loop.c +3 -6
@@ -386,13 +386,10 @@ static struct mdio_driver dsa_loop_drv = {static void dsa_loop_phydevs_unregister (void ) { -unsigned int i; - -for (i =0 ; i <NUM_FIXED_PHYS ; i++) -if (!IS_ERR (phydevs[i])) { +for (int i =0 ; i <NUM_FIXED_PHYS ; i++) { +if (!IS_ERR (phydevs[i]))fixed_phy_unregister (phydevs[i]); -phy_device_free (phydevs[i]); - } + } }static int __init dsa_loop_init (void )
drivers/net/mdio/of_mdio.c +0 -1
@@ -473,6 +473,5 @@ void of_phy_deregister_fixed_link(struct device_node *np)fixed_phy_unregister (phydev);put_device (&phydev->mdio.dev);/* of_phy_find_device() */ -phy_device_free (phydev);/* fixed_phy_register() */ }EXPORT_SYMBOL (of_phy_deregister_fixed_link);
drivers/net/phy/fixed_phy.c +1 -0
@@ -304,6 +304,7 @@ void fixed_phy_unregister(struct phy_device *phy)phy_device_remove (phy);of_node_put (phy->mdio.dev.of_node);fixed_phy_del (phy->mdio.addr); +phy_device_free (phy); }EXPORT_SYMBOL_GPL (fixed_phy_unregister);
Signature · 1 line
2.50.1
Quoted 8 lines · Heiner Kallweit
fixed_phy_register()creates and registers thephy_device. To be symmetric, we should not only unregister, but also free thephy_deviceinfixed_phy_unregister(). This allows to simplify code in users.Note wrt
of_phy_deregister_fixed_link():put_device(&phydev->mdio.dev)andphy_device_free(phydev)are identical.Signed-off-by Heiner Kallweit <[email protected]>
Thanks!
Signature · 2 lines
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <[email protected]>:
Hello:
This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <[email protected]>:
Quoted 8 lines · On Sat, 23 Aug 2025 23:25:05 +0200 you wrote:
fixed_phy_register()creates and registers thephy_device. To be symmetric, we should not only unregister, but also free thephy_deviceinfixed_phy_unregister(). This allows to simplify code in users.Note wrt
of_phy_deregister_fixed_link():put_device(&phydev->mdio.dev)andphy_device_free(phydev)are identical.[...]
Here is the summary with links:
- [net-next] net: phy: fixed_phy: let fixed_phy_unregister free the phy_device
https://git.kernel.org/netdev/net-next/c/a0f849c1cc6d
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html