selftests/bpf: Fix typos and grammar in test sources
Subsystems (5)
PATCH v2 1/1 selftests/bpf: Fix typos and grammar in test sources
From: Shubham Sharma <[email protected]>
Fixed the spelling typo and checked other BPF selftests sources for similar typos.
Follow-up to patch series 990629
v2:Instead of sending multiple tiny patches for minor comment fixes, combined them into a single pass across the affected files.
--- tools/testing/selftests/bpf/Makefile | 2 +- tools/testing/selftests/bpf/bench.c | 2 +- tools/testing/selftests/bpf/prog_tests/btf_dump.c | 2 +- tools/testing/selftests/bpf/prog_tests/fd_array.c | 2 +- .../testing/selftests/bpf/prog_tests/kprobe_multi_test.c | 2 +- tools/testing/selftests/bpf/prog_tests/module_attach.c | 2 +- tools/testing/selftests/bpf/prog_tests/reg_bounds.c | 4 ++-- .../selftests/bpf/prog_tests/stacktrace_build_id.c | 2 +- .../selftests/bpf/prog_tests/stacktrace_build_id_nmi.c | 2 +- tools/testing/selftests/bpf/prog_tests/stacktrace_map.c | 2 +- .../selftests/bpf/prog_tests/stacktrace_map_raw_tp.c | 2 +- .../selftests/bpf/prog_tests/stacktrace_map_skip.c | 2 +- tools/testing/selftests/bpf/progs/bpf_cc_cubic.c | 2 +- tools/testing/selftests/bpf/progs/bpf_dctcp.c | 2 +- .../selftests/bpf/progs/freplace_connect_v4_prog.c | 2 +- tools/testing/selftests/bpf/progs/iters_state_safety.c | 2 +- tools/testing/selftests/bpf/progs/rbtree_search.c | 2 +- .../testing/selftests/bpf/progs/struct_ops_kptr_return.c | 2 +- tools/testing/selftests/bpf/progs/struct_ops_refcounted.c | 2 +- tools/testing/selftests/bpf/progs/test_cls_redirect.c | 2 +- .../selftests/bpf/progs/test_cls_redirect_dynptr.c | 2 +- tools/testing/selftests/bpf/progs/uretprobe_stack.c | 4 ++-- tools/testing/selftests/bpf/progs/verifier_scalar_ids.c | 2 +- tools/testing/selftests/bpf/progs/verifier_var_off.c | 6 +++--- tools/testing/selftests/bpf/test_sockmap.c | 2 +- tools/testing/selftests/bpf/verifier/calls.c | 8 ++++---- tools/testing/selftests/bpf/xdping.c | 2 +- tools/testing/selftests/bpf/xsk.h | 4 ++-- 28 files changed, 36 insertions(+), 36 deletions(-)
tools/testing/selftests/bpf/Makefile +1 -1
@@ -398,7 +398,7 @@ $(HOST_BPFOBJ): $(wildcard $(BPFDIR)/*.[ch] $(BPFDIR)/Makefile) \ DESTDIR=$(HOST_SCRATCH_DIR)/ prefix= all install_headers endif -# vmlinux.h is first dumped to a temprorary file and then compared to +# vmlinux.h is first dumped to a temporary file and then compared to # the previous version. This helps to avoid unnecessary re-builds of # $(TRUNNER_BPF_OBJS) $(INCLUDE_DIR)/vmlinux.h: $(VMLINUX_BTF) $(BPFTOOL) | $(INCLUDE_DIR)
tools/testing/selftests/bpf/bench.c +1 -1
@@ -499,7 +499,7 @@ extern const struct bench bench_rename_rawtp;extern const struct bench bench_rename_fentry;extern const struct bench bench_rename_fexit; -/* pure counting benchmarks to establish theoretical lmits */ +/* pure counting benchmarks to establish theoretical limits */ extern const struct bench bench_trig_usermode_count;extern const struct bench bench_trig_syscall_count;extern const struct bench bench_trig_kernel_count;
tools/testing/selftests/bpf/prog_tests/btf_dump.c +1 -1
@@ -63,7 +63,7 @@ static int test_btf_dump_case(int n, struct btf_dump_test_case *t)/* tests with t->known_ptr_sz have no "long" or "unsigned long" type, * so it's impossible to determine correct pointer size; but if they -* do, it should be 8 regardless of host architecture, becaues BPF +* do, it should be 8 regardless of host architecture, because BPF * target is always 64-bit */ if (!t->known_ptr_sz) {
tools/testing/selftests/bpf/prog_tests/fd_array.c +1 -1
@@ -293,7 +293,7 @@ static int get_btf_id_by_fd(int btf_fd, __u32 *id)* 1) Create a new btf, it's referenced only by a file descriptor, so refcnt=1 * 2) Load a BPF prog with fd_array[0] = btf_fd; now btf's refcnt=2 * 3) Close the btf_fd, now refcnt=1 -* Wait and check that BTF stil exists. +* Wait and check that BTF still exists. */ static void check_fd_array_cnt__referenced_btfs (void ) {
tools/testing/selftests/bpf/prog_tests/kprobe_multi_test.c +1 -1
@@ -463,7 +463,7 @@ static bool skip_entry(char *name)return false; } -/* Do comparision by ignoring '.llvm.<hash>' suffixes. */ +/* Do comparison by ignoring '.llvm.<hash>' suffixes. */ static int compare_name (const char *name1,const char *name2) {const char *res1, *res2;
tools/testing/selftests/bpf/prog_tests/module_attach.c +1 -1
@@ -90,7 +90,7 @@ void test_module_attach(void)test_module_attach__detach (skel); -/* attach fentry/fexit and make sure it get's module reference */ +/* attach fentry/fexit and make sure it gets module reference */ link =bpf_program__attach (skel->progs.handle_fentry);if (!ASSERT_OK_PTR (link,"attach_fentry" )) goto cleanup;
tools/testing/selftests/bpf/prog_tests/reg_bounds.c +2 -2
@@ -623,7 +623,7 @@ static void range_cond(enum num_t t, struct range x, struct range y, *newx =range (t, x.a, x.b); *newy =range (t, y.a +1 , y.b); }else if (x.a == x.b && x.b == y.b) { -/* X is a constant matching rigth side of Y */ +/* X is a constant matching right side of Y */ *newx =range (t, x.a, x.b); *newy =range (t, y.a, y.b -1 ); }else if (y.a == y.b && x.a == y.a) {
@@ -631,7 +631,7 @@ static void range_cond(enum num_t t, struct range x, struct range y, *newx =range (t, x.a +1 , x.b); *newy =range (t, y.a, y.b); }else if (y.a == y.b && x.b == y.b) { -/* Y is a constant matching rigth side of X */ +/* Y is a constant matching right side of X */ *newx =range (t, x.a, x.b -1 ); *newy =range (t, y.a, y.b); }else {
tools/testing/selftests/bpf/prog_tests/stacktrace_build_id.c +1 -1
@@ -39,7 +39,7 @@ void test_stacktrace_build_id(void)bpf_map_update_elem (control_map_fd, &key, &val,0 );/* for every element in stackid_hmap, we can find a corresponding one -* in stackmap, and vise versa. +* in stackmap, and vice versa. */ err =compare_map_keys (stackid_hmap_fd, stackmap_fd); if (CHECK(err, "compare_map_keys stackid_hmap vs. stackmap",
tools/testing/selftests/bpf/prog_tests/stacktrace_build_id_nmi.c +1 -1
@@ -66,7 +66,7 @@ void test_stacktrace_build_id_nmi(void)bpf_map_update_elem (control_map_fd, &key, &val,0 );/* for every element in stackid_hmap, we can find a corresponding one -* in stackmap, and vise versa. +* in stackmap, and vice versa. */ err =compare_map_keys (stackid_hmap_fd, stackmap_fd); if (CHECK(err, "compare_map_keys stackid_hmap vs. stackmap",
tools/testing/selftests/bpf/prog_tests/stacktrace_map.c +1 -1
@@ -50,7 +50,7 @@ void test_stacktrace_map(void)bpf_map_update_elem (control_map_fd, &key, &val,0 );/* for every element in stackid_hmap, we can find a corresponding one -* in stackmap, and vise versa. +* in stackmap, and vice versa. */ err =compare_map_keys (stackid_hmap_fd, stackmap_fd); if (CHECK(err, "compare_map_keys stackid_hmap vs. stackmap",
tools/testing/selftests/bpf/prog_tests/stacktrace_map_raw_tp.c +1 -1
@@ -46,7 +46,7 @@ void test_stacktrace_map_raw_tp(void)bpf_map_update_elem (control_map_fd, &key, &val,0 );/* for every element in stackid_hmap, we can find a corresponding one -* in stackmap, and vise versa. +* in stackmap, and vice versa. */ err =compare_map_keys (stackid_hmap_fd, stackmap_fd); if (CHECK(err, "compare_map_keys stackid_hmap vs. stackmap",
tools/testing/selftests/bpf/prog_tests/stacktrace_map_skip.c +1 -1
@@ -40,7 +40,7 @@ void test_stacktrace_map_skip(void) skel->bss->control =1 ;/* for every element in stackid_hmap, we can find a corresponding one -* in stackmap, and vise versa. +* in stackmap, and vice versa. */ err =compare_map_keys (stackid_hmap_fd, stackmap_fd);if (!ASSERT_OK (err,"compare_map_keys stackid_hmap vs. stackmap" ))
tools/testing/selftests/bpf/progs/bpf_cc_cubic.c +1 -1
@@ -101,7 +101,7 @@ static void tcp_cwnd_reduction(struct sock *sk, int newly_acked_sacked, tp->snd_cwnd = pkts_in_flight + sndcnt; } -/* Decide wheather to run the increase function of congestion control. */ +/* Decide whether to run the increase function of congestion control. */ static bool tcp_may_raise_cwnd (const struct sock *sk,const int flag) {if (tcp_sk (sk)->reordering >TCP_REORDERING )
tools/testing/selftests/bpf/progs/bpf_dctcp.c +1 -1
@@ -1,7 +1,7 @@// SPDX-License-Identifier: GPL-2.0 /* Copyright (c) 2019 Facebook */ -/* WARNING: This implemenation is not necessarily the same +/* WARNING: This implementation is not necessarily the same * as the tcp_dctcp.c. The purpose is mainly for testing * the kernel BPF logic. */
tools/testing/selftests/bpf/progs/freplace_connect_v4_prog.c +1 -1
@@ -12,7 +12,7 @@ SEC("freplace/connect_v4_prog")int new_connect_v4_prog (struct bpf_sock_addr *ctx) { -// return value thats in invalid range +// return value that's in invalid range return 255 ; }
tools/testing/selftests/bpf/progs/iters_state_safety.c +1 -1
@@ -345,7 +345,7 @@ int __naked read_from_iter_slot_fail(void)"r3 = 1000;" "call %[bpf_iter_num_new];" -/* attemp to leak bpf_iter_num state */ +/* attempt to leak bpf_iter_num state */ "r7 = *(u64 *)(r6 + 0);" "r8 = *(u64 *)(r6 + 8);"
tools/testing/selftests/bpf/progs/rbtree_search.c +1 -1
@@ -183,7 +183,7 @@ long test_##op##_spinlock_##dolock(void *ctx) \ }/* -* Use a spearate MSG macro instead of passing to TEST_XXX(..., MSG) +* Use a separate MSG macro instead of passing to TEST_XXX(..., MSG) * to ensure the message itself is not in the bpf prog lineinfo * which the verifier includes in its log. * Otherwise, the test_loader will incorrectly match the prog lineinfo
tools/testing/selftests/bpf/progs/struct_ops_kptr_return.c +1 -1
@@ -9,7 +9,7 @@ void bpf_task_release(struct task_struct *p) __ksym;/* This test struct_ops BPF programs returning referenced kptr. The verifier should * allow a referenced kptr or a NULL pointer to be returned. A referenced kptr to task -* here is acquried automatically as the task argument is tagged with "__ref". +* here is acquired automatically as the task argument is tagged with "__ref". */ SEC("struct_ops/test_return_ref_kptr") struct task_struct *BPF_PROG(kptr_return, int dummy,
tools/testing/selftests/bpf/progs/struct_ops_refcounted.c +1 -1
@@ -9,7 +9,7 @@ __attribute__((nomerge)) extern void bpf_task_release(struct task_struct *p) __k/* This is a test BPF program that uses struct_ops to access a referenced * kptr argument. This is a test for the verifier to ensure that it -* 1) recongnizes the task as a referenced object (i.e., ref_obj_id > 0), and +* 1) recognizes the task as a referenced object (i.e., ref_obj_id > 0), and * 2) the same reference can be acquired from multiple paths as long as it * has not been released. */
tools/testing/selftests/bpf/progs/test_cls_redirect.c +1 -1
@@ -129,7 +129,7 @@ typedef uint8_t *net_ptr __attribute__((align_value(8))); typedef struct buf { struct __sk_buff *skb; net_ptr head; - /* NB: tail musn't have alignment other than 1, otherwise + /* NB: tail mustn't have alignment other than 1, otherwise * LLVM will go and eliminate code, e.g. when checking packet lengths. */ uint8_t *const tail;
tools/testing/selftests/bpf/progs/test_cls_redirect_dynptr.c +1 -1
@@ -494,7 +494,7 @@ static ret_t get_next_hop(struct bpf_dynptr *dynptr, __u64 *offset, encap_header *offset +=sizeof (*next_hop); -/* Skip the remainig next hops (may be zero). */ +/* Skip the remaining next hops (may be zero). */ return skip_next_hops (offset, encap->unigue.hop_count - encap->unigue.next_hop -1 ); }
tools/testing/selftests/bpf/progs/uretprobe_stack.c +2 -2
@@ -26,8 +26,8 @@ int usdt_len; SEC("uprobe//proc/self/exe:target_1")int BPF_UPROBE (uprobe_1 ) { -/* target_1 is recursive wit depth of 2, so we capture two separate -* stack traces, depending on which occurence it is +/* target_1 is recursive with depth of 2, so we capture two separate +* stack traces, depending on which occurrence it is */ static bool recur = false;
tools/testing/selftests/bpf/progs/verifier_scalar_ids.c +1 -1
@@ -349,7 +349,7 @@ __naked void precision_two_ids(void) SEC("socket") __success __log_level(2) __flag(BPF_F_TEST_STATE_FREQ) -/* check thar r0 and r6 have different IDs after 'if', +/* check that r0 and r6 have different IDs after 'if', * collect_linked_regs() can't tie more than 6 registers for a single insn. */ __msg("8: (25) if r0 > 0x7 goto pc+0 ; R0=scalar(id=1")
tools/testing/selftests/bpf/progs/verifier_var_off.c +3 -3
@@ -114,8 +114,8 @@ __naked void stack_write_priv_vs_unpriv(void) }/* Similar to the previous test, but this time also perform a read from the -* address written to with a variable offset. The read is allowed, showing that, -* after a variable-offset write, a priviledged program can read the slots that +* address written to with a variable offet. The read is allowed, showing that, +* after a variable-offset write, a privileged program can read the slots that * were in the range of that write (even if the verifier doesn't actually know if * the slot being read was really written to or not. *
@@ -157,7 +157,7 @@ __naked void stack_write_followed_by_read(void) SEC("socket") __description("variable-offset stack write clobbers spilled regs") __failure -/* In the priviledged case, dereferencing a spilled-and-then-filled +/* In the privileged case, dereferencing a spilled-and-then-filled * register is rejected because the previous variable offset stack * write might have overwritten the spilled pointer (i.e. we lose track * of the spilled register when we analyze the write).
tools/testing/selftests/bpf/test_sockmap.c +1 -1
@@ -1372,7 +1372,7 @@ static int run_options(struct sockmap_options *options, int cg_fd, int test) }else fprintf (stderr,"unknown test\n" ); out: -/* Detatch and zero all the maps */ +/* Detach and zero all the maps */ bpf_prog_detach2 (bpf_program__fd (progs[3 ]), cg_fd,BPF_CGROUP_SOCK_OPS );for (i =0 ; i <ARRAY_SIZE (links); i++) {
tools/testing/selftests/bpf/verifier/calls.c +4 -4
@@ -1375,7 +1375,7 @@BPF_JMP_IMM (BPF_JEQ ,BPF_REG_0 ,0 ,1 ),/* write into map value */ BPF_ST_MEM (BPF_DW ,BPF_REG_0 ,0 ,0 ), -/* fetch secound map_value_ptr from the stack */ +/* fetch second map_value_ptr from the stack */ BPF_LDX_MEM (BPF_DW ,BPF_REG_0 ,BPF_REG_10 ,-16 ), BPF_JMP_IMM(BPF_JEQ, BPF_REG_0, 0, 1),/* write into map value */
@@ -1439,7 +1439,7 @@/* second time with fp-16 */ BPF_RAW_INSN (BPF_JMP |BPF_CALL ,0 ,1 ,0 ,4 ),BPF_JMP_IMM (BPF_JNE ,BPF_REG_0 ,1 ,2 ), -/* fetch secound map_value_ptr from the stack */ +/* fetch second map_value_ptr from the stack */ BPF_LDX_MEM (BPF_DW ,BPF_REG_0 ,BPF_REG_7 ,0 ),/* write into map value */ BPF_ST_MEM(BPF_DW, BPF_REG_0, 0, 0),
@@ -1493,7 +1493,7 @@/* second time with fp-16 */ BPF_RAW_INSN (BPF_JMP |BPF_CALL ,0 ,1 ,0 ,4 ),BPF_JMP_IMM (BPF_JNE ,BPF_REG_0 ,0 ,2 ), -/* fetch secound map_value_ptr from the stack */ +/* fetch second map_value_ptr from the stack */ BPF_LDX_MEM (BPF_DW ,BPF_REG_0 ,BPF_REG_7 ,0 ),/* write into map value */ BPF_ST_MEM(BPF_DW, BPF_REG_0, 0, 0),
@@ -2380,7 +2380,7 @@*/ BPF_JMP_REG (BPF_JGT ,BPF_REG_6 ,BPF_REG_7 ,1 ),BPF_MOV64_REG (BPF_REG_9 ,BPF_REG_8 ), -/* r9 = *r9 ; verifier get's to this point via two paths: +/* r9 = *r9 ; verifier gets to this point via two paths: * ; (I) one including r9 = r8, verified first; * ; (II) one excluding r9 = r8, verified next. * ; After load of *r9 to r9 the frame[0].fp[-24].id == r9.id.
tools/testing/selftests/bpf/xdping.c +1 -1
@@ -155,7 +155,7 @@ int main(int argc, char **argv) }if (!server) { -/* Only supports IPv4; see hints initiailization above. */ +/* Only supports IPv4; see hints initialization above. */ if (getaddrinfo (argv[optind],NULL , &hints, &a) || !a) {fprintf (stderr,"Could not resolve %s\n" , argv[optind]);return 1 ;
tools/testing/selftests/bpf/xsk.h +2 -2
@@ -93,8 +93,8 @@ static inline __u32 xsk_prod_nb_free(struct xsk_ring_prod *r, __u32 nb)/* Refresh the local tail pointer. * cached_cons is r->size bigger than the real consumer pointer so * that this addition can be avoided in the more frequently -* executed code that computs free_entries in the beginning of -* this function. Without this optimization it whould have been +* executed code that computes free_entries in the beginning of +* this function. Without this optimization it would have been * free_entries = r->cached_prod - r->cached_cons + r->size. */ r->cached_cons =__atomic_load_n (r->consumer, __ATOMIC_ACQUIRE);
Signature · 1 line
2.48.1
This patch was applied to bpf/bpf-next.git (master) by Andrii Nakryiko <[email protected]>:
Hello:
This patch was applied to bpf/bpf-next.git (master) by Andrii Nakryiko <[email protected]>:
Quoted 9 lines · On Tue, 26 Aug 2025 18:27:46 +0530 you wrote:
From: Shubham Sharma <[email protected]>
Fixed the spelling typo and checked other BPF selftests sources for similar typos.
Follow-up to patch series 990629
v2:Instead of sending multiple tiny patches for minor comment fixes, combined them into a single pass across the affected files.
[...]
Here is the summary with links:
- [v2] selftests/bpf: Fix typos and grammar in test sources
https://git.kernel.org/bpf/bpf-next/c/d3abefe89740
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html