net: macb: Disable clocks once
Subsystems (3)
PATCH v2 1/1 net: macb: Disable clocks once
From: Neil Mandir <[email protected]>
When the driver is removed the clocks are disabled twice: once in macb_remove and a second time by runtime pm. Disable wakeup in remove so all the clocks are disabled and skip the second call to macb_clks_disable. Always suspend the device as we always set it active in probe.
---
Changes in v2:
- Spruce up the commit message
- Rebase
drivers/net/ethernet/cadence/macb_main.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-)
drivers/net/ethernet/cadence/macb_main.c +2 -5
@@ -5404,14 +5404,11 @@ static void macb_remove(struct platform_device *pdev)mdiobus_unregister (bp->mii_bus);mdiobus_free (bp->mii_bus); +device_set_wakeup_enable (&bp->pdev->dev,0 );cancel_work_sync (&bp->hresp_err_bh_work);pm_runtime_disable (&pdev->dev);pm_runtime_dont_use_autosuspend (&pdev->dev); -if (!pm_runtime_suspended (&pdev->dev)) { -macb_clks_disable (bp->pclk, bp->hclk, bp->tx_clk, - bp->rx_clk, bp->tsu_clk); -pm_runtime_set_suspended (&pdev->dev); - } +pm_runtime_set_suspended (&pdev->dev);phylink_destroy (bp->phylink);free_netdev (dev); }
Signature · 1 line
2.35.1.1320.gc452695387.dirty
This patch was applied to netdev/net.git (main) by Paolo Abeni <[email protected]>:
Hello:
This patch was applied to netdev/net.git (main)
by Paolo Abeni <[email protected]>:
Quoted 8 lines · On Tue, 26 Aug 2025 10:30:22 -0400 you wrote:
From: Neil Mandir <[email protected]>
When the driver is removed the clocks are disabled twice: once in
macb_removeand a second time by runtime pm. Disable wakeup in remove so all the clocks are disabled and skip the second call tomacb_clks_disable. Always suspend the device as we always set it active in probe.[...]
Here is the summary with links:
- [net,v2] net: macb: Disable clocks once
https://git.kernel.org/netdev/net/c/dac978e51cce
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html