bpf: Allow fall back to interpreter for programs with stack size <= 512
PATCH v3 1/1 bpf: Allow fall back to interpreter for programs with stack size <= 512
OpenWRT users reported regression on ARMv6 devices after updating to latest HEAD, where tcpdump filter:
tcpdump "not ether host 3c37121a2b3c and not ether host 184ecbca2a3a \
and not ether host 14130b4d3f47 and not ether host f0f61cf440b7 \
and not ether host a84b4dedf471 and not ether host d022be17e1d7 \
and not ether host 5c497967208b and not ether host 706655784d5b"
fails with warning: "Kernel filter failed: No error information" when using config:
# CONFIG_BPF_JIT_ALWAYS_ON is not set CONFIG_BPF_JIT_DEFAULT_ON=y
The issue arises because commits:
1. "bpf: Fix array bounds error with may_goto" changed default runtime to __bpf_prog_ret0_warn when jit_requested = 1
2. "bpf: Avoid __bpf_prog_ret0_warn when jit fails" returns error when jit_requested = 1 but jit fails
This change restores interpreter fallback capability for BPF programs with stack size <= 512 bytes when jit fails.
---
changes:
v3:
- Remove the selftest (Puranjay and Eduard)
v2:
- Addressed comments from Alexei
- Add selftest
https://lore.kernel.org/all/[email protected]/
v1:
https://lore.kernel.org/all/[email protected]/
--- kernel/bpf/core.c | 16 +++++++++------- 1 file changed, 9 insertions(+), 7 deletions(-)
kernel/bpf/core.c +9 -7
@@ -2366,8 +2366,7 @@ static unsigned int __bpf_prog_ret0_warn(const void *ctx, const struct bpf_insn *insn) {/* If this handler ever gets executed, then BPF_JIT_ALWAYS_ON -* is not working properly, or interpreter is being used when -* prog->jit_requested is not 0, so warn about it! +* is not working properly, so warn about it! */ WARN_ON_ONCE (1 );return 0 ;
@@ -2468,8 +2467,9 @@ static int bpf_check_tail_call(const struct bpf_prog *fp)return ret; } -static void bpf_prog_select_func (struct bpf_prog *fp) +static bool bpf_prog_select_interpreter (struct bpf_prog *fp) { +bool select_interpreter = false;#ifndef CONFIG_BPF_JIT_ALWAYS_ON u32 stack_depth =max_t (u32, fp->aux->stack_depth,1 );u32 idx = (round_up (stack_depth,32 ) /32 ) -1 ;
@@ -2478,15 +2478,16 @@ static void bpf_prog_select_func(struct bpf_prog *fp)* But for non-JITed programs, we don't need bpf_func, so no bounds * check needed. */ -if (!fp->jit_requested && - !WARN_ON_ONCE (idx >=ARRAY_SIZE (interpreters))) { +if (idx <ARRAY_SIZE (interpreters)) { fp->bpf_func = interpreters[idx]; + select_interpreter = true; }else { fp->bpf_func = __bpf_prog_ret0_warn; }#else fp->bpf_func = __bpf_prog_ret0_warn;#endif +return select_interpreter; }/**
@@ -2505,7 +2506,7 @@ struct bpf_prog *bpf_prog_select_runtime(struct bpf_prog *fp, int *err)/* In case of BPF to BPF calls, verifier did all the prep * work with regards to JITing, etc. */ -bool jit_needed = fp->jit_requested; +bool jit_needed = false;if (fp->bpf_func) goto finalize;
@@ -2514,7 +2515,8 @@ struct bpf_prog *bpf_prog_select_runtime(struct bpf_prog *fp, int *err) bpf_prog_has_kfunc_call(fp)) jit_needed = true; -bpf_prog_select_func (fp); +if (!bpf_prog_select_interpreter (fp)) + jit_needed = true;/* eBPF JITs can rewrite the program in case constant * blinding is active. However, in case of error during
Signature · 1 line
2.43.0
Quoted 31 lines · KaFai Wan
OpenWRT users reported regression on ARMv6 devices after updating to latest HEAD, where tcpdump filter:
tcpdump "not ether host
3c37121a2b3cand not ether host184ecbca2a3a\
and not ether host14130b4d3f47and not ether hostf0f61cf440b7\
and not ether hosta84b4dedf471and not ether hostd022be17e1d7\
and not ether host5c497967208band not ether host706655784d5b"fails with warning: "Kernel filter failed: No error information" when using config:
#CONFIG_BPF_JIT_ALWAYS_ONis not setCONFIG_BPF_JIT_DEFAULT_ON=yThe issue arises because commits:
1. "bpf: Fix array bounds error withmay_goto" changed default runtime to__bpf_prog_ret0_warnwhenjit_requested= 1
2. "bpf: Avoid__bpf_prog_ret0_warnwhen jit fails" returns error whenjit_requested= 1 but jit failsThis change restores interpreter fallback capability for BPF programs with stack size <= 512 bytes when jit fails.
Reported-by Felix Fietkau <[email protected]>Fixes 6ebc5030e0c5 ("bpf: Fix array bounds error with may_goto")Signed-off-by KaFai Wan <[email protected]>---
changes:
v3:
- Remove the selftest (Puranjay and Eduard)
Quoted 8 lines
v2:
- Addressed comments from Alexei
- Add selftest
https://lore.kernel.org/all/[email protected]/
[...]
This patch was applied to bpf/bpf.git (master) by Alexei Starovoitov <[email protected]>:
Hello:
This patch was applied to bpf/bpf.git (master)
by Alexei Starovoitov <[email protected]>:
Quoted 9 lines · On Tue, 9 Sep 2025 22:46:14 +0800 you wrote:
OpenWRT users reported regression on ARMv6 devices after updating to latest HEAD, where tcpdump filter:
tcpdump "not ether host
3c37121a2b3cand not ether host184ecbca2a3a\
and not ether host14130b4d3f47and not ether hostf0f61cf440b7\
and not ether hosta84b4dedf471and not ether hostd022be17e1d7\
and not ether host5c497967208band not ether host706655784d5b"[...]
Here is the summary with links:
- [bpf,v3,1/1] bpf: Allow fall back to interpreter for programs with stack size <= 512
https://git.kernel.org/bpf/bpf/c/df0cb5cb50bd
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html