Skip to contentSkip to conversation

arm64: dts: apm-shadowcat: Move slimpro nodes out of "simple-bus" node

PATCH Applied Rob Herring (Arm) 2 participants 2 messages Sep 19, 2025 – Sep 23, 2025

Subsystems (2)
lore
Share & tools
lore

Rob Herring (Arm)

author maintainer
#0 lore raw

PATCH 1/1 arm64: dts: apm-shadowcat: Move slimpro nodes out of "simple-bus" node

The slimpro nodes are not MMIO devices, so they don't belong under a "simple-bus" node. Move them to the top level.

---
I made the same change on storm, but somehow missed shadowcat.

To: [email protected]
Arnd, please apply directly.

---
 arch/arm64/boot/dts/apm/apm-shadowcat.dtsi | 20 ++++++++++----------
 1 file changed, 10 insertions(+), 10 deletions(-)
arch/arm64/boot/dts/apm/apm-shadowcat.dtsi +10 -10
index 261fc10adefb..5bbedb0a7107 100644
@@ -224,6 +224,16 @@ timer {
 		clock-frequency = <50000000>;
 	};
 
+	i2cslimpro {
+		compatible = "apm,xgene-slimpro-i2c";
+		mboxes = <&mailbox 0>;
+	};
+
+	hwmonslimpro {
+		compatible = "apm,xgene-slimpro-hwmon";
+		mboxes = <&mailbox 7>;
+	};
+
 	soc {
 		compatible = "simple-bus";
 		#address-cells = <2>;
@@ -577,16 +587,6 @@ mailbox: mailbox@10540000 {
 					0x0 0x7 0x4>;
 		};
 
-		i2cslimpro {
-			compatible = "apm,xgene-slimpro-i2c";
-			mboxes = <&mailbox 0>;
-		};
-
-		hwmonslimpro {
-			compatible = "apm,xgene-slimpro-hwmon";
-			mboxes = <&mailbox 7>;
-		};
-
 		serial0: serial@10600000 {
 			compatible = "ns16550";
 			reg = <0 0x10600000 0x0 0x1000>;
Signature · 1 line
2.51.0
#1 lore raw
This patch was applied to soc/soc.git (for-next) by Arnd Bergmann <[email protected]>:

Hello:

This patch was applied to soc/soc.git (for-next)
by Arnd Bergmann <[email protected]>:

Quoted 8 lines · On Fri, 19 Sep 2025 11:15:08 -0500 you wrote:

The slimpro nodes are not MMIO devices, so they don't belong under a "simple-bus" node. Move them to the top level.

---
I made the same change on storm, but somehow missed shadowcat.

[...]

Here is the summary with links:
- arm64: dts: apm-shadowcat: Move slimpro nodes out of "simple-bus" node

    https://git.kernel.org/soc/soc/c/676af08386e4

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html