ASoc: tac5x1x: mixer-test report
Subsystems (3)
v3 cover ASoc: tac5x1x: mixer-test report
mixer-test report:
TAP version 13
# Card 0/titac5x1xsoundc - ti,tac5x1x-soundcard (ti,tac5x1x-soundcard) 1..525
ok 1 get_value.titac5x1xsoundc.74
# titac5x1xsoundc.74 ASI_TX_CH4_EN Capture Switch ok 2 name.titac5x1xsoundc.74 ok 3 write_default.titac5x1xsoundc.74 ok 4 write_valid.titac5x1xsoundc.74 ok 5 write_invalid.titac5x1xsoundc.74 ok 6 event_missing.titac5x1xsoundc.74 ok 7 event_spurious.titac5x1xsoundc.74 ok 8 get_value.titac5x1xsoundc.73 # titac5x1xsoundc.73 ASI_TX_CH3_EN Capture Switch ok 9 name.titac5x1xsoundc.73 ok 10 write_default.titac5x1xsoundc.73 ok 11 write_valid.titac5x1xsoundc.73 ok 12 write_invalid.titac5x1xsoundc.73 ok 13 event_missing.titac5x1xsoundc.73 ok 14 event_spurious.titac5x1xsoundc.73 ok 15 get_value.titac5x1xsoundc.72 # titac5x1xsoundc.72 IN2 Source Mux ok 16 name.titac5x1xsoundc.72 ok 17 write_default.titac5x1xsoundc.72 ok 18 write_valid.titac5x1xsoundc.72 ok 19 write_invalid.titac5x1xsoundc.72 ok 20 event_missing.titac5x1xsoundc.72 ok 21 event_spurious.titac5x1xsoundc.72 ok 22 get_value.titac5x1xsoundc.71 # titac5x1xsoundc.71 IN1 Source Mux ok 23 name.titac5x1xsoundc.71 ok 24 write_default.titac5x1xsoundc.71 ok 25 write_valid.titac5x1xsoundc.71 ok 26 write_invalid.titac5x1xsoundc.71 ok 27 event_missing.titac5x1xsoundc.71 ok 28 event_spurious.titac5x1xsoundc.71 ok 29 get_value.titac5x1xsoundc.70 # titac5x1xsoundc.70 ADC2 Config ok 30 name.titac5x1xsoundc.70 ok 31 write_default.titac5x1xsoundc.70 ok 32 write_valid.titac5x1xsoundc.70 ok 33 write_invalid.titac5x1xsoundc.70 ok 34 event_missing.titac5x1xsoundc.70 ok 35 event_spurious.titac5x1xsoundc.70 ok 36 get_value.titac5x1xsoundc.69 # titac5x1xsoundc.69 ADC2 Full-Scale ok 37 name.titac5x1xsoundc.69 ok 38 write_default.titac5x1xsoundc.69 ok 39 write_valid.titac5x1xsoundc.69 ok 40 write_invalid.titac5x1xsoundc.69 ok 41 event_missing.titac5x1xsoundc.69 ok 42 event_spurious.titac5x1xsoundc.69 ok 43 get_value.titac5x1xsoundc.68 # titac5x1xsoundc.68 ASI_RX_CH2_EN Switch ok 44 name.titac5x1xsoundc.68 ok 45 write_default.titac5x1xsoundc.68 ok 46 write_valid.titac5x1xsoundc.68 ok 47 write_invalid.titac5x1xsoundc.68 ok 48 event_missing.titac5x1xsoundc.68 ok 49 event_spurious.titac5x1xsoundc.68 ok 50 get_value.titac5x1xsoundc.67 # titac5x1xsoundc.67 OUT2x Driver ok 51 name.titac5x1xsoundc.67 ok 52 write_default.titac5x1xsoundc.67 ok 53 write_valid.titac5x1xsoundc.67 ok 54 write_invalid.titac5x1xsoundc.67 ok 55 event_missing.titac5x1xsoundc.67 ok 56 event_spurious.titac5x1xsoundc.67 ok 57 get_value.titac5x1xsoundc.66 # titac5x1xsoundc.66 OUT2x Config ok 58 name.titac5x1xsoundc.66 ok 59 write_default.titac5x1xsoundc.66 ok 60 write_valid.titac5x1xsoundc.66 ok 61 write_invalid.titac5x1xsoundc.66 ok 62 event_missing.titac5x1xsoundc.66 ok 63 event_spurious.titac5x1xsoundc.66 ok 64 get_value.titac5x1xsoundc.65 # titac5x1xsoundc.65 OUT2x Source ok 65 name.titac5x1xsoundc.65 ok 66 write_default.titac5x1xsoundc.65 ok 67 write_valid.titac5x1xsoundc.65 ok 68 write_invalid.titac5x1xsoundc.65 ok 69 event_missing.titac5x1xsoundc.65 ok 70 event_spurious.titac5x1xsoundc.65 ok 71 get_value.titac5x1xsoundc.64 # titac5x1xsoundc.64 ASI_RX_CH1_EN Switch ok 72 name.titac5x1xsoundc.64 ok 73 write_default.titac5x1xsoundc.64 ok 74 write_valid.titac5x1xsoundc.64 ok 75 write_invalid.titac5x1xsoundc.64 ok 76 event_missing.titac5x1xsoundc.64 ok 77 event_spurious.titac5x1xsoundc.64 ok 78 get_value.titac5x1xsoundc.63 # titac5x1xsoundc.63 OUT1x Driver ok 79 name.titac5x1xsoundc.63 ok 80 write_default.titac5x1xsoundc.63 ok 81 write_valid.titac5x1xsoundc.63 ok 82 write_invalid.titac5x1xsoundc.63 ok 83 event_missing.titac5x1xsoundc.63 ok 84 event_spurious.titac5x1xsoundc.63 ok 85 get_value.titac5x1xsoundc.62 # titac5x1xsoundc.62 OUT1x Config ok 86 name.titac5x1xsoundc.62 ok 87 write_default.titac5x1xsoundc.62 ok 88 write_valid.titac5x1xsoundc.62 ok 89 write_invalid.titac5x1xsoundc.62 ok 90 event_missing.titac5x1xsoundc.62 ok 91 event_spurious.titac5x1xsoundc.62 ok 92 get_value.titac5x1xsoundc.61 # titac5x1xsoundc.61 OUT1x Source ok 93 name.titac5x1xsoundc.61 ok 94 write_default.titac5x1xsoundc.61 ok 95 write_valid.titac5x1xsoundc.61 ok 96 write_invalid.titac5x1xsoundc.61 ok 97 event_missing.titac5x1xsoundc.61 ok 98 event_spurious.titac5x1xsoundc.61 ok 99 get_value.titac5x1xsoundc.60 # titac5x1xsoundc.60 ASI_TX_CH2_EN Capture Switch ok 100 name.titac5x1xsoundc.60 ok 101 write_default.titac5x1xsoundc.60 ok 102 write_valid.titac5x1xsoundc.60 ok 103 write_invalid.titac5x1xsoundc.60 ok 104 event_missing.titac5x1xsoundc.60 ok 105 event_spurious.titac5x1xsoundc.60 ok 106 get_value.titac5x1xsoundc.59 # titac5x1xsoundc.59 ASI_TX_CH1_EN Capture Switch ok 107 name.titac5x1xsoundc.59 ok 108 write_default.titac5x1xsoundc.59 ok 109 write_valid.titac5x1xsoundc.59 ok 110 write_invalid.titac5x1xsoundc.59 ok 111 event_missing.titac5x1xsoundc.59 ok 112 event_spurious.titac5x1xsoundc.59 ok 113 get_value.titac5x1xsoundc.58 # titac5x1xsoundc.58 ADC1 Config ok 114 name.titac5x1xsoundc.58 ok 115 write_default.titac5x1xsoundc.58 ok 116 write_valid.titac5x1xsoundc.58 ok 117 write_invalid.titac5x1xsoundc.58 ok 118 event_missing.titac5x1xsoundc.58 ok 119 event_spurious.titac5x1xsoundc.58 ok 120 get_value.titac5x1xsoundc.57 # titac5x1xsoundc.57 ADC1 Full-Scale ok 121 name.titac5x1xsoundc.57 ok 122 write_default.titac5x1xsoundc.57 ok 123 write_valid.titac5x1xsoundc.57 ok 124 write_invalid.titac5x1xsoundc.57 ok 125 event_missing.titac5x1xsoundc.57 ok 126 event_spurious.titac5x1xsoundc.57 ok 127 get_value.titac5x1xsoundc.56 # titac5x1xsoundc.56 IN_CH4_EN Capture Switch ok 128 name.titac5x1xsoundc.56 ok 129 write_default.titac5x1xsoundc.56 ok 130 write_valid.titac5x1xsoundc.56 ok 131 write_invalid.titac5x1xsoundc.56 ok 132 event_missing.titac5x1xsoundc.56 ok 133 event_spurious.titac5x1xsoundc.56 ok 134 get_value.titac5x1xsoundc.55 # titac5x1xsoundc.55 IN_CH3_EN Capture Switch ok 135 name.titac5x1xsoundc.55 ok 136 write_default.titac5x1xsoundc.55 ok 137 write_valid.titac5x1xsoundc.55 ok 138 write_invalid.titac5x1xsoundc.55 ok 139 event_missing.titac5x1xsoundc.55 ok 140 event_spurious.titac5x1xsoundc.55 ok 141 get_value.titac5x1xsoundc.54 # titac5x1xsoundc.54 IN_CH2_EN Capture Switch ok 142 name.titac5x1xsoundc.54 ok 143 write_default.titac5x1xsoundc.54 ok 144 write_valid.titac5x1xsoundc.54 ok 145 write_invalid.titac5x1xsoundc.54 ok 146 event_missing.titac5x1xsoundc.54 ok 147 event_spurious.titac5x1xsoundc.54 ok 148 get_value.titac5x1xsoundc.53 # titac5x1xsoundc.53 IN_CH1_EN Capture Switch ok 149 name.titac5x1xsoundc.53 ok 150 write_default.titac5x1xsoundc.53 ok 151 write_valid.titac5x1xsoundc.53 ok 152 write_invalid.titac5x1xsoundc.53 ok 153 event_missing.titac5x1xsoundc.53 ok 154 event_spurious.titac5x1xsoundc.53 ok 155 get_value.titac5x1xsoundc.52 # titac5x1xsoundc.52 ASI_TX_CH8_CFG ok 156 name.titac5x1xsoundc.52 ok 157 write_default.titac5x1xsoundc.52 ok 158 write_valid.titac5x1xsoundc.52 ok 159 write_invalid.titac5x1xsoundc.52 ok 160 event_missing.titac5x1xsoundc.52 ok 161 event_spurious.titac5x1xsoundc.52 ok 162 get_value.titac5x1xsoundc.51 # titac5x1xsoundc.51 ASI_TX_CH7_CFG ok 163 name.titac5x1xsoundc.51 ok 164 write_default.titac5x1xsoundc.51 ok 165 write_valid.titac5x1xsoundc.51 ok 166 write_invalid.titac5x1xsoundc.51 ok 167 event_missing.titac5x1xsoundc.51 ok 168 event_spurious.titac5x1xsoundc.51 ok 169 get_value.titac5x1xsoundc.50 # titac5x1xsoundc.50 ASI_TX_CH6_CFG ok 170 name.titac5x1xsoundc.50 ok 171 write_default.titac5x1xsoundc.50 ok 172 write_valid.titac5x1xsoundc.50 ok 173 write_invalid.titac5x1xsoundc.50 ok 174 event_missing.titac5x1xsoundc.50 ok 175 event_spurious.titac5x1xsoundc.50 ok 176 get_value.titac5x1xsoundc.49 # titac5x1xsoundc.49 ASI_TX_CH5_CFG ok 177 name.titac5x1xsoundc.49 ok 178 write_default.titac5x1xsoundc.49 ok 179 write_valid.titac5x1xsoundc.49 ok 180 write_invalid.titac5x1xsoundc.49 ok 181 event_missing.titac5x1xsoundc.49 ok 182 event_spurious.titac5x1xsoundc.49 ok 183 get_value.titac5x1xsoundc.48 # titac5x1xsoundc.48 ADC1 Phase Capture Volume ok 184 name.titac5x1xsoundc.48 ok 185 write_default.titac5x1xsoundc.48 ok 186 write_valid.titac5x1xsoundc.48 ok 187 write_invalid.titac5x1xsoundc.48 ok 188 event_missing.titac5x1xsoundc.48 ok 189 event_spurious.titac5x1xsoundc.48 ok 190 get_value.titac5x1xsoundc.47 # titac5x1xsoundc.47 ADC1 Fine Capture Volume ok 191 name.titac5x1xsoundc.47 ok 192 write_default.titac5x1xsoundc.47 ok 193 write_valid.titac5x1xsoundc.47 ok 194 write_invalid.titac5x1xsoundc.47 ok 195 event_missing.titac5x1xsoundc.47 ok 196 event_spurious.titac5x1xsoundc.47 ok 197 get_value.titac5x1xsoundc.46 # titac5x1xsoundc.46 ADC1 Digital Capture Volume ok 198 name.titac5x1xsoundc.46 ok 199 write_default.titac5x1xsoundc.46 ok 200 write_valid.titac5x1xsoundc.46 ok 201 write_invalid.titac5x1xsoundc.46 ok 202 event_missing.titac5x1xsoundc.46 ok 203 event_spurious.titac5x1xsoundc.46 ok 204 get_value.titac5x1xsoundc.45 # titac5x1xsoundc.45 ADC1 Audio BW ok 205 name.titac5x1xsoundc.45 ok 206 write_default.titac5x1xsoundc.45 ok 207 write_valid.titac5x1xsoundc.45 ok 208 write_invalid.titac5x1xsoundc.45 ok 209 event_missing.titac5x1xsoundc.45 ok 210 event_spurious.titac5x1xsoundc.45 ok 211 get_value.titac5x1xsoundc.44 # titac5x1xsoundc.44 Record Decimation Filter ok 212 name.titac5x1xsoundc.44 ok 213 write_default.titac5x1xsoundc.44 ok 214 write_valid.titac5x1xsoundc.44 ok 215 write_invalid.titac5x1xsoundc.44 ok 216 event_missing.titac5x1xsoundc.44 ok 217 event_spurious.titac5x1xsoundc.44 ok 218 get_value.titac5x1xsoundc.43 # titac5x1xsoundc.43 PDM4 Phase Capture Volume ok 219 name.titac5x1xsoundc.43 ok 220 write_default.titac5x1xsoundc.43 ok 221 write_valid.titac5x1xsoundc.43 ok 222 write_invalid.titac5x1xsoundc.43 ok 223 event_missing.titac5x1xsoundc.43 ok 224 event_spurious.titac5x1xsoundc.43 ok 225 get_value.titac5x1xsoundc.42 # titac5x1xsoundc.42 PDM3 Phase Capture Volume ok 226 name.titac5x1xsoundc.42 ok 227 write_default.titac5x1xsoundc.42 ok 228 write_valid.titac5x1xsoundc.42 ok 229 write_invalid.titac5x1xsoundc.42 ok 230 event_missing.titac5x1xsoundc.42 ok 231 event_spurious.titac5x1xsoundc.42 ok 232 get_value.titac5x1xsoundc.41 # titac5x1xsoundc.41 PDM4 Fine Capture Volume ok 233 name.titac5x1xsoundc.41 ok 234 write_default.titac5x1xsoundc.41 ok 235 write_valid.titac5x1xsoundc.41 ok 236 write_invalid.titac5x1xsoundc.41 ok 237 event_missing.titac5x1xsoundc.41 ok 238 event_spurious.titac5x1xsoundc.41 ok 239 get_value.titac5x1xsoundc.40 # titac5x1xsoundc.40 PDM3 Fine Capture Volume ok 240 name.titac5x1xsoundc.40 ok 241 write_default.titac5x1xsoundc.40 ok 242 write_valid.titac5x1xsoundc.40 ok 243 write_invalid.titac5x1xsoundc.40 ok 244 event_missing.titac5x1xsoundc.40 ok 245 event_spurious.titac5x1xsoundc.40 ok 246 get_value.titac5x1xsoundc.39 # titac5x1xsoundc.39 PDM4 Digital Capture Volume ok 247 name.titac5x1xsoundc.39 ok 248 write_default.titac5x1xsoundc.39 ok 249 write_valid.titac5x1xsoundc.39 ok 250 write_invalid.titac5x1xsoundc.39 ok 251 event_missing.titac5x1xsoundc.39 ok 252 event_spurious.titac5x1xsoundc.39 ok 253 get_value.titac5x1xsoundc.38 # titac5x1xsoundc.38 PDM3 Digital Capture Volume ok 254 name.titac5x1xsoundc.38 ok 255 write_default.titac5x1xsoundc.38 ok 256 write_valid.titac5x1xsoundc.38 ok 257 write_invalid.titac5x1xsoundc.38 ok 258 event_missing.titac5x1xsoundc.38 ok 259 event_spurious.titac5x1xsoundc.38 ok 260 get_value.titac5x1xsoundc.37 # titac5x1xsoundc.37 PDM2 Phase Capture Volume ok 261 name.titac5x1xsoundc.37 ok 262 write_default.titac5x1xsoundc.37 ok 263 write_valid.titac5x1xsoundc.37 ok 264 write_invalid.titac5x1xsoundc.37 ok 265 event_missing.titac5x1xsoundc.37 ok 266 event_spurious.titac5x1xsoundc.37 ok 267 get_value.titac5x1xsoundc.36 # titac5x1xsoundc.36 PDM1 Phase Capture Volume ok 268 name.titac5x1xsoundc.36 ok 269 write_default.titac5x1xsoundc.36 ok 270 write_valid.titac5x1xsoundc.36 ok 271 write_invalid.titac5x1xsoundc.36 ok 272 event_missing.titac5x1xsoundc.36 ok 273 event_spurious.titac5x1xsoundc.36 ok 274 get_value.titac5x1xsoundc.35 # titac5x1xsoundc.35 PDM2 Fine Capture Volume ok 275 name.titac5x1xsoundc.35 ok 276 write_default.titac5x1xsoundc.35 ok 277 write_valid.titac5x1xsoundc.35 ok 278 write_invalid.titac5x1xsoundc.35 ok 279 event_missing.titac5x1xsoundc.35 ok 280 event_spurious.titac5x1xsoundc.35 ok 281 get_value.titac5x1xsoundc.34 # titac5x1xsoundc.34 PDM1 Fine Capture Volume ok 282 name.titac5x1xsoundc.34 ok 283 write_default.titac5x1xsoundc.34 ok 284 write_valid.titac5x1xsoundc.34 ok 285 write_invalid.titac5x1xsoundc.34 ok 286 event_missing.titac5x1xsoundc.34 ok 287 event_spurious.titac5x1xsoundc.34 ok 288 get_value.titac5x1xsoundc.33 # titac5x1xsoundc.33 PDM2 Digital Capture Volume ok 289 name.titac5x1xsoundc.33 ok 290 write_default.titac5x1xsoundc.33 ok 291 write_valid.titac5x1xsoundc.33 ok 292 write_invalid.titac5x1xsoundc.33 ok 293 event_missing.titac5x1xsoundc.33 ok 294 event_spurious.titac5x1xsoundc.33 ok 295 get_value.titac5x1xsoundc.32 # titac5x1xsoundc.32 PDM1 Digital Capture Volume ok 296 name.titac5x1xsoundc.32 ok 297 write_default.titac5x1xsoundc.32 ok 298 write_valid.titac5x1xsoundc.32 ok 299 write_invalid.titac5x1xsoundc.32 ok 300 event_missing.titac5x1xsoundc.32 ok 301 event_spurious.titac5x1xsoundc.32 ok 302 get_value.titac5x1xsoundc.31 # titac5x1xsoundc.31 PDM Clk Divider ok 303 name.titac5x1xsoundc.31 ok 304 write_default.titac5x1xsoundc.31 ok 305 write_valid.titac5x1xsoundc.31 ok 306 write_invalid.titac5x1xsoundc.31 ok 307 event_missing.titac5x1xsoundc.31 ok 308 event_spurious.titac5x1xsoundc.31 ok 309 get_value.titac5x1xsoundc.30 # titac5x1xsoundc.30 DAC2 Audio BW ok 310 name.titac5x1xsoundc.30 ok 311 write_default.titac5x1xsoundc.30 ok 312 write_valid.titac5x1xsoundc.30 ok 313 write_invalid.titac5x1xsoundc.30 ok 314 event_missing.titac5x1xsoundc.30 ok 315 event_spurious.titac5x1xsoundc.30 ok 316 get_value.titac5x1xsoundc.29 # titac5x1xsoundc.29 DAC2 CHB Gain Calibration Playback Volume ok 317 name.titac5x1xsoundc.29 ok 318 write_default.titac5x1xsoundc.29 ok 319 write_valid.titac5x1xsoundc.29 ok 320 write_invalid.titac5x1xsoundc.29 ok 321 event_missing.titac5x1xsoundc.29 ok 322 event_spurious.titac5x1xsoundc.29 ok 323 get_value.titac5x1xsoundc.28 # titac5x1xsoundc.28 DAC2 CHA Gain Calibration Playback Volume ok 324 name.titac5x1xsoundc.28 ok 325 write_default.titac5x1xsoundc.28 ok 326 write_valid.titac5x1xsoundc.28 ok 327 write_invalid.titac5x1xsoundc.28 ok 328 event_missing.titac5x1xsoundc.28 ok 329 event_spurious.titac5x1xsoundc.28 ok 330 get_value.titac5x1xsoundc.27 # titac5x1xsoundc.27 DAC2 CHB Digital Playback Volume ok 331 name.titac5x1xsoundc.27 ok 332 write_default.titac5x1xsoundc.27 ok 333 write_valid.titac5x1xsoundc.27 ok 334 write_invalid.titac5x1xsoundc.27 ok 335 event_missing.titac5x1xsoundc.27 ok 336 event_spurious.titac5x1xsoundc.27 ok 337 get_value.titac5x1xsoundc.26 # titac5x1xsoundc.26 DAC2 CHA Digital Playback Volume ok 338 name.titac5x1xsoundc.26 ok 339 write_default.titac5x1xsoundc.26 ok 340 write_valid.titac5x1xsoundc.26 ok 341 write_invalid.titac5x1xsoundc.26 ok 342 event_missing.titac5x1xsoundc.26 ok 343 event_spurious.titac5x1xsoundc.26 ok 344 get_value.titac5x1xsoundc.25 # titac5x1xsoundc.25 OUT2M Analog Level Playback Volume ok 345 name.titac5x1xsoundc.25 ok 346 write_default.titac5x1xsoundc.25 ok 347 write_valid.titac5x1xsoundc.25 ok 348 write_invalid.titac5x1xsoundc.25 ok 349 event_missing.titac5x1xsoundc.25 ok 350 event_spurious.titac5x1xsoundc.25 ok 351 get_value.titac5x1xsoundc.24 # titac5x1xsoundc.24 OUT2P Analog Level Playback Volume ok 352 name.titac5x1xsoundc.24 ok 353 write_default.titac5x1xsoundc.24 ok 354 write_valid.titac5x1xsoundc.24 ok 355 write_invalid.titac5x1xsoundc.24 ok 356 event_missing.titac5x1xsoundc.24 ok 357 event_spurious.titac5x1xsoundc.24 ok 358 get_value.titac5x1xsoundc.23 # titac5x1xsoundc.23 ADC2 Phase Capture Volume ok 359 name.titac5x1xsoundc.23 ok 360 write_default.titac5x1xsoundc.23 ok 361 write_valid.titac5x1xsoundc.23 ok 362 write_invalid.titac5x1xsoundc.23 ok 363 event_missing.titac5x1xsoundc.23 ok 364 event_spurious.titac5x1xsoundc.23 ok 365 get_value.titac5x1xsoundc.22 # titac5x1xsoundc.22 ADC2 Fine Capture Volume ok 366 name.titac5x1xsoundc.22 ok 367 write_default.titac5x1xsoundc.22 ok 368 write_valid.titac5x1xsoundc.22 ok 369 write_invalid.titac5x1xsoundc.22 ok 370 event_missing.titac5x1xsoundc.22 ok 371 event_spurious.titac5x1xsoundc.22 ok 372 get_value.titac5x1xsoundc.21 # titac5x1xsoundc.21 ADC2 Digital Capture Volume ok 373 name.titac5x1xsoundc.21 ok 374 write_default.titac5x1xsoundc.21 ok 375 write_valid.titac5x1xsoundc.21 ok 376 write_invalid.titac5x1xsoundc.21 ok 377 event_missing.titac5x1xsoundc.21 ok 378 event_spurious.titac5x1xsoundc.21 ok 379 get_value.titac5x1xsoundc.20 # titac5x1xsoundc.20 ADC2 Audio BW ok 380 name.titac5x1xsoundc.20 ok 381 write_default.titac5x1xsoundc.20 ok 382 write_valid.titac5x1xsoundc.20 ok 383 write_invalid.titac5x1xsoundc.20 ok 384 event_missing.titac5x1xsoundc.20 ok 385 event_spurious.titac5x1xsoundc.20 ok 386 get_value.titac5x1xsoundc.19 # titac5x1xsoundc.19 OUT_CH4_EN Playback Switch ok 387 name.titac5x1xsoundc.19 ok 388 write_default.titac5x1xsoundc.19 ok 389 write_valid.titac5x1xsoundc.19 ok 390 write_invalid.titac5x1xsoundc.19 ok 391 event_missing.titac5x1xsoundc.19 ok 392 event_spurious.titac5x1xsoundc.19 ok 393 get_value.titac5x1xsoundc.18 # titac5x1xsoundc.18 OUT_CH3_EN Playback Switch ok 394 name.titac5x1xsoundc.18 ok 395 write_default.titac5x1xsoundc.18 ok 396 write_valid.titac5x1xsoundc.18 ok 397 write_invalid.titac5x1xsoundc.18 ok 398 event_missing.titac5x1xsoundc.18 ok 399 event_spurious.titac5x1xsoundc.18 ok 400 get_value.titac5x1xsoundc.17 # titac5x1xsoundc.17 OUT_CH2_EN Playback Switch ok 401 name.titac5x1xsoundc.17 ok 402 write_default.titac5x1xsoundc.17 ok 403 write_valid.titac5x1xsoundc.17 ok 404 write_invalid.titac5x1xsoundc.17 ok 405 event_missing.titac5x1xsoundc.17 ok 406 event_spurious.titac5x1xsoundc.17 ok 407 get_value.titac5x1xsoundc.16 # titac5x1xsoundc.16 OUT_CH1_EN Playback Switch ok 408 name.titac5x1xsoundc.16 ok 409 write_default.titac5x1xsoundc.16 ok 410 write_valid.titac5x1xsoundc.16 ok 411 write_invalid.titac5x1xsoundc.16 ok 412 event_missing.titac5x1xsoundc.16 ok 413 event_spurious.titac5x1xsoundc.16 ok 414 get_value.titac5x1xsoundc.15 # titac5x1xsoundc.15 ASI_RX_CH8_EN Playback ok 415 name.titac5x1xsoundc.15 ok 416 write_default.titac5x1xsoundc.15 ok 417 write_valid.titac5x1xsoundc.15 ok 418 write_invalid.titac5x1xsoundc.15 ok 419 event_missing.titac5x1xsoundc.15 ok 420 event_spurious.titac5x1xsoundc.15 ok 421 get_value.titac5x1xsoundc.14 # titac5x1xsoundc.14 ASI_RX_CH7_EN Playback ok 422 name.titac5x1xsoundc.14 ok 423 write_default.titac5x1xsoundc.14 ok 424 write_valid.titac5x1xsoundc.14 ok 425 write_invalid.titac5x1xsoundc.14 ok 426 event_missing.titac5x1xsoundc.14 ok 427 event_spurious.titac5x1xsoundc.14 ok 428 get_value.titac5x1xsoundc.13 # titac5x1xsoundc.13 ASI_RX_CH6_EN Playback ok 429 name.titac5x1xsoundc.13 ok 430 write_default.titac5x1xsoundc.13 ok 431 write_valid.titac5x1xsoundc.13 ok 432 write_invalid.titac5x1xsoundc.13 ok 433 event_missing.titac5x1xsoundc.13 ok 434 event_spurious.titac5x1xsoundc.13 ok 435 get_value.titac5x1xsoundc.12 # titac5x1xsoundc.12 ASI_RX_CH5_EN Playback ok 436 name.titac5x1xsoundc.12 ok 437 write_default.titac5x1xsoundc.12 ok 438 write_valid.titac5x1xsoundc.12 ok 439 write_invalid.titac5x1xsoundc.12 ok 440 event_missing.titac5x1xsoundc.12 ok 441 event_spurious.titac5x1xsoundc.12 ok 442 get_value.titac5x1xsoundc.11 # titac5x1xsoundc.11 ASI_RX_CH4_EN Playback Switch ok 443 name.titac5x1xsoundc.11 ok 444 write_default.titac5x1xsoundc.11 ok 445 write_valid.titac5x1xsoundc.11 ok 446 write_invalid.titac5x1xsoundc.11 ok 447 event_missing.titac5x1xsoundc.11 ok 448 event_spurious.titac5x1xsoundc.11 ok 449 get_value.titac5x1xsoundc.10 # titac5x1xsoundc.10 ASI_RX_CH3_EN Playback Switch ok 450 name.titac5x1xsoundc.10 ok 451 write_default.titac5x1xsoundc.10 ok 452 write_valid.titac5x1xsoundc.10 ok 453 write_invalid.titac5x1xsoundc.10 ok 454 event_missing.titac5x1xsoundc.10 ok 455 event_spurious.titac5x1xsoundc.10 ok 456 get_value.titac5x1xsoundc.9 # titac5x1xsoundc.9 DAC1 CHB Gain Calibration Playback Volume ok 457 name.titac5x1xsoundc.9 ok 458 write_default.titac5x1xsoundc.9 ok 459 write_valid.titac5x1xsoundc.9 ok 460 write_invalid.titac5x1xsoundc.9 ok 461 event_missing.titac5x1xsoundc.9 ok 462 event_spurious.titac5x1xsoundc.9 ok 463 get_value.titac5x1xsoundc.8 # titac5x1xsoundc.8 DAC1 CHA Gain Calibration Playback Volume ok 464 name.titac5x1xsoundc.8 ok 465 write_default.titac5x1xsoundc.8 ok 466 write_valid.titac5x1xsoundc.8 ok 467 write_invalid.titac5x1xsoundc.8 ok 468 event_missing.titac5x1xsoundc.8 ok 469 event_spurious.titac5x1xsoundc.8 ok 470 get_value.titac5x1xsoundc.7 # titac5x1xsoundc.7 DAC1 CHB Digital Playback Volume ok 471 name.titac5x1xsoundc.7 ok 472 write_default.titac5x1xsoundc.7 ok 473 write_valid.titac5x1xsoundc.7 ok 474 write_invalid.titac5x1xsoundc.7 ok 475 event_missing.titac5x1xsoundc.7 ok 476 event_spurious.titac5x1xsoundc.7 ok 477 get_value.titac5x1xsoundc.6 # titac5x1xsoundc.6 DAC1 CHA Digital Playback Volume ok 478 name.titac5x1xsoundc.6 ok 479 write_default.titac5x1xsoundc.6 ok 480 write_valid.titac5x1xsoundc.6 ok 481 write_invalid.titac5x1xsoundc.6 ok 482 event_missing.titac5x1xsoundc.6 ok 483 event_spurious.titac5x1xsoundc.6 ok 484 get_value.titac5x1xsoundc.5 # titac5x1xsoundc.5 OUT1M Analog Level Playback Volume ok 485 name.titac5x1xsoundc.5 ok 486 write_default.titac5x1xsoundc.5 ok 487 write_valid.titac5x1xsoundc.5 ok 488 write_invalid.titac5x1xsoundc.5 ok 489 event_missing.titac5x1xsoundc.5 ok 490 event_spurious.titac5x1xsoundc.5 ok 491 get_value.titac5x1xsoundc.4 # titac5x1xsoundc.4 OUT1P Analog Level Playback Volume ok 492 name.titac5x1xsoundc.4 ok 493 write_default.titac5x1xsoundc.4 ok 494 write_valid.titac5x1xsoundc.4 ok 495 write_invalid.titac5x1xsoundc.4 ok 496 event_missing.titac5x1xsoundc.4 ok 497 event_spurious.titac5x1xsoundc.4 ok 498 get_value.titac5x1xsoundc.3 # titac5x1xsoundc.3 DAC1 Audio BW ok 499 name.titac5x1xsoundc.3 ok 500 write_default.titac5x1xsoundc.3 ok 501 write_valid.titac5x1xsoundc.3 ok 502 write_invalid.titac5x1xsoundc.3 ok 503 event_missing.titac5x1xsoundc.3 ok 504 event_spurious.titac5x1xsoundc.3 ok 505 get_value.titac5x1xsoundc.2 # titac5x1xsoundc.2 Playback Decimation Filter ok 506 name.titac5x1xsoundc.2 ok 507 write_default.titac5x1xsoundc.2 ok 508 write_valid.titac5x1xsoundc.2 ok 509 write_invalid.titac5x1xsoundc.2 ok 510 event_missing.titac5x1xsoundc.2 ok 511 event_spurious.titac5x1xsoundc.2 ok 512 get_value.titac5x1xsoundc.1 # titac5x1xsoundc.1 ADC2 Common-mode Tolerance ok 513 name.titac5x1xsoundc.1 ok 514 write_default.titac5x1xsoundc.1 ok 515 write_valid.titac5x1xsoundc.1 ok 516 write_invalid.titac5x1xsoundc.1 ok 517 event_missing.titac5x1xsoundc.1 ok 518 event_spurious.titac5x1xsoundc.1 ok 519 get_value.titac5x1xsoundc.0 # titac5x1xsoundc.0 ADC1 Common-mode Tolerance ok 520 name.titac5x1xsoundc.0 ok 521 write_default.titac5x1xsoundc.0 ok 522 write_valid.titac5x1xsoundc.0 ok 523 write_invalid.titac5x1xsoundc.0 ok 524 event_missing.titac5x1xsoundc.0 ok 525 event_spurious.titac5x1xsoundc.0 # Totals: pass:525 fail:0 xfail:0 xpass:0 skip:0 error:0
Niranjan H Y (4):
ASoc: tac5x1x: add codec driver tac5x1x family
dt-bindings: sound: bindings for tac5x1x family of codecs
Asoc: pcm6240: remove support for taac5x1x family
dt-bindings: sound: device support list for pcm6240
.../devicetree/bindings/sound/ti,pcm6240.yaml | 10 - .../devicetree/bindings/sound/ti,tac5x1x.yaml | 262 ++ sound/soc/codecs/Kconfig | 12 + sound/soc/codecs/Makefile | 2 + sound/soc/codecs/pcm6240.c | 126 +- sound/soc/codecs/pcm6240.h | 4 - sound/soc/codecs/tac5x1x-i2c.c | 2137 +++++++++++++++++ sound/soc/codecs/tac5x1x.h | 300 +++ 8 files changed, 2716 insertions(+), 137 deletions(-) create mode 100644 Documentation/devicetree/bindings/sound/ti,tac5x1x.yaml create mode 100644 sound/soc/codecs/tac5x1x-i2c.c create mode 100644 sound/soc/codecs/tac5x1x.h
Signature · 1 line
2.45.2
PATCH v3 1/4 ASoc: tac5x1x: add codec driver tac5x1x family
tac5x1x family are series of low-power and high performance mono/stereo audio codecs consists of ADC and DAC combinations. The patch adds supports for Codecs(DAC & ADC), ADC only and DAC only configurations available in the tac5x1x family.
---
v2:
- Merge tac5x1x and tac5x1x-i2c into one tac5x1x-i2c
- Kconfig changes for
* merge to removed SND_SOC_TAC5X1X
* select REGMAP_I2C for SND_SOC_TAC5X1X_I2C
- Makefile changes for
* merging tac5x1x and tac5x1x-i2c
* sorted entry added for tac5x1x-i2c
- Removed a unwanted log during probe
- Removed "Reserved" keyword for bitmask
- Removed retry with sleep logic for regmap read/write
- Refactored interrupt handling code to have only thread function. Removed work function for interrupt handling. Also removed disabling/enabling interrupts in thread function.
- Replace EXPORT_SYMBOL to EXPORT_SYMBOL_GPL for tac5x1x_regmap
- Moved impedance related settings to DTS
- Used plain control for on/off switch for DAC related channel controls.
- Removed TDM slot selection mixer control. Configured the slot for the I2S mode during the .hw_params call
- Moved some ADC related settings to device tree as they are one time configurations.
- Replaced regulator APIs with regulator bulk APIs
- Moved cache sync after regulator enable during _resume
- Removed unwanted member variables
- Fixed "mixer control" error with certain dts configurations
- Fixed number of chars more than 80 for many lines
v3:
- dev_err to dev_dbg for interrupt and return IRQ_NONE on latch read error
- Removed read only mixer control to check the GPIO settings
- Removed pdm data in pin selection from mixer control and moved the configuration to dts
- moved the reset to i2c_probe
- refactored the device initialisation code
- replace dev_err with dev_dbg for the non-mandatory dts entry parse errors
- made tac5x1x_of_match as static
--- sound/soc/codecs/Kconfig | 12 + sound/soc/codecs/Makefile | 2 + sound/soc/codecs/tac5x1x-i2c.c | 2137 ++++++++++++++++++++++++++++++++ sound/soc/codecs/tac5x1x.h | 300 +++++ 4 files changed, 2451 insertions(+) create mode 100644 sound/soc/codecs/tac5x1x-i2c.c create mode 100644 sound/soc/codecs/tac5x1x.h
sound/soc/codecs/Kconfig +12 -0
@@ -259,6 +259,7 @@ config SND_SOC_ALL_CODECS imply SND_SOC_STA529 imply SND_SOC_STAC9766 imply SND_SOC_STI_SAS + imply SND_SOC_TAC5X1X_I2C imply SND_SOC_TAS2552 imply SND_SOC_TAS2562 imply SND_SOC_TAS2764
@@ -2008,6 +2009,17 @@ config SND_SOC_STAC9766 config SND_SOC_STI_SAS tristate "codec Audio support for STI SAS codec" +config SND_SOC_TAC5X1X_I2C + tristate "Texas Instruments TAC5X1X family driver based on I2C" + depends on I2C && REGMAP_I2C + select REGMAP_I2C + help + Enable support for Texas Instruments TAC5X1X family Audio chips. + The family consists mono/stereo audio codecs, DACs and ADCs. + Includes support for TAC5311-Q1, TAC5411-Q1, TAC5111, TAC5211, + TAA5212, TAA5412-Q1, TAD5112, TAD5212, TAC5312, TAC5412-Q1, + TAC5112, TAC5212 + config SND_SOC_TAS2552 tristate "Texas Instruments TAS2552 Mono Audio amplifier" depends on I2C
sound/soc/codecs/Makefile +2 -0
@@ -303,6 +303,7 @@ snd-soc-sta350-y := sta350.o snd-soc-sta529-y := sta529.o snd-soc-stac9766-y := stac9766.o snd-soc-sti-sas-y := sti-sas.o +snd-soc-tac5x1x-i2c-y := tac5x1x-i2c.o snd-soc-tas5086-y := tas5086.o snd-soc-tas571x-y := tas571x.o snd-soc-tas5720-y := tas5720.o
@@ -721,6 +722,7 @@ obj-$(CONFIG_SND_SOC_STA350) += snd-soc-sta350.o obj-$(CONFIG_SND_SOC_STA529) += snd-soc-sta529.o obj-$(CONFIG_SND_SOC_STAC9766) += snd-soc-stac9766.o obj-$(CONFIG_SND_SOC_STI_SAS) += snd-soc-sti-sas.o +obj-$(CONFIG_SND_SOC_TAC5X1X_I2C) += snd-soc-tac5x1x-i2c.o obj-$(CONFIG_SND_SOC_TAS2552) += snd-soc-tas2552.o obj-$(CONFIG_SND_SOC_TAS2562) += snd-soc-tas2562.o obj-$(CONFIG_SND_SOC_TAS2764) += snd-soc-tas2764.o
sound/soc/codecs/tac5x1x-i2c.c new file +2137 -0
2,137 lines not on this page · raw message
sound/soc/codecs/tac5x1x.h new file +300 -0
300 lines not on this page · raw message
Signature · 1 line
2.45.2
Re: [PATCH v3 1/4] ASoc: tac5x1x: add codec driver tac5x1x family
Quoted 8 lines · Niranjan H Y
tac5x1x family are series of low-power and high performance mono/stereo audio codecs consists of ADC and DAC combinations. The patch adds supports for
Codecs(DAC & ADC), ADC only and DAC only configurations available in the tac5x1x family.Signed-off-by Niranjan H Y <[email protected]>---
Organize your patches correctly - you cannot have user of binding before that binding is documented. See submitting patches and writing bindings in DT dir.
Best regards,
Krzysztof
kernel test robot
build botRe: [PATCH v3 1/4] ASoc: tac5x1x: add codec driver tac5x1x family
In reply to Niranjan H Ykernel test robot noticed the following build errors:
Hi Niranjan,
kernel test robot noticed the following build errors:
[auto build test ERROR on broonie-sound/for-next]
[also build test ERROR on linus/master v6.16-rc3 next-20250627] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Niranjan-H-Y/ASoc-tac5x1x-add-codec-driver-tac5x1x-family/20250627-021555 base: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next patch link: https://lore.kernel.org/r/20250626181334.1200-2-niranjan.hy%40ti.com patch subject: [PATCH v3 1/4] ASoc: tac5x1x: add codec driver tac5x1x family config: x86_64-kexec (attached as .config) compiler: clang version 20.1.7 (https://github.com/llvm/llvm-project 6146a88f60492b520a36f8f8f3231e15f3cc6082) reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250627/[email protected]/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <[email protected]>
| Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/
All errors (new ones prefixed by >>):
>> error: recursive dependency detected!
symbol REGMAP_I2C is selected by SND_SOC_TAC5X1X_I2C symbol SND_SOC_TAC5X1X_I2C depends on REGMAP_I2C
For a resolution refer to Documentation/kbuild/kconfig-language.rst subsection "Kconfig recursive dependency limitations"
Signature · 2 lines
0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki
Mark Brown
maintainerRe: [PATCH v3 1/4] ASoc: tac5x1x: add codec driver tac5x1x family
In reply to Niranjan H YQuoted 4 lines · Niranjan H Y
tac5x1x family are series of low-power and high performance mono/stereo audio codecs consists of ADC and DAC combinations. The patch adds supports for
Codecs(DAC & ADC), ADC only and DAC only configurations available in the tac5x1x family.
This looks basically good from a driver point of view, but I see there will be some more changes needed due to the DT bindings review.
PATCH v3 2/4 dt-bindings: sound: bindings for tac5x1x family of codecs
In reply to Niranjan H Ytac5x1x family are series of low-power and high performance mono/stereo audio codecs consists of ADC and DAC combinations. The family consist of Codecs(DAC & ADC), ADC only and DAC only configurations. The documentation explains the list of devices in the family, their power supply configurations and gpio configuration options available for various functionality.
---
v2:
- Document newly added dts entries ti,adc1-impedance, ti,adc2-impedance, ti,out2x-vcom-cfg
v3:
- add documentation for ti,pdm-input-pins
- Update required section
--- .../devicetree/bindings/sound/ti,tac5x1x.yaml | 262 ++++++++++++++++++ 1 file changed, 262 insertions(+) create mode 100644 Documentation/devicetree/bindings/sound/ti,tac5x1x.yaml
Documentation/devicetree/bindings/sound/ti,tac5x1x.yaml new file +262 -0
@@ -0,0 +1,262 @@ +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause +# Copyright (C) 2025 Texas Instruments Incorporated +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/sound/ti,tac5x1x.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Texas Instruments TAC5X1X Codec + +description: | + TAC5X1X are series of low-power and high performance mono or stereo + audio codecs, as well as multiple inputs and outputs programmable in + single-ended or fully differential configurations. Device supports both + Microphone and Line In input on ADC Channel. DAC Output can be configured + for either Line Out or Head Phone Load. + + The serial control bus supports SPI or I2C protocols, while the serial audio + data bus is programmable for I2S, left/right-justified, DSP, or TDM modes. + + Specification about the codecs can be found at: + https://www.ti.com/lit/gpn/taa5212 + https://www.ti.com/lit/gpn/taa5412-q1 + https://www.ti.com/lit/gpn/tac5111 + https://www.ti.com/lit/gpn/tac5112 + https://www.ti.com/lit/gpn/tac5211 + https://www.ti.com/lit/gpn/tac5212 + https://www.ti.com/lit/gpn/tac5311-q1 + https://www.ti.com/lit/gpn/tac5312-q1 + https://www.ti.com/lit/gpn/tac5411-q1 + https://www.ti.com/lit/gpn/tac5412-q1 + https://www.ti.com/lit/gpn/tad5112 + https://www.ti.com/lit/gpn/tad5212 + +maintainers: + - Niranjan H Y <[email protected]> + - Kevin Lu <[email protected]> + +properties: + compatible: + enum: + - ti,taa5212 + - ti,taa5412 + - ti,tac5111 + - ti,tac5112 + - ti,tac5211 + - ti,tac5212 + - ti,tac5311 + - ti,tac5312 + - ti,tac5411 + - ti,tac5412 + - ti,tad5112 + - ti,tad5212 + + reg: + maxItems: 1 + + ti,vref: + description: VREF required voltage. If node is omitted then VREF is powered down. + $ref: /schemas/types.yaml#/definitions/uint32 + oneOf: + - const: 0 + description: VREF output is powered to 2.75V. + - const: 1 + description: VREF output is powered to 2.5V. + - const: 2 + description: VREF output is powered to 1.375V. + + ti,micbias-vg: + description: MicBias required voltage. If node is omitted then MicBias is powered down. + $ref: /schemas/types.yaml#/definitions/uint32 + oneOf: + - const: 0 + description: MICBIAS output is same as the VREF output + - const: 1 + description: MICBIAS output is 0.5 times the VREF output + - const: 3 + description: MICBIAS output is same as the AVDD + + avdd-supply: + description: Analog DAC voltage. + + iovdd-supply: + description: I/O voltage. + + ti,gpios-func: + description: | + Array indicating the GPIO1, GPIO2, GPO1 Functionality in the same order. + Each integer elemnent in the array represent the following + - 0 TAC5X1X_GPIO_DISABLE - GPIO is Disabled + - 1 TAC5X1X_GPIO_GPI - General Purpose Input + - 2 ADC3XXX_GPIO_GPO - General Purpose Output + - 3 TAC5X1X_GPIO_IRQ - Chip Interrupt + - 4 TAC5X1X_GPIO_PDMCLK - PDM CLK Output + - 5 TAC5X1X_GPIO_P_DOUT - Primary ASI DOUT + - 6 TAC5X1X_GPIO_P_DOUT2 - Primary ASI DOUT2 + - 7 TAC5X1X_GPIO_S_DOUT - Secondary ASI DOUT + - 8 TAC5X1X_GPIO_S_DOUT2 - Secondary ASI DOUT2 + - 9 TAC5X1X_GPIO_S_BCLK - Secondary BCLK Output + - 10 TAC5X1X_GPIO_S_FSYNC - Secondary FSYNC Output + - 11 TAC5X1X_GPIO_CLKOUT - General Purpose Output + - 12 TAC5X1X_GPIO_DOUT_MUX + - 13 TAC5X1X_GPIO_DAISY_OUT + $ref: /schemas/types.yaml#/definitions/uint32-array + minItems: 3 + maxItems: 3 + + ti,gpios-drive: + description: | + Array indicating the GPIO1, GPIO2, GPO1 Driver values + Each number in the array indicate the following driver values. + - 0 # Hi-Z Output + - 1 # Drive active low and active High + - 2 # Drive active low and weak High + - 3 # Drive acive low and Hi-Z + - 4 # Drive weak low and active High + - 5 # Drive Hi-Z and active High + $ref: /schemas/types.yaml#/definitions/uint32-array + minItems: 3 + maxItems: 3 + + ti,pdm-input-pins: + description: | + Array indicating the PDM Data Input for "Ch1 & Ch2" and "Ch3 & Ch4" + respectively. Each number in the array indicate the following + - 0 # PDM input disabled + - 1 # PDM input GPIO1 + - 2 # PDM input GPIO2 + - 3 # PDM input GPI1 + $ref: /schemas/types.yaml#/definitions/uint32-array + minItems: 2 + maxItems: 2 + + ti,gpi1-func: + description: GPI1 Functionality + $ref: /schemas/types.yaml#/definitions/uint32 + enum: + - 0 # TAC5X1X_GPIO_DISABLE - I/O buffers powered down and not used + - 1 # TAC5X1X_GPIO_GPI - General purpose input + default: 0 + + '#sound-dai-cells': + const: 0 + + clocks: + maxItems: 1 + + ti,gpa-gpio: + description: GPA using GPIO1 configuration + $ref: /schemas/types.yaml#/definitions/uint32 + enum: + - 0 # GPA using GPIO1 is disabled + - 1 # GPA using GPIO1 + default: 0 + + ti,in-ch-en: + description: Enable Input channel diagnostics for TAC54XX and TAC53XX device. + $ref: /schemas/types.yaml#/definitions/uint32 + enum: + - 0 # Disable input channel diagnostics + - 1 # Enable input channel diagnostics + + ti,out-ch-en: + description: Enable Output channel diagnostics for TAC54XX and TAC53XX device + $ref: /schemas/types.yaml#/definitions/uint32 + enum: + - 0 # Disable Output channel diagnostics + - 1 # Enable Output channel Diagnostics + + ti,incl-se-inm: + description: INxM pin Diagnostics Scan Selection for Single Ended Configuration + $ref: /schemas/types.yaml#/definitions/uint32 + enum: + - 0 # INxM pin Diagnostics Scan Selection for Single Ended excluded for diagnosis + - 1 # INxM pin Diagnostics Scan Selection for Single Ended included for diagnosis + + ti,incl-ac-coup: + description: AC coupled channels pins Scan Selection for Diagnostics + $ref: /schemas/types.yaml#/definitions/uint32 + enum: + - 0 # AC coupled channels pins Scan Selection for Diagnostics exluded for diagnosis + - 1 # AC coupled channels pins Scan Selection for Diagnostics included for diagnosis + + ti,micbias-threshold: + description: Micbias Low and High threshold values for TAC54XX and TAC53XX series + $ref: /schemas/types.yaml#/definitions/uint32-array + maxItems: 2 + minItems: 2 + items: + minimum: 72 + maximum: 162 + + ti,gpa-threshold: + description: GPA Low and High threshold Values + $ref: /schemas/types.yaml#/definitions/uint32-array + maxItems: 2 + minItems: 2 + items: + minimum: 75 + maximum: 186 + + ti,adc1-impedance: + description: Channel 1 Input Impedance Value + $ref: /schemas/types.yaml#/definitions/uint32 + enum: + - 0 # 5 kOhm + - 1 # 10 kOhm + - 2 # 40 kOhm + default: 0 + + ti,adc2-impedance: + description: Channel 2 Input Impedance Value + $ref: /schemas/types.yaml#/definitions/uint32 + enum: + - 0 # 5 kOhm + - 1 # 10 kOhm + - 2 # 40 kOhm + default: 0 + + ti,out2x-vcom-cfg: + description: Channel OUT2x VCOM configuration + $ref: /schemas/types.yaml#/definitions/uint32 + enum: + - 0 # 0.6 * Vref + - 1 # AVDD by 2 + default: 0 + +required: + - compatible + - reg + - ti,vref + - ti,micbias-vg + +additionalProperties: false + +examples: + - | + #include <dt-bindings/gpio/gpio.h> + + i2c { + #address-cells = <1>; + #size-cells = <0>; + + tac5x1x: tac5x1x@52 { + compatible = "ti,tac5212"; + reg = <0x52>; + #sound-dai-cells = <0>; + avdd-supply = <&vdd_3v3_reg>; + iovdd-supply = <&vdd_3v3_reg>; + ti,vref = <0>; + ti,micbias-vg = <3>; + ti,gpi1-func = <0>; + ti,gpios-func = <4>, <1>, <0>; + ti,gpios-drive = <0>, <0>, <0>; + ti,gpa-gpio = <0>; + ti,in-ch-en = <1>; + ti,out-ch-en = <1>; + ti,incl-ac-coup = <0>; + ti,incl-se-inm = <0>; + ti,gpa-threshold = <75>, <186>; + }; + }; +...
Signature · 1 line
2.45.2
Rob Herring (Arm)
maintainerRe: [PATCH v3 2/4] dt-bindings: sound: bindings for tac5x1x family of codecs
Quoted 16 lines · Niranjan H Y
tac5x1x family are series of low-power and high performance mono/stereo audio codecs consists of ADC and DAC combinations. The family consist of
Codecs(DAC & ADC), ADC only and DAC only configurations. The documentation explains the list of devices in the family, their power supply configurations and gpio configuration options available for various functionality.Signed-off-by Niranjan H Y <[email protected]>---
v2:
- Document newly added dts entries ti,adc1-impedance, ti,adc2-impedance, ti,out2x-vcom-cfg
v3:
- add documentation for ti,pdm-input-pins
- Update required section
Quoted 5 lines
--- .../devicetree/bindings/sound/ti,tac5x1x.yaml | 262 ++++++++++++++++++ 1 file changed, 262 insertions(+) create mode 100644 Documentation/devicetree/bindings/sound/ti,tac5x1x.yaml
My bot found errors running 'make dt_binding_check' on your patch:
yamllint warnings/errors:
dtschema/dtc warnings/errors:
Warning: Duplicate compatible "ti,taa5412" found in schemas matching "$id":
http://devicetree.org/schemas/sound/ti,pcm6240.yaml# http://devicetree.org/schemas/sound/ti,tac5x1x.yaml# Warning: Duplicate compatible "ti,taa5212" found in schemas matching "$id": http://devicetree.org/schemas/sound/ti,pcm6240.yaml# http://devicetree.org/schemas/sound/ti,tac5x1x.yaml# Warning: Duplicate compatible "ti,tad5212" found in schemas matching "$id": http://devicetree.org/schemas/sound/ti,pcm6240.yaml# http://devicetree.org/schemas/sound/ti,tac5x1x.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/sound/ti,tac5x1x.example.dtb: tac5x1x@52 (ti,tac5212): ti,gpa-gpio: 0 is not of type 'array'
from schema $id: http://devicetree.org/schemas/gpio/gpio-consumer.yaml#
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/[email protected]
The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
Re: [PATCH v3 2/4] dt-bindings: sound: bindings for tac5x1x family of codecs
In reply to Niranjan H YQuoted 76 lines · Niranjan H Y
tac5x1x family are series of low-power and high performance mono/stereo audio codecs consists of ADC and DAC combinations. The family consist of
Codecs(DAC & ADC), ADC only and DAC only configurations. The documentation explains the list of devices in the family, their power supply configurations and gpio configuration options available for various functionality.Signed-off-by Niranjan H Y <[email protected]>---
v2:
- Document newly added dts entries ti,adc1-impedance, ti,adc2-impedance, ti,out2x-vcom-cfg
v3:
- add documentation for ti,pdm-input-pins
- Update required section--- .../devicetree/bindings/sound/ti,tac5x1x.yaml | 262 ++++++++++++++++++ 1 file changed, 262 insertions(+) create mode 100644 Documentation/devicetree/bindings/sound/ti,tac5x1x.yamlDocumentation/devicetree/bindings/sound/ti,tac5x1x.yaml new file +49
-0@@ -0,0 +1,262 @@ +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause +# Copyright (C) 2025 Texas Instruments Incorporated +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/sound/ti,tac5x1x.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Texas Instruments TAC5X1X Codec + +description: | + TAC5X1X are series of low-power and high performance mono or stereo + audio codecs, as well as multiple inputs and outputs programmable in + single-ended or fully differential configurations. Device supports both + Microphone and Line In input on ADC Channel. DAC Output can be configured + for either Line Out or Head Phone Load. + + The serial control bus supports SPI or I2C protocols, while the serial audio + data bus is programmable for I2S, left/right-justified, DSP, or TDM modes. + + Specification about the codecs can be found at: + https://www.ti.com/lit/gpn/taa5212 + https://www.ti.com/lit/gpn/taa5412-q1 + https://www.ti.com/lit/gpn/tac5111 + https://www.ti.com/lit/gpn/tac5112 + https://www.ti.com/lit/gpn/tac5211 + https://www.ti.com/lit/gpn/tac5212 + https://www.ti.com/lit/gpn/tac5311-q1 + https://www.ti.com/lit/gpn/tac5312-q1 + https://www.ti.com/lit/gpn/tac5411-q1 + https://www.ti.com/lit/gpn/tac5412-q1 + https://www.ti.com/lit/gpn/tad5112 + https://www.ti.com/lit/gpn/tad5212 + +maintainers: + - Niranjan H Y <[email protected]> + - Kevin Lu <[email protected]> + +properties: + compatible: + enum: + - ti,taa5212 + - ti,taa5412 + - ti,tac5111 + - ti,tac5112 + - ti,tac5211 + - ti,tac5212 + - ti,tac5311 + - ti,tac5312 + - ti,tac5411
Documentation/devicetree/bindings/sound/ti,tac5x1x.yaml line 59
Quoted 10 lines
Documentation/devicetree/bindings/sound/ti,tac5x1x.yaml new file +10
-0+ - ti,tac5412 + - ti,tad5112 + - ti,tad5212 + + reg: + maxItems: 1 + + ti,vref: + description: VREF required voltage. If node is omitted then VREF is powered down. + $ref: /schemas/types.yaml#/definitions/uint32
Voltage is in microvolt. Use proper suffix/values.
Quoted 36 lines
Documentation/devicetree/bindings/sound/ti,tac5x1x.yaml new file +36
-0+ oneOf: + - const: 0 + description: VREF output is powered to 2.75V. + - const: 1 + description: VREF output is powered to 2.5V. + - const: 2 + description: VREF output is powered to 1.375V. + + ti,micbias-vg: + description: MicBias required voltage. If node is omitted then MicBias is powered down. + $ref: /schemas/types.yaml#/definitions/uint32 + oneOf: + - const: 0 + description: MICBIAS output is same as the VREF output + - const: 1 + description: MICBIAS output is 0.5 times the VREF output + - const: 3 + description: MICBIAS output is same as the AVDD + + avdd-supply: + description: Analog DAC voltage. + + iovdd-supply: + description: I/O voltage. + + ti,gpios-func: + description: | + Array indicating the GPIO1, GPIO2, GPO1 Functionality in the same order. + Each integer elemnent in the array represent the following + - 0 TAC5X1X_GPIO_DISABLE - GPIO is Disabled + - 1 TAC5X1X_GPIO_GPI - General Purpose Input + - 2 ADC3XXX_GPIO_GPO - General Purpose Output + - 3 TAC5X1X_GPIO_IRQ - Chip Interrupt + - 4 TAC5X1X_GPIO_PDMCLK - PDM CLK Output + - 5 TAC5X1X_GPIO_P_DOUT - Primary ASI DOUT + - 6 TAC5X1X_GPIO_P_DOUT2 - Primary ASI DOUT2
Documentation/devicetree/bindings/sound/ti,tac5x1x.yaml line 105
Quoted 10 lines
Documentation/devicetree/bindings/sound/ti,tac5x1x.yaml new file +10
-0+ - 7 TAC5X1X_GPIO_S_DOUT - Secondary ASI DOUT + - 8 TAC5X1X_GPIO_S_DOUT2 - Secondary ASI DOUT2 + - 9 TAC5X1X_GPIO_S_BCLK - Secondary BCLK Output + - 10 TAC5X1X_GPIO_S_FSYNC - Secondary FSYNC Output + - 11 TAC5X1X_GPIO_CLKOUT - General Purpose Output + - 12 TAC5X1X_GPIO_DOUT_MUX + - 13 TAC5X1X_GPIO_DAISY_OUT + $ref: /schemas/types.yaml#/definitions/uint32-array + minItems: 3 + maxItems: 3
Don't encode gpios and pins as some custom properties.
Quoted 4 lines
Documentation/devicetree/bindings/sound/ti,tac5x1x.yaml new file +4
-0+ + ti,gpios-drive: + description: | + Array indicating the GPIO1, GPIO2, GPO1 Driver values
Documentation/devicetree/bindings/sound/ti,tac5x1x.yaml line 119
Quoted 10 lines
Documentation/devicetree/bindings/sound/ti,tac5x1x.yaml new file +10
-0+ Each number in the array indicate the following driver values. + - 0 # Hi-Z Output + - 1 # Drive active low and active High + - 2 # Drive active low and weak High + - 3 # Drive acive low and Hi-Z + - 4 # Drive weak low and active High + - 5 # Drive Hi-Z and active High + $ref: /schemas/types.yaml#/definitions/uint32-array + minItems: 3 + maxItems: 3
Use standard pinctrl bindings.
Documentation/devicetree/bindings/sound/ti,tac5x1x.yaml line 132
Quoted 13 lines
Documentation/devicetree/bindings/sound/ti,tac5x1x.yaml new file +13
-0+ + ti,pdm-input-pins: + description: | + Array indicating the PDM Data Input for "Ch1 & Ch2" and "Ch3 & Ch4" + respectively. Each number in the array indicate the following + - 0 # PDM input disabled + - 1 # PDM input GPIO1 + - 2 # PDM input GPIO2 + - 3 # PDM input GPI1 + $ref: /schemas/types.yaml#/definitions/uint32-array + minItems: 2 + maxItems: 2 +
This is v3, but changelog is scarce, no cover letter, no other lore references. All this is questionable. Plus the style mixing vendor with standard properties.
Documentation/devicetree/bindings/sound/ti,tac5x1x.yaml line 141
Quoted 9 lines
Documentation/devicetree/bindings/sound/ti,tac5x1x.yaml new file +9
-0+ ti,gpi1-func: + description: GPI1 Functionality + $ref: /schemas/types.yaml#/definitions/uint32 + enum: + - 0 # TAC5X1X_GPIO_DISABLE - I/O buffers powered down and not used + - 1 # TAC5X1X_GPIO_GPI - General purpose input + default: 0 + + '#sound-dai-cells':
Missing ref to dai common. Look at other bindings.
Documentation/devicetree/bindings/sound/ti,tac5x1x.yaml line 147
Quoted 6 lines
Documentation/devicetree/bindings/sound/ti,tac5x1x.yaml new file +6
-0+ const: 0 + + clocks: + maxItems: 1 + + ti,gpa-gpio:
Why this appeared here? Looks like totally random sorting.
First goes compatible, then reg, then standard properties, then vendor properties. I have few more comments but this binding looks terrible. I suggest you doing extensive initernal review, before you send next version.
Quoted 45 lines
Documentation/devicetree/bindings/sound/ti,tac5x1x.yaml new file +45
-0+ description: GPA using GPIO1 configuration + $ref: /schemas/types.yaml#/definitions/uint32 + enum: + - 0 # GPA using GPIO1 is disabled + - 1 # GPA using GPIO1 + default: 0 + + ti,in-ch-en: + description: Enable Input channel diagnostics for TAC54XX and TAC53XX device. + $ref: /schemas/types.yaml#/definitions/uint32 + enum: + - 0 # Disable input channel diagnostics + - 1 # Enable input channel diagnostics + + ti,out-ch-en: + description: Enable Output channel diagnostics for TAC54XX and TAC53XX device + $ref: /schemas/types.yaml#/definitions/uint32 + enum: + - 0 # Disable Output channel diagnostics + - 1 # Enable Output channel Diagnostics + + ti,incl-se-inm: + description: INxM pin Diagnostics Scan Selection for Single Ended Configuration + $ref: /schemas/types.yaml#/definitions/uint32 + enum: + - 0 # INxM pin Diagnostics Scan Selection for Single Ended excluded for diagnosis + - 1 # INxM pin Diagnostics Scan Selection for Single Ended included for diagnosis + + ti,incl-ac-coup: + description: AC coupled channels pins Scan Selection for Diagnostics + $ref: /schemas/types.yaml#/definitions/uint32 + enum: + - 0 # AC coupled channels pins Scan Selection for Diagnostics exluded for diagnosis + - 1 # AC coupled channels pins Scan Selection for Diagnostics included for diagnosis + + ti,micbias-threshold: + description: Micbias Low and High threshold values for TAC54XX and TAC53XX series + $ref: /schemas/types.yaml#/definitions/uint32-array + maxItems: 2 + minItems: 2 + items: + minimum: 72 + maximum: 162 + + ti,gpa-threshold:
Documentation/devicetree/bindings/sound/ti,tac5x1x.yaml line 202
Quoted 10 lines
Documentation/devicetree/bindings/sound/ti,tac5x1x.yaml new file +10
-0+ description: GPA Low and High threshold Values + $ref: /schemas/types.yaml#/definitions/uint32-array + maxItems: 2 + minItems: 2 + items: + minimum: 75 + maximum: 186 + + ti,adc1-impedance: + description: Channel 1 Input Impedance Value
Use proper units.
Quoted 31 lines
Documentation/devicetree/bindings/sound/ti,tac5x1x.yaml new file +31
-0+ $ref: /schemas/types.yaml#/definitions/uint32 + enum: + - 0 # 5 kOhm + - 1 # 10 kOhm + - 2 # 40 kOhm + default: 0 + + ti,adc2-impedance: + description: Channel 2 Input Impedance Value + $ref: /schemas/types.yaml#/definitions/uint32 + enum: + - 0 # 5 kOhm + - 1 # 10 kOhm + - 2 # 40 kOhm + default: 0 + + ti,out2x-vcom-cfg: + description: Channel OUT2x VCOM configuration + $ref: /schemas/types.yaml#/definitions/uint32 + enum: + - 0 # 0.6 * Vref + - 1 # AVDD by 2 + default: 0 + +required: + - compatible + - reg + - ti,vref + - ti,micbias-vg + +additionalProperties: false
Documentation/devicetree/bindings/sound/ti,tac5x1x.yaml line 243
Quoted 10 lines
Documentation/devicetree/bindings/sound/ti,tac5x1x.yaml new file +10
-0+ +examples: + - | + #include <dt-bindings/gpio/gpio.h> + + i2c { + #address-cells = <1>; + #size-cells = <0>; + + tac5x1x: tac5x1x@52 {
Node names should be generic. See also an explanation and list of examples (not exhaustive) in DT specification:
https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation
Best regards,
Krzysztof
PATCH v3 3/4 Asoc: pcm6240: remove support for taac5x1x family
In reply to Niranjan H Ytac5x1x codec driver suporrts tac5x1x family which includes the following ADCs and DACs. So removed the duplicate entries in the pcm6240 i2c driver.
---
v3:
- remove unused code
--- sound/soc/codecs/pcm6240.c | 126 +------------------------------------ sound/soc/codecs/pcm6240.h | 4 -- 2 files changed, 3 insertions(+), 127 deletions(-)
sound/soc/codecs/pcm6240.c +3 -123
@@ -44,10 +44,6 @@ static const struct i2c_device_id pcmdevice_i2c_id[] = { { "pcmd3140", PCMD3140 }, { "pcmd3180", PCMD3180 }, { "pcmd512x", PCMD512X }, - { "taa5212", TAA5212 }, - { "taa5412", TAA5412 }, - { "tad5212", TAD5212 }, - { "tad5412", TAD5412 }, {} };MODULE_DEVICE_TABLE (i2c, pcmdevice_i2c_id);
@@ -442,60 +438,6 @@ static const struct pcmdevice_mixer_control pcmd3180_fine_gain_ctl[] = { } }; -static const struct pcmdevice_mixer_control taa5412_digi_vol_ctl[] = { - { - .shift =0 , - .reg =TAA5412_REG_CH1_DIGITAL_VOLUME , - .max =0xff , - .invert =0 , - }, - { - .shift =0 , - .reg =TAA5412_REG_CH2_DIGITAL_VOLUME , - .max =0xff , - .invert =0 , - }, - { - .shift =0 , - .reg =TAA5412_REG_CH3_DIGITAL_VOLUME , - .max =0xff , - .invert =0 , - }, - { - .shift =0 , - .reg =TAA5412_REG_CH4_DIGITAL_VOLUME , - .max =0xff , - .invert =0 , - } -}; - -static const struct pcmdevice_mixer_control taa5412_fine_gain_ctl[] = { - { - .shift =4 , - .reg =TAA5412_REG_CH1_FINE_GAIN , - .max =0xf , - .invert =0 , - }, - { - .shift =4 , - .reg =TAA5412_REG_CH2_FINE_GAIN , - .max =0xf , - .invert =0 , - }, - { - .shift =4 , - .reg =TAA5412_REG_CH3_FINE_GAIN , - .max =0xf , - .invert =4 , - }, - { - .shift =0 , - .reg =TAA5412_REG_CH4_FINE_GAIN , - .max =0xf , - .invert =4 , - } -}; - static const DECLARE_TLV_DB_MINMAX_MUTE(pcmd3140_dig_gain_tlv, -10000, 2700); static const DECLARE_TLV_DB_MINMAX_MUTE(pcm1690_fine_dig_gain_tlv,
@@ -510,9 +452,7 @@ static const DECLARE_TLV_DB_LINEAR(adc5120_chgain_tlv, 0, 4200); static const DECLARE_TLV_DB_MINMAX_MUTE(pcm6260_fgain_tlv, -10000, 2700); static const DECLARE_TLV_DB_LINEAR(pcm6260_chgain_tlv, 0, 4200); -static const DECLARE_TLV_DB_MINMAX_MUTE(taa5412_dig_vol_tlv, - -8050, 4700); -static const DECLARE_TLV_DB_LINEAR(taa5412_fine_gain_tlv, +static const DECLARE_TLV_DB_LINEAR(pcmd31x0_fine_gain_tlv, -80, 70); static int pcmdev_change_dev(struct pcmdevice_priv *pcm_priv,
@@ -981,7 +921,7 @@ static const struct pcmdev_ctrl_info pcmdev_gain_ctl_info[][2] = {// PCMD3140 { { - .gain = taa5412_fine_gain_tlv, + .gain = pcmd31x0_fine_gain_tlv, .pcmdev_ctrl = pcmd3140_fine_gain_ctl, .ctrl_array_size = ARRAY_SIZE(pcmd3140_fine_gain_ctl), .get = pcmdevice_get_volsw,
@@ -1000,7 +940,7 @@ static const struct pcmdev_ctrl_info pcmdev_gain_ctl_info[][2] = {// PCMD3180 { { - .gain = taa5412_fine_gain_tlv, + .gain = pcmd31x0_fine_gain_tlv, .pcmdev_ctrl = pcmd3180_fine_gain_ctl, .ctrl_array_size = ARRAY_SIZE(pcmd3180_fine_gain_ctl), .get = pcmdevice_get_volsw,
@@ -1025,62 +965,6 @@ static const struct pcmdev_ctrl_info pcmdev_gain_ctl_info[][2] = { .ctrl_array_size = 0, }, }, - // TAA5212 - { - { - .gain = taa5412_fine_gain_tlv, - .pcmdev_ctrl = taa5412_fine_gain_ctl, - .ctrl_array_size = ARRAY_SIZE(taa5412_fine_gain_ctl), - .get = pcmdevice_get_volsw, - .put = pcmdevice_put_volsw, - .pcmdev_ctrl_name_id = 2, - }, - { - .gain = taa5412_dig_vol_tlv, - .pcmdev_ctrl = taa5412_digi_vol_ctl, - .ctrl_array_size = ARRAY_SIZE(taa5412_digi_vol_ctl), - .get = pcmdevice_get_volsw, - .put = pcmdevice_put_volsw, - .pcmdev_ctrl_name_id = 1, - }, - }, - // TAA5412 - { - { - .gain = taa5412_fine_gain_tlv, - .pcmdev_ctrl = taa5412_fine_gain_ctl, - .ctrl_array_size = ARRAY_SIZE(taa5412_fine_gain_ctl), - .get = pcmdevice_get_volsw, - .put = pcmdevice_put_volsw, - .pcmdev_ctrl_name_id = 2, - }, - { - .gain = taa5412_dig_vol_tlv, - .pcmdev_ctrl = taa5412_digi_vol_ctl, - .ctrl_array_size = ARRAY_SIZE(taa5412_digi_vol_ctl), - .get = pcmdevice_get_volsw, - .put = pcmdevice_put_volsw, - .pcmdev_ctrl_name_id = 1, - }, - }, - // TAD5212 - { - { - .ctrl_array_size = 0, - }, - { - .ctrl_array_size = 0, - }, - }, - // TAD5412 - { - { - .ctrl_array_size = 0, - }, - { - .ctrl_array_size = 0, - }, - }, }; static int pcmdev_dev_bulk_write(struct pcmdevice_priv *pcm_dev,
@@ -2002,10 +1886,6 @@ static const struct of_device_id pcmdevice_of_match[] = { { .compatible = "ti,pcmd3140" }, { .compatible = "ti,pcmd3180" }, { .compatible = "ti,pcmd512x" }, - { .compatible = "ti,taa5212" }, - { .compatible = "ti,taa5412" }, - { .compatible = "ti,tad5212" }, - { .compatible = "ti,tad5412" }, {}, };MODULE_DEVICE_TABLE (of, pcmdevice_of_match);
sound/soc/codecs/pcm6240.h +0 -4
@@ -33,10 +33,6 @@ enum pcm_device {PCMD3140 ,PCMD3180 ,PCMD512X , -TAA5212 , -TAA5412 , -TAD5212 , -TAD5412 , MAX_DEVICE, };
Signature · 1 line
2.45.2
PATCH v3 4/4 dt-bindings: sound: device support list for pcm6240
In reply to Niranjan H YRemoved taa* and tad* device from the support list as these devices are supported by tac5x1x codec driver
---
v3:
- update the subject of the patch file
--- .../devicetree/bindings/sound/ti,pcm6240.yaml | 10 ---------- 1 file changed, 10 deletions(-)
Documentation/devicetree/bindings/sound/ti,pcm6240.yaml +0 -10
@@ -29,8 +29,6 @@ description: | https://www.ti.com/lit/gpn/pcm9211 https://www.ti.com/lit/gpn/pcmd3140 https://www.ti.com/lit/gpn/pcmd3180 - https://www.ti.com/lit/gpn/taa5212 - https://www.ti.com/lit/gpn/tad5212 properties: compatible:
@@ -81,10 +79,6 @@ properties: ti,pcmd3180: Eight-channel pulse-density-modulation input to TDM or I2S output converter. - ti,taa5212: Low-power high-performance stereo audio ADC with 118-dB - dynamic range. - - ti,tad5212: Low-power stereo audio DAC with 120-dB dynamic range. oneOf: - items: - enum:
@@ -98,8 +92,6 @@ properties: - enum: - ti,pcmd512x - ti,pcm9211 - - ti,taa5212 - - ti,tad5212 - const: ti,adc6120 - items: - enum:
@@ -114,8 +106,6 @@ properties: - ti,pcmd3140 - ti,pcmd3180 - ti,pcm1690 - - ti,taa5412 - - ti,tad5412 - const: ti,pcm6240 - enum: - ti,adc6120
Signature · 1 line
2.45.2
Re: [PATCH v3 4/4] dt-bindings: sound: device support list for pcm6240
Quoted 2 lines · Niranjan H Y
Removed taa* and tad* device from the support list as these devices are supported by tac5x1x codec driver
No, why? Hardware does not change.
Quoted 35 lines
Signed-off-by Niranjan H Y <[email protected]>---
v3:
- update the subject of the patch file--- .../devicetree/bindings/sound/ti,pcm6240.yaml | 10 ---------- 1 file changed, 10 deletions(-)Documentation/devicetree/bindings/sound/ti,pcm6240.yaml +0
-6@@ -29,8 +29,6 @@ description: | https://www.ti.com/lit/gpn/pcm9211 https://www.ti.com/lit/gpn/pcmd3140 https://www.ti.com/lit/gpn/pcmd3180 - https://www.ti.com/lit/gpn/taa5212 - https://www.ti.com/lit/gpn/tad5212 properties: compatible:@@ -81,10 +79,6 @@ properties: ti,pcmd3180: Eight-channel pulse-density-modulation input to TDM or I2S output converter. - ti,taa5212: Low-power high-performance stereo audio ADC with 118-dB - dynamic range. - - ti,tad5212: Low-power stereo audio DAC with 120-dB dynamic range. oneOf: - items: - enum:
Documentation/devicetree/bindings/sound/ti,pcm6240.yaml properties: · line 95
Quoted 6 lines
Documentation/devicetree/bindings/sound/ti,pcm6240.yaml +0
-2@@ -98,8 +92,6 @@ properties: - enum: - ti,pcmd512x - ti,pcm9211 - - ti,taa5212 - - ti,tad5212 - const: ti,adc6120
All this is ABI break without explanation.
Best regards,
Krzysztof
Mark Brown
maintainerRe: [PATCH v3 4/4] dt-bindings: sound: device support list for pcm6240
Quoted 6 lines · Krzysztof Kozlowski
Quoted 2 lines · Niranjan H Y
Removed taa* and tad* device from the support list as these devices are supported by tac5x1x codec driver
No, why? Hardware does not change.
So long as the bindings are compatible it's not a problem, this does happen sometimes when people realise that a device needs more specific support and it's more managable to split out from a common binding. The commit log should have the analysis of this though.
Re: [PATCH v3 4/4] dt-bindings: sound: device support list for pcm6240
Quoted 6 lines · Mark Brown
Quoted 4 lines · Krzysztof Kozlowski
Quoted 2 lines · Niranjan H Y
Removed taa* and tad* device from the support list as these devices are supported by tac5x1x codec driver
Quoted 6 lines
Quoted 1 line
No, why? Hardware does not change.
So long as the bindings are compatible it's not a problem, this does happen sometimes when people realise that a device needs more specific support and it's more managable to split out from a common binding. The commit log should have the analysis of this though.
Yeah and then it should be one commit moving - not removing - compatibles to a new binding, with that analysis or explanation.
Best regards,
Krzysztof