Skip to contentSkip to conversation

drm/bridge: PTN3460 needs DRM_KMS_HELPER

PATCH In review Arnd Bergmann 2 participants 2 messages Mar 25, 2014

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/bridge: PTN3460 needs DRM_KMS_HELPER

The recently added PTN3460 device driver uses interfaces that are provided by the KMS helper infrastructure, so we should explicitly select that to avoid this linker error:

ERROR: "drm_helper_probe_single_connector_modes" [drivers/gpu/drm/bridge/ptn3460.ko] undefined!
ERROR: "drm_helper_connector_dpms" [drivers/gpu/drm/bridge/ptn3460.ko] undefined!

We have to drop the I2C dependency to avoid a circular dependency chain, but that's ok because DRM already selects I2C.

---
I found this today doing randconfig builds on linux-next.

drivers/gpu/drm/bridge/Kconfig +2 -1
index f8db069..884923f 100644
@@ -1,4 +1,5 @@
 config DRM_PTN3460
 	tristate "PTN3460 DP/LVDS bridge"
-	depends on DRM && I2C
+	depends on DRM
+	select DRM_KMS_HELPER
 	---help---
#1 lore raw

2014-03-25 20:06 GMT+09:00 Arnd Bergmann <[email protected]>:

Quoted 7 lines

The recently added PTN3460 device driver uses interfaces that are provided by the KMS helper infrastructure, so we should explicitly select that to avoid this linker error:

ERROR: "drm_helper_probe_single_connector_modes" [drivers/gpu/drm/bridge/ptn3460.ko] undefined!
ERROR: "drm_helper_connector_dpms" [drivers/gpu/drm/bridge/ptn3460.ko] undefined!

Ah, right. Exynos drm selects DRM_KMS_HELPER so I cannot see build error.

Thanks,
Inki Dae

Quoted 23 lines

We have to drop the I2C dependency to avoid a circular dependency chain, but that's ok because DRM already selects I2C.

---
I found this today doing randconfig builds on linux-next.

drivers/gpu/drm/bridge/Kconfig +2 -1
index f8db069..884923f 100644
@@ -1,4 +1,5 @@
 config DRM_PTN3460
        tristate "PTN3460 DP/LVDS bridge"
-       depends on DRM && I2C
+       depends on DRM
+       select DRM_KMS_HELPER
        ---help---

_______________________________________________
dri-devel mailing list
dri-devel at lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel