dt-bindings: hwmon: Convert aspeed,ast2400-pwm-tacho to DT schema
Rob Herring (Arm)
maintainerPATCH 1/1 dt-bindings: hwmon: Convert aspeed,ast2400-pwm-tacho to DT schema
Convert the ASpeed fan controller binding to DT schema format.
The '#cooling-cells' value used is 1 rather than 2. '#size-cells' is 0 rather 1.
Some users define more that 8 fan nodes where 2 fans share a PWM. The driver seems to let the 2nd fan just overwrite the 1st one. That also creates some addressing errors in the DT (duplicate addresses and wrong unit-addresses).
--- .../hwmon/aspeed,ast2400-pwm-tacho.yaml | 105 ++++++++++++++++++ .../bindings/hwmon/aspeed-pwm-tacho.txt | 73 ------------ 2 files changed, 105 insertions(+), 73 deletions(-) create mode 100644 Documentation/devicetree/bindings/hwmon/aspeed,ast2400-pwm-tacho.yaml delete mode 100644 Documentation/devicetree/bindings/hwmon/aspeed-pwm-tacho.txt
Documentation/devicetree/bindings/hwmon/aspeed,ast2400-pwm-tacho.yaml new file +105 -0
@@ -0,0 +1,105 @@ +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/hwmon/aspeed,ast2400-pwm-tacho.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: ASPEED AST2400/AST2500 PWM and Fan Tacho controller + +maintainers: + - Joel Stanley <[email protected]> + - Andrew Jeffery <[email protected]> + +description: > + The ASPEED PWM controller can support upto 8 PWM outputs. The ASPEED Fan Tacho + controller can support upto 16 Fan tachometer inputs. + + There can be up to 8 fans supported. Each fan can have 1 PWM output and + 1-2 Fan tach inputs. + +properties: + compatible: + enum: + - aspeed,ast2400-pwm-tacho + - aspeed,ast2500-pwm-tacho + + reg: + maxItems: 1 + + '#address-cells': + const: 1 + + '#size-cells': + const: 0 + + '#cooling-cells': + const: 1 + + clocks: + maxItems: 1 + + resets: + maxItems: 1 + +patternProperties: + '^fan@[0-7]$': + description: Fan subnode + type: object + additionalProperties: false + + properties: + reg: + description: PWM source port index (0 = PWM A, ..., 7 = PWM H) + maximum: 7 + + cooling-levels: + description: PWM duty cycle values for cooling states + $ref: /schemas/types.yaml#/definitions/uint8-array + minItems: 1 + maxItems: 16 # Should be enough + + aspeed,fan-tach-ch: + description: Fan tachometer input channel + $ref: /schemas/types.yaml#/definitions/uint8-array + minItems: 1 + maxItems: 2 + items: + maximum: 15 + + required: + - reg + - aspeed,fan-tach-ch + +required: + - compatible + - reg + - '#address-cells' + - '#size-cells' + - clocks + - resets + +additionalProperties: false + +examples: + - | + #include <dt-bindings/clock/aspeed-clock.h> + + fan-controller@1e786000 { + compatible = "aspeed,ast2500-pwm-tacho"; + reg = <0x1e786000 0x1000>; + #address-cells = <1>; + #size-cells = <0>; + #cooling-cells = <1>; + clocks = <&syscon ASPEED_CLK_APB>; + resets = <&syscon ASPEED_RESET_PWM>; + + fan@0 { + reg = <0x00>; + cooling-levels = /bits/ 8 <125 151 177 203 229 255>; + aspeed,fan-tach-ch = /bits/ 8 <0x00>; + }; + + fan@1 { + reg = <0x01>; + aspeed,fan-tach-ch = /bits/ 8 <0x01 0x02>; + }; + };
Documentation/devicetree/bindings/hwmon/aspeed-pwm-tacho.txt deleted +0 -73
73 lines not on this page · raw message
Signature · 1 line
2.51.0
Rob Herring (Arm)
maintainerQuoted 10 lines · Rob Herring (Arm)
Convert the ASpeed fan controller binding to DT schema format.
The '#cooling-cells' value used is 1 rather than 2. '#size-cells' is 0 rather 1.
Some users define more that 8 fan nodes where 2 fans share a PWM. The driver seems to let the 2nd fan just overwrite the 1st one. That also creates some addressing errors in the DT (duplicate addresses and wrong unit-addresses).
Quoted 8 lines
Signed-off-by Rob Herring (Arm) <[email protected]>--- .../hwmon/aspeed,ast2400-pwm-tacho.yaml | 105 ++++++++++++++++++ .../bindings/hwmon/aspeed-pwm-tacho.txt | 73 ------------ 2 files changed, 105 insertions(+), 73 deletions(-) create mode 100644 Documentation/devicetree/bindings/hwmon/aspeed,ast2400-pwm-tacho.yaml delete mode 100644 Documentation/devicetree/bindings/hwmon/aspeed-pwm-tacho.txt
My bot found errors running 'make dt_binding_check' on your patch:
yamllint warnings/errors:
dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/hwmon/aspeed,ast2400-pwm-tacho.example.dtb: fan-controller@1e786000 (aspeed,ast2500-pwm-tacho): #cooling-cells: 2 was expected
from schema $id: http://devicetree.org/schemas/thermal/thermal-cooling-devices.yaml
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/[email protected]
The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
Documentation/devicetree/bindings/hwmon/aspeed,ast2400-pwm-tacho.yaml
Quoted 24 lines · Rob Herring (Arm)
Convert the ASpeed fan controller binding to DT schema format.
The '#cooling-cells' value used is 1 rather than 2. '#size-cells' is 0 rather 1.
Some users define more that 8 fan nodes where 2 fans share a PWM. The driver seems to let the 2nd fan just overwrite the 1st one. That also creates some addressing errors in the DT (duplicate addresses and wrong unit-addresses).
Signed-off-by Rob Herring (Arm) <[email protected]>--- .../hwmon/aspeed,ast2400-pwm-tacho.yaml | 105 ++++++++++++++++++ .../bindings/hwmon/aspeed-pwm-tacho.txt | 73 ------------ 2 files changed, 105 insertions(+), 73 deletions(-) create mode 100644 Documentation/devicetree/bindings/hwmon/aspeed,ast2400-pwm-tacho.yaml delete mode 100644 Documentation/devicetree/bindings/hwmon/aspeed-pwm-tacho.txtDocumentation/devicetree/bindings/hwmon/aspeed,ast2400-pwm-tacho.yaml new file +0
-0@@ -0,0 +1,105 @@
Missing SPDX. Few other checkpatch warnings like typos. I guess you will see it in the Patchwork, so just writing here that it should not be picked up by PWM folks.
Documentation/devicetree/bindings/hwmon/aspeed,ast2400-pwm-tacho.yaml line 6
Quoted 6 lines
Documentation/devicetree/bindings/hwmon/aspeed,ast2400-pwm-tacho.yaml new file +6
-0+%YAML 1.2 +--- +$id: http://devicetree.org/schemas/hwmon/aspeed,ast2400-pwm-tacho.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: ASPEED AST2400/AST2500 PWM and Fan Tacho controller
Best regards,
Krzysztof