drm/i915/display: Add initial support for Xe3p_LPD
Subsystems (3)
v2 cover drm/i915/display: Add initial support for Xe3p_LPD
This series adds initial support for Xe3p_LPD, Intel's display architecture with IP version 35.
This series contains basic enabling patches and does not provide complete support for the display IP yet. More involved features, like the new PHY implementation and ALPM will come as separate patch series.
---
Changes in v2:
- Incorporated review feedback. Please check the changelog in the
patches for details.
- Link to v1: https://lore.kernel.org/r/[email protected]
---
Ankit Nautiyal (1):
drm/i915/xe3p_lpd: Drop support for interlace mode
Gustavo Sousa (13):
drm/i915/display: Use braces for if-ladder in intel_bw_init_hw() drm/i915/dram: Add field ecc_impacting_de_bw drm/i915/xe3p_lpd: Wait for AUX channel power status drm/i915/wm: Reorder adjust_wm_latency() for Xe3_LPD drm/i915/xe3p_lpd: Always apply level-0 watermark adjustment drm/i915/xe3p_lpd: Add CDCLK table
drm/i915/xe3p_lpd: Load DMC firmware
drm/i915/xe3p_lpd: Extend Wa_16025573575
drm/i915/xe3p_lpd: Reload DMC MMIO for pipes C and D drm/i915/vbt: Add fields dedicated_external and dyn_port_over_tc drm/i915/power: Use intel_encoder_is_tc()
drm/i915/display: Handle dedicated external ports in intel_encoder_is_tc() drm/i915/xe3p_lpd: Extend Type-C flow for static DDI allocation
Jouni Högander (1):
drm/i915/xe3p_lpd: PSR SU minimum lines is 4
Juha-pekka Heikkila (1):
drm/i915/xe3p_lpd: Don't allow odd ypan or ysize with semiplanar format
Luca Coelho (1):
drm/i915/wm: don't use method1 in Xe3p_LPD onwards
Matt Atwood (1):
drm/i915/xe3p_lpd: Update bandwidth parameters
Matt Roper (1):
drm/i915/xe3p_lpd: Drop north display reset option programming
Ravi Kumar Vodapalli (1):
drm/i915/xe3p_lpd: Adapt to updates on MBUS_CTL/DBUF_CTL registers
Sai Teja Pottumuttu (8):
drm/i915/xe3p_lpd: Add Xe3p_LPD display IP features drm/i915/xe3p_lpd: Expand bifield masks dbuf blocks fields drm/i915/xe3p_lpd: Support UINT16 formats drm/i915/xe3p_lpd: Extend FBC support to UINT16 formats drm/i915/xe3p_lpd: Horizontal flip support for linear surfaces drm/i915/xe3p_lpd: Underrun debuggability and error codes/hints drm/i915/xe3p_lpd: Remove gamma,csc bottom color checks drm/i915/nvls: Add NVL-S display support
Vinod Govindapillai (4):
drm/i915/xe3p_lpd: Enable system caching for FBC drm/i915/xe3p_lpd: Introduce pixel normalizer config support drm/i915/xe3p_lpd: Add FBC support for FP16 formats drm/i915/xe3p_lpd: Enable pixel normalizer for fp16 formats for FBC
drivers/gpu/drm/i915/display/intel_bios.c | 54 ++++++- drivers/gpu/drm/i915/display/intel_bios.h | 2 + drivers/gpu/drm/i915/display/intel_bw.c | 39 +++-- drivers/gpu/drm/i915/display/intel_cdclk.c | 44 +++++- drivers/gpu/drm/i915/display/intel_color.c | 13 +- drivers/gpu/drm/i915/display/intel_ddi.c | 11 ++ drivers/gpu/drm/i915/display/intel_display.c | 33 ++++- .../gpu/drm/i915/display/intel_display_device.c | 6 + .../gpu/drm/i915/display/intel_display_device.h | 4 +- drivers/gpu/drm/i915/display/intel_display_power.c | 3 + .../drm/i915/display/intel_display_power_well.c | 58 ++++++-- drivers/gpu/drm/i915/display/intel_display_regs.h | 40 ++++- drivers/gpu/drm/i915/display/intel_display_types.h | 4 + drivers/gpu/drm/i915/display/intel_display_wa.c | 3 +- drivers/gpu/drm/i915/display/intel_dmc.c | 13 +- drivers/gpu/drm/i915/display/intel_fbc.c | 126 +++++++++++++++- drivers/gpu/drm/i915/display/intel_fbc.h | 1 + drivers/gpu/drm/i915/display/intel_fbc_regs.h | 11 ++ drivers/gpu/drm/i915/display/intel_fifo_underrun.c | 87 +++++++++++ drivers/gpu/drm/i915/display/intel_plane.c | 3 + drivers/gpu/drm/i915/display/intel_psr.c | 25 ++++ drivers/gpu/drm/i915/display/intel_tc.c | 151 ++++++++++++++++++- drivers/gpu/drm/i915/display/intel_vbt_defs.h | 3 +- drivers/gpu/drm/i915/display/skl_universal_plane.c | 162 +++++++++++++++------ .../drm/i915/display/skl_universal_plane_regs.h | 25 +++- drivers/gpu/drm/i915/display/skl_watermark.c | 55 +++++-- drivers/gpu/drm/i915/display/skl_watermark_regs.h | 52 ++++--- drivers/gpu/drm/i915/i915_reg.h | 1 + drivers/gpu/drm/i915/soc/intel_dram.c | 4 + drivers/gpu/drm/i915/soc/intel_dram.h | 1 + 30 files changed, 882 insertions(+), 152 deletions(-)
---
base-commit: fb0f56ad8a2c9953c57c3337a72ccbf9c5050687
change-id: 20251014-xe3p_lpd-basic-enabling-eb4424698b44
Best regards,
Signature · 1 line
Gustavo Sousa <[email protected]>
PATCH v2 1/32 drm/i915/xe3p_lpd: Add Xe3p_LPD display IP features
From: Sai Teja Pottumuttu <[email protected]>
Xe3p_LPD (display version 35) is similar to Xe2_LPD with respect to the features described by struct intel_display_device_info, so reuse its device descriptor.
v2:
- Add reference to Bspec 74201. (Shekhar)
Bspec: 74201, 74304
--- drivers/gpu/drm/i915/display/intel_display_device.c | 1 + 1 file changed, 1 insertion(+)
drivers/gpu/drm/i915/display/intel_display_device.c +1 -0
@@ -1507,6 +1507,7 @@ static const struct { { 20, 0, &xe2_lpd_display }, { 30, 0, &xe2_lpd_display }, { 30, 2, &wcl_display }, + { 35, 0, &xe2_lpd_display }, }; static const struct intel_display_device_info *
Signature · 1 line
2.51.0
PATCH v2 2/32 drm/i915/xe3p_lpd: Drop north display reset option programming
In reply to Gustavo SousaFrom: Matt Roper <[email protected]>
The NDE_RSTWRN_OPT has been removed on Xe3p platforms and reset option programming is no longer necessary during display init.
Bspec: 68846, 69137
--- drivers/gpu/drm/i915/display/intel_display_power.c | 3 +++ 1 file changed, 3 insertions(+)
drivers/gpu/drm/i915/display/intel_display_power.c +3 -0
@@ -1436,6 +1436,9 @@ static void intel_pch_reset_handshake(struct intel_display *display,i915_reg_t reg;u32 reset_bits; +if (DISPLAY_VER (display) >=35 ) +return ; +if (display->platform.ivybridge) { reg =GEN7_MSG_CTL ; reset_bits =WAIT_FOR_PCH_FLR_ACK |WAIT_FOR_PCH_RESET_ACK ;
Signature · 1 line
2.51.0
PATCH v2 3/32 drm/i915/display: Use braces for if-ladder in intel_bw_init_hw()
In reply to Gustavo SousaLooking at the current if-ladder in intel_bw_init_hw(), we see that Xe2_HPD contains two entries, differing only for ECC memories. Let's improve readability by using braces and allowing adding extra conditions for each case.
v2:
- Tweaked commit message, since we are not going to add the ECC case for Xe3p_LPD anymore.
--- drivers/gpu/drm/i915/display/intel_bw.c | 29 +++++++++++++++-------------- 1 file changed, 15 insertions(+), 14 deletions(-)
drivers/gpu/drm/i915/display/intel_bw.c +15 -14
@@ -802,29 +802,30 @@ void intel_bw_init_hw(struct intel_display *display)if (!HAS_DISPLAY (display))return ; -if (DISPLAY_VERx100 (display) >=3002 ) +if (DISPLAY_VERx100 (display) >=3002 ) {tgl_get_bw_info (display, dram_info, &xe3lpd_3002_sa_info); -else if (DISPLAY_VER (display) >=30 ) + }else if (DISPLAY_VER (display) >=30 ) {tgl_get_bw_info (display, dram_info, &xe3lpd_sa_info); -else if (DISPLAY_VERx100 (display) >=1401 && display->platform.dgfx && - dram_info->type ==INTEL_DRAM_GDDR_ECC ) -xe2_hpd_get_bw_info (display, dram_info, &xe2_hpd_ecc_sa_info); -else if (DISPLAY_VERx100 (display) >=1401 && display->platform.dgfx) -xe2_hpd_get_bw_info (display, dram_info, &xe2_hpd_sa_info); -else if (DISPLAY_VER (display) >=14 ) + }else if (DISPLAY_VERx100 (display) >=1401 && display->platform.dgfx) { +if (dram_info->type ==INTEL_DRAM_GDDR_ECC ) +xe2_hpd_get_bw_info (display, dram_info, &xe2_hpd_ecc_sa_info); +else +xe2_hpd_get_bw_info (display, dram_info, &xe2_hpd_sa_info); + }else if (DISPLAY_VER (display) >=14 ) {tgl_get_bw_info (display, dram_info, &mtl_sa_info); -else if (display->platform.dg2) + }else if (display->platform.dg2) {dg2_get_bw_info (display); -else if (display->platform.alderlake_p) + }else if (display->platform.alderlake_p) {tgl_get_bw_info (display, dram_info, &adlp_sa_info); -else if (display->platform.alderlake_s) + }else if (display->platform.alderlake_s) {tgl_get_bw_info (display, dram_info, &adls_sa_info); -else if (display->platform.rocketlake) + }else if (display->platform.rocketlake) {tgl_get_bw_info (display, dram_info, &rkl_sa_info); -else if (DISPLAY_VER (display) ==12 ) + }else if (DISPLAY_VER (display) ==12 ) {tgl_get_bw_info (display, dram_info, &tgl_sa_info); -else if (DISPLAY_VER (display) ==11 ) + }else if (DISPLAY_VER (display) ==11 ) {icl_get_bw_info (display, dram_info, &icl_sa_info); + } } static unsigned int intel_bw_num_active_planes(struct intel_display *display,
Signature · 1 line
2.51.0
PATCH v2 4/32 drm/i915/dram: Add field ecc_impacting_de_bw
In reply to Gustavo SousaStarting with Xe3p_LPD, we now have a new field in MEM_SS_INFO_GLOBAL that indicates whether the memory has enabled ECC that limits display bandwidth. Add the field ecc_impacting_de_bw to struct dram_info to contain that information and set it appropriately when probing for memory info.
Currently there are no instructions in Bspec on how to handle that case, so let's throw a warning if we ever find such a scenario.
v2:
- s/ecc_impacting_de/ecc_impacting_de_bw/ to be more specific. (Matt Atwood)
- Add warning if ecc_impacting_de_bw is true, since we currently do not have instructions on how to handle it. (Matt Roper)
Bspec: 69131
--- drivers/gpu/drm/i915/display/intel_bw.c | 8 ++++++++ drivers/gpu/drm/i915/i915_reg.h | 1 + drivers/gpu/drm/i915/soc/intel_dram.c | 4 ++++ drivers/gpu/drm/i915/soc/intel_dram.h | 1 + 4 files changed, 14 insertions(+)
drivers/gpu/drm/i915/display/intel_bw.c +8 -0
@@ -802,6 +802,14 @@ void intel_bw_init_hw(struct intel_display *display)if (!HAS_DISPLAY (display))return ; +/* +* Starting with Xe3p_LPD, the hardware tells us whether memory has ECC +* enabled that would impact display bandwidth. However, so far there +* are no instructions in Bspec on how to handle that case. Let's +* complain if we ever find such a scenario. +*/ +drm_WARN_ON_ONCE (display->drm, dram_info->ecc_impacting_de_bw); +if (DISPLAY_VERx100 (display) >=3002 ) {tgl_get_bw_info (display, dram_info, &xe3lpd_3002_sa_info); }else if (DISPLAY_VER (display) >=30 ) {
drivers/gpu/drm/i915/i915_reg.h +1 -0
@@ -1233,6 +1233,7 @@#define OROM_OFFSET_MASK REG_GENMASK(20, 16)#define MTL_MEM_SS_INFO_GLOBAL _MMIO(0x45700) +#define XE3P_ECC_IMPACTING_DE REG_BIT(12)#define MTL_N_OF_ENABLED_QGV_POINTS_MASK REG_GENMASK(11, 8)#define MTL_N_OF_POPULATED_CH_MASK REG_GENMASK(7, 4)#define MTL_DDR_TYPE_MASK REG_GENMASK(3, 0)
drivers/gpu/drm/i915/soc/intel_dram.c +4 -0
@@ -685,6 +685,7 @@ static int gen12_get_dram_info(struct drm_i915_private *i915, struct dram_info *static int xelpdp_get_dram_info (struct drm_i915_private *i915,struct dram_info *dram_info) { +struct intel_display *display = i915->display;u32 val =intel_uncore_read (&i915->uncore,MTL_MEM_SS_INFO_GLOBAL );switch (REG_FIELD_GET (MTL_DDR_TYPE_MASK , val)) {
@@ -723,6 +724,9 @@ static int xelpdp_get_dram_info(struct drm_i915_private *i915, struct dram_info dram_info->num_qgv_points =REG_FIELD_GET (MTL_N_OF_ENABLED_QGV_POINTS_MASK , val);/* PSF GV points not supported in D14+ */ +if (DISPLAY_VER (display) >=35 ) + dram_info->ecc_impacting_de_bw =REG_FIELD_GET (XE3P_ECC_IMPACTING_DE , val); +return 0 ; }
drivers/gpu/drm/i915/soc/intel_dram.h +1 -0
@@ -30,6 +30,7 @@ struct dram_info {u8 num_channels;u8 num_qgv_points;u8 num_psf_gv_points; +bool ecc_impacting_de_bw;/* Only valid from Xe3p_LPD onward. */ bool symmetric_memory;bool has_16gb_dimms; };
Signature · 1 line
2.51.0
Re: [PATCH v2 04/32] drm/i915/dram: Add field ecc_impacting_de_bw
Quoting Gustavo Sousa (2025-10-21 21:28:29-03:00)
Quoted 32 lines
Starting with
Xe3p_LPD, we now have a new field inMEM_SS_INFO_GLOBALthat indicates whether the memory has enabled ECC that limits display bandwidth. Add the fieldecc_impacting_de_bwto structdram_infoto contain that information and set it appropriately when probing for memory info.Currently there are no instructions in Bspec on how to handle that case, so let's throw a warning if we ever find such a scenario.
v2:
- s/ecc_impacting_de/ecc_impacting_de_bw/ to be more specific. (Matt Atwood)
- Add warning ifecc_impacting_de_bwis true, since we currently do not have instructions on how to handle it. (Matt Roper)Bspec: 69131
Cc Jani Nikula <[email protected]>Cc Matt Atwood <[email protected]>Cc Matt Roper <[email protected]>Signed-off-by Gustavo Sousa <[email protected]>---
drivers/gpu/drm/i915/display/intel_bw.c | 8 ++++++++ drivers/gpu/drm/i915/i915_reg.h | 1 + drivers/gpu/drm/i915/soc/intel_dram.c | 4 ++++ drivers/gpu/drm/i915/soc/intel_dram.h | 1 + 4 files changed, 14 insertions(+)drivers/gpu/drm/i915/display/intel_bw.c +0
-0
drivers/gpu/drm/i915/display/intel_bw.c void intel_bw_init_hw(struct intel_display *display) · line 811
Quoted 10 lines
drivers/gpu/drm/i915/display/intel_bw.c +7
-0@@ -802,6 +802,14 @@ void intel_bw_init_hw(struct intel_display *display)if (!HAS_DISPLAY (display))return ; +/* +* Starting with Xe3p_LPD, the hardware tells us whether memory has ECC +* enabled that would impact display bandwidth. However, so far there +* are no instructions in Bspec on how to handle that case. Let's +* complain if we ever find such a scenario. +*/ +drm_WARN_ON_ONCE (display->drm, dram_info->ecc_impacting_de_bw);
Oops. Just realized that DG2 does not have dram_info. Thanks, CI!
I'll fix this on the next version, probably with:
drm_WARN_ON_ONCE(display->drm, dram_info && dram_info->ecc_impacting_de_bw);
--
Gustavo Sousa
Quoted 54 lines
drivers/gpu/drm/i915/display/intel_bw.c +1
-0+if (DISPLAY_VERx100 (display) >=3002 ) {tgl_get_bw_info (display, dram_info, &xe3lpd_3002_sa_info); }else if (DISPLAY_VER (display) >=30 ) {drivers/gpu/drm/i915/i915_reg.h +1
-0@@ -1233,6 +1233,7 @@#define OROM_OFFSET_MASK REG_GENMASK(20, 16)#define MTL_MEM_SS_INFO_GLOBAL _MMIO(0x45700) +#define XE3P_ECC_IMPACTING_DE REG_BIT(12)#define MTL_N_OF_ENABLED_QGV_POINTS_MASK REG_GENMASK(11, 8)#define MTL_N_OF_POPULATED_CH_MASK REG_GENMASK(7, 4)#define MTL_DDR_TYPE_MASK REG_GENMASK(3, 0)drivers/gpu/drm/i915/soc/intel_dram.c +4
-0@@ -685,6 +685,7 @@ static int gen12_get_dram_info(struct drm_i915_private *i915, struct dram_info *static int xelpdp_get_dram_info (struct drm_i915_private *i915,struct dram_info *dram_info) { +struct intel_display *display = i915->display;u32 val =intel_uncore_read (&i915->uncore,MTL_MEM_SS_INFO_GLOBAL );switch (REG_FIELD_GET (MTL_DDR_TYPE_MASK , val)) {@@ -723,6 +724,9 @@ static int xelpdp_get_dram_info(struct drm_i915_private *i915, struct dram_info dram_info->num_qgv_points =REG_FIELD_GET (MTL_N_OF_ENABLED_QGV_POINTS_MASK , val);/* PSF GV points not supported in D14+ */ +if (DISPLAY_VER (display) >=35 ) + dram_info->ecc_impacting_de_bw =REG_FIELD_GET (XE3P_ECC_IMPACTING_DE , val); +return 0 ; }drivers/gpu/drm/i915/soc/intel_dram.h +1
-0@@ -30,6 +30,7 @@ struct dram_info {u8 num_channels;u8 num_qgv_points;u8 num_psf_gv_points; +bool ecc_impacting_de_bw;/* Only valid from Xe3p_LPD onward. */ bool symmetric_memory;bool has_16gb_dimms; };Signature · 2 lines
-- 2.51.0
Jani Nikula
maintainerRe: [PATCH v2 04/32] drm/i915/dram: Add field ecc_impacting_de_bw
Quoted 46 lines · Gustavo Sousa
Quoting Gustavo Sousa (2025-10-21 21:28:29-03:00)
Quoted 32 lines
Starting with
Xe3p_LPD, we now have a new field inMEM_SS_INFO_GLOBALthat indicates whether the memory has enabled ECC that limits display bandwidth. Add the fieldecc_impacting_de_bwto structdram_infoto contain that information and set it appropriately when probing for memory info.Currently there are no instructions in Bspec on how to handle that case, so let's throw a warning if we ever find such a scenario.
v2:
- s/ecc_impacting_de/ecc_impacting_de_bw/ to be more specific. (Matt Atwood)
- Add warning ifecc_impacting_de_bwis true, since we currently do not have instructions on how to handle it. (Matt Roper)Bspec: 69131
Cc Jani Nikula <[email protected]>Cc Matt Atwood <[email protected]>Cc Matt Roper <[email protected]>Signed-off-by Gustavo Sousa <[email protected]>---
drivers/gpu/drm/i915/display/intel_bw.c | 8 ++++++++ drivers/gpu/drm/i915/i915_reg.h | 1 + drivers/gpu/drm/i915/soc/intel_dram.c | 4 ++++ drivers/gpu/drm/i915/soc/intel_dram.h | 1 + 4 files changed, 14 insertions(+)drivers/gpu/drm/i915/display/intel_bw.c +0
-0drivers/gpu/drm/i915/display/intel_bw.c void intel_bw_init_hw(struct intel_display *display) · line 811
Quoted 10 lines
drivers/gpu/drm/i915/display/intel_bw.c +7
-0@@ -802,6 +802,14 @@ void intel_bw_init_hw(struct intel_display *display)if (!HAS_DISPLAY (display))return ; +/* +* Starting with Xe3p_LPD, the hardware tells us whether memory has ECC +* enabled that would impact display bandwidth. However, so far there +* are no instructions in Bspec on how to handle that case. Let's +* complain if we ever find such a scenario. +*/ +drm_WARN_ON_ONCE (display->drm, dram_info->ecc_impacting_de_bw);Oops. Just realized that DG2 does not have
dram_info. Thanks, CI!
Quoted 4 lines
I'll fix this on the next version, probably with:
drm_WARN_ON_ONCE(display->drm, dram_info && dram_info->ecc_impacting_de_bw);
The comment I added above intel_dram_info():
/*
* Returns NULL for platforms that don't have dram info. Avoid overzealous NULL
* checks, and prefer not dereferencing on platforms that shouldn't look at dram
* info, to catch accidental and incorrect dram info checks.
*/
You caught the whole thing on CI *because* there was no NULL check. With the NULL check, you'll ignore missing dram info on future platforms that should have it.
BR,
Jani.
Quoted 58 lines
--
Gustavo SousaQuoted 54 lines
drivers/gpu/drm/i915/display/intel_bw.c +1
-0+if (DISPLAY_VERx100 (display) >=3002 ) {tgl_get_bw_info (display, dram_info, &xe3lpd_3002_sa_info); }else if (DISPLAY_VER (display) >=30 ) {drivers/gpu/drm/i915/i915_reg.h +1
-0@@ -1233,6 +1233,7 @@#define OROM_OFFSET_MASK REG_GENMASK(20, 16)#define MTL_MEM_SS_INFO_GLOBAL _MMIO(0x45700) +#define XE3P_ECC_IMPACTING_DE REG_BIT(12)#define MTL_N_OF_ENABLED_QGV_POINTS_MASK REG_GENMASK(11, 8)#define MTL_N_OF_POPULATED_CH_MASK REG_GENMASK(7, 4)#define MTL_DDR_TYPE_MASK REG_GENMASK(3, 0)drivers/gpu/drm/i915/soc/intel_dram.c +4
-0@@ -685,6 +685,7 @@ static int gen12_get_dram_info(struct drm_i915_private *i915, struct dram_info *static int xelpdp_get_dram_info (struct drm_i915_private *i915,struct dram_info *dram_info) { +struct intel_display *display = i915->display;u32 val =intel_uncore_read (&i915->uncore,MTL_MEM_SS_INFO_GLOBAL );switch (REG_FIELD_GET (MTL_DDR_TYPE_MASK , val)) {@@ -723,6 +724,9 @@ static int xelpdp_get_dram_info(struct drm_i915_private *i915, struct dram_info dram_info->num_qgv_points =REG_FIELD_GET (MTL_N_OF_ENABLED_QGV_POINTS_MASK , val);/* PSF GV points not supported in D14+ */ +if (DISPLAY_VER (display) >=35 ) + dram_info->ecc_impacting_de_bw =REG_FIELD_GET (XE3P_ECC_IMPACTING_DE , val); +return 0 ; }drivers/gpu/drm/i915/soc/intel_dram.h +1
-0@@ -30,6 +30,7 @@ struct dram_info {u8 num_channels;u8 num_qgv_points;u8 num_psf_gv_points; +bool ecc_impacting_de_bw;/* Only valid from Xe3p_LPD onward. */ bool symmetric_memory;bool has_16gb_dimms; };Signature · 2 lines
-- 2.51.0
Signature · 1 line
Jani Nikula, Intel
Re: [PATCH v2 04/32] drm/i915/dram: Add field ecc_impacting_de_bw
Quoting Jani Nikula (2025-10-22 08:53:34-03:00)
Quoted 60 lines · Gustavo Sousa
Quoted 46 lines
Quoting Gustavo Sousa (2025-10-21 21:28:29-03:00)
Quoted 32 lines
Starting with
Xe3p_LPD, we now have a new field inMEM_SS_INFO_GLOBALthat indicates whether the memory has enabled ECC that limits display bandwidth. Add the fieldecc_impacting_de_bwto structdram_infoto contain that information and set it appropriately when probing for memory info.Currently there are no instructions in Bspec on how to handle that case, so let's throw a warning if we ever find such a scenario.
v2:
- s/ecc_impacting_de/ecc_impacting_de_bw/ to be more specific. (Matt Atwood)
- Add warning ifecc_impacting_de_bwis true, since we currently do not have instructions on how to handle it. (Matt Roper)Bspec: 69131
Cc Jani Nikula <[email protected]>Cc Matt Atwood <[email protected]>Cc Matt Roper <[email protected]>Signed-off-by Gustavo Sousa <[email protected]>---
drivers/gpu/drm/i915/display/intel_bw.c | 8 ++++++++ drivers/gpu/drm/i915/i915_reg.h | 1 + drivers/gpu/drm/i915/soc/intel_dram.c | 4 ++++ drivers/gpu/drm/i915/soc/intel_dram.h | 1 + 4 files changed, 14 insertions(+)drivers/gpu/drm/i915/display/intel_bw.c +0
-0drivers/gpu/drm/i915/display/intel_bw.c void intel_bw_init_hw(struct intel_display *display) · line 811
Quoted 10 lines
drivers/gpu/drm/i915/display/intel_bw.c +7
-0@@ -802,6 +802,14 @@ void intel_bw_init_hw(struct intel_display *display)if (!HAS_DISPLAY (display))return ; +/* +* Starting with Xe3p_LPD, the hardware tells us whether memory has ECC +* enabled that would impact display bandwidth. However, so far there +* are no instructions in Bspec on how to handle that case. Let's +* complain if we ever find such a scenario. +*/ +drm_WARN_ON_ONCE (display->drm, dram_info->ecc_impacting_de_bw);Oops. Just realized that DG2 does not have
dram_info. Thanks, CI!Quoted 4 lines
I'll fix this on the next version, probably with:
drm_WARN_ON_ONCE(display->drm, dram_info && dram_info->ecc_impacting_de_bw);The comment I added above
intel_dram_info():/*
* Returns NULL for platforms that don't have dram info. Avoid overzealous NULL
* checks, and prefer not dereferencing on platforms that shouldn't look at dram
* info, to catch accidental and incorrect dram info checks.
*/
Quoted 3 lines
You caught the whole thing on CI *because* there was no NULL check. With the NULL check, you'll ignore missing dram info on future platforms that should have it.
Okay. I see your point. So, perhaps I should keep the drm_WARN_ON_ONCE() inside the display version >= 35 case?
--
Gustavo Sousa
Quoted 69 lines
BR,
Jani.Quoted 58 lines
--
Gustavo SousaQuoted 54 lines
drivers/gpu/drm/i915/display/intel_bw.c +1
-0+if (DISPLAY_VERx100 (display) >=3002 ) {tgl_get_bw_info (display, dram_info, &xe3lpd_3002_sa_info); }else if (DISPLAY_VER (display) >=30 ) {drivers/gpu/drm/i915/i915_reg.h +1
-0@@ -1233,6 +1233,7 @@#define OROM_OFFSET_MASK REG_GENMASK(20, 16)#define MTL_MEM_SS_INFO_GLOBAL _MMIO(0x45700) +#define XE3P_ECC_IMPACTING_DE REG_BIT(12)#define MTL_N_OF_ENABLED_QGV_POINTS_MASK REG_GENMASK(11, 8)#define MTL_N_OF_POPULATED_CH_MASK REG_GENMASK(7, 4)#define MTL_DDR_TYPE_MASK REG_GENMASK(3, 0)drivers/gpu/drm/i915/soc/intel_dram.c +4
-0@@ -685,6 +685,7 @@ static int gen12_get_dram_info(struct drm_i915_private *i915, struct dram_info *static int xelpdp_get_dram_info (struct drm_i915_private *i915,struct dram_info *dram_info) { +struct intel_display *display = i915->display;u32 val =intel_uncore_read (&i915->uncore,MTL_MEM_SS_INFO_GLOBAL );switch (REG_FIELD_GET (MTL_DDR_TYPE_MASK , val)) {@@ -723,6 +724,9 @@ static int xelpdp_get_dram_info(struct drm_i915_private *i915, struct dram_info dram_info->num_qgv_points =REG_FIELD_GET (MTL_N_OF_ENABLED_QGV_POINTS_MASK , val);/* PSF GV points not supported in D14+ */ +if (DISPLAY_VER (display) >=35 ) + dram_info->ecc_impacting_de_bw =REG_FIELD_GET (XE3P_ECC_IMPACTING_DE , val); +return 0 ; }drivers/gpu/drm/i915/soc/intel_dram.h +1
-0@@ -30,6 +30,7 @@ struct dram_info {u8 num_channels;u8 num_qgv_points;u8 num_psf_gv_points; +bool ecc_impacting_de_bw;/* Only valid from Xe3p_LPD onward. */ bool symmetric_memory;bool has_16gb_dimms; };Signature · 2 lines
-- 2.51.0Signature · 1 line
Jani Nikula, Intel
PATCH v2 5/32 drm/i915/xe3p_lpd: Update bandwidth parameters
In reply to Gustavo SousaFrom: Matt Atwood <[email protected]>
Bandwidth parameters for Xe3p_LPD are the same as for Xe3_LPD. Re-use them.
v2:
- Do not have a special case for ecc_impacting_de_bw, since there are no specific instructions in Bspec for this scenario. (Matt Roper)
Bspec: 68859
--- drivers/gpu/drm/i915/display/intel_bw.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/gpu/drm/i915/display/intel_bw.c +3 -1
@@ -810,7 +810,9 @@ void intel_bw_init_hw(struct intel_display *display)*/ drm_WARN_ON_ONCE (display->drm, dram_info->ecc_impacting_de_bw); -if (DISPLAY_VERx100 (display) >=3002 ) { +if (DISPLAY_VER (display) >=35 ) { +tgl_get_bw_info (display, dram_info, &xe3lpd_sa_info); + }else if (DISPLAY_VERx100 (display) >=3002 ) {tgl_get_bw_info (display, dram_info, &xe3lpd_3002_sa_info); }else if (DISPLAY_VER (display) >=30 ) {tgl_get_bw_info (display, dram_info, &xe3lpd_sa_info);
Signature · 1 line
2.51.0
Re: [PATCH v2 05/32] drm/i915/xe3p_lpd: Update bandwidth parameters
Quoted 22 lines · Gustavo Sousa
From: Matt Atwood <[email protected]>
Bandwidth parameters for
Xe3p_LPDare the same as forXe3_LPD. Re-use them.v2:
- Do not have a special case forecc_impacting_de_bw, since there are no specific instructions in Bspec for this scenario. (Matt Roper)Bspec: 68859
Cc Matt Roper <[email protected]>Signed-off-by Matt Atwood <[email protected]>Signed-off-by Gustavo Sousa <[email protected]>--- drivers/gpu/drm/i915/display/intel_bw.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)drivers/gpu/drm/i915/display/intel_bw.c +0
-0
drivers/gpu/drm/i915/display/intel_bw.c void intel_bw_init_hw(struct intel_display *display) · line 815
Quoted 7 lines
drivers/gpu/drm/i915/display/intel_bw.c +3
-1@@ -810,7 +810,9 @@ void intel_bw_init_hw(struct intel_display *display)*/ drm_WARN_ON_ONCE (display->drm, dram_info->ecc_impacting_de_bw); -if (DISPLAY_VERx100 (display) >=3002 ) { +if (DISPLAY_VER (display) >=35 ) { +tgl_get_bw_info (display, dram_info, &xe3lpd_sa_info); + }else if (DISPLAY_VERx100 (display) >=3002 ) {
We could change 30.02 to a "==" since it's a one-off special case, and let everything else continue to fall into to the ">= 30" branch below. Up to you; either way,
As I mentioned before, we probably should think about moving the bandwidth / memory stuff back to being platform-based rather than IP-based, but that's something we can look at as a folow-up; it doesn't need to be part of this series.
Matt
Quoted 7 lines
drivers/gpu/drm/i915/display/intel_bw.c +0
-0tgl_get_bw_info (display, dram_info, &xe3lpd_3002_sa_info); }else if (DISPLAY_VER (display) >=30 ) {tgl_get_bw_info (display, dram_info, &xe3lpd_sa_info);Signature · 2 lines
-- 2.51.0
Signature · 4 lines
Matt Roper Graphics Software Engineer Linux GPU Platform Enablement Intel Corporation
Re: [PATCH v2 05/32] drm/i915/xe3p_lpd: Update bandwidth parameters
Quoting Matt Roper (2025-10-22 11:56:40-03:00)
Quoted 26 lines · Gustavo Sousa
Quoted 25 lines
From: Matt Atwood <[email protected]>
Bandwidth parameters for
Xe3p_LPDare the same as forXe3_LPD. Re-use them.v2:
- Do not have a special case forecc_impacting_de_bw, since there are no specific instructions in Bspec for this scenario. (Matt Roper)Bspec: 68859
Cc Matt Roper <[email protected]>Signed-off-by Matt Atwood <[email protected]>Signed-off-by Gustavo Sousa <[email protected]>--- drivers/gpu/drm/i915/display/intel_bw.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)drivers/gpu/drm/i915/display/intel_bw.c +0
-0@@ -810,7 +810,9 @@ void intel_bw_init_hw(struct intel_display *display)*/ drm_WARN_ON_ONCE (display->drm, dram_info->ecc_impacting_de_bw);
Quoted 7 lines
drivers/gpu/drm/i915/display/intel_bw.c void intel_bw_init_hw(struct intel_display *display) · line 815
Quoted 4 lines
drivers/gpu/drm/i915/display/intel_bw.c +3
-1-if (DISPLAY_VERx100 (display) >=3002 ) { +if (DISPLAY_VER (display) >=35 ) { +tgl_get_bw_info (display, dram_info, &xe3lpd_sa_info); + }else if (DISPLAY_VERx100 (display) >=3002 ) {We could change 30.02 to a "==" since it's a one-off special case, and let everything else continue to fall into to the ">= 30" branch below.
Yeah, that sounds good. I'll go with your suggestion.
Quoted 3 lines
Up to you; either way,
Reviewed-by Matt Roper <[email protected]>
Thanks!
--
Gustavo Sousa
Quoted 22 lines
As I mentioned before, we probably should think about moving the bandwidth / memory stuff back to being platform-based rather than IP-based, but that's something we can look at as a folow-up; it doesn't need to be part of this series.
Matt
Quoted 7 lines
drivers/gpu/drm/i915/display/intel_bw.c +0
-0tgl_get_bw_info (display, dram_info, &xe3lpd_3002_sa_info); }else if (DISPLAY_VER (display) >=30 ) {tgl_get_bw_info (display, dram_info, &xe3lpd_sa_info);Signature · 2 lines
-- 2.51.0Signature · 4 lines
Matt Roper Graphics Software Engineer Linux GPU Platform Enablement Intel Corporation
PATCH v2 6/32 drm/i915/xe3p_lpd: Expand bifield masks dbuf blocks fields
In reply to Gustavo SousaFrom: Sai Teja Pottumuttu <[email protected]>
On Xe3p_LPD, the dbuf blocks fields of different registers are now documented as 13-bit fields. The dbuf isn't really large enough to need the 13th bit, but let's go ahead and update the definition now just in case some new display IP in future ends up needing the larger size. The extra bit is an unused bit in previous display versions, so we can safely just extend the existing definition.
Bspec: 69847, 69880, 72053
--- drivers/gpu/drm/i915/display/skl_universal_plane_regs.h | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-)
drivers/gpu/drm/i915/display/skl_universal_plane_regs.h +6 -6
@@ -324,7 +324,7 @@#define PLANE_WM_IGNORE_LINES REG_BIT(30)#define PLANE_WM_AUTO_MIN_ALLOC_EN REG_BIT(29)#define PLANE_WM_LINES_MASK REG_GENMASK(26, 14) -#define PLANE_WM_BLOCKS_MASK REG_GENMASK(11, 0) +#define PLANE_WM_BLOCKS_MASK REG_GENMASK(12, 0)#define _PLANE_WM_SAGV_1_A 0x70258#define _PLANE_WM_SAGV_1_B 0x71258
@@ -375,10 +375,10 @@ _PLANE_BUF_CFG_1_A, _PLANE_BUF_CFG_1_B, \ _PLANE_BUF_CFG_2_A, _PLANE_BUF_CFG_2_B) -/* skl+: 10 bits, icl+ 11 bits, adlp+ 12 bits */ -#define PLANE_BUF_END_MASK REG_GENMASK(27, 16) +/* skl+: 10 bits, icl+ 11 bits, adlp+ 12 bits, xe3p_lpd 13 bits */ +#define PLANE_BUF_END_MASK REG_GENMASK(28, 16)#define PLANE_BUF_END (end) REG_FIELD_PREP(PLANE_BUF_END_MASK, (end)) -#define PLANE_BUF_START_MASK REG_GENMASK(11, 0) +#define PLANE_BUF_START_MASK REG_GENMASK(12, 0)#define PLANE_BUF_START (start) REG_FIELD_PREP(PLANE_BUF_START_MASK, (start))#define _PLANE_MIN_BUF_CFG_1_A 0x70274
@@ -389,9 +389,9 @@ _PLANE_MIN_BUF_CFG_1_A, _PLANE_MIN_BUF_CFG_1_B, \ _PLANE_MIN_BUF_CFG_2_A, _PLANE_MIN_BUF_CFG_2_B)#define PLANE_AUTO_MIN_DBUF_EN REG_BIT(31) -#define PLANE_MIN_DBUF_BLOCKS_MASK REG_GENMASK(27, 16) +#define PLANE_MIN_DBUF_BLOCKS_MASK REG_GENMASK(28, 16)#define PLANE_MIN_DBUF_BLOCKS (val) REG_FIELD_PREP(PLANE_MIN_DBUF_BLOCKS_MASK, (val)) -#define PLANE_INTERIM_DBUF_BLOCKS_MASK REG_GENMASK(11, 0) +#define PLANE_INTERIM_DBUF_BLOCKS_MASK REG_GENMASK(12, 0)#define PLANE_INTERIM_DBUF_BLOCKS (val) REG_FIELD_PREP(PLANE_INTERIM_DBUF_BLOCKS_MASK, (val))/* tgl+ */
Signature · 1 line
2.51.0
PATCH v2 7/32 drm/i915/xe3p_lpd: Support UINT16 formats
In reply to Gustavo SousaFrom: Sai Teja Pottumuttu <[email protected]>
Starting from display Xe3p_LPD, UINT16 formats are also supported. Add its corresponding PLANE_CTL bit and add the format in the necessary functions.
v2:
- Add reference to Bspec 68911. (Matt Atwood)
Bspec: 68904, 69853, 68911
--- drivers/gpu/drm/i915/display/skl_universal_plane.c | 96 +++++++++++++++------- .../drm/i915/display/skl_universal_plane_regs.h | 1 + 2 files changed, 68 insertions(+), 29 deletions(-)
drivers/gpu/drm/i915/display/skl_universal_plane.c +67 -29
@@ -136,36 +136,47 @@ static const u32 icl_sdr_uv_plane_formats[] = { DRM_FORMAT_XVYU2101010, }; +#define ICL_HDR_PLANE_FORMATS \ + DRM_FORMAT_C8, \ + DRM_FORMAT_RGB565, \ + DRM_FORMAT_XRGB8888, \ + DRM_FORMAT_XBGR8888, \ + DRM_FORMAT_ARGB8888, \ + DRM_FORMAT_ABGR8888, \ + DRM_FORMAT_XRGB2101010, \ + DRM_FORMAT_XBGR2101010, \ + DRM_FORMAT_ARGB2101010, \ + DRM_FORMAT_ABGR2101010, \ + DRM_FORMAT_XRGB16161616F, \ + DRM_FORMAT_XBGR16161616F, \ + DRM_FORMAT_ARGB16161616F, \ + DRM_FORMAT_ABGR16161616F, \ + DRM_FORMAT_YUYV, \ + DRM_FORMAT_YVYU, \ + DRM_FORMAT_UYVY, \ + DRM_FORMAT_VYUY, \ + DRM_FORMAT_NV12, \ + DRM_FORMAT_P010, \ + DRM_FORMAT_P012, \ + DRM_FORMAT_P016, \ + DRM_FORMAT_Y210, \ + DRM_FORMAT_Y212, \ + DRM_FORMAT_Y216, \ + DRM_FORMAT_XYUV8888, \ + DRM_FORMAT_XVYU2101010, \ + DRM_FORMAT_XVYU12_16161616, \ + DRM_FORMAT_XVYU16161616 +static const u32 icl_hdr_plane_formats[] = { -DRM_FORMAT_C8 , -DRM_FORMAT_RGB565 , -DRM_FORMAT_XRGB8888 , -DRM_FORMAT_XBGR8888 , -DRM_FORMAT_ARGB8888 , -DRM_FORMAT_ABGR8888 , -DRM_FORMAT_XRGB2101010 , -DRM_FORMAT_XBGR2101010 , -DRM_FORMAT_ARGB2101010 , -DRM_FORMAT_ABGR2101010 , -DRM_FORMAT_XRGB16161616F , -DRM_FORMAT_XBGR16161616F , -DRM_FORMAT_ARGB16161616F , -DRM_FORMAT_ABGR16161616F , -DRM_FORMAT_YUYV , -DRM_FORMAT_YVYU , -DRM_FORMAT_UYVY , -DRM_FORMAT_VYUY , -DRM_FORMAT_NV12 , -DRM_FORMAT_P010 , -DRM_FORMAT_P012 , -DRM_FORMAT_P016 , -DRM_FORMAT_Y210 , -DRM_FORMAT_Y212 , -DRM_FORMAT_Y216 , -DRM_FORMAT_XYUV8888 , -DRM_FORMAT_XVYU2101010 , -DRM_FORMAT_XVYU12_16161616 , -DRM_FORMAT_XVYU16161616 , +ICL_HDR_PLANE_FORMATS , +}; + +static const u32 xe3p_lpd_hdr_plane_formats[] = { +ICL_HDR_PLANE_FORMATS , +DRM_FORMAT_XRGB16161616 , +DRM_FORMAT_XBGR16161616 , +DRM_FORMAT_ARGB16161616 , +DRM_FORMAT_ABGR16161616 , };int skl_format_to_fourcc (int format,bool rgb_order,bool alpha)
@@ -220,6 +231,18 @@ int skl_format_to_fourcc(int format, bool rgb_order, bool alpha)else return DRM_FORMAT_XRGB2101010 ; } +case PLANE_CTL_FORMAT_XRGB_16161616 : +if (rgb_order) { +if (alpha) +return DRM_FORMAT_ABGR16161616 ; +else +return DRM_FORMAT_XBGR16161616 ; + }else { +if (alpha) +return DRM_FORMAT_ARGB16161616 ; +else +return DRM_FORMAT_XRGB16161616 ; + }case PLANE_CTL_FORMAT_XRGB_16161616F :if (rgb_order) {if (alpha)
@@ -960,6 +983,12 @@ static u32 skl_plane_ctl_format(u32 pixel_format)case DRM_FORMAT_XRGB2101010 :case DRM_FORMAT_ARGB2101010 :return PLANE_CTL_FORMAT_XRGB_2101010 ; +case DRM_FORMAT_XBGR16161616 : +case DRM_FORMAT_ABGR16161616 : +return PLANE_CTL_FORMAT_XRGB_16161616 |PLANE_CTL_ORDER_RGBX ; +case DRM_FORMAT_XRGB16161616 : +case DRM_FORMAT_ARGB16161616 : +return PLANE_CTL_FORMAT_XRGB_16161616 ;case DRM_FORMAT_XBGR16161616F :case DRM_FORMAT_ABGR16161616F :return PLANE_CTL_FORMAT_XRGB_16161616F |PLANE_CTL_ORDER_RGBX ;
@@ -2479,6 +2508,11 @@ static const u32 *icl_get_plane_formats(struct intel_display *display, int *num_formats) {if (icl_is_hdr_plane (display, plane_id)) { +if (DISPLAY_VER (display) >=35 ) { + *num_formats =ARRAY_SIZE (xe3p_lpd_hdr_plane_formats); +return xe3p_lpd_hdr_plane_formats; + } + *num_formats =ARRAY_SIZE (icl_hdr_plane_formats);return icl_hdr_plane_formats; }else if (icl_is_nv12_y_plane (display, plane_id)) {
@@ -2637,6 +2671,10 @@ static bool tgl_plane_format_mod_supported(struct drm_plane *_plane,case DRM_FORMAT_RGB565 :case DRM_FORMAT_XVYU2101010 :case DRM_FORMAT_C8 : +case DRM_FORMAT_XBGR16161616 : +case DRM_FORMAT_ABGR16161616 : +case DRM_FORMAT_XRGB16161616 : +case DRM_FORMAT_ARGB16161616 :case DRM_FORMAT_Y210 :case DRM_FORMAT_Y212 :case DRM_FORMAT_Y216 :
drivers/gpu/drm/i915/display/skl_universal_plane_regs.h +1 -0
@@ -64,6 +64,7 @@#define PLANE_CTL_FORMAT_Y410 REG_FIELD_PREP(PLANE_CTL_FORMAT_MASK_ICL, 7)#define PLANE_CTL_FORMAT_Y412 REG_FIELD_PREP(PLANE_CTL_FORMAT_MASK_ICL, 9)#define PLANE_CTL_FORMAT_Y416 REG_FIELD_PREP(PLANE_CTL_FORMAT_MASK_ICL, 11) +#define PLANE_CTL_FORMAT_XRGB_16161616 REG_FIELD_PREP(PLANE_CTL_FORMAT_MASK_ICL, 18)#define PLANE_CTL_PIPE_CSC_ENABLE REG_BIT(23)/* Pre-GLK */ #define PLANE_CTL_KEY_ENABLE_MASK REG_GENMASK(22, 21)#define PLANE_CTL_KEY_ENABLE_SOURCE REG_FIELD_PREP(PLANE_CTL_KEY_ENABLE_MASK, 1)
Signature · 1 line
2.51.0
Re: [PATCH v2 07/32] drm/i915/xe3p_lpd: Support UINT16 formats
Quoted 5 lines · Gustavo Sousa
From: Sai Teja Pottumuttu <[email protected]>
Starting from display
Xe3p_LPD, UINT16 formats are also supported. Add its correspondingPLANE_CTLbit and add the format in the necessary functions.
Those have been supported by the hardware for a lot longer than that.
I have an old branch that adds them here:
https://github.com/vsyrjala/linux.git uint16
but I never landed that.
Quoted 164 lines
v2:
- Add reference to Bspec 68911. (Matt Atwood)Bspec: 68904, 69853, 68911
Signed-off-by Sai Teja Pottumuttu <[email protected]>Reviewed-by Matt Atwood <[email protected]>Signed-off-by Gustavo Sousa <[email protected]>--- drivers/gpu/drm/i915/display/skl_universal_plane.c | 96 +++++++++++++++------- .../drm/i915/display/skl_universal_plane_regs.h | 1 + 2 files changed, 68 insertions(+), 29 deletions(-)drivers/gpu/drm/i915/display/skl_universal_plane.c +67
-29@@ -136,36 +136,47 @@ static const u32 icl_sdr_uv_plane_formats[] = { DRM_FORMAT_XVYU2101010, }; +#define ICL_HDR_PLANE_FORMATS \ + DRM_FORMAT_C8, \ + DRM_FORMAT_RGB565, \ + DRM_FORMAT_XRGB8888, \ + DRM_FORMAT_XBGR8888, \ + DRM_FORMAT_ARGB8888, \ + DRM_FORMAT_ABGR8888, \ + DRM_FORMAT_XRGB2101010, \ + DRM_FORMAT_XBGR2101010, \ + DRM_FORMAT_ARGB2101010, \ + DRM_FORMAT_ABGR2101010, \ + DRM_FORMAT_XRGB16161616F, \ + DRM_FORMAT_XBGR16161616F, \ + DRM_FORMAT_ARGB16161616F, \ + DRM_FORMAT_ABGR16161616F, \ + DRM_FORMAT_YUYV, \ + DRM_FORMAT_YVYU, \ + DRM_FORMAT_UYVY, \ + DRM_FORMAT_VYUY, \ + DRM_FORMAT_NV12, \ + DRM_FORMAT_P010, \ + DRM_FORMAT_P012, \ + DRM_FORMAT_P016, \ + DRM_FORMAT_Y210, \ + DRM_FORMAT_Y212, \ + DRM_FORMAT_Y216, \ + DRM_FORMAT_XYUV8888, \ + DRM_FORMAT_XVYU2101010, \ + DRM_FORMAT_XVYU12_16161616, \ + DRM_FORMAT_XVYU16161616 +static const u32 icl_hdr_plane_formats[] = { -DRM_FORMAT_C8 , -DRM_FORMAT_RGB565 , -DRM_FORMAT_XRGB8888 , -DRM_FORMAT_XBGR8888 , -DRM_FORMAT_ARGB8888 , -DRM_FORMAT_ABGR8888 , -DRM_FORMAT_XRGB2101010 , -DRM_FORMAT_XBGR2101010 , -DRM_FORMAT_ARGB2101010 , -DRM_FORMAT_ABGR2101010 , -DRM_FORMAT_XRGB16161616F , -DRM_FORMAT_XBGR16161616F , -DRM_FORMAT_ARGB16161616F , -DRM_FORMAT_ABGR16161616F , -DRM_FORMAT_YUYV , -DRM_FORMAT_YVYU , -DRM_FORMAT_UYVY , -DRM_FORMAT_VYUY , -DRM_FORMAT_NV12 , -DRM_FORMAT_P010 , -DRM_FORMAT_P012 , -DRM_FORMAT_P016 , -DRM_FORMAT_Y210 , -DRM_FORMAT_Y212 , -DRM_FORMAT_Y216 , -DRM_FORMAT_XYUV8888 , -DRM_FORMAT_XVYU2101010 , -DRM_FORMAT_XVYU12_16161616 , -DRM_FORMAT_XVYU16161616 , +ICL_HDR_PLANE_FORMATS , +}; + +static const u32 xe3p_lpd_hdr_plane_formats[] = { +ICL_HDR_PLANE_FORMATS , +DRM_FORMAT_XRGB16161616 , +DRM_FORMAT_XBGR16161616 , +DRM_FORMAT_ARGB16161616 , +DRM_FORMAT_ABGR16161616 , };int skl_format_to_fourcc (int format,bool rgb_order,bool alpha)@@ -220,6 +231,18 @@ int skl_format_to_fourcc(int format, bool rgb_order, bool alpha)else return DRM_FORMAT_XRGB2101010 ; } +case PLANE_CTL_FORMAT_XRGB_16161616 : +if (rgb_order) { +if (alpha) +return DRM_FORMAT_ABGR16161616 ; +else +return DRM_FORMAT_XBGR16161616 ; + }else { +if (alpha) +return DRM_FORMAT_ARGB16161616 ; +else +return DRM_FORMAT_XRGB16161616 ; + }case PLANE_CTL_FORMAT_XRGB_16161616F :if (rgb_order) {if (alpha)@@ -960,6 +983,12 @@ static u32 skl_plane_ctl_format(u32 pixel_format)case DRM_FORMAT_XRGB2101010 :case DRM_FORMAT_ARGB2101010 :return PLANE_CTL_FORMAT_XRGB_2101010 ; +case DRM_FORMAT_XBGR16161616 : +case DRM_FORMAT_ABGR16161616 : +return PLANE_CTL_FORMAT_XRGB_16161616 |PLANE_CTL_ORDER_RGBX ; +case DRM_FORMAT_XRGB16161616 : +case DRM_FORMAT_ARGB16161616 : +return PLANE_CTL_FORMAT_XRGB_16161616 ;case DRM_FORMAT_XBGR16161616F :case DRM_FORMAT_ABGR16161616F :return PLANE_CTL_FORMAT_XRGB_16161616F |PLANE_CTL_ORDER_RGBX ;@@ -2479,6 +2508,11 @@ static const u32 *icl_get_plane_formats(struct intel_display *display, int *num_formats) {if (icl_is_hdr_plane (display, plane_id)) { +if (DISPLAY_VER (display) >=35 ) { + *num_formats =ARRAY_SIZE (xe3p_lpd_hdr_plane_formats); +return xe3p_lpd_hdr_plane_formats; + } + *num_formats =ARRAY_SIZE (icl_hdr_plane_formats);return icl_hdr_plane_formats; }else if (icl_is_nv12_y_plane (display, plane_id)) {@@ -2637,6 +2671,10 @@ static bool tgl_plane_format_mod_supported(struct drm_plane *_plane,case DRM_FORMAT_RGB565 :case DRM_FORMAT_XVYU2101010 :case DRM_FORMAT_C8 : +case DRM_FORMAT_XBGR16161616 : +case DRM_FORMAT_ABGR16161616 : +case DRM_FORMAT_XRGB16161616 : +case DRM_FORMAT_ARGB16161616 :case DRM_FORMAT_Y210 :case DRM_FORMAT_Y212 :case DRM_FORMAT_Y216 :drivers/gpu/drm/i915/display/skl_universal_plane_regs.h +1
-0@@ -64,6 +64,7 @@#define PLANE_CTL_FORMAT_Y410 REG_FIELD_PREP(PLANE_CTL_FORMAT_MASK_ICL, 7)#define PLANE_CTL_FORMAT_Y412 REG_FIELD_PREP(PLANE_CTL_FORMAT_MASK_ICL, 9)#define PLANE_CTL_FORMAT_Y416 REG_FIELD_PREP(PLANE_CTL_FORMAT_MASK_ICL, 11) +#define PLANE_CTL_FORMAT_XRGB_16161616 REG_FIELD_PREP(PLANE_CTL_FORMAT_MASK_ICL, 18)#define PLANE_CTL_PIPE_CSC_ENABLE REG_BIT(23)/* Pre-GLK */ #define PLANE_CTL_KEY_ENABLE_MASK REG_GENMASK(22, 21)#define PLANE_CTL_KEY_ENABLE_SOURCE REG_FIELD_PREP(PLANE_CTL_KEY_ENABLE_MASK, 1)Signature · 2 lines
-- 2.51.0
Signature · 2 lines
Ville Syrjälä Intel
Re: [PATCH v2 07/32] drm/i915/xe3p_lpd: Support UINT16 formats
Quoted 9 lines · Ville Syrjälä
Quoted 5 lines · Gustavo Sousa
From: Sai Teja Pottumuttu <[email protected]>
Starting from display
Xe3p_LPD, UINT16 formats are also supported. Add its correspondingPLANE_CTLbit and add the format in the necessary functions.Those have been supported by the hardware for a lot longer than that.
Agreed. General support was added back in ICL (bspec 7656), although it appears that it was unofficial and not productized or fully hardware-validated. It appears that support has remained unofficial even up through these current platforms. So I'm not sure we really want to enable this if we don't have a specific use case asking for it; it will _probably_ work, but there may be corner cases that have problems because it wasn't intended for real use.
The only thing that seems to have changed is that UINT16 formats got added to the list of formats that FBC can handle as part of the same change that added the FP16 formats to that list.
Matt
Quoted 173 lines
I have an old branch that adds them here:
https://github.com/vsyrjala/linux.git uint16
but I never landed that.Quoted 164 lines
v2:
- Add reference to Bspec 68911. (Matt Atwood)Bspec: 68904, 69853, 68911
Signed-off-by Sai Teja Pottumuttu <[email protected]>Reviewed-by Matt Atwood <[email protected]>Signed-off-by Gustavo Sousa <[email protected]>--- drivers/gpu/drm/i915/display/skl_universal_plane.c | 96 +++++++++++++++------- .../drm/i915/display/skl_universal_plane_regs.h | 1 + 2 files changed, 68 insertions(+), 29 deletions(-)drivers/gpu/drm/i915/display/skl_universal_plane.c +67
-29@@ -136,36 +136,47 @@ static const u32 icl_sdr_uv_plane_formats[] = { DRM_FORMAT_XVYU2101010, }; +#define ICL_HDR_PLANE_FORMATS \ + DRM_FORMAT_C8, \ + DRM_FORMAT_RGB565, \ + DRM_FORMAT_XRGB8888, \ + DRM_FORMAT_XBGR8888, \ + DRM_FORMAT_ARGB8888, \ + DRM_FORMAT_ABGR8888, \ + DRM_FORMAT_XRGB2101010, \ + DRM_FORMAT_XBGR2101010, \ + DRM_FORMAT_ARGB2101010, \ + DRM_FORMAT_ABGR2101010, \ + DRM_FORMAT_XRGB16161616F, \ + DRM_FORMAT_XBGR16161616F, \ + DRM_FORMAT_ARGB16161616F, \ + DRM_FORMAT_ABGR16161616F, \ + DRM_FORMAT_YUYV, \ + DRM_FORMAT_YVYU, \ + DRM_FORMAT_UYVY, \ + DRM_FORMAT_VYUY, \ + DRM_FORMAT_NV12, \ + DRM_FORMAT_P010, \ + DRM_FORMAT_P012, \ + DRM_FORMAT_P016, \ + DRM_FORMAT_Y210, \ + DRM_FORMAT_Y212, \ + DRM_FORMAT_Y216, \ + DRM_FORMAT_XYUV8888, \ + DRM_FORMAT_XVYU2101010, \ + DRM_FORMAT_XVYU12_16161616, \ + DRM_FORMAT_XVYU16161616 +static const u32 icl_hdr_plane_formats[] = { -DRM_FORMAT_C8 , -DRM_FORMAT_RGB565 , -DRM_FORMAT_XRGB8888 , -DRM_FORMAT_XBGR8888 , -DRM_FORMAT_ARGB8888 , -DRM_FORMAT_ABGR8888 , -DRM_FORMAT_XRGB2101010 , -DRM_FORMAT_XBGR2101010 , -DRM_FORMAT_ARGB2101010 , -DRM_FORMAT_ABGR2101010 , -DRM_FORMAT_XRGB16161616F , -DRM_FORMAT_XBGR16161616F , -DRM_FORMAT_ARGB16161616F , -DRM_FORMAT_ABGR16161616F , -DRM_FORMAT_YUYV , -DRM_FORMAT_YVYU , -DRM_FORMAT_UYVY , -DRM_FORMAT_VYUY , -DRM_FORMAT_NV12 , -DRM_FORMAT_P010 , -DRM_FORMAT_P012 , -DRM_FORMAT_P016 , -DRM_FORMAT_Y210 , -DRM_FORMAT_Y212 , -DRM_FORMAT_Y216 , -DRM_FORMAT_XYUV8888 , -DRM_FORMAT_XVYU2101010 , -DRM_FORMAT_XVYU12_16161616 , -DRM_FORMAT_XVYU16161616 , +ICL_HDR_PLANE_FORMATS , +}; + +static const u32 xe3p_lpd_hdr_plane_formats[] = { +ICL_HDR_PLANE_FORMATS , +DRM_FORMAT_XRGB16161616 , +DRM_FORMAT_XBGR16161616 , +DRM_FORMAT_ARGB16161616 , +DRM_FORMAT_ABGR16161616 , };int skl_format_to_fourcc (int format,bool rgb_order,bool alpha)@@ -220,6 +231,18 @@ int skl_format_to_fourcc(int format, bool rgb_order, bool alpha)else return DRM_FORMAT_XRGB2101010 ; } +case PLANE_CTL_FORMAT_XRGB_16161616 : +if (rgb_order) { +if (alpha) +return DRM_FORMAT_ABGR16161616 ; +else +return DRM_FORMAT_XBGR16161616 ; + }else { +if (alpha) +return DRM_FORMAT_ARGB16161616 ; +else +return DRM_FORMAT_XRGB16161616 ; + }case PLANE_CTL_FORMAT_XRGB_16161616F :if (rgb_order) {if (alpha)@@ -960,6 +983,12 @@ static u32 skl_plane_ctl_format(u32 pixel_format)case DRM_FORMAT_XRGB2101010 :case DRM_FORMAT_ARGB2101010 :return PLANE_CTL_FORMAT_XRGB_2101010 ; +case DRM_FORMAT_XBGR16161616 : +case DRM_FORMAT_ABGR16161616 : +return PLANE_CTL_FORMAT_XRGB_16161616 |PLANE_CTL_ORDER_RGBX ; +case DRM_FORMAT_XRGB16161616 : +case DRM_FORMAT_ARGB16161616 : +return PLANE_CTL_FORMAT_XRGB_16161616 ;case DRM_FORMAT_XBGR16161616F :case DRM_FORMAT_ABGR16161616F :return PLANE_CTL_FORMAT_XRGB_16161616F |PLANE_CTL_ORDER_RGBX ;@@ -2479,6 +2508,11 @@ static const u32 *icl_get_plane_formats(struct intel_display *display, int *num_formats) {if (icl_is_hdr_plane (display, plane_id)) { +if (DISPLAY_VER (display) >=35 ) { + *num_formats =ARRAY_SIZE (xe3p_lpd_hdr_plane_formats); +return xe3p_lpd_hdr_plane_formats; + } + *num_formats =ARRAY_SIZE (icl_hdr_plane_formats);return icl_hdr_plane_formats; }else if (icl_is_nv12_y_plane (display, plane_id)) {@@ -2637,6 +2671,10 @@ static bool tgl_plane_format_mod_supported(struct drm_plane *_plane,case DRM_FORMAT_RGB565 :case DRM_FORMAT_XVYU2101010 :case DRM_FORMAT_C8 : +case DRM_FORMAT_XBGR16161616 : +case DRM_FORMAT_ABGR16161616 : +case DRM_FORMAT_XRGB16161616 : +case DRM_FORMAT_ARGB16161616 :case DRM_FORMAT_Y210 :case DRM_FORMAT_Y212 :case DRM_FORMAT_Y216 :drivers/gpu/drm/i915/display/skl_universal_plane_regs.h +1
-0@@ -64,6 +64,7 @@#define PLANE_CTL_FORMAT_Y410 REG_FIELD_PREP(PLANE_CTL_FORMAT_MASK_ICL, 7)#define PLANE_CTL_FORMAT_Y412 REG_FIELD_PREP(PLANE_CTL_FORMAT_MASK_ICL, 9)#define PLANE_CTL_FORMAT_Y416 REG_FIELD_PREP(PLANE_CTL_FORMAT_MASK_ICL, 11) +#define PLANE_CTL_FORMAT_XRGB_16161616 REG_FIELD_PREP(PLANE_CTL_FORMAT_MASK_ICL, 18)#define PLANE_CTL_PIPE_CSC_ENABLE REG_BIT(23)/* Pre-GLK */ #define PLANE_CTL_KEY_ENABLE_MASK REG_GENMASK(22, 21)#define PLANE_CTL_KEY_ENABLE_SOURCE REG_FIELD_PREP(PLANE_CTL_KEY_ENABLE_MASK, 1)Signature · 2 lines
-- 2.51.0Signature · 2 lines
Ville Syrjälä Intel
Signature · 4 lines
Matt Roper Graphics Software Engineer Linux GPU Platform Enablement Intel Corporation
Re: [PATCH v2 07/32] drm/i915/xe3p_lpd: Support UINT16 formats
Quoting Matt Roper (2025-10-22 14:58:05-03:00)
Quoted 10 lines · Ville Syrjälä
Quoted 9 lines · Gustavo Sousa
Quoted 5 lines
From: Sai Teja Pottumuttu <[email protected]>
Starting from display
Xe3p_LPD, UINT16 formats are also supported. Add its correspondingPLANE_CTLbit and add the format in the necessary functions.Those have been supported by the hardware for a lot longer than that.
Yeah, Bspec shows that the support for UINT16 formats was already there before Xe3p_LPD.
Quoted 8 lines
Agreed. General support was added back in ICL (bspec 7656), although it appears that it was unofficial and not productized or fully hardware-validated. It appears that support has remained unofficial even up through these current platforms. So I'm not sure we really want to enable this if we don't have a specific use case asking for it; it will _probably_ work, but there may be corner cases that have problems because it wasn't intended for real use.
Yeah. I think I'll just drop the UINT16-related patches from this series.
Thanks!
--
Gustavo Sousa
Quoted 187 lines
The only thing that seems to have changed is that UINT16 formats got added to the list of formats that FBC can handle as part of the same change that added the FP16 formats to that list.
Matt
Quoted 173 lines
I have an old branch that adds them here:
https://github.com/vsyrjala/linux.git uint16
but I never landed that.Quoted 164 lines
v2:
- Add reference to Bspec 68911. (Matt Atwood)Bspec: 68904, 69853, 68911
Signed-off-by Sai Teja Pottumuttu <[email protected]>Reviewed-by Matt Atwood <[email protected]>Signed-off-by Gustavo Sousa <[email protected]>--- drivers/gpu/drm/i915/display/skl_universal_plane.c | 96 +++++++++++++++------- .../drm/i915/display/skl_universal_plane_regs.h | 1 + 2 files changed, 68 insertions(+), 29 deletions(-)drivers/gpu/drm/i915/display/skl_universal_plane.c +67
-29@@ -136,36 +136,47 @@ static const u32 icl_sdr_uv_plane_formats[] = { DRM_FORMAT_XVYU2101010, }; +#define ICL_HDR_PLANE_FORMATS \ + DRM_FORMAT_C8, \ + DRM_FORMAT_RGB565, \ + DRM_FORMAT_XRGB8888, \ + DRM_FORMAT_XBGR8888, \ + DRM_FORMAT_ARGB8888, \ + DRM_FORMAT_ABGR8888, \ + DRM_FORMAT_XRGB2101010, \ + DRM_FORMAT_XBGR2101010, \ + DRM_FORMAT_ARGB2101010, \ + DRM_FORMAT_ABGR2101010, \ + DRM_FORMAT_XRGB16161616F, \ + DRM_FORMAT_XBGR16161616F, \ + DRM_FORMAT_ARGB16161616F, \ + DRM_FORMAT_ABGR16161616F, \ + DRM_FORMAT_YUYV, \ + DRM_FORMAT_YVYU, \ + DRM_FORMAT_UYVY, \ + DRM_FORMAT_VYUY, \ + DRM_FORMAT_NV12, \ + DRM_FORMAT_P010, \ + DRM_FORMAT_P012, \ + DRM_FORMAT_P016, \ + DRM_FORMAT_Y210, \ + DRM_FORMAT_Y212, \ + DRM_FORMAT_Y216, \ + DRM_FORMAT_XYUV8888, \ + DRM_FORMAT_XVYU2101010, \ + DRM_FORMAT_XVYU12_16161616, \ + DRM_FORMAT_XVYU16161616 +static const u32 icl_hdr_plane_formats[] = { -DRM_FORMAT_C8 , -DRM_FORMAT_RGB565 , -DRM_FORMAT_XRGB8888 , -DRM_FORMAT_XBGR8888 , -DRM_FORMAT_ARGB8888 , -DRM_FORMAT_ABGR8888 , -DRM_FORMAT_XRGB2101010 , -DRM_FORMAT_XBGR2101010 , -DRM_FORMAT_ARGB2101010 , -DRM_FORMAT_ABGR2101010 , -DRM_FORMAT_XRGB16161616F , -DRM_FORMAT_XBGR16161616F , -DRM_FORMAT_ARGB16161616F , -DRM_FORMAT_ABGR16161616F , -DRM_FORMAT_YUYV , -DRM_FORMAT_YVYU , -DRM_FORMAT_UYVY , -DRM_FORMAT_VYUY , -DRM_FORMAT_NV12 , -DRM_FORMAT_P010 , -DRM_FORMAT_P012 , -DRM_FORMAT_P016 , -DRM_FORMAT_Y210 , -DRM_FORMAT_Y212 , -DRM_FORMAT_Y216 , -DRM_FORMAT_XYUV8888 , -DRM_FORMAT_XVYU2101010 , -DRM_FORMAT_XVYU12_16161616 , -DRM_FORMAT_XVYU16161616 , +ICL_HDR_PLANE_FORMATS , +}; + +static const u32 xe3p_lpd_hdr_plane_formats[] = { +ICL_HDR_PLANE_FORMATS , +DRM_FORMAT_XRGB16161616 , +DRM_FORMAT_XBGR16161616 , +DRM_FORMAT_ARGB16161616 , +DRM_FORMAT_ABGR16161616 , };int skl_format_to_fourcc (int format,bool rgb_order,bool alpha)@@ -220,6 +231,18 @@ int skl_format_to_fourcc(int format, bool rgb_order, bool alpha)else return DRM_FORMAT_XRGB2101010 ; } +case PLANE_CTL_FORMAT_XRGB_16161616 : +if (rgb_order) { +if (alpha) +return DRM_FORMAT_ABGR16161616 ; +else +return DRM_FORMAT_XBGR16161616 ; + }else { +if (alpha) +return DRM_FORMAT_ARGB16161616 ; +else +return DRM_FORMAT_XRGB16161616 ; + }case PLANE_CTL_FORMAT_XRGB_16161616F :if (rgb_order) {if (alpha)@@ -960,6 +983,12 @@ static u32 skl_plane_ctl_format(u32 pixel_format)case DRM_FORMAT_XRGB2101010 :case DRM_FORMAT_ARGB2101010 :return PLANE_CTL_FORMAT_XRGB_2101010 ; +case DRM_FORMAT_XBGR16161616 : +case DRM_FORMAT_ABGR16161616 : +return PLANE_CTL_FORMAT_XRGB_16161616 |PLANE_CTL_ORDER_RGBX ; +case DRM_FORMAT_XRGB16161616 : +case DRM_FORMAT_ARGB16161616 : +return PLANE_CTL_FORMAT_XRGB_16161616 ;case DRM_FORMAT_XBGR16161616F :case DRM_FORMAT_ABGR16161616F :return PLANE_CTL_FORMAT_XRGB_16161616F |PLANE_CTL_ORDER_RGBX ;@@ -2479,6 +2508,11 @@ static const u32 *icl_get_plane_formats(struct intel_display *display, int *num_formats) {if (icl_is_hdr_plane (display, plane_id)) { +if (DISPLAY_VER (display) >=35 ) { + *num_formats =ARRAY_SIZE (xe3p_lpd_hdr_plane_formats); +return xe3p_lpd_hdr_plane_formats; + } + *num_formats =ARRAY_SIZE (icl_hdr_plane_formats);return icl_hdr_plane_formats; }else if (icl_is_nv12_y_plane (display, plane_id)) {@@ -2637,6 +2671,10 @@ static bool tgl_plane_format_mod_supported(struct drm_plane *_plane,case DRM_FORMAT_RGB565 :case DRM_FORMAT_XVYU2101010 :case DRM_FORMAT_C8 : +case DRM_FORMAT_XBGR16161616 : +case DRM_FORMAT_ABGR16161616 : +case DRM_FORMAT_XRGB16161616 : +case DRM_FORMAT_ARGB16161616 :case DRM_FORMAT_Y210 :case DRM_FORMAT_Y212 :case DRM_FORMAT_Y216 :drivers/gpu/drm/i915/display/skl_universal_plane_regs.h +1
-0@@ -64,6 +64,7 @@#define PLANE_CTL_FORMAT_Y410 REG_FIELD_PREP(PLANE_CTL_FORMAT_MASK_ICL, 7)#define PLANE_CTL_FORMAT_Y412 REG_FIELD_PREP(PLANE_CTL_FORMAT_MASK_ICL, 9)#define PLANE_CTL_FORMAT_Y416 REG_FIELD_PREP(PLANE_CTL_FORMAT_MASK_ICL, 11) +#define PLANE_CTL_FORMAT_XRGB_16161616 REG_FIELD_PREP(PLANE_CTL_FORMAT_MASK_ICL, 18)#define PLANE_CTL_PIPE_CSC_ENABLE REG_BIT(23)/* Pre-GLK */ #define PLANE_CTL_KEY_ENABLE_MASK REG_GENMASK(22, 21)#define PLANE_CTL_KEY_ENABLE_SOURCE REG_FIELD_PREP(PLANE_CTL_KEY_ENABLE_MASK, 1)Signature · 2 lines
-- 2.51.0Signature · 2 lines
Ville Syrjälä IntelSignature · 4 lines
Matt Roper Graphics Software Engineer Linux GPU Platform Enablement Intel Corporation
PATCH v2 8/32 drm/i915/xe3p_lpd: Extend FBC support to UINT16 formats
In reply to Gustavo SousaFrom: Sai Teja Pottumuttu <[email protected]>
Starting Xe3p_LPD, FBC is supported on UINT16 formats as well. Also UINT16 being a 64bpp format, will use cpp of 8 for cfb stride and thus size calculations.
Cc: Shekhar Chauhan <[email protected]>
BSpec: 68881, 68904, 69560
--- drivers/gpu/drm/i915/display/intel_fbc.c | 42 ++++++++++++++++++++++++++++---- 1 file changed, 37 insertions(+), 5 deletions(-)
drivers/gpu/drm/i915/display/intel_fbc.c +37 -5
@@ -141,15 +141,25 @@ static unsigned int intel_fbc_plane_stride(const struct intel_plane_state *planereturn stride; } -static unsigned int intel_fbc_cfb_cpp (void ) +static unsigned int intel_fbc_cfb_cpp (const struct intel_plane_state *plane_state) { -return 4 ;/* FBC always 4 bytes per pixel */ +const struct drm_framebuffer *fb = plane_state->hw.fb; + +switch (fb->format->format) { +case DRM_FORMAT_XRGB16161616 : +case DRM_FORMAT_XBGR16161616 : +case DRM_FORMAT_ARGB16161616 : +case DRM_FORMAT_ABGR16161616 : +return 8 ; +default : +return 4 ; + } }/* plane stride based cfb stride in bytes, assuming 1:1 compression limit */ static unsigned int intel_fbc_plane_cfb_stride (const struct intel_plane_state *plane_state) { -unsigned int cpp =intel_fbc_cfb_cpp (); +unsigned int cpp =intel_fbc_cfb_cpp (plane_state);return intel_fbc_plane_stride (plane_state) * cpp; }
@@ -203,7 +213,7 @@ static unsigned int intel_fbc_cfb_stride(const struct intel_plane_state *plane_sstruct intel_display *display =to_intel_display (plane_state->uapi.plane->dev);unsigned int stride =intel_fbc_plane_cfb_stride (plane_state);unsigned int width =drm_rect_width (&plane_state->uapi.src) >>16 ; -unsigned int cpp =intel_fbc_cfb_cpp (); +unsigned int cpp =intel_fbc_cfb_cpp (plane_state);return _intel_fbc_cfb_stride (display, cpp, width, stride); }
@@ -1081,11 +1091,33 @@ static bool lnl_fbc_pixel_format_is_valid(const struct intel_plane_state *plane_ } } +static bool xe3p_lpd_fbc_pixel_format_is_valid (const struct intel_plane_state *plane_state) +{ +const struct drm_framebuffer *fb = plane_state->hw.fb; + +switch (fb->format->format) { +case DRM_FORMAT_XRGB8888 : +case DRM_FORMAT_XBGR8888 : +case DRM_FORMAT_ARGB8888 : +case DRM_FORMAT_ABGR8888 : +case DRM_FORMAT_RGB565 : +case DRM_FORMAT_XRGB16161616 : +case DRM_FORMAT_XBGR16161616 : +case DRM_FORMAT_ARGB16161616 : +case DRM_FORMAT_ABGR16161616 : +return true; +default : +return false; + } +} +static bool pixel_format_is_valid (const struct intel_plane_state *plane_state) {struct intel_display *display =to_intel_display (plane_state->uapi.plane->dev); -if (DISPLAY_VER (display) >=20 ) +if (DISPLAY_VER (display) >=35 ) +return xe3p_lpd_fbc_pixel_format_is_valid (plane_state); +else if (DISPLAY_VER (display) >=20 )return lnl_fbc_pixel_format_is_valid (plane_state);else if (DISPLAY_VER (display) >=5 || display->platform.g4x)return g4x_fbc_pixel_format_is_valid (plane_state);
Signature · 1 line
2.51.0
Re: [PATCH v2 08/32] drm/i915/xe3p_lpd: Extend FBC support to UINT16 formats
Quoted 27 lines · Gustavo Sousa
From: Sai Teja Pottumuttu <[email protected]>
Starting
Xe3p_LPD, FBC is supported on UINT16 formats as well. Also UINT16 being a 64bpp format, will use cpp of 8 for cfb stride and thus size calculations.Cc: Shekhar Chauhan <[email protected]>
BSpec: 68881, 68904, 69560Signed-off-by Sai Teja Pottumuttu <[email protected]>Signed-off-by Gustavo Sousa <[email protected]>--- drivers/gpu/drm/i915/display/intel_fbc.c | 42 ++++++++++++++++++++++++++++---- 1 file changed, 37 insertions(+), 5 deletions(-)drivers/gpu/drm/i915/display/intel_fbc.c +2
-2@@ -141,15 +141,25 @@ static unsigned int intel_fbc_plane_stride(const struct intel_plane_state *planereturn stride; } -static unsigned int intel_fbc_cfb_cpp (void ) +static unsigned int intel_fbc_cfb_cpp (const struct intel_plane_state *plane_state) { -return 4 ;/* FBC always 4 bytes per pixel */ +const struct drm_framebuffer *fb = plane_state->hw.fb;
drivers/gpu/drm/i915/display/intel_fbc.c static unsigned int intel_fbc_plane_stride(const struct intel_plane_state *plane · line 156
Quoted 10 lines
drivers/gpu/drm/i915/display/intel_fbc.c +10
-0+ +switch (fb->format->format) { +case DRM_FORMAT_XRGB16161616 : +case DRM_FORMAT_XBGR16161616 : +case DRM_FORMAT_ARGB16161616 : +case DRM_FORMAT_ABGR16161616 : +return 8 ; +default : +return 4 ; + }
return max(cpp, 4);
Quoted 57 lines
drivers/gpu/drm/i915/display/intel_fbc.c +25
-3}/* plane stride based cfb stride in bytes, assuming 1:1 compression limit */ static unsigned int intel_fbc_plane_cfb_stride (const struct intel_plane_state *plane_state) { -unsigned int cpp =intel_fbc_cfb_cpp (); +unsigned int cpp =intel_fbc_cfb_cpp (plane_state);return intel_fbc_plane_stride (plane_state) * cpp; }@@ -203,7 +213,7 @@ static unsigned int intel_fbc_cfb_stride(const struct intel_plane_state *plane_sstruct intel_display *display =to_intel_display (plane_state->uapi.plane->dev);unsigned int stride =intel_fbc_plane_cfb_stride (plane_state);unsigned int width =drm_rect_width (&plane_state->uapi.src) >>16 ; -unsigned int cpp =intel_fbc_cfb_cpp (); +unsigned int cpp =intel_fbc_cfb_cpp (plane_state);return _intel_fbc_cfb_stride (display, cpp, width, stride); }@@ -1081,11 +1091,33 @@ static bool lnl_fbc_pixel_format_is_valid(const struct intel_plane_state *plane_ } } +static bool xe3p_lpd_fbc_pixel_format_is_valid (const struct intel_plane_state *plane_state) +{ +const struct drm_framebuffer *fb = plane_state->hw.fb; + +switch (fb->format->format) { +case DRM_FORMAT_XRGB8888 : +case DRM_FORMAT_XBGR8888 : +case DRM_FORMAT_ARGB8888 : +case DRM_FORMAT_ABGR8888 : +case DRM_FORMAT_RGB565 : +case DRM_FORMAT_XRGB16161616 : +case DRM_FORMAT_XBGR16161616 : +case DRM_FORMAT_ARGB16161616 : +case DRM_FORMAT_ABGR16161616 : +return true; +default : +return false; + } +} +static bool pixel_format_is_valid (const struct intel_plane_state *plane_state) {struct intel_display *display =to_intel_display (plane_state->uapi.plane->dev); -if (DISPLAY_VER (display) >=20 ) +if (DISPLAY_VER (display) >=35 ) +return xe3p_lpd_fbc_pixel_format_is_valid (plane_state); +else if (DISPLAY_VER (display) >=20 )return lnl_fbc_pixel_format_is_valid (plane_state);else if (DISPLAY_VER (display) >=5 || display->platform.g4x)return g4x_fbc_pixel_format_is_valid (plane_state);Signature · 2 lines
-- 2.51.0
Signature · 2 lines
Ville Syrjälä Intel
PATCH v2 9/32 drm/i915/xe3p_lpd: Horizontal flip support for linear surfaces
In reply to Gustavo SousaFrom: Sai Teja Pottumuttu <[email protected]>
Starting from Xe3p_LPD, linear surfaces also support horizontal flip.
Bspec: 68904
--- drivers/gpu/drm/i915/display/skl_universal_plane.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/gpu/drm/i915/display/skl_universal_plane.c +2 -1
@@ -1753,7 +1753,8 @@ static int skl_plane_check_fb(const struct intel_crtc_state *crtc_state, }if (rotation &DRM_MODE_REFLECT_X && - fb->modifier ==DRM_FORMAT_MOD_LINEAR ) { + fb->modifier ==DRM_FORMAT_MOD_LINEAR && +DISPLAY_VER (display) <35 ) {drm_dbg_kms (display->drm,"[PLANE:%d:%s] horizontal flip is not supported with linear surface formats\n" , plane->base.base.id, plane->base.name);
Signature · 1 line
2.51.0
PATCH v2 10/32 drm/i915/xe3p_lpd: Wait for AUX channel power status
In reply to Gustavo SousaThe LT PHY in Xe3p_LPD allows polling for the AUX channel power status to verify completion of power up and down. As such, let's use that field to have a more precise waiting time instead of a fixed one.
Bspec: 68967
--- .../drm/i915/display/intel_display_power_well.c | 32 +++++++++++++++++----- 1 file changed, 25 insertions(+), 7 deletions(-)
drivers/gpu/drm/i915/display/intel_display_power_well.c +25 -7
@@ -1858,23 +1858,41 @@ static void xelpdp_aux_power_well_enable(struct intel_display *display,XELPDP_DP_AUX_CH_CTL_POWER_REQUEST , XELPDP_DP_AUX_CH_CTL_POWER_REQUEST); -/* -* The power status flag cannot be used to determine whether aux -* power wells have finished powering up. Instead we're -* expected to just wait a fixed 600us after raising the request -* bit. -*/ -usleep_range (600 ,1200 ); +if (DISPLAY_VER (display) >=35 ) { +if (intel_de_wait_for_set (display,XELPDP_DP_AUX_CH_CTL (display, aux_ch), +XELPDP_DP_AUX_CH_CTL_POWER_STATUS ,1 )) +drm_warn (display->drm, +"Timeout waiting for PHY %c AUX channel power to be up\n" , +phy_name (phy)); + }else { +/* +* The power status flag cannot be used to determine whether aux +* power wells have finished powering up. Instead we're +* expected to just wait a fixed 600us after raising the request +* bit. +*/ +usleep_range (600 ,1200 ); + } }static void xelpdp_aux_power_well_disable (struct intel_display *display,struct i915_power_well *power_well) {enum aux_ch aux_ch =i915_power_well_instance (power_well)->xelpdp.aux_ch; +enum phy phy =icl_aux_pw_to_phy (display, power_well);intel_de_rmw (display,XELPDP_DP_AUX_CH_CTL (display, aux_ch),XELPDP_DP_AUX_CH_CTL_POWER_REQUEST ,0 ); + +if (DISPLAY_VER (display) >=35 ) { +if (intel_de_wait_for_clear (display,XELPDP_DP_AUX_CH_CTL (display, aux_ch), +XELPDP_DP_AUX_CH_CTL_POWER_STATUS ,1 )) +drm_warn (display->drm, +"Timeout waiting for PHY %c AUX channel power to be down\n" , +phy_name (phy)); + } +usleep_range (10 ,30 ); }
Signature · 1 line
2.51.0
Re: [PATCH v2 10/32] drm/i915/xe3p_lpd: Wait for AUX channel power status
Quoted 16 lines · Gustavo Sousa
The LT PHY in
Xe3p_LPDallows polling for the AUX channel power status to verify completion of power up and down. As such, let's use that field to have a more precise waiting time instead of a fixed one.Bspec: 68967
Signed-off-by Gustavo Sousa <[email protected]>--- .../drm/i915/display/intel_display_power_well.c | 32 +++++++++++++++++----- 1 file changed, 25 insertions(+), 7 deletions(-)drivers/gpu/drm/i915/display/intel_display_power_well.c +0
-0@@ -1858,23 +1858,41 @@ static void xelpdp_aux_power_well_enable(struct intel_display *display, XELPDP_DP_AUX_CH_CTL_POWER_REQUEST,
drivers/gpu/drm/i915/display/intel_display_power_well.c static void xelpdp_aux_power_well_enable(struct intel_display *display, · line 1861
Quoted 10 lines
drivers/gpu/drm/i915/display/intel_display_power_well.c +1
-7XELPDP_DP_AUX_CH_CTL_POWER_REQUEST); -/* -* The power status flag cannot be used to determine whether aux -* power wells have finished powering up. Instead we're -* expected to just wait a fixed 600us after raising the request -* bit. -*/ -usleep_range (600 ,1200 ); +if (DISPLAY_VER (display) >=35 ) {
Since the bspec specifically calls this out as a flow for LT PHY, it seems like it would make more sense to make the condition here a feature flag check for LT PHY. As I understand it, the selection of one type of PHY over another is more of a business / per-platform decision than an IP progression thing, so it's quite possible that some future platforms past Xe3p may not have LT PHYs.
Matt
Quoted 41 lines
drivers/gpu/drm/i915/display/intel_display_power_well.c +24
-0+if (intel_de_wait_for_set (display,XELPDP_DP_AUX_CH_CTL (display, aux_ch), +XELPDP_DP_AUX_CH_CTL_POWER_STATUS ,1 )) +drm_warn (display->drm, +"Timeout waiting for PHY %c AUX channel power to be up\n" , +phy_name (phy)); + }else { +/* +* The power status flag cannot be used to determine whether aux +* power wells have finished powering up. Instead we're +* expected to just wait a fixed 600us after raising the request +* bit. +*/ +usleep_range (600 ,1200 ); + } }static void xelpdp_aux_power_well_disable (struct intel_display *display,struct i915_power_well *power_well) {enum aux_ch aux_ch =i915_power_well_instance (power_well)->xelpdp.aux_ch; +enum phy phy =icl_aux_pw_to_phy (display, power_well);intel_de_rmw (display,XELPDP_DP_AUX_CH_CTL (display, aux_ch),XELPDP_DP_AUX_CH_CTL_POWER_REQUEST ,0 ); + +if (DISPLAY_VER (display) >=35 ) { +if (intel_de_wait_for_clear (display,XELPDP_DP_AUX_CH_CTL (display, aux_ch), +XELPDP_DP_AUX_CH_CTL_POWER_STATUS ,1 )) +drm_warn (display->drm, +"Timeout waiting for PHY %c AUX channel power to be down\n" , +phy_name (phy)); + } +usleep_range (10 ,30 ); }Signature · 2 lines
-- 2.51.0
Signature · 4 lines
Matt Roper Graphics Software Engineer Linux GPU Platform Enablement Intel Corporation
Re: [PATCH v2 10/32] drm/i915/xe3p_lpd: Wait for AUX channel power status
Quoting Matt Roper (2025-10-29 17:06:28-03:00)
Quoted 19 lines · Gustavo Sousa
Quoted 18 lines
The LT PHY in
Xe3p_LPDallows polling for the AUX channel power status to verify completion of power up and down. As such, let's use that field to have a more precise waiting time instead of a fixed one.Bspec: 68967
Signed-off-by Gustavo Sousa <[email protected]>--- .../drm/i915/display/intel_display_power_well.c | 32 +++++++++++++++++----- 1 file changed, 25 insertions(+), 7 deletions(-)drivers/gpu/drm/i915/display/intel_display_power_well.c +0
-0@@ -1858,23 +1858,41 @@ static void xelpdp_aux_power_well_enable(struct intel_display *display,XELPDP_DP_AUX_CH_CTL_POWER_REQUEST , XELPDP_DP_AUX_CH_CTL_POWER_REQUEST);
Quoted 15 lines
drivers/gpu/drm/i915/display/intel_display_power_well.c static void xelpdp_aux_power_well_enable(struct intel_display *display, · line 1861
Quoted 8 lines
drivers/gpu/drm/i915/display/intel_display_power_well.c +1
-7-/* -* The power status flag cannot be used to determine whether aux -* power wells have finished powering up. Instead we're -* expected to just wait a fixed 600us after raising the request -* bit. -*/ -usleep_range (600 ,1200 ); +if (DISPLAY_VER (display) >=35 ) {Since the bspec specifically calls this out as a flow for LT PHY, it seems like it would make more sense to make the condition here a feature flag check for LT PHY. As I understand it, the selection of one type of PHY over another is more of a business / per-platform decision than an IP progression thing, so it's quite possible that some future platforms past Xe3p may not have LT PHYs.
Yeah, makes sense.
I know that the LT PHY series[1] does include a HAS_LT_PHY() macro, but it does the same IP version check. Perhaps we should define that macro using a platform check.
For this series, I think I'll add a patch to include the HAS_LT_PHY() macro with platform check and use it here.
In the long term, I was thinking we could have an enum intel_phy_type and have a function that returns the correct value based on the port.
--
Gustavo Sousa
Quoted 51 lines
Matt
Quoted 41 lines
drivers/gpu/drm/i915/display/intel_display_power_well.c +24
-0+if (intel_de_wait_for_set (display,XELPDP_DP_AUX_CH_CTL (display, aux_ch), +XELPDP_DP_AUX_CH_CTL_POWER_STATUS ,1 )) +drm_warn (display->drm, +"Timeout waiting for PHY %c AUX channel power to be up\n" , +phy_name (phy)); + }else { +/* +* The power status flag cannot be used to determine whether aux +* power wells have finished powering up. Instead we're +* expected to just wait a fixed 600us after raising the request +* bit. +*/ +usleep_range (600 ,1200 ); + } }static void xelpdp_aux_power_well_disable (struct intel_display *display,struct i915_power_well *power_well) {enum aux_ch aux_ch =i915_power_well_instance (power_well)->xelpdp.aux_ch; +enum phy phy =icl_aux_pw_to_phy (display, power_well);intel_de_rmw (display,XELPDP_DP_AUX_CH_CTL (display, aux_ch),XELPDP_DP_AUX_CH_CTL_POWER_REQUEST ,0 ); + +if (DISPLAY_VER (display) >=35 ) { +if (intel_de_wait_for_clear (display,XELPDP_DP_AUX_CH_CTL (display, aux_ch), +XELPDP_DP_AUX_CH_CTL_POWER_STATUS ,1 )) +drm_warn (display->drm, +"Timeout waiting for PHY %c AUX channel power to be down\n" , +phy_name (phy)); + } +usleep_range (10 ,30 ); }Signature · 2 lines
-- 2.51.0Signature · 4 lines
Matt Roper Graphics Software Engineer Linux GPU Platform Enablement Intel Corporation
PATCH v2 11/32 drm/i915/xe3p_lpd: Underrun debuggability and error codes/hints
In reply to Gustavo SousaFrom: Sai Teja Pottumuttu <[email protected]>
Starting with Xe3p_LPD, we get two new registers and some bits in existing registers that expose hardware state information at the time of underrun notification that can be relevant to debugging.
Add the necessary logic in the driver to print the available debug information when an underrun happens.
v2:
- Use seq_buf to generate planes string. (Jani)
- Move definition of FBC_DEBUG_STATUS to intel_fbc_regs.h. (Ville)
- Change logic for processing UNDERRUN_DBG1 to use loops and move it to a separate function. (Gustavo)
- Always print underrun error message, even if there wouldn't be any debug info associated to the underrun. (Gustavo)
Bspec: 69111, 69561, 74411, 74412
--- drivers/gpu/drm/i915/display/intel_display_regs.h | 20 +++++ drivers/gpu/drm/i915/display/intel_fbc_regs.h | 2 + drivers/gpu/drm/i915/display/intel_fifo_underrun.c | 87 ++++++++++++++++++++++ 3 files changed, 109 insertions(+)
drivers/gpu/drm/i915/display/intel_display_regs.h +20 -0
@@ -882,6 +882,25 @@#define PIPE_MISC2_FLIP_INFO_PLANE_SEL_MASK REG_GENMASK(2, 0)/* tgl+ */ #define PIPE_MISC2_FLIP_INFO_PLANE_SEL (plane_id) REG_FIELD_PREP(PIPE_MISC2_FLIP_INFO_PLANE_SEL_MASK, (plane_id)) +#define _UNDERRUN_DBG1_A 0x70064 +#define _UNDERRUN_DBG1_B 0x71064 +#define UNDERRUN_DBG1 (pipe) _MMIO_PIPE(pipe, \ + _UNDERRUN_DBG1_A, \ + _UNDERRUN_DBG1_B) +#define UNDERRUN_DBUF_BLOCK_NOT_VALID_MASK REG_GENMASK(29, 24) +#define UNDERRUN_DDB_EMPTY_MASK REG_GENMASK(21, 16) +#define UNDERRUN_DBUF_NOT_FILLED_MASK REG_GENMASK(13, 8) +#define UNDERRUN_BELOW_WM0_MASK REG_GENMASK(5, 0) + +#define _UNDERRUN_DBG2_A 0x70068 +#define _UNDERRUN_DBG2_B 0x71068 +#define UNDERRUN_DBG2 (pipe) _MMIO_PIPE(pipe, \ + _UNDERRUN_DBG2_A, \ + _UNDERRUN_DBG2_B) +#define UNDERRUN_FRAME_LINE_COUNTERS_FROZEN REG_BIT(31) +#define UNDERRUN_PIPE_FRAME_COUNT_MASK REG_GENMASK(30, 20) +#define UNDERRUN_LINE_COUNT_MASK REG_GENMASK(19, 0) +#define DPINVGTT _MMIO(VLV_DISPLAY_BASE + 0x7002c)/* VLV/CHV only */ #define DPINVGTT_EN_MASK_CHV REG_GENMASK(27, 16)#define DPINVGTT_EN_MASK_VLV REG_GENMASK(23, 16)
@@ -1416,6 +1435,7 @@#define GEN12_DCPR_STATUS_1 _MMIO(0x46440)#define XELPDP_PMDEMAND_INFLIGHT_STATUS REG_BIT(26) +#define XE3P_UNDERRUN_PKGC REG_BIT(21)#define FUSE_STRAP _MMIO(0x42014)#define ILK_INTERNAL_GRAPHICS_DISABLE REG_BIT(31)
drivers/gpu/drm/i915/display/intel_fbc_regs.h +2 -0
@@ -88,6 +88,8 @@#define DPFC_FENCE_YOFF _MMIO(0x3218)#define ILK_DPFC_FENCE_YOFF (fbc_id) _MMIO_PIPE((fbc_id), 0x43218, 0x43258)#define DPFC_CHICKEN _MMIO(0x3224) +#define FBC_DEBUG_STATUS (pipe) _MMIO_PIPE(pipe, 0x43220, 0x43260) +#define FBC_UNDERRUN_DECOMPRESSION REG_BIT(27)#define ILK_DPFC_CHICKEN (fbc_id) _MMIO_PIPE((fbc_id), 0x43224, 0x43264)#define DPFC_HT_MODIFY REG_BIT(31)/* pre-ivb */ #define DPFC_NUKE_ON_ANY_MODIFICATION REG_BIT(23)/* bdw+ */
drivers/gpu/drm/i915/display/intel_fifo_underrun.c +87 -0
111 lines not on this page · raw message
Signature · 1 line
2.51.0
Re: [PATCH v2 11/32] drm/i915/xe3p_lpd: Underrun debuggability and error codes/hints
Quoted 72 lines · Gustavo Sousa
From: Sai Teja Pottumuttu <[email protected]>
Starting with
Xe3p_LPD, we get two new registers and some bits in existing registers that expose hardware state information at the time of underrun notification that can be relevant to debugging.Add the necessary logic in the driver to print the available debug information when an underrun happens.
v2:
- Useseq_bufto generate planes string. (Jani)
- Move definition ofFBC_DEBUG_STATUStointel_fbc_regs.h. (Ville)
- Change logic for processingUNDERRUN_DBG1to use loops and move it to a separate function. (Gustavo)
- Always print underrun error message, even if there wouldn't be any debug info associated to the underrun. (Gustavo)Bspec: 69111, 69561, 74411, 74412
Cc Jani Nikula <[email protected]>Cc Ville Syrjälä <[email protected]>Signed-off-by Sai Teja Pottumuttu <[email protected]>Co-developed-by Gustavo Sousa <[email protected]>Signed-off-by Gustavo Sousa <[email protected]>--- drivers/gpu/drm/i915/display/intel_display_regs.h | 20 +++++ drivers/gpu/drm/i915/display/intel_fbc_regs.h | 2 + drivers/gpu/drm/i915/display/intel_fifo_underrun.c | 87 ++++++++++++++++++++++ 3 files changed, 109 insertions(+)drivers/gpu/drm/i915/display/intel_display_regs.h +20
-0@@ -882,6 +882,25 @@#define PIPE_MISC2_FLIP_INFO_PLANE_SEL_MASK REG_GENMASK(2, 0)/* tgl+ */ #define PIPE_MISC2_FLIP_INFO_PLANE_SEL (plane_id) REG_FIELD_PREP(PIPE_MISC2_FLIP_INFO_PLANE_SEL_MASK, (plane_id)) +#define _UNDERRUN_DBG1_A 0x70064 +#define _UNDERRUN_DBG1_B 0x71064 +#define UNDERRUN_DBG1 (pipe) _MMIO_PIPE(pipe, \ + _UNDERRUN_DBG1_A, \ + _UNDERRUN_DBG1_B) +#define UNDERRUN_DBUF_BLOCK_NOT_VALID_MASK REG_GENMASK(29, 24) +#define UNDERRUN_DDB_EMPTY_MASK REG_GENMASK(21, 16) +#define UNDERRUN_DBUF_NOT_FILLED_MASK REG_GENMASK(13, 8) +#define UNDERRUN_BELOW_WM0_MASK REG_GENMASK(5, 0) + +#define _UNDERRUN_DBG2_A 0x70068 +#define _UNDERRUN_DBG2_B 0x71068 +#define UNDERRUN_DBG2 (pipe) _MMIO_PIPE(pipe, \ + _UNDERRUN_DBG2_A, \ + _UNDERRUN_DBG2_B) +#define UNDERRUN_FRAME_LINE_COUNTERS_FROZEN REG_BIT(31) +#define UNDERRUN_PIPE_FRAME_COUNT_MASK REG_GENMASK(30, 20) +#define UNDERRUN_LINE_COUNT_MASK REG_GENMASK(19, 0) +#define DPINVGTT _MMIO(VLV_DISPLAY_BASE + 0x7002c)/* VLV/CHV only */ #define DPINVGTT_EN_MASK_CHV REG_GENMASK(27, 16)#define DPINVGTT_EN_MASK_VLV REG_GENMASK(23, 16)@@ -1416,6 +1435,7 @@#define GEN12_DCPR_STATUS_1 _MMIO(0x46440)#define XELPDP_PMDEMAND_INFLIGHT_STATUS REG_BIT(26) +#define XE3P_UNDERRUN_PKGC REG_BIT(21)#define FUSE_STRAP _MMIO(0x42014)#define ILK_INTERNAL_GRAPHICS_DISABLE REG_BIT(31)drivers/gpu/drm/i915/display/intel_fbc_regs.h +0
-0
drivers/gpu/drm/i915/display/intel_fbc_regs.h line 91
Quoted 4 lines
drivers/gpu/drm/i915/display/intel_fbc_regs.h +1
-0@@ -88,6 +88,8 @@#define DPFC_FENCE_YOFF _MMIO(0x3218)#define ILK_DPFC_FENCE_YOFF (fbc_id) _MMIO_PIPE((fbc_id), 0x43218, 0x43258)#define DPFC_CHICKEN _MMIO(0x3224) +#define FBC_DEBUG_STATUS (pipe) _MMIO_PIPE(pipe, 0x43220, 0x43260)
Is 'pipe' correct here? Most of the other FBC registers are parameterized by FBC instance rather than pipe.
Quoted 48 lines
drivers/gpu/drm/i915/display/intel_fbc_regs.h +1
-0+#define FBC_UNDERRUN_DECOMPRESSION REG_BIT(27)#define ILK_DPFC_CHICKEN (fbc_id) _MMIO_PIPE((fbc_id), 0x43224, 0x43264)#define DPFC_HT_MODIFY REG_BIT(31)/* pre-ivb */ #define DPFC_NUKE_ON_ANY_MODIFICATION REG_BIT(23)/* bdw+ */ drivers/gpu/drm/i915/display/intel_fifo_underrun.c +22
-0@@ -25,6 +25,8 @@* */ +#include <linux/seq_buf.h> +#include <drm/drm_print.h> #include "i915_reg.h" @@ -34,6 +36,7 @@#include "intel_display_trace.h" #include "intel_display_types.h" #include "intel_fbc.h" +#include "intel_fbc_regs.h" #include "intel_fifo_underrun.h" #include "intel_pch_display.h" @@ -352,6 +355,87 @@ bool intel_set_pch_fifo_underrun_reporting(struct intel_display *display,return old; } +#define UNDERRUN_DBG1_NUM_PLANES 6 + +static void process_underrun_dbg1 (struct intel_display *display, +enum pipe pipe) +{ +struct { +u32 mask; +const char *info; + } info_masks[] = { + {UNDERRUN_DBUF_BLOCK_NOT_VALID_MASK ,"DBUF block not valid" }, + {UNDERRUN_DDB_EMPTY_MASK ,"DDB empty" }, + {UNDERRUN_DBUF_NOT_FILLED_MASK ,"DBUF not completely filled" }, + {UNDERRUN_BELOW_WM0_MASK ,"DBUF below WM0" }, + }; +DECLARE_SEQ_BUF (planes_desc,32 ); +u32 val; + + val =intel_de_read (display,UNDERRUN_DBG1 (pipe)); +intel_de_write (display,UNDERRUN_DBG1 (pipe), val);
drivers/gpu/drm/i915/display/intel_fifo_underrun.c bool intel_set_pch_fifo_underrun_reporting(struct intel_display *display, · line 386
Quoted 10 lines
drivers/gpu/drm/i915/display/intel_fifo_underrun.c +10
-0+ +for (int i =0 ; i <ARRAY_SIZE (info_masks); i++) { +u32 plane_bits; + + plane_bits = val & info_masks[i].mask; + +if (!plane_bits) +continue ; + + plane_bits >>=ffs (info_masks[i].mask) -1 ;
Nitpick: It seems like we're just open-coding REG_FIELD_GET here. Any reason not to simplify down to something like this?
u32 plane_bits = REG_FIELD_GET(info_masks[i].mask, val);
if (!plane_bits)
continue;Quoted 33 lines
drivers/gpu/drm/i915/display/intel_fifo_underrun.c +33
-0+ +seq_buf_clear (&planes_desc); + +for (int j =0 ; j <UNDERRUN_DBG1_NUM_PLANES ; j++) { +if (!(plane_bits ®_BIT (j))) +continue ; + +if (j ==0 ) +seq_buf_puts (&planes_desc,"[C]" ); +else +seq_buf_printf (&planes_desc,"[%d]" , j); + } + +drm_err (display->drm, +"Pipe %c FIFO underrun info: %s on planes: %s\n" , +pipe_name (pipe), info_masks[i].info,seq_buf_str (&planes_desc)); + +drm_WARN_ON (display->drm,seq_buf_has_overflowed (&planes_desc)); + } +} + +static void xe3p_lpd_log_underrun (struct intel_display *display, +enum pipe pipe) +{ +u32 val; + +process_underrun_dbg1 (display, pipe); + + val =intel_de_read (display,UNDERRUN_DBG2 (pipe)); +if (val &UNDERRUN_FRAME_LINE_COUNTERS_FROZEN ) { +intel_de_write (display,UNDERRUN_DBG2 (pipe),UNDERRUN_FRAME_LINE_COUNTERS_FROZEN ); + drm_err(display->drm, "Pipe %c FIFO underrun info: Frame count: %u, Line count: %u\n", + pipe_name(pipe),
drivers/gpu/drm/i915/display/intel_fifo_underrun.c bool intel_set_pch_fifo_underrun_reporting(struct intel_display *display, · line 429
Quoted 10 lines
drivers/gpu/drm/i915/display/intel_fifo_underrun.c +10
-0+REG_FIELD_GET (UNDERRUN_PIPE_FRAME_COUNT_MASK , val), + REG_FIELD_GET(UNDERRUN_LINE_COUNT_MASK, val)); + } + + val =intel_de_read (display,FBC_DEBUG_STATUS (pipe)); +if (val &FBC_UNDERRUN_DECOMPRESSION ) { +intel_de_write (display,FBC_DEBUG_STATUS (pipe),FBC_UNDERRUN_DECOMPRESSION ); +drm_err (display->drm,"Pipe %c FIFO underrun info: FBC decompression\n" , +pipe_name (pipe)); + }
As noted above, I'm not sure if 'pipe' is technically correct for this register. I think it always winds up with a 1:1 relationship on current platforms, but would it make more sense to just move this check and print into intel_fbc_handle_fifo_underrun_irq() where we're already handling the FBC stuff on a per-FBC unit basis?
Matt
Quoted 26 lines
drivers/gpu/drm/i915/display/intel_fifo_underrun.c +12
-0+ + val =intel_de_read (display,GEN12_DCPR_STATUS_1 ); +if (val &XE3P_UNDERRUN_PKGC ) { +intel_de_write (display,GEN12_DCPR_STATUS_1 ,XE3P_UNDERRUN_PKGC ); +drm_err (display->drm,"Pipe %c FIFO underrun info: Pkgc blocking memory\n" , +pipe_name (pipe)); + } +} +/** * intel_cpu_fifo_underrun_irq_handler - handle CPU fifo underrun interrupt * @display: display device instance @@ -379,6 +463,9 @@ void intel_cpu_fifo_underrun_irq_handler(struct intel_display *display,trace_intel_cpu_fifo_underrun (display, pipe);drm_err (display->drm,"CPU pipe %c FIFO underrun\n" ,pipe_name (pipe)); + +if (DISPLAY_VER (display) >=35 ) +xe3p_lpd_log_underrun (display, pipe); }intel_fbc_handle_fifo_underrun_irq (display);Signature · 2 lines
-- 2.51.0
Signature · 4 lines
Matt Roper Graphics Software Engineer Linux GPU Platform Enablement Intel Corporation
Re: [PATCH v2 11/32] drm/i915/xe3p_lpd: Underrun debuggability and error codes/hints
Quoting Matt Roper (2025-10-29 17:54:39-03:00)
Quoted 66 lines · Gustavo Sousa
Quoted 65 lines
From: Sai Teja Pottumuttu <[email protected]>
Starting with
Xe3p_LPD, we get two new registers and some bits in existing registers that expose hardware state information at the time of underrun notification that can be relevant to debugging.Add the necessary logic in the driver to print the available debug information when an underrun happens.
v2:
- Useseq_bufto generate planes string. (Jani)
- Move definition ofFBC_DEBUG_STATUStointel_fbc_regs.h. (Ville)
- Change logic for processingUNDERRUN_DBG1to use loops and move it to a separate function. (Gustavo)
- Always print underrun error message, even if there wouldn't be any debug info associated to the underrun. (Gustavo)Bspec: 69111, 69561, 74411, 74412
Cc Jani Nikula <[email protected]>Cc Ville Syrjälä <[email protected]>Signed-off-by Sai Teja Pottumuttu <[email protected]>Co-developed-by Gustavo Sousa <[email protected]>Signed-off-by Gustavo Sousa <[email protected]>--- drivers/gpu/drm/i915/display/intel_display_regs.h | 20 +++++ drivers/gpu/drm/i915/display/intel_fbc_regs.h | 2 + drivers/gpu/drm/i915/display/intel_fifo_underrun.c | 87 ++++++++++++++++++++++ 3 files changed, 109 insertions(+)drivers/gpu/drm/i915/display/intel_display_regs.h +20
-0@@ -882,6 +882,25 @@#define PIPE_MISC2_FLIP_INFO_PLANE_SEL_MASK REG_GENMASK(2, 0)/* tgl+ */ #define PIPE_MISC2_FLIP_INFO_PLANE_SEL (plane_id) REG_FIELD_PREP(PIPE_MISC2_FLIP_INFO_PLANE_SEL_MASK, (plane_id)) +#define _UNDERRUN_DBG1_A 0x70064 +#define _UNDERRUN_DBG1_B 0x71064 +#define UNDERRUN_DBG1 (pipe) _MMIO_PIPE(pipe, \ + _UNDERRUN_DBG1_A, \ + _UNDERRUN_DBG1_B) +#define UNDERRUN_DBUF_BLOCK_NOT_VALID_MASK REG_GENMASK(29, 24) +#define UNDERRUN_DDB_EMPTY_MASK REG_GENMASK(21, 16) +#define UNDERRUN_DBUF_NOT_FILLED_MASK REG_GENMASK(13, 8) +#define UNDERRUN_BELOW_WM0_MASK REG_GENMASK(5, 0) + +#define _UNDERRUN_DBG2_A 0x70068 +#define _UNDERRUN_DBG2_B 0x71068 +#define UNDERRUN_DBG2 (pipe) _MMIO_PIPE(pipe, \ + _UNDERRUN_DBG2_A, \ + _UNDERRUN_DBG2_B) +#define UNDERRUN_FRAME_LINE_COUNTERS_FROZEN REG_BIT(31) +#define UNDERRUN_PIPE_FRAME_COUNT_MASK REG_GENMASK(30, 20) +#define UNDERRUN_LINE_COUNT_MASK REG_GENMASK(19, 0) +#define DPINVGTT _MMIO(VLV_DISPLAY_BASE + 0x7002c)/* VLV/CHV only */ #define DPINVGTT_EN_MASK_CHV REG_GENMASK(27, 16)#define DPINVGTT_EN_MASK_VLV REG_GENMASK(23, 16)@@ -1416,6 +1435,7 @@#define GEN12_DCPR_STATUS_1 _MMIO(0x46440)#define XELPDP_PMDEMAND_INFLIGHT_STATUS REG_BIT(26) +#define XE3P_UNDERRUN_PKGC REG_BIT(21)
Quoted 14 lines
drivers/gpu/drm/i915/display/intel_fbc_regs.h line 91
Quoted 11 lines
drivers/gpu/drm/i915/display/intel_display_regs.h +0
-0#define FUSE_STRAP _MMIO(0x42014)#define ILK_INTERNAL_GRAPHICS_DISABLE REG_BIT(31)drivers/gpu/drm/i915/display/intel_fbc_regs.h +1
-0@@ -88,6 +88,8 @@#define DPFC_FENCE_YOFF _MMIO(0x3218)#define ILK_DPFC_FENCE_YOFF (fbc_id) _MMIO_PIPE((fbc_id), 0x43218, 0x43258)#define DPFC_CHICKEN _MMIO(0x3224) +#define FBC_DEBUG_STATUS (pipe) _MMIO_PIPE(pipe, 0x43220, 0x43260)Is 'pipe' correct here? Most of the other FBC registers are parameterized by FBC instance rather than pipe.
Yeah, I just blindly copy/pasted the definition without realizing that the rest of the file uses fbc_id. I'll change it to use fbc_id as well.
Quoted 63 lines
Quoted 49 lines
drivers/gpu/drm/i915/display/intel_fbc_regs.h +1
-0+#define FBC_UNDERRUN_DECOMPRESSION REG_BIT(27)#define ILK_DPFC_CHICKEN (fbc_id) _MMIO_PIPE((fbc_id), 0x43224, 0x43264)#define DPFC_HT_MODIFY REG_BIT(31)/* pre-ivb */ #define DPFC_NUKE_ON_ANY_MODIFICATION REG_BIT(23)/* bdw+ */ drivers/gpu/drm/i915/display/intel_fifo_underrun.c +22
-0@@ -25,6 +25,8 @@* */ +#include <linux/seq_buf.h> +#include <drm/drm_print.h> #include "i915_reg.h" @@ -34,6 +36,7 @@#include "intel_display_trace.h" #include "intel_display_types.h" #include "intel_fbc.h" +#include "intel_fbc_regs.h" #include "intel_fifo_underrun.h" #include "intel_pch_display.h" @@ -352,6 +355,87 @@ bool intel_set_pch_fifo_underrun_reporting(struct intel_display *display,return old; } +#define UNDERRUN_DBG1_NUM_PLANES 6 + +static void process_underrun_dbg1 (struct intel_display *display, +enum pipe pipe) +{ +struct { +u32 mask; +const char *info; + } info_masks[] = { + {UNDERRUN_DBUF_BLOCK_NOT_VALID_MASK ,"DBUF block not valid" }, + {UNDERRUN_DDB_EMPTY_MASK ,"DDB empty" }, + {UNDERRUN_DBUF_NOT_FILLED_MASK ,"DBUF not completely filled" }, + {UNDERRUN_BELOW_WM0_MASK ,"DBUF below WM0" }, + }; +DECLARE_SEQ_BUF (planes_desc,32 ); +u32 val; + + val =intel_de_read (display,UNDERRUN_DBG1 (pipe)); +intel_de_write (display,UNDERRUN_DBG1 (pipe), val);drivers/gpu/drm/i915/display/intel_fifo_underrun.c bool intel_set_pch_fifo_underrun_reporting(struct intel_display *display, · line 386
Quoted 10 lines
drivers/gpu/drm/i915/display/intel_fifo_underrun.c +10
-0+ +for (int i =0 ; i <ARRAY_SIZE (info_masks); i++) { +u32 plane_bits; + + plane_bits = val & info_masks[i].mask; + +if (!plane_bits) +continue ; + + plane_bits >>=ffs (info_masks[i].mask) -1 ;Nitpick: It seems like we're just open-coding
REG_FIELD_GEThere. Any reason not to simplify down to something like this?
Quoted 4 lines
u32 plane_bits = REG_FIELD_GET(info_masks[i].mask, val);
if (!plane_bits)
continue;We can't use REG_FIELD_GET() because the mask parameter must be a constant expression. That's why I went with open-coded version.
We could change the current patch to use REG_FIELD_GET() with something like below. What do you think?
|diff --git a/drivers/gpu/drm/i915/display/intel_fifo_underrun.c b/drivers/gpu/drm/i915/display/intel_fifo_underrun.c
|index 43cf141a59ae..34faedb9799c 100644
|--- a/drivers/gpu/drm/i915/display/intel_fifo_underrun.c
|+++ b/drivers/gpu/drm/i915/display/intel_fifo_underrun.c
|@@ -360,35 +360,28 @@ bool intel_set_pch_fifo_underrun_reporting(struct intel_display *display,
| static void process_underrun_dbg1(struct intel_display *display,
| enum pipe pipe)
| {
|+ u32 val = intel_de_read(display, UNDERRUN_DBG1(pipe));
| struct {
|- u32 mask;
|+ u32 plane_mask;
| const char *info;
|- } info_masks[] = {
|- { UNDERRUN_DBUF_BLOCK_NOT_VALID_MASK, "DBUF block not valid" },
|- { UNDERRUN_DDB_EMPTY_MASK, "DDB empty" },
|- { UNDERRUN_DBUF_NOT_FILLED_MASK, "DBUF not completely filled" },
|- { UNDERRUN_BELOW_WM0_MASK, "DBUF below WM0" },
|+ } masks[] = {
|+ { REG_FIELD_GET(UNDERRUN_DBUF_BLOCK_NOT_VALID_MASK, val), "DBUF block not valid" },
|+ { REG_FIELD_GET(UNDERRUN_DDB_EMPTY_MASK, val), "DDB empty" },
|+ { REG_FIELD_GET(UNDERRUN_DBUF_NOT_FILLED_MASK, val), "DBUF not completely filled" },
|+ { REG_FIELD_GET(UNDERRUN_BELOW_WM0_MASK, val), "DBUF below WM0" },
| };
| DECLARE_SEQ_BUF(planes_desc, 32);
|- u32 val;
|
|- val = intel_de_read(display, UNDERRUN_DBG1(pipe));
| intel_de_write(display, UNDERRUN_DBG1(pipe), val);
|
|- for (int i = 0; i < ARRAY_SIZE(info_masks); i++) {
|- u32 plane_bits;
|-
|- plane_bits = val & info_masks[i].mask;
|-
|- if (!plane_bits)
|+ for (int i = 0; i < ARRAY_SIZE(masks); i++) {
|+ if (!masks[i].plane_mask)
| continue;
|
|- plane_bits >>= ffs(info_masks[i].mask) - 1;
|-
| seq_buf_clear(&planes_desc);
|
| for (int j = 0; j < UNDERRUN_DBG1_NUM_PLANES; j++) {
|- if (!(plane_bits & REG_BIT(j)))
|+ if (!(masks[i].plane_mask & REG_BIT(j)))
| continue;
|
| if (j == 0)
|@@ -399,7 +392,7 @@ static void process_underrun_dbg1(struct intel_display *display,
|
| drm_err(display->drm,
| "Pipe %c FIFO underrun info: %s on planes: %s\n",
|- pipe_name(pipe), info_masks[i].info, seq_buf_str(&planes_desc));
|+ pipe_name(pipe), masks[i].info, seq_buf_str(&planes_desc));
|
| drm_WARN_ON(display->drm, seq_buf_has_overflowed(&planes_desc));
| }Quoted 42 lines
Quoted 42 lines
drivers/gpu/drm/i915/display/intel_fifo_underrun.c +41
-0+ +seq_buf_clear (&planes_desc); + +for (int j =0 ; j <UNDERRUN_DBG1_NUM_PLANES ; j++) { +if (!(plane_bits ®_BIT (j))) +continue ; + +if (j ==0 ) +seq_buf_puts (&planes_desc,"[C]" ); +else +seq_buf_printf (&planes_desc,"[%d]" , j); + } + +drm_err (display->drm, +"Pipe %c FIFO underrun info: %s on planes: %s\n" , +pipe_name (pipe), info_masks[i].info,seq_buf_str (&planes_desc)); + +drm_WARN_ON (display->drm,seq_buf_has_overflowed (&planes_desc)); + } +} + +static void xe3p_lpd_log_underrun (struct intel_display *display, +enum pipe pipe) +{ +u32 val; + +process_underrun_dbg1 (display, pipe); + + val =intel_de_read (display,UNDERRUN_DBG2 (pipe)); +if (val &UNDERRUN_FRAME_LINE_COUNTERS_FROZEN ) { +intel_de_write (display,UNDERRUN_DBG2 (pipe),UNDERRUN_FRAME_LINE_COUNTERS_FROZEN ); +drm_err (display->drm,"Pipe %c FIFO underrun info: Frame count: %u, Line count: %u\n" , +pipe_name (pipe), +REG_FIELD_GET (UNDERRUN_PIPE_FRAME_COUNT_MASK , val), +REG_FIELD_GET (UNDERRUN_LINE_COUNT_MASK , val)); + } + + val =intel_de_read (display,FBC_DEBUG_STATUS (pipe)); +if (val &FBC_UNDERRUN_DECOMPRESSION ) { +intel_de_write (display,FBC_DEBUG_STATUS (pipe),FBC_UNDERRUN_DECOMPRESSION ); + drm_err(display->drm, "Pipe %c FIFO underrun info: FBC decompression\n",
Quoted 8 lines
drivers/gpu/drm/i915/display/intel_fifo_underrun.c bool intel_set_pch_fifo_underrun_reporting(struct intel_display *display, · line 429
Quoted 2 lines
drivers/gpu/drm/i915/display/intel_fifo_underrun.c +2
-0+ pipe_name(pipe)); + }As noted above, I'm not sure if 'pipe' is technically correct for this register. I think it always winds up with a 1:1 relationship on current platforms, but would it make more sense to just move this check and print into
intel_fbc_handle_fifo_underrun_irq()where we're already handling the FBC stuff on a per-FBC unit basis?
Yeah. We probably want to check if there is a valid FBC instance respective to this pipe and then read the register.
I see complications with moving this tointel_fbc_handle_fifo_underrun_irq():
1) The function intel_fbc_handle_fifo_underrun_irq() is more about disabling the FBC on an underrun. I think reporting that the FBC was decompressing when the there was an underrun makes more sense to be grouped together with the other info related to FIFO underruns. It could even be useful if, due to some hw/sw bug, FBC is still doing something after we disabled it (or so we thought) due to a previous underrun.
2) Logging underrun debug info is currently guarded by intel_set_cpu_fifo_underrun_reporting(). So, we would need to complicate the implementation a bit to ensure that intel_fbc_handle_fifo_underrun_irq() would only report when reporting was enabled.
So, I was thinking about defining a new function intel_fbc_fifo_underrun_log_info() and calling it from xe3p_lpd_log_underrun(). What do you think?
--
Gustavo Sousa
Quoted 36 lines
Matt
Quoted 26 lines
drivers/gpu/drm/i915/display/intel_fifo_underrun.c +12
-0+ + val =intel_de_read (display,GEN12_DCPR_STATUS_1 ); +if (val &XE3P_UNDERRUN_PKGC ) { +intel_de_write (display,GEN12_DCPR_STATUS_1 ,XE3P_UNDERRUN_PKGC ); +drm_err (display->drm,"Pipe %c FIFO underrun info: Pkgc blocking memory\n" , +pipe_name (pipe)); + } +} +/** * intel_cpu_fifo_underrun_irq_handler - handle CPU fifo underrun interrupt * @display: display device instance @@ -379,6 +463,9 @@ void intel_cpu_fifo_underrun_irq_handler(struct intel_display *display,trace_intel_cpu_fifo_underrun (display, pipe);drm_err (display->drm,"CPU pipe %c FIFO underrun\n" ,pipe_name (pipe)); + +if (DISPLAY_VER (display) >=35 ) +xe3p_lpd_log_underrun (display, pipe); }intel_fbc_handle_fifo_underrun_irq (display);Signature · 2 lines
-- 2.51.0Signature · 4 lines
Matt Roper Graphics Software Engineer Linux GPU Platform Enablement Intel Corporation
Re: [PATCH v2 11/32] drm/i915/xe3p_lpd: Underrun debuggability and error codes/hints
Quoted 148 lines · Gustavo Sousa
Quoting Matt Roper (2025-10-29 17:54:39-03:00)
Quoted 66 lines · Gustavo Sousa
Quoted 65 lines
From: Sai Teja Pottumuttu <[email protected]>
Starting with
Xe3p_LPD, we get two new registers and some bits in existing registers that expose hardware state information at the time of underrun notification that can be relevant to debugging.Add the necessary logic in the driver to print the available debug information when an underrun happens.
v2:
- Useseq_bufto generate planes string. (Jani)
- Move definition ofFBC_DEBUG_STATUStointel_fbc_regs.h. (Ville)
- Change logic for processingUNDERRUN_DBG1to use loops and move it to a separate function. (Gustavo)
- Always print underrun error message, even if there wouldn't be any debug info associated to the underrun. (Gustavo)Bspec: 69111, 69561, 74411, 74412
Cc Jani Nikula <[email protected]>Cc Ville Syrjälä <[email protected]>Signed-off-by Sai Teja Pottumuttu <[email protected]>Co-developed-by Gustavo Sousa <[email protected]>Signed-off-by Gustavo Sousa <[email protected]>--- drivers/gpu/drm/i915/display/intel_display_regs.h | 20 +++++ drivers/gpu/drm/i915/display/intel_fbc_regs.h | 2 + drivers/gpu/drm/i915/display/intel_fifo_underrun.c | 87 ++++++++++++++++++++++ 3 files changed, 109 insertions(+)drivers/gpu/drm/i915/display/intel_display_regs.h +20
-0@@ -882,6 +882,25 @@#define PIPE_MISC2_FLIP_INFO_PLANE_SEL_MASK REG_GENMASK(2, 0)/* tgl+ */ #define PIPE_MISC2_FLIP_INFO_PLANE_SEL (plane_id) REG_FIELD_PREP(PIPE_MISC2_FLIP_INFO_PLANE_SEL_MASK, (plane_id)) +#define _UNDERRUN_DBG1_A 0x70064 +#define _UNDERRUN_DBG1_B 0x71064 +#define UNDERRUN_DBG1 (pipe) _MMIO_PIPE(pipe, \ + _UNDERRUN_DBG1_A, \ + _UNDERRUN_DBG1_B) +#define UNDERRUN_DBUF_BLOCK_NOT_VALID_MASK REG_GENMASK(29, 24) +#define UNDERRUN_DDB_EMPTY_MASK REG_GENMASK(21, 16) +#define UNDERRUN_DBUF_NOT_FILLED_MASK REG_GENMASK(13, 8) +#define UNDERRUN_BELOW_WM0_MASK REG_GENMASK(5, 0) + +#define _UNDERRUN_DBG2_A 0x70068 +#define _UNDERRUN_DBG2_B 0x71068 +#define UNDERRUN_DBG2 (pipe) _MMIO_PIPE(pipe, \ + _UNDERRUN_DBG2_A, \ + _UNDERRUN_DBG2_B) +#define UNDERRUN_FRAME_LINE_COUNTERS_FROZEN REG_BIT(31) +#define UNDERRUN_PIPE_FRAME_COUNT_MASK REG_GENMASK(30, 20) +#define UNDERRUN_LINE_COUNT_MASK REG_GENMASK(19, 0) +#define DPINVGTT _MMIO(VLV_DISPLAY_BASE + 0x7002c)/* VLV/CHV only */ #define DPINVGTT_EN_MASK_CHV REG_GENMASK(27, 16)#define DPINVGTT_EN_MASK_VLV REG_GENMASK(23, 16)@@ -1416,6 +1435,7 @@#define GEN12_DCPR_STATUS_1 _MMIO(0x46440)#define XELPDP_PMDEMAND_INFLIGHT_STATUS REG_BIT(26) +#define XE3P_UNDERRUN_PKGC REG_BIT(21)Quoted 14 lines
drivers/gpu/drm/i915/display/intel_fbc_regs.h line 91
Quoted 11 lines
drivers/gpu/drm/i915/display/intel_display_regs.h +0
-0#define FUSE_STRAP _MMIO(0x42014)#define ILK_INTERNAL_GRAPHICS_DISABLE REG_BIT(31)drivers/gpu/drm/i915/display/intel_fbc_regs.h +1
-0@@ -88,6 +88,8 @@#define DPFC_FENCE_YOFF _MMIO(0x3218)#define ILK_DPFC_FENCE_YOFF (fbc_id) _MMIO_PIPE((fbc_id), 0x43218, 0x43258)#define DPFC_CHICKEN _MMIO(0x3224) +#define FBC_DEBUG_STATUS (pipe) _MMIO_PIPE(pipe, 0x43220, 0x43260)Is 'pipe' correct here? Most of the other FBC registers are parameterized by FBC instance rather than pipe.
Yeah, I just blindly copy/pasted the definition without realizing that the rest of the file uses
fbc_id. I'll change it to usefbc_idas well.Quoted 63 lines
Quoted 49 lines
drivers/gpu/drm/i915/display/intel_fbc_regs.h +1
-0+#define FBC_UNDERRUN_DECOMPRESSION REG_BIT(27)#define ILK_DPFC_CHICKEN (fbc_id) _MMIO_PIPE((fbc_id), 0x43224, 0x43264)#define DPFC_HT_MODIFY REG_BIT(31)/* pre-ivb */ #define DPFC_NUKE_ON_ANY_MODIFICATION REG_BIT(23)/* bdw+ */ drivers/gpu/drm/i915/display/intel_fifo_underrun.c +22
-0@@ -25,6 +25,8 @@* */ +#include <linux/seq_buf.h> +#include <drm/drm_print.h> #include "i915_reg.h" @@ -34,6 +36,7 @@#include "intel_display_trace.h" #include "intel_display_types.h" #include "intel_fbc.h" +#include "intel_fbc_regs.h" #include "intel_fifo_underrun.h" #include "intel_pch_display.h" @@ -352,6 +355,87 @@ bool intel_set_pch_fifo_underrun_reporting(struct intel_display *display,return old; } +#define UNDERRUN_DBG1_NUM_PLANES 6 + +static void process_underrun_dbg1 (struct intel_display *display, +enum pipe pipe) +{ +struct { +u32 mask; +const char *info; + } info_masks[] = { + {UNDERRUN_DBUF_BLOCK_NOT_VALID_MASK ,"DBUF block not valid" }, + {UNDERRUN_DDB_EMPTY_MASK ,"DDB empty" }, + {UNDERRUN_DBUF_NOT_FILLED_MASK ,"DBUF not completely filled" }, + {UNDERRUN_BELOW_WM0_MASK ,"DBUF below WM0" }, + }; +DECLARE_SEQ_BUF (planes_desc,32 ); +u32 val; + + val =intel_de_read (display,UNDERRUN_DBG1 (pipe)); +intel_de_write (display,UNDERRUN_DBG1 (pipe), val);drivers/gpu/drm/i915/display/intel_fifo_underrun.c bool intel_set_pch_fifo_underrun_reporting(struct intel_display *display, · line 386
Quoted 10 lines
drivers/gpu/drm/i915/display/intel_fifo_underrun.c +10
-0+ +for (int i =0 ; i <ARRAY_SIZE (info_masks); i++) { +u32 plane_bits; + + plane_bits = val & info_masks[i].mask; + +if (!plane_bits) +continue ; + + plane_bits >>=ffs (info_masks[i].mask) -1 ;Nitpick: It seems like we're just open-coding
REG_FIELD_GEThere. Any reason not to simplify down to something like this?
Quoted 7 lines
Quoted 4 lines
u32 plane_bits = REG_FIELD_GET(info_masks[i].mask, val); if (!plane_bits) continue;We can't use
REG_FIELD_GET()because the mask parameter must be a constant expression. That's why I went with open-coded version.
Oh yeah, I always forget about that restriction. I'm fine with keeping the open-coded version in that case, although you may want to move the plane_bits assignment up onto the declaration line. And maybe use __ffs() instead of ffs() to avoid the need to substract 1.
Quoted 136 lines
We could change the current patch to use
REG_FIELD_GET()with something like below. What do you think?|diff --git a/drivers/gpu/drm/i915/display/intel_fifo_underrun.c b/drivers/gpu/drm/i915/display/intel_fifo_underrun.c |index 43cf141a59ae..34faedb9799c 100644 |--- a/drivers/gpu/drm/i915/display/intel_fifo_underrun.c |+++ b/drivers/gpu/drm/i915/display/intel_fifo_underrun.c |@@ -360,35 +360,28 @@ bool intel_set_pch_fifo_underrun_reporting(struct intel_display *display, | static void process_underrun_dbg1(struct intel_display *display, | enum pipe pipe) | { |+ u32 val = intel_de_read(display, UNDERRUN_DBG1(pipe)); | struct { |- u32 mask; |+ u32 plane_mask; | const char *info; |- } info_masks[] = { |- { UNDERRUN_DBUF_BLOCK_NOT_VALID_MASK, "DBUF block not valid" }, |- { UNDERRUN_DDB_EMPTY_MASK, "DDB empty" }, |- { UNDERRUN_DBUF_NOT_FILLED_MASK, "DBUF not completely filled" }, |- { UNDERRUN_BELOW_WM0_MASK, "DBUF below WM0" }, |+ } masks[] = { |+ { REG_FIELD_GET(UNDERRUN_DBUF_BLOCK_NOT_VALID_MASK, val), "DBUF block not valid" }, |+ { REG_FIELD_GET(UNDERRUN_DDB_EMPTY_MASK, val), "DDB empty" }, |+ { REG_FIELD_GET(UNDERRUN_DBUF_NOT_FILLED_MASK, val), "DBUF not completely filled" }, |+ { REG_FIELD_GET(UNDERRUN_BELOW_WM0_MASK, val), "DBUF below WM0" }, | }; | DECLARE_SEQ_BUF(planes_desc, 32); |- u32 val; | |- val = intel_de_read(display, UNDERRUN_DBG1(pipe)); | intel_de_write(display, UNDERRUN_DBG1(pipe), val); | |- for (int i = 0; i < ARRAY_SIZE(info_masks); i++) { |- u32 plane_bits; |- |- plane_bits = val & info_masks[i].mask; |- |- if (!plane_bits) |+ for (int i = 0; i < ARRAY_SIZE(masks); i++) { |+ if (!masks[i].plane_mask) | continue; | |- plane_bits >>= ffs(info_masks[i].mask) - 1; |- | seq_buf_clear(&planes_desc); | | for (int j = 0; j < UNDERRUN_DBG1_NUM_PLANES; j++) { |- if (!(plane_bits & REG_BIT(j))) |+ if (!(masks[i].plane_mask & REG_BIT(j))) | continue; | | if (j == 0) |@@ -399,7 +392,7 @@ static void process_underrun_dbg1(struct intel_display *display, | | drm_err(display->drm, | "Pipe %c FIFO underrun info: %s on planes: %s\n", |- pipe_name(pipe), info_masks[i].info, seq_buf_str(&planes_desc)); |+ pipe_name(pipe), masks[i].info, seq_buf_str(&planes_desc)); | | drm_WARN_ON(display->drm, seq_buf_has_overflowed(&planes_desc)); | }Quoted 42 lines
Quoted 42 lines
drivers/gpu/drm/i915/display/intel_fifo_underrun.c +41
-0+ +seq_buf_clear (&planes_desc); + +for (int j =0 ; j <UNDERRUN_DBG1_NUM_PLANES ; j++) { +if (!(plane_bits ®_BIT (j))) +continue ; + +if (j ==0 ) +seq_buf_puts (&planes_desc,"[C]" ); +else +seq_buf_printf (&planes_desc,"[%d]" , j); + } + +drm_err (display->drm, +"Pipe %c FIFO underrun info: %s on planes: %s\n" , +pipe_name (pipe), info_masks[i].info,seq_buf_str (&planes_desc)); + +drm_WARN_ON (display->drm,seq_buf_has_overflowed (&planes_desc)); + } +} + +static void xe3p_lpd_log_underrun (struct intel_display *display, +enum pipe pipe) +{ +u32 val; + +process_underrun_dbg1 (display, pipe); + + val =intel_de_read (display,UNDERRUN_DBG2 (pipe)); +if (val &UNDERRUN_FRAME_LINE_COUNTERS_FROZEN ) { +intel_de_write (display,UNDERRUN_DBG2 (pipe),UNDERRUN_FRAME_LINE_COUNTERS_FROZEN ); +drm_err (display->drm,"Pipe %c FIFO underrun info: Frame count: %u, Line count: %u\n" , +pipe_name (pipe), +REG_FIELD_GET (UNDERRUN_PIPE_FRAME_COUNT_MASK , val), +REG_FIELD_GET (UNDERRUN_LINE_COUNT_MASK , val)); + } + + val =intel_de_read (display,FBC_DEBUG_STATUS (pipe)); +if (val &FBC_UNDERRUN_DECOMPRESSION ) { +intel_de_write (display,FBC_DEBUG_STATUS (pipe),FBC_UNDERRUN_DECOMPRESSION ); + drm_err(display->drm, "Pipe %c FIFO underrun info: FBC decompression\n",Quoted 8 lines
drivers/gpu/drm/i915/display/intel_fifo_underrun.c bool intel_set_pch_fifo_underrun_reporting(struct intel_display *display, · line 429
Quoted 2 lines
drivers/gpu/drm/i915/display/intel_fifo_underrun.c +2
-0+ pipe_name(pipe)); + }As noted above, I'm not sure if 'pipe' is technically correct for this register. I think it always winds up with a 1:1 relationship on current platforms, but would it make more sense to just move this check and print into
intel_fbc_handle_fifo_underrun_irq()where we're already handling the FBC stuff on a per-FBC unit basis?Yeah. We probably want to check if there is a valid FBC instance respective to this pipe and then read the register.
I see complications with moving this to
intel_fbc_handle_fifo_underrun_irq():1) The function
intel_fbc_handle_fifo_underrun_irq()is more about disabling the FBC on an underrun. I think reporting that the FBC was decompressing when the there was an underrun makes more sense to be grouped together with the other info related to FIFO underruns. It could even be useful if, due to some hw/sw bug, FBC is still doing something after we disabled it (or so we thought) due to a previous underrun.2) Logging underrun debug info is currently guarded by
intel_set_cpu_fifo_underrun_reporting(). So, we would need to complicate the implementation a bit to ensure thatintel_fbc_handle_fifo_underrun_irq()would only report when reporting was enabled.
Quoted 3 lines
So, I was thinking about defining a new function
intel_fbc_fifo_underrun_log_info()and calling it fromxe3p_lpd_log_underrun(). What do you think?
Yeah, that sounds fine to me.
Matt
Quoted 39 lines
--
Gustavo SousaQuoted 36 lines
Matt
Quoted 26 lines
drivers/gpu/drm/i915/display/intel_fifo_underrun.c +12
-0+ + val =intel_de_read (display,GEN12_DCPR_STATUS_1 ); +if (val &XE3P_UNDERRUN_PKGC ) { +intel_de_write (display,GEN12_DCPR_STATUS_1 ,XE3P_UNDERRUN_PKGC ); +drm_err (display->drm,"Pipe %c FIFO underrun info: Pkgc blocking memory\n" , +pipe_name (pipe)); + } +} +/** * intel_cpu_fifo_underrun_irq_handler - handle CPU fifo underrun interrupt * @display: display device instance @@ -379,6 +463,9 @@ void intel_cpu_fifo_underrun_irq_handler(struct intel_display *display,trace_intel_cpu_fifo_underrun (display, pipe);drm_err (display->drm,"CPU pipe %c FIFO underrun\n" ,pipe_name (pipe)); + +if (DISPLAY_VER (display) >=35 ) +xe3p_lpd_log_underrun (display, pipe); }intel_fbc_handle_fifo_underrun_irq (display);Signature · 2 lines
-- 2.51.0Signature · 4 lines
Matt Roper Graphics Software Engineer Linux GPU Platform Enablement Intel Corporation
Signature · 4 lines
Matt Roper Graphics Software Engineer Linux GPU Platform Enablement Intel Corporation
Re: [PATCH v2 11/32] drm/i915/xe3p_lpd: Underrun debuggability and error codes/hints
Quoting Matt Roper (2025-10-31 19:17:23-03:00)
Quoted 154 lines · Gustavo Sousa
Quoted 153 lines
Quoting Matt Roper (2025-10-29 17:54:39-03:00)
Quoted 66 lines · Gustavo Sousa
Quoted 65 lines
From: Sai Teja Pottumuttu <[email protected]>
Starting with
Xe3p_LPD, we get two new registers and some bits in existing registers that expose hardware state information at the time of underrun notification that can be relevant to debugging.Add the necessary logic in the driver to print the available debug information when an underrun happens.
v2:
- Useseq_bufto generate planes string. (Jani)
- Move definition ofFBC_DEBUG_STATUStointel_fbc_regs.h. (Ville)
- Change logic for processingUNDERRUN_DBG1to use loops and move it to a separate function. (Gustavo)
- Always print underrun error message, even if there wouldn't be any debug info associated to the underrun. (Gustavo)Bspec: 69111, 69561, 74411, 74412
Cc Jani Nikula <[email protected]>Cc Ville Syrjälä <[email protected]>Signed-off-by Sai Teja Pottumuttu <[email protected]>Co-developed-by Gustavo Sousa <[email protected]>Signed-off-by Gustavo Sousa <[email protected]>--- drivers/gpu/drm/i915/display/intel_display_regs.h | 20 +++++ drivers/gpu/drm/i915/display/intel_fbc_regs.h | 2 + drivers/gpu/drm/i915/display/intel_fifo_underrun.c | 87 ++++++++++++++++++++++ 3 files changed, 109 insertions(+)drivers/gpu/drm/i915/display/intel_display_regs.h +20
-0@@ -882,6 +882,25 @@#define PIPE_MISC2_FLIP_INFO_PLANE_SEL_MASK REG_GENMASK(2, 0)/* tgl+ */ #define PIPE_MISC2_FLIP_INFO_PLANE_SEL (plane_id) REG_FIELD_PREP(PIPE_MISC2_FLIP_INFO_PLANE_SEL_MASK, (plane_id)) +#define _UNDERRUN_DBG1_A 0x70064 +#define _UNDERRUN_DBG1_B 0x71064 +#define UNDERRUN_DBG1 (pipe) _MMIO_PIPE(pipe, \ + _UNDERRUN_DBG1_A, \ + _UNDERRUN_DBG1_B) +#define UNDERRUN_DBUF_BLOCK_NOT_VALID_MASK REG_GENMASK(29, 24) +#define UNDERRUN_DDB_EMPTY_MASK REG_GENMASK(21, 16) +#define UNDERRUN_DBUF_NOT_FILLED_MASK REG_GENMASK(13, 8) +#define UNDERRUN_BELOW_WM0_MASK REG_GENMASK(5, 0) + +#define _UNDERRUN_DBG2_A 0x70068 +#define _UNDERRUN_DBG2_B 0x71068 +#define UNDERRUN_DBG2 (pipe) _MMIO_PIPE(pipe, \ + _UNDERRUN_DBG2_A, \ + _UNDERRUN_DBG2_B) +#define UNDERRUN_FRAME_LINE_COUNTERS_FROZEN REG_BIT(31) +#define UNDERRUN_PIPE_FRAME_COUNT_MASK REG_GENMASK(30, 20) +#define UNDERRUN_LINE_COUNT_MASK REG_GENMASK(19, 0) +#define DPINVGTT _MMIO(VLV_DISPLAY_BASE + 0x7002c)/* VLV/CHV only */ #define DPINVGTT_EN_MASK_CHV REG_GENMASK(27, 16)#define DPINVGTT_EN_MASK_VLV REG_GENMASK(23, 16)@@ -1416,6 +1435,7 @@#define GEN12_DCPR_STATUS_1 _MMIO(0x46440)#define XELPDP_PMDEMAND_INFLIGHT_STATUS REG_BIT(26) +#define XE3P_UNDERRUN_PKGC REG_BIT(21)Quoted 14 lines
drivers/gpu/drm/i915/display/intel_fbc_regs.h line 91
Quoted 11 lines
drivers/gpu/drm/i915/display/intel_display_regs.h +0
-0#define FUSE_STRAP _MMIO(0x42014)#define ILK_INTERNAL_GRAPHICS_DISABLE REG_BIT(31)drivers/gpu/drm/i915/display/intel_fbc_regs.h +1
-0@@ -88,6 +88,8 @@#define DPFC_FENCE_YOFF _MMIO(0x3218)#define ILK_DPFC_FENCE_YOFF (fbc_id) _MMIO_PIPE((fbc_id), 0x43218, 0x43258)#define DPFC_CHICKEN _MMIO(0x3224) +#define FBC_DEBUG_STATUS (pipe) _MMIO_PIPE(pipe, 0x43220, 0x43260)Is 'pipe' correct here? Most of the other FBC registers are parameterized by FBC instance rather than pipe.
Yeah, I just blindly copy/pasted the definition without realizing that the rest of the file uses
fbc_id. I'll change it to usefbc_idas well.Quoted 67 lines
Quoted 49 lines
drivers/gpu/drm/i915/display/intel_fbc_regs.h +1
-0+#define FBC_UNDERRUN_DECOMPRESSION REG_BIT(27)#define ILK_DPFC_CHICKEN (fbc_id) _MMIO_PIPE((fbc_id), 0x43224, 0x43264)#define DPFC_HT_MODIFY REG_BIT(31)/* pre-ivb */ #define DPFC_NUKE_ON_ANY_MODIFICATION REG_BIT(23)/* bdw+ */ drivers/gpu/drm/i915/display/intel_fifo_underrun.c +22
-0@@ -25,6 +25,8 @@* */ +#include <linux/seq_buf.h> +#include <drm/drm_print.h> #include "i915_reg.h" @@ -34,6 +36,7 @@#include "intel_display_trace.h" #include "intel_display_types.h" #include "intel_fbc.h" +#include "intel_fbc_regs.h" #include "intel_fifo_underrun.h" #include "intel_pch_display.h" @@ -352,6 +355,87 @@ bool intel_set_pch_fifo_underrun_reporting(struct intel_display *display,return old; } +#define UNDERRUN_DBG1_NUM_PLANES 6 + +static void process_underrun_dbg1 (struct intel_display *display, +enum pipe pipe) +{ +struct { +u32 mask; +const char *info; + } info_masks[] = { + {UNDERRUN_DBUF_BLOCK_NOT_VALID_MASK ,"DBUF block not valid" }, + {UNDERRUN_DDB_EMPTY_MASK ,"DDB empty" }, + {UNDERRUN_DBUF_NOT_FILLED_MASK ,"DBUF not completely filled" }, + {UNDERRUN_BELOW_WM0_MASK ,"DBUF below WM0" }, + }; +DECLARE_SEQ_BUF (planes_desc,32 ); +u32 val; + + val =intel_de_read (display,UNDERRUN_DBG1 (pipe)); +intel_de_write (display,UNDERRUN_DBG1 (pipe), val);drivers/gpu/drm/i915/display/intel_fifo_underrun.c bool intel_set_pch_fifo_underrun_reporting(struct intel_display *display, · line 386
Quoted 10 lines
drivers/gpu/drm/i915/display/intel_fifo_underrun.c +10
-0+ +for (int i =0 ; i <ARRAY_SIZE (info_masks); i++) { +u32 plane_bits; + + plane_bits = val & info_masks[i].mask; + +if (!plane_bits) +continue ; + + plane_bits >>=ffs (info_masks[i].mask) -1 ;Nitpick: It seems like we're just open-coding
REG_FIELD_GEThere. Any reason not to simplify down to something like this?u32 plane_bits = REG_FIELD_GET(info_masks[i].mask, val); if (!plane_bits) continue;
Quoted 7 lines
Quoted 2 lines
We can't use
REG_FIELD_GET()because the mask parameter must be a constant expression. That's why I went with open-coded version.Oh yeah, I always forget about that restriction. I'm fine with keeping the open-coded version in that case, although you may want to move the
plane_bitsassignment up onto the declaration line. And maybe use__ffs()instead offfs()to avoid the need to substract 1.
Hehe. I ended up applying the diff from below to my local v3; it is not too late to go back to the open-coded version though. I could go with either versions, so let me know what you prefer. :-)
--
Gustavo Sousa
Quoted 191 lines
Quoted 137 lines
We could change the current patch to use
REG_FIELD_GET()with something like below. What do you think?|diff --git a/drivers/gpu/drm/i915/display/intel_fifo_underrun.c b/drivers/gpu/drm/i915/display/intel_fifo_underrun.c |index 43cf141a59ae..34faedb9799c 100644 |--- a/drivers/gpu/drm/i915/display/intel_fifo_underrun.c |+++ b/drivers/gpu/drm/i915/display/intel_fifo_underrun.c |@@ -360,35 +360,28 @@ bool intel_set_pch_fifo_underrun_reporting(struct intel_display *display, | static void process_underrun_dbg1(struct intel_display *display, | enum pipe pipe) | { |+ u32 val = intel_de_read(display, UNDERRUN_DBG1(pipe)); | struct { |- u32 mask; |+ u32 plane_mask; | const char *info; |- } info_masks[] = { |- { UNDERRUN_DBUF_BLOCK_NOT_VALID_MASK, "DBUF block not valid" }, |- { UNDERRUN_DDB_EMPTY_MASK, "DDB empty" }, |- { UNDERRUN_DBUF_NOT_FILLED_MASK, "DBUF not completely filled" }, |- { UNDERRUN_BELOW_WM0_MASK, "DBUF below WM0" }, |+ } masks[] = { |+ { REG_FIELD_GET(UNDERRUN_DBUF_BLOCK_NOT_VALID_MASK, val), "DBUF block not valid" }, |+ { REG_FIELD_GET(UNDERRUN_DDB_EMPTY_MASK, val), "DDB empty" }, |+ { REG_FIELD_GET(UNDERRUN_DBUF_NOT_FILLED_MASK, val), "DBUF not completely filled" }, |+ { REG_FIELD_GET(UNDERRUN_BELOW_WM0_MASK, val), "DBUF below WM0" }, | }; | DECLARE_SEQ_BUF(planes_desc, 32); |- u32 val; | |- val = intel_de_read(display, UNDERRUN_DBG1(pipe)); | intel_de_write(display, UNDERRUN_DBG1(pipe), val); | |- for (int i = 0; i < ARRAY_SIZE(info_masks); i++) { |- u32 plane_bits; |- |- plane_bits = val & info_masks[i].mask; |- |- if (!plane_bits) |+ for (int i = 0; i < ARRAY_SIZE(masks); i++) { |+ if (!masks[i].plane_mask) | continue; | |- plane_bits >>= ffs(info_masks[i].mask) - 1; |- | seq_buf_clear(&planes_desc); | | for (int j = 0; j < UNDERRUN_DBG1_NUM_PLANES; j++) { |- if (!(plane_bits & REG_BIT(j))) |+ if (!(masks[i].plane_mask & REG_BIT(j))) | continue; | | if (j == 0) |@@ -399,7 +392,7 @@ static void process_underrun_dbg1(struct intel_display *display, | | drm_err(display->drm, | "Pipe %c FIFO underrun info: %s on planes: %s\n", |- pipe_name(pipe), info_masks[i].info, seq_buf_str(&planes_desc)); |+ pipe_name(pipe), masks[i].info, seq_buf_str(&planes_desc)); | | drm_WARN_ON(display->drm, seq_buf_has_overflowed(&planes_desc)); | }Quoted 42 lines
Quoted 42 lines
drivers/gpu/drm/i915/display/intel_fifo_underrun.c +41
-0+ +seq_buf_clear (&planes_desc); + +for (int j =0 ; j <UNDERRUN_DBG1_NUM_PLANES ; j++) { +if (!(plane_bits ®_BIT (j))) +continue ; + +if (j ==0 ) +seq_buf_puts (&planes_desc,"[C]" ); +else +seq_buf_printf (&planes_desc,"[%d]" , j); + } + +drm_err (display->drm, +"Pipe %c FIFO underrun info: %s on planes: %s\n" , +pipe_name (pipe), info_masks[i].info,seq_buf_str (&planes_desc)); + +drm_WARN_ON (display->drm,seq_buf_has_overflowed (&planes_desc)); + } +} + +static void xe3p_lpd_log_underrun (struct intel_display *display, +enum pipe pipe) +{ +u32 val; + +process_underrun_dbg1 (display, pipe); + + val =intel_de_read (display,UNDERRUN_DBG2 (pipe)); +if (val &UNDERRUN_FRAME_LINE_COUNTERS_FROZEN ) { +intel_de_write (display,UNDERRUN_DBG2 (pipe),UNDERRUN_FRAME_LINE_COUNTERS_FROZEN ); +drm_err (display->drm,"Pipe %c FIFO underrun info: Frame count: %u, Line count: %u\n" , +pipe_name (pipe), +REG_FIELD_GET (UNDERRUN_PIPE_FRAME_COUNT_MASK , val), +REG_FIELD_GET (UNDERRUN_LINE_COUNT_MASK , val)); + } + + val =intel_de_read (display,FBC_DEBUG_STATUS (pipe)); +if (val &FBC_UNDERRUN_DECOMPRESSION ) { +intel_de_write (display,FBC_DEBUG_STATUS (pipe),FBC_UNDERRUN_DECOMPRESSION ); + drm_err(display->drm, "Pipe %c FIFO underrun info: FBC decompression\n",Quoted 8 lines
drivers/gpu/drm/i915/display/intel_fifo_underrun.c bool intel_set_pch_fifo_underrun_reporting(struct intel_display *display, · line 429
Quoted 2 lines
drivers/gpu/drm/i915/display/intel_fifo_underrun.c +2
-0+ pipe_name(pipe)); + }As noted above, I'm not sure if 'pipe' is technically correct for this register. I think it always winds up with a 1:1 relationship on current platforms, but would it make more sense to just move this check and print into
intel_fbc_handle_fifo_underrun_irq()where we're already handling the FBC stuff on a per-FBC unit basis?Yeah. We probably want to check if there is a valid FBC instance respective to this pipe and then read the register.
I see complications with moving this to
intel_fbc_handle_fifo_underrun_irq():1) The function
intel_fbc_handle_fifo_underrun_irq()is more about disabling the FBC on an underrun. I think reporting that the FBC was decompressing when the there was an underrun makes more sense to be grouped together with the other info related to FIFO underruns. It could even be useful if, due to some hw/sw bug, FBC is still doing something after we disabled it (or so we thought) due to a previous underrun.2) Logging underrun debug info is currently guarded by
intel_set_cpu_fifo_underrun_reporting(). So, we would need to complicate the implementation a bit to ensure thatintel_fbc_handle_fifo_underrun_irq()would only report when reporting was enabled.Quoted 3 lines
So, I was thinking about defining a new function
intel_fbc_fifo_underrun_log_info()and calling it fromxe3p_lpd_log_underrun(). What do you think?Yeah, that sounds fine to me.
Matt
Quoted 39 lines
--
Gustavo SousaQuoted 36 lines
Matt
Quoted 26 lines
drivers/gpu/drm/i915/display/intel_fifo_underrun.c +12
-0+ + val =intel_de_read (display,GEN12_DCPR_STATUS_1 ); +if (val &XE3P_UNDERRUN_PKGC ) { +intel_de_write (display,GEN12_DCPR_STATUS_1 ,XE3P_UNDERRUN_PKGC ); +drm_err (display->drm,"Pipe %c FIFO underrun info: Pkgc blocking memory\n" , +pipe_name (pipe)); + } +} +/** * intel_cpu_fifo_underrun_irq_handler - handle CPU fifo underrun interrupt * @display: display device instance @@ -379,6 +463,9 @@ void intel_cpu_fifo_underrun_irq_handler(struct intel_display *display,trace_intel_cpu_fifo_underrun (display, pipe);drm_err (display->drm,"CPU pipe %c FIFO underrun\n" ,pipe_name (pipe)); + +if (DISPLAY_VER (display) >=35 ) +xe3p_lpd_log_underrun (display, pipe); }intel_fbc_handle_fifo_underrun_irq (display);Signature · 2 lines
-- 2.51.0Signature · 4 lines
Matt Roper Graphics Software Engineer Linux GPU Platform Enablement Intel CorporationSignature · 4 lines
Matt Roper Graphics Software Engineer Linux GPU Platform Enablement Intel Corporation
Re: [PATCH v2 11/32] drm/i915/xe3p_lpd: Underrun debuggability and error codes/hints
In reply to Matt RoperQuoting Matt Roper (2025-10-31 19:17:23-03:00)
Quoted 154 lines · Gustavo Sousa
Quoted 153 lines
Quoting Matt Roper (2025-10-29 17:54:39-03:00)
Quoted 66 lines · Gustavo Sousa
Quoted 65 lines
From: Sai Teja Pottumuttu <[email protected]>
Starting with
Xe3p_LPD, we get two new registers and some bits in existing registers that expose hardware state information at the time of underrun notification that can be relevant to debugging.Add the necessary logic in the driver to print the available debug information when an underrun happens.
v2:
- Useseq_bufto generate planes string. (Jani)
- Move definition ofFBC_DEBUG_STATUStointel_fbc_regs.h. (Ville)
- Change logic for processingUNDERRUN_DBG1to use loops and move it to a separate function. (Gustavo)
- Always print underrun error message, even if there wouldn't be any debug info associated to the underrun. (Gustavo)Bspec: 69111, 69561, 74411, 74412
Cc Jani Nikula <[email protected]>Cc Ville Syrjälä <[email protected]>Signed-off-by Sai Teja Pottumuttu <[email protected]>Co-developed-by Gustavo Sousa <[email protected]>Signed-off-by Gustavo Sousa <[email protected]>--- drivers/gpu/drm/i915/display/intel_display_regs.h | 20 +++++ drivers/gpu/drm/i915/display/intel_fbc_regs.h | 2 + drivers/gpu/drm/i915/display/intel_fifo_underrun.c | 87 ++++++++++++++++++++++ 3 files changed, 109 insertions(+)drivers/gpu/drm/i915/display/intel_display_regs.h +20
-0@@ -882,6 +882,25 @@#define PIPE_MISC2_FLIP_INFO_PLANE_SEL_MASK REG_GENMASK(2, 0)/* tgl+ */ #define PIPE_MISC2_FLIP_INFO_PLANE_SEL (plane_id) REG_FIELD_PREP(PIPE_MISC2_FLIP_INFO_PLANE_SEL_MASK, (plane_id)) +#define _UNDERRUN_DBG1_A 0x70064 +#define _UNDERRUN_DBG1_B 0x71064 +#define UNDERRUN_DBG1 (pipe) _MMIO_PIPE(pipe, \ + _UNDERRUN_DBG1_A, \ + _UNDERRUN_DBG1_B) +#define UNDERRUN_DBUF_BLOCK_NOT_VALID_MASK REG_GENMASK(29, 24) +#define UNDERRUN_DDB_EMPTY_MASK REG_GENMASK(21, 16) +#define UNDERRUN_DBUF_NOT_FILLED_MASK REG_GENMASK(13, 8) +#define UNDERRUN_BELOW_WM0_MASK REG_GENMASK(5, 0) + +#define _UNDERRUN_DBG2_A 0x70068 +#define _UNDERRUN_DBG2_B 0x71068 +#define UNDERRUN_DBG2 (pipe) _MMIO_PIPE(pipe, \ + _UNDERRUN_DBG2_A, \ + _UNDERRUN_DBG2_B) +#define UNDERRUN_FRAME_LINE_COUNTERS_FROZEN REG_BIT(31) +#define UNDERRUN_PIPE_FRAME_COUNT_MASK REG_GENMASK(30, 20) +#define UNDERRUN_LINE_COUNT_MASK REG_GENMASK(19, 0) +#define DPINVGTT _MMIO(VLV_DISPLAY_BASE + 0x7002c)/* VLV/CHV only */ #define DPINVGTT_EN_MASK_CHV REG_GENMASK(27, 16)#define DPINVGTT_EN_MASK_VLV REG_GENMASK(23, 16)@@ -1416,6 +1435,7 @@#define GEN12_DCPR_STATUS_1 _MMIO(0x46440)#define XELPDP_PMDEMAND_INFLIGHT_STATUS REG_BIT(26) +#define XE3P_UNDERRUN_PKGC REG_BIT(21)Quoted 14 lines
drivers/gpu/drm/i915/display/intel_fbc_regs.h line 91
Quoted 11 lines
drivers/gpu/drm/i915/display/intel_display_regs.h +0
-0#define FUSE_STRAP _MMIO(0x42014)#define ILK_INTERNAL_GRAPHICS_DISABLE REG_BIT(31)drivers/gpu/drm/i915/display/intel_fbc_regs.h +1
-0@@ -88,6 +88,8 @@#define DPFC_FENCE_YOFF _MMIO(0x3218)#define ILK_DPFC_FENCE_YOFF (fbc_id) _MMIO_PIPE((fbc_id), 0x43218, 0x43258)#define DPFC_CHICKEN _MMIO(0x3224) +#define FBC_DEBUG_STATUS (pipe) _MMIO_PIPE(pipe, 0x43220, 0x43260)Is 'pipe' correct here? Most of the other FBC registers are parameterized by FBC instance rather than pipe.
Yeah, I just blindly copy/pasted the definition without realizing that the rest of the file uses
fbc_id. I'll change it to usefbc_idas well.Quoted 67 lines
Quoted 49 lines
drivers/gpu/drm/i915/display/intel_fbc_regs.h +1
-0+#define FBC_UNDERRUN_DECOMPRESSION REG_BIT(27)#define ILK_DPFC_CHICKEN (fbc_id) _MMIO_PIPE((fbc_id), 0x43224, 0x43264)#define DPFC_HT_MODIFY REG_BIT(31)/* pre-ivb */ #define DPFC_NUKE_ON_ANY_MODIFICATION REG_BIT(23)/* bdw+ */ drivers/gpu/drm/i915/display/intel_fifo_underrun.c +22
-0@@ -25,6 +25,8 @@* */ +#include <linux/seq_buf.h> +#include <drm/drm_print.h> #include "i915_reg.h" @@ -34,6 +36,7 @@#include "intel_display_trace.h" #include "intel_display_types.h" #include "intel_fbc.h" +#include "intel_fbc_regs.h" #include "intel_fifo_underrun.h" #include "intel_pch_display.h" @@ -352,6 +355,87 @@ bool intel_set_pch_fifo_underrun_reporting(struct intel_display *display,return old; } +#define UNDERRUN_DBG1_NUM_PLANES 6 + +static void process_underrun_dbg1 (struct intel_display *display, +enum pipe pipe) +{ +struct { +u32 mask; +const char *info; + } info_masks[] = { + {UNDERRUN_DBUF_BLOCK_NOT_VALID_MASK ,"DBUF block not valid" }, + {UNDERRUN_DDB_EMPTY_MASK ,"DDB empty" }, + {UNDERRUN_DBUF_NOT_FILLED_MASK ,"DBUF not completely filled" }, + {UNDERRUN_BELOW_WM0_MASK ,"DBUF below WM0" }, + }; +DECLARE_SEQ_BUF (planes_desc,32 ); +u32 val; + + val =intel_de_read (display,UNDERRUN_DBG1 (pipe)); +intel_de_write (display,UNDERRUN_DBG1 (pipe), val);drivers/gpu/drm/i915/display/intel_fifo_underrun.c bool intel_set_pch_fifo_underrun_reporting(struct intel_display *display, · line 386
Quoted 10 lines
drivers/gpu/drm/i915/display/intel_fifo_underrun.c +10
-0+ +for (int i =0 ; i <ARRAY_SIZE (info_masks); i++) { +u32 plane_bits; + + plane_bits = val & info_masks[i].mask; + +if (!plane_bits) +continue ; + + plane_bits >>=ffs (info_masks[i].mask) -1 ;Nitpick: It seems like we're just open-coding
REG_FIELD_GEThere. Any reason not to simplify down to something like this?u32 plane_bits = REG_FIELD_GET(info_masks[i].mask, val); if (!plane_bits) continue;
Quoted 7 lines
Quoted 2 lines
We can't use
REG_FIELD_GET()because the mask parameter must be a constant expression. That's why I went with open-coded version.Oh yeah, I always forget about that restriction. I'm fine with keeping the open-coded version in that case, although you may want to move the
plane_bitsassignment up onto the declaration line. And maybe use__ffs()instead offfs()to avoid the need to substract 1.
I'm going back to the open-coded version after feedback[1] on v4. With that, I'll move the assignment up onto the declaration.
Now, for the suggestion of using __ffs(), while i915 (non-display part) and xe do use it, it appears display code has the preference of using "ffs(...) - 1", so I'm a bit hesitant on introducing its usage to display code.
Maybe display maintainers could give their view on this.
[1] https://lore.kernel.org/all/[email protected]/
Quoted 191 lines
Quoted 137 lines
We could change the current patch to use
REG_FIELD_GET()with something like below. What do you think?|diff --git a/drivers/gpu/drm/i915/display/intel_fifo_underrun.c b/drivers/gpu/drm/i915/display/intel_fifo_underrun.c |index 43cf141a59ae..34faedb9799c 100644 |--- a/drivers/gpu/drm/i915/display/intel_fifo_underrun.c |+++ b/drivers/gpu/drm/i915/display/intel_fifo_underrun.c |@@ -360,35 +360,28 @@ bool intel_set_pch_fifo_underrun_reporting(struct intel_display *display, | static void process_underrun_dbg1(struct intel_display *display, | enum pipe pipe) | { |+ u32 val = intel_de_read(display, UNDERRUN_DBG1(pipe)); | struct { |- u32 mask; |+ u32 plane_mask; | const char *info; |- } info_masks[] = { |- { UNDERRUN_DBUF_BLOCK_NOT_VALID_MASK, "DBUF block not valid" }, |- { UNDERRUN_DDB_EMPTY_MASK, "DDB empty" }, |- { UNDERRUN_DBUF_NOT_FILLED_MASK, "DBUF not completely filled" }, |- { UNDERRUN_BELOW_WM0_MASK, "DBUF below WM0" }, |+ } masks[] = { |+ { REG_FIELD_GET(UNDERRUN_DBUF_BLOCK_NOT_VALID_MASK, val), "DBUF block not valid" }, |+ { REG_FIELD_GET(UNDERRUN_DDB_EMPTY_MASK, val), "DDB empty" }, |+ { REG_FIELD_GET(UNDERRUN_DBUF_NOT_FILLED_MASK, val), "DBUF not completely filled" }, |+ { REG_FIELD_GET(UNDERRUN_BELOW_WM0_MASK, val), "DBUF below WM0" }, | }; | DECLARE_SEQ_BUF(planes_desc, 32); |- u32 val; | |- val = intel_de_read(display, UNDERRUN_DBG1(pipe)); | intel_de_write(display, UNDERRUN_DBG1(pipe), val); | |- for (int i = 0; i < ARRAY_SIZE(info_masks); i++) { |- u32 plane_bits; |- |- plane_bits = val & info_masks[i].mask; |- |- if (!plane_bits) |+ for (int i = 0; i < ARRAY_SIZE(masks); i++) { |+ if (!masks[i].plane_mask) | continue; | |- plane_bits >>= ffs(info_masks[i].mask) - 1; |- | seq_buf_clear(&planes_desc); | | for (int j = 0; j < UNDERRUN_DBG1_NUM_PLANES; j++) { |- if (!(plane_bits & REG_BIT(j))) |+ if (!(masks[i].plane_mask & REG_BIT(j))) | continue; | | if (j == 0) |@@ -399,7 +392,7 @@ static void process_underrun_dbg1(struct intel_display *display, | | drm_err(display->drm, | "Pipe %c FIFO underrun info: %s on planes: %s\n", |- pipe_name(pipe), info_masks[i].info, seq_buf_str(&planes_desc)); |+ pipe_name(pipe), masks[i].info, seq_buf_str(&planes_desc)); | | drm_WARN_ON(display->drm, seq_buf_has_overflowed(&planes_desc)); | }Quoted 42 lines
Quoted 42 lines
drivers/gpu/drm/i915/display/intel_fifo_underrun.c +41
-0+ +seq_buf_clear (&planes_desc); + +for (int j =0 ; j <UNDERRUN_DBG1_NUM_PLANES ; j++) { +if (!(plane_bits ®_BIT (j))) +continue ; + +if (j ==0 ) +seq_buf_puts (&planes_desc,"[C]" ); +else +seq_buf_printf (&planes_desc,"[%d]" , j); + } + +drm_err (display->drm, +"Pipe %c FIFO underrun info: %s on planes: %s\n" , +pipe_name (pipe), info_masks[i].info,seq_buf_str (&planes_desc)); + +drm_WARN_ON (display->drm,seq_buf_has_overflowed (&planes_desc)); + } +} + +static void xe3p_lpd_log_underrun (struct intel_display *display, +enum pipe pipe) +{ +u32 val; + +process_underrun_dbg1 (display, pipe); + + val =intel_de_read (display,UNDERRUN_DBG2 (pipe)); +if (val &UNDERRUN_FRAME_LINE_COUNTERS_FROZEN ) { +intel_de_write (display,UNDERRUN_DBG2 (pipe),UNDERRUN_FRAME_LINE_COUNTERS_FROZEN ); +drm_err (display->drm,"Pipe %c FIFO underrun info: Frame count: %u, Line count: %u\n" , +pipe_name (pipe), +REG_FIELD_GET (UNDERRUN_PIPE_FRAME_COUNT_MASK , val), +REG_FIELD_GET (UNDERRUN_LINE_COUNT_MASK , val)); + } + + val =intel_de_read (display,FBC_DEBUG_STATUS (pipe)); +if (val &FBC_UNDERRUN_DECOMPRESSION ) { +intel_de_write (display,FBC_DEBUG_STATUS (pipe),FBC_UNDERRUN_DECOMPRESSION ); + drm_err(display->drm, "Pipe %c FIFO underrun info: FBC decompression\n",Quoted 8 lines
drivers/gpu/drm/i915/display/intel_fifo_underrun.c bool intel_set_pch_fifo_underrun_reporting(struct intel_display *display, · line 429
Quoted 2 lines
drivers/gpu/drm/i915/display/intel_fifo_underrun.c +2
-0+ pipe_name(pipe)); + }As noted above, I'm not sure if 'pipe' is technically correct for this register. I think it always winds up with a 1:1 relationship on current platforms, but would it make more sense to just move this check and print into
intel_fbc_handle_fifo_underrun_irq()where we're already handling the FBC stuff on a per-FBC unit basis?Yeah. We probably want to check if there is a valid FBC instance respective to this pipe and then read the register.
I see complications with moving this to
intel_fbc_handle_fifo_underrun_irq():1) The function
intel_fbc_handle_fifo_underrun_irq()is more about disabling the FBC on an underrun. I think reporting that the FBC was decompressing when the there was an underrun makes more sense to be grouped together with the other info related to FIFO underruns. It could even be useful if, due to some hw/sw bug, FBC is still doing something after we disabled it (or so we thought) due to a previous underrun.2) Logging underrun debug info is currently guarded by
intel_set_cpu_fifo_underrun_reporting(). So, we would need to complicate the implementation a bit to ensure thatintel_fbc_handle_fifo_underrun_irq()would only report when reporting was enabled.Quoted 3 lines
So, I was thinking about defining a new function
intel_fbc_fifo_underrun_log_info()and calling it fromxe3p_lpd_log_underrun(). What do you think?Yeah, that sounds fine to me.
Matt
Quoted 39 lines
--
Gustavo SousaQuoted 36 lines
Matt
Quoted 26 lines
drivers/gpu/drm/i915/display/intel_fifo_underrun.c +12
-0+ + val =intel_de_read (display,GEN12_DCPR_STATUS_1 ); +if (val &XE3P_UNDERRUN_PKGC ) { +intel_de_write (display,GEN12_DCPR_STATUS_1 ,XE3P_UNDERRUN_PKGC ); +drm_err (display->drm,"Pipe %c FIFO underrun info: Pkgc blocking memory\n" , +pipe_name (pipe)); + } +} +/** * intel_cpu_fifo_underrun_irq_handler - handle CPU fifo underrun interrupt * @display: display device instance @@ -379,6 +463,9 @@ void intel_cpu_fifo_underrun_irq_handler(struct intel_display *display,trace_intel_cpu_fifo_underrun (display, pipe);drm_err (display->drm,"CPU pipe %c FIFO underrun\n" ,pipe_name (pipe)); + +if (DISPLAY_VER (display) >=35 ) +xe3p_lpd_log_underrun (display, pipe); }intel_fbc_handle_fifo_underrun_irq (display);Signature · 2 lines
-- 2.51.0Signature · 4 lines
Matt Roper Graphics Software Engineer Linux GPU Platform Enablement Intel CorporationSignature · 4 lines
Matt Roper Graphics Software Engineer Linux GPU Platform Enablement Intel Corporation
PATCH v2 12/32 drm/i915/xe3p_lpd: Remove gamma,csc bottom color checks
In reply to Gustavo SousaFrom: Sai Teja Pottumuttu <[email protected]>
With Xe3p_LPD, the SKL_BOTTOM_COLOR_GAMMA_ENABLE and SKL_BOTTOM_COLOR_CSC_ENABLE bits are being removed. Thus, we need not set gamma_enable nor csc_enable in crtc_state.
Note that GAMMA_MODE.POST_CSC_GAMMA_ENABLE and CSC_MODE.ICL_CSC_ENABLE are the documented alternatives for the bottom color bits being removed. But as these suggested bits are being checked in state checker as part of gamma_mode, csc_mode fields and as gamma_enable/csc_enable are not being used anywhere else functionally post ICL, we need not set these fields in crtc_state.
Bspec: 69734
--- drivers/gpu/drm/i915/display/intel_color.c | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-)
drivers/gpu/drm/i915/display/intel_color.c +7 -6
@@ -1090,18 +1090,19 @@ static void skl_get_config(struct intel_crtc_state *crtc_state) {struct intel_display *display =to_intel_display (crtc_state);struct intel_crtc *crtc =to_intel_crtc (crtc_state->uapi.crtc); -u32 tmp; crtc_state->gamma_mode =hsw_read_gamma_mode (crtc); crtc_state->csc_mode =ilk_read_csc_mode (crtc); - tmp =intel_de_read (display,SKL_BOTTOM_COLOR (crtc->pipe)); +if (DISPLAY_VER (display) <35 ) { +u32 tmp =intel_de_read (display,SKL_BOTTOM_COLOR (crtc->pipe)); -if (tmp &SKL_BOTTOM_COLOR_GAMMA_ENABLE ) - crtc_state->gamma_enable = true; +if (tmp &SKL_BOTTOM_COLOR_GAMMA_ENABLE ) + crtc_state->gamma_enable = true; -if (tmp &SKL_BOTTOM_COLOR_CSC_ENABLE ) - crtc_state->csc_enable = true; +if (tmp &SKL_BOTTOM_COLOR_CSC_ENABLE ) + crtc_state->csc_enable = true; + } } static void skl_color_commit_arm(struct intel_dsb *dsb,
Signature · 1 line
2.51.0
PATCH v2 13/32 drm/i915/xe3p_lpd: Adapt to updates on MBUS_CTL/DBUF_CTL registers
In reply to Gustavo SousaFrom: Ravi Kumar Vodapalli <[email protected]>
Some of the register fields of MBUS_CTL and DBUF_CTL register are changed for Xe3p_LPD platforms. Update the changed fields in the driver. Below are the changes:
MBUS_CTL:
Translation Throttle Min It changed from BIT[15:13] to BIT[16:13]
DBUF_CTL:
Min Tracker State Service
It changed from BIT[18:16] to BIT[20:16]
Max Tracker State Service
It changed to from BIT[23:19] to BIT[14:10] but using default value, so no need to define in code.
v2:
- Keep definitions in the same line (i.e. without line continuation breaks) for better readability. (Jani)
Bspec: 68868, 68872
--- drivers/gpu/drm/i915/display/skl_watermark.c | 16 +++++-- drivers/gpu/drm/i915/display/skl_watermark_regs.h | 52 ++++++++++++----------- 2 files changed, 40 insertions(+), 28 deletions(-)
drivers/gpu/drm/i915/display/skl_watermark.c +12 -4
@@ -3477,7 +3477,10 @@ void intel_dbuf_mdclk_cdclk_ratio_update(struct intel_display *display,if (!HAS_MBUS_JOINING (display))return ; -if (DISPLAY_VER (display) >=20 ) +if (DISPLAY_VER (display) >=35 ) +intel_de_rmw (display,MBUS_CTL ,XE3P_MBUS_TRANSLATION_THROTTLE_MIN_MASK , +XE3P_MBUS_TRANSLATION_THROTTLE_MIN (ratio -1 )); +else if (DISPLAY_VER (display) >=20 )intel_de_rmw (display,MBUS_CTL ,MBUS_TRANSLATION_THROTTLE_MIN_MASK ,MBUS_TRANSLATION_THROTTLE_MIN (ratio -1 ));
@@ -3488,9 +3491,14 @@ void intel_dbuf_mdclk_cdclk_ratio_update(struct intel_display *display, ratio, str_yes_no(joined_mbus));for_each_dbuf_slice (display, slice) -intel_de_rmw (display,DBUF_CTL_S (slice), -DBUF_MIN_TRACKER_STATE_SERVICE_MASK , -DBUF_MIN_TRACKER_STATE_SERVICE (ratio -1 )); +if (DISPLAY_VER (display) >=35 ) +intel_de_rmw (display,DBUF_CTL_S (slice), +XE3P_DBUF_MIN_TRACKER_STATE_SERVICE_MASK , +XE3P_DBUF_MIN_TRACKER_STATE_SERVICE (ratio -1 )); +else +intel_de_rmw (display,DBUF_CTL_S (slice), +DBUF_MIN_TRACKER_STATE_SERVICE_MASK , +DBUF_MIN_TRACKER_STATE_SERVICE (ratio -1 )); }static void intel_dbuf_mdclk_min_tracker_update (struct intel_atomic_state *state)
drivers/gpu/drm/i915/display/skl_watermark_regs.h +28 -24
65 lines not on this page · raw message
Signature · 1 line
2.51.0
Re: [PATCH v2 13/32] drm/i915/xe3p_lpd: Adapt to updates on MBUS_CTL/DBUF_CTL registers
Quoted 10 lines · Gustavo Sousa
From: Ravi Kumar Vodapalli <[email protected]>
Some of the register fields of
MBUS_CTLandDBUF_CTLregister are changed forXe3p_LPDplatforms. Update the changed fields in the driver. Below are the changes:
MBUS_CTL:Translation Throttle Min It changed from BIT[15:13] to BIT[16:13]
Quoted 7 lines
DBUF_CTL:
Min Tracker State Service
It changed from BIT[18:16] to BIT[20:16]
Max Tracker State Service
It changed to from BIT[23:19] to BIT[14:10] but using default value, so no need to define in code.
In a lot of cases when a register field picks up extra high bit(s), the extra bits were previously reserved, so it's fine to just adjust the existing definition (since reserved bits are required to always read out of hardware as zeroes). However in these cases, the new bits these fields are extending into were actively used by the hardware for other purposes on previous platforms, which is why it's necessary to keep the existing pre-Xe3p definitions unchanged and create separate Xe3p ones that can be used only on the newer Xe3p platforms. You should make some mention of that in the commit message so it's clear why we're handling these a bit differently than a lot of other registers.
Quoted 68 lines
v2:
- Keep definitions in the same line (i.e. without line continuation breaks) for better readability. (Jani)Bspec: 68868, 68872
Cc Jani Nikula <[email protected]>Signed-off-by Ravi Kumar Vodapalli <[email protected]>Signed-off-by Gustavo Sousa <[email protected]>--- drivers/gpu/drm/i915/display/skl_watermark.c | 16 +++++-- drivers/gpu/drm/i915/display/skl_watermark_regs.h | 52 ++++++++++++----------- 2 files changed, 40 insertions(+), 28 deletions(-)drivers/gpu/drm/i915/display/skl_watermark.c +12
-4@@ -3477,7 +3477,10 @@ void intel_dbuf_mdclk_cdclk_ratio_update(struct intel_display *display,if (!HAS_MBUS_JOINING (display))return ; -if (DISPLAY_VER (display) >=20 ) +if (DISPLAY_VER (display) >=35 ) +intel_de_rmw (display,MBUS_CTL ,XE3P_MBUS_TRANSLATION_THROTTLE_MIN_MASK , +XE3P_MBUS_TRANSLATION_THROTTLE_MIN (ratio -1 )); +else if (DISPLAY_VER (display) >=20 )intel_de_rmw (display,MBUS_CTL ,MBUS_TRANSLATION_THROTTLE_MIN_MASK ,MBUS_TRANSLATION_THROTTLE_MIN (ratio -1 ));@@ -3488,9 +3491,14 @@ void intel_dbuf_mdclk_cdclk_ratio_update(struct intel_display *display, ratio, str_yes_no(joined_mbus));for_each_dbuf_slice (display, slice) -intel_de_rmw (display,DBUF_CTL_S (slice), -DBUF_MIN_TRACKER_STATE_SERVICE_MASK , -DBUF_MIN_TRACKER_STATE_SERVICE (ratio -1 )); +if (DISPLAY_VER (display) >=35 ) +intel_de_rmw (display,DBUF_CTL_S (slice), +XE3P_DBUF_MIN_TRACKER_STATE_SERVICE_MASK , +XE3P_DBUF_MIN_TRACKER_STATE_SERVICE (ratio -1 )); +else +intel_de_rmw (display,DBUF_CTL_S (slice), +DBUF_MIN_TRACKER_STATE_SERVICE_MASK , +DBUF_MIN_TRACKER_STATE_SERVICE (ratio -1 )); }static void intel_dbuf_mdclk_min_tracker_update (struct intel_atomic_state *state)drivers/gpu/drm/i915/display/skl_watermark_regs.h +2
-10@@ -32,16 +32,18 @@#define MBUS_BBOX_CTL_S1 _MMIO(0x45040)#define MBUS_BBOX_CTL_S2 _MMIO(0x45044) -#define MBUS_CTL _MMIO(0x4438C) -#define MBUS_JOIN REG_BIT(31) -#define MBUS_HASHING_MODE_MASK REG_BIT(30) -#define MBUS_HASHING_MODE_2x2 REG_FIELD_PREP(MBUS_HASHING_MODE_MASK, 0) -#define MBUS_HASHING_MODE_1x4 REG_FIELD_PREP(MBUS_HASHING_MODE_MASK, 1) -#define MBUS_JOIN_PIPE_SELECT_MASK REG_GENMASK(28, 26) -#define MBUS_JOIN_PIPE_SELECT (pipe) REG_FIELD_PREP(MBUS_JOIN_PIPE_SELECT_MASK, pipe) -#define MBUS_JOIN_PIPE_SELECT_NONE MBUS_JOIN_PIPE_SELECT(7) -#define MBUS_TRANSLATION_THROTTLE_MIN_MASK REG_GENMASK(15, 13) -#define MBUS_TRANSLATION_THROTTLE_MIN (val) REG_FIELD_PREP(MBUS_TRANSLATION_THROTTLE_MIN_MASK, val) +#define MBUS_CTL _MMIO(0x4438C) +#define MBUS_JOIN REG_BIT(31)
drivers/gpu/drm/i915/display/skl_watermark_regs.h line 46
Quoted 10 lines
drivers/gpu/drm/i915/display/skl_watermark_regs.h +10
-0+#define MBUS_HASHING_MODE_MASK REG_BIT(30) +#define MBUS_HASHING_MODE_2x2 REG_FIELD_PREP(MBUS_HASHING_MODE_MASK, 0) +#define MBUS_HASHING_MODE_1x4 REG_FIELD_PREP(MBUS_HASHING_MODE_MASK, 1) +#define MBUS_JOIN_PIPE_SELECT_MASK REG_GENMASK(28, 26) +#define MBUS_JOIN_PIPE_SELECT (pipe) REG_FIELD_PREP(MBUS_JOIN_PIPE_SELECT_MASK, pipe) +#define MBUS_JOIN_PIPE_SELECT_NONE MBUS_JOIN_PIPE_SELECT(7) +#define MBUS_TRANSLATION_THROTTLE_MIN_MASK REG_GENMASK(15, 13) +#define MBUS_TRANSLATION_THROTTLE_MIN (val) REG_FIELD_PREP(MBUS_TRANSLATION_THROTTLE_MIN_MASK, val) +#define XE3P_MBUS_TRANSLATION_THROTTLE_MIN_MASK REG_GENMASK(16, 13) +#define XE3P_MBUS_TRANSLATION_THROTTLE_MIN (val) REG_FIELD_PREP(XE3P_MBUS_TRANSLATION_THROTTLE_MIN_MASK, val)
Nitpick: I'm not sure if we're 100% consistent, but I feel like we usually sort bitfields based on their upper bound rather than their lower bound. So even though xe3p and pre-xe3p start at the same bit 13, the xe3p should probably be sorted first since it ends at a higher bit (16 vs 15).
Quoted 28 lines
drivers/gpu/drm/i915/display/skl_watermark_regs.h +7
-14/* * The below are numbered starting from "S1" on gen11/gen12, but starting @@ -51,21 +53,23 @@* way things will be named by the hardware team going forward, plus it's more * consistent with how most of the rest of our registers are named. */ -#define _DBUF_CTL_S0 0x45008 -#define _DBUF_CTL_S1 0x44FE8 -#define _DBUF_CTL_S2 0x44300 -#define _DBUF_CTL_S3 0x44304 -#define DBUF_CTL_S (slice) _MMIO(_PICK(slice, \ - _DBUF_CTL_S0, \ - _DBUF_CTL_S1, \ - _DBUF_CTL_S2, \ - _DBUF_CTL_S3)) -#define DBUF_POWER_REQUEST REG_BIT(31) -#define DBUF_POWER_STATE REG_BIT(30) -#define DBUF_TRACKER_STATE_SERVICE_MASK REG_GENMASK(23, 19) -#define DBUF_TRACKER_STATE_SERVICE (x) REG_FIELD_PREP(DBUF_TRACKER_STATE_SERVICE_MASK, x) -#define DBUF_MIN_TRACKER_STATE_SERVICE_MASK REG_GENMASK(18, 16)/* ADL-P+ */ +#define _DBUF_CTL_S0 0x45008 +#define _DBUF_CTL_S1 0x44FE8 +#define _DBUF_CTL_S2 0x44300 +#define _DBUF_CTL_S3 0x44304 +#define DBUF_CTL_S (slice) _MMIO(_PICK(slice, \ + _DBUF_CTL_S0, \ + _DBUF_CTL_S1, \
drivers/gpu/drm/i915/display/skl_watermark_regs.h line 72
Quoted 10 lines
drivers/gpu/drm/i915/display/skl_watermark_regs.h +9
-0+ _DBUF_CTL_S2, \ + _DBUF_CTL_S3)) +#define DBUF_POWER_REQUEST REG_BIT(31) +#define DBUF_POWER_STATE REG_BIT(30) +#define DBUF_TRACKER_STATE_SERVICE_MASK REG_GENMASK(23, 19) +#define DBUF_TRACKER_STATE_SERVICE (x) REG_FIELD_PREP(DBUF_TRACKER_STATE_SERVICE_MASK, x) +#define DBUF_MIN_TRACKER_STATE_SERVICE_MASK REG_GENMASK(18, 16)/* ADL-P+ */ #define DBUF_MIN_TRACKER_STATE_SERVICE (x) REG_FIELD_PREP(DBUF_MIN_TRACKER_STATE_SERVICE_MASK, x)/* ADL-P+ */ +#define XE3P_DBUF_MIN_TRACKER_STATE_SERVICE_MASK REG_GENMASK(20, 16) +#define XE3P_DBUF_MIN_TRACKER_STATE_SERVICE (x) REG_FIELD_PREP(XE3P_DBUF_MIN_TRACKER_STATE_SERVICE_MASK, x)
Same here.
Matt
Quoted 7 lines
drivers/gpu/drm/i915/display/skl_watermark_regs.h +0
-0#define MTL_LATENCY_LP0_LP1 _MMIO(0x45780)#define MTL_LATENCY_LP2_LP3 _MMIO(0x45784)Signature · 1 line
2.51.0
Signature · 4 lines
Matt Roper Graphics Software Engineer Linux GPU Platform Enablement Intel Corporation
Re: [PATCH v2 13/32] drm/i915/xe3p_lpd: Adapt to updates on MBUS_CTL/DBUF_CTL registers
Quoting Matt Roper (2025-10-29 18:22:15-03:00)
Quoted 19 lines · Gustavo Sousa
Quoted 10 lines
From: Ravi Kumar Vodapalli <[email protected]>
Some of the register fields of
MBUS_CTLandDBUF_CTLregister are changed forXe3p_LPDplatforms. Update the changed fields in the driver. Below are the changes:
MBUS_CTL:
Translation Throttle Min
It changed from BIT[15:13] to BIT[16:13]Quoted 7 lines
DBUF_CTL:
Min Tracker State Service
It changed from BIT[18:16] to BIT[20:16]
Max Tracker State Service
It changed to from BIT[23:19] to BIT[14:10] but using default value, so no need to define in code.
Quoted 10 lines
In a lot of cases when a register field picks up extra high bit(s), the extra bits were previously reserved, so it's fine to just adjust the existing definition (since reserved bits are required to always read out of hardware as zeroes). However in these cases, the new bits these fields are extending into were actively used by the hardware for other purposes on previous platforms, which is why it's necessary to keep the existing pre-Xe3p definitions unchanged and create separate Xe3p ones that can be used only on the newer Xe3p platforms. You should make some mention of that in the commit message so it's clear why we're handling these a bit differently than a lot of other registers.
Agreed. Just updated the local v3 to make that clear.
Quoted 77 lines
Quoted 77 lines
v2:
- Keep definitions in the same line (i.e. without line continuation breaks) for better readability. (Jani)Bspec: 68868, 68872
Cc Jani Nikula <[email protected]>Signed-off-by Ravi Kumar Vodapalli <[email protected]>Signed-off-by Gustavo Sousa <[email protected]>--- drivers/gpu/drm/i915/display/skl_watermark.c | 16 +++++-- drivers/gpu/drm/i915/display/skl_watermark_regs.h | 52 ++++++++++++----------- 2 files changed, 40 insertions(+), 28 deletions(-)drivers/gpu/drm/i915/display/skl_watermark.c +12
-4@@ -3477,7 +3477,10 @@ void intel_dbuf_mdclk_cdclk_ratio_update(struct intel_display *display,if (!HAS_MBUS_JOINING (display))return ; -if (DISPLAY_VER (display) >=20 ) +if (DISPLAY_VER (display) >=35 ) +intel_de_rmw (display,MBUS_CTL ,XE3P_MBUS_TRANSLATION_THROTTLE_MIN_MASK , +XE3P_MBUS_TRANSLATION_THROTTLE_MIN (ratio -1 )); +else if (DISPLAY_VER (display) >=20 )intel_de_rmw (display,MBUS_CTL ,MBUS_TRANSLATION_THROTTLE_MIN_MASK ,MBUS_TRANSLATION_THROTTLE_MIN (ratio -1 ));@@ -3488,9 +3491,14 @@ void intel_dbuf_mdclk_cdclk_ratio_update(struct intel_display *display, ratio, str_yes_no(joined_mbus));for_each_dbuf_slice (display, slice) -intel_de_rmw (display,DBUF_CTL_S (slice), -DBUF_MIN_TRACKER_STATE_SERVICE_MASK , -DBUF_MIN_TRACKER_STATE_SERVICE (ratio -1 )); +if (DISPLAY_VER (display) >=35 ) +intel_de_rmw (display,DBUF_CTL_S (slice), +XE3P_DBUF_MIN_TRACKER_STATE_SERVICE_MASK , +XE3P_DBUF_MIN_TRACKER_STATE_SERVICE (ratio -1 )); +else +intel_de_rmw (display,DBUF_CTL_S (slice), +DBUF_MIN_TRACKER_STATE_SERVICE_MASK , +DBUF_MIN_TRACKER_STATE_SERVICE (ratio -1 )); }static void intel_dbuf_mdclk_min_tracker_update (struct intel_atomic_state *state)drivers/gpu/drm/i915/display/skl_watermark_regs.h +10
-10@@ -32,16 +32,18 @@#define MBUS_BBOX_CTL_S1 _MMIO(0x45040)#define MBUS_BBOX_CTL_S2 _MMIO(0x45044) -#define MBUS_CTL _MMIO(0x4438C) -#define MBUS_JOIN REG_BIT(31) -#define MBUS_HASHING_MODE_MASK REG_BIT(30) -#define MBUS_HASHING_MODE_2x2 REG_FIELD_PREP(MBUS_HASHING_MODE_MASK, 0) -#define MBUS_HASHING_MODE_1x4 REG_FIELD_PREP(MBUS_HASHING_MODE_MASK, 1) -#define MBUS_JOIN_PIPE_SELECT_MASK REG_GENMASK(28, 26) -#define MBUS_JOIN_PIPE_SELECT (pipe) REG_FIELD_PREP(MBUS_JOIN_PIPE_SELECT_MASK, pipe) -#define MBUS_JOIN_PIPE_SELECT_NONE MBUS_JOIN_PIPE_SELECT(7) -#define MBUS_TRANSLATION_THROTTLE_MIN_MASK REG_GENMASK(15, 13) -#define MBUS_TRANSLATION_THROTTLE_MIN (val) REG_FIELD_PREP(MBUS_TRANSLATION_THROTTLE_MIN_MASK, val) +#define MBUS_CTL _MMIO(0x4438C) +#define MBUS_JOIN REG_BIT(31) +#define MBUS_HASHING_MODE_MASK REG_BIT(30) +#define MBUS_HASHING_MODE_2x2 REG_FIELD_PREP(MBUS_HASHING_MODE_MASK, 0) +#define MBUS_HASHING_MODE_1x4 REG_FIELD_PREP(MBUS_HASHING_MODE_MASK, 1) +#define MBUS_JOIN_PIPE_SELECT_MASK REG_GENMASK(28, 26) +#define MBUS_JOIN_PIPE_SELECT (pipe) REG_FIELD_PREP(MBUS_JOIN_PIPE_SELECT_MASK, pipe) +#define MBUS_JOIN_PIPE_SELECT_NONE MBUS_JOIN_PIPE_SELECT(7) +#define MBUS_TRANSLATION_THROTTLE_MIN_MASK REG_GENMASK(15, 13) +#define MBUS_TRANSLATION_THROTTLE_MIN (val) REG_FIELD_PREP(MBUS_TRANSLATION_THROTTLE_MIN_MASK, val)
Quoted 8 lines
drivers/gpu/drm/i915/display/skl_watermark_regs.h line 46
Quoted 2 lines
drivers/gpu/drm/i915/display/skl_watermark_regs.h +2
-0+#define XE3P_MBUS_TRANSLATION_THROTTLE_MIN_MASK REG_GENMASK(16, 13) +#define XE3P_MBUS_TRANSLATION_THROTTLE_MIN (val) REG_FIELD_PREP(XE3P_MBUS_TRANSLATION_THROTTLE_MIN_MASK, val)Nitpick: I'm not sure if we're 100% consistent, but I feel like we usually sort bitfields based on their upper bound rather than their lower bound. So even though xe3p and pre-xe3p start at the same bit 13, the xe3p should probably be sorted first since it ends at a higher bit (16 vs 15).
Ack.
Thanks!
--
Gustavo Sousa
Quoted 58 lines
Quoted 29 lines
drivers/gpu/drm/i915/display/skl_watermark_regs.h +7
-14/* * The below are numbered starting from "S1" on gen11/gen12, but starting @@ -51,21 +53,23 @@* way things will be named by the hardware team going forward, plus it's more * consistent with how most of the rest of our registers are named. */ -#define _DBUF_CTL_S0 0x45008 -#define _DBUF_CTL_S1 0x44FE8 -#define _DBUF_CTL_S2 0x44300 -#define _DBUF_CTL_S3 0x44304 -#define DBUF_CTL_S (slice) _MMIO(_PICK(slice, \ - _DBUF_CTL_S0, \ - _DBUF_CTL_S1, \ - _DBUF_CTL_S2, \ - _DBUF_CTL_S3)) -#define DBUF_POWER_REQUEST REG_BIT(31) -#define DBUF_POWER_STATE REG_BIT(30) -#define DBUF_TRACKER_STATE_SERVICE_MASK REG_GENMASK(23, 19) -#define DBUF_TRACKER_STATE_SERVICE (x) REG_FIELD_PREP(DBUF_TRACKER_STATE_SERVICE_MASK, x) -#define DBUF_MIN_TRACKER_STATE_SERVICE_MASK REG_GENMASK(18, 16)/* ADL-P+ */ +#define _DBUF_CTL_S0 0x45008 +#define _DBUF_CTL_S1 0x44FE8 +#define _DBUF_CTL_S2 0x44300 +#define _DBUF_CTL_S3 0x44304 +#define DBUF_CTL_S (slice) _MMIO(_PICK(slice, \ + _DBUF_CTL_S0, \ + _DBUF_CTL_S1, \drivers/gpu/drm/i915/display/skl_watermark_regs.h line 72
Quoted 10 lines
drivers/gpu/drm/i915/display/skl_watermark_regs.h +9
-0+ _DBUF_CTL_S2, \ + _DBUF_CTL_S3)) +#define DBUF_POWER_REQUEST REG_BIT(31) +#define DBUF_POWER_STATE REG_BIT(30) +#define DBUF_TRACKER_STATE_SERVICE_MASK REG_GENMASK(23, 19) +#define DBUF_TRACKER_STATE_SERVICE (x) REG_FIELD_PREP(DBUF_TRACKER_STATE_SERVICE_MASK, x) +#define DBUF_MIN_TRACKER_STATE_SERVICE_MASK REG_GENMASK(18, 16)/* ADL-P+ */ #define DBUF_MIN_TRACKER_STATE_SERVICE (x) REG_FIELD_PREP(DBUF_MIN_TRACKER_STATE_SERVICE_MASK, x)/* ADL-P+ */ +#define XE3P_DBUF_MIN_TRACKER_STATE_SERVICE_MASK REG_GENMASK(20, 16) +#define XE3P_DBUF_MIN_TRACKER_STATE_SERVICE (x) REG_FIELD_PREP(XE3P_DBUF_MIN_TRACKER_STATE_SERVICE_MASK, x)Same here.
Matt
Quoted 7 lines
drivers/gpu/drm/i915/display/skl_watermark_regs.h +0
-0#define MTL_LATENCY_LP0_LP1 _MMIO(0x45780)#define MTL_LATENCY_LP2_LP3 _MMIO(0x45784)Signature · 1 line
2.51.0Signature · 4 lines
Matt Roper Graphics Software Engineer Linux GPU Platform Enablement Intel Corporation
PATCH v2 14/32 drm/i915/wm: Reorder adjust_wm_latency() for Xe3_LPD
In reply to Gustavo SousaIn an upcoming change related to Xe3p_LPD, we will need to (i) update wm[0] in adjust_wm_latency() and (ii) do the same increase_wm_latency() that is currently done when (wm[0] == 0).
Because make_wm_latency_monotonic() depends on wm[0], part (i) needs to be done before it gets called. In order to keep (i) and (ii) as a contiguous logical sequence, let's reorder adjust_wm_latency(), making make_wm_latency_monotonic() the last thing to be done.
Also take this opportunity to simplify the code by doing the call to increase_wm_latency() only once.
--- drivers/gpu/drm/i915/display/skl_watermark.c | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-)
drivers/gpu/drm/i915/display/skl_watermark.c +8 -4
@@ -3213,14 +3213,13 @@ static void adjust_wm_latency(struct intel_display *display) {u16 *wm = display->wm.skl_latency; +int inc =0 ;if (display->platform.dg2)multiply_wm_latency (display,2 );sanitize_wm_latency (display); -make_wm_latency_monotonic (display); -/* * WaWmMemoryReadLatency *
@@ -3229,7 +3228,7 @@ adjust_wm_latency(struct intel_display *display)* from the punit when level 0 response data is 0us. */ if (wm[0 ] ==0 ) -increase_wm_latency (display,wm_read_latency (display)); + inc +=wm_read_latency (display);/* * WA Level-0 adjustment for 16Gb+ DIMMs: SKL+
@@ -3238,7 +3237,12 @@ adjust_wm_latency(struct intel_display *display)* to avoid any underrun. */ if (need_16gb_dimm_wa (display)) -increase_wm_latency (display,1 ); + inc +=1 ; + +if (inc) +increase_wm_latency (display, inc); + +make_wm_latency_monotonic (display); }static void mtl_read_wm_latency (struct intel_display *display)
Signature · 1 line
2.51.0
Re: [PATCH v2 14/32] drm/i915/wm: Reorder adjust_wm_latency() for Xe3_LPD
Quoted 9 lines · Gustavo Sousa
In an upcoming change related to
Xe3p_LPD, we will need to (i) update wm[0] inadjust_wm_latency()and (ii) do the sameincrease_wm_latency()that is currently done when (wm[0] == 0).Because
make_wm_latency_monotonic()depends on wm[0], part (i) needs to be done before it gets called. In order to keep (i) and (ii) as a contiguous logical sequence, let's reorderadjust_wm_latency(), makingmake_wm_latency_monotonic()the last thing to be done.
Quoted 5 lines
Also take this opportunity to simplify the code by doing the call to
increase_wm_latency()only once.Cc Ville Syrjälä <[email protected]>Signed-off-by Gustavo Sousa <[email protected]>
Quoted 51 lines
--- drivers/gpu/drm/i915/display/skl_watermark.c | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-)drivers/gpu/drm/i915/display/skl_watermark.c +8
-4@@ -3213,14 +3213,13 @@ static void adjust_wm_latency(struct intel_display *display) {u16 *wm = display->wm.skl_latency; +int inc =0 ;if (display->platform.dg2)multiply_wm_latency (display,2 );sanitize_wm_latency (display); -make_wm_latency_monotonic (display); -/* * WaWmMemoryReadLatency * @@ -3229,7 +3228,7 @@ adjust_wm_latency(struct intel_display *display)* from the punit when level 0 response data is 0us. */ if (wm[0 ] ==0 ) -increase_wm_latency (display,wm_read_latency (display)); + inc +=wm_read_latency (display);/* * WA Level-0 adjustment for 16Gb+ DIMMs: SKL+ @@ -3238,7 +3237,12 @@ adjust_wm_latency(struct intel_display *display)* to avoid any underrun. */ if (need_16gb_dimm_wa (display)) -increase_wm_latency (display,1 ); + inc +=1 ; + +if (inc) +increase_wm_latency (display, inc); + +make_wm_latency_monotonic (display); }static void mtl_read_wm_latency (struct intel_display *display)Signature · 2 lines
-- 2.51.0
Signature · 4 lines
Matt Roper Graphics Software Engineer Linux GPU Platform Enablement Intel Corporation
Re: [PATCH v2 14/32] drm/i915/wm: Reorder adjust_wm_latency() for Xe3_LPD
In reply to Gustavo SousaQuoted 25 lines · Gustavo Sousa
In an upcoming change related to
Xe3p_LPD, we will need to (i) update wm[0] inadjust_wm_latency()and (ii) do the sameincrease_wm_latency()that is currently done when (wm[0] == 0).Because
make_wm_latency_monotonic()depends on wm[0], part (i) needs to be done before it gets called. In order to keep (i) and (ii) as a contiguous logical sequence, let's reorderadjust_wm_latency(), makingmake_wm_latency_monotonic()the last thing to be done.Also take this opportunity to simplify the code by doing the call to
increase_wm_latency()only once.Cc Ville Syrjälä <[email protected]>Signed-off-by Gustavo Sousa <[email protected]>--- drivers/gpu/drm/i915/display/skl_watermark.c | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-)drivers/gpu/drm/i915/display/skl_watermark.c +0
-0@@ -3213,14 +3213,13 @@ static void adjust_wm_latency(struct intel_display *display) {
drivers/gpu/drm/i915/display/skl_watermark.c static void · line 3223
Quoted 10 lines
drivers/gpu/drm/i915/display/skl_watermark.c +1
-2u16 *wm = display->wm.skl_latency; +int inc =0 ;if (display->platform.dg2)multiply_wm_latency (display,2 );sanitize_wm_latency (display); -make_wm_latency_monotonic (display); -
I was thinking that by doing this early we avoid potentially papering over our own bugs in the later adjustments. But Windows does appear to do this after the read latency adjustment.
And it looks like Windows actually stopped doing this for xe3 and now it rejects non-monotonic values. And it also does that after the read latency adjustment.
So I guess what we want to do is move this later, only call it for pre-xe3, and add another step after it to validate that the latencies are indeed monotonic.
Quoted 13 lines
drivers/gpu/drm/i915/display/skl_watermark.c +1
-1/* * WaWmMemoryReadLatency * @@ -3229,7 +3228,7 @@ adjust_wm_latency(struct intel_display *display)* from the punit when level 0 response data is 0us. */ if (wm[0 ] ==0 ) -increase_wm_latency (display,wm_read_latency (display)); + inc +=wm_read_latency (display);/* * WA Level-0 adjustment for 16Gb+ DIMMs: SKL+
drivers/gpu/drm/i915/display/skl_watermark.c adjust_wm_latency(struct intel_display *display) · line 3243
Quoted 8 lines
drivers/gpu/drm/i915/display/skl_watermark.c +4
-1@@ -3238,7 +3237,12 @@ adjust_wm_latency(struct intel_display *display)* to avoid any underrun. */ if (need_16gb_dimm_wa (display)) -increase_wm_latency (display,1 ); + inc +=1 ; + +if (inc) +increase_wm_latency (display, inc);
I don't see that variable being helpful in any real way. Just makes the function more complicated for no good reason. It also has nothing to do with the rest of this patch.
Quoted 8 lines
drivers/gpu/drm/i915/display/skl_watermark.c +2
-0+ +make_wm_latency_monotonic (display); }static void mtl_read_wm_latency (struct intel_display *display)Signature · 2 lines
-- 2.51.0
Signature · 2 lines
Ville Syrjälä Intel
Re: [PATCH v2 14/32] drm/i915/wm: Reorder adjust_wm_latency() for Xe3_LPD
Quoted 32 lines · Ville Syrjälä
Quoted 31 lines · Gustavo Sousa
In an upcoming change related to
Xe3p_LPD, we will need to (i) update wm[0] inadjust_wm_latency()and (ii) do the sameincrease_wm_latency()that is currently done when (wm[0] == 0).Because
make_wm_latency_monotonic()depends on wm[0], part (i) needs to be done before it gets called. In order to keep (i) and (ii) as a contiguous logical sequence, let's reorderadjust_wm_latency(), makingmake_wm_latency_monotonic()the last thing to be done.Also take this opportunity to simplify the code by doing the call to
increase_wm_latency()only once.Cc Ville Syrjälä <[email protected]>Signed-off-by Gustavo Sousa <[email protected]>--- drivers/gpu/drm/i915/display/skl_watermark.c | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-)drivers/gpu/drm/i915/display/skl_watermark.c +1
-0@@ -3213,14 +3213,13 @@ static void adjust_wm_latency(struct intel_display *display) {u16 *wm = display->wm.skl_latency; +int inc =0 ;if (display->platform.dg2)multiply_wm_latency (display,2 );
Quoted 8 lines
drivers/gpu/drm/i915/display/skl_watermark.c static void · line 3223
Quoted 4 lines
drivers/gpu/drm/i915/display/skl_watermark.c +0
-2sanitize_wm_latency (display); -make_wm_latency_monotonic (display); -I was thinking that by doing this early we avoid potentially papering over our own bugs in the later adjustments. But Windows does appear to do this after the read latency adjustment.
Hmm, I suppose it doesn't really matter whether it's before or after since the read latency adjustment applies to all wm levels. So I think I still prefer to keep it early to avoid papering over our own bugs.
Quoted 47 lines
And it looks like Windows actually stopped doing this for xe3 and now it rejects non-monotonic values. And it also does that after the read latency adjustment.
So I guess what we want to do is move this later, only call it for pre-xe3, and add another step after it to validate that the latencies are indeed monotonic.
Quoted 13 lines
drivers/gpu/drm/i915/display/skl_watermark.c +1
-1/* * WaWmMemoryReadLatency * @@ -3229,7 +3228,7 @@ adjust_wm_latency(struct intel_display *display)* from the punit when level 0 response data is 0us. */ if (wm[0 ] ==0 ) -increase_wm_latency (display,wm_read_latency (display)); + inc +=wm_read_latency (display);/* * WA Level-0 adjustment for 16Gb+ DIMMs: SKL+ drivers/gpu/drm/i915/display/skl_watermark.c adjust_wm_latency(struct intel_display *display) · line 3243
Quoted 8 lines
drivers/gpu/drm/i915/display/skl_watermark.c +4
-1@@ -3238,7 +3237,12 @@ adjust_wm_latency(struct intel_display *display)* to avoid any underrun. */ if (need_16gb_dimm_wa (display)) -increase_wm_latency (display,1 ); + inc +=1 ; + +if (inc) +increase_wm_latency (display, inc);I don't see that variable being helpful in any real way. Just makes the function more complicated for no good reason. It also has nothing to do with the rest of this patch.
Quoted 8 lines
drivers/gpu/drm/i915/display/skl_watermark.c +2
-0+ +make_wm_latency_monotonic (display); }static void mtl_read_wm_latency (struct intel_display *display)Signature · 2 lines
-- 2.51.0Signature · 2 lines
Ville Syrjälä Intel
Signature · 2 lines
Ville Syrjälä Intel
Re: [PATCH v2 14/32] drm/i915/wm: Reorder adjust_wm_latency() for Xe3_LPD
Quoting Ville Syrjälä (2025-10-29 19:36:14-03:00)
Quoted 42 lines · Ville Syrjälä
Quoted 32 lines · Gustavo Sousa
Quoted 31 lines
In an upcoming change related to
Xe3p_LPD, we will need to (i) update wm[0] inadjust_wm_latency()and (ii) do the sameincrease_wm_latency()that is currently done when (wm[0] == 0).Because
make_wm_latency_monotonic()depends on wm[0], part (i) needs to be done before it gets called. In order to keep (i) and (ii) as a contiguous logical sequence, let's reorderadjust_wm_latency(), makingmake_wm_latency_monotonic()the last thing to be done.Also take this opportunity to simplify the code by doing the call to
increase_wm_latency()only once.Cc Ville Syrjälä <[email protected]>Signed-off-by Gustavo Sousa <[email protected]>--- drivers/gpu/drm/i915/display/skl_watermark.c | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-)drivers/gpu/drm/i915/display/skl_watermark.c +1
-0@@ -3213,14 +3213,13 @@ static void adjust_wm_latency(struct intel_display *display) {u16 *wm = display->wm.skl_latency; +int inc =0 ;if (display->platform.dg2)multiply_wm_latency (display,2 );Quoted 8 lines
drivers/gpu/drm/i915/display/skl_watermark.c static void · line 3223
Quoted 4 lines
drivers/gpu/drm/i915/display/skl_watermark.c +0
-2sanitize_wm_latency (display); -make_wm_latency_monotonic (display); -I was thinking that by doing this early we avoid potentially papering over our own bugs in the later adjustments. But Windows does appear to do this after the read latency adjustment.
Quoted 3 lines
Hmm, I suppose it doesn't really matter whether it's before or after since the read latency adjustment applies to all wm levels. So I think I still prefer to keep it early to avoid papering over our own bugs.
Okay. In this case, I guess I can drop this patch then and go back to the original approach + moving the assignment of "wm[0] = 0" to be done earlier.
Quoted 9 lines
Quoted 9 lines
And it looks like Windows actually stopped doing this for xe3 and now it rejects non-monotonic values. And it also does that after the read latency adjustment.
So I guess what we want to do is move this later, only call it for pre-xe3, and add another step after it to validate that the latencies are indeed monotonic.
I guess in our case, we would reject them in sanitize_wm_latency(), making everything after the invalid level (i.e. wm[level] < wm[level - 1]) be forced to zero, right?
In summary, with keeping make_wm_latency_monotonic() early, something like this?
|diff --git a/drivers/gpu/drm/i915/display/skl_watermark.c b/drivers/gpu/drm/i915/display/skl_watermark.c
|index c141d575009f..6cf1565dcefd 100644
|--- a/drivers/gpu/drm/i915/display/skl_watermark.c
|+++ b/drivers/gpu/drm/i915/display/skl_watermark.c
|@@ -3183,11 +3183,16 @@ static void sanitize_wm_latency(struct intel_display *display)
| int level, num_levels = display->wm.num_levels;
|
| /*
|- * If a level n (n > 1) has a 0us latency, all levels m (m >= n)
|- * need to be disabled. We make sure to sanitize the values out
|- * of the punit to satisfy this requirement.
|+ * Two types of sanitization are done here:
|+ * 1) If a level n (n > 1) has a 0us latency, all levels m (m >= n)
|+ * need to be disabled. We make sure to sanitize the values out of
|+ * the punit to satisfy this requirement.
|+ * 2) For Xe3 onward, only accept monotonic ranges.
| */
| for (level = 1; level < num_levels; level++) {
|+ if (DISPLAY_VER(display) >= 30 && wm[level] < wm[level - 1])
|+ wm[level] = 0;
|+
| if (wm[level] == 0)
| break;
| }
|@@ -3201,6 +3206,9 @@ static void make_wm_latency_monotonic(struct intel_display *display)
| u16 *wm = display->wm.skl_latency;
| int level, num_levels = display->wm.num_levels;
|
|+ if (DISPLAY_VER(display) < 30)
|+ return;
|+
| for (level = 1; level < num_levels; level++) {
| if (wm[level] == 0)
| break;If so, I could include this patch as part of this series to avoid conflicts or keep it as a separate patch...
--
Gustavo Sousa
Quoted 43 lines
Quoted 39 lines
Quoted 14 lines
drivers/gpu/drm/i915/display/skl_watermark.c +1
-1/* * WaWmMemoryReadLatency * @@ -3229,7 +3228,7 @@ adjust_wm_latency(struct intel_display *display)* from the punit when level 0 response data is 0us. */ if (wm[0 ] ==0 ) -increase_wm_latency (display,wm_read_latency (display)); + inc +=wm_read_latency (display);/* * WA Level-0 adjustment for 16Gb+ DIMMs: SKL+ drivers/gpu/drm/i915/display/skl_watermark.c adjust_wm_latency(struct intel_display *display) · line 3243
Quoted 8 lines
drivers/gpu/drm/i915/display/skl_watermark.c +4
-1@@ -3238,7 +3237,12 @@ adjust_wm_latency(struct intel_display *display)* to avoid any underrun. */ if (need_16gb_dimm_wa (display)) -increase_wm_latency (display,1 ); + inc +=1 ; + +if (inc) +increase_wm_latency (display, inc);I don't see that variable being helpful in any real way. Just makes the function more complicated for no good reason. It also has nothing to do with the rest of this patch.
Quoted 8 lines
drivers/gpu/drm/i915/display/skl_watermark.c +2
-0+ +make_wm_latency_monotonic (display); }static void mtl_read_wm_latency (struct intel_display *display)Signature · 2 lines
-- 2.51.0Signature · 2 lines
Ville Syrjälä IntelSignature · 2 lines
Ville Syrjälä Intel
Re: [PATCH v2 14/32] drm/i915/wm: Reorder adjust_wm_latency() for Xe3_LPD
Quoted 80 lines · Gustavo Sousa
Quoting Ville Syrjälä (2025-10-29 19:36:14-03:00)
Quoted 42 lines · Ville Syrjälä
Quoted 32 lines · Gustavo Sousa
Quoted 31 lines
In an upcoming change related to
Xe3p_LPD, we will need to (i) update wm[0] inadjust_wm_latency()and (ii) do the sameincrease_wm_latency()that is currently done when (wm[0] == 0).Because
make_wm_latency_monotonic()depends on wm[0], part (i) needs to be done before it gets called. In order to keep (i) and (ii) as a contiguous logical sequence, let's reorderadjust_wm_latency(), makingmake_wm_latency_monotonic()the last thing to be done.Also take this opportunity to simplify the code by doing the call to
increase_wm_latency()only once.Cc Ville Syrjälä <[email protected]>Signed-off-by Gustavo Sousa <[email protected]>--- drivers/gpu/drm/i915/display/skl_watermark.c | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-)drivers/gpu/drm/i915/display/skl_watermark.c +1
-0@@ -3213,14 +3213,13 @@ static void adjust_wm_latency(struct intel_display *display) {u16 *wm = display->wm.skl_latency; +int inc =0 ;if (display->platform.dg2)multiply_wm_latency (display,2 );Quoted 8 lines
drivers/gpu/drm/i915/display/skl_watermark.c static void · line 3223
Quoted 4 lines
drivers/gpu/drm/i915/display/skl_watermark.c +0
-2sanitize_wm_latency (display); -make_wm_latency_monotonic (display); -I was thinking that by doing this early we avoid potentially papering over our own bugs in the later adjustments. But Windows does appear to do this after the read latency adjustment.
Quoted 3 lines
Hmm, I suppose it doesn't really matter whether it's before or after since the read latency adjustment applies to all wm levels. So I think I still prefer to keep it early to avoid papering over our own bugs.
Okay. In this case, I guess I can drop this patch then and go back to the original approach + moving the assignment of "wm[0] = 0" to be done earlier.
Quoted 9 lines
Quoted 9 lines
And it looks like Windows actually stopped doing this for xe3 and now it rejects non-monotonic values. And it also does that after the read latency adjustment.
So I guess what we want to do is move this later, only call it for pre-xe3, and add another step after it to validate that the latencies are indeed monotonic.
I guess in our case, we would reject them in
sanitize_wm_latency(), making everything after the invalid level (i.e. wm[level] < wm[level - 1]) be forced to zero, right?In summary, with keeping
make_wm_latency_monotonic()early, something like this?|diff --git a/drivers/gpu/drm/i915/display/skl_watermark.c b/drivers/gpu/drm/i915/display/skl_watermark.c |index c141d575009f..6cf1565dcefd 100644 |--- a/drivers/gpu/drm/i915/display/skl_watermark.c |+++ b/drivers/gpu/drm/i915/display/skl_watermark.c |@@ -3183,11 +3183,16 @@ static void sanitize_wm_latency(struct intel_display *display) | int level, num_levels = display->wm.num_levels; | | /* |- * If a level n (n > 1) has a 0us latency, all levels m (m >= n) |- * need to be disabled. We make sure to sanitize the values out |- * of the punit to satisfy this requirement. |+ * Two types of sanitization are done here:
Quoted 8 lines
|+ * 1) If a level n (n > 1) has a 0us latency, all levels m (m >= n)
|+ * need to be disabled. We make sure to sanitize the values out of
|+ * the punit to satisfy this requirement.
|+ * 2) For Xe3 onward, only accept monotonic ranges.
| */
| for (level = 1; level < num_levels; level++) {
|+ if (DISPLAY_VER(display) >= 30 && wm[level] < wm[level - 1])
|+ wm[level] = 0;I don't think we want to sweep these under the rug.
IMO we should simply not call make_wm_latency_monotonic() on xe3+, and do some kind of drm_WARN(!is_wm_latency_monotonic()) once we're done with all the adjustments.
Quoted 64 lines
|+ | if (wm[level] == 0) | break; | } |@@ -3201,6 +3206,9 @@ static void make_wm_latency_monotonic(struct intel_display *display) | u16 *wm = display->wm.skl_latency; | int level, num_levels = display->wm.num_levels; | |+ if (DISPLAY_VER(display) < 30) |+ return; |+ | for (level = 1; level < num_levels; level++) { | if (wm[level] == 0) | break;If so, I could include this patch as part of this series to avoid conflicts or keep it as a separate patch...
--
Gustavo SousaQuoted 43 lines
Quoted 39 lines
Quoted 14 lines
drivers/gpu/drm/i915/display/skl_watermark.c +1
-1/* * WaWmMemoryReadLatency * @@ -3229,7 +3228,7 @@ adjust_wm_latency(struct intel_display *display)* from the punit when level 0 response data is 0us. */ if (wm[0 ] ==0 ) -increase_wm_latency (display,wm_read_latency (display)); + inc +=wm_read_latency (display);/* * WA Level-0 adjustment for 16Gb+ DIMMs: SKL+ drivers/gpu/drm/i915/display/skl_watermark.c adjust_wm_latency(struct intel_display *display) · line 3243
Quoted 8 lines
drivers/gpu/drm/i915/display/skl_watermark.c +4
-1@@ -3238,7 +3237,12 @@ adjust_wm_latency(struct intel_display *display)* to avoid any underrun. */ if (need_16gb_dimm_wa (display)) -increase_wm_latency (display,1 ); + inc +=1 ; + +if (inc) +increase_wm_latency (display, inc);I don't see that variable being helpful in any real way. Just makes the function more complicated for no good reason. It also has nothing to do with the rest of this patch.
Quoted 8 lines
drivers/gpu/drm/i915/display/skl_watermark.c +2
-0+ +make_wm_latency_monotonic (display); }static void mtl_read_wm_latency (struct intel_display *display)Signature · 2 lines
-- 2.51.0Signature · 2 lines
Ville Syrjälä IntelSignature · 2 lines
Ville Syrjälä Intel
Signature · 2 lines
Ville Syrjälä Intel
Re: [PATCH v2 14/32] drm/i915/wm: Reorder adjust_wm_latency() for Xe3_LPD
In reply to Ville SyrjäläQuoting Ville Syrjälä (2025-10-29 19:22:01-03:00)
Quoted 59 lines · Gustavo Sousa
Quoted 25 lines
In an upcoming change related to
Xe3p_LPD, we will need to (i) update wm[0] inadjust_wm_latency()and (ii) do the sameincrease_wm_latency()that is currently done when (wm[0] == 0).Because
make_wm_latency_monotonic()depends on wm[0], part (i) needs to be done before it gets called. In order to keep (i) and (ii) as a contiguous logical sequence, let's reorderadjust_wm_latency(), makingmake_wm_latency_monotonic()the last thing to be done.Also take this opportunity to simplify the code by doing the call to
increase_wm_latency()only once.Cc Ville Syrjälä <[email protected]>Signed-off-by Gustavo Sousa <[email protected]>--- drivers/gpu/drm/i915/display/skl_watermark.c | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-)drivers/gpu/drm/i915/display/skl_watermark.c +0
-0@@ -3213,14 +3213,13 @@ static void adjust_wm_latency(struct intel_display *display) {drivers/gpu/drm/i915/display/skl_watermark.c static void · line 3223
Quoted 10 lines
drivers/gpu/drm/i915/display/skl_watermark.c +1
-2u16 *wm = display->wm.skl_latency; +int inc =0 ;if (display->platform.dg2)multiply_wm_latency (display,2 );sanitize_wm_latency (display); -make_wm_latency_monotonic (display); -I was thinking that by doing this early we avoid potentially papering over our own bugs in the later adjustments. But Windows does appear to do this after the read latency adjustment.
And it looks like Windows actually stopped doing this for xe3 and now it rejects non-monotonic values. And it also does that after the read latency adjustment.
So I guess what we want to do is move this later, only call it for pre-xe3, and add another step after it to validate that the latencies are indeed monotonic.
Quoted 10 lines
drivers/gpu/drm/i915/display/skl_watermark.c +1
-1/* * WaWmMemoryReadLatency * @@ -3229,7 +3228,7 @@ adjust_wm_latency(struct intel_display *display)* from the punit when level 0 response data is 0us. */ if (wm[0 ] ==0 ) -increase_wm_latency (display,wm_read_latency (display)); + inc +=wm_read_latency (display);
Quoted 14 lines
drivers/gpu/drm/i915/display/skl_watermark.c adjust_wm_latency(struct intel_display *display) · line 3243
Quoted 11 lines
drivers/gpu/drm/i915/display/skl_watermark.c +4
-1/* * WA Level-0 adjustment for 16Gb+ DIMMs: SKL+ @@ -3238,7 +3237,12 @@ adjust_wm_latency(struct intel_display *display)* to avoid any underrun. */ if (need_16gb_dimm_wa (display)) -increase_wm_latency (display,1 ); + inc +=1 ; + +if (inc) +increase_wm_latency (display, inc);I don't see that variable being helpful in any real way. Just makes the function more complicated for no good reason.
I liked the fact that we would be calling increase_wm_latency() only once... Not a big deal though.
--
Gustavo Sousa
Quoted 14 lines
It also has nothing to do with the rest of this patch.
Quoted 8 lines
drivers/gpu/drm/i915/display/skl_watermark.c +2
-0+ +make_wm_latency_monotonic (display); }static void mtl_read_wm_latency (struct intel_display *display)Signature · 2 lines
-- 2.51.0Signature · 2 lines
Ville Syrjälä Intel
PATCH v2 15/32 drm/i915/xe3p_lpd: Always apply level-0 watermark adjustment
In reply to Gustavo SousaWhen reading memory latencies for watermark calculations, previous display releases instructed to apply an adjustment of adding a certain value (e.g. 6us) to all levels when the level 0's memory latency read from hardware was zero.
For Xe3p_LPD, the instruction is to always use 6us for level 0 and to add that value to the other levels. Update adjust_wm_latency() accordingly.
While previously the adjustment was considered a workaround by the driver, for Xe3p_LPD that is part of the formal specification. So, let's make sure that we differentiate those two in the driver code, even if there is a bit of redundancy with "inc += wm_read_latency(display)" appearing twice in the code.
v2:
- Rebased after addition of prep patch "drm/i915/wm: Reorder adjust_wm_latency() for Xe3_LPD".
Bspec: 68986, 69126
--- drivers/gpu/drm/i915/display/skl_watermark.c | 25 +++++++++++++++++-------- 1 file changed, 17 insertions(+), 8 deletions(-)
drivers/gpu/drm/i915/display/skl_watermark.c +17 -8
@@ -3220,15 +3220,24 @@ adjust_wm_latency(struct intel_display *display)sanitize_wm_latency (display); -/* -* WaWmMemoryReadLatency -* -* punit doesn't take into account the read latency so we need -* to add proper adjustment to each valid level we retrieve -* from the punit when level 0 response data is 0us. -*/ -if (wm[0 ] ==0 ) +if (DISPLAY_VER (display) >=35 ) { +/* +* Xe3p asks to ignore wm[0] read from the register and always +* use the adjustment that adds the read latency to all valid +* latency values. +*/ + wm[0 ] =0 ; inc +=wm_read_latency (display); + }else if (wm[0 ] ==0 ) { +/* +* WaWmMemoryReadLatency +* +* punit doesn't take into account the read latency so we need +* to add proper adjustment to each valid level we retrieve +* from the punit when level 0 response data is 0us. +*/ + inc +=wm_read_latency (display); + }/* * WA Level-0 adjustment for 16Gb+ DIMMs: SKL+
Signature · 1 line
2.51.0
Re: [PATCH v2 15/32] drm/i915/xe3p_lpd: Always apply level-0 watermark adjustment
Quoted 51 lines · Gustavo Sousa
When reading memory latencies for watermark calculations, previous display releases instructed to apply an adjustment of adding a certain value (e.g. 6us) to all levels when the level 0's memory latency read from hardware was zero.
For
Xe3p_LPD, the instruction is to always use 6us for level 0 and to add that value to the other levels. Updateadjust_wm_latency()accordingly.While previously the adjustment was considered a workaround by the driver, for
Xe3p_LPDthat is part of the formal specification. So, let's make sure that we differentiate those two in the driver code, even if there is a bit of redundancy with "inc +=wm_read_latency(display)" appearing twice in the code.v2:
- Rebased after addition of prep patch "drm/i915/wm: Reorderadjust_wm_latency()forXe3_LPD".Bspec: 68986, 69126
Cc Matt Atwood <[email protected]>Cc Ville Syrjälä <[email protected]>Signed-off-by Gustavo Sousa <[email protected]>--- drivers/gpu/drm/i915/display/skl_watermark.c | 25 +++++++++++++++++-------- 1 file changed, 17 insertions(+), 8 deletions(-)drivers/gpu/drm/i915/display/skl_watermark.c +7
-8@@ -3220,15 +3220,24 @@ adjust_wm_latency(struct intel_display *display)sanitize_wm_latency (display); -/* -* WaWmMemoryReadLatency -* -* punit doesn't take into account the read latency so we need -* to add proper adjustment to each valid level we retrieve -* from the punit when level 0 response data is 0us. -*/ -if (wm[0 ] ==0 ) +if (DISPLAY_VER (display) >=35 ) { +/* +* Xe3p asks to ignore wm[0] read from the register and always +* use the adjustment that adds the read latency to all valid +* latency values. +*/ + wm[0 ] =0 ; inc +=wm_read_latency (display);
drivers/gpu/drm/i915/display/skl_watermark.c adjust_wm_latency(struct intel_display *display) · line 3240
Quoted 10 lines
drivers/gpu/drm/i915/display/skl_watermark.c +10
-0+ }else if (wm[0 ] ==0 ) { +/* +* WaWmMemoryReadLatency +* +* punit doesn't take into account the read latency so we need +* to add proper adjustment to each valid level we retrieve +* from the punit when level 0 response data is 0us. +*/ + inc +=wm_read_latency (display); + }
Wouldn't it be simpler to just have a separate
/*
* Xe3p and beyond should ignore level 0's reported latency and
* always apply WaWmMemoryReadLatency logic.
*/
if (DISPLAY_VER(display) >= 35)
wm[0] = 0;and leave the rest of the code unchanged?
Either way, matches the spec so
Matt
Quoted 7 lines
drivers/gpu/drm/i915/display/skl_watermark.c +0
-0/* * WA Level-0 adjustment for 16Gb+ DIMMs: SKL+ Signature · 1 line
2.51.0
Signature · 4 lines
Matt Roper Graphics Software Engineer Linux GPU Platform Enablement Intel Corporation
Re: [PATCH v2 15/32] drm/i915/xe3p_lpd: Always apply level-0 watermark adjustment
Quoted 65 lines · Matt Roper
Quoted 51 lines · Gustavo Sousa
When reading memory latencies for watermark calculations, previous display releases instructed to apply an adjustment of adding a certain value (e.g. 6us) to all levels when the level 0's memory latency read from hardware was zero.
For
Xe3p_LPD, the instruction is to always use 6us for level 0 and to add that value to the other levels. Updateadjust_wm_latency()accordingly.While previously the adjustment was considered a workaround by the driver, for
Xe3p_LPDthat is part of the formal specification. So, let's make sure that we differentiate those two in the driver code, even if there is a bit of redundancy with "inc +=wm_read_latency(display)" appearing twice in the code.v2:
- Rebased after addition of prep patch "drm/i915/wm: Reorderadjust_wm_latency()forXe3_LPD".Bspec: 68986, 69126
Cc Matt Atwood <[email protected]>Cc Ville Syrjälä <[email protected]>Signed-off-by Gustavo Sousa <[email protected]>--- drivers/gpu/drm/i915/display/skl_watermark.c | 25 +++++++++++++++++-------- 1 file changed, 17 insertions(+), 8 deletions(-)drivers/gpu/drm/i915/display/skl_watermark.c +7
-8@@ -3220,15 +3220,24 @@ adjust_wm_latency(struct intel_display *display)sanitize_wm_latency (display); -/* -* WaWmMemoryReadLatency -* -* punit doesn't take into account the read latency so we need -* to add proper adjustment to each valid level we retrieve -* from the punit when level 0 response data is 0us. -*/ -if (wm[0 ] ==0 ) +if (DISPLAY_VER (display) >=35 ) { +/* +* Xe3p asks to ignore wm[0] read from the register and always +* use the adjustment that adds the read latency to all valid +* latency values. +*/ + wm[0 ] =0 ; inc +=wm_read_latency (display);drivers/gpu/drm/i915/display/skl_watermark.c adjust_wm_latency(struct intel_display *display) · line 3240
Quoted 10 lines
drivers/gpu/drm/i915/display/skl_watermark.c +10
-0+ }else if (wm[0 ] ==0 ) { +/* +* WaWmMemoryReadLatency +* +* punit doesn't take into account the read latency so we need +* to add proper adjustment to each valid level we retrieve +* from the punit when level 0 response data is 0us. +*/ + inc +=wm_read_latency (display); + }Wouldn't it be simpler to just have a separate
Quoted 8 lines
/* * Xe3p and beyond should ignore level 0's reported latency and * always apply WaWmMemoryReadLatency logic. */ if (DISPLAY_VER(display) >= 35) wm[0] = 0;and leave the rest of the code unchanged?
That, and I think just stuff it into sanitize_wm_latency() so that the bogus value gets nuked before we use it for anything.
Quoted 21 lines
Either way, matches the spec so
Reviewed-by Matt Roper <[email protected]>Matt
Quoted 7 lines
drivers/gpu/drm/i915/display/skl_watermark.c +0
-0/* * WA Level-0 adjustment for 16Gb+ DIMMs: SKL+ Signature · 1 line
2.51.0Signature · 4 lines
Matt Roper Graphics Software Engineer Linux GPU Platform Enablement Intel Corporation
Signature · 2 lines
Ville Syrjälä Intel
Re: [PATCH v2 15/32] drm/i915/xe3p_lpd: Always apply level-0 watermark adjustment
Quoting Ville Syrjälä (2025-10-29 19:39:47-03:00)
Quoted 73 lines · Matt Roper
Quoted 72 lines · Gustavo Sousa
Quoted 51 lines
When reading memory latencies for watermark calculations, previous display releases instructed to apply an adjustment of adding a certain value (e.g. 6us) to all levels when the level 0's memory latency read from hardware was zero.
For
Xe3p_LPD, the instruction is to always use 6us for level 0 and to add that value to the other levels. Updateadjust_wm_latency()accordingly.While previously the adjustment was considered a workaround by the driver, for
Xe3p_LPDthat is part of the formal specification. So, let's make sure that we differentiate those two in the driver code, even if there is a bit of redundancy with "inc +=wm_read_latency(display)" appearing twice in the code.v2:
- Rebased after addition of prep patch "drm/i915/wm: Reorderadjust_wm_latency()forXe3_LPD".Bspec: 68986, 69126
Cc Matt Atwood <[email protected]>Cc Ville Syrjälä <[email protected]>Signed-off-by Gustavo Sousa <[email protected]>--- drivers/gpu/drm/i915/display/skl_watermark.c | 25 +++++++++++++++++-------- 1 file changed, 17 insertions(+), 8 deletions(-)drivers/gpu/drm/i915/display/skl_watermark.c +7
-8@@ -3220,15 +3220,24 @@ adjust_wm_latency(struct intel_display *display)sanitize_wm_latency (display); -/* -* WaWmMemoryReadLatency -* -* punit doesn't take into account the read latency so we need -* to add proper adjustment to each valid level we retrieve -* from the punit when level 0 response data is 0us. -*/ -if (wm[0 ] ==0 ) +if (DISPLAY_VER (display) >=35 ) { +/* +* Xe3p asks to ignore wm[0] read from the register and always +* use the adjustment that adds the read latency to all valid +* latency values. +*/ + wm[0 ] =0 ; inc +=wm_read_latency (display);drivers/gpu/drm/i915/display/skl_watermark.c adjust_wm_latency(struct intel_display *display) · line 3240
Quoted 10 lines
drivers/gpu/drm/i915/display/skl_watermark.c +10
-0+ }else if (wm[0 ] ==0 ) { +/* +* WaWmMemoryReadLatency +* +* punit doesn't take into account the read latency so we need +* to add proper adjustment to each valid level we retrieve +* from the punit when level 0 response data is 0us. +*/ + inc +=wm_read_latency (display); + }Wouldn't it be simpler to just have a separate
/* * Xe3p and beyond should ignore level 0's reported latency and * always apply WaWmMemoryReadLatency logic. */ if (DISPLAY_VER(display) >= 35) wm[0] = 0;
Quoted 4 lines
Quoted 1 line
and leave the rest of the code unchanged?
That, and I think just stuff it into
sanitize_wm_latency()so that the bogus value gets nuked before we use it for anything.
Alright. Let me do that then.
FWIW, I wanted to keep the code clearly differentiating a WA path from what is now part of the regular spec for Xe3p (or is it still a WA? :-P), hence trying avoiding the split (doing wm[0] = 0 elsewhere).
--
Gustavo Sousa
Quoted 26 lines
Quoted 22 lines
Either way, matches the spec so
Reviewed-by Matt Roper <[email protected]>Matt
Quoted 7 lines
drivers/gpu/drm/i915/display/skl_watermark.c +0
-0/* * WA Level-0 adjustment for 16Gb+ DIMMs: SKL+ Signature · 1 line
2.51.0Signature · 4 lines
Matt Roper Graphics Software Engineer Linux GPU Platform Enablement Intel CorporationSignature · 2 lines
Ville Syrjälä Intel
PATCH v2 16/32 drm/i915/xe3p_lpd: Add CDCLK table
In reply to Gustavo SousaAdd CDCLK table for Xe3p_LPD.
Just as with Xe3_LPD, we don't need to send voltage index info in the PMDemand message, so we are able to re-use xe3lpd_cdclk_funcs.
With the new CDCLK table, we also need to update the maximum CDCLK value returned by intel_update_max_cdclk().
Bspec: 68861, 68863
--- drivers/gpu/drm/i915/display/intel_cdclk.c | 44 ++++++++++++++++++++++++++++-- 1 file changed, 42 insertions(+), 2 deletions(-)
drivers/gpu/drm/i915/display/intel_cdclk.c +42 -2
@@ -1534,6 +1534,41 @@ static const struct intel_cdclk_vals xe3lpd_cdclk_table[] = { {} }; +static const struct intel_cdclk_vals xe3p_lpd_cdclk_table[] = { + { .refclk =38400 , .cdclk =151200 , .ratio =21 , .waveform =0xa4a4 }, + { .refclk =38400 , .cdclk =176400 , .ratio =21 , .waveform =0xaa54 }, + { .refclk =38400 , .cdclk =201600 , .ratio =21 , .waveform =0xaaaa }, + { .refclk =38400 , .cdclk =226800 , .ratio =21 , .waveform =0xad5a }, + { .refclk =38400 , .cdclk =252000 , .ratio =21 , .waveform =0xb6b6 }, + { .refclk =38400 , .cdclk =277200 , .ratio =21 , .waveform =0xdbb6 }, + { .refclk =38400 , .cdclk =302400 , .ratio =21 , .waveform =0xeeee }, + { .refclk =38400 , .cdclk =327600 , .ratio =21 , .waveform =0xf7de }, + { .refclk =38400 , .cdclk =352800 , .ratio =21 , .waveform =0xfefe }, + { .refclk =38400 , .cdclk =378000 , .ratio =21 , .waveform =0xfffe }, + { .refclk =38400 , .cdclk =403200 , .ratio =21 , .waveform =0xffff }, + { .refclk =38400 , .cdclk =422400 , .ratio =22 , .waveform =0xffff }, + { .refclk =38400 , .cdclk =441600 , .ratio =23 , .waveform =0xffff }, + { .refclk =38400 , .cdclk =460800 , .ratio =24 , .waveform =0xffff }, + { .refclk =38400 , .cdclk =480000 , .ratio =25 , .waveform =0xffff }, + { .refclk =38400 , .cdclk =499200 , .ratio =26 , .waveform =0xffff }, + { .refclk =38400 , .cdclk =518400 , .ratio =27 , .waveform =0xffff }, + { .refclk =38400 , .cdclk =537600 , .ratio =28 , .waveform =0xffff }, + { .refclk =38400 , .cdclk =556800 , .ratio =29 , .waveform =0xffff }, + { .refclk =38400 , .cdclk =576000 , .ratio =30 , .waveform =0xffff }, + { .refclk =38400 , .cdclk =595200 , .ratio =31 , .waveform =0xffff }, + { .refclk =38400 , .cdclk =614400 , .ratio =32 , .waveform =0xffff }, + { .refclk =38400 , .cdclk =633600 , .ratio =33 , .waveform =0xffff }, + { .refclk =38400 , .cdclk =652800 , .ratio =34 , .waveform =0xffff }, + { .refclk =38400 , .cdclk =672000 , .ratio =35 , .waveform =0xffff }, + { .refclk =38400 , .cdclk =691200 , .ratio =36 , .waveform =0xffff }, + { .refclk =38400 , .cdclk =710400 , .ratio =37 , .waveform =0xffff }, + { .refclk =38400 , .cdclk =729600 , .ratio =38 , .waveform =0xffff }, + { .refclk =38400 , .cdclk =748800 , .ratio =39 , .waveform =0xffff }, + { .refclk =38400 , .cdclk =768000 , .ratio =40 , .waveform =0xffff }, + { .refclk =38400 , .cdclk =787200 , .ratio =41 , .waveform =0xffff }, + {} +}; +static const int cdclk_squash_len =16 ;static int cdclk_squash_divider (u16 waveform)
@@ -3560,7 +3595,9 @@ static int intel_compute_max_dotclk(struct intel_display *display)*/ void intel_update_max_cdclk (struct intel_display *display) { -if (DISPLAY_VERx100 (display) >=3002 ) { +if (DISPLAY_VER (display) >=35 ) { + display->cdclk.max_cdclk_freq =787200 ; + }else if (DISPLAY_VERx100 (display) >=3002 ) { display->cdclk.max_cdclk_freq =480000 ; }else if (DISPLAY_VER (display) >=30 ) { display->cdclk.max_cdclk_freq =691200 ;
@@ -3911,7 +3948,10 @@ static const struct intel_cdclk_funcs i830_cdclk_funcs = {*/ void intel_init_cdclk_hooks (struct intel_display *display) { -if (DISPLAY_VER (display) >=30 ) { +if (DISPLAY_VER (display) >=35 ) { + display->funcs.cdclk = &xe3lpd_cdclk_funcs; + display->cdclk.table = xe3p_lpd_cdclk_table; + }else if (DISPLAY_VER (display) >=30 ) { display->funcs.cdclk = &xe3lpd_cdclk_funcs; display->cdclk.table = xe3lpd_cdclk_table; }else if (DISPLAY_VER (display) >=20 ) {
Signature · 1 line
2.51.0
PATCH v2 17/32 drm/i915/xe3p_lpd: Load DMC firmware
In reply to Gustavo SousaLoad the DMC firmware for Xe3p_LPD.
--- drivers/gpu/drm/i915/display/intel_dmc.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-)
drivers/gpu/drm/i915/display/intel_dmc.c +8 -1
@@ -127,6 +127,9 @@ static bool dmc_firmware_param_disabled(struct intel_display *display)#define DISPLAY_VER13_DMC_MAX_FW_SIZE 0x20000#define DISPLAY_VER12_DMC_MAX_FW_SIZE ICL_DMC_MAX_FW_SIZE +#define XE3P_LPD_DMC_PATH DMC_PATH(xe3p_lpd) +MODULE_FIRMWARE (XE3P_LPD_DMC_PATH ); +#define XE3LPD_3002_DMC_PATH DMC_PATH(xe3lpd_3002)MODULE_FIRMWARE (XE3LPD_3002_DMC_PATH );
@@ -186,7 +189,11 @@ static const char *dmc_firmware_default(struct intel_display *display, u32 *size {const char *fw_path =NULL ;u32 max_fw_size =0 ; -if (DISPLAY_VERx100 (display) ==3002 ) { + +if (DISPLAY_VERx100 (display) ==3500 ) { + fw_path =XE3P_LPD_DMC_PATH ; + max_fw_size =XE2LPD_DMC_MAX_FW_SIZE ; + }else if (DISPLAY_VERx100 (display) ==3002 ) { fw_path =XE3LPD_3002_DMC_PATH ; max_fw_size =XE2LPD_DMC_MAX_FW_SIZE ; }else if (DISPLAY_VERx100 (display) ==3000 ) {
Signature · 1 line
2.51.0
PATCH v2 18/32 drm/i915/xe3p_lpd: Drop support for interlace mode
In reply to Gustavo SousaFrom: Ankit Nautiyal <[email protected]>
Interlace mode is officially removed from HW from Xe3p_LPD. The register TRANS_VSYNCSHIFT and the bits in TRANS_CONF are now removed, so make sure we do not set/get these anymore.
Bspec: 69961, 70000
--- drivers/gpu/drm/i915/display/intel_display.c | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-)
drivers/gpu/drm/i915/display/intel_display.c +8 -6
@@ -2633,7 +2633,7 @@ static void intel_set_transcoder_timings(const struct intel_crtc_state *crtc_sta crtc_vblank_start =1 ; } -if (DISPLAY_VER (display) >=4 ) +if (DISPLAY_VER (display) >=4 &&DISPLAY_VER (display) <35 )intel_de_write (display,TRANS_VSYNCSHIFT (display, cpu_transcoder), vsyncshift);
@@ -2771,7 +2771,7 @@ static bool intel_pipe_is_interlaced(const struct intel_crtc_state *crtc_state)struct intel_display *display =to_intel_display (crtc_state);enum transcoder cpu_transcoder = crtc_state->cpu_transcoder; -if (DISPLAY_VER (display) ==2 ) +if (DISPLAY_VER (display) ==2 ||DISPLAY_VER (display) >=35 )return false; if (DISPLAY_VER(display) >= 9 ||
@@ -3162,10 +3162,12 @@ static void hsw_set_transconf(const struct intel_crtc_state *crtc_state)if (display->platform.haswell && crtc_state->dither) val |=TRANSCONF_DITHER_EN |TRANSCONF_DITHER_TYPE_SP ; -if (crtc_state->hw.adjusted_mode.flags &DRM_MODE_FLAG_INTERLACE ) - val |=TRANSCONF_INTERLACE_IF_ID_ILK ; -else - val |=TRANSCONF_INTERLACE_PF_PD_ILK ; +if (DISPLAY_VER (display) <35 ) { +if (crtc_state->hw.adjusted_mode.flags &DRM_MODE_FLAG_INTERLACE ) + val |=TRANSCONF_INTERLACE_IF_ID_ILK ; +else + val |=TRANSCONF_INTERLACE_PF_PD_ILK ; + }if (display->platform.haswell && crtc_state->output_format !=INTEL_OUTPUT_FORMAT_RGB )
Signature · 1 line
2.51.0
PATCH v2 19/32 drm/i915/xe3p_lpd: PSR SU minimum lines is 4
In reply to Gustavo SousaFrom: Jouni Högander <[email protected]>
Ensure the minimum selective update line count is 4 in case of display version 35 and onwards.
v2:
- Fix style by dropping extra spaces after assignment operator.
(Jani).
Bspec: 69887
--- drivers/gpu/drm/i915/display/intel_psr.c | 25 +++++++++++++++++++++++++ 1 file changed, 25 insertions(+)
drivers/gpu/drm/i915/display/intel_psr.c +25 -0
@@ -2804,6 +2804,29 @@ intel_psr_apply_su_area_workarounds(struct intel_crtc_state *crtc_state)intel_psr_apply_pr_link_on_su_wa (crtc_state); } +static void intel_psr_su_area_min_lines (struct intel_crtc_state *crtc_state) +{ +struct intel_display *display =to_intel_display (crtc_state); +struct drm_rect damaged_area; + +/* +* Bspec mentions 4 being minimum lines in SU for display version +* 35 and onwards. +*/ +if (DISPLAY_VER (display) <35 ||drm_rect_height (&crtc_state->psr2_su_area) >=4 ) +return ; + + damaged_area.x1 = crtc_state->psr2_su_area.x1; + damaged_area.y1 = crtc_state->psr2_su_area.y1; + damaged_area.x2 = crtc_state->psr2_su_area.x2; + damaged_area.y2 = crtc_state->psr2_su_area.y2; + + damaged_area.y2 +=4 -drm_rect_height (&damaged_area); +drm_rect_intersect (&damaged_area, &crtc_state->pipe_src); + damaged_area.y1 -=4 -drm_rect_height (&damaged_area); +clip_area_update (&crtc_state->psr2_su_area, &damaged_area, &crtc_state->pipe_src); +} +int intel_psr2_sel_fetch_update (struct intel_atomic_state *state,struct intel_crtc *crtc) {
@@ -2912,6 +2935,8 @@ int intel_psr2_sel_fetch_update(struct intel_atomic_state *state,if (full_update) goto skip_sel_fetch_set_loop; +intel_psr_su_area_min_lines (crtc_state); +intel_psr_apply_su_area_workarounds (crtc_state); ret =drm_atomic_add_affected_planes (&state->base, &crtc->base);
Signature · 1 line
2.51.0
Re: [PATCH v2 19/32] drm/i915/xe3p_lpd: PSR SU minimum lines is 4
Quoted 4 lines · Gustavo Sousa
From: Jouni Högander <[email protected]>
Ensure the minimum selective update line count is 4 in case of display version 35 and onwards.
I don't think this is true for Xe3p (at least based on what's shown at the bottom of bspec 69887).
Matt
Quoted 60 lines
v2:
- Fix style by dropping extra spaces after assignment operator.(Jani).Bspec: 69887
Cc Jani Nikula <[email protected]>Signed-off-by Jouni Högander <[email protected]>Signed-off-by Gustavo Sousa <[email protected]>--- drivers/gpu/drm/i915/display/intel_psr.c | 25 +++++++++++++++++++++++++ 1 file changed, 25 insertions(+)drivers/gpu/drm/i915/display/intel_psr.c +25
-0@@ -2804,6 +2804,29 @@ intel_psr_apply_su_area_workarounds(struct intel_crtc_state *crtc_state)intel_psr_apply_pr_link_on_su_wa (crtc_state); } +static void intel_psr_su_area_min_lines (struct intel_crtc_state *crtc_state) +{ +struct intel_display *display =to_intel_display (crtc_state); +struct drm_rect damaged_area; + +/* +* Bspec mentions 4 being minimum lines in SU for display version +* 35 and onwards. +*/ +if (DISPLAY_VER (display) <35 ||drm_rect_height (&crtc_state->psr2_su_area) >=4 ) +return ; + + damaged_area.x1 = crtc_state->psr2_su_area.x1; + damaged_area.y1 = crtc_state->psr2_su_area.y1; + damaged_area.x2 = crtc_state->psr2_su_area.x2; + damaged_area.y2 = crtc_state->psr2_su_area.y2; + + damaged_area.y2 +=4 -drm_rect_height (&damaged_area); +drm_rect_intersect (&damaged_area, &crtc_state->pipe_src); + damaged_area.y1 -=4 -drm_rect_height (&damaged_area); +clip_area_update (&crtc_state->psr2_su_area, &damaged_area, &crtc_state->pipe_src); +} +int intel_psr2_sel_fetch_update (struct intel_atomic_state *state,struct intel_crtc *crtc) {@@ -2912,6 +2935,8 @@ int intel_psr2_sel_fetch_update(struct intel_atomic_state *state,if (full_update) goto skip_sel_fetch_set_loop; +intel_psr_su_area_min_lines (crtc_state); +intel_psr_apply_su_area_workarounds (crtc_state); ret =drm_atomic_add_affected_planes (&state->base, &crtc->base);Signature · 2 lines
-- 2.51.0
Signature · 4 lines
Matt Roper Graphics Software Engineer Linux GPU Platform Enablement Intel Corporation
Re: [PATCH v2 19/32] drm/i915/xe3p_lpd: PSR SU minimum lines is 4
Quoting Matt Roper (2025-10-29 19:14:23-03:00)
Quoted 8 lines · Gustavo Sousa
Quoted 4 lines
From: Jouni Högander <[email protected]>
Ensure the minimum selective update line count is 4 in case of display version 35 and onwards.
I don't think this is true for Xe3p (at least based on what's shown at the bottom of bspec 69887).
Agreed. I think we can drop this patch.
--
Gustavo Sousa
Quoted 70 lines
Matt
Quoted 60 lines
v2:
- Fix style by dropping extra spaces after assignment operator.(Jani).Bspec: 69887
Cc Jani Nikula <[email protected]>Signed-off-by Jouni Högander <[email protected]>Signed-off-by Gustavo Sousa <[email protected]>--- drivers/gpu/drm/i915/display/intel_psr.c | 25 +++++++++++++++++++++++++ 1 file changed, 25 insertions(+)drivers/gpu/drm/i915/display/intel_psr.c +25
-0@@ -2804,6 +2804,29 @@ intel_psr_apply_su_area_workarounds(struct intel_crtc_state *crtc_state)intel_psr_apply_pr_link_on_su_wa (crtc_state); } +static void intel_psr_su_area_min_lines (struct intel_crtc_state *crtc_state) +{ +struct intel_display *display =to_intel_display (crtc_state); +struct drm_rect damaged_area; + +/* +* Bspec mentions 4 being minimum lines in SU for display version +* 35 and onwards. +*/ +if (DISPLAY_VER (display) <35 ||drm_rect_height (&crtc_state->psr2_su_area) >=4 ) +return ; + + damaged_area.x1 = crtc_state->psr2_su_area.x1; + damaged_area.y1 = crtc_state->psr2_su_area.y1; + damaged_area.x2 = crtc_state->psr2_su_area.x2; + damaged_area.y2 = crtc_state->psr2_su_area.y2; + + damaged_area.y2 +=4 -drm_rect_height (&damaged_area); +drm_rect_intersect (&damaged_area, &crtc_state->pipe_src); + damaged_area.y1 -=4 -drm_rect_height (&damaged_area); +clip_area_update (&crtc_state->psr2_su_area, &damaged_area, &crtc_state->pipe_src); +} +int intel_psr2_sel_fetch_update (struct intel_atomic_state *state,struct intel_crtc *crtc) {@@ -2912,6 +2935,8 @@ int intel_psr2_sel_fetch_update(struct intel_atomic_state *state,if (full_update) goto skip_sel_fetch_set_loop; +intel_psr_su_area_min_lines (crtc_state); +intel_psr_apply_su_area_workarounds (crtc_state); ret =drm_atomic_add_affected_planes (&state->base, &crtc->base);Signature · 2 lines
-- 2.51.0Signature · 4 lines
Matt Roper Graphics Software Engineer Linux GPU Platform Enablement Intel Corporation
PATCH v2 20/32 drm/i915/xe3p_lpd: Enable system caching for FBC
In reply to Gustavo SousaFrom: Vinod Govindapillai <[email protected]>
Configure one of the FBC instances to use system caching. FBC read/write requests are tagged as cacheable till a programmed limit is reached by the hw.
Bspec: 74722
--- drivers/gpu/drm/i915/display/intel_fbc.c | 47 +++++++++++++++++++++++++++ drivers/gpu/drm/i915/display/intel_fbc_regs.h | 9 +++++ 2 files changed, 56 insertions(+)
drivers/gpu/drm/i915/display/intel_fbc.c +47 -0
@@ -126,6 +126,9 @@ struct intel_fbc {*/ struct intel_fbc_state state;const char *no_fbc_reason; + +/* Only one of FBC instances can use the system cache */ +bool own_sys_cache; };/* plane stride in pixels */
@@ -570,12 +573,51 @@ static bool ilk_fbc_is_compressing(struct intel_fbc *fbc)return intel_de_read (fbc->display,ILK_DPFC_STATUS (fbc->id)) &DPFC_COMP_SEG_MASK ; } +static void nvl_fbc_program_system_cache (struct intel_fbc *fbc,bool enable) +{ +struct intel_display *display = fbc->display; +u32 cfb_offset, usage; + +lockdep_assert_held (&fbc->lock); + + usage =intel_de_read (display,NVL_FBC_SYS_CACHE_USAGE_CFG ); + +/* System cache already being used by another pipe */ +if (enable && (usage &FBC_SYS_CACHE_TAG_USE_RES_SPACE )) +return ; + +/* Only the fbc instance which owns system cache can disable it */ +if (!enable && !fbc->own_sys_cache) +return ; + +/* +* Not programming the cache limit and cache reading enable bits explicitly +* here. The default values should take care of those and that could leave +* adjustments of those bits to the system hw policy +* +* TODO: check if we need to explicitly program these? +*/ + cfb_offset = enable ?i915_gem_stolen_node_offset (fbc->compressed_fb) :0 ; + usage |=FBC_SYS_CACHE_START_BASE (cfb_offset); + usage |= enable ?FBC_SYS_CACHE_TAG_USE_RES_SPACE :FBC_SYS_CACHE_TAG_DONT_CACHE ; + +intel_de_write (display,NVL_FBC_SYS_CACHE_USAGE_CFG , usage); + + fbc->own_sys_cache = enable; + +drm_dbg_kms (display->drm,"System caching for FBC[%d] %s\n" , + fbc->id, enable ?"configured" :"cleared" ); +} +static void ilk_fbc_program_cfb (struct intel_fbc *fbc) {struct intel_display *display = fbc->display;intel_de_write (display,ILK_DPFC_CB_BASE (fbc->id),i915_gem_stolen_node_offset (fbc->compressed_fb)); + +if (DISPLAY_VER (display) >=35 ) +nvl_fbc_program_system_cache (fbc, true); }static const struct intel_fbc_funcs ilk_fbc_funcs = {
@@ -953,6 +995,8 @@ static void intel_fbc_program_workarounds(struct intel_fbc *fbc)static void __intel_fbc_cleanup_cfb (struct intel_fbc *fbc) { +struct intel_display *display = fbc->display; +if (WARN_ON (intel_fbc_hw_is_active (fbc)))return ;
@@ -960,6 +1004,9 @@ static void __intel_fbc_cleanup_cfb(struct intel_fbc *fbc)i915_gem_stolen_remove_node (fbc->compressed_llb);if (i915_gem_stolen_node_allocated (fbc->compressed_fb))i915_gem_stolen_remove_node (fbc->compressed_fb); + +if (DISPLAY_VER (display) >=35 ) +nvl_fbc_program_system_cache (fbc, false); }void intel_fbc_cleanup (struct intel_display *display)
drivers/gpu/drm/i915/display/intel_fbc_regs.h +9 -0
@@ -128,4 +128,13 @@#define FBC_REND_NUKE REG_BIT(2)#define FBC_REND_CACHE_CLEAN REG_BIT(1) +#define NVL_FBC_SYS_CACHE_USAGE_CFG _MMIO(0x1344E0) +#define FBC_SYS_CACHE_START_BASE_MASK REG_GENMASK(31, 16) +#define FBC_SYS_CACHE_START_BASE (base) REG_FIELD_PREP(FBC_SYS_CACHE_START_BASE_MASK, (base)) +#define FBC_SYS_CACHEABLE_RANGE_MASK REG_GENMASK(15, 4) +#define FBC_SYS_CACHEABLE_RANGE (range) REG_FIELD_PREP(FBC_SYS_CACHEABLE_RANGE_MASK, (range)) +#define FBC_SYS_CACHE_TAG_MASK REG_GENMASK(3, 2) +#define FBC_SYS_CACHE_TAG_DONT_CACHE REG_FIELD_PREP(FBC_SYS_CACHE_TAG_MASK, 0) +#define FBC_SYS_CACHE_TAG_USE_RES_SPACE REG_FIELD_PREP(FBC_SYS_CACHE_TAG_MASK, 3) +#endif /* __INTEL_FBC_REGS__ */
Signature · 1 line
2.51.0
PATCH v2 21/32 drm/i915/xe3p_lpd: Extend Wa_16025573575
In reply to Gustavo SousaWa_16025573575 also applies to Xe3p_LPD, so let's include it in the IP version checks.
--- drivers/gpu/drm/i915/display/intel_display_wa.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/gpu/drm/i915/display/intel_display_wa.c +2 -1
@@ -49,7 +49,8 @@ void intel_display_wa_apply(struct intel_display *display)*/ static bool intel_display_needs_wa_16025573575 (struct intel_display *display) { -return DISPLAY_VERx100 (display) ==3000 ||DISPLAY_VERx100 (display) ==3002 ; +return DISPLAY_VERx100 (display) ==3000 ||DISPLAY_VERx100 (display) ==3002 || +DISPLAY_VERx100 (display) ==3500 ; }/*
Signature · 1 line
2.51.0
PATCH v2 22/32 drm/i915/xe3p_lpd: Don't allow odd ypan or ysize with semiplanar format
In reply to Gustavo SousaFrom: Juha-pekka Heikkila <[email protected]>
Disable support for odd panning and size in y direction when running on display version 35 and using semiplanar formats.
Bspec: 68903
--- drivers/gpu/drm/i915/display/intel_plane.c | 3 +++ 1 file changed, 3 insertions(+)
drivers/gpu/drm/i915/display/intel_plane.c +3 -0
@@ -1050,6 +1050,9 @@ int intel_plane_check_src_coordinates(struct intel_plane_state *plane_state) DISPLAY_VERx100(display) == 3002) && src_x % 2 != 0) hsub =2 ; + +if (DISPLAY_VER (display) ==35 ) + vsub =2 ; }else { hsub = fb->format->hsub; vsub = fb->format->vsub;
Signature · 1 line
2.51.0
PATCH v2 23/32 drm/i915/xe3p_lpd: Reload DMC MMIO for pipes C and D
In reply to Gustavo SousaXe3p_LPD has the same behavior as for Xe3_LPD with respect to DMC context data for pipes C and D, which are lost when their power wells are disabled. As such, let's extend the condition for Xe3_LPD in need_pipedmc_load_mmio() to also catch Xe3p_LPD.
Bspec: 68851
--- drivers/gpu/drm/i915/display/intel_dmc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/gpu/drm/i915/display/intel_dmc.c +2 -2
@@ -673,11 +673,11 @@ static bool need_pipedmc_load_program(struct intel_display *display)static bool need_pipedmc_load_mmio (struct intel_display *display,enum pipe pipe) {/* -* PTL: +* Xe3_LPD/Xe3p_LPD: * - pipe A/B DMC doesn't need save/restore * - pipe C/D DMC is in PG0, needs manual save/restore */ -if (DISPLAY_VER (display) ==30 ) +if (IS_DISPLAY_VER (display,30 ,35 ))return pipe >=PIPE_C ;/*
Signature · 1 line
2.51.0
PATCH v2 24/32 drm/i915/xe3p_lpd: Introduce pixel normalizer config support
In reply to Gustavo SousaFrom: Vinod Govindapillai <[email protected]>
To enable FBC for FP16 formats, we need to enable the pixel normalizer block. Introduce the register definitions and the initial steps for configuring the pixel normalizer block. In this patch the pixel normalizer block is kept as disabled. The follow-up patches will handle configuring the pixel normalizer block for hdr planes for FP16 formats.
Bspec: 69863
--- drivers/gpu/drm/i915/display/intel_display_types.h | 3 +++ drivers/gpu/drm/i915/display/skl_universal_plane.c | 15 +++++++++++++++ drivers/gpu/drm/i915/display/skl_universal_plane_regs.h | 11 +++++++++++ 3 files changed, 29 insertions(+)
drivers/gpu/drm/i915/display/intel_display_types.h +3 -0
@@ -679,6 +679,9 @@ struct intel_plane_state {/* surface address register */ u32 surf; +/* plane pixel normalizer config for Xe3p_LPD+ FBC FP16 */ +u32 pixel_normalizer; +/* * scaler_id * = -1 : not using a scaler
drivers/gpu/drm/i915/display/skl_universal_plane.c +15 -0
@@ -893,6 +893,12 @@ static void skl_write_plane_wm(struct intel_dsb *dsb, xe3_plane_min_ddb_reg_val(min_ddb, interim_ddb)); } +static void +xe3p_lpd_plane_check_pixel_normalizer (struct intel_plane_state *plane_state) +{ + plane_state->pixel_normalizer =0 ; +} + static void skl_plane_disable_arm(struct intel_dsb *dsb, struct intel_plane *plane,
@@ -1671,6 +1677,11 @@ icl_plane_update_arm(struct intel_dsb *dsb,icl_plane_update_sel_fetch_arm (dsb, plane, crtc_state, plane_state); +/* Only the HDR planes can have pixel normalizer */ +if (DISPLAY_VER (display) >=35 &&icl_is_hdr_plane (display, plane_id)) +intel_de_write_dsb (display, dsb, +PLANE_PIXEL_NORMALIZE (plane->pipe, plane->id), + plane_state->pixel_normalizer);/* * The control register self-arms if the plane was previously * disabled. Try to make the plane enable atomic by writing
@@ -2385,6 +2396,10 @@ static int skl_plane_check(struct intel_crtc_state *crtc_state, plane_state->damage =DRM_RECT_INIT (0 ,0 ,0 ,0 ); } +/* Pixel normalizer for Xe3p_LPD+ */ +if (DISPLAY_VER (display) >=35 &&icl_is_hdr_plane (display, plane->id)) +xe3p_lpd_plane_check_pixel_normalizer (plane_state); + plane_state->ctl =skl_plane_ctl (plane_state);if (DISPLAY_VER (display) >=10 )
drivers/gpu/drm/i915/display/skl_universal_plane_regs.h +11 -0
@@ -456,4 +456,15 @@ _SEL_FETCH_PLANE_OFFSET_5_A, _SEL_FETCH_PLANE_OFFSET_5_B, \ _SEL_FETCH_PLANE_OFFSET_6_A, _SEL_FETCH_PLANE_OFFSET_6_B) +#define _PLANE_PIXEL_NORMALIZE_1_A 0x701a8 +#define _PLANE_PIXEL_NORMALIZE_2_A 0x702a8 +#define _PLANE_PIXEL_NORMALIZE_1_B 0x711a8 +#define _PLANE_PIXEL_NORMALIZE_2_B 0x712a8 +#define PLANE_PIXEL_NORMALIZE (pipe, plane) _MMIO_SKL_PLANE((pipe), (plane), \ + _PLANE_PIXEL_NORMALIZE_1_A, _PLANE_PIXEL_NORMALIZE_1_B, \ + _PLANE_PIXEL_NORMALIZE_2_A, _PLANE_PIXEL_NORMALIZE_2_B) +#define PLANE_PIXEL_NORMALIZE_ENABLE REG_BIT(31) +#define PLANE_PIXEL_NORMALIZE_NORM_FACTOR_MASK REG_GENMASK(15, 0) +#define PLANE_PIXEL_NORMALIZE_NORM_FACTOR (val) REG_FIELD_PREP(PLANE_PIXEL_NORMALIZE_NORM_FACTOR_MASK, (val)) +#endif /* __SKL_UNIVERSAL_PLANE_REGS_H__ */
Signature · 1 line
2.51.0
PATCH v2 25/32 drm/i915/xe3p_lpd: Add FBC support for FP16 formats
In reply to Gustavo SousaFrom: Vinod Govindapillai <[email protected]>
Add supported FP16 formats for FBC. FBC can be enabled with FP16 formats only when plane pixel normalizer block is enabled.
Bspec: 6881, 69863, 68904
--- drivers/gpu/drm/i915/display/intel_fbc.c | 37 ++++++++++++++++++++++++++++++++ drivers/gpu/drm/i915/display/intel_fbc.h | 1 + 2 files changed, 38 insertions(+)
drivers/gpu/drm/i915/display/intel_fbc.c +37 -0
@@ -63,6 +63,7 @@#include "intel_fbc.h" #include "intel_fbc_regs.h" #include "intel_frontbuffer.h" +#include "skl_universal_plane_regs.h" #define for_each_fbc_id (__display, __fbc_id) \ for ((__fbc_id) = INTEL_FBC_A; (__fbc_id) < I915_MAX_FBCS; (__fbc_id)++) \
@@ -153,6 +154,8 @@ static unsigned int intel_fbc_cfb_cpp(const struct intel_plane_state *plane_statcase DRM_FORMAT_XBGR16161616 :case DRM_FORMAT_ARGB16161616 :case DRM_FORMAT_ABGR16161616 : +case DRM_FORMAT_ARGB16161616F : +case DRM_FORMAT_ABGR16161616F :return 8 ;default :return 4 ;
@@ -695,6 +698,30 @@ static void skl_fbc_program_cfb_stride(struct intel_fbc *fbc) CHICKEN_FBC_STRIDE_MASK, val); } +static bool +xe3p_lpd_fbc_is_fp16_format (const struct intel_plane_state *plane_state) +{ +const struct drm_framebuffer *fb = plane_state->hw.fb; + +switch (fb->format->format) { +case DRM_FORMAT_ARGB16161616F : +case DRM_FORMAT_ABGR16161616F : +return true; +default : +return false; + } +} + +bool +intel_fbc_is_fp16_format_supported (const struct intel_plane_state *plane_state) +{ +struct intel_display *display =to_intel_display (plane_state); + +if (DISPLAY_VER (display) >=35 ) +return xe3p_lpd_fbc_is_fp16_format (plane_state); + +return false; +}static u32 ivb_dpfc_ctl (struct intel_fbc *fbc) {struct intel_display *display = fbc->display;
@@ -810,6 +837,8 @@ static void intel_fbc_nuke(struct intel_fbc *fbc)static void intel_fbc_activate (struct intel_fbc *fbc) {struct intel_display *display = fbc->display; +struct intel_plane *plane = fbc->state.plane; +struct intel_plane_state *plane_state =to_intel_plane_state (plane->base.state);lockdep_assert_held (&fbc->lock);
@@ -822,6 +851,11 @@ static void intel_fbc_activate(struct intel_fbc *fbc)*/ drm_WARN_ON (display->drm, fbc->active &&HAS_FBC_DIRTY_RECT (display)); +drm_WARN_ON (display->drm, +DISPLAY_VER (display) >=35 && +xe3p_lpd_fbc_is_fp16_format (plane_state) && + (plane_state->pixel_normalizer &PLANE_PIXEL_NORMALIZE_ENABLE ) ==0 ); +intel_fbc_hw_activate (fbc);intel_fbc_nuke (fbc);
@@ -1142,6 +1176,9 @@ static bool xe3p_lpd_fbc_pixel_format_is_valid(const struct intel_plane_state *p {const struct drm_framebuffer *fb = plane_state->hw.fb; +if (xe3p_lpd_fbc_is_fp16_format (plane_state)) +return true; +switch (fb->format->format) {case DRM_FORMAT_XRGB8888 :case DRM_FORMAT_XBGR8888 :
drivers/gpu/drm/i915/display/intel_fbc.h +1 -0
@@ -53,5 +53,6 @@ void intel_fbc_prepare_dirty_rect(struct intel_atomic_state *state, struct intel_crtc *crtc);void intel_fbc_dirty_rect_update_noarm (struct intel_dsb *dsb,struct intel_plane *plane); +bool intel_fbc_is_fp16_format_supported (const struct intel_plane_state *plane_state);#endif /* __INTEL_FBC_H__ */
Signature · 1 line
2.51.0
PATCH v2 26/32 drm/i915/xe3p_lpd: Enable pixel normalizer for fp16 formats for FBC
In reply to Gustavo SousaFrom: Vinod Govindapillai <[email protected]>
There is a hw restriction that we could enable the FBC for FP16 formats only if the pixel normalization block is enabled. Hence enable the pixel normalizer block with normalzation factor as 1.0 for the supported FP16 formats to get the FBC enabled. Two existing helper function definitions are moved up to avoid the forward declarations as part of this patch as well.
Bspec: 69863, 68881
--- drivers/gpu/drm/i915/display/skl_universal_plane.c | 50 ++++++++++++++-------- .../drm/i915/display/skl_universal_plane_regs.h | 1 + 2 files changed, 33 insertions(+), 18 deletions(-)
drivers/gpu/drm/i915/display/skl_universal_plane.c +32 -18
@@ -486,6 +486,23 @@ static int skl_plane_max_height(const struct drm_framebuffer *fb,return 4096 ; } +static enum intel_fbc_id skl_fbc_id_for_pipe (enum pipe pipe) +{ +return pipe -PIPE_A +INTEL_FBC_A ; +} + +static bool skl_plane_has_fbc (struct intel_display *display, +enum intel_fbc_id fbc_id,enum plane_id plane_id) +{ +if ((DISPLAY_RUNTIME_INFO (display)->fbc_mask &BIT (fbc_id)) ==0 ) +return false; + +if (DISPLAY_VER (display) >=20 ) +return icl_is_hdr_plane (display, plane_id); +else +return plane_id ==PLANE_1 ; +} +static int icl_plane_max_height (const struct drm_framebuffer *fb,int color_plane,unsigned int rotation)
@@ -896,7 +913,21 @@ static void skl_write_plane_wm(struct intel_dsb *dsb,static void xe3p_lpd_plane_check_pixel_normalizer (struct intel_plane_state *plane_state) { - plane_state->pixel_normalizer =0 ; +struct intel_display *display =to_intel_display (plane_state); +struct intel_plane *plane =to_intel_plane (plane_state->uapi.plane); +enum intel_fbc_id fbc_id =skl_fbc_id_for_pipe (plane->pipe); +u32 reg =0 ; + +/* +* To enable FBC for FP16 formats, enable pixel normalizer with +* normalization factor as 1.0 +*/ +if (skl_plane_has_fbc (display, fbc_id, plane->id) && +intel_fbc_is_fp16_format_supported (plane_state)) + reg =PLANE_PIXEL_NORMALIZE_NORM_FACTOR (PLANE_PIXEL_NORMALIZE_NORM_FACTOR_1_0 ) | +PLANE_PIXEL_NORMALIZE_ENABLE ; + + plane_state->pixel_normalizer = reg; } static void
@@ -2449,23 +2480,6 @@ void icl_link_nv12_planes(struct intel_plane_state *uv_plane_state, } } -static enum intel_fbc_id skl_fbc_id_for_pipe (enum pipe pipe) -{ -return pipe -PIPE_A +INTEL_FBC_A ; -} - -static bool skl_plane_has_fbc (struct intel_display *display, -enum intel_fbc_id fbc_id,enum plane_id plane_id) -{ -if ((DISPLAY_RUNTIME_INFO (display)->fbc_mask &BIT (fbc_id)) ==0 ) -return false; - -if (DISPLAY_VER (display) >=20 ) -return icl_is_hdr_plane (display, plane_id); -else -return plane_id ==PLANE_1 ; -} -static struct intel_fbc *skl_plane_fbc (struct intel_display *display,enum pipe pipe,enum plane_id plane_id) {
drivers/gpu/drm/i915/display/skl_universal_plane_regs.h +1 -0
@@ -466,5 +466,6 @@#define PLANE_PIXEL_NORMALIZE_ENABLE REG_BIT(31)#define PLANE_PIXEL_NORMALIZE_NORM_FACTOR_MASK REG_GENMASK(15, 0)#define PLANE_PIXEL_NORMALIZE_NORM_FACTOR (val) REG_FIELD_PREP(PLANE_PIXEL_NORMALIZE_NORM_FACTOR_MASK, (val)) +#define PLANE_PIXEL_NORMALIZE_NORM_FACTOR_1_0 0x3c00#endif /* __SKL_UNIVERSAL_PLANE_REGS_H__ */
Signature · 1 line
2.51.0
PATCH v2 27/32 drm/i915/vbt: Add fields dedicated_external and dyn_port_over_tc
In reply to Gustavo SousaVBT version 264 adds new fields associated to Xe3p_LPD's new ways of configuring SoC for TC ports and PHYs. Update the code to match the updates in VBT.
The new field dedicated_external is used to represent TC ports that are connected to PHYs outside of the Type-C subsystem, meaning that they behave like dedicated ports and don't require the extra Type-C programming. In an upcoming change, we will update the driver to take this field into consideration when detecting the type of port.
The new field dyn_port_over_tc is used to inform that the TC port can be dynamically allocated for a legacy connector in the Type-C subsystem, which is a new feature in Xe3p_LPD. In upcoming changes, we will use that field in order to handle the IOM resource management programming required for that.
Note that, when dedicated_external is set, the fields dp_usb_type_c and tbt are tagged as "don't care" in the spec, so they should be ignored in that case, so also add a sanitization function to take care of forcing them to zero when dedicated_external is true.
v2:
- Use sanitization function to force dp_usb_type_c and tbt fields to be zero instead of adding a intel_bios_encoder_is_dedicated_external() check in each of their respective accessor functions. (Jani)
- Print info about dedicated external ports in print_ddi_port().
(Jani)
Bspec: 20124, 68954, 74304
--- drivers/gpu/drm/i915/display/intel_bios.c | 54 ++++++++++++++++++++++++++- drivers/gpu/drm/i915/display/intel_bios.h | 2 + drivers/gpu/drm/i915/display/intel_vbt_defs.h | 3 +- 3 files changed, 56 insertions(+), 3 deletions(-)
drivers/gpu/drm/i915/display/intel_bios.c +52 -2
@@ -2529,6 +2529,36 @@ intel_bios_encoder_reject_edp_rate(const struct intel_bios_encoder_data *devdatareturn devdata->child.edp_data_rate_override &edp_rate_override_mask (rate); } +static void sanitize_dedicated_external (struct intel_bios_encoder_data *devdata, +enum port port) +{ +struct intel_display *display = devdata->display; + +if (!intel_bios_encoder_is_dedicated_external (devdata)) +return ; + +/* +* Fields dp_usb_type_c and tbt must be ignored when +* dedicated_external is set. Since dedicated_external is for +* ports connected to PHYs outside of the Type-C subsystem, it +* is safe to force those fields to zero. +*/ + +if (devdata->child.dp_usb_type_c) { +drm_dbg_kms (display->drm, +"VBT claims Port %c supports USB Type-C, but the port is dedicated external, ignoring\n" , +port_name (port)); + devdata->child.dp_usb_type_c =0 ; + } + +if (devdata->child.tbt) { +drm_dbg_kms (display->drm, +"VBT claims Port %c supports TBT, but the port is dedicated external, ignoring\n" , +port_name (port)); + devdata->child.tbt =0 ; + } +} +static void sanitize_device_type (struct intel_bios_encoder_data *devdata,enum port port) {
@@ -2667,7 +2697,8 @@ static void print_ddi_port(const struct intel_bios_encoder_data *devdata) {struct intel_display *display = devdata->display;const struct child_device_config *child = &devdata->child; -bool is_dvi, is_hdmi, is_dp, is_edp, is_dsi, is_crt, supports_typec_usb, supports_tbt; +bool is_dvi, is_hdmi, is_dp, is_edp, is_dsi, is_crt, supports_typec_usb, + supports_tbt, dedicated_external;int dp_boost_level, dp_max_link_rate, hdmi_boost_level, hdmi_level_shift, max_tmds_clock;enum port port;
@@ -2693,6 +2724,12 @@ static void print_ddi_port(const struct intel_bios_encoder_data *devdata) supports_typec_usb, supports_tbt, devdata->dsc != NULL); + dedicated_external =intel_bios_encoder_is_dedicated_external (devdata); +if (dedicated_external) +drm_dbg_kms (display->drm, +"Port %c is dedicated external\n" , +port_name (port)); + hdmi_level_shift =intel_bios_hdmi_level_shift (devdata);if (hdmi_level_shift >=0 ) { drm_dbg_kms(display->drm,
@@ -2750,6 +2787,7 @@ static void parse_ddi_port(struct intel_bios_encoder_data *devdata)return ; } +sanitize_dedicated_external (devdata, port);sanitize_device_type (devdata, port);sanitize_hdmi_level_shift (devdata, port); }
@@ -2777,7 +2815,7 @@ static int child_device_expected_size(u16 version) {BUILD_BUG_ON (sizeof (struct child_device_config ) <40 ); -if (version >263 ) +if (version >264 )return -ENOENT ;else if (version >=263 )return 44 ;
@@ -3722,6 +3760,18 @@ bool intel_bios_encoder_supports_tbt(const struct intel_bios_encoder_data *devdareturn devdata->display->vbt.version >=209 && devdata->child.tbt; } +bool intel_bios_encoder_is_dedicated_external (const struct intel_bios_encoder_data *devdata) +{ +return devdata->display->vbt.version >=264 && + devdata->child.dedicated_external; +} + +bool intel_bios_encoder_supports_dyn_port_over_tc (const struct intel_bios_encoder_data *devdata) +{ +return devdata->display->vbt.version >=264 && + devdata->child.dyn_port_over_tc; +} +bool intel_bios_encoder_lane_reversal (const struct intel_bios_encoder_data *devdata) {return devdata && devdata->child.lane_reversal;
drivers/gpu/drm/i915/display/intel_bios.h +2 -0
@@ -79,6 +79,8 @@ bool intel_bios_encoder_supports_dp(const struct intel_bios_encoder_data *devdatbool intel_bios_encoder_supports_edp (const struct intel_bios_encoder_data *devdata);bool intel_bios_encoder_supports_typec_usb (const struct intel_bios_encoder_data *devdata);bool intel_bios_encoder_supports_tbt (const struct intel_bios_encoder_data *devdata); +bool intel_bios_encoder_is_dedicated_external (const struct intel_bios_encoder_data *devdata); +bool intel_bios_encoder_supports_dyn_port_over_tc (const struct intel_bios_encoder_data *devdata);bool intel_bios_encoder_supports_dsi (const struct intel_bios_encoder_data *devdata);bool intel_bios_encoder_supports_dp_dual_mode (const struct intel_bios_encoder_data *devdata);bool intel_bios_encoder_is_lspcon (const struct intel_bios_encoder_data *devdata);
drivers/gpu/drm/i915/display/intel_vbt_defs.h +2 -1
@@ -554,7 +554,8 @@ struct child_device_config {u8 dvo_function; u8 dp_usb_type_c:1; /* 195+ */ u8 tbt:1; /* 209+ */ - u8 flags2_reserved:2; /* 195+ */ + u8 dedicated_external:1; /* 264+ */ + u8 dyn_port_over_tc:1; /* 264+ */ u8 dp_port_trace_length:4; /* 209+ */u8 dp_gpio_index;/* 195+ */ u16 dp_gpio_pin_num;/* 195+ */
Signature · 1 line
2.51.0
PATCH v2 28/32 drm/i915/power: Use intel_encoder_is_tc()
In reply to Gustavo SousaStarting with Xe3p_LPD, when intel_phy_is_tc() returns true, it does not necessarily mean that the port is connected to a PHY in the Type-C subsystem. The reason is that there is now a VBT field called dedicated_external that will indicate that a Type-C capable port is connected to a (most likely) combo/dedicated PHY. When that's the case, we must not do the extra programming required for Type-C connections.
In an upcoming change, we will modify intel_encoder_is_tc() to take the VBT field dedicated_external into consideration. Update intel_display_power_well.c to use that function instead of intel_phy_is_tc().
Note that, even though icl_aux_power_well_{enable,disable} are not part of Xe3p_LPD's display paths, we modify them anyway for uniformity.
--- .../drm/i915/display/intel_display_power_well.c | 26 +++++++++++++++------- 1 file changed, 18 insertions(+), 8 deletions(-)
drivers/gpu/drm/i915/display/intel_display_power_well.c +18 -8
@@ -256,8 +256,9 @@ aux_ch_to_digital_port(struct intel_display *display,return NULL ; } -static enum phy icl_aux_pw_to_phy (struct intel_display *display, -const struct i915_power_well *power_well) +static struct intel_encoder * +icl_aux_pw_to_encoder (struct intel_display *display, +const struct i915_power_well *power_well) {enum aux_ch aux_ch =icl_aux_pw_to_ch (power_well);struct intel_digital_port *dig_port =aux_ch_to_digital_port (display, aux_ch);
@@ -269,7 +270,15 @@ static enum phy icl_aux_pw_to_phy(struct intel_display *display,* as HDMI-only and routed to a combo PHY, the encoder either won't be * present at all or it will not have an aux_ch assigned. */ -return dig_port ?intel_encoder_to_phy (&dig_port->base) :PHY_NONE ; +return dig_port ? &dig_port->base :NULL ; +} + +static enum phy icl_aux_pw_to_phy (struct intel_display *display, +const struct i915_power_well *power_well) +{ +struct intel_encoder *encoder =icl_aux_pw_to_encoder (display, power_well); + +return encoder ?intel_encoder_to_phy (encoder) :PHY_NONE ; } static void hsw_wait_for_power_well_enable(struct intel_display *display,
@@ -568,9 +577,9 @@ static void icl_aux_power_well_enable(struct intel_display *display, struct i915_power_well *power_well) { - enum phy phy = icl_aux_pw_to_phy(display, power_well); + struct intel_encoder *encoder = icl_aux_pw_to_encoder(display, power_well); -if (intel_phy_is_tc (display, phy)) +if (encoder &&intel_encoder_is_tc (encoder))return icl_tc_phy_aux_power_well_enable (display, power_well); else if (display->platform.icelake) return icl_combo_phy_aux_power_well_enable(display,
@@ -583,9 +592,9 @@ static void icl_aux_power_well_disable(struct intel_display *display, struct i915_power_well *power_well) { - enum phy phy = icl_aux_pw_to_phy(display, power_well); + struct intel_encoder *encoder = icl_aux_pw_to_encoder(display, power_well); -if (intel_phy_is_tc (display, phy)) +if (encoder &&intel_encoder_is_tc (encoder))return hsw_power_well_disable (display, power_well); else if (display->platform.icelake) return icl_combo_phy_aux_power_well_disable(display,
@@ -1847,10 +1856,11 @@ tgl_tc_cold_off_power_well_is_enabled(struct intel_display *display,static void xelpdp_aux_power_well_enable (struct intel_display *display,struct i915_power_well *power_well) { +struct intel_encoder *encoder =icl_aux_pw_to_encoder (display, power_well);enum aux_ch aux_ch =i915_power_well_instance (power_well)->xelpdp.aux_ch;enum phy phy =icl_aux_pw_to_phy (display, power_well); -if (intel_phy_is_tc (display, phy)) +if (encoder &&intel_encoder_is_tc (encoder))icl_tc_port_assert_ref_held (display, power_well,aux_ch_to_digital_port (display, aux_ch));
Signature · 1 line
2.51.0
PATCH v2 29/32 drm/i915/display: Handle dedicated external ports in intel_encoder_is_tc()
In reply to Gustavo SousaStarting with Xe3p_LPD, the VBT has a new field, called in the driver "dedicated_external", which tells that a Type-C capable port is physically connected to a PHY outside of the Type-C subsystem. When that's the case, the driver must not do the extra Type-C programming for that port. Update intel_encoder_is_tc() to check for that case.
While at it, add a note to intel_phy_is_tc() to remind us that it is about whether the respective port is a Type-C capable port rather than the PHY itself.
(Maybe it would be a nice idea to rename intel_phy_is_tc()?)
Note that this was handled with a new bool member added to struct intel_digital_port instead of having querying the VBT directly because VBT memory is freed (intel_bios_driver_remove) before encoder cleanup (intel_ddi_encoder_destroy), which would cause an oops to happen when the latter calls intel_encoder_is_tc(). This could be fixed by keeping VBT data around longer, but that's left for a follow-up work, if deemed necessary.
v2:
- Drop printing info about dedicated external, now that we are doing it when parsing the VBT. (Jani)
- Add a FIXME comment on the code explaining why we need to store dedicated_external in struct intel_digital_port. (Jani)
--- drivers/gpu/drm/i915/display/intel_ddi.c | 11 +++++++++++ drivers/gpu/drm/i915/display/intel_display.c | 19 ++++++++++++++++++- drivers/gpu/drm/i915/display/intel_display_types.h | 1 + 3 files changed, 30 insertions(+), 1 deletion(-)
drivers/gpu/drm/i915/display/intel_ddi.c +11 -0
@@ -5350,6 +5350,17 @@ void intel_ddi_init(struct intel_display *display, goto err; } +/* +* FIXME: We currently need to store dedicated_external because devdata +* does not live long enough for when intel_encoder_is_tc() is called on +* the unbind path. This needs to be fixed by making sure that the VBT +* data is kept long enough, so that +* intel_bios_encoder_is_dedicated_external() can be called directly +* from intel_encoder_is_tc(). +*/ +if (intel_bios_encoder_is_dedicated_external (devdata)) + dig_port->dedicated_external = true; +if (intel_encoder_is_tc (encoder)) {bool is_legacy = !intel_bios_encoder_supports_typec_usb(devdata) &&
drivers/gpu/drm/i915/display/intel_display.c +18 -1
@@ -1778,7 +1778,17 @@ bool intel_phy_is_combo(struct intel_display *display, enum phy phy)return false; } -/* Prefer intel_encoder_is_tc() */ +/* +* This function returns true if the DDI port respective to the PHY enumeration +* is a Type-C capable port. +* +* Depending on the VBT, the port might be configured +* as a "dedicated external" port, meaning that actual physical PHY is outside +* of the Type-C subsystem and, as such, not really a "Type-C PHY". +* +* Prefer intel_encoder_is_tc(), especially if you really need to know if we +* are dealing with Type-C connections. +*/ bool intel_phy_is_tc (struct intel_display *display,enum phy phy) {/*
@@ -1863,6 +1873,13 @@ bool intel_encoder_is_tc(struct intel_encoder *encoder) {struct intel_display *display =to_intel_display (encoder); +if (intel_encoder_is_dig_port (encoder)) { +struct intel_digital_port *dig_port =enc_to_dig_port (encoder); + +if (dig_port->dedicated_external) +return false; + } +return intel_phy_is_tc (display,intel_encoder_to_phy (encoder)); }
drivers/gpu/drm/i915/display/intel_display_types.h +1 -0
@@ -1925,6 +1925,7 @@ struct intel_digital_port {bool lane_reversal;bool ddi_a_4_lanes;bool release_cl2_override; +bool dedicated_external;u8 max_lanes;/* Used for DP and ICL+ TypeC/DP and TypeC/HDMI ports. */ enum aux_ch aux_ch;
Signature · 1 line
2.51.0
PATCH v2 30/32 drm/i915/wm: don't use method1 in Xe3p_LPD onwards
In reply to Gustavo SousaFrom: Luca Coelho <[email protected]>
Starting from display version 35, we don't need to use method1 to calculate the watermark values anymore, so skip it.
Bspec: 68985
--- drivers/gpu/drm/i915/display/skl_watermark.c | 2 ++ 1 file changed, 2 insertions(+)
drivers/gpu/drm/i915/display/skl_watermark.c +2 -0
@@ -1812,6 +1812,8 @@ static void skl_compute_plane_wm(const struct intel_crtc_state *crtc_state,if (wp->y_tiled) { selected_result =max_fixed16 (method2, wp->y_tile_minimum); + }else if (DISPLAY_VER (display) >=35 ) { + selected_result = method2; }else { if ((wp->cpp * crtc_state->hw.pipe_mode.crtc_htotal / wp->dbuf_block_size < 1) &&
Signature · 1 line
2.51.0
Re: [PATCH v2 30/32] drm/i915/wm: don't use method1 in Xe3p_LPD onwards
Quoted 8 lines · Gustavo Sousa
From: Luca Coelho <[email protected]>
Starting from display version 35, we don't need to use method1 to calculate the watermark values anymore, so skip it.
Bspec: 68985
Signed-off-by Luca Coelho <[email protected]>Signed-off-by Gustavo Sousa <[email protected]>
The change itself looks fine to me, so I'll give the RB. But, I'm still unconvinced on the wordings of this commit title and it's message.
Quoted 18 lines
--- drivers/gpu/drm/i915/display/skl_watermark.c | 2 ++ 1 file changed, 2 insertions(+)drivers/gpu/drm/i915/display/skl_watermark.c +2
-0@@ -1812,6 +1812,8 @@ static void skl_compute_plane_wm(const struct intel_crtc_state *crtc_state,if (wp->y_tiled) { selected_result =max_fixed16 (method2, wp->y_tile_minimum); + }else if (DISPLAY_VER (display) >=35 ) { + selected_result = method2; }else { if ((wp->cpp * crtc_state->hw.pipe_mode.crtc_htotal / wp->dbuf_block_size < 1) &&
PATCH v2 31/32 drm/i915/xe3p_lpd: Extend Type-C flow for static DDI allocation
In reply to Gustavo SousaXe3p_LPD has a new feature that allows the driver to allocate at runtime the DDI (TC ones) port to drive a legacy connection on the Type-C subsystem. This allows better resource utilization, because now there is no need to statically reserve ports for legacy connectors on the Type-C subsystem.
That said, our driver is not yet ready for the dynamic allocation. Thus, as an incremental step, let's add the logic containing the required programming sequence for the allocation, but, instead of selecting the first available port, we try so use the 1:1 mapping expected by the driver today.
Bspec: 68954
---
NOTE: This patch is still a WIP. There are some opens to resolve here. Nevertheless, I'm sending it here for early feedback.
For the HIP-index stuff, I have a local refactor started and need to finish it up and send it.
The other open is about concurrent calls to iom_dp_resource_lock(). It is likely that we need to have a software lock to prevent concurrent access to IOM_DP_HW_RESOURCE_SEMAPHORE from our driver.
--- drivers/gpu/drm/i915/display/intel_display_regs.h | 20 ++- drivers/gpu/drm/i915/display/intel_tc.c | 151 +++++++++++++++++++++- 2 files changed, 169 insertions(+), 2 deletions(-)
drivers/gpu/drm/i915/display/intel_display_regs.h +19 -1
@@ -2912,6 +2912,25 @@ enum skl_power_gate {#define DP_PIN_ASSIGNMENT (idx, x) ((x) << ((idx) * 4))/* See enum intel_tc_pin_assignment for the pin assignment field values. */ +/* +* FIXME: There is also a definition for this register in intel_dkl_phy_regs.h. +* We need to consolidate the definitions. +*/ +#define HIP_INDEX_REG0 _MMIO(0x1010a0) +#define HIP_168_INDEX_MASK REG_GENMASK(3, 0) +#define HIP_168_IOM_RES_MGMT REG_FIELD_PREP(HIP_168_INDEX_MASK, 0x1) + +#define IOM_DP_HW_RESOURCE_SEMAPHORE _MMIO(0x168038) +#define IOM_DP_HW_SEMLOCK REG_BIT(31) +#define IOM_REQUESTOR_ID_MASK REG_GENMASK(3, 0) +#define IOM_REQUESTOR_ID_DISPLAY_ENGINE REG_FIELD_PREP(IOM_REQUESTOR_ID_MASK, 0x4) + +#define IOM_DP_RESOURCE_MNG _MMIO(0x16802c) +#define IOM_DDI_CONSUMER_SHIFT (tc_port) ((tc_port) * 4) +#define IOM_DDI_CONSUMER_MASK (tc_port) (0xf << IOM_DDI_CONSUMER_SHIFT(tc_port)) +#define IOM_DDI_CONSUMER (tc_port, x) ((x) << IOM_DDI_CONSUMER_SHIFT(tc_port)) +#define IOM_DDI_CONSUMER_STATIC_TC (tc_port) IOM_DDI_CONSUMER(tc_port, 0x8 + (tc_port)) +#define _TCSS_DDI_STATUS_1 0x161500#define _TCSS_DDI_STATUS_2 0x161504#define TCSS_DDI_STATUS (tc) _MMIO(_PICK_EVEN(tc, \
@@ -2950,5 +2969,4 @@ enum skl_power_gate {#define MTL_TRDPRE_MASK REG_GENMASK(7, 0) -#endif /* __INTEL_DISPLAY_REGS_H__ */
drivers/gpu/drm/i915/display/intel_tc.c +150 -1
189 lines not on this page · raw message
Signature · 1 line
2.51.0
PATCH v2 32/32 drm/i915/nvls: Add NVL-S display support
In reply to Gustavo SousaFrom: Sai Teja Pottumuttu <[email protected]>
Add platform description and PCI IDs for NVL-S.
BSpec: 74201
--- drivers/gpu/drm/i915/display/intel_display_device.c | 5 +++++ drivers/gpu/drm/i915/display/intel_display_device.h | 4 +++- 2 files changed, 8 insertions(+), 1 deletion(-)
drivers/gpu/drm/i915/display/intel_display_device.c +5 -0
@@ -1420,6 +1420,10 @@ static const struct platform_desc ptl_desc = { } }; +static const struct platform_desc nvl_desc = { +PLATFORM (novalake), +}; +__diag_pop ();/*
@@ -1495,6 +1499,7 @@ static const struct {INTEL_BMG_IDS (INTEL_DISPLAY_DEVICE , &bmg_desc),INTEL_PTL_IDS (INTEL_DISPLAY_DEVICE , &ptl_desc),INTEL_WCL_IDS (INTEL_DISPLAY_DEVICE , &ptl_desc), + INTEL_NVLS_IDS(INTEL_DISPLAY_DEVICE, &nvl_desc), }; static const struct {
drivers/gpu/drm/i915/display/intel_display_device.h +3 -1
@@ -102,7 +102,9 @@ struct pci_dev; func(battlemage) \ /* Display ver 30 (based on GMD ID) */ \ func(pantherlake) \ - func(pantherlake_wildcatlake) + func(pantherlake_wildcatlake) \ + /* Display ver 35 (based on GMD ID) */ \ + func(novalake) #define __MEMBER(name) unsigned long name:1;
Signature · 1 line
2.51.0
Re: [PATCH v2 32/32] drm/i915/nvls: Add NVL-S display support
Quoted 7 lines · Gustavo Sousa
From: Sai Teja Pottumuttu <[email protected]>
Add platform description and PCI IDs for NVL-S.
BSpec: 74201
Signed-off-by Sai Teja Pottumuttu <[email protected]>Signed-off-by Gustavo Sousa <[email protected]>
LGTM,
Quoted 44 lines
--- drivers/gpu/drm/i915/display/intel_display_device.c | 5 +++++ drivers/gpu/drm/i915/display/intel_display_device.h | 4 +++- 2 files changed, 8 insertions(+), 1 deletion(-)drivers/gpu/drm/i915/display/intel_display_device.c +5
-0@@ -1420,6 +1420,10 @@ static const struct platform_desc ptl_desc = { } }; +static const struct platform_desc nvl_desc = { +PLATFORM (novalake), +}; +__diag_pop ();/* @@ -1495,6 +1499,7 @@ static const struct {INTEL_BMG_IDS (INTEL_DISPLAY_DEVICE , &bmg_desc),INTEL_PTL_IDS (INTEL_DISPLAY_DEVICE , &ptl_desc),INTEL_WCL_IDS (INTEL_DISPLAY_DEVICE , &ptl_desc), + INTEL_NVLS_IDS(INTEL_DISPLAY_DEVICE, &nvl_desc), }; static const struct {drivers/gpu/drm/i915/display/intel_display_device.h +3
-1@@ -102,7 +102,9 @@ struct pci_dev; func(battlemage) \ /* Display ver 30 (based on GMD ID) */ \ func(pantherlake) \ - func(pantherlake_wildcatlake) + func(pantherlake_wildcatlake) \ + /* Display ver 35 (based on GMD ID) */ \ + func(novalake) #define __MEMBER(name) unsigned long name:1;
Patchwork
CI✗ CI.checkpatch: warning for drm/i915/display: Add initial support for Xe3p_LPD (rev2)
In reply to Gustavo Sousa== Series Details ==
== Series Details ==
Series: drm/i915/display: Add initial support for Xe3p_LPD (rev2)
URL : https://patchwork.freedesktop.org/series/155951/
State : warning
== Summary ==
+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master 8677d3b99d5fd579c143b22605d99121e2482e8a
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit 387f9710ae42dfc13a4855b133bc0ccdc6b25ed9
Author: Sai Teja Pottumuttu <[email protected]> Date: Tue Oct 21 21:28:57 2025 -0300
drm/i915/nvls: Add NVL-S display support
Add platform description and PCI IDs for NVL-S.
BSpec: 74201
+ /mt/dim checkpatch fb0f56ad8a2c9953c57c3337a72ccbf9c5050687 drm-intel 83c8f8f1f923 drm/i915/xe3p_lpd: Add Xe3p_LPD display IP features 6b15382528f0 drm/i915/xe3p_lpd: Drop north display reset option programming 61bf516479a9 drm/i915/display: Use braces for if-ladder in intel_bw_init_hw() 62329d343d1a drm/i915/dram: Add field ecc_impacting_de_bw2272d8259525 drm/i915/xe3p_lpd: Update bandwidth parameters000a8ad89bba drm/i915/xe3p_lpd: Expand bifield masks dbuf blocks fields 51f2795f4702 drm/i915/xe3p_lpd: Support UINT16 formats
-:26: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses #26: FILE: drivers/gpu/drm/i915/display/skl_universal_plane.c:139:
+#define ICL_HDR_PLANE_FORMATS \
+ DRM_FORMAT_C8, \
+ DRM_FORMAT_RGB565, \
+ DRM_FORMAT_XRGB8888, \
+ DRM_FORMAT_XBGR8888, \
+ DRM_FORMAT_ARGB8888, \
+ DRM_FORMAT_ABGR8888, \
+ DRM_FORMAT_XRGB2101010, \
+ DRM_FORMAT_XBGR2101010, \
+ DRM_FORMAT_ARGB2101010, \
+ DRM_FORMAT_ABGR2101010, \
+ DRM_FORMAT_XRGB16161616F, \
+ DRM_FORMAT_XBGR16161616F, \
+ DRM_FORMAT_ARGB16161616F, \
+ DRM_FORMAT_ABGR16161616F, \
+ DRM_FORMAT_YUYV, \
+ DRM_FORMAT_YVYU, \
+ DRM_FORMAT_UYVY, \
+ DRM_FORMAT_VYUY, \
+ DRM_FORMAT_NV12, \
+ DRM_FORMAT_P010, \
+ DRM_FORMAT_P012, \
+ DRM_FORMAT_P016, \
+ DRM_FORMAT_Y210, \
+ DRM_FORMAT_Y212, \
+ DRM_FORMAT_Y216, \
+ DRM_FORMAT_XYUV8888, \
+ DRM_FORMAT_XVYU2101010, \
+ DRM_FORMAT_XVYU12_16161616, \
+ DRM_FORMAT_XVYU16161616
BUT SEE:
do {} while (0) advice is over-stated in a few situations:
The more obvious case is macros, like MODULE_PARM_DESC, invoked at file-scope, where C disallows code (it must be in functions). See $exceptions if you have one to add by name.
More troublesome is declarative macros used at top of new scope, like DECLARE_PER_CPU. These might just compile with a do-while-0 wrapper, but would be incorrect. Most of these are handled by detecting struct,union,etc declaration primitives in $exceptions.
Theres also macros called inside an if (block), which "return" an expression. These cannot do-while, and need a ({}) wrapper.
Enjoy this qualification while we work to improve our heuristics.
total: 1 errors, 0 warnings, 0 checks, 134 lines checked 31399ec88037 drm/i915/xe3p_lpd: Extend FBC support to UINT16 formats 690063b5e6dd drm/i915/xe3p_lpd: Horizontal flip support for linear surfaces d25b6d5431b3 drm/i915/xe3p_lpd: Wait for AUX channel power status c9299e73b03a drm/i915/xe3p_lpd: Underrun debuggability and error codes/hints 92f80d12e10f drm/i915/xe3p_lpd: Remove gamma,csc bottom color checks b27a1a95fe61 drm/i915/xe3p_lpd: Adapt to updates on MBUS_CTL/DBUF_CTL registers -:90: WARNING:LONG_LINE: line length of 104 exceeds 100 columns #90: FILE: drivers/gpu/drm/i915/display/skl_watermark_regs.h:41:
+#define MBUS_JOIN_PIPE_SELECT(pipe) REG_FIELD_PREP(MBUS_JOIN_PIPE_SELECT_MASK, pipe)
-:93: WARNING:LONG_LINE: line length of 111 exceeds 100 columns #93: FILE: drivers/gpu/drm/i915/display/skl_watermark_regs.h:44:
+#define MBUS_TRANSLATION_THROTTLE_MIN(val) REG_FIELD_PREP(MBUS_TRANSLATION_THROTTLE_MIN_MASK, val)
-:95: WARNING:LONG_LINE: line length of 116 exceeds 100 columns #95: FILE: drivers/gpu/drm/i915/display/skl_watermark_regs.h:46:
+#define XE3P_MBUS_TRANSLATION_THROTTLE_MIN(val) REG_FIELD_PREP(XE3P_MBUS_TRANSLATION_THROTTLE_MIN_MASK, val)
-:129: WARNING:LONG_LINE: line length of 106 exceeds 100 columns #129: FILE: drivers/gpu/drm/i915/display/skl_watermark_regs.h:68:
+#define DBUF_TRACKER_STATE_SERVICE(x) REG_FIELD_PREP(DBUF_TRACKER_STATE_SERVICE_MASK, x)
-:133: WARNING:LONG_LINE: line length of 115 exceeds 100 columns #133: FILE: drivers/gpu/drm/i915/display/skl_watermark_regs.h:72:
+#define XE3P_DBUF_MIN_TRACKER_STATE_SERVICE(x) REG_FIELD_PREP(XE3P_DBUF_MIN_TRACKER_STATE_SERVICE_MASK, x)
total: 0 errors, 5 warnings, 0 checks, 93 lines checked d974777d47bf drm/i915/wm: Reorder adjust_wm_latency() for Xe3_LPD dd6fb557f35d drm/i915/xe3p_lpd: Always apply level-0 watermark adjustment ca8e49b5183f drm/i915/xe3p_lpd: Add CDCLK tableb377c411618d drm/i915/xe3p_lpd: Load DMC firmware 88c79c22277f drm/i915/xe3p_lpd: Drop support for interlace mode 53d11d92ebdd drm/i915/xe3p_lpd: PSR SU minimum lines is 4 ce331e8fadb3 drm/i915/xe3p_lpd: Enable system caching for FBC -:109: WARNING:LONG_LINE: line length of 101 exceeds 100 columns #109: FILE: drivers/gpu/drm/i915/display/intel_fbc_regs.h:133:
+#define FBC_SYS_CACHE_START_BASE(base) REG_FIELD_PREP(FBC_SYS_CACHE_START_BASE_MASK, (base))
-:111: WARNING:LONG_LINE: line length of 101 exceeds 100 columns #111: FILE: drivers/gpu/drm/i915/display/intel_fbc_regs.h:135:
+#define FBC_SYS_CACHEABLE_RANGE(range) REG_FIELD_PREP(FBC_SYS_CACHEABLE_RANGE_MASK, (range))
total: 0 errors, 2 warnings, 0 checks, 90 lines checkeda3bca120437c drm/i915/xe3p_lpd: Extend Wa_160255735750eb17bacc065 drm/i915/xe3p_lpd: Don't allow odd ypan or ysize with semiplanar format 12b452115ca9 drm/i915/xe3p_lpd: Reload DMC MMIO for pipes C and D 83fba4a5f9c4 drm/i915/xe3p_lpd: Introduce pixel normalizer config support -:84: WARNING:LONG_LINE: line length of 121 exceeds 100 columns
#84: FILE: drivers/gpu/drm/i915/display/skl_universal_plane_regs.h:464:
+ _PLANE_PIXEL_NORMALIZE_1_A, _PLANE_PIXEL_NORMALIZE_1_B, \
-:85: WARNING:LONG_LINE: line length of 119 exceeds 100 columns #85: FILE: drivers/gpu/drm/i915/display/skl_universal_plane_regs.h:465:
+ _PLANE_PIXEL_NORMALIZE_2_A, _PLANE_PIXEL_NORMALIZE_2_B)
-:88: WARNING:LONG_LINE: line length of 117 exceeds 100 columns #88: FILE: drivers/gpu/drm/i915/display/skl_universal_plane_regs.h:468:
+#define PLANE_PIXEL_NORMALIZE_NORM_FACTOR(val) REG_FIELD_PREP(PLANE_PIXEL_NORMALIZE_NORM_FACTOR_MASK, (val))
total: 0 errors, 3 warnings, 0 checks, 57 lines checkedde0cf9ba0fb0 drm/i915/xe3p_lpd: Add FBC support for FP16 formats e2f2a8b7c679 drm/i915/xe3p_lpd: Enable pixel normalizer for fp16 formats for FBC 34fb910baedf drm/i915/vbt: Add fields dedicated_external and dyn_port_over_tc 2075fb0d821d drm/i915/power: Use intel_encoder_is_tc()e534f54d6aa3 drm/i915/display: Handle dedicated external ports in intel_encoder_is_tc() 20c7de16a9e7 drm/i915/wm: don't use method1 in Xe3p_LPD onwards 9db84c8aed8e drm/i915/xe3p_lpd: Extend Type-C flow for static DDI allocation -:49: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'tc_port' - possible side-effects? #49: FILE: drivers/gpu/drm/i915/display/intel_display_regs.h:2932:
+#define IOM_DDI_CONSUMER_STATIC_TC(tc_port) IOM_DDI_CONSUMER(tc_port, 0x8 + (tc_port))
total: 0 errors, 0 warnings, 1 checks, 219 lines checked 387f9710ae42 drm/i915/nvls: Add NVL-S display support
Patchwork
CI✓ CI.KUnit: success for drm/i915/display: Add initial support for Xe3p_LPD (rev2)
In reply to Gustavo Sousa== Series Details ==
== Series Details ==
Series: drm/i915/display: Add initial support for Xe3p_LPD (rev2)
URL : https://patchwork.freedesktop.org/series/155951/
State : success
== Summary ==
+ trap cleanup EXIT
+ /kernel/tools/testing/kunit/kunit.py run --kunitconfig /kernel/drivers/gpu/drm/xe/.kunitconfig [01:38:38] Configuring KUnit Kernel ...
Generating .config ...
Populating config with:
$ make ARCH=um O=.kunit olddefconfig [01:38:42] Building KUnit Kernel ... Populating config with: $ make ARCH=um O=.kunit olddefconfig Building with: $ make all compile_commands.json scripts_gdb ARCH=um O=.kunit --jobs=48 [01:39:13] Starting KUnit Kernel (1/1)... [01:39:13] ============================================================ Running tests with: $ .kunit/linux kunit.enable=1 mem=1G console=tty kunit_shutdown=halt [01:39:13] ================== guc_buf (11 subtests) =================== [01:39:13] [PASSED] test_smallest [01:39:13] [PASSED] test_largest [01:39:13] [PASSED] test_granular [01:39:13] [PASSED] test_unique [01:39:13] [PASSED] test_overlap [01:39:13] [PASSED] test_reusable [01:39:13] [PASSED] test_too_big [01:39:13] [PASSED] test_flush [01:39:13] [PASSED] test_lookup [01:39:13] [PASSED] test_data [01:39:13] [PASSED] test_class [01:39:13] ===================== [PASSED] guc_buf ===================== [01:39:13] =================== guc_dbm (7 subtests) =================== [01:39:13] [PASSED] test_empty [01:39:13] [PASSED] test_default [01:39:13] ======================== test_size ======================== [01:39:13] [PASSED] 4 [01:39:13] [PASSED] 8 [01:39:13] [PASSED] 32 [01:39:13] [PASSED] 256 [01:39:13] ==================== [PASSED] test_size ==================== [01:39:13] ======================= test_reuse ======================== [01:39:13] [PASSED] 4 [01:39:13] [PASSED] 8 [01:39:13] [PASSED] 32 [01:39:13] [PASSED] 256 [01:39:13] =================== [PASSED] test_reuse ==================== [01:39:13] =================== test_range_overlap ==================== [01:39:13] [PASSED] 4 [01:39:13] [PASSED] 8 [01:39:13] [PASSED] 32 [01:39:13] [PASSED] 256 [01:39:13] =============== [PASSED] test_range_overlap ================ [01:39:13] =================== test_range_compact ==================== [01:39:13] [PASSED] 4 [01:39:13] [PASSED] 8 [01:39:13] [PASSED] 32 [01:39:13] [PASSED] 256 [01:39:13] =============== [PASSED] test_range_compact ================ [01:39:13] ==================== test_range_spare ===================== [01:39:13] [PASSED] 4 [01:39:13] [PASSED] 8 [01:39:13] [PASSED] 32 [01:39:13] [PASSED] 256 [01:39:13] ================ [PASSED] test_range_spare ================= [01:39:13] ===================== [PASSED] guc_dbm ===================== [01:39:13] =================== guc_idm (6 subtests) =================== [01:39:13] [PASSED] bad_init [01:39:13] [PASSED] no_init [01:39:13] [PASSED] init_fini [01:39:13] [PASSED] check_used [01:39:13] [PASSED] check_quota [01:39:13] [PASSED] check_all [01:39:13] ===================== [PASSED] guc_idm ===================== [01:39:13] ================== no_relay (3 subtests) =================== [01:39:13] [PASSED] xe_drops_guc2pf_if_not_ready [01:39:13] [PASSED] xe_drops_guc2vf_if_not_ready [01:39:13] [PASSED] xe_rejects_send_if_not_ready [01:39:13] ==================== [PASSED] no_relay ===================== [01:39:13] ================== pf_relay (14 subtests) ================== [01:39:13] [PASSED] pf_rejects_guc2pf_too_short [01:39:13] [PASSED] pf_rejects_guc2pf_too_long [01:39:13] [PASSED] pf_rejects_guc2pf_no_payload [01:39:13] [PASSED] pf_fails_no_payload [01:39:13] [PASSED] pf_fails_bad_origin [01:39:13] [PASSED] pf_fails_bad_type [01:39:13] [PASSED] pf_txn_reports_error [01:39:13] [PASSED] pf_txn_sends_pf2guc [01:39:13] [PASSED] pf_sends_pf2guc [01:39:13] [SKIPPED] pf_loopback_nop [01:39:13] [SKIPPED] pf_loopback_echo [01:39:13] [SKIPPED] pf_loopback_fail [01:39:13] [SKIPPED] pf_loopback_busy [01:39:13] [SKIPPED] pf_loopback_retry [01:39:13] ==================== [PASSED] pf_relay ===================== [01:39:13] ================== vf_relay (3 subtests) =================== [01:39:13] [PASSED] vf_rejects_guc2vf_too_short [01:39:13] [PASSED] vf_rejects_guc2vf_too_long [01:39:13] [PASSED] vf_rejects_guc2vf_no_payload [01:39:13] ==================== [PASSED] vf_relay ===================== [01:39:13] ===================== lmtt (1 subtest) ===================== [01:39:13] ======================== test_ops ========================= [01:39:13] [PASSED] 2-level [01:39:13] [PASSED] multi-level [01:39:13] ==================== [PASSED] test_ops ===================== [01:39:13] ====================== [PASSED] lmtt ======================= [01:39:13] ================= pf_service (11 subtests) ================= [01:39:13] [PASSED] pf_negotiate_any [01:39:13] [PASSED] pf_negotiate_base_match [01:39:13] [PASSED] pf_negotiate_base_newer [01:39:13] [PASSED] pf_negotiate_base_next [01:39:13] [SKIPPED] pf_negotiate_base_older [01:39:13] [PASSED] pf_negotiate_base_prev [01:39:13] [PASSED] pf_negotiate_latest_match [01:39:13] [PASSED] pf_negotiate_latest_newer [01:39:13] [PASSED] pf_negotiate_latest_next [01:39:13] [SKIPPED] pf_negotiate_latest_older [01:39:13] [SKIPPED] pf_negotiate_latest_prev [01:39:13] =================== [PASSED] pf_service ==================== [01:39:13] ================= xe_guc_g2g (2 subtests) ================== [01:39:13] ============== xe_live_guc_g2g_kunit_default ============== [01:39:13] ========= [SKIPPED] xe_live_guc_g2g_kunit_default ========== [01:39:13] ============== xe_live_guc_g2g_kunit_allmem =============== [01:39:13] ========== [SKIPPED] xe_live_guc_g2g_kunit_allmem ========== [01:39:13] =================== [SKIPPED] xe_guc_g2g =================== [01:39:13] =================== xe_mocs (2 subtests) =================== [01:39:13] ================ xe_live_mocs_kernel_kunit ================ [01:39:13] =========== [SKIPPED] xe_live_mocs_kernel_kunit ============ [01:39:13] ================ xe_live_mocs_reset_kunit ================= [01:39:13] ============ [SKIPPED] xe_live_mocs_reset_kunit ============ [01:39:13] ==================== [SKIPPED] xe_mocs ===================== [01:39:13] ================= xe_migrate (2 subtests) ================== [01:39:13] ================= xe_migrate_sanity_kunit ================= [01:39:13] ============ [SKIPPED] xe_migrate_sanity_kunit ============= [01:39:13] ================== xe_validate_ccs_kunit ================== [01:39:13] ============= [SKIPPED] xe_validate_ccs_kunit ============== [01:39:13] =================== [SKIPPED] xe_migrate =================== [01:39:13] ================== xe_dma_buf (1 subtest) ================== [01:39:13] ==================== xe_dma_buf_kunit ===================== [01:39:13] ================ [SKIPPED] xe_dma_buf_kunit ================ [01:39:13] =================== [SKIPPED] xe_dma_buf =================== [01:39:13] ================= xe_bo_shrink (1 subtest) ================= [01:39:13] =================== xe_bo_shrink_kunit ==================== [01:39:13] =============== [SKIPPED] xe_bo_shrink_kunit =============== [01:39:13] ================== [SKIPPED] xe_bo_shrink ================== [01:39:13] ==================== xe_bo (2 subtests) ==================== [01:39:13] ================== xe_ccs_migrate_kunit =================== [01:39:13] ============== [SKIPPED] xe_ccs_migrate_kunit ============== [01:39:13] ==================== xe_bo_evict_kunit ==================== [01:39:13] =============== [SKIPPED] xe_bo_evict_kunit ================ [01:39:13] ===================== [SKIPPED] xe_bo ====================== [01:39:13] ==================== args (11 subtests) ==================== [01:39:13] [PASSED] count_args_test [01:39:13] [PASSED] call_args_example [01:39:13] [PASSED] call_args_test [01:39:13] [PASSED] drop_first_arg_example [01:39:13] [PASSED] drop_first_arg_test [01:39:13] [PASSED] first_arg_example [01:39:13] [PASSED] first_arg_test [01:39:13] [PASSED] last_arg_example [01:39:13] [PASSED] last_arg_test [01:39:13] [PASSED] pick_arg_example [01:39:13] [PASSED] sep_comma_example [01:39:13] ====================== [PASSED] args ======================= [01:39:13] =================== xe_pci (3 subtests) ==================== [01:39:13] ==================== check_graphics_ip ==================== [01:39:13] [PASSED] 12.00 Xe_LP [01:39:13] [PASSED] 12.10 Xe_LP+ [01:39:13] [PASSED] 12.55 Xe_HPG [01:39:13] [PASSED] 12.60 Xe_HPC [01:39:13] [PASSED] 12.70 Xe_LPG [01:39:13] [PASSED] 12.71 Xe_LPG [01:39:13] [PASSED] 12.74 Xe_LPG+ [01:39:13] [PASSED] 20.01 Xe2_HPG [01:39:13] [PASSED] 20.02 Xe2_HPG [01:39:13] [PASSED] 20.04 Xe2_LPG [01:39:13] [PASSED] 30.00 Xe3_LPG [01:39:13] [PASSED] 30.01 Xe3_LPG [01:39:13] [PASSED] 30.03 Xe3_LPG [01:39:13] [PASSED] 30.04 Xe3_LPG [01:39:13] [PASSED] 30.05 Xe3_LPG [01:39:13] [PASSED] 35.11 Xe3p_XPC [01:39:13] ================ [PASSED] check_graphics_ip ================ [01:39:13] ===================== check_media_ip ====================== [01:39:13] [PASSED] 12.00 Xe_M [01:39:13] [PASSED] 12.55 Xe_HPM [01:39:13] [PASSED] 13.00 Xe_LPM+ [01:39:13] [PASSED] 13.01 Xe2_HPM [01:39:13] [PASSED] 20.00 Xe2_LPM [01:39:13] [PASSED] 30.00 Xe3_LPM [01:39:13] [PASSED] 30.02 Xe3_LPM [01:39:13] [PASSED] 35.00 Xe3p_LPM [01:39:13] [PASSED] 35.03 Xe3p_HPM [01:39:13] ================= [PASSED] check_media_ip ================== [01:39:13] ================= check_platform_gt_count ================= [01:39:13] [PASSED] 0x9A60 (TIGERLAKE) [01:39:13] [PASSED] 0x9A68 (TIGERLAKE) [01:39:13] [PASSED] 0x9A70 (TIGERLAKE) [01:39:13] [PASSED] 0x9A40 (TIGERLAKE) [01:39:13] [PASSED] 0x9A49 (TIGERLAKE) [01:39:13] [PASSED] 0x9A59 (TIGERLAKE) [01:39:13] [PASSED] 0x9A78 (TIGERLAKE) [01:39:13] [PASSED] 0x9AC0 (TIGERLAKE) [01:39:13] [PASSED] 0x9AC9 (TIGERLAKE) [01:39:13] [PASSED] 0x9AD9 (TIGERLAKE) [01:39:13] [PASSED] 0x9AF8 (TIGERLAKE) [01:39:13] [PASSED] 0x4C80 (ROCKETLAKE) [01:39:13] [PASSED] 0x4C8A (ROCKETLAKE) [01:39:13] [PASSED] 0x4C8B (ROCKETLAKE) [01:39:13] [PASSED] 0x4C8C (ROCKETLAKE) [01:39:13] [PASSED] 0x4C90 (ROCKETLAKE) [01:39:13] [PASSED] 0x4C9A (ROCKETLAKE) [01:39:13] [PASSED] 0x4680 (ALDERLAKE_S) [01:39:13] [PASSED] 0x4682 (ALDERLAKE_S) [01:39:13] [PASSED] 0x4688 (ALDERLAKE_S) [01:39:13] [PASSED] 0x468A (ALDERLAKE_S) [01:39:13] [PASSED] 0x468B (ALDERLAKE_S) [01:39:13] [PASSED] 0x4690 (ALDERLAKE_S) [01:39:13] [PASSED] 0x4692 (ALDERLAKE_S) [01:39:13] [PASSED] 0x4693 (ALDERLAKE_S) [01:39:13] [PASSED] 0x46A0 (ALDERLAKE_P) [01:39:13] [PASSED] 0x46A1 (ALDERLAKE_P) [01:39:13] [PASSED] 0x46A2 (ALDERLAKE_P) [01:39:13] [PASSED] 0x46A3 (ALDERLAKE_P) [01:39:13] [PASSED] 0x46A6 (ALDERLAKE_P) [01:39:13] [PASSED] 0x46A8 (ALDERLAKE_P) [01:39:13] [PASSED] 0x46AA (ALDERLAKE_P) [01:39:13] [PASSED] 0x462A (ALDERLAKE_P) [01:39:13] [PASSED] 0x4626 (ALDERLAKE_P) [01:39:13] [PASSED] 0x4628 (ALDERLAKE_P) [01:39:13] [PASSED] 0x46B0 (ALDERLAKE_P) [01:39:13] [PASSED] 0x46B1 (ALDERLAKE_P) [01:39:13] [PASSED] 0x46B2 (ALDERLAKE_P) [01:39:13] [PASSED] 0x46B3 (ALDERLAKE_P) [01:39:13] [PASSED] 0x46C0 (ALDERLAKE_P) [01:39:13] [PASSED] 0x46C1 (ALDERLAKE_P) [01:39:13] [PASSED] 0x46C2 (ALDERLAKE_P) [01:39:13] [PASSED] 0x46C3 (ALDERLAKE_P) [01:39:13] [PASSED] 0x46D0 (ALDERLAKE_N) [01:39:13] [PASSED] 0x46D1 (ALDERLAKE_N) [01:39:13] [PASSED] 0x46D2 (ALDERLAKE_N) [01:39:13] [PASSED] 0x46D3 (ALDERLAKE_N) [01:39:13] [PASSED] 0x46D4 (ALDERLAKE_N) [01:39:13] [PASSED] 0xA721 (ALDERLAKE_P) [01:39:13] [PASSED] 0xA7A1 (ALDERLAKE_P) [01:39:13] [PASSED] 0xA7A9 (ALDERLAKE_P) [01:39:13] [PASSED] 0xA7AC (ALDERLAKE_P) [01:39:13] [PASSED] 0xA7AD (ALDERLAKE_P) [01:39:13] [PASSED] 0xA720 (ALDERLAKE_P) [01:39:13] [PASSED] 0xA7A0 (ALDERLAKE_P) [01:39:13] [PASSED] 0xA7A8 (ALDERLAKE_P) [01:39:13] [PASSED] 0xA7AA (ALDERLAKE_P) [01:39:13] [PASSED] 0xA7AB (ALDERLAKE_P) [01:39:13] [PASSED] 0xA780 (ALDERLAKE_S) [01:39:13] [PASSED] 0xA781 (ALDERLAKE_S) [01:39:13] [PASSED] 0xA782 (ALDERLAKE_S) [01:39:13] [PASSED] 0xA783 (ALDERLAKE_S) [01:39:13] [PASSED] 0xA788 (ALDERLAKE_S) [01:39:13] [PASSED] 0xA789 (ALDERLAKE_S) [01:39:13] [PASSED] 0xA78A (ALDERLAKE_S) [01:39:13] [PASSED] 0xA78B (ALDERLAKE_S) [01:39:13] [PASSED] 0x4905 (DG1) [01:39:13] [PASSED] 0x4906 (DG1) [01:39:13] [PASSED] 0x4907 (DG1) [01:39:13] [PASSED] 0x4908 (DG1) [01:39:13] [PASSED] 0x4909 (DG1) [01:39:13] [PASSED] 0x56C0 (DG2) [01:39:13] [PASSED] 0x56C2 (DG2) [01:39:13] [PASSED] 0x56C1 (DG2) [01:39:13] [PASSED] 0x7D51 (METEORLAKE) [01:39:13] [PASSED] 0x7DD1 (METEORLAKE) [01:39:13] [PASSED] 0x7D41 (METEORLAKE) [01:39:13] [PASSED] 0x7D67 (METEORLAKE) [01:39:13] [PASSED] 0xB640 (METEORLAKE) [01:39:13] [PASSED] 0x56A0 (DG2) [01:39:13] [PASSED] 0x56A1 (DG2) [01:39:13] [PASSED] 0x56A2 (DG2) [01:39:13] [PASSED] 0x56BE (DG2) [01:39:13] [PASSED] 0x56BF (DG2) [01:39:13] [PASSED] 0x5690 (DG2) [01:39:13] [PASSED] 0x5691 (DG2) [01:39:13] [PASSED] 0x5692 (DG2) [01:39:13] [PASSED] 0x56A5 (DG2) [01:39:13] [PASSED] 0x56A6 (DG2) [01:39:13] [PASSED] 0x56B0 (DG2) [01:39:13] [PASSED] 0x56B1 (DG2) [01:39:13] [PASSED] 0x56BA (DG2) [01:39:13] [PASSED] 0x56BB (DG2) [01:39:13] [PASSED] 0x56BC (DG2) [01:39:13] [PASSED] 0x56BD (DG2) [01:39:13] [PASSED] 0x5693 (DG2) [01:39:13] [PASSED] 0x5694 (DG2) [01:39:13] [PASSED] 0x5695 (DG2) [01:39:13] [PASSED] 0x56A3 (DG2) [01:39:13] [PASSED] 0x56A4 (DG2) [01:39:13] [PASSED] 0x56B2 (DG2) [01:39:13] [PASSED] 0x56B3 (DG2) [01:39:13] [PASSED] 0x5696 (DG2) [01:39:13] [PASSED] 0x5697 (DG2) [01:39:13] [PASSED] 0xB69 (PVC) [01:39:13] [PASSED] 0xB6E (PVC) [01:39:13] [PASSED] 0xBD4 (PVC) [01:39:13] [PASSED] 0xBD5 (PVC) [01:39:13] [PASSED] 0xBD6 (PVC) [01:39:13] [PASSED] 0xBD7 (PVC) [01:39:13] [PASSED] 0xBD8 (PVC) [01:39:13] [PASSED] 0xBD9 (PVC) [01:39:13] [PASSED] 0xBDA (PVC) [01:39:13] [PASSED] 0xBDB (PVC) [01:39:13] [PASSED] 0xBE0 (PVC) [01:39:13] [PASSED] 0xBE1 (PVC) [01:39:13] [PASSED] 0xBE5 (PVC) [01:39:13] [PASSED] 0x7D40 (METEORLAKE) [01:39:13] [PASSED] 0x7D45 (METEORLAKE) [01:39:13] [PASSED] 0x7D55 (METEORLAKE) [01:39:13] [PASSED] 0x7D60 (METEORLAKE) [01:39:13] [PASSED] 0x7DD5 (METEORLAKE) [01:39:13] [PASSED] 0x6420 (LUNARLAKE) [01:39:13] [PASSED] 0x64A0 (LUNARLAKE) [01:39:13] [PASSED] 0x64B0 (LUNARLAKE) [01:39:13] [PASSED] 0xE202 (BATTLEMAGE) [01:39:13] [PASSED] 0xE209 (BATTLEMAGE) [01:39:13] [PASSED] 0xE20B (BATTLEMAGE) [01:39:13] [PASSED] 0xE20C (BATTLEMAGE) [01:39:13] [PASSED] 0xE20D (BATTLEMAGE) [01:39:13] [PASSED] 0xE210 (BATTLEMAGE) [01:39:13] [PASSED] 0xE211 (BATTLEMAGE) [01:39:13] [PASSED] 0xE212 (BATTLEMAGE) [01:39:13] [PASSED] 0xE216 (BATTLEMAGE) [01:39:13] [PASSED] 0xE220 (BATTLEMAGE) [01:39:13] [PASSED] 0xE221 (BATTLEMAGE) [01:39:13] [PASSED] 0xE222 (BATTLEMAGE) [01:39:13] [PASSED] 0xE223 (BATTLEMAGE) [01:39:13] [PASSED] 0xB080 (PANTHERLAKE) [01:39:13] [PASSED] 0xB081 (PANTHERLAKE) [01:39:13] [PASSED] 0xB082 (PANTHERLAKE) [01:39:13] [PASSED] 0xB083 (PANTHERLAKE) [01:39:13] [PASSED] 0xB084 (PANTHERLAKE) [01:39:13] [PASSED] 0xB085 (PANTHERLAKE) [01:39:13] [PASSED] 0xB086 (PANTHERLAKE) [01:39:13] [PASSED] 0xB087 (PANTHERLAKE) [01:39:13] [PASSED] 0xB08F (PANTHERLAKE) [01:39:13] [PASSED] 0xB090 (PANTHERLAKE) [01:39:13] [PASSED] 0xB0A0 (PANTHERLAKE) [01:39:13] [PASSED] 0xB0B0 (PANTHERLAKE) [01:39:13] [PASSED] 0xFD80 (PANTHERLAKE) [01:39:13] [PASSED] 0xFD81 (PANTHERLAKE) [01:39:13] [PASSED] 0xD740 (NOVALAKE_S) [01:39:13] [PASSED] 0xD741 (NOVALAKE_S) [01:39:13] [PASSED] 0xD742 (NOVALAKE_S) [01:39:13] [PASSED] 0xD743 (NOVALAKE_S) [01:39:13] [PASSED] 0xD744 (NOVALAKE_S) [01:39:13] [PASSED] 0xD745 (NOVALAKE_S) [01:39:13] ============= [PASSED] check_platform_gt_count ============= [01:39:13] ===================== [PASSED] xe_pci ====================== [01:39:13] =================== xe_rtp (2 subtests) ==================== [01:39:13] =============== xe_rtp_process_to_sr_tests ================ [01:39:13] [PASSED] coalesce-same-reg [01:39:13] [PASSED] no-match-no-add [01:39:13] [PASSED] match-or [01:39:13] [PASSED] match-or-xfail [01:39:13] [PASSED] no-match-no-add-multiple-rules [01:39:13] [PASSED] two-regs-two-entries [01:39:13] [PASSED] clr-one-set-other [01:39:13] [PASSED] set-field [01:39:13] [PASSED] conflict-duplicate [01:39:13] [PASSED] conflict-not-disjoint [01:39:13] [PASSED] conflict-reg-type [01:39:13] =========== [PASSED] xe_rtp_process_to_sr_tests ============ [01:39:13] ================== xe_rtp_process_tests =================== [01:39:13] [PASSED] active1 [01:39:13] [PASSED] active2 [01:39:13] [PASSED] active-inactive [01:39:13] [PASSED] inactive-active [01:39:13] [PASSED] inactive-1st_or_active-inactive [01:39:13] [PASSED] inactive-2nd_or_active-inactive [01:39:13] [PASSED] inactive-last_or_active-inactive [01:39:13] [PASSED] inactive-no_or_active-inactive stty: 'standard input': Inappropriate ioctl for device [01:39:13] ============== [PASSED] xe_rtp_process_tests =============== [01:39:13] ===================== [PASSED] xe_rtp ====================== [01:39:13] ==================== xe_wa (1 subtest) ===================== [01:39:13] ======================== xe_wa_gt ========================= [01:39:13] [PASSED] TIGERLAKE B0 [01:39:13] [PASSED] DG1 A0 [01:39:13] [PASSED] DG1 B0 [01:39:13] [PASSED] ALDERLAKE_S A0 [01:39:13] [PASSED] ALDERLAKE_S B0 [01:39:13] [PASSED] ALDERLAKE_S C0 [01:39:13] [PASSED] ALDERLAKE_S D0 [01:39:13] [PASSED] ALDERLAKE_P A0 [01:39:13] [PASSED] ALDERLAKE_P B0 [01:39:13] [PASSED] ALDERLAKE_P C0 [01:39:13] [PASSED] ALDERLAKE_S RPLS D0 [01:39:13] [PASSED] ALDERLAKE_P RPLU E0 [01:39:13] [PASSED] DG2 G10 C0 [01:39:13] [PASSED] DG2 G11 B1 [01:39:13] [PASSED] DG2 G12 A1 [01:39:13] [PASSED] METEORLAKE 12.70(Xe_LPG) A0 13.00(Xe_LPM+) A0 [01:39:13] [PASSED] METEORLAKE 12.71(Xe_LPG) A0 13.00(Xe_LPM+) A0 [01:39:13] [PASSED] METEORLAKE 12.74(Xe_LPG+) A0 13.00(Xe_LPM+) A0 [01:39:13] [PASSED] LUNARLAKE 20.04(Xe2_LPG) A0 20.00(Xe2_LPM) A0 [01:39:13] [PASSED] LUNARLAKE 20.04(Xe2_LPG) B0 20.00(Xe2_LPM) A0 [01:39:13] [PASSED] BATTLEMAGE 20.01(Xe2_HPG) A0 13.01(Xe2_HPM) A1 [01:39:13] [PASSED] PANTHERLAKE 30.00(Xe3_LPG) A0 30.00(Xe3_LPM) A0 [01:39:13] ==================== [PASSED] xe_wa_gt ===================== [01:39:13] ====================== [PASSED] xe_wa ====================== [01:39:13] ============================================================ [01:39:13] Testing complete. Ran 317 tests: passed: 299, skipped: 18 [01:39:13] Elapsed time: 35.079s total, 4.195s configuring, 30.518s building, 0.338s running
+ /kernel/tools/testing/kunit/kunit.py run --kunitconfig /kernel/drivers/gpu/drm/tests/.kunitconfig [01:39:13] Configuring KUnit Kernel ...
Regenerating .config ...
Populating config with:
$ make ARCH=um O=.kunit olddefconfig [01:39:15] Building KUnit Kernel ... Populating config with: $ make ARCH=um O=.kunit olddefconfig Building with: $ make all compile_commands.json scripts_gdb ARCH=um O=.kunit --jobs=48 [01:39:39] Starting KUnit Kernel (1/1)... [01:39:39] ============================================================ Running tests with: $ .kunit/linux kunit.enable=1 mem=1G console=tty kunit_shutdown=halt [01:39:40] ============ drm_test_pick_cmdline (2 subtests) ============ [01:39:40] [PASSED] drm_test_pick_cmdline_res_1920_1080_60 [01:39:40] =============== drm_test_pick_cmdline_named =============== [01:39:40] [PASSED] NTSC [01:39:40] [PASSED] NTSC-J [01:39:40] [PASSED] PAL [01:39:40] [PASSED] PAL-M [01:39:40] =========== [PASSED] drm_test_pick_cmdline_named =========== [01:39:40] ============== [PASSED] drm_test_pick_cmdline ============== [01:39:40] == drm_test_atomic_get_connector_for_encoder (1 subtest) === [01:39:40] [PASSED] drm_test_drm_atomic_get_connector_for_encoder [01:39:40] ==== [PASSED] drm_test_atomic_get_connector_for_encoder ==== [01:39:40] =========== drm_validate_clone_mode (2 subtests) =========== [01:39:40] ============== drm_test_check_in_clone_mode =============== [01:39:40] [PASSED] in_clone_mode [01:39:40] [PASSED] not_in_clone_mode [01:39:40] ========== [PASSED] drm_test_check_in_clone_mode =========== [01:39:40] =============== drm_test_check_valid_clones =============== [01:39:40] [PASSED] not_in_clone_mode [01:39:40] [PASSED] valid_clone [01:39:40] [PASSED] invalid_clone [01:39:40] =========== [PASSED] drm_test_check_valid_clones =========== [01:39:40] ============= [PASSED] drm_validate_clone_mode ============= [01:39:40] ============= drm_validate_modeset (1 subtest) ============= [01:39:40] [PASSED] drm_test_check_connector_changed_modeset [01:39:40] ============== [PASSED] drm_validate_modeset =============== [01:39:40] ====== drm_test_bridge_get_current_state (2 subtests) ====== [01:39:40] [PASSED] drm_test_drm_bridge_get_current_state_atomic [01:39:40] [PASSED] drm_test_drm_bridge_get_current_state_legacy [01:39:40] ======== [PASSED] drm_test_bridge_get_current_state ======== [01:39:40] ====== drm_test_bridge_helper_reset_crtc (3 subtests) ====== [01:39:40] [PASSED] drm_test_drm_bridge_helper_reset_crtc_atomic [01:39:40] [PASSED] drm_test_drm_bridge_helper_reset_crtc_atomic_disabled [01:39:40] [PASSED] drm_test_drm_bridge_helper_reset_crtc_legacy [01:39:40] ======== [PASSED] drm_test_bridge_helper_reset_crtc ======== [01:39:40] ============== drm_bridge_alloc (2 subtests) =============== [01:39:40] [PASSED] drm_test_drm_bridge_alloc_basic [01:39:40] [PASSED] drm_test_drm_bridge_alloc_get_put [01:39:40] ================ [PASSED] drm_bridge_alloc ================= [01:39:40] ================== drm_buddy (8 subtests) ================== [01:39:40] [PASSED] drm_test_buddy_alloc_limit [01:39:40] [PASSED] drm_test_buddy_alloc_optimistic [01:39:40] [PASSED] drm_test_buddy_alloc_pessimistic [01:39:40] [PASSED] drm_test_buddy_alloc_pathological [01:39:40] [PASSED] drm_test_buddy_alloc_contiguous [01:39:40] [PASSED] drm_test_buddy_alloc_clear [01:39:40] [PASSED] drm_test_buddy_alloc_range_bias [01:39:40] [PASSED] drm_test_buddy_fragmentation_performance [01:39:40] ==================== [PASSED] drm_buddy ==================== [01:39:40] ============= drm_cmdline_parser (40 subtests) ============= [01:39:40] [PASSED] drm_test_cmdline_force_d_only [01:39:40] [PASSED] drm_test_cmdline_force_D_only_dvi [01:39:40] [PASSED] drm_test_cmdline_force_D_only_hdmi [01:39:40] [PASSED] drm_test_cmdline_force_D_only_not_digital [01:39:40] [PASSED] drm_test_cmdline_force_e_only [01:39:40] [PASSED] drm_test_cmdline_res [01:39:40] [PASSED] drm_test_cmdline_res_vesa [01:39:40] [PASSED] drm_test_cmdline_res_vesa_rblank [01:39:40] [PASSED] drm_test_cmdline_res_rblank [01:39:40] [PASSED] drm_test_cmdline_res_bpp [01:39:40] [PASSED] drm_test_cmdline_res_refresh [01:39:40] [PASSED] drm_test_cmdline_res_bpp_refresh [01:39:40] [PASSED] drm_test_cmdline_res_bpp_refresh_interlaced [01:39:40] [PASSED] drm_test_cmdline_res_bpp_refresh_margins [01:39:40] [PASSED] drm_test_cmdline_res_bpp_refresh_force_off [01:39:40] [PASSED] drm_test_cmdline_res_bpp_refresh_force_on [01:39:40] [PASSED] drm_test_cmdline_res_bpp_refresh_force_on_analog [01:39:40] [PASSED] drm_test_cmdline_res_bpp_refresh_force_on_digital [01:39:40] [PASSED] drm_test_cmdline_res_bpp_refresh_interlaced_margins_force_on [01:39:40] [PASSED] drm_test_cmdline_res_margins_force_on [01:39:40] [PASSED] drm_test_cmdline_res_vesa_margins [01:39:40] [PASSED] drm_test_cmdline_name [01:39:40] [PASSED] drm_test_cmdline_name_bpp [01:39:40] [PASSED] drm_test_cmdline_name_option [01:39:40] [PASSED] drm_test_cmdline_name_bpp_option [01:39:40] [PASSED] drm_test_cmdline_rotate_0 [01:39:40] [PASSED] drm_test_cmdline_rotate_90 [01:39:40] [PASSED] drm_test_cmdline_rotate_180 [01:39:40] [PASSED] drm_test_cmdline_rotate_270 [01:39:40] [PASSED] drm_test_cmdline_hmirror [01:39:40] [PASSED] drm_test_cmdline_vmirror [01:39:40] [PASSED] drm_test_cmdline_margin_options [01:39:40] [PASSED] drm_test_cmdline_multiple_options [01:39:40] [PASSED] drm_test_cmdline_bpp_extra_and_option [01:39:40] [PASSED] drm_test_cmdline_extra_and_option [01:39:40] [PASSED] drm_test_cmdline_freestanding_options [01:39:40] [PASSED] drm_test_cmdline_freestanding_force_e_and_options [01:39:40] [PASSED] drm_test_cmdline_panel_orientation [01:39:40] ================ drm_test_cmdline_invalid ================= [01:39:40] [PASSED] margin_only [01:39:40] [PASSED] interlace_only [01:39:40] [PASSED] res_missing_x [01:39:40] [PASSED] res_missing_y [01:39:40] [PASSED] res_bad_y [01:39:40] [PASSED] res_missing_y_bpp [01:39:40] [PASSED] res_bad_bpp [01:39:40] [PASSED] res_bad_refresh [01:39:40] [PASSED] res_bpp_refresh_force_on_off [01:39:40] [PASSED] res_invalid_mode [01:39:40] [PASSED] res_bpp_wrong_place_mode [01:39:40] [PASSED] name_bpp_refresh [01:39:40] [PASSED] name_refresh [01:39:40] [PASSED] name_refresh_wrong_mode [01:39:40] [PASSED] name_refresh_invalid_mode [01:39:40] [PASSED] rotate_multiple [01:39:40] [PASSED] rotate_invalid_val [01:39:40] [PASSED] rotate_truncated [01:39:40] [PASSED] invalid_option [01:39:40] [PASSED] invalid_tv_option [01:39:40] [PASSED] truncated_tv_option [01:39:40] ============ [PASSED] drm_test_cmdline_invalid ============= [01:39:40] =============== drm_test_cmdline_tv_options =============== [01:39:40] [PASSED] NTSC [01:39:40] [PASSED] NTSC_443 [01:39:40] [PASSED] NTSC_J [01:39:40] [PASSED] PAL [01:39:40] [PASSED] PAL_M [01:39:40] [PASSED] PAL_N [01:39:40] [PASSED] SECAM [01:39:40] [PASSED] MONO_525 [01:39:40] [PASSED] MONO_625 [01:39:40] =========== [PASSED] drm_test_cmdline_tv_options =========== [01:39:40] =============== [PASSED] drm_cmdline_parser ================ [01:39:40] ========== drmm_connector_hdmi_init (20 subtests) ========== [01:39:40] [PASSED] drm_test_connector_hdmi_init_valid [01:39:40] [PASSED] drm_test_connector_hdmi_init_bpc_8 [01:39:40] [PASSED] drm_test_connector_hdmi_init_bpc_10 [01:39:40] [PASSED] drm_test_connector_hdmi_init_bpc_12 [01:39:40] [PASSED] drm_test_connector_hdmi_init_bpc_invalid [01:39:40] [PASSED] drm_test_connector_hdmi_init_bpc_null [01:39:40] [PASSED] drm_test_connector_hdmi_init_formats_empty [01:39:40] [PASSED] drm_test_connector_hdmi_init_formats_no_rgb [01:39:40] === drm_test_connector_hdmi_init_formats_yuv420_allowed === [01:39:40] [PASSED] supported_formats=0x9 yuv420_allowed=1 [01:39:40] [PASSED] supported_formats=0x9 yuv420_allowed=0 [01:39:40] [PASSED] supported_formats=0x3 yuv420_allowed=1 [01:39:40] [PASSED] supported_formats=0x3 yuv420_allowed=0 [01:39:40] === [PASSED] drm_test_connector_hdmi_init_formats_yuv420_allowed === [01:39:40] [PASSED] drm_test_connector_hdmi_init_null_ddc [01:39:40] [PASSED] drm_test_connector_hdmi_init_null_product [01:39:40] [PASSED] drm_test_connector_hdmi_init_null_vendor [01:39:40] [PASSED] drm_test_connector_hdmi_init_product_length_exact [01:39:40] [PASSED] drm_test_connector_hdmi_init_product_length_too_long [01:39:40] [PASSED] drm_test_connector_hdmi_init_product_valid [01:39:40] [PASSED] drm_test_connector_hdmi_init_vendor_length_exact [01:39:40] [PASSED] drm_test_connector_hdmi_init_vendor_length_too_long [01:39:40] [PASSED] drm_test_connector_hdmi_init_vendor_valid [01:39:40] ========= drm_test_connector_hdmi_init_type_valid ========= [01:39:40] [PASSED] HDMI-A [01:39:40] [PASSED] HDMI-B [01:39:40] ===== [PASSED] drm_test_connector_hdmi_init_type_valid ===== [01:39:40] ======== drm_test_connector_hdmi_init_type_invalid ======== [01:39:40] [PASSED] Unknown [01:39:40] [PASSED] VGA [01:39:40] [PASSED] DVI-I [01:39:40] [PASSED] DVI-D [01:39:40] [PASSED] DVI-A [01:39:40] [PASSED] Composite [01:39:40] [PASSED] SVIDEO [01:39:40] [PASSED] LVDS [01:39:40] [PASSED] Component [01:39:40] [PASSED] DIN [01:39:40] [PASSED] DP [01:39:40] [PASSED] TV [01:39:40] [PASSED] eDP [01:39:40] [PASSED] Virtual [01:39:40] [PASSED] DSI [01:39:40] [PASSED] DPI [01:39:40] [PASSED] Writeback [01:39:40] [PASSED] SPI [01:39:40] [PASSED] USB [01:39:40] ==== [PASSED] drm_test_connector_hdmi_init_type_invalid ==== [01:39:40] ============ [PASSED] drmm_connector_hdmi_init ============= [01:39:40] ============= drmm_connector_init (3 subtests) ============= [01:39:40] [PASSED] drm_test_drmm_connector_init [01:39:40] [PASSED] drm_test_drmm_connector_init_null_ddc [01:39:40] ========= drm_test_drmm_connector_init_type_valid ========= [01:39:40] [PASSED] Unknown [01:39:40] [PASSED] VGA [01:39:40] [PASSED] DVI-I [01:39:40] [PASSED] DVI-D [01:39:40] [PASSED] DVI-A [01:39:40] [PASSED] Composite [01:39:40] [PASSED] SVIDEO [01:39:40] [PASSED] LVDS [01:39:40] [PASSED] Component [01:39:40] [PASSED] DIN [01:39:40] [PASSED] DP [01:39:40] [PASSED] HDMI-A [01:39:40] [PASSED] HDMI-B [01:39:40] [PASSED] TV [01:39:40] [PASSED] eDP [01:39:40] [PASSED] Virtual [01:39:40] [PASSED] DSI [01:39:40] [PASSED] DPI [01:39:40] [PASSED] Writeback [01:39:40] [PASSED] SPI [01:39:40] [PASSED] USB [01:39:40] ===== [PASSED] drm_test_drmm_connector_init_type_valid ===== [01:39:40] =============== [PASSED] drmm_connector_init =============== [01:39:40] ========= drm_connector_dynamic_init (6 subtests) ========== [01:39:40] [PASSED] drm_test_drm_connector_dynamic_init [01:39:40] [PASSED] drm_test_drm_connector_dynamic_init_null_ddc [01:39:40] [PASSED] drm_test_drm_connector_dynamic_init_not_added [01:39:40] [PASSED] drm_test_drm_connector_dynamic_init_properties [01:39:40] ===== drm_test_drm_connector_dynamic_init_type_valid ====== [01:39:40] [PASSED] Unknown [01:39:40] [PASSED] VGA [01:39:40] [PASSED] DVI-I [01:39:40] [PASSED] DVI-D [01:39:40] [PASSED] DVI-A [01:39:40] [PASSED] Composite [01:39:40] [PASSED] SVIDEO [01:39:40] [PASSED] LVDS [01:39:40] [PASSED] Component [01:39:40] [PASSED] DIN [01:39:40] [PASSED] DP [01:39:40] [PASSED] HDMI-A [01:39:40] [PASSED] HDMI-B [01:39:40] [PASSED] TV [01:39:40] [PASSED] eDP [01:39:40] [PASSED] Virtual [01:39:40] [PASSED] DSI [01:39:40] [PASSED] DPI [01:39:40] [PASSED] Writeback [01:39:40] [PASSED] SPI [01:39:40] [PASSED] USB [01:39:40] = [PASSED] drm_test_drm_connector_dynamic_init_type_valid == [01:39:40] ======== drm_test_drm_connector_dynamic_init_name ========= [01:39:40] [PASSED] Unknown [01:39:40] [PASSED] VGA [01:39:40] [PASSED] DVI-I [01:39:40] [PASSED] DVI-D [01:39:40] [PASSED] DVI-A [01:39:40] [PASSED] Composite [01:39:40] [PASSED] SVIDEO [01:39:40] [PASSED] LVDS [01:39:40] [PASSED] Component [01:39:40] [PASSED] DIN [01:39:40] [PASSED] DP [01:39:40] [PASSED] HDMI-A [01:39:40] [PASSED] HDMI-B [01:39:40] [PASSED] TV [01:39:40] [PASSED] eDP [01:39:40] [PASSED] Virtual [01:39:40] [PASSED] DSI [01:39:40] [PASSED] DPI [01:39:40] [PASSED] Writeback [01:39:40] [PASSED] SPI [01:39:40] [PASSED] USB [01:39:40] ==== [PASSED] drm_test_drm_connector_dynamic_init_name ===== [01:39:40] =========== [PASSED] drm_connector_dynamic_init ============ [01:39:40] ==== drm_connector_dynamic_register_early (4 subtests) ===== [01:39:40] [PASSED] drm_test_drm_connector_dynamic_register_early_on_list [01:39:40] [PASSED] drm_test_drm_connector_dynamic_register_early_defer [01:39:40] [PASSED] drm_test_drm_connector_dynamic_register_early_no_init [01:39:40] [PASSED] drm_test_drm_connector_dynamic_register_early_no_mode_object [01:39:40] ====== [PASSED] drm_connector_dynamic_register_early ======= [01:39:40] ======= drm_connector_dynamic_register (7 subtests) ======== [01:39:40] [PASSED] drm_test_drm_connector_dynamic_register_on_list [01:39:40] [PASSED] drm_test_drm_connector_dynamic_register_no_defer [01:39:40] [PASSED] drm_test_drm_connector_dynamic_register_no_init [01:39:40] [PASSED] drm_test_drm_connector_dynamic_register_mode_object [01:39:40] [PASSED] drm_test_drm_connector_dynamic_register_sysfs [01:39:40] [PASSED] drm_test_drm_connector_dynamic_register_sysfs_name [01:39:40] [PASSED] drm_test_drm_connector_dynamic_register_debugfs [01:39:40] ========= [PASSED] drm_connector_dynamic_register ========== [01:39:40] = drm_connector_attach_broadcast_rgb_property (2 subtests) = [01:39:40] [PASSED] drm_test_drm_connector_attach_broadcast_rgb_property [01:39:40] [PASSED] drm_test_drm_connector_attach_broadcast_rgb_property_hdmi_connector [01:39:40] === [PASSED] drm_connector_attach_broadcast_rgb_property === [01:39:40] ========== drm_get_tv_mode_from_name (2 subtests) ========== [01:39:40] ========== drm_test_get_tv_mode_from_name_valid =========== [01:39:40] [PASSED] NTSC [01:39:40] [PASSED] NTSC-443 [01:39:40] [PASSED] NTSC-J [01:39:40] [PASSED] PAL [01:39:40] [PASSED] PAL-M [01:39:40] [PASSED] PAL-N [01:39:40] [PASSED] SECAM [01:39:40] [PASSED] Mono [01:39:40] ====== [PASSED] drm_test_get_tv_mode_from_name_valid ======= [01:39:40] [PASSED] drm_test_get_tv_mode_from_name_truncated [01:39:40] ============ [PASSED] drm_get_tv_mode_from_name ============ [01:39:40] = drm_test_connector_hdmi_compute_mode_clock (12 subtests) = [01:39:40] [PASSED] drm_test_drm_hdmi_compute_mode_clock_rgb [01:39:40] [PASSED] drm_test_drm_hdmi_compute_mode_clock_rgb_10bpc [01:39:40] [PASSED] drm_test_drm_hdmi_compute_mode_clock_rgb_10bpc_vic_1 [01:39:40] [PASSED] drm_test_drm_hdmi_compute_mode_clock_rgb_12bpc [01:39:40] [PASSED] drm_test_drm_hdmi_compute_mode_clock_rgb_12bpc_vic_1 [01:39:40] [PASSED] drm_test_drm_hdmi_compute_mode_clock_rgb_double [01:39:40] = drm_test_connector_hdmi_compute_mode_clock_yuv420_valid = [01:39:40] [PASSED] VIC 96 [01:39:40] [PASSED] VIC 97 [01:39:40] [PASSED] VIC 101 [01:39:40] [PASSED] VIC 102 [01:39:40] [PASSED] VIC 106 [01:39:40] [PASSED] VIC 107 [01:39:40] === [PASSED] drm_test_connector_hdmi_compute_mode_clock_yuv420_valid === [01:39:40] [PASSED] drm_test_connector_hdmi_compute_mode_clock_yuv420_10_bpc [01:39:40] [PASSED] drm_test_connector_hdmi_compute_mode_clock_yuv420_12_bpc [01:39:40] [PASSED] drm_test_connector_hdmi_compute_mode_clock_yuv422_8_bpc [01:39:40] [PASSED] drm_test_connector_hdmi_compute_mode_clock_yuv422_10_bpc [01:39:40] [PASSED] drm_test_connector_hdmi_compute_mode_clock_yuv422_12_bpc [01:39:40] === [PASSED] drm_test_connector_hdmi_compute_mode_clock ==== [01:39:40] == drm_hdmi_connector_get_broadcast_rgb_name (2 subtests) == [01:39:40] === drm_test_drm_hdmi_connector_get_broadcast_rgb_name ==== [01:39:40] [PASSED] Automatic [01:39:40] [PASSED] Full [01:39:40] [PASSED] Limited 16:235 [01:39:40] === [PASSED] drm_test_drm_hdmi_connector_get_broadcast_rgb_name === [01:39:40] [PASSED] drm_test_drm_hdmi_connector_get_broadcast_rgb_name_invalid [01:39:40] ==== [PASSED] drm_hdmi_connector_get_broadcast_rgb_name ==== [01:39:40] == drm_hdmi_connector_get_output_format_name (2 subtests) == [01:39:40] === drm_test_drm_hdmi_connector_get_output_format_name ==== [01:39:40] [PASSED] RGB [01:39:40] [PASSED] YUV 4:2:0 [01:39:40] [PASSED] YUV 4:2:2 [01:39:40] [PASSED] YUV 4:4:4 [01:39:40] === [PASSED] drm_test_drm_hdmi_connector_get_output_format_name === [01:39:40] [PASSED] drm_test_drm_hdmi_connector_get_output_format_name_invalid [01:39:40] ==== [PASSED] drm_hdmi_connector_get_output_format_name ==== [01:39:40] ============= drm_damage_helper (21 subtests) ============== [01:39:40] [PASSED] drm_test_damage_iter_no_damage [01:39:40] [PASSED] drm_test_damage_iter_no_damage_fractional_src [01:39:40] [PASSED] drm_test_damage_iter_no_damage_src_moved [01:39:40] [PASSED] drm_test_damage_iter_no_damage_fractional_src_moved [01:39:40] [PASSED] drm_test_damage_iter_no_damage_not_visible [01:39:40] [PASSED] drm_test_damage_iter_no_damage_no_crtc [01:39:40] [PASSED] drm_test_damage_iter_no_damage_no_fb [01:39:40] [PASSED] drm_test_damage_iter_simple_damage [01:39:40] [PASSED] drm_test_damage_iter_single_damage [01:39:40] [PASSED] drm_test_damage_iter_single_damage_intersect_src [01:39:40] [PASSED] drm_test_damage_iter_single_damage_outside_src [01:39:40] [PASSED] drm_test_damage_iter_single_damage_fractional_src [01:39:40] [PASSED] drm_test_damage_iter_single_damage_intersect_fractional_src [01:39:40] [PASSED] drm_test_damage_iter_single_damage_outside_fractional_src [01:39:40] [PASSED] drm_test_damage_iter_single_damage_src_moved [01:39:40] [PASSED] drm_test_damage_iter_single_damage_fractional_src_moved [01:39:40] [PASSED] drm_test_damage_iter_damage [01:39:40] [PASSED] drm_test_damage_iter_damage_one_intersect [01:39:40] [PASSED] drm_test_damage_iter_damage_one_outside [01:39:40] [PASSED] drm_test_damage_iter_damage_src_moved [01:39:40] [PASSED] drm_test_damage_iter_damage_not_visible [01:39:40] ================ [PASSED] drm_damage_helper ================ [01:39:40] ============== drm_dp_mst_helper (3 subtests) ============== [01:39:40] ============== drm_test_dp_mst_calc_pbn_mode ============== [01:39:40] [PASSED] Clock 154000 BPP 30 DSC disabled [01:39:40] [PASSED] Clock 234000 BPP 30 DSC disabled [01:39:40] [PASSED] Clock 297000 BPP 24 DSC disabled [01:39:40] [PASSED] Clock 332880 BPP 24 DSC enabled [01:39:40] [PASSED] Clock 324540 BPP 24 DSC enabled [01:39:40] ========== [PASSED] drm_test_dp_mst_calc_pbn_mode ========== [01:39:40] ============== drm_test_dp_mst_calc_pbn_div =============== [01:39:40] [PASSED] Link rate 2000000 lane count 4 [01:39:40] [PASSED] Link rate 2000000 lane count 2 [01:39:40] [PASSED] Link rate 2000000 lane count 1 [01:39:40] [PASSED] Link rate 1350000 lane count 4 [01:39:40] [PASSED] Link rate 1350000 lane count 2 [01:39:40] [PASSED] Link rate 1350000 lane count 1 [01:39:40] [PASSED] Link rate 1000000 lane count 4 [01:39:40] [PASSED] Link rate 1000000 lane count 2 [01:39:40] [PASSED] Link rate 1000000 lane count 1 [01:39:40] [PASSED] Link rate 810000 lane count 4 [01:39:40] [PASSED] Link rate 810000 lane count 2 [01:39:40] [PASSED] Link rate 810000 lane count 1 [01:39:40] [PASSED] Link rate 540000 lane count 4 [01:39:40] [PASSED] Link rate 540000 lane count 2 [01:39:40] [PASSED] Link rate 540000 lane count 1 [01:39:40] [PASSED] Link rate 270000 lane count 4 [01:39:40] [PASSED] Link rate 270000 lane count 2 [01:39:40] [PASSED] Link rate 270000 lane count 1 [01:39:40] [PASSED] Link rate 162000 lane count 4 [01:39:40] [PASSED] Link rate 162000 lane count 2 [01:39:40] [PASSED] Link rate 162000 lane count 1 [01:39:40] ========== [PASSED] drm_test_dp_mst_calc_pbn_div =========== [01:39:40] ========= drm_test_dp_mst_sideband_msg_req_decode ========= [01:39:40] [PASSED] DP_ENUM_PATH_RESOURCES with port number [01:39:40] [PASSED] DP_POWER_UP_PHY with port number [01:39:40] [PASSED] DP_POWER_DOWN_PHY with port number [01:39:40] [PASSED] DP_ALLOCATE_PAYLOAD with SDP stream sinks [01:39:40] [PASSED] DP_ALLOCATE_PAYLOAD with port number [01:39:40] [PASSED] DP_ALLOCATE_PAYLOAD with VCPI [01:39:40] [PASSED] DP_ALLOCATE_PAYLOAD with PBN [01:39:40] [PASSED] DP_QUERY_PAYLOAD with port number [01:39:40] [PASSED] DP_QUERY_PAYLOAD with VCPI [01:39:40] [PASSED] DP_REMOTE_DPCD_READ with port number [01:39:40] [PASSED] DP_REMOTE_DPCD_READ with DPCD address [01:39:40] [PASSED] DP_REMOTE_DPCD_READ with max number of bytes [01:39:40] [PASSED] DP_REMOTE_DPCD_WRITE with port number [01:39:40] [PASSED] DP_REMOTE_DPCD_WRITE with DPCD address [01:39:40] [PASSED] DP_REMOTE_DPCD_WRITE with data array [01:39:40] [PASSED] DP_REMOTE_I2C_READ with port number [01:39:40] [PASSED] DP_REMOTE_I2C_READ with I2C device ID [01:39:40] [PASSED] DP_REMOTE_I2C_READ with transactions array [01:39:40] [PASSED] DP_REMOTE_I2C_WRITE with port number [01:39:40] [PASSED] DP_REMOTE_I2C_WRITE with I2C device ID [01:39:40] [PASSED] DP_REMOTE_I2C_WRITE with data array [01:39:40] [PASSED] DP_QUERY_STREAM_ENC_STATUS with stream ID [01:39:40] [PASSED] DP_QUERY_STREAM_ENC_STATUS with client ID [01:39:40] [PASSED] DP_QUERY_STREAM_ENC_STATUS with stream event [01:39:40] [PASSED] DP_QUERY_STREAM_ENC_STATUS with valid stream event [01:39:40] [PASSED] DP_QUERY_STREAM_ENC_STATUS with stream behavior [01:39:40] [PASSED] DP_QUERY_STREAM_ENC_STATUS with a valid stream behavior [01:39:40] ===== [PASSED] drm_test_dp_mst_sideband_msg_req_decode ===== [01:39:40] ================ [PASSED] drm_dp_mst_helper ================ [01:39:40] ================== drm_exec (7 subtests) =================== [01:39:40] [PASSED] sanitycheck [01:39:40] [PASSED] test_lock [01:39:40] [PASSED] test_lock_unlock [01:39:40] [PASSED] test_duplicates [01:39:40] [PASSED] test_prepare [01:39:40] [PASSED] test_prepare_array [01:39:40] [PASSED] test_multiple_loops [01:39:40] ==================== [PASSED] drm_exec ===================== [01:39:40] =========== drm_format_helper_test (17 subtests) =========== [01:39:40] ============== drm_test_fb_xrgb8888_to_gray8 ============== [01:39:40] [PASSED] single_pixel_source_buffer [01:39:40] [PASSED] single_pixel_clip_rectangle [01:39:40] [PASSED] well_known_colors [01:39:40] [PASSED] destination_pitch [01:39:40] ========== [PASSED] drm_test_fb_xrgb8888_to_gray8 ========== [01:39:40] ============= drm_test_fb_xrgb8888_to_rgb332 ============== [01:39:40] [PASSED] single_pixel_source_buffer [01:39:40] [PASSED] single_pixel_clip_rectangle [01:39:40] [PASSED] well_known_colors [01:39:40] [PASSED] destination_pitch [01:39:40] ========= [PASSED] drm_test_fb_xrgb8888_to_rgb332 ========== [01:39:40] ============= drm_test_fb_xrgb8888_to_rgb565 ============== [01:39:40] [PASSED] single_pixel_source_buffer [01:39:40] [PASSED] single_pixel_clip_rectangle [01:39:40] [PASSED] well_known_colors [01:39:40] [PASSED] destination_pitch [01:39:40] ========= [PASSED] drm_test_fb_xrgb8888_to_rgb565 ========== [01:39:40] ============ drm_test_fb_xrgb8888_to_xrgb1555 ============= [01:39:40] [PASSED] single_pixel_source_buffer [01:39:40] [PASSED] single_pixel_clip_rectangle [01:39:40] [PASSED] well_known_colors [01:39:40] [PASSED] destination_pitch [01:39:40] ======== [PASSED] drm_test_fb_xrgb8888_to_xrgb1555 ========= [01:39:40] ============ drm_test_fb_xrgb8888_to_argb1555 ============= [01:39:40] [PASSED] single_pixel_source_buffer [01:39:40] [PASSED] single_pixel_clip_rectangle [01:39:40] [PASSED] well_known_colors [01:39:40] [PASSED] destination_pitch [01:39:40] ======== [PASSED] drm_test_fb_xrgb8888_to_argb1555 ========= [01:39:40] ============ drm_test_fb_xrgb8888_to_rgba5551 ============= [01:39:40] [PASSED] single_pixel_source_buffer [01:39:40] [PASSED] single_pixel_clip_rectangle [01:39:40] [PASSED] well_known_colors [01:39:40] [PASSED] destination_pitch [01:39:40] ======== [PASSED] drm_test_fb_xrgb8888_to_rgba5551 ========= [01:39:40] ============= drm_test_fb_xrgb8888_to_rgb888 ============== [01:39:40] [PASSED] single_pixel_source_buffer [01:39:40] [PASSED] single_pixel_clip_rectangle [01:39:40] [PASSED] well_known_colors [01:39:40] [PASSED] destination_pitch [01:39:40] ========= [PASSED] drm_test_fb_xrgb8888_to_rgb888 ========== [01:39:40] ============= drm_test_fb_xrgb8888_to_bgr888 ============== [01:39:40] [PASSED] single_pixel_source_buffer [01:39:40] [PASSED] single_pixel_clip_rectangle [01:39:40] [PASSED] well_known_colors [01:39:40] [PASSED] destination_pitch [01:39:40] ========= [PASSED] drm_test_fb_xrgb8888_to_bgr888 ========== [01:39:40] ============ drm_test_fb_xrgb8888_to_argb8888 ============= [01:39:40] [PASSED] single_pixel_source_buffer [01:39:40] [PASSED] single_pixel_clip_rectangle [01:39:40] [PASSED] well_known_colors [01:39:40] [PASSED] destination_pitch [01:39:40] ======== [PASSED] drm_test_fb_xrgb8888_to_argb8888 ========= [01:39:40] =========== drm_test_fb_xrgb8888_to_xrgb2101010 =========== [01:39:40] [PASSED] single_pixel_source_buffer [01:39:40] [PASSED] single_pixel_clip_rectangle [01:39:40] [PASSED] well_known_colors [01:39:40] [PASSED] destination_pitch [01:39:40] ======= [PASSED] drm_test_fb_xrgb8888_to_xrgb2101010 ======= [01:39:40] =========== drm_test_fb_xrgb8888_to_argb2101010 =========== [01:39:40] [PASSED] single_pixel_source_buffer [01:39:40] [PASSED] single_pixel_clip_rectangle [01:39:40] [PASSED] well_known_colors [01:39:40] [PASSED] destination_pitch [01:39:40] ======= [PASSED] drm_test_fb_xrgb8888_to_argb2101010 ======= [01:39:40] ============== drm_test_fb_xrgb8888_to_mono =============== [01:39:40] [PASSED] single_pixel_source_buffer [01:39:40] [PASSED] single_pixel_clip_rectangle [01:39:40] [PASSED] well_known_colors [01:39:40] [PASSED] destination_pitch [01:39:40] ========== [PASSED] drm_test_fb_xrgb8888_to_mono =========== [01:39:40] ==================== drm_test_fb_swab ===================== [01:39:40] [PASSED] single_pixel_source_buffer [01:39:40] [PASSED] single_pixel_clip_rectangle [01:39:40] [PASSED] well_known_colors [01:39:40] [PASSED] destination_pitch [01:39:40] ================ [PASSED] drm_test_fb_swab ================= [01:39:40] ============ drm_test_fb_xrgb8888_to_xbgr8888 ============= [01:39:40] [PASSED] single_pixel_source_buffer [01:39:40] [PASSED] single_pixel_clip_rectangle [01:39:40] [PASSED] well_known_colors [01:39:40] [PASSED] destination_pitch [01:39:40] ======== [PASSED] drm_test_fb_xrgb8888_to_xbgr8888 ========= [01:39:40] ============ drm_test_fb_xrgb8888_to_abgr8888 ============= [01:39:40] [PASSED] single_pixel_source_buffer [01:39:40] [PASSED] single_pixel_clip_rectangle [01:39:40] [PASSED] well_known_colors [01:39:40] [PASSED] destination_pitch [01:39:40] ======== [PASSED] drm_test_fb_xrgb8888_to_abgr8888 ========= [01:39:40] ================= drm_test_fb_clip_offset ================= [01:39:40] [PASSED] pass through [01:39:40] [PASSED] horizontal offset [01:39:40] [PASSED] vertical offset [01:39:40] [PASSED] horizontal and vertical offset [01:39:40] [PASSED] horizontal offset (custom pitch) [01:39:40] [PASSED] vertical offset (custom pitch) [01:39:40] [PASSED] horizontal and vertical offset (custom pitch) [01:39:40] ============= [PASSED] drm_test_fb_clip_offset ============= [01:39:40] =================== drm_test_fb_memcpy ==================== [01:39:40] [PASSED] single_pixel_source_buffer: XR24 little-endian (0x34325258) [01:39:40] [PASSED] single_pixel_source_buffer: XRA8 little-endian (0x38415258) [01:39:40] [PASSED] single_pixel_source_buffer: YU24 little-endian (0x34325559) [01:39:40] [PASSED] single_pixel_clip_rectangle: XB24 little-endian (0x34324258) [01:39:40] [PASSED] single_pixel_clip_rectangle: XRA8 little-endian (0x38415258) [01:39:40] [PASSED] single_pixel_clip_rectangle: YU24 little-endian (0x34325559) [01:39:40] [PASSED] well_known_colors: XB24 little-endian (0x34324258) [01:39:40] [PASSED] well_known_colors: XRA8 little-endian (0x38415258) [01:39:40] [PASSED] well_known_colors: YU24 little-endian (0x34325559) [01:39:40] [PASSED] destination_pitch: XB24 little-endian (0x34324258) [01:39:40] [PASSED] destination_pitch: XRA8 little-endian (0x38415258) [01:39:40] [PASSED] destination_pitch: YU24 little-endian (0x34325559) [01:39:40] =============== [PASSED] drm_test_fb_memcpy ================ [01:39:40] ============= [PASSED] drm_format_helper_test ============== [01:39:40] ================= drm_format (18 subtests) ================= [01:39:40] [PASSED] drm_test_format_block_width_invalid [01:39:40] [PASSED] drm_test_format_block_width_one_plane [01:39:40] [PASSED] drm_test_format_block_width_two_plane [01:39:40] [PASSED] drm_test_format_block_width_three_plane [01:39:40] [PASSED] drm_test_format_block_width_tiled [01:39:40] [PASSED] drm_test_format_block_height_invalid [01:39:40] [PASSED] drm_test_format_block_height_one_plane [01:39:40] [PASSED] drm_test_format_block_height_two_plane [01:39:40] [PASSED] drm_test_format_block_height_three_plane [01:39:40] [PASSED] drm_test_format_block_height_tiled [01:39:40] [PASSED] drm_test_format_min_pitch_invalid [01:39:40] [PASSED] drm_test_format_min_pitch_one_plane_8bpp [01:39:40] [PASSED] drm_test_format_min_pitch_one_plane_16bpp [01:39:40] [PASSED] drm_test_format_min_pitch_one_plane_24bpp [01:39:40] [PASSED] drm_test_format_min_pitch_one_plane_32bpp [01:39:40] [PASSED] drm_test_format_min_pitch_two_plane [01:39:40] [PASSED] drm_test_format_min_pitch_three_plane_8bpp [01:39:40] [PASSED] drm_test_format_min_pitch_tiled [01:39:40] =================== [PASSED] drm_format ==================== [01:39:40] ============== drm_framebuffer (10 subtests) =============== [01:39:40] ========== drm_test_framebuffer_check_src_coords ========== [01:39:40] [PASSED] Success: source fits into fb [01:39:40] [PASSED] Fail: overflowing fb with x-axis coordinate [01:39:40] [PASSED] Fail: overflowing fb with y-axis coordinate [01:39:40] [PASSED] Fail: overflowing fb with source width [01:39:40] [PASSED] Fail: overflowing fb with source height [01:39:40] ====== [PASSED] drm_test_framebuffer_check_src_coords ====== [01:39:40] [PASSED] drm_test_framebuffer_cleanup [01:39:40] =============== drm_test_framebuffer_create =============== [01:39:40] [PASSED] ABGR8888 normal sizes [01:39:40] [PASSED] ABGR8888 max sizes [01:39:40] [PASSED] ABGR8888 pitch greater than min required [01:39:40] [PASSED] ABGR8888 pitch less than min required [01:39:40] [PASSED] ABGR8888 Invalid width [01:39:40] [PASSED] ABGR8888 Invalid buffer handle [01:39:40] [PASSED] No pixel format [01:39:40] [PASSED] ABGR8888 Width 0 [01:39:40] [PASSED] ABGR8888 Height 0 [01:39:40] [PASSED] ABGR8888 Out of bound height * pitch combination [01:39:40] [PASSED] ABGR8888 Large buffer offset [01:39:40] [PASSED] ABGR8888 Buffer offset for inexistent plane [01:39:40] [PASSED] ABGR8888 Invalid flag [01:39:40] [PASSED] ABGR8888 Set DRM_MODE_FB_MODIFIERS without modifiers [01:39:40] [PASSED] ABGR8888 Valid buffer modifier [01:39:40] [PASSED] ABGR8888 Invalid buffer modifier(DRM_FORMAT_MOD_SAMSUNG_64_32_TILE) [01:39:40] [PASSED] ABGR8888 Extra pitches without DRM_MODE_FB_MODIFIERS [01:39:40] [PASSED] ABGR8888 Extra pitches with DRM_MODE_FB_MODIFIERS [01:39:40] [PASSED] NV12 Normal sizes [01:39:40] [PASSED] NV12 Max sizes [01:39:40] [PASSED] NV12 Invalid pitch [01:39:40] [PASSED] NV12 Invalid modifier/missing DRM_MODE_FB_MODIFIERS flag [01:39:40] [PASSED] NV12 different modifier per-plane [01:39:40] [PASSED] NV12 with DRM_FORMAT_MOD_SAMSUNG_64_32_TILE [01:39:40] [PASSED] NV12 Valid modifiers without DRM_MODE_FB_MODIFIERS [01:39:40] [PASSED] NV12 Modifier for inexistent plane [01:39:40] [PASSED] NV12 Handle for inexistent plane [01:39:40] [PASSED] NV12 Handle for inexistent plane without DRM_MODE_FB_MODIFIERS [01:39:40] [PASSED] YVU420 DRM_MODE_FB_MODIFIERS set without modifier [01:39:40] [PASSED] YVU420 Normal sizes [01:39:40] [PASSED] YVU420 Max sizes [01:39:40] [PASSED] YVU420 Invalid pitch [01:39:40] [PASSED] YVU420 Different pitches [01:39:40] [PASSED] YVU420 Different buffer offsets/pitches [01:39:40] [PASSED] YVU420 Modifier set just for plane 0, without DRM_MODE_FB_MODIFIERS [01:39:40] [PASSED] YVU420 Modifier set just for planes 0, 1, without DRM_MODE_FB_MODIFIERS [01:39:40] [PASSED] YVU420 Modifier set just for plane 0, 1, with DRM_MODE_FB_MODIFIERS [01:39:40] [PASSED] YVU420 Valid modifier [01:39:40] [PASSED] YVU420 Different modifiers per plane [01:39:40] [PASSED] YVU420 Modifier for inexistent plane [01:39:40] [PASSED] YUV420_10BIT Invalid modifier(DRM_FORMAT_MOD_LINEAR) [01:39:40] [PASSED] X0L2 Normal sizes [01:39:40] [PASSED] X0L2 Max sizes [01:39:40] [PASSED] X0L2 Invalid pitch [01:39:40] [PASSED] X0L2 Pitch greater than minimum required [01:39:40] [PASSED] X0L2 Handle for inexistent plane [01:39:40] [PASSED] X0L2 Offset for inexistent plane, without DRM_MODE_FB_MODIFIERS set [01:39:40] [PASSED] X0L2 Modifier without DRM_MODE_FB_MODIFIERS set [01:39:40] [PASSED] X0L2 Valid modifier [01:39:40] [PASSED] X0L2 Modifier for inexistent plane [01:39:40] =========== [PASSED] drm_test_framebuffer_create =========== [01:39:40] [PASSED] drm_test_framebuffer_free [01:39:40] [PASSED] drm_test_framebuffer_init [01:39:40] [PASSED] drm_test_framebuffer_init_bad_format [01:39:40] [PASSED] drm_test_framebuffer_init_dev_mismatch [01:39:40] [PASSED] drm_test_framebuffer_lookup [01:39:40] [PASSED] drm_test_framebuffer_lookup_inexistent [01:39:40] [PASSED] drm_test_framebuffer_modifiers_not_supported [01:39:40] ================= [PASSED] drm_framebuffer ================= [01:39:40] ================ drm_gem_shmem (8 subtests) ================ [01:39:40] [PASSED] drm_gem_shmem_test_obj_create [01:39:40] [PASSED] drm_gem_shmem_test_obj_create_private [01:39:40] [PASSED] drm_gem_shmem_test_pin_pages [01:39:40] [PASSED] drm_gem_shmem_test_vmap [01:39:40] [PASSED] drm_gem_shmem_test_get_pages_sgt [01:39:40] [PASSED] drm_gem_shmem_test_get_sg_table [01:39:40] [PASSED] drm_gem_shmem_test_madvise [01:39:40] [PASSED] drm_gem_shmem_test_purge [01:39:40] ================== [PASSED] drm_gem_shmem ================== [01:39:40] === drm_atomic_helper_connector_hdmi_check (27 subtests) === [01:39:40] [PASSED] drm_test_check_broadcast_rgb_auto_cea_mode [01:39:40] [PASSED] drm_test_check_broadcast_rgb_auto_cea_mode_vic_1 [01:39:40] [PASSED] drm_test_check_broadcast_rgb_full_cea_mode [01:39:40] [PASSED] drm_test_check_broadcast_rgb_full_cea_mode_vic_1 [01:39:40] [PASSED] drm_test_check_broadcast_rgb_limited_cea_mode [01:39:40] [PASSED] drm_test_check_broadcast_rgb_limited_cea_mode_vic_1 [01:39:40] ====== drm_test_check_broadcast_rgb_cea_mode_yuv420 ======= [01:39:40] [PASSED] Automatic [01:39:40] [PASSED] Full [01:39:40] [PASSED] Limited 16:235 [01:39:40] == [PASSED] drm_test_check_broadcast_rgb_cea_mode_yuv420 === [01:39:40] [PASSED] drm_test_check_broadcast_rgb_crtc_mode_changed [01:39:40] [PASSED] drm_test_check_broadcast_rgb_crtc_mode_not_changed [01:39:40] [PASSED] drm_test_check_disable_connector [01:39:40] [PASSED] drm_test_check_hdmi_funcs_reject_rate [01:39:40] [PASSED] drm_test_check_max_tmds_rate_bpc_fallback_rgb [01:39:40] [PASSED] drm_test_check_max_tmds_rate_bpc_fallback_yuv420 [01:39:40] [PASSED] drm_test_check_max_tmds_rate_bpc_fallback_ignore_yuv422 [01:39:40] [PASSED] drm_test_check_max_tmds_rate_bpc_fallback_ignore_yuv420 [01:39:40] [PASSED] drm_test_check_driver_unsupported_fallback_yuv420 [01:39:40] [PASSED] drm_test_check_output_bpc_crtc_mode_changed [01:39:40] [PASSED] drm_test_check_output_bpc_crtc_mode_not_changed [01:39:40] [PASSED] drm_test_check_output_bpc_dvi [01:39:40] [PASSED] drm_test_check_output_bpc_format_vic_1 [01:39:40] [PASSED] drm_test_check_output_bpc_format_display_8bpc_only [01:39:40] [PASSED] drm_test_check_output_bpc_format_display_rgb_only [01:39:40] [PASSED] drm_test_check_output_bpc_format_driver_8bpc_only [01:39:40] [PASSED] drm_test_check_output_bpc_format_driver_rgb_only [01:39:40] [PASSED] drm_test_check_tmds_char_rate_rgb_8bpc [01:39:40] [PASSED] drm_test_check_tmds_char_rate_rgb_10bpc [01:39:40] [PASSED] drm_test_check_tmds_char_rate_rgb_12bpc [01:39:40] ===== [PASSED] drm_atomic_helper_connector_hdmi_check ====== [01:39:40] === drm_atomic_helper_connector_hdmi_reset (6 subtests) ==== [01:39:40] [PASSED] drm_test_check_broadcast_rgb_value [01:39:40] [PASSED] drm_test_check_bpc_8_value [01:39:40] [PASSED] drm_test_check_bpc_10_value [01:39:40] [PASSED] drm_test_check_bpc_12_value [01:39:40] [PASSED] drm_test_check_format_value [01:39:40] [PASSED] drm_test_check_tmds_char_value [01:39:40] ===== [PASSED] drm_atomic_helper_connector_hdmi_reset ====== [01:39:40] = drm_atomic_helper_connector_hdmi_mode_valid (4 subtests) = [01:39:40] [PASSED] drm_test_check_mode_valid [01:39:40] [PASSED] drm_test_check_mode_valid_reject [01:39:40] [PASSED] drm_test_check_mode_valid_reject_rate [01:39:40] [PASSED] drm_test_check_mode_valid_reject_max_clock [01:39:40] === [PASSED] drm_atomic_helper_connector_hdmi_mode_valid === [01:39:40] ================= drm_managed (2 subtests) ================= [01:39:40] [PASSED] drm_test_managed_release_action [01:39:40] [PASSED] drm_test_managed_run_action [01:39:40] =================== [PASSED] drm_managed =================== [01:39:40] =================== drm_mm (6 subtests) ==================== [01:39:40] [PASSED] drm_test_mm_init [01:39:40] [PASSED] drm_test_mm_debug [01:39:40] [PASSED] drm_test_mm_align32 [01:39:40] [PASSED] drm_test_mm_align64 [01:39:40] [PASSED] drm_test_mm_lowest [01:39:40] [PASSED] drm_test_mm_highest [01:39:40] ===================== [PASSED] drm_mm ====================== [01:39:40] ============= drm_modes_analog_tv (5 subtests) ============= [01:39:40] [PASSED] drm_test_modes_analog_tv_mono_576i [01:39:40] [PASSED] drm_test_modes_analog_tv_ntsc_480i [01:39:40] [PASSED] drm_test_modes_analog_tv_ntsc_480i_inlined [01:39:40] [PASSED] drm_test_modes_analog_tv_pal_576i [01:39:40] [PASSED] drm_test_modes_analog_tv_pal_576i_inlined [01:39:40] =============== [PASSED] drm_modes_analog_tv =============== [01:39:40] ============== drm_plane_helper (2 subtests) =============== [01:39:40] =============== drm_test_check_plane_state ================ [01:39:40] [PASSED] clipping_simple [01:39:40] [PASSED] clipping_rotate_reflect [01:39:40] [PASSED] positioning_simple [01:39:40] [PASSED] upscaling [01:39:40] [PASSED] downscaling [01:39:40] [PASSED] rounding1 [01:39:40] [PASSED] rounding2 [01:39:40] [PASSED] rounding3 [01:39:40] [PASSED] rounding4 [01:39:40] =========== [PASSED] drm_test_check_plane_state ============ [01:39:40] =========== drm_test_check_invalid_plane_state ============ [01:39:40] [PASSED] positioning_invalid [01:39:40] [PASSED] upscaling_invalid [01:39:40] [PASSED] downscaling_invalid [01:39:40] ======= [PASSED] drm_test_check_invalid_plane_state ======== [01:39:40] ================ [PASSED] drm_plane_helper ================= [01:39:40] ====== drm_connector_helper_tv_get_modes (1 subtest) ======= [01:39:40] ====== drm_test_connector_helper_tv_get_modes_check ======= [01:39:40] [PASSED] None [01:39:40] [PASSED] PAL [01:39:40] [PASSED] NTSC [01:39:40] [PASSED] Both, NTSC Default [01:39:40] [PASSED] Both, PAL Default [01:39:40] [PASSED] Both, NTSC Default, with PAL on command-line [01:39:40] [PASSED] Both, PAL Default, with NTSC on command-line [01:39:40] == [PASSED] drm_test_connector_helper_tv_get_modes_check === [01:39:40] ======== [PASSED] drm_connector_helper_tv_get_modes ======== [01:39:40] ================== drm_rect (9 subtests) =================== [01:39:40] [PASSED] drm_test_rect_clip_scaled_div_by_zero [01:39:40] [PASSED] drm_test_rect_clip_scaled_not_clipped [01:39:40] [PASSED] drm_test_rect_clip_scaled_clipped [01:39:40] [PASSED] drm_test_rect_clip_scaled_signed_vs_unsigned [01:39:40] ================= drm_test_rect_intersect ================= [01:39:40] [PASSED] top-left x bottom-right: 2x2+1+1 x 2x2+0+0 [01:39:40] [PASSED] top-right x bottom-left: 2x2+0+0 x 2x2+1-1 [01:39:40] [PASSED] bottom-left x top-right: 2x2+1-1 x 2x2+0+0 [01:39:40] [PASSED] bottom-right x top-left: 2x2+0+0 x 2x2+1+1 [01:39:40] [PASSED] right x left: 2x1+0+0 x 3x1+1+0 [01:39:40] [PASSED] left x right: 3x1+1+0 x 2x1+0+0 [01:39:40] [PASSED] up x bottom: 1x2+0+0 x 1x3+0-1 [01:39:40] [PASSED] bottom x up: 1x3+0-1 x 1x2+0+0 [01:39:40] [PASSED] touching corner: 1x1+0+0 x 2x2+1+1 [01:39:40] [PASSED] touching side: 1x1+0+0 x 1x1+1+0 [01:39:40] [PASSED] equal rects: 2x2+0+0 x 2x2+0+0 [01:39:40] [PASSED] inside another: 2x2+0+0 x 1x1+1+1 [01:39:40] [PASSED] far away: 1x1+0+0 x 1x1+3+6 [01:39:40] [PASSED] points intersecting: 0x0+5+10 x 0x0+5+10 [01:39:40] [PASSED] points not intersecting: 0x0+0+0 x 0x0+5+10 [01:39:40] ============= [PASSED] drm_test_rect_intersect ============= [01:39:40] ================ drm_test_rect_calc_hscale ================ [01:39:40] [PASSED] normal use [01:39:40] [PASSED] out of max range [01:39:40] [PASSED] out of min range [01:39:40] [PASSED] zero dst [01:39:40] [PASSED] negative src [01:39:40] [PASSED] negative dst [01:39:40] ============ [PASSED] drm_test_rect_calc_hscale ============ [01:39:40] ================ drm_test_rect_calc_vscale ================ [01:39:40] [PASSED] normal use stty: 'standard input': Inappropriate ioctl for device [01:39:40] [PASSED] out of max range [01:39:40] [PASSED] out of min range [01:39:40] [PASSED] zero dst [01:39:40] [PASSED] negative src [01:39:40] [PASSED] negative dst [01:39:40] ============ [PASSED] drm_test_rect_calc_vscale ============ [01:39:40] ================== drm_test_rect_rotate =================== [01:39:40] [PASSED] reflect-x [01:39:40] [PASSED] reflect-y [01:39:40] [PASSED] rotate-0 [01:39:40] [PASSED] rotate-90 [01:39:40] [PASSED] rotate-180 [01:39:40] [PASSED] rotate-270 [01:39:40] ============== [PASSED] drm_test_rect_rotate =============== [01:39:40] ================ drm_test_rect_rotate_inv ================= [01:39:40] [PASSED] reflect-x [01:39:40] [PASSED] reflect-y [01:39:40] [PASSED] rotate-0 [01:39:40] [PASSED] rotate-90 [01:39:40] [PASSED] rotate-180 [01:39:40] [PASSED] rotate-270 [01:39:40] ============ [PASSED] drm_test_rect_rotate_inv ============= [01:39:40] ==================== [PASSED] drm_rect ===================== [01:39:40] ============ drm_sysfb_modeset_test (1 subtest) ============ [01:39:40] ============ drm_test_sysfb_build_fourcc_list ============= [01:39:40] [PASSED] no native formats [01:39:40] [PASSED] XRGB8888 as native format [01:39:40] [PASSED] remove duplicates [01:39:40] [PASSED] convert alpha formats [01:39:40] [PASSED] random formats [01:39:40] ======== [PASSED] drm_test_sysfb_build_fourcc_list ========= [01:39:40] ============= [PASSED] drm_sysfb_modeset_test ============== [01:39:40] ============================================================ [01:39:40] Testing complete. Ran 622 tests: passed: 622 [01:39:40] Elapsed time: 26.684s total, 1.695s configuring, 24.567s building, 0.394s running
+ /kernel/tools/testing/kunit/kunit.py run --kunitconfig /kernel/drivers/gpu/drm/ttm/tests/.kunitconfig [01:39:40] Configuring KUnit Kernel ...
Regenerating .config ...
Populating config with:
$ make ARCH=um O=.kunit olddefconfig [01:39:42] Building KUnit Kernel ... Populating config with: $ make ARCH=um O=.kunit olddefconfig Building with: $ make all compile_commands.json scripts_gdb ARCH=um O=.kunit --jobs=48 [01:39:51] Starting KUnit Kernel (1/1)... [01:39:51] ============================================================ Running tests with: $ .kunit/linux kunit.enable=1 mem=1G console=tty kunit_shutdown=halt [01:39:51] ================= ttm_device (5 subtests) ================== [01:39:51] [PASSED] ttm_device_init_basic [01:39:51] [PASSED] ttm_device_init_multiple [01:39:51] [PASSED] ttm_device_fini_basic [01:39:51] [PASSED] ttm_device_init_no_vma_man [01:39:51] ================== ttm_device_init_pools ================== [01:39:51] [PASSED] No DMA allocations, no DMA32 required [01:39:51] [PASSED] DMA allocations, DMA32 required [01:39:51] [PASSED] No DMA allocations, DMA32 required [01:39:51] [PASSED] DMA allocations, no DMA32 required [01:39:51] ============== [PASSED] ttm_device_init_pools ============== [01:39:51] =================== [PASSED] ttm_device ==================== [01:39:51] ================== ttm_pool (8 subtests) =================== [01:39:51] ================== ttm_pool_alloc_basic =================== [01:39:51] [PASSED] One page [01:39:51] [PASSED] More than one page [01:39:51] [PASSED] Above the allocation limit [01:39:51] [PASSED] One page, with coherent DMA mappings enabled [01:39:51] [PASSED] Above the allocation limit, with coherent DMA mappings enabled [01:39:51] ============== [PASSED] ttm_pool_alloc_basic =============== [01:39:51] ============== ttm_pool_alloc_basic_dma_addr ============== [01:39:51] [PASSED] One page [01:39:51] [PASSED] More than one page [01:39:51] [PASSED] Above the allocation limit [01:39:51] [PASSED] One page, with coherent DMA mappings enabled [01:39:51] [PASSED] Above the allocation limit, with coherent DMA mappings enabled [01:39:51] ========== [PASSED] ttm_pool_alloc_basic_dma_addr ========== [01:39:51] [PASSED] ttm_pool_alloc_order_caching_match [01:39:51] [PASSED] ttm_pool_alloc_caching_mismatch [01:39:51] [PASSED] ttm_pool_alloc_order_mismatch [01:39:51] [PASSED] ttm_pool_free_dma_alloc [01:39:51] [PASSED] ttm_pool_free_no_dma_alloc [01:39:51] [PASSED] ttm_pool_fini_basic [01:39:51] ==================== [PASSED] ttm_pool ===================== [01:39:51] ================ ttm_resource (8 subtests) ================= [01:39:51] ================= ttm_resource_init_basic ================= [01:39:51] [PASSED] Init resource in TTM_PL_SYSTEM [01:39:51] [PASSED] Init resource in TTM_PL_VRAM [01:39:51] [PASSED] Init resource in a private placement [01:39:51] [PASSED] Init resource in TTM_PL_SYSTEM, set placement flags [01:39:51] ============= [PASSED] ttm_resource_init_basic ============= [01:39:51] [PASSED] ttm_resource_init_pinned [01:39:51] [PASSED] ttm_resource_fini_basic [01:39:51] [PASSED] ttm_resource_manager_init_basic [01:39:51] [PASSED] ttm_resource_manager_usage_basic [01:39:51] [PASSED] ttm_resource_manager_set_used_basic [01:39:51] [PASSED] ttm_sys_man_alloc_basic [01:39:51] [PASSED] ttm_sys_man_free_basic [01:39:51] ================== [PASSED] ttm_resource =================== [01:39:51] =================== ttm_tt (15 subtests) =================== [01:39:51] ==================== ttm_tt_init_basic ==================== [01:39:51] [PASSED] Page-aligned size [01:39:51] [PASSED] Extra pages requested [01:39:51] ================ [PASSED] ttm_tt_init_basic ================ [01:39:51] [PASSED] ttm_tt_init_misaligned [01:39:51] [PASSED] ttm_tt_fini_basic [01:39:51] [PASSED] ttm_tt_fini_sg [01:39:51] [PASSED] ttm_tt_fini_shmem [01:39:51] [PASSED] ttm_tt_create_basic [01:39:51] [PASSED] ttm_tt_create_invalid_bo_type [01:39:51] [PASSED] ttm_tt_create_ttm_exists [01:39:51] [PASSED] ttm_tt_create_failed [01:39:51] [PASSED] ttm_tt_destroy_basic [01:39:51] [PASSED] ttm_tt_populate_null_ttm [01:39:51] [PASSED] ttm_tt_populate_populated_ttm [01:39:51] [PASSED] ttm_tt_unpopulate_basic [01:39:51] [PASSED] ttm_tt_unpopulate_empty_ttm [01:39:51] [PASSED] ttm_tt_swapin_basic [01:39:51] ===================== [PASSED] ttm_tt ====================== [01:39:51] =================== ttm_bo (14 subtests) =================== [01:39:51] =========== ttm_bo_reserve_optimistic_no_ticket =========== [01:39:51] [PASSED] Cannot be interrupted and sleeps [01:39:51] [PASSED] Cannot be interrupted, locks straight away [01:39:51] [PASSED] Can be interrupted, sleeps [01:39:51] ======= [PASSED] ttm_bo_reserve_optimistic_no_ticket ======= [01:39:51] [PASSED] ttm_bo_reserve_locked_no_sleep [01:39:51] [PASSED] ttm_bo_reserve_no_wait_ticket [01:39:51] [PASSED] ttm_bo_reserve_double_resv [01:39:51] [PASSED] ttm_bo_reserve_interrupted [01:39:51] [PASSED] ttm_bo_reserve_deadlock [01:39:51] [PASSED] ttm_bo_unreserve_basic [01:39:51] [PASSED] ttm_bo_unreserve_pinned [01:39:51] [PASSED] ttm_bo_unreserve_bulk [01:39:51] [PASSED] ttm_bo_fini_basic [01:39:51] [PASSED] ttm_bo_fini_shared_resv [01:39:51] [PASSED] ttm_bo_pin_basic [01:39:51] [PASSED] ttm_bo_pin_unpin_resource [01:39:51] [PASSED] ttm_bo_multiple_pin_one_unpin [01:39:51] ===================== [PASSED] ttm_bo ====================== [01:39:51] ============== ttm_bo_validate (21 subtests) =============== [01:39:51] ============== ttm_bo_init_reserved_sys_man =============== [01:39:51] [PASSED] Buffer object for userspace [01:39:51] [PASSED] Kernel buffer object [01:39:51] [PASSED] Shared buffer object [01:39:51] ========== [PASSED] ttm_bo_init_reserved_sys_man =========== [01:39:51] ============== ttm_bo_init_reserved_mock_man ============== [01:39:51] [PASSED] Buffer object for userspace [01:39:51] [PASSED] Kernel buffer object [01:39:51] [PASSED] Shared buffer object [01:39:51] ========== [PASSED] ttm_bo_init_reserved_mock_man ========== [01:39:51] [PASSED] ttm_bo_init_reserved_resv [01:39:51] ================== ttm_bo_validate_basic ================== [01:39:51] [PASSED] Buffer object for userspace [01:39:51] [PASSED] Kernel buffer object [01:39:51] [PASSED] Shared buffer object [01:39:51] ============== [PASSED] ttm_bo_validate_basic ============== [01:39:51] [PASSED] ttm_bo_validate_invalid_placement [01:39:51] ============= ttm_bo_validate_same_placement ============== [01:39:51] [PASSED] System manager [01:39:51] [PASSED] VRAM manager [01:39:51] ========= [PASSED] ttm_bo_validate_same_placement ========== [01:39:51] [PASSED] ttm_bo_validate_failed_alloc [01:39:51] [PASSED] ttm_bo_validate_pinned [01:39:51] [PASSED] ttm_bo_validate_busy_placement [01:39:51] ================ ttm_bo_validate_multihop ================= [01:39:51] [PASSED] Buffer object for userspace [01:39:51] [PASSED] Kernel buffer object [01:39:51] [PASSED] Shared buffer object [01:39:51] ============ [PASSED] ttm_bo_validate_multihop ============= [01:39:51] ========== ttm_bo_validate_no_placement_signaled ========== [01:39:51] [PASSED] Buffer object in system domain, no page vector [01:39:51] [PASSED] Buffer object in system domain with an existing page vector [01:39:51] ====== [PASSED] ttm_bo_validate_no_placement_signaled ====== [01:39:51] ======== ttm_bo_validate_no_placement_not_signaled ======== [01:39:51] [PASSED] Buffer object for userspace [01:39:51] [PASSED] Kernel buffer object [01:39:51] [PASSED] Shared buffer object [01:39:51] ==== [PASSED] ttm_bo_validate_no_placement_not_signaled ==== [01:39:51] [PASSED] ttm_bo_validate_move_fence_signaled [01:39:51] ========= ttm_bo_validate_move_fence_not_signaled ========= [01:39:51] [PASSED] Waits for GPU [01:39:51] [PASSED] Tries to lock straight away [01:39:51] ===== [PASSED] ttm_bo_validate_move_fence_not_signaled ===== [01:39:51] [PASSED] ttm_bo_validate_happy_evict [01:39:51] [PASSED] ttm_bo_validate_all_pinned_evict [01:39:51] [PASSED] ttm_bo_validate_allowed_only_evict [01:39:51] [PASSED] ttm_bo_validate_deleted_evict [01:39:51] [PASSED] ttm_bo_validate_busy_domain_evict [01:39:51] [PASSED] ttm_bo_validate_evict_gutting [01:39:51] [PASSED] ttm_bo_validate_recrusive_evict stty: 'standard input': Inappropriate ioctl for device [01:39:51] ================= [PASSED] ttm_bo_validate ================= [01:39:51] ============================================================ [01:39:51] Testing complete. Ran 101 tests: passed: 101 [01:39:51] Elapsed time: 11.120s total, 1.609s configuring, 9.245s building, 0.226s running
+ cleanup
++ stat -c %u:%g /kernel
+ chown -R 1003:1003 /kernel
Patchwork
CI✗ i915.CI.BAT: failure for drm/i915/display: Add initial support for Xe3p_LPD (rev2)
In reply to Gustavo Sousa== Series Details ==
== Series Details ==
Series: drm/i915/display: Add initial support for Xe3p_LPD (rev2)
URL : https://patchwork.freedesktop.org/series/155952/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_17402 -> Patchwork_155952v2
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_155952v2 absolutely need to be verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_155952v2, please notify your bug team ([email protected]) to allow them to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v2/index.html
Participating hosts (45 -> 43)
------------------------------
Missing (2): fi-glk-j4005 fi-snb-2520m
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_155952v2:
### IGT changes ###
#### Possible regressions ####
* igt@i915_module_load@load:
- bat-dg2-13: [PASS][1] -> [ABORT][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17402/bat-dg2-13/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v2/bat-dg2-13/igt@[email protected]
- bat-dg2-9: [PASS][3] -> [ABORT][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17402/bat-dg2-9/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v2/bat-dg2-9/igt@[email protected]
- bat-dg2-11: [PASS][5] -> [ABORT][6]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17402/bat-dg2-11/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v2/bat-dg2-11/igt@[email protected]
- bat-dg2-14: [PASS][7] -> [ABORT][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17402/bat-dg2-14/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v2/bat-dg2-14/igt@[email protected]
- bat-dg2-8: [PASS][9] -> [ABORT][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17402/bat-dg2-8/igt@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v2/bat-dg2-8/igt@[email protected]
Known issues
------------
Here are the changes found in Patchwork_155952v2 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@dmabuf@all-tests@dma_fence_chain:
- fi-bsw-n3050: [PASS][11] -> [ABORT][12] ([i915#12904]) +1 other test abort
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17402/fi-bsw-n3050/igt@dmabuf@all-tests@dma_fence_chain.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v2/fi-bsw-n3050/igt@dmabuf@all-tests@dma_fence_chain.html
* igt@i915_selftest@live:
- bat-mtlp-8: [PASS][13] -> [DMESG-FAIL][14] ([i915#12061]) +1 other test dmesg-fail
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17402/bat-mtlp-8/igt@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v2/bat-mtlp-8/igt@[email protected]
#### Possible fixes ####
* igt@dmabuf@all-tests:
- bat-apl-1: [ABORT][15] ([i915#12904]) -> [PASS][16] +1 other test pass
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17402/bat-apl-1/igt@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v2/bat-apl-1/igt@[email protected]
#### Warnings ####
* igt@i915_selftest@live:
- bat-atsm-1: [DMESG-FAIL][17] ([i915#12061] / [i915#13929]) -> [DMESG-FAIL][18] ([i915#12061] / [i915#14204])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17402/bat-atsm-1/igt@[email protected]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v2/bat-atsm-1/igt@[email protected]
* igt@i915_selftest@live@mman:
- bat-atsm-1: [DMESG-FAIL][19] ([i915#13929]) -> [DMESG-FAIL][20] ([i915#14204])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17402/bat-atsm-1/igt@i915_selftest@[email protected]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v2/bat-atsm-1/igt@i915_selftest@[email protected]
[i915#12061]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12061
[i915#12904]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12904
[i915#13929]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/13929
[i915#14204]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/14204
Build changes
-------------
* Linux: CI_DRM_17402 -> Patchwork_155952v2
CI-20190529: 20190529
CI_DRM_17402: fb0f56ad8a2c9953c57c3337a72ccbf9c5050687 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_8594: 8594
Patchwork_155952v2: fb0f56ad8a2c9953c57c3337a72ccbf9c5050687 @ git://anongit.freedesktop.org/gfx-ci/linux
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v2/index.html
Patchwork
CI✗ CI.checksparse: warning for drm/i915/display: Add initial support for Xe3p_LPD (rev2)
In reply to Gustavo Sousa== Series Details ==
== Series Details ==
Series: drm/i915/display: Add initial support for Xe3p_LPD (rev2)
URL : https://patchwork.freedesktop.org/series/155951/
State : warning
== Summary ==
+ trap cleanup EXIT
+ KERNEL=/kernel
+ MT=/root/linux/maintainer-tools
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools /root/linux/maintainer-tools
Cloning into '/root/linux/maintainer-tools'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ make -C /root/linux/maintainer-tools
make: Entering directory '/root/linux/maintainer-tools'
cc -O2 -g -Wextra -o remap-log remap-log.c
make: Leaving directory '/root/linux/maintainer-tools'
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ /root/linux/maintainer-tools/dim sparse --fast fb0f56ad8a2c9953c57c3337a72ccbf9c5050687
Sparse version: 0.6.4 (Ubuntu: 0.6.4-4ubuntu3)
Fast mode used, each commit won't be checked separately.+drivers/gpu/drm/i915/gt/intel_reset.c:1569:12: warning: context imbalance in '_intel_gt_reset_lock' - different lock contexts for basic block +drivers/gpu/drm/i915/i915_gpu_error.c:692:3: warning: symbol 'guc_hw_reg_state' was not declared. Should it be static? +drivers/gpu/drm/i915/i915_irq.c:465:9: warning: unreplaced symbol '<noident>'+drivers/gpu/drm/i915/i915_irq.c:465:9: warning: unreplaced symbol '<noident>'+drivers/gpu/drm/i915/i915_irq.c:473:16: warning: unreplaced symbol '<noident>' +drivers/gpu/drm/i915/i915_irq.c:473:16: warning: unreplaced symbol '<noident>'+drivers/gpu/drm/i915/i915_irq.c:478:9: warning: unreplaced symbol '<noident>'+drivers/gpu/drm/i915/i915_irq.c:478:9: warning: unreplaced symbol '<noident>'+drivers/gpu/drm/i915/i915_irq.c:478:9: warning: unreplaced symbol '<noident>'+drivers/gpu/drm/i915/i915_irq.c:516:9: warning: unreplaced symbol '<noident>'+drivers/gpu/drm/i915/i915_irq.c:516:9: warning: unreplaced symbol '<noident>'+drivers/gpu/drm/i915/i915_irq.c:524:16: warning: unreplaced symbol '<noident>' +drivers/gpu/drm/i915/i915_irq.c:524:16: warning: unreplaced symbol '<noident>'+drivers/gpu/drm/i915/i915_irq.c:529:9: warning: unreplaced symbol '<noident>'+drivers/gpu/drm/i915/i915_irq.c:529:9: warning: unreplaced symbol '<noident>'+drivers/gpu/drm/i915/i915_irq.c:529:9: warning: unreplaced symbol '<noident>'+drivers/gpu/drm/i915/i915_irq.c:573:9: warning: unreplaced symbol '<noident>'+drivers/gpu/drm/i915/i915_irq.c:573:9: warning: unreplaced symbol '<noident>'+drivers/gpu/drm/i915/i915_irq.c:576:15: warning: unreplaced symbol '<noident>' +drivers/gpu/drm/i915/i915_irq.c:576:15: warning: unreplaced symbol '<noident>'+drivers/gpu/drm/i915/i915_irq.c:580:9: warning: unreplaced symbol '<noident>'+drivers/gpu/drm/i915/i915_irq.c:580:9: warning: unreplaced symbol '<noident>'+drivers/gpu/drm/i915/i915_irq.c:587:9: warning: unreplaced symbol '<noident>'+drivers/gpu/drm/i915/i915_irq.c:587:9: warning: unreplaced symbol '<noident>'+drivers/gpu/drm/i915/i915_irq.c:587:9: warning: unreplaced symbol '<noident>'+drivers/gpu/drm/i915/i915_irq.c:587:9: warning: unreplaced symbol '<noident>'
+ cleanup
++ stat -c %u:%g /kernel
+ chown -R 1003:1003 /kernel
Patchwork
CI✓ Xe.CI.BAT: success for drm/i915/display: Add initial support for Xe3p_LPD (rev2)
In reply to Gustavo Sousa== Series Details ==
== Series Details ==
Series: drm/i915/display: Add initial support for Xe3p_LPD (rev2)
URL : https://patchwork.freedesktop.org/series/155951/
State : success
== Summary ==
CI Bug Log - changes from xe-3961-fb0f56ad8a2c9953c57c3337a72ccbf9c5050687_BAT -> xe-pw-155951v2_BAT
====================================================
Summary
-------
**SUCCESS**
No regressions found.
Participating hosts (12 -> 11)
------------------------------
Missing (1): bat-pvc-2
Known issues
------------
Here are the changes found in xe-pw-155951v2_BAT that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@xe_module_load@load:
- bat-dg2-oem2: [PASS][1] -> [ABORT][2] ([Intel XE#5087])
[1]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3961-fb0f56ad8a2c9953c57c3337a72ccbf9c5050687/bat-dg2-oem2/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155951v2/bat-dg2-oem2/igt@[email protected]
#### Possible fixes ####
* igt@kms_flip@basic-plain-flip@d-edp1:
- bat-adlp-7: [DMESG-WARN][3] ([Intel XE#4543]) -> [PASS][4] +1 other test pass
[3]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3961-fb0f56ad8a2c9953c57c3337a72ccbf9c5050687/bat-adlp-7/igt@kms_flip@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155951v2/bat-adlp-7/igt@kms_flip@[email protected]
[Intel XE#4543]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/4543
[Intel XE#5087]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/5087
Build changes
-------------
* Linux: xe-3961-fb0f56ad8a2c9953c57c3337a72ccbf9c5050687 -> xe-pw-155951v2
IGT_8594: 8594
xe-3961-fb0f56ad8a2c9953c57c3337a72ccbf9c5050687: fb0f56ad8a2c9953c57c3337a72ccbf9c5050687
xe-pw-155951v2: 155951v2
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155951v2/index.html
Patchwork
CI✓ Xe.CI.Full: success for drm/i915/display: Add initial support for Xe3p_LPD (rev2)
In reply to Gustavo Sousa== Series Details ==
== Series Details ==
Series: drm/i915/display: Add initial support for Xe3p_LPD (rev2)
URL : https://patchwork.freedesktop.org/series/155951/
State : success
== Summary ==
CI Bug Log - changes from xe-3961-fb0f56ad8a2c9953c57c3337a72ccbf9c5050687_FULL -> xe-pw-155951v2_FULL
====================================================
Summary
-------
**SUCCESS**
No regressions found.
Participating hosts (4 -> 4)
------------------------------
No changes in participating hosts
Known issues
------------
Here are the changes found in xe-pw-155951v2_FULL that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-0-async-flip:
- shard-bmg: NOTRUN -> [SKIP][1] ([Intel XE#1124])
[1]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155951v2/shard-bmg-8/igt@[email protected]
* igt@kms_bw@linear-tiling-2-displays-2160x1440p:
- shard-bmg: NOTRUN -> [SKIP][2] ([Intel XE#367])
[2]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155951v2/shard-bmg-8/igt@[email protected]
* igt@kms_ccs@bad-rotation-90-4-tiled-lnl-ccs@pipe-c-dp-2:
- shard-bmg: NOTRUN -> [SKIP][3] ([Intel XE#2652] / [Intel XE#787]) +12 other tests skip
[3]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155951v2/shard-bmg-8/igt@kms_ccs@[email protected]
* igt@kms_ccs@crc-primary-rotation-180-4-tiled-dg2-rc-ccs-cc:
- shard-bmg: NOTRUN -> [SKIP][4] ([Intel XE#2887])
[4]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155951v2/shard-bmg-8/igt@[email protected]
* igt@kms_chamelium_frames@dp-crc-single:
- shard-bmg: NOTRUN -> [SKIP][5] ([Intel XE#2252]) +2 other tests skip
[5]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155951v2/shard-bmg-8/igt@[email protected]
* igt@kms_content_protection@atomic:
- shard-bmg: NOTRUN -> [FAIL][6] ([Intel XE#1178]) +2 other tests fail
[6]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155951v2/shard-bmg-8/igt@[email protected]
* igt@kms_cursor_crc@cursor-onscreen-64x21:
- shard-bmg: NOTRUN -> [SKIP][7] ([Intel XE#2320]) +1 other test skip
[7]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155951v2/shard-bmg-8/igt@[email protected]
* igt@kms_cursor_legacy@2x-long-nonblocking-modeset-vs-cursor-atomic:
- shard-bmg: [PASS][8] -> [SKIP][9] ([Intel XE#2291])
[8]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3961-fb0f56ad8a2c9953c57c3337a72ccbf9c5050687/shard-bmg-8/igt@kms_cursor_legacy@2x-long-nonblocking-modeset-vs-cursor-atomic.html
[9]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155951v2/shard-bmg-6/igt@kms_cursor_legacy@2x-long-nonblocking-modeset-vs-cursor-atomic.html
* igt@kms_cursor_legacy@flip-vs-cursor-atomic:
- shard-bmg: [PASS][10] -> [FAIL][11] ([Intel XE#1475]) +1 other test fail
[10]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3961-fb0f56ad8a2c9953c57c3337a72ccbf9c5050687/shard-bmg-6/igt@[email protected]
[11]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155951v2/shard-bmg-7/igt@[email protected]
* igt@kms_cursor_legacy@flip-vs-cursor-legacy:
- shard-bmg: [PASS][12] -> [FAIL][13] ([Intel XE#4633])
[12]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3961-fb0f56ad8a2c9953c57c3337a72ccbf9c5050687/shard-bmg-8/igt@[email protected]
[13]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155951v2/shard-bmg-6/igt@[email protected]
* igt@kms_dsc@dsc-with-output-formats:
- shard-bmg: NOTRUN -> [SKIP][14] ([Intel XE#2244])
[14]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155951v2/shard-bmg-8/igt@[email protected]
* igt@kms_flip@2x-flip-vs-wf_vblank:
- shard-bmg: [PASS][15] -> [SKIP][16] ([Intel XE#2316]) +1 other test skip
[15]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3961-fb0f56ad8a2c9953c57c3337a72ccbf9c5050687/shard-bmg-1/igt@kms_flip@2x-flip-vs-wf_vblank.html
[16]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155951v2/shard-bmg-6/igt@kms_flip@2x-flip-vs-wf_vblank.html
* igt@kms_flip@flip-vs-suspend-interruptible@d-hdmi-a1:
- shard-adlp: [PASS][17] -> [DMESG-WARN][18] ([Intel XE#2953] / [Intel XE#4173]) +4 other tests dmesg-warn
[17]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3961-fb0f56ad8a2c9953c57c3337a72ccbf9c5050687/shard-adlp-4/igt@kms_flip@[email protected]
[18]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155951v2/shard-adlp-2/igt@kms_flip@[email protected]
* igt@kms_flip@flip-vs-suspend@d-hdmi-a1:
- shard-adlp: [PASS][19] -> [DMESG-WARN][20] ([Intel XE#4543]) +10 other tests dmesg-warn
[19]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3961-fb0f56ad8a2c9953c57c3337a72ccbf9c5050687/shard-adlp-3/igt@kms_flip@[email protected]
[20]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155951v2/shard-adlp-4/igt@kms_flip@[email protected]
* igt@kms_flip_tiling@flip-change-tiling@pipe-b-hdmi-a-1-y-to-y:
- shard-adlp: [PASS][21] -> [DMESG-FAIL][22] ([Intel XE#4543])
[21]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3961-fb0f56ad8a2c9953c57c3337a72ccbf9c5050687/shard-adlp-3/igt@kms_flip_tiling@[email protected]
[22]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155951v2/shard-adlp-6/igt@kms_flip_tiling@[email protected]
* igt@kms_frontbuffer_tracking@drrs-2p-scndscrn-spr-indfb-draw-mmap-wc:
- shard-bmg: NOTRUN -> [SKIP][23] ([Intel XE#2311]) +1 other test skip
[23]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155951v2/shard-bmg-8/igt@kms_frontbuffer_tracking@drrs-2p-scndscrn-spr-indfb-draw-mmap-wc.html
* igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-cur-indfb-draw-mmap-wc:
- shard-bmg: NOTRUN -> [SKIP][24] ([Intel XE#5390]) +1 other test skip
[24]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155951v2/shard-bmg-8/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-cur-indfb-draw-mmap-wc.html
* igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-indfb-plflip-blt:
- shard-bmg: NOTRUN -> [SKIP][25] ([Intel XE#2313]) +4 other tests skip
[25]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155951v2/shard-bmg-8/igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-indfb-plflip-blt.html
* igt@kms_hdr@invalid-hdr:
- shard-bmg: [PASS][26] -> [SKIP][27] ([Intel XE#1503])
[26]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3961-fb0f56ad8a2c9953c57c3337a72ccbf9c5050687/shard-bmg-3/igt@[email protected]
[27]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155951v2/shard-bmg-1/igt@[email protected]
* igt@kms_joiner@basic-ultra-joiner:
- shard-bmg: NOTRUN -> [SKIP][28] ([Intel XE#2927])
[28]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155951v2/shard-bmg-8/igt@[email protected]
* igt@kms_pm_dc@dc3co-vpb-simulation:
- shard-bmg: NOTRUN -> [SKIP][29] ([Intel XE#2391])
[29]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155951v2/shard-bmg-8/igt@[email protected]
* igt@kms_psr@fbc-pr-basic:
- shard-bmg: NOTRUN -> [SKIP][30] ([Intel XE#1406] / [Intel XE#2234] / [Intel XE#2850])
[30]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155951v2/shard-bmg-8/igt@[email protected]
* igt@kms_rotation_crc@primary-y-tiled-reflect-x-90:
- shard-bmg: NOTRUN -> [SKIP][31] ([Intel XE#3414] / [Intel XE#3904])
[31]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155951v2/shard-bmg-8/igt@[email protected]
* igt@kms_setmode@invalid-clone-single-crtc:
- shard-bmg: [PASS][32] -> [SKIP][33] ([Intel XE#1435])
[32]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3961-fb0f56ad8a2c9953c57c3337a72ccbf9c5050687/shard-bmg-4/igt@[email protected]
[33]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155951v2/shard-bmg-6/igt@[email protected]
* igt@kms_vrr@flipline:
- shard-lnl: [PASS][34] -> [FAIL][35] ([Intel XE#4227]) +1 other test fail
[34]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3961-fb0f56ad8a2c9953c57c3337a72ccbf9c5050687/shard-lnl-8/igt@[email protected]
[35]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155951v2/shard-lnl-1/igt@[email protected]
* igt@xe_eudebug@basic-exec-queues:
- shard-bmg: NOTRUN -> [SKIP][36] ([Intel XE#4837]) +2 other tests skip
[36]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155951v2/shard-bmg-8/igt@[email protected]
* igt@xe_exec_basic@multigpu-no-exec-rebind:
- shard-bmg: NOTRUN -> [SKIP][37] ([Intel XE#2322]) +1 other test skip
[37]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155951v2/shard-bmg-8/igt@[email protected]
* igt@xe_exec_reset@cm-close-fd:
- shard-adlp: [PASS][38] -> [DMESG-WARN][39] ([Intel XE#3868])
[38]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3961-fb0f56ad8a2c9953c57c3337a72ccbf9c5050687/shard-adlp-1/igt@[email protected]
[39]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155951v2/shard-adlp-3/igt@[email protected]
* igt@xe_exec_system_allocator@pat-index-madvise-pat-idx-uc-multi-vma:
- shard-lnl: [PASS][40] -> [FAIL][41] ([Intel XE#5625])
[40]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3961-fb0f56ad8a2c9953c57c3337a72ccbf9c5050687/shard-lnl-7/igt@xe_exec_system_allocator@pat-index-madvise-pat-idx-uc-multi-vma.html
[41]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155951v2/shard-lnl-7/igt@xe_exec_system_allocator@pat-index-madvise-pat-idx-uc-multi-vma.html
* igt@xe_exec_system_allocator@threads-shared-vm-many-stride-mmap-free-huge:
- shard-bmg: NOTRUN -> [SKIP][42] ([Intel XE#4943]) +3 other tests skip
[42]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155951v2/shard-bmg-8/igt@xe_exec_system_allocator@threads-shared-vm-many-stride-mmap-free-huge.html
* igt@xe_module_load@force-load:
- shard-bmg: NOTRUN -> [SKIP][43] ([Intel XE#2457])
[43]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155951v2/shard-bmg-8/igt@[email protected]
* igt@xe_pm@s2idle-multiple-execs:
- shard-adlp: [PASS][44] -> [DMESG-WARN][45] ([Intel XE#2953] / [Intel XE#4173] / [Intel XE#4504])
[44]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3961-fb0f56ad8a2c9953c57c3337a72ccbf9c5050687/shard-adlp-2/igt@[email protected]
[45]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155951v2/shard-adlp-1/igt@[email protected]
* igt@xe_query@multigpu-query-cs-cycles:
- shard-bmg: NOTRUN -> [SKIP][46] ([Intel XE#944])
[46]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155951v2/shard-bmg-8/igt@[email protected]
#### Possible fixes ####
* igt@core_hotunplug@hotrebind-lateclose:
- shard-adlp: [DMESG-WARN][47] ([Intel XE#2953] / [Intel XE#4173]) -> [PASS][48]
[47]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3961-fb0f56ad8a2c9953c57c3337a72ccbf9c5050687/shard-adlp-9/igt@[email protected]
[48]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155951v2/shard-adlp-2/igt@[email protected]
* igt@kms_async_flips@crc-atomic@pipe-d-hdmi-a-1:
- shard-adlp: [FAIL][49] ([Intel XE#3884]) -> [PASS][50]
[49]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3961-fb0f56ad8a2c9953c57c3337a72ccbf9c5050687/shard-adlp-8/igt@kms_async_flips@[email protected]
[50]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155951v2/shard-adlp-9/igt@kms_async_flips@[email protected]
* igt@kms_bw@connected-linear-tiling-2-displays-3840x2160p:
- shard-bmg: [SKIP][51] ([Intel XE#2314] / [Intel XE#2894]) -> [PASS][52]
[51]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3961-fb0f56ad8a2c9953c57c3337a72ccbf9c5050687/shard-bmg-6/igt@[email protected]
[52]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155951v2/shard-bmg-7/igt@[email protected]
* igt@kms_cursor_legacy@cursora-vs-flipb-legacy:
- shard-bmg: [SKIP][53] ([Intel XE#2291]) -> [PASS][54] +4 other tests pass
[53]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3961-fb0f56ad8a2c9953c57c3337a72ccbf9c5050687/shard-bmg-6/igt@[email protected]
[54]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155951v2/shard-bmg-8/igt@[email protected]
* igt@kms_dp_link_training@non-uhbr-sst:
- shard-bmg: [SKIP][55] ([Intel XE#4354]) -> [PASS][56]
[55]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3961-fb0f56ad8a2c9953c57c3337a72ccbf9c5050687/shard-bmg-6/igt@[email protected]
[56]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155951v2/shard-bmg-8/igt@[email protected]
* igt@kms_flip@2x-flip-vs-dpms-off-vs-modeset-interruptible:
- shard-bmg: [SKIP][57] ([Intel XE#2316]) -> [PASS][58] +6 other tests pass
[57]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3961-fb0f56ad8a2c9953c57c3337a72ccbf9c5050687/shard-bmg-6/igt@[email protected]
[58]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155951v2/shard-bmg-7/igt@[email protected]
* igt@kms_flip@flip-vs-blocking-wf-vblank@c-hdmi-a1:
- shard-adlp: [DMESG-WARN][59] ([Intel XE#4543]) -> [PASS][60] +7 other tests pass
[59]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3961-fb0f56ad8a2c9953c57c3337a72ccbf9c5050687/shard-adlp-8/igt@kms_flip@[email protected]
[60]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155951v2/shard-adlp-3/igt@kms_flip@[email protected]
* igt@kms_flip@flip-vs-expired-vblank-interruptible@b-edp1:
- shard-lnl: [FAIL][61] ([Intel XE#301]) -> [PASS][62] +3 other tests pass
[61]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3961-fb0f56ad8a2c9953c57c3337a72ccbf9c5050687/shard-lnl-3/igt@kms_flip@[email protected]
[62]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155951v2/shard-lnl-2/igt@kms_flip@[email protected]
* igt@kms_flip_tiling@flip-change-tiling@pipe-d-hdmi-a-1-x-to-y:
- shard-adlp: [FAIL][63] ([Intel XE#1874]) -> [PASS][64]
[63]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3961-fb0f56ad8a2c9953c57c3337a72ccbf9c5050687/shard-adlp-3/igt@kms_flip_tiling@[email protected]
[64]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155951v2/shard-adlp-6/igt@kms_flip_tiling@[email protected]
* igt@kms_flip_tiling@flip-change-tiling@pipe-d-hdmi-a-1-y-to-y:
- shard-adlp: [DMESG-FAIL][65] ([Intel XE#4543]) -> [PASS][66]
[65]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3961-fb0f56ad8a2c9953c57c3337a72ccbf9c5050687/shard-adlp-3/igt@kms_flip_tiling@[email protected]
[66]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155951v2/shard-adlp-6/igt@kms_flip_tiling@[email protected]
* igt@kms_hdr@invalid-metadata-sizes:
- shard-bmg: [SKIP][67] ([Intel XE#1503]) -> [PASS][68]
[67]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3961-fb0f56ad8a2c9953c57c3337a72ccbf9c5050687/shard-bmg-6/igt@[email protected]
[68]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155951v2/shard-bmg-7/igt@[email protected]
* igt@kms_plane_multiple@2x-tiling-4:
- shard-bmg: [SKIP][69] ([Intel XE#4596]) -> [PASS][70]
[69]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3961-fb0f56ad8a2c9953c57c3337a72ccbf9c5050687/shard-bmg-6/igt@[email protected]
[70]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155951v2/shard-bmg-7/igt@[email protected]
* igt@xe_exec_balancer@once-parallel-userptr-invalidate:
- shard-bmg: [DMESG-FAIL][71] ([Intel XE#3876]) -> [PASS][72] +2 other tests pass
[71]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3961-fb0f56ad8a2c9953c57c3337a72ccbf9c5050687/shard-bmg-2/igt@[email protected]
[72]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155951v2/shard-bmg-8/igt@[email protected]
* igt@xe_exec_basic@many-null-defer-bind:
- shard-bmg: [DMESG-WARN][73] ([Intel XE#3876]) -> [PASS][74]
[73]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3961-fb0f56ad8a2c9953c57c3337a72ccbf9c5050687/shard-bmg-2/igt@[email protected]
[74]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155951v2/shard-bmg-8/igt@[email protected]
* igt@xe_exec_fault_mode@many-execqueues-bindexecqueue-userptr-invalidate-imm:
- shard-bmg: [FAIL][75] ([Intel XE#5625]) -> [PASS][76] +3 other tests pass
[75]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3961-fb0f56ad8a2c9953c57c3337a72ccbf9c5050687/shard-bmg-2/igt@xe_exec_fault_mode@many-execqueues-bindexecqueue-userptr-invalidate-imm.html
[76]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155951v2/shard-bmg-8/igt@xe_exec_fault_mode@many-execqueues-bindexecqueue-userptr-invalidate-imm.html
* igt@xe_exec_fault_mode@twice-userptr-invalidate-race-imm:
- shard-bmg: [FAIL][77] ([Intel XE#6050]) -> [PASS][78] +1 other test pass
[77]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3961-fb0f56ad8a2c9953c57c3337a72ccbf9c5050687/shard-bmg-2/igt@[email protected]
[78]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155951v2/shard-bmg-8/igt@[email protected]
* igt@xe_exec_reset@cm-gt-reset:
- shard-bmg: [FAIL][79] ([Intel XE#6325]) -> [PASS][80]
[79]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3961-fb0f56ad8a2c9953c57c3337a72ccbf9c5050687/shard-bmg-2/igt@[email protected]
[80]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155951v2/shard-bmg-8/igt@[email protected]
* igt@xe_exec_system_allocator@twice-mmap-new-race-nomemset:
- shard-bmg: [FAIL][81] ([Intel XE#4937] / [Intel XE#5625]) -> [PASS][82] +32 other tests pass
[81]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3961-fb0f56ad8a2c9953c57c3337a72ccbf9c5050687/shard-bmg-2/igt@[email protected]
[82]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155951v2/shard-bmg-8/igt@[email protected]
* igt@xe_pm@s2idle-exec-after:
- shard-bmg: [TIMEOUT][83] ([Intel XE#3876] / [Intel XE#6162]) -> [PASS][84]
[83]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3961-fb0f56ad8a2c9953c57c3337a72ccbf9c5050687/shard-bmg-2/igt@[email protected]
[84]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155951v2/shard-bmg-8/igt@[email protected]
* igt@xe_pm_residency@gt-c6-freeze@gt0:
- shard-bmg: [DMESG-FAIL][85] ([Intel XE#5545]) -> [PASS][86] +1 other test pass
[85]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3961-fb0f56ad8a2c9953c57c3337a72ccbf9c5050687/shard-bmg-2/igt@xe_pm_residency@[email protected]
[86]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155951v2/shard-bmg-8/igt@xe_pm_residency@[email protected]
* igt@xe_pm_residency@gt-c6-freeze@gt1:
- shard-bmg: [FAIL][87] ([Intel XE#5545]) -> [PASS][88]
[87]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3961-fb0f56ad8a2c9953c57c3337a72ccbf9c5050687/shard-bmg-2/igt@xe_pm_residency@[email protected]
[88]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155951v2/shard-bmg-8/igt@xe_pm_residency@[email protected]
* igt@xe_vm@munmap-style-unbind-userptr-inval-front:
- shard-bmg: [INCOMPLETE][89] ([Intel XE#4842]) -> [PASS][90]
[89]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3961-fb0f56ad8a2c9953c57c3337a72ccbf9c5050687/shard-bmg-2/igt@[email protected]
[90]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155951v2/shard-bmg-8/igt@[email protected]
#### Warnings ####
* igt@kms_content_protection@srm:
- shard-bmg: [SKIP][91] ([Intel XE#2341]) -> [FAIL][92] ([Intel XE#1178])
[91]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3961-fb0f56ad8a2c9953c57c3337a72ccbf9c5050687/shard-bmg-6/igt@[email protected]
[92]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155951v2/shard-bmg-7/igt@[email protected]
* igt@kms_flip@flip-vs-panning-vs-hang@d-hdmi-a1:
- shard-adlp: [DMESG-WARN][93] ([Intel XE#4543]) -> [TIMEOUT][94] ([Intel XE#4543]) +1 other test timeout
[93]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3961-fb0f56ad8a2c9953c57c3337a72ccbf9c5050687/shard-adlp-8/igt@kms_flip@[email protected]
[94]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155951v2/shard-adlp-2/igt@kms_flip@[email protected]
* igt@kms_flip@flip-vs-suspend-interruptible:
- shard-adlp: [DMESG-WARN][95] ([Intel XE#4543]) -> [DMESG-WARN][96] ([Intel XE#2953] / [Intel XE#4173])
[95]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3961-fb0f56ad8a2c9953c57c3337a72ccbf9c5050687/shard-adlp-4/igt@[email protected]
[96]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155951v2/shard-adlp-2/igt@[email protected]
* igt@kms_frontbuffer_tracking@drrs-2p-primscrn-pri-indfb-draw-mmap-wc:
- shard-bmg: [SKIP][97] ([Intel XE#2311]) -> [SKIP][98] ([Intel XE#2312]) +10 other tests skip
[97]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3961-fb0f56ad8a2c9953c57c3337a72ccbf9c5050687/shard-bmg-1/igt@kms_frontbuffer_tracking@drrs-2p-primscrn-pri-indfb-draw-mmap-wc.html
[98]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155951v2/shard-bmg-6/igt@kms_frontbuffer_tracking@drrs-2p-primscrn-pri-indfb-draw-mmap-wc.html
* igt@kms_frontbuffer_tracking@drrs-2p-scndscrn-pri-indfb-draw-mmap-wc:
- shard-bmg: [SKIP][99] ([Intel XE#2312]) -> [SKIP][100] ([Intel XE#2311]) +13 other tests skip
[99]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3961-fb0f56ad8a2c9953c57c3337a72ccbf9c5050687/shard-bmg-6/igt@kms_frontbuffer_tracking@drrs-2p-scndscrn-pri-indfb-draw-mmap-wc.html
[100]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155951v2/shard-bmg-7/igt@kms_frontbuffer_tracking@drrs-2p-scndscrn-pri-indfb-draw-mmap-wc.html
* igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-cur-indfb-draw-render:
- shard-bmg: [SKIP][101] ([Intel XE#2312]) -> [SKIP][102] ([Intel XE#5390]) +6 other tests skip
[101]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3961-fb0f56ad8a2c9953c57c3337a72ccbf9c5050687/shard-bmg-6/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-cur-indfb-draw-render.html
[102]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155951v2/shard-bmg-8/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-cur-indfb-draw-render.html
* igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-spr-indfb-onoff:
- shard-bmg: [SKIP][103] ([Intel XE#5390]) -> [SKIP][104] ([Intel XE#2312]) +5 other tests skip
[103]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3961-fb0f56ad8a2c9953c57c3337a72ccbf9c5050687/shard-bmg-4/igt@[email protected]
[104]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155951v2/shard-bmg-6/igt@[email protected]
* igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-spr-indfb-draw-blt:
- shard-bmg: [SKIP][105] ([Intel XE#2313]) -> [SKIP][106] ([Intel XE#2312]) +8 other tests skip
[105]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3961-fb0f56ad8a2c9953c57c3337a72ccbf9c5050687/shard-bmg-1/igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-spr-indfb-draw-blt.html
[106]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155951v2/shard-bmg-6/igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-spr-indfb-draw-blt.html
* igt@kms_frontbuffer_tracking@psr-2p-primscrn-spr-indfb-fullscreen:
- shard-bmg: [SKIP][107] ([Intel XE#2312]) -> [SKIP][108] ([Intel XE#2313]) +13 other tests skip
[107]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3961-fb0f56ad8a2c9953c57c3337a72ccbf9c5050687/shard-bmg-6/igt@kms_frontbuffer_tracking@psr-2p-primscrn-spr-indfb-fullscreen.html
[108]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155951v2/shard-bmg-7/igt@kms_frontbuffer_tracking@psr-2p-primscrn-spr-indfb-fullscreen.html
* igt@kms_tiled_display@basic-test-pattern:
- shard-bmg: [SKIP][109] ([Intel XE#2426]) -> [FAIL][110] ([Intel XE#1729])
[109]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3961-fb0f56ad8a2c9953c57c3337a72ccbf9c5050687/shard-bmg-3/igt@[email protected]
[110]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155951v2/shard-bmg-1/igt@[email protected]
* igt@xe_module_load@load:
- shard-dg2-set2: ([PASS][111], [PASS][112], [PASS][113], [PASS][114], [PASS][115], [PASS][116], [PASS][117], [PASS][118], [PASS][119], [SKIP][120], [PASS][121], [PASS][122], [PASS][123], [PASS][124], [PASS][125], [PASS][126], [PASS][127], [PASS][128], [PASS][129], [PASS][130], [PASS][131], [PASS][132], [PASS][133], [PASS][134], [PASS][135], [PASS][136]) ([Intel XE#378]) -> ([ABORT][137], [ABORT][138], [ABORT][139], [ABORT][140], [ABORT][141], [ABORT][142], [ABORT][143], [ABORT][144], [ABORT][145], [ABORT][146], [ABORT][147], [ABORT][148], [ABORT][149], [ABORT][150], [ABORT][151], [ABORT][152], [ABORT][153], [ABORT][154], [ABORT][155], [ABORT][156], [ABORT][157], [ABORT][158], [ABORT][159], [ABORT][160], [ABORT][161]) ([Intel XE#5087])
[111]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3961-fb0f56ad8a2c9953c57c3337a72ccbf9c5050687/shard-dg2-434/igt@[email protected]
[112]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3961-fb0f56ad8a2c9953c57c3337a72ccbf9c5050687/shard-dg2-434/igt@[email protected]
[113]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3961-fb0f56ad8a2c9953c57c3337a72ccbf9c5050687/shard-dg2-434/igt@[email protected]
[114]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3961-fb0f56ad8a2c9953c57c3337a72ccbf9c5050687/shard-dg2-433/igt@[email protected]
[115]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3961-fb0f56ad8a2c9953c57c3337a72ccbf9c5050687/shard-dg2-432/igt@[email protected]
[116]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3961-fb0f56ad8a2c9953c57c3337a72ccbf9c5050687/shard-dg2-432/igt@[email protected]
[117]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3961-fb0f56ad8a2c9953c57c3337a72ccbf9c5050687/shard-dg2-436/igt@[email protected]
[118]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3961-fb0f56ad8a2c9953c57c3337a72ccbf9c5050687/shard-dg2-434/igt@[email protected]
[119]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3961-fb0f56ad8a2c9953c57c3337a72ccbf9c5050687/shard-dg2-433/igt@[email protected]
[120]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3961-fb0f56ad8a2c9953c57c3337a72ccbf9c5050687/shard-dg2-466/igt@[email protected]
[121]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3961-fb0f56ad8a2c9953c57c3337a72ccbf9c5050687/shard-dg2-436/igt@[email protected]
[122]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3961-fb0f56ad8a2c9953c57c3337a72ccbf9c5050687/shard-dg2-435/igt@[email protected]
[123]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3961-fb0f56ad8a2c9953c57c3337a72ccbf9c5050687/shard-dg2-433/igt@[email protected]
[124]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3961-fb0f56ad8a2c9953c57c3337a72ccbf9c5050687/shard-dg2-464/igt@[email protected]
[125]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3961-fb0f56ad8a2c9953c57c3337a72ccbf9c5050687/shard-dg2-463/igt@[email protected]
[126]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3961-fb0f56ad8a2c9953c57c3337a72ccbf9c5050687/shard-dg2-466/igt@[email protected]
[127]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3961-fb0f56ad8a2c9953c57c3337a72ccbf9c5050687/shard-dg2-466/igt@[email protected]
[128]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3961-fb0f56ad8a2c9953c57c3337a72ccbf9c5050687/shard-dg2-463/igt@[email protected]
[129]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3961-fb0f56ad8a2c9953c57c3337a72ccbf9c5050687/shard-dg2-435/igt@[email protected]
[130]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3961-fb0f56ad8a2c9953c57c3337a72ccbf9c5050687/shard-dg2-435/igt@[email protected]
[131]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3961-fb0f56ad8a2c9953c57c3337a72ccbf9c5050687/shard-dg2-432/igt@[email protected]
[132]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3961-fb0f56ad8a2c9953c57c3337a72ccbf9c5050687/shard-dg2-464/igt@[email protected]
[133]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3961-fb0f56ad8a2c9953c57c3337a72ccbf9c5050687/shard-dg2-466/igt@[email protected]
[134]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3961-fb0f56ad8a2c9953c57c3337a72ccbf9c5050687/shard-dg2-463/igt@[email protected]
[135]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3961-fb0f56ad8a2c9953c57c3337a72ccbf9c5050687/shard-dg2-463/igt@[email protected]
[136]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3961-fb0f56ad8a2c9953c57c3337a72ccbf9c5050687/shard-dg2-432/igt@[email protected]
[137]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155951v2/shard-dg2-463/igt@[email protected]
[138]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155951v2/shard-dg2-463/igt@[email protected]
[139]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155951v2/shard-dg2-463/igt@[email protected]
[140]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155951v2/shard-dg2-466/igt@[email protected]
[141]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155951v2/shard-dg2-466/igt@[email protected]
[142]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155951v2/shard-dg2-466/igt@[email protected]
[143]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155951v2/shard-dg2-435/igt@[email protected]
[144]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155951v2/shard-dg2-435/igt@[email protected]
[145]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155951v2/shard-dg2-435/igt@[email protected]
[146]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155951v2/shard-dg2-436/igt@[email protected]
[147]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155951v2/shard-dg2-436/igt@[email protected]
[148]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155951v2/shard-dg2-436/igt@[email protected]
[149]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155951v2/shard-dg2-433/igt@[email protected]
[150]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155951v2/shard-dg2-433/igt@[email protected]
[151]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155951v2/shard-dg2-433/igt@[email protected]
[152]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155951v2/shard-dg2-433/igt@[email protected]
[153]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155951v2/shard-dg2-464/igt@[email protected]
[154]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155951v2/shard-dg2-464/igt@[email protected]
[155]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155951v2/shard-dg2-464/igt@[email protected]
[156]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155951v2/shard-dg2-434/igt@[email protected]
[157]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155951v2/shard-dg2-434/igt@[email protected]
[158]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155951v2/shard-dg2-434/igt@[email protected]
[159]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155951v2/shard-dg2-432/igt@[email protected]
[160]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155951v2/shard-dg2-432/igt@[email protected]
[161]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155951v2/shard-dg2-432/igt@[email protected]
[Intel XE#1124]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1124
[Intel XE#1178]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1178
[Intel XE#1406]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1406
[Intel XE#1435]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1435
[Intel XE#1475]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1475
[Intel XE#1503]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1503
[Intel XE#1729]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1729
[Intel XE#1874]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1874
[Intel XE#2234]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2234
[Intel XE#2244]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2244
[Intel XE#2252]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2252
[Intel XE#2291]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2291
[Intel XE#2311]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2311
[Intel XE#2312]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2312
[Intel XE#2313]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2313
[Intel XE#2314]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2314
[Intel XE#2316]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2316
[Intel XE#2320]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2320
[Intel XE#2322]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2322
[Intel XE#2341]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2341
[Intel XE#2391]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2391
[Intel XE#2426]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2426
[Intel XE#2457]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2457
[Intel XE#2652]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2652
[Intel XE#2850]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2850
[Intel XE#2887]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2887
[Intel XE#2894]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2894
[Intel XE#2927]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2927
[Intel XE#2953]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2953
[Intel XE#301]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/301
[Intel XE#3414]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/3414
[Intel XE#367]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/367
[Intel XE#378]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/378
[Intel XE#3868]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/3868
[Intel XE#3876]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/3876
[Intel XE#3884]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/3884
[Intel XE#3904]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/3904
[Intel XE#4173]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/4173
[Intel XE#4227]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/4227
[Intel XE#4354]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/4354
[Intel XE#4504]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/4504
[Intel XE#4543]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/4543
[Intel XE#4596]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/4596
[Intel XE#4633]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/4633
[Intel XE#4837]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/4837
[Intel XE#4842]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/4842
[Intel XE#4937]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/4937
[Intel XE#4943]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/4943
[Intel XE#5087]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/5087
[Intel XE#5390]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/5390
[Intel XE#5545]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/5545
[Intel XE#5625]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/5625
[Intel XE#6050]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/6050
[Intel XE#6162]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/6162
[Intel XE#6325]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/6325
[Intel XE#787]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/787
[Intel XE#944]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/944
Build changes
-------------
* Linux: xe-3961-fb0f56ad8a2c9953c57c3337a72ccbf9c5050687 -> xe-pw-155951v2
IGT_8594: 8594
xe-3961-fb0f56ad8a2c9953c57c3337a72ccbf9c5050687: fb0f56ad8a2c9953c57c3337a72ccbf9c5050687
xe-pw-155951v2: 155951v2
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155951v2/index.html