drm/i915/display: Add initial support for Xe3p_LPD
Subsystems (3)
v4 cover drm/i915/display: Add initial support for Xe3p_LPD
This series adds initial support for Xe3p_LPD, Intel's display architecture with IP version 35.
This series contains basic enabling patches and does not provide complete support for the display IP yet. More involved features, like the new PHY implementation and ALPM are implemented as separate patch series.
---
Changes in v4:
- Skipped patches from v3 that were already applied.
- Dropped patch "drm/i915/xe3p_lpd: Enable system caching for FBC" with
the expectation that its next version will be sent as a standalone
patch.
- Link to v3: https://patch.msgid.link/[email protected]
Changes in v3:
- Reshuffled patches so that most of the ones already containing a r-b
are placed at the start.
- Dropped "drm/i915/xe3p_lpd: Wait for AUX channel power status", as a
similar patch was already applied from a patch series dedicated to LT
PHY
(https://lore.kernel.org/all/[email protected]/).
- Dropped patches related to UINT16 plane formats, as they were
incomplete and were not specific to Xe3p_LPD.
- Dropped FBC related patches, as Vinod is handling them as a separated
series
(https://lore.kernel.org/intel-gfx/[email protected]/)
- Dropped "drm/i915/xe3p_lpd: PSR SU minimum lines is 4", since that
change is not valid according to Bspec.
- Incorporated review feedback on the other patches. Please check the
changelog in the individual patches for details.
- Link to v2: https://lore.kernel.org/r/[email protected]
Changes in v2:
- Incorporated review feedback. Please check the changelog in the
patches for details.
- Link to v1: https://lore.kernel.org/r/[email protected]
---
Gustavo Sousa (10):
drm/i915/wm: Do not make latency values monotonic on Xe3 onward drm/i915/vbt: Add fields dedicated_external and dyn_port_over_tc drm/i915/power: Use intel_encoder_is_tc()
drm/i915/display: Handle dedicated external ports in intel_encoder_is_tc() drm/i915/fbc: Add intel_fbc_id_for_pipe()
drm/i915/xe3p_lpd: Handle underrun debug bits drm/i915/xe3p_lpd: Extend Type-C flow for static DDI allocation drm/i915/display: Use platform check in HAS_LT_PHY() drm/i915/display: Move HAS_LT_PHY() to intel_display_device.h drm/i915/display: Use HAS_LT_PHY() for LT PHY AUX power
Sai Teja Pottumuttu (1):
drm/i915/nvls: Add NVL-S display support
drivers/gpu/drm/i915/display/intel_bios.c | 54 +++++++- drivers/gpu/drm/i915/display/intel_bios.h | 2 + drivers/gpu/drm/i915/display/intel_ddi.c | 11 ++ drivers/gpu/drm/i915/display/intel_display.c | 19 ++- .../gpu/drm/i915/display/intel_display_device.c | 5 + .../gpu/drm/i915/display/intel_display_device.h | 6 +- .../drm/i915/display/intel_display_power_well.c | 42 +++--- drivers/gpu/drm/i915/display/intel_display_regs.h | 36 ++++- drivers/gpu/drm/i915/display/intel_display_types.h | 1 + drivers/gpu/drm/i915/display/intel_fbc.c | 5 + drivers/gpu/drm/i915/display/intel_fbc.h | 2 + drivers/gpu/drm/i915/display/intel_fbc_regs.h | 2 + drivers/gpu/drm/i915/display/intel_fifo_underrun.c | 128 +++++++++++++++++ drivers/gpu/drm/i915/display/intel_lt_phy.h | 2 - drivers/gpu/drm/i915/display/intel_tc.c | 151 ++++++++++++++++++++- drivers/gpu/drm/i915/display/intel_vbt_defs.h | 3 +- drivers/gpu/drm/i915/display/skl_universal_plane.c | 9 +- drivers/gpu/drm/i915/display/skl_watermark.c | 17 ++- 18 files changed, 462 insertions(+), 33 deletions(-)
---
base-commit: 2bc418aa7efaae562e49d84e8b28f799cf624745
change-id: 20251014-xe3p_lpd-basic-enabling-eb4424698b44
Best regards,
Signature · 1 line
Gustavo Sousa <[email protected]>
PATCH v4 1/11 drm/i915/wm: Do not make latency values monotonic on Xe3 onward
The Windows driver is rejecting non-monotonic ranges latency values for Xe3. Let's make sure that we do not call make_wm_latency_monotonic() for Xe3 and beyond.
Also, because of that, let's add a check at the end of adjust_wm_latency() to ensure we raise a warning if the final list of latency values is not monotonic.
--- drivers/gpu/drm/i915/display/skl_watermark.c | 17 ++++++++++++++++- 1 file changed, 16 insertions(+), 1 deletion(-)
drivers/gpu/drm/i915/display/skl_watermark.c +16 -1
@@ -3218,6 +3218,18 @@ static void make_wm_latency_monotonic(struct intel_display *display) } } +static bool is_wm_latency_monotonic (struct intel_display *display) +{ +u16 *wm = display->wm.skl_latency; +int level, num_levels = display->wm.num_levels; + +for (level =1 ; level < num_levels; level++) +if (wm[level] < wm[level -1 ]) +return false; + +return true; +} +static void adjust_wm_latency (struct intel_display *display) {
@@ -3228,7 +3240,8 @@ adjust_wm_latency(struct intel_display *display)sanitize_wm_latency (display); -make_wm_latency_monotonic (display); +if (DISPLAY_VER (display) <30 ) +make_wm_latency_monotonic (display);/* * WaWmMemoryReadLatency
@@ -3248,6 +3261,8 @@ adjust_wm_latency(struct intel_display *display)*/ if (need_16gb_dimm_wa (display))increase_wm_latency (display,1 ); + +drm_WARN_ON (display->drm, !is_wm_latency_monotonic (display)); }static void mtl_read_wm_latency (struct intel_display *display)
Signature · 1 line
2.51.0
RE: [PATCH v4 01/11] drm/i915/wm: Do not make latency values monotonic on Xe3 onward
Quoted 6 lines
Subject: [PATCH v4 01/11] drm/i915/wm: Do not make latency values monotonic on Xe3 onward
The Windows driver is rejecting non-monotonic ranges latency values for Xe3. Let's make sure that we do not call
make_wm_latency_monotonic()for Xe3 and beyond.
Idt saying we are doing It because Windows driver is doing it is the correct reason to do this. This may very well be needed but I think its better to add the right reason here. Also Bspec no. at trailer if available.
Rest looks good to me
Regards,
Suraj Kandpal
Quoted 57 lines
Also, because of that, let's add a check at the end of
adjust_wm_latency()to ensure we raise a warning if the final list of latency values is not monotonic.Cc Ville Syrjälä <[email protected]>Suggested-by Ville Syrjälä <[email protected]>Signed-off-by Gustavo Sousa <[email protected]>--- drivers/gpu/drm/i915/display/skl_watermark.c | 17 ++++++++++++++++- 1 file changed, 16 insertions(+), 1 deletion(-)drivers/gpu/drm/i915/display/skl_watermark.c +11
-0@@ -3218,6 +3218,18 @@ static void make_wm_latency_monotonic(struct intel_display *display) } } +static bool is_wm_latency_monotonic (struct intel_display *display) { +u16 *wm = display->wm.skl_latency; +int level, num_levels = display->wm.num_levels; + +for (level =1 ; level < num_levels; level++) +if (wm[level] < wm[level -1 ]) +return false; + +return true; +} +static void adjust_wm_latency(struct intel_display *display) { @@ -3228,7 +3240,8 @@
adjust_wm_latency(struct intel_display *display)drivers/gpu/drm/i915/display/skl_watermark.c +4
-2sanitize_wm_latency (display); -make_wm_latency_monotonic (display); +if (DISPLAY_VER (display) <30 ) +make_wm_latency_monotonic (display);/* * WaWmMemoryReadLatency @@ -3248,6 +3261,8 @@ adjust_wm_latency(struct intel_display *display)*/ if (need_16gb_dimm_wa (display))increase_wm_latency (display,1 ); + +drm_WARN_ON (display->drm, !is_wm_latency_monotonic (display)); }static void mtl_read_wm_latency (struct intel_display *display) --2.51.0
RE: [PATCH v4 01/11] drm/i915/wm: Do not make latency values monotonic on Xe3 onward
Quoting Kandpal, Suraj (2025-11-12 00:46:59-03:00)
Quoted 9 lines
Quoted 6 lines
Subject: [PATCH v4 01/11] drm/i915/wm: Do not make latency values monotonic on Xe3 onward
The Windows driver is rejecting non-monotonic ranges latency values for Xe3. Let's make sure that we do not call
make_wm_latency_monotonic()for Xe3 and beyond.Idt saying we are doing It because Windows driver is doing it is the correct reason to do this. This may very well be needed but I think its better to add the right reason here.
Yeah, that's fair. Maybe Ville can provide more details here.
Also note that there is some discussion[1] on v3 of the series (v4 was posted here because of an imminent unavailability of my part).
[1] https://lore.kernel.org/all/[email protected]/
Quoted 1 line
Also Bspec no. at trailer if available.
I am not sure there is a good Bspec number to refer to here. :-\
Quoted 2 lines
Rest looks good to me
Thanks!
--
Gustavo Sousa
Quoted 62 lines
Regards,
Suraj KandpalQuoted 57 lines
Also, because of that, let's add a check at the end of
adjust_wm_latency()to ensure we raise a warning if the final list of latency values is not monotonic.Cc Ville Syrjälä <[email protected]>Suggested-by Ville Syrjälä <[email protected]>Signed-off-by Gustavo Sousa <[email protected]>--- drivers/gpu/drm/i915/display/skl_watermark.c | 17 ++++++++++++++++- 1 file changed, 16 insertions(+), 1 deletion(-)drivers/gpu/drm/i915/display/skl_watermark.c +11
-0@@ -3218,6 +3218,18 @@ static void make_wm_latency_monotonic(struct intel_display *display) } } +static bool is_wm_latency_monotonic (struct intel_display *display) { +u16 *wm = display->wm.skl_latency; +int level, num_levels = display->wm.num_levels; + +for (level =1 ; level < num_levels; level++) +if (wm[level] < wm[level -1 ]) +return false; + +return true; +} +static void adjust_wm_latency(struct intel_display *display) { @@ -3228,7 +3240,8 @@
adjust_wm_latency(struct intel_display *display)sanitize_wm_latency(display);drivers/gpu/drm/i915/display/skl_watermark.c +4
-2-make_wm_latency_monotonic (display); +if (DISPLAY_VER (display) <30 ) +make_wm_latency_monotonic (display);/* * WaWmMemoryReadLatency @@ -3248,6 +3261,8 @@ adjust_wm_latency(struct intel_display *display)*/ if (need_16gb_dimm_wa (display))increase_wm_latency (display,1 ); + +drm_WARN_ON (display->drm, !is_wm_latency_monotonic (display)); }static void mtl_read_wm_latency (struct intel_display *display) --2.51.0
PATCH v4 2/11 drm/i915/vbt: Add fields dedicated_external and dyn_port_over_tc
In reply to Gustavo SousaVBT version 264 adds new fields associated to Xe3p_LPD's new ways of configuring SoC for TC ports and PHYs. Update the code to match the updates in VBT.
The new field dedicated_external is used to represent TC ports that are connected to PHYs outside of the Type-C subsystem, meaning that they behave like dedicated ports and don't require the extra Type-C programming. In an upcoming change, we will update the driver to take this field into consideration when detecting the type of port.
The new field dyn_port_over_tc is used to inform that the TC port can be dynamically allocated for a legacy connector in the Type-C subsystem, which is a new feature in Xe3p_LPD. In upcoming changes, we will use that field in order to handle the IOM resource management programming required for that.
Note that, when dedicated_external is set, the fields dp_usb_type_c and tbt are tagged as "don't care" in the spec, so they should be ignored in that case, so also add a sanitization function to take care of forcing them to zero when dedicated_external is true.
v2:
- Use sanitization function to force dp_usb_type_c and tbt fields to be zero instead of adding a intel_bios_encoder_is_dedicated_external() check in each of their respective accessor functions. (Jani)
- Print info about dedicated external ports in print_ddi_port().
(Jani)
Bspec: 20124, 68954, 74304
--- drivers/gpu/drm/i915/display/intel_bios.c | 54 ++++++++++++++++++++++++++- drivers/gpu/drm/i915/display/intel_bios.h | 2 + drivers/gpu/drm/i915/display/intel_vbt_defs.h | 3 +- 3 files changed, 56 insertions(+), 3 deletions(-)
drivers/gpu/drm/i915/display/intel_bios.c +52 -2
@@ -2530,6 +2530,36 @@ intel_bios_encoder_reject_edp_rate(const struct intel_bios_encoder_data *devdatareturn devdata->child.edp_data_rate_override &edp_rate_override_mask (rate); } +static void sanitize_dedicated_external (struct intel_bios_encoder_data *devdata, +enum port port) +{ +struct intel_display *display = devdata->display; + +if (!intel_bios_encoder_is_dedicated_external (devdata)) +return ; + +/* +* Fields dp_usb_type_c and tbt must be ignored when +* dedicated_external is set. Since dedicated_external is for +* ports connected to PHYs outside of the Type-C subsystem, it +* is safe to force those fields to zero. +*/ + +if (devdata->child.dp_usb_type_c) { +drm_dbg_kms (display->drm, +"VBT claims Port %c supports USB Type-C, but the port is dedicated external, ignoring\n" , +port_name (port)); + devdata->child.dp_usb_type_c =0 ; + } + +if (devdata->child.tbt) { +drm_dbg_kms (display->drm, +"VBT claims Port %c supports TBT, but the port is dedicated external, ignoring\n" , +port_name (port)); + devdata->child.tbt =0 ; + } +} +static void sanitize_device_type (struct intel_bios_encoder_data *devdata,enum port port) {
@@ -2668,7 +2698,8 @@ static void print_ddi_port(const struct intel_bios_encoder_data *devdata) {struct intel_display *display = devdata->display;const struct child_device_config *child = &devdata->child; -bool is_dvi, is_hdmi, is_dp, is_edp, is_dsi, is_crt, supports_typec_usb, supports_tbt; +bool is_dvi, is_hdmi, is_dp, is_edp, is_dsi, is_crt, supports_typec_usb, + supports_tbt, dedicated_external;int dp_boost_level, dp_max_link_rate, hdmi_boost_level, hdmi_level_shift, max_tmds_clock;enum port port;
@@ -2694,6 +2725,12 @@ static void print_ddi_port(const struct intel_bios_encoder_data *devdata) supports_typec_usb, supports_tbt, devdata->dsc != NULL); + dedicated_external =intel_bios_encoder_is_dedicated_external (devdata); +if (dedicated_external) +drm_dbg_kms (display->drm, +"Port %c is dedicated external\n" , +port_name (port)); + hdmi_level_shift =intel_bios_hdmi_level_shift (devdata);if (hdmi_level_shift >=0 ) { drm_dbg_kms(display->drm,
@@ -2751,6 +2788,7 @@ static void parse_ddi_port(struct intel_bios_encoder_data *devdata)return ; } +sanitize_dedicated_external (devdata, port);sanitize_device_type (devdata, port);sanitize_hdmi_level_shift (devdata, port); }
@@ -2778,7 +2816,7 @@ static int child_device_expected_size(u16 version) {BUILD_BUG_ON (sizeof (struct child_device_config ) <40 ); -if (version >263 ) +if (version >264 )return -ENOENT ;else if (version >=263 )return 44 ;
@@ -3723,6 +3761,18 @@ bool intel_bios_encoder_supports_tbt(const struct intel_bios_encoder_data *devdareturn devdata->display->vbt.version >=209 && devdata->child.tbt; } +bool intel_bios_encoder_is_dedicated_external (const struct intel_bios_encoder_data *devdata) +{ +return devdata->display->vbt.version >=264 && + devdata->child.dedicated_external; +} + +bool intel_bios_encoder_supports_dyn_port_over_tc (const struct intel_bios_encoder_data *devdata) +{ +return devdata->display->vbt.version >=264 && + devdata->child.dyn_port_over_tc; +} +bool intel_bios_encoder_lane_reversal (const struct intel_bios_encoder_data *devdata) {return devdata && devdata->child.lane_reversal;
drivers/gpu/drm/i915/display/intel_bios.h +2 -0
@@ -79,6 +79,8 @@ bool intel_bios_encoder_supports_dp(const struct intel_bios_encoder_data *devdatbool intel_bios_encoder_supports_edp (const struct intel_bios_encoder_data *devdata);bool intel_bios_encoder_supports_typec_usb (const struct intel_bios_encoder_data *devdata);bool intel_bios_encoder_supports_tbt (const struct intel_bios_encoder_data *devdata); +bool intel_bios_encoder_is_dedicated_external (const struct intel_bios_encoder_data *devdata); +bool intel_bios_encoder_supports_dyn_port_over_tc (const struct intel_bios_encoder_data *devdata);bool intel_bios_encoder_supports_dsi (const struct intel_bios_encoder_data *devdata);bool intel_bios_encoder_supports_dp_dual_mode (const struct intel_bios_encoder_data *devdata);bool intel_bios_encoder_is_lspcon (const struct intel_bios_encoder_data *devdata);
drivers/gpu/drm/i915/display/intel_vbt_defs.h +2 -1
@@ -554,7 +554,8 @@ struct child_device_config {u8 dvo_function; u8 dp_usb_type_c:1; /* 195+ */ u8 tbt:1; /* 209+ */ - u8 flags2_reserved:2; /* 195+ */ + u8 dedicated_external:1; /* 264+ */ + u8 dyn_port_over_tc:1; /* 264+ */ u8 dp_port_trace_length:4; /* 209+ */u8 dp_gpio_index;/* 195+ */ u16 dp_gpio_pin_num;/* 195+ */
Signature · 1 line
2.51.0
Re: [PATCH v4 02/11] drm/i915/vbt: Add fields dedicated_external and dyn_port_over_tc
Quoted 91 lines · Gustavo Sousa
VBT version 264 adds new fields associated to Xe3p_LPD's new ways of configuring SoC for TC ports and PHYs. Update the code to match the updates in VBT.
The new field
dedicated_externalis used to represent TC ports that are connected to PHYs outside of the Type-C subsystem, meaning that they behave like dedicated ports and don't require the extra Type-C programming. In an upcoming change, we will update the driver to take this field into consideration when detecting the type of port.The new field
dyn_port_over_tcis used to inform that the TC port can be dynamically allocated for a legacy connector in the Type-C subsystem, which is a new feature inXe3p_LPD. In upcoming changes, we will use that field in order to handle the IOM resource management programming required for that.Note that, when
dedicated_externalis set, the fieldsdp_usb_type_cand tbt are tagged as "don't care" in the spec, so they should be ignored in that case, so also add a sanitization function to take care of forcing them to zero whendedicated_externalis true.v2:
- Use sanitization function to forcedp_usb_type_cand tbt fields to be zero instead of adding aintel_bios_encoder_is_dedicated_external()check in each of their respective accessor functions. (Jani)
- Print info about dedicated external ports inprint_ddi_port().(Jani)Bspec: 20124, 68954, 74304
Cc Jani Nikula <[email protected]>Cc Shekhar Chauhan <[email protected]>Signed-off-by Gustavo Sousa <[email protected]>--- drivers/gpu/drm/i915/display/intel_bios.c | 54 ++++++++++++++++++++++++++- drivers/gpu/drm/i915/display/intel_bios.h | 2 + drivers/gpu/drm/i915/display/intel_vbt_defs.h | 3 +- 3 files changed, 56 insertions(+), 3 deletions(-)drivers/gpu/drm/i915/display/intel_bios.c +32
-1@@ -2530,6 +2530,36 @@ intel_bios_encoder_reject_edp_rate(const struct intel_bios_encoder_data *devdatareturn devdata->child.edp_data_rate_override &edp_rate_override_mask (rate); } +static void sanitize_dedicated_external (struct intel_bios_encoder_data *devdata, +enum port port) +{ +struct intel_display *display = devdata->display; + +if (!intel_bios_encoder_is_dedicated_external (devdata)) +return ; + +/* +* Fields dp_usb_type_c and tbt must be ignored when +* dedicated_external is set. Since dedicated_external is for +* ports connected to PHYs outside of the Type-C subsystem, it +* is safe to force those fields to zero. +*/ + +if (devdata->child.dp_usb_type_c) { +drm_dbg_kms (display->drm, +"VBT claims Port %c supports USB Type-C, but the port is dedicated external, ignoring\n" , +port_name (port)); + devdata->child.dp_usb_type_c =0 ; + } + +if (devdata->child.tbt) { +drm_dbg_kms (display->drm, +"VBT claims Port %c supports TBT, but the port is dedicated external, ignoring\n" , +port_name (port)); + devdata->child.tbt =0 ; + } +} +static void sanitize_device_type (struct intel_bios_encoder_data *devdata,enum port port) {@@ -2668,7 +2698,8 @@ static void print_ddi_port(const struct intel_bios_encoder_data *devdata) {struct intel_display *display = devdata->display;const struct child_device_config *child = &devdata->child; -bool is_dvi, is_hdmi, is_dp, is_edp, is_dsi, is_crt, supports_typec_usb, supports_tbt; +bool is_dvi, is_hdmi, is_dp, is_edp, is_dsi, is_crt, supports_typec_usb, + supports_tbt, dedicated_external;int dp_boost_level, dp_max_link_rate, hdmi_boost_level, hdmi_level_shift, max_tmds_clock;enum port port;
drivers/gpu/drm/i915/display/intel_bios.c static void print_ddi_port(const struct intel_bios_encoder_data *devdata) · line 2729
Quoted 5 lines
drivers/gpu/drm/i915/display/intel_bios.c +2
-0@@ -2694,6 +2725,12 @@ static void print_ddi_port(const struct intel_bios_encoder_data *devdata) supports_typec_usb, supports_tbt, devdata->dsc != NULL); + dedicated_external =intel_bios_encoder_is_dedicated_external (devdata); +if (dedicated_external)
Nit: the variable could be dropped imo, and would be good to print the dyn_port_over_tc info as well. Either way:
Quoted 74 lines
drivers/gpu/drm/i915/display/intel_bios.c +18
-1+drm_dbg_kms (display->drm, +"Port %c is dedicated external\n" , +port_name (port)); + hdmi_level_shift =intel_bios_hdmi_level_shift (devdata);if (hdmi_level_shift >=0 ) { drm_dbg_kms(display->drm,@@ -2751,6 +2788,7 @@ static void parse_ddi_port(struct intel_bios_encoder_data *devdata)return ; } +sanitize_dedicated_external (devdata, port);sanitize_device_type (devdata, port);sanitize_hdmi_level_shift (devdata, port); }@@ -2778,7 +2816,7 @@ static int child_device_expected_size(u16 version) {BUILD_BUG_ON (sizeof (struct child_device_config ) <40 ); -if (version >263 ) +if (version >264 )return -ENOENT ;else if (version >=263 )return 44 ;@@ -3723,6 +3761,18 @@ bool intel_bios_encoder_supports_tbt(const struct intel_bios_encoder_data *devdareturn devdata->display->vbt.version >=209 && devdata->child.tbt; } +bool intel_bios_encoder_is_dedicated_external (const struct intel_bios_encoder_data *devdata) +{ +return devdata->display->vbt.version >=264 && + devdata->child.dedicated_external; +} + +bool intel_bios_encoder_supports_dyn_port_over_tc (const struct intel_bios_encoder_data *devdata) +{ +return devdata->display->vbt.version >=264 && + devdata->child.dyn_port_over_tc; +} +bool intel_bios_encoder_lane_reversal (const struct intel_bios_encoder_data *devdata) {return devdata && devdata->child.lane_reversal;drivers/gpu/drm/i915/display/intel_bios.h +2
-0@@ -79,6 +79,8 @@ bool intel_bios_encoder_supports_dp(const struct intel_bios_encoder_data *devdatbool intel_bios_encoder_supports_edp (const struct intel_bios_encoder_data *devdata);bool intel_bios_encoder_supports_typec_usb (const struct intel_bios_encoder_data *devdata);bool intel_bios_encoder_supports_tbt (const struct intel_bios_encoder_data *devdata); +bool intel_bios_encoder_is_dedicated_external (const struct intel_bios_encoder_data *devdata); +bool intel_bios_encoder_supports_dyn_port_over_tc (const struct intel_bios_encoder_data *devdata);bool intel_bios_encoder_supports_dsi (const struct intel_bios_encoder_data *devdata);bool intel_bios_encoder_supports_dp_dual_mode (const struct intel_bios_encoder_data *devdata);bool intel_bios_encoder_is_lspcon (const struct intel_bios_encoder_data *devdata);drivers/gpu/drm/i915/display/intel_vbt_defs.h +2
-1@@ -554,7 +554,8 @@ struct child_device_config {u8 dvo_function; u8 dp_usb_type_c:1; /* 195+ */ u8 tbt:1; /* 209+ */ - u8 flags2_reserved:2; /* 195+ */ + u8 dedicated_external:1; /* 264+ */ + u8 dyn_port_over_tc:1; /* 264+ */ u8 dp_port_trace_length:4; /* 209+ */u8 dp_gpio_index;/* 195+ */ u16 dp_gpio_pin_num;/* 195+ */ Signature · 2 lines
-- 2.51.0
Re: [PATCH v4 02/11] drm/i915/vbt: Add fields dedicated_external and dyn_port_over_tc
Quoted 48 lines · Imre Deak
Quoted 47 lines · Gustavo Sousa
VBT version 264 adds new fields associated to Xe3p_LPD's new ways of configuring SoC for TC ports and PHYs. Update the code to match the updates in VBT.
The new field
dedicated_externalis used to represent TC ports that are connected to PHYs outside of the Type-C subsystem, meaning that they behave like dedicated ports and don't require the extra Type-C programming. In an upcoming change, we will update the driver to take this field into consideration when detecting the type of port.The new field
dyn_port_over_tcis used to inform that the TC port can be dynamically allocated for a legacy connector in the Type-C subsystem, which is a new feature inXe3p_LPD. In upcoming changes, we will use that field in order to handle the IOM resource management programming required for that.Note that, when
dedicated_externalis set, the fieldsdp_usb_type_cand tbt are tagged as "don't care" in the spec, so they should be ignored in that case, so also add a sanitization function to take care of forcing them to zero whendedicated_externalis true.v2:
- Use sanitization function to forcedp_usb_type_cand tbt fields to be zero instead of adding aintel_bios_encoder_is_dedicated_external()check in each of their respective accessor functions. (Jani)
- Print info about dedicated external ports inprint_ddi_port().(Jani)Bspec: 20124, 68954, 74304
Cc Jani Nikula <[email protected]>Cc Shekhar Chauhan <[email protected]>Signed-off-by Gustavo Sousa <[email protected]>--- drivers/gpu/drm/i915/display/intel_bios.c | 54 ++++++++++++++++++++++++++- drivers/gpu/drm/i915/display/intel_bios.h | 2 + drivers/gpu/drm/i915/display/intel_vbt_defs.h | 3 +- 3 files changed, 56 insertions(+), 3 deletions(-)drivers/gpu/drm/i915/display/intel_bios.c +0
-0@@ -2530,6 +2530,36 @@ intel_bios_encoder_reject_edp_rate(const struct intel_bios_encoder_data *devdatareturn devdata->child.edp_data_rate_override &edp_rate_override_mask (rate); }
Quoted 14 lines
Quoted 4 lines
drivers/gpu/drm/i915/display/intel_bios.c +4
-0+static void sanitize_dedicated_external (struct intel_bios_encoder_data *devdata, +enum port port) +{ +struct intel_display *display = devdata->display;drivers/gpu/drm/i915/display/intel_bios.c intel_bios_encoder_reject_edp_rate(const struct intel_bios_encoder_data *devdata · line 2546
Quoted 10 lines
drivers/gpu/drm/i915/display/intel_bios.c +10
-0+ +if (!intel_bios_encoder_is_dedicated_external (devdata)) +return ; + +/* +* Fields dp_usb_type_c and tbt must be ignored when +* dedicated_external is set. Since dedicated_external is for +* ports connected to PHYs outside of the Type-C subsystem, it +* is safe to force those fields to zero. +*/
Forgot this: IIUC dyn_port_over_tc doesn't make either sense for a dedicated external port. IOW, a dedicated port/PHY is not enabled by the TypeC sequences defined at bspec/68954 and so for such a port/PHY the DDI->PHY mapping is always 1:1 and so the corresponding DDI can't either be dynamically allocated to different PHYs. If that's a correct understanding, dyn_port_over_tc should be also verified/zeroed out here imo.
Quoted 115 lines
Quoted 30 lines
drivers/gpu/drm/i915/display/intel_bios.c +18
-1+ +if (devdata->child.dp_usb_type_c) { +drm_dbg_kms (display->drm, +"VBT claims Port %c supports USB Type-C, but the port is dedicated external, ignoring\n" , +port_name (port)); + devdata->child.dp_usb_type_c =0 ; + } + +if (devdata->child.tbt) { +drm_dbg_kms (display->drm, +"VBT claims Port %c supports TBT, but the port is dedicated external, ignoring\n" , +port_name (port)); + devdata->child.tbt =0 ; + } +} +static void sanitize_device_type (struct intel_bios_encoder_data *devdata,enum port port) {@@ -2668,7 +2698,8 @@ static void print_ddi_port(const struct intel_bios_encoder_data *devdata) {struct intel_display *display = devdata->display;const struct child_device_config *child = &devdata->child; -bool is_dvi, is_hdmi, is_dp, is_edp, is_dsi, is_crt, supports_typec_usb, supports_tbt; +bool is_dvi, is_hdmi, is_dp, is_edp, is_dsi, is_crt, supports_typec_usb, + supports_tbt, dedicated_external;int dp_boost_level, dp_max_link_rate, hdmi_boost_level, hdmi_level_shift, max_tmds_clock;enum port port;drivers/gpu/drm/i915/display/intel_bios.c static void print_ddi_port(const struct intel_bios_encoder_data *devdata) · line 2729
Quoted 5 lines
drivers/gpu/drm/i915/display/intel_bios.c +2
-0@@ -2694,6 +2725,12 @@ static void print_ddi_port(const struct intel_bios_encoder_data *devdata) supports_typec_usb, supports_tbt, devdata->dsc != NULL); + dedicated_external =intel_bios_encoder_is_dedicated_external (devdata); +if (dedicated_external)Nit: the variable could be dropped imo, and would be good to print the
dyn_port_over_tcinfo as well. Either way:Reviewed-by Imre Deak <[email protected]>Quoted 74 lines
drivers/gpu/drm/i915/display/intel_bios.c +18
-1+drm_dbg_kms (display->drm, +"Port %c is dedicated external\n" , +port_name (port)); + hdmi_level_shift =intel_bios_hdmi_level_shift (devdata);if (hdmi_level_shift >=0 ) { drm_dbg_kms(display->drm,@@ -2751,6 +2788,7 @@ static void parse_ddi_port(struct intel_bios_encoder_data *devdata)return ; } +sanitize_dedicated_external (devdata, port);sanitize_device_type (devdata, port);sanitize_hdmi_level_shift (devdata, port); }@@ -2778,7 +2816,7 @@ static int child_device_expected_size(u16 version) {BUILD_BUG_ON (sizeof (struct child_device_config ) <40 ); -if (version >263 ) +if (version >264 )return -ENOENT ;else if (version >=263 )return 44 ;@@ -3723,6 +3761,18 @@ bool intel_bios_encoder_supports_tbt(const struct intel_bios_encoder_data *devdareturn devdata->display->vbt.version >=209 && devdata->child.tbt; } +bool intel_bios_encoder_is_dedicated_external (const struct intel_bios_encoder_data *devdata) +{ +return devdata->display->vbt.version >=264 && + devdata->child.dedicated_external; +} + +bool intel_bios_encoder_supports_dyn_port_over_tc (const struct intel_bios_encoder_data *devdata) +{ +return devdata->display->vbt.version >=264 && + devdata->child.dyn_port_over_tc; +} +bool intel_bios_encoder_lane_reversal (const struct intel_bios_encoder_data *devdata) {return devdata && devdata->child.lane_reversal;drivers/gpu/drm/i915/display/intel_bios.h +2
-0@@ -79,6 +79,8 @@ bool intel_bios_encoder_supports_dp(const struct intel_bios_encoder_data *devdatbool intel_bios_encoder_supports_edp (const struct intel_bios_encoder_data *devdata);bool intel_bios_encoder_supports_typec_usb (const struct intel_bios_encoder_data *devdata);bool intel_bios_encoder_supports_tbt (const struct intel_bios_encoder_data *devdata); +bool intel_bios_encoder_is_dedicated_external (const struct intel_bios_encoder_data *devdata); +bool intel_bios_encoder_supports_dyn_port_over_tc (const struct intel_bios_encoder_data *devdata);bool intel_bios_encoder_supports_dsi (const struct intel_bios_encoder_data *devdata);bool intel_bios_encoder_supports_dp_dual_mode (const struct intel_bios_encoder_data *devdata);bool intel_bios_encoder_is_lspcon (const struct intel_bios_encoder_data *devdata);drivers/gpu/drm/i915/display/intel_vbt_defs.h +2
-1@@ -554,7 +554,8 @@ struct child_device_config {u8 dvo_function; u8 dp_usb_type_c:1; /* 195+ */ u8 tbt:1; /* 209+ */ - u8 flags2_reserved:2; /* 195+ */ + u8 dedicated_external:1; /* 264+ */ + u8 dyn_port_over_tc:1; /* 264+ */ u8 dp_port_trace_length:4; /* 209+ */u8 dp_gpio_index;/* 195+ */ u16 dp_gpio_pin_num;/* 195+ */ Signature · 2 lines
-- 2.51.0
Re: [PATCH v4 02/11] drm/i915/vbt: Add fields dedicated_external and dyn_port_over_tc
Quoting Imre Deak (2025-11-11 13:15:41-03:00)
Quoted 64 lines · Imre Deak
Quoted 48 lines · Gustavo Sousa
Quoted 47 lines
VBT version 264 adds new fields associated to Xe3p_LPD's new ways of configuring SoC for TC ports and PHYs. Update the code to match the updates in VBT.
The new field
dedicated_externalis used to represent TC ports that are connected to PHYs outside of the Type-C subsystem, meaning that they behave like dedicated ports and don't require the extra Type-C programming. In an upcoming change, we will update the driver to take this field into consideration when detecting the type of port.The new field
dyn_port_over_tcis used to inform that the TC port can be dynamically allocated for a legacy connector in the Type-C subsystem, which is a new feature inXe3p_LPD. In upcoming changes, we will use that field in order to handle the IOM resource management programming required for that.Note that, when
dedicated_externalis set, the fieldsdp_usb_type_cand tbt are tagged as "don't care" in the spec, so they should be ignored in that case, so also add a sanitization function to take care of forcing them to zero whendedicated_externalis true.v2:
- Use sanitization function to forcedp_usb_type_cand tbt fields to be zero instead of adding aintel_bios_encoder_is_dedicated_external()check in each of their respective accessor functions. (Jani)
- Print info about dedicated external ports inprint_ddi_port().(Jani)Bspec: 20124, 68954, 74304
Cc Jani Nikula <[email protected]>Cc Shekhar Chauhan <[email protected]>Signed-off-by Gustavo Sousa <[email protected]>--- drivers/gpu/drm/i915/display/intel_bios.c | 54 ++++++++++++++++++++++++++- drivers/gpu/drm/i915/display/intel_bios.h | 2 + drivers/gpu/drm/i915/display/intel_vbt_defs.h | 3 +- 3 files changed, 56 insertions(+), 3 deletions(-)drivers/gpu/drm/i915/display/intel_bios.c +0
-0@@ -2530,6 +2530,36 @@ intel_bios_encoder_reject_edp_rate(const struct intel_bios_encoder_data *devdatareturn devdata->child.edp_data_rate_override &edp_rate_override_mask (rate); }Quoted 14 lines
Quoted 4 lines
drivers/gpu/drm/i915/display/intel_bios.c +4
-0+static void sanitize_dedicated_external (struct intel_bios_encoder_data *devdata, +enum port port) +{ +struct intel_display *display = devdata->display;drivers/gpu/drm/i915/display/intel_bios.c intel_bios_encoder_reject_edp_rate(const struct intel_bios_encoder_data *devdata · line 2546
Quoted 10 lines
drivers/gpu/drm/i915/display/intel_bios.c +10
-0+ +if (!intel_bios_encoder_is_dedicated_external (devdata)) +return ; + +/* +* Fields dp_usb_type_c and tbt must be ignored when +* dedicated_external is set. Since dedicated_external is for +* ports connected to PHYs outside of the Type-C subsystem, it +* is safe to force those fields to zero. +*/
Quoted 7 lines
Forgot this: IIUC
dyn_port_over_tcdoesn't make either sense for a dedicated external port. IOW, a dedicated port/PHY is not enabled by the TypeC sequences defined at bspec/68954 and so for such a port/PHY theDDI->PHYmapping is always 1:1 and so the corresponding DDI can't either be dynamically allocated to different PHYs. If that's a correct understanding,dyn_port_over_tcshould be also verified/zeroed out here imo.
Yep, there shouldn't be any need for DDI allocation for dedicated external ports. However, we would only be checking for dyn_port_over_tc when doing the Type-C flows, which would not happen for a dedicated external port. Give that, do you think we need to add the extra check here?
The main reason we are adding those checks below is because the VBT spec marks those bits as "don't care" when dedicated_external is set.
--
Gustavo Sousa
Quoted 116 lines
Quoted 116 lines
Quoted 31 lines
drivers/gpu/drm/i915/display/intel_bios.c +18
-1+ +if (devdata->child.dp_usb_type_c) { +drm_dbg_kms (display->drm, +"VBT claims Port %c supports USB Type-C, but the port is dedicated external, ignoring\n" , +port_name (port)); + devdata->child.dp_usb_type_c =0 ; + } + +if (devdata->child.tbt) { +drm_dbg_kms (display->drm, +"VBT claims Port %c supports TBT, but the port is dedicated external, ignoring\n" , +port_name (port)); + devdata->child.tbt =0 ; + } +} +static void sanitize_device_type (struct intel_bios_encoder_data *devdata,enum port port) {@@ -2668,7 +2698,8 @@ static void print_ddi_port(const struct intel_bios_encoder_data *devdata) {struct intel_display *display = devdata->display;const struct child_device_config *child = &devdata->child; -bool is_dvi, is_hdmi, is_dp, is_edp, is_dsi, is_crt, supports_typec_usb, supports_tbt; +bool is_dvi, is_hdmi, is_dp, is_edp, is_dsi, is_crt, supports_typec_usb, + supports_tbt, dedicated_external;int dp_boost_level, dp_max_link_rate, hdmi_boost_level, hdmi_level_shift, max_tmds_clock;enum port port;drivers/gpu/drm/i915/display/intel_bios.c static void print_ddi_port(const struct intel_bios_encoder_data *devdata) · line 2729
Quoted 5 lines
drivers/gpu/drm/i915/display/intel_bios.c +2
-0@@ -2694,6 +2725,12 @@ static void print_ddi_port(const struct intel_bios_encoder_data *devdata) supports_typec_usb, supports_tbt, devdata->dsc != NULL); + dedicated_external =intel_bios_encoder_is_dedicated_external (devdata); +if (dedicated_external)Nit: the variable could be dropped imo, and would be good to print the
dyn_port_over_tcinfo as well. Either way:Reviewed-by Imre Deak <[email protected]>Quoted 74 lines
drivers/gpu/drm/i915/display/intel_bios.c +18
-1+drm_dbg_kms (display->drm, +"Port %c is dedicated external\n" , +port_name (port)); + hdmi_level_shift =intel_bios_hdmi_level_shift (devdata);if (hdmi_level_shift >=0 ) { drm_dbg_kms(display->drm,@@ -2751,6 +2788,7 @@ static void parse_ddi_port(struct intel_bios_encoder_data *devdata)return ; } +sanitize_dedicated_external (devdata, port);sanitize_device_type (devdata, port);sanitize_hdmi_level_shift (devdata, port); }@@ -2778,7 +2816,7 @@ static int child_device_expected_size(u16 version) {BUILD_BUG_ON (sizeof (struct child_device_config ) <40 ); -if (version >263 ) +if (version >264 )return -ENOENT ;else if (version >=263 )return 44 ;@@ -3723,6 +3761,18 @@ bool intel_bios_encoder_supports_tbt(const struct intel_bios_encoder_data *devdareturn devdata->display->vbt.version >=209 && devdata->child.tbt; } +bool intel_bios_encoder_is_dedicated_external (const struct intel_bios_encoder_data *devdata) +{ +return devdata->display->vbt.version >=264 && + devdata->child.dedicated_external; +} + +bool intel_bios_encoder_supports_dyn_port_over_tc (const struct intel_bios_encoder_data *devdata) +{ +return devdata->display->vbt.version >=264 && + devdata->child.dyn_port_over_tc; +} +bool intel_bios_encoder_lane_reversal (const struct intel_bios_encoder_data *devdata) {return devdata && devdata->child.lane_reversal;drivers/gpu/drm/i915/display/intel_bios.h +2
-0@@ -79,6 +79,8 @@ bool intel_bios_encoder_supports_dp(const struct intel_bios_encoder_data *devdatbool intel_bios_encoder_supports_edp (const struct intel_bios_encoder_data *devdata);bool intel_bios_encoder_supports_typec_usb (const struct intel_bios_encoder_data *devdata);bool intel_bios_encoder_supports_tbt (const struct intel_bios_encoder_data *devdata); +bool intel_bios_encoder_is_dedicated_external (const struct intel_bios_encoder_data *devdata); +bool intel_bios_encoder_supports_dyn_port_over_tc (const struct intel_bios_encoder_data *devdata);bool intel_bios_encoder_supports_dsi (const struct intel_bios_encoder_data *devdata);bool intel_bios_encoder_supports_dp_dual_mode (const struct intel_bios_encoder_data *devdata);bool intel_bios_encoder_is_lspcon (const struct intel_bios_encoder_data *devdata);drivers/gpu/drm/i915/display/intel_vbt_defs.h +2
-1@@ -554,7 +554,8 @@ struct child_device_config {u8 dvo_function; u8 dp_usb_type_c:1; /* 195+ */ u8 tbt:1; /* 209+ */ - u8 flags2_reserved:2; /* 195+ */ + u8 dedicated_external:1; /* 264+ */ + u8 dyn_port_over_tc:1; /* 264+ */ u8 dp_port_trace_length:4; /* 209+ */u8 dp_gpio_index;/* 195+ */ u16 dp_gpio_pin_num;/* 195+ */ Signature · 2 lines
-- 2.51.0
Re: [PATCH v4 02/11] drm/i915/vbt: Add fields dedicated_external and dyn_port_over_tc
Quoted 73 lines · Gustavo Sousa
Quoting Imre Deak (2025-11-11 13:15:41-03:00)
Quoted 64 lines · Imre Deak
Quoted 48 lines · Gustavo Sousa
Quoted 47 lines
VBT version 264 adds new fields associated to Xe3p_LPD's new ways of configuring SoC for TC ports and PHYs. Update the code to match the updates in VBT.
The new field
dedicated_externalis used to represent TC ports that are connected to PHYs outside of the Type-C subsystem, meaning that they behave like dedicated ports and don't require the extra Type-C programming. In an upcoming change, we will update the driver to take this field into consideration when detecting the type of port.The new field
dyn_port_over_tcis used to inform that the TC port can be dynamically allocated for a legacy connector in the Type-C subsystem, which is a new feature inXe3p_LPD. In upcoming changes, we will use that field in order to handle the IOM resource management programming required for that.Note that, when
dedicated_externalis set, the fieldsdp_usb_type_cand tbt are tagged as "don't care" in the spec, so they should be ignored in that case, so also add a sanitization function to take care of forcing them to zero whendedicated_externalis true.v2:
- Use sanitization function to forcedp_usb_type_cand tbt fields to be zero instead of adding aintel_bios_encoder_is_dedicated_external()check in each of their respective accessor functions. (Jani)
- Print info about dedicated external ports inprint_ddi_port().(Jani)Bspec: 20124, 68954, 74304
Cc Jani Nikula <[email protected]>Cc Shekhar Chauhan <[email protected]>Signed-off-by Gustavo Sousa <[email protected]>--- drivers/gpu/drm/i915/display/intel_bios.c | 54 ++++++++++++++++++++++++++- drivers/gpu/drm/i915/display/intel_bios.h | 2 + drivers/gpu/drm/i915/display/intel_vbt_defs.h | 3 +- 3 files changed, 56 insertions(+), 3 deletions(-)drivers/gpu/drm/i915/display/intel_bios.c +0
-0@@ -2530,6 +2530,36 @@ intel_bios_encoder_reject_edp_rate(const struct intel_bios_encoder_data *devdatareturn devdata->child.edp_data_rate_override &edp_rate_override_mask (rate); }Quoted 14 lines
Quoted 4 lines
drivers/gpu/drm/i915/display/intel_bios.c +4
-0+static void sanitize_dedicated_external (struct intel_bios_encoder_data *devdata, +enum port port) +{ +struct intel_display *display = devdata->display;drivers/gpu/drm/i915/display/intel_bios.c intel_bios_encoder_reject_edp_rate(const struct intel_bios_encoder_data *devdata · line 2546
Quoted 10 lines
drivers/gpu/drm/i915/display/intel_bios.c +10
-0+ +if (!intel_bios_encoder_is_dedicated_external (devdata)) +return ; + +/* +* Fields dp_usb_type_c and tbt must be ignored when +* dedicated_external is set. Since dedicated_external is for +* ports connected to PHYs outside of the Type-C subsystem, it +* is safe to force those fields to zero. +*/ Quoted 7 lines
Forgot this: IIUC
dyn_port_over_tcdoesn't make either sense for a dedicated external port. IOW, a dedicated port/PHY is not enabled by the TypeC sequences defined at bspec/68954 and so for such a port/PHY theDDI->PHYmapping is always 1:1 and so the corresponding DDI can't either be dynamically allocated to different PHYs. If that's a correct understanding,dyn_port_over_tcshould be also verified/zeroed out here imo.
Quoted 8 lines
Yep, there shouldn't be any need for DDI allocation for dedicated external ports. However, we would only be checking for
dyn_port_over_tcwhen doing the Type-C flows, which would not happen for a dedicated external port. Give that, do you think we need to add the extra check here?The main reason we are adding those checks below is because the VBT spec marks those bits as "don't care" when
dedicated_externalis set.
Right. To me, the interdependencies of these flags in VBT are a bit complex. We are reflecting now about the above dependency, which is good, since we'll at least agree then how these flags are supposed to work. Imo it should've been also documented more explicitly in Bspec, similarly to the DP-alt and TBT "don't care" documentation.
With all that, at least a code comment would be good about this for a future reader, but even the verify/zeroing would be useful imo, in case there is a VBT setting the flags contrary to our assumptions (that would remind us then to figure out if our or the VBT authors' assumptions were wrong).
It's a detail only, I'm not insisting on either of the above, so up to you (maybe you'd only update it in case you have to resend the patch anyway or stg).
Quoted 119 lines
--
Gustavo SousaQuoted 116 lines
Quoted 116 lines
Quoted 31 lines
drivers/gpu/drm/i915/display/intel_bios.c +18
-1+ +if (devdata->child.dp_usb_type_c) { +drm_dbg_kms (display->drm, +"VBT claims Port %c supports USB Type-C, but the port is dedicated external, ignoring\n" , +port_name (port)); + devdata->child.dp_usb_type_c =0 ; + } + +if (devdata->child.tbt) { +drm_dbg_kms (display->drm, +"VBT claims Port %c supports TBT, but the port is dedicated external, ignoring\n" , +port_name (port)); + devdata->child.tbt =0 ; + } +} +static void sanitize_device_type (struct intel_bios_encoder_data *devdata,enum port port) {@@ -2668,7 +2698,8 @@ static void print_ddi_port(const struct intel_bios_encoder_data *devdata) {struct intel_display *display = devdata->display;const struct child_device_config *child = &devdata->child; -bool is_dvi, is_hdmi, is_dp, is_edp, is_dsi, is_crt, supports_typec_usb, supports_tbt; +bool is_dvi, is_hdmi, is_dp, is_edp, is_dsi, is_crt, supports_typec_usb, + supports_tbt, dedicated_external;int dp_boost_level, dp_max_link_rate, hdmi_boost_level, hdmi_level_shift, max_tmds_clock;enum port port;drivers/gpu/drm/i915/display/intel_bios.c static void print_ddi_port(const struct intel_bios_encoder_data *devdata) · line 2729
Quoted 5 lines
drivers/gpu/drm/i915/display/intel_bios.c +2
-0@@ -2694,6 +2725,12 @@ static void print_ddi_port(const struct intel_bios_encoder_data *devdata) supports_typec_usb, supports_tbt, devdata->dsc != NULL); + dedicated_external =intel_bios_encoder_is_dedicated_external (devdata); +if (dedicated_external)Nit: the variable could be dropped imo, and would be good to print the
dyn_port_over_tcinfo as well. Either way:Reviewed-by Imre Deak <[email protected]>Quoted 74 lines
drivers/gpu/drm/i915/display/intel_bios.c +18
-1+drm_dbg_kms (display->drm, +"Port %c is dedicated external\n" , +port_name (port)); + hdmi_level_shift =intel_bios_hdmi_level_shift (devdata);if (hdmi_level_shift >=0 ) { drm_dbg_kms(display->drm,@@ -2751,6 +2788,7 @@ static void parse_ddi_port(struct intel_bios_encoder_data *devdata)return ; } +sanitize_dedicated_external (devdata, port);sanitize_device_type (devdata, port);sanitize_hdmi_level_shift (devdata, port); }@@ -2778,7 +2816,7 @@ static int child_device_expected_size(u16 version) {BUILD_BUG_ON (sizeof (struct child_device_config ) <40 ); -if (version >263 ) +if (version >264 )return -ENOENT ;else if (version >=263 )return 44 ;@@ -3723,6 +3761,18 @@ bool intel_bios_encoder_supports_tbt(const struct intel_bios_encoder_data *devdareturn devdata->display->vbt.version >=209 && devdata->child.tbt; } +bool intel_bios_encoder_is_dedicated_external (const struct intel_bios_encoder_data *devdata) +{ +return devdata->display->vbt.version >=264 && + devdata->child.dedicated_external; +} + +bool intel_bios_encoder_supports_dyn_port_over_tc (const struct intel_bios_encoder_data *devdata) +{ +return devdata->display->vbt.version >=264 && + devdata->child.dyn_port_over_tc; +} +bool intel_bios_encoder_lane_reversal (const struct intel_bios_encoder_data *devdata) {return devdata && devdata->child.lane_reversal;drivers/gpu/drm/i915/display/intel_bios.h +2
-0@@ -79,6 +79,8 @@ bool intel_bios_encoder_supports_dp(const struct intel_bios_encoder_data *devdatbool intel_bios_encoder_supports_edp (const struct intel_bios_encoder_data *devdata);bool intel_bios_encoder_supports_typec_usb (const struct intel_bios_encoder_data *devdata);bool intel_bios_encoder_supports_tbt (const struct intel_bios_encoder_data *devdata); +bool intel_bios_encoder_is_dedicated_external (const struct intel_bios_encoder_data *devdata); +bool intel_bios_encoder_supports_dyn_port_over_tc (const struct intel_bios_encoder_data *devdata);bool intel_bios_encoder_supports_dsi (const struct intel_bios_encoder_data *devdata);bool intel_bios_encoder_supports_dp_dual_mode (const struct intel_bios_encoder_data *devdata);bool intel_bios_encoder_is_lspcon (const struct intel_bios_encoder_data *devdata);drivers/gpu/drm/i915/display/intel_vbt_defs.h +2
-1@@ -554,7 +554,8 @@ struct child_device_config {u8 dvo_function; u8 dp_usb_type_c:1; /* 195+ */ u8 tbt:1; /* 209+ */ - u8 flags2_reserved:2; /* 195+ */ + u8 dedicated_external:1; /* 264+ */ + u8 dyn_port_over_tc:1; /* 264+ */ u8 dp_port_trace_length:4; /* 209+ */u8 dp_gpio_index;/* 195+ */ u16 dp_gpio_pin_num;/* 195+ */ Signature · 2 lines
-- 2.51.0
Re: [PATCH v4 02/11] drm/i915/vbt: Add fields dedicated_external and dyn_port_over_tc
Quoting Imre Deak (2025-11-12 10:20:31-03:00)
Quoted 95 lines · Gustavo Sousa
Quoted 73 lines
Quoting Imre Deak (2025-11-11 13:15:41-03:00)
Quoted 64 lines · Imre Deak
Quoted 48 lines · Gustavo Sousa
Quoted 47 lines
VBT version 264 adds new fields associated to Xe3p_LPD's new ways of configuring SoC for TC ports and PHYs. Update the code to match the updates in VBT.
The new field
dedicated_externalis used to represent TC ports that are connected to PHYs outside of the Type-C subsystem, meaning that they behave like dedicated ports and don't require the extra Type-C programming. In an upcoming change, we will update the driver to take this field into consideration when detecting the type of port.The new field
dyn_port_over_tcis used to inform that the TC port can be dynamically allocated for a legacy connector in the Type-C subsystem, which is a new feature inXe3p_LPD. In upcoming changes, we will use that field in order to handle the IOM resource management programming required for that.Note that, when
dedicated_externalis set, the fieldsdp_usb_type_cand tbt are tagged as "don't care" in the spec, so they should be ignored in that case, so also add a sanitization function to take care of forcing them to zero whendedicated_externalis true.v2:
- Use sanitization function to forcedp_usb_type_cand tbt fields to be zero instead of adding aintel_bios_encoder_is_dedicated_external()check in each of their respective accessor functions. (Jani)
- Print info about dedicated external ports inprint_ddi_port().(Jani)Bspec: 20124, 68954, 74304
Cc Jani Nikula <[email protected]>Cc Shekhar Chauhan <[email protected]>Signed-off-by Gustavo Sousa <[email protected]>--- drivers/gpu/drm/i915/display/intel_bios.c | 54 ++++++++++++++++++++++++++- drivers/gpu/drm/i915/display/intel_bios.h | 2 + drivers/gpu/drm/i915/display/intel_vbt_defs.h | 3 +- 3 files changed, 56 insertions(+), 3 deletions(-)drivers/gpu/drm/i915/display/intel_bios.c +0
-0@@ -2530,6 +2530,36 @@ intel_bios_encoder_reject_edp_rate(const struct intel_bios_encoder_data *devdatareturn devdata->child.edp_data_rate_override &edp_rate_override_mask (rate); }Quoted 14 lines
Quoted 4 lines
drivers/gpu/drm/i915/display/intel_bios.c +4
-0+static void sanitize_dedicated_external (struct intel_bios_encoder_data *devdata, +enum port port) +{ +struct intel_display *display = devdata->display;drivers/gpu/drm/i915/display/intel_bios.c intel_bios_encoder_reject_edp_rate(const struct intel_bios_encoder_data *devdata · line 2546
Quoted 10 lines
drivers/gpu/drm/i915/display/intel_bios.c +10
-0+ +if (!intel_bios_encoder_is_dedicated_external (devdata)) +return ; + +/* +* Fields dp_usb_type_c and tbt must be ignored when +* dedicated_external is set. Since dedicated_external is for +* ports connected to PHYs outside of the Type-C subsystem, it +* is safe to force those fields to zero. +*/ Quoted 7 lines
Forgot this: IIUC
dyn_port_over_tcdoesn't make either sense for a dedicated external port. IOW, a dedicated port/PHY is not enabled by the TypeC sequences defined at bspec/68954 and so for such a port/PHY theDDI->PHYmapping is always 1:1 and so the corresponding DDI can't either be dynamically allocated to different PHYs. If that's a correct understanding,dyn_port_over_tcshould be also verified/zeroed out here imo.Quoted 8 lines
Yep, there shouldn't be any need for DDI allocation for dedicated external ports. However, we would only be checking for
dyn_port_over_tcwhen doing the Type-C flows, which would not happen for a dedicated external port. Give that, do you think we need to add the extra check here?The main reason we are adding those checks below is because the VBT spec marks those bits as "don't care" when
dedicated_externalis set.Right. To me, the interdependencies of these flags in VBT are a bit complex. We are reflecting now about the above dependency, which is good, since we'll at least agree then how these flags are supposed to work. Imo it should've been also documented more explicitly in Bspec, similarly to the DP-alt and TBT "don't care" documentation.
With all that, at least a code comment would be good about this for a future reader, but even the verify/zeroing would be useful imo, in case there is a VBT setting the flags contrary to our assumptions (that would remind us then to figure out if our or the VBT authors' assumptions were wrong).
Quoted 3 lines
It's a detail only, I'm not insisting on either of the above, so up to you (maybe you'd only update it in case you have to resend the patch anyway or stg).
I'll have a new version of this series and I added the logic to zero out dyn_port_over_tc as well. Thanks!
Quoted 38 lines
Quoted 38 lines
--
Gustavo SousaQuoted 34 lines
Quoted 34 lines
Quoted 34 lines
drivers/gpu/drm/i915/display/intel_bios.c +18
-1+ +if (devdata->child.dp_usb_type_c) { +drm_dbg_kms (display->drm, +"VBT claims Port %c supports USB Type-C, but the port is dedicated external, ignoring\n" , +port_name (port)); + devdata->child.dp_usb_type_c =0 ; + } + +if (devdata->child.tbt) { +drm_dbg_kms (display->drm, +"VBT claims Port %c supports TBT, but the port is dedicated external, ignoring\n" , +port_name (port)); + devdata->child.tbt =0 ; + } +} +static void sanitize_device_type (struct intel_bios_encoder_data *devdata,enum port port) {@@ -2668,7 +2698,8 @@ static void print_ddi_port(const struct intel_bios_encoder_data *devdata) {struct intel_display *display = devdata->display;const struct child_device_config *child = &devdata->child; -bool is_dvi, is_hdmi, is_dp, is_edp, is_dsi, is_crt, supports_typec_usb, supports_tbt; +bool is_dvi, is_hdmi, is_dp, is_edp, is_dsi, is_crt, supports_typec_usb, + supports_tbt, dedicated_external;int dp_boost_level, dp_max_link_rate, hdmi_boost_level, hdmi_level_shift, max_tmds_clock;enum port port;@@ -2694,6 +2725,12 @@ static void print_ddi_port(const struct intel_bios_encoder_data *devdata) supports_typec_usb, supports_tbt, devdata->dsc != NULL);
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
drivers/gpu/drm/i915/display/intel_bios.c static void print_ddi_port(const struct intel_bios_encoder_data *devdata) · line 2729
Quoted 2 lines
drivers/gpu/drm/i915/display/intel_bios.c +2
-0+ dedicated_external =intel_bios_encoder_is_dedicated_external (devdata); +if (dedicated_external)Nit: the variable could be dropped imo, and would be good to print the
dyn_port_over_tcinfo as well. Either way:
Incorporated this into local v5. Thanks!
--
Gustavo Sousa
Quoted 77 lines
Quoted 77 lines
Quoted 77 lines
Quoted 77 lines
Reviewed-by Imre Deak <[email protected]>Quoted 74 lines
drivers/gpu/drm/i915/display/intel_bios.c +18
-1+drm_dbg_kms (display->drm, +"Port %c is dedicated external\n" , +port_name (port)); + hdmi_level_shift =intel_bios_hdmi_level_shift (devdata);if (hdmi_level_shift >=0 ) { drm_dbg_kms(display->drm,@@ -2751,6 +2788,7 @@ static void parse_ddi_port(struct intel_bios_encoder_data *devdata)return ; } +sanitize_dedicated_external (devdata, port);sanitize_device_type (devdata, port);sanitize_hdmi_level_shift (devdata, port); }@@ -2778,7 +2816,7 @@ static int child_device_expected_size(u16 version) {BUILD_BUG_ON (sizeof (struct child_device_config ) <40 ); -if (version >263 ) +if (version >264 )return -ENOENT ;else if (version >=263 )return 44 ;@@ -3723,6 +3761,18 @@ bool intel_bios_encoder_supports_tbt(const struct intel_bios_encoder_data *devdareturn devdata->display->vbt.version >=209 && devdata->child.tbt; } +bool intel_bios_encoder_is_dedicated_external (const struct intel_bios_encoder_data *devdata) +{ +return devdata->display->vbt.version >=264 && + devdata->child.dedicated_external; +} + +bool intel_bios_encoder_supports_dyn_port_over_tc (const struct intel_bios_encoder_data *devdata) +{ +return devdata->display->vbt.version >=264 && + devdata->child.dyn_port_over_tc; +} +bool intel_bios_encoder_lane_reversal (const struct intel_bios_encoder_data *devdata) {return devdata && devdata->child.lane_reversal;drivers/gpu/drm/i915/display/intel_bios.h +2
-0@@ -79,6 +79,8 @@ bool intel_bios_encoder_supports_dp(const struct intel_bios_encoder_data *devdatbool intel_bios_encoder_supports_edp (const struct intel_bios_encoder_data *devdata);bool intel_bios_encoder_supports_typec_usb (const struct intel_bios_encoder_data *devdata);bool intel_bios_encoder_supports_tbt (const struct intel_bios_encoder_data *devdata); +bool intel_bios_encoder_is_dedicated_external (const struct intel_bios_encoder_data *devdata); +bool intel_bios_encoder_supports_dyn_port_over_tc (const struct intel_bios_encoder_data *devdata);bool intel_bios_encoder_supports_dsi (const struct intel_bios_encoder_data *devdata);bool intel_bios_encoder_supports_dp_dual_mode (const struct intel_bios_encoder_data *devdata);bool intel_bios_encoder_is_lspcon (const struct intel_bios_encoder_data *devdata);drivers/gpu/drm/i915/display/intel_vbt_defs.h +2
-1@@ -554,7 +554,8 @@ struct child_device_config {u8 dvo_function; u8 dp_usb_type_c:1; /* 195+ */ u8 tbt:1; /* 209+ */ - u8 flags2_reserved:2; /* 195+ */ + u8 dedicated_external:1; /* 264+ */ + u8 dyn_port_over_tc:1; /* 264+ */ u8 dp_port_trace_length:4; /* 209+ */u8 dp_gpio_index;/* 195+ */ u16 dp_gpio_pin_num;/* 195+ */ Signature · 2 lines
-- 2.51.0
PATCH v4 3/11 drm/i915/power: Use intel_encoder_is_tc()
In reply to Gustavo SousaStarting with Xe3p_LPD, when intel_phy_is_tc() returns true, it does not necessarily mean that the port is connected to a PHY in the Type-C subsystem. The reason is that there is now a VBT field called dedicated_external that will indicate that a Type-C capable port is connected to a (most likely) combo/dedicated PHY. When that's the case, we must not do the extra programming required for Type-C connections.
In an upcoming change, we will modify intel_encoder_is_tc() to take the VBT field dedicated_external into consideration. Update intel_display_power_well.c to use that function instead of intel_phy_is_tc().
Note that, even though icl_aux_power_well_{enable,disable} are not part of Xe3p_LPD's display paths, we modify them anyway for uniformity.
--- .../drm/i915/display/intel_display_power_well.c | 26 +++++++++++++++------- 1 file changed, 18 insertions(+), 8 deletions(-)
drivers/gpu/drm/i915/display/intel_display_power_well.c +18 -8
@@ -258,8 +258,9 @@ aux_ch_to_digital_port(struct intel_display *display,return NULL ; } -static enum phy icl_aux_pw_to_phy (struct intel_display *display, -const struct i915_power_well *power_well) +static struct intel_encoder * +icl_aux_pw_to_encoder (struct intel_display *display, +const struct i915_power_well *power_well) {enum aux_ch aux_ch =icl_aux_pw_to_ch (power_well);struct intel_digital_port *dig_port =aux_ch_to_digital_port (display, aux_ch);
@@ -271,7 +272,15 @@ static enum phy icl_aux_pw_to_phy(struct intel_display *display,* as HDMI-only and routed to a combo PHY, the encoder either won't be * present at all or it will not have an aux_ch assigned. */ -return dig_port ?intel_encoder_to_phy (&dig_port->base) :PHY_NONE ; +return dig_port ? &dig_port->base :NULL ; +} + +static enum phy icl_aux_pw_to_phy (struct intel_display *display, +const struct i915_power_well *power_well) +{ +struct intel_encoder *encoder =icl_aux_pw_to_encoder (display, power_well); + +return encoder ?intel_encoder_to_phy (encoder) :PHY_NONE ; } static void hsw_wait_for_power_well_enable(struct intel_display *display,
@@ -570,9 +579,9 @@ static void icl_aux_power_well_enable(struct intel_display *display, struct i915_power_well *power_well) { - enum phy phy = icl_aux_pw_to_phy(display, power_well); + struct intel_encoder *encoder = icl_aux_pw_to_encoder(display, power_well); -if (intel_phy_is_tc (display, phy)) +if (encoder &&intel_encoder_is_tc (encoder))return icl_tc_phy_aux_power_well_enable (display, power_well); else if (display->platform.icelake) return icl_combo_phy_aux_power_well_enable(display,
@@ -585,9 +594,9 @@ static void icl_aux_power_well_disable(struct intel_display *display, struct i915_power_well *power_well) { - enum phy phy = icl_aux_pw_to_phy(display, power_well); + struct intel_encoder *encoder = icl_aux_pw_to_encoder(display, power_well); -if (intel_phy_is_tc (display, phy)) +if (encoder &&intel_encoder_is_tc (encoder))return hsw_power_well_disable (display, power_well); else if (display->platform.icelake) return icl_combo_phy_aux_power_well_disable(display,
@@ -1849,10 +1858,11 @@ tgl_tc_cold_off_power_well_is_enabled(struct intel_display *display,static void xelpdp_aux_power_well_enable (struct intel_display *display,struct i915_power_well *power_well) { +struct intel_encoder *encoder =icl_aux_pw_to_encoder (display, power_well);enum aux_ch aux_ch =i915_power_well_instance (power_well)->xelpdp.aux_ch;enum phy phy =icl_aux_pw_to_phy (display, power_well); -if (intel_phy_is_tc (display, phy)) +if (encoder &&intel_encoder_is_tc (encoder))icl_tc_port_assert_ref_held (display, power_well,aux_ch_to_digital_port (display, aux_ch));
Signature · 1 line
2.51.0
Re: [PATCH v4 03/11] drm/i915/power: Use intel_encoder_is_tc()
Quoted 56 lines · Gustavo Sousa
Starting with
Xe3p_LPD, whenintel_phy_is_tc()returns true, it does not necessarily mean that the port is connected to a PHY in the Type-C subsystem. The reason is that there is now a VBT field calleddedicated_externalthat will indicate that a Type-C capable port is connected to a (most likely) combo/dedicated PHY. When that's the case, we must not do the extra programming required for Type-C connections.In an upcoming change, we will modify
intel_encoder_is_tc()to take the VBT fielddedicated_externalinto consideration. Updateintel_display_power_well.cto use that function instead ofintel_phy_is_tc().Note that, even though icl_aux_power_well_{enable,disable} are not part of Xe3p_LPD's display paths, we modify them anyway for uniformity.
Cc Shekhar Chauhan <[email protected]>Reviewed-by Suraj Kandpal <[email protected]>Signed-off-by Gustavo Sousa <[email protected]>--- .../drm/i915/display/intel_display_power_well.c | 26 +++++++++++++++------- 1 file changed, 18 insertions(+), 8 deletions(-)drivers/gpu/drm/i915/display/intel_display_power_well.c +12
-3@@ -258,8 +258,9 @@ aux_ch_to_digital_port(struct intel_display *display,return NULL ; } -static enum phy icl_aux_pw_to_phy (struct intel_display *display, -const struct i915_power_well *power_well) +static struct intel_encoder * +icl_aux_pw_to_encoder (struct intel_display *display, +const struct i915_power_well *power_well) {enum aux_ch aux_ch =icl_aux_pw_to_ch (power_well);struct intel_digital_port *dig_port =aux_ch_to_digital_port (display, aux_ch);@@ -271,7 +272,15 @@ static enum phy icl_aux_pw_to_phy(struct intel_display *display,* as HDMI-only and routed to a combo PHY, the encoder either won't be * present at all or it will not have an aux_ch assigned. */ -return dig_port ?intel_encoder_to_phy (&dig_port->base) :PHY_NONE ; +return dig_port ? &dig_port->base :NULL ; +} + +static enum phy icl_aux_pw_to_phy (struct intel_display *display, +const struct i915_power_well *power_well) +{ +struct intel_encoder *encoder =icl_aux_pw_to_encoder (display, power_well); + +return encoder ?intel_encoder_to_phy (encoder) :PHY_NONE ; } static void hsw_wait_for_power_well_enable(struct intel_display *display,
drivers/gpu/drm/i915/display/intel_display_power_well.c static void · line 584
Quoted 8 lines
drivers/gpu/drm/i915/display/intel_display_power_well.c +2
-2@@ -570,9 +579,9 @@ static void icl_aux_power_well_enable(struct intel_display *display, struct i915_power_well *power_well) { - enum phy phy = icl_aux_pw_to_phy(display, power_well); + struct intel_encoder *encoder = icl_aux_pw_to_encoder(display, power_well); -if (intel_phy_is_tc (display, phy)) +if (encoder &&intel_encoder_is_tc (encoder))
Adding an icl_aux_pw_is_tc_phy(display, power_well) helper would simplify things avoiding the need to retrieve the encoder.
Quoted 32 lines
drivers/gpu/drm/i915/display/intel_display_power_well.c +4
-3return icl_tc_phy_aux_power_well_enable (display, power_well); else if (display->platform.icelake) return icl_combo_phy_aux_power_well_enable(display,@@ -585,9 +594,9 @@ static void icl_aux_power_well_disable(struct intel_display *display, struct i915_power_well *power_well) { - enum phy phy = icl_aux_pw_to_phy(display, power_well); + struct intel_encoder *encoder = icl_aux_pw_to_encoder(display, power_well); -if (intel_phy_is_tc (display, phy)) +if (encoder &&intel_encoder_is_tc (encoder))return hsw_power_well_disable (display, power_well); else if (display->platform.icelake) return icl_combo_phy_aux_power_well_disable(display,@@ -1849,10 +1858,11 @@ tgl_tc_cold_off_power_well_is_enabled(struct intel_display *display,static void xelpdp_aux_power_well_enable (struct intel_display *display,struct i915_power_well *power_well) { +struct intel_encoder *encoder =icl_aux_pw_to_encoder (display, power_well);enum aux_ch aux_ch =i915_power_well_instance (power_well)->xelpdp.aux_ch;enum phy phy =icl_aux_pw_to_phy (display, power_well); -if (intel_phy_is_tc (display, phy)) +if (encoder &&intel_encoder_is_tc (encoder))icl_tc_port_assert_ref_held (display, power_well,aux_ch_to_digital_port (display, aux_ch));Signature · 2 lines
-- 2.51.0
Re: [PATCH v4 03/11] drm/i915/power: Use intel_encoder_is_tc()
Quoting Imre Deak (2025-11-12 13:19:07-03:00)
Quoted 63 lines · Gustavo Sousa
Quoted 62 lines
Starting with
Xe3p_LPD, whenintel_phy_is_tc()returns true, it does not necessarily mean that the port is connected to a PHY in the Type-C subsystem. The reason is that there is now a VBT field calleddedicated_externalthat will indicate that a Type-C capable port is connected to a (most likely) combo/dedicated PHY. When that's the case, we must not do the extra programming required for Type-C connections.In an upcoming change, we will modify
intel_encoder_is_tc()to take the VBT fielddedicated_externalinto consideration. Updateintel_display_power_well.cto use that function instead ofintel_phy_is_tc().Note that, even though icl_aux_power_well_{enable,disable} are not part of Xe3p_LPD's display paths, we modify them anyway for uniformity.
Cc Shekhar Chauhan <[email protected]>Reviewed-by Suraj Kandpal <[email protected]>Signed-off-by Gustavo Sousa <[email protected]>--- .../drm/i915/display/intel_display_power_well.c | 26 +++++++++++++++------- 1 file changed, 18 insertions(+), 8 deletions(-)drivers/gpu/drm/i915/display/intel_display_power_well.c +13
-4@@ -258,8 +258,9 @@ aux_ch_to_digital_port(struct intel_display *display,return NULL ; } -static enum phy icl_aux_pw_to_phy (struct intel_display *display, -const struct i915_power_well *power_well) +static struct intel_encoder * +icl_aux_pw_to_encoder (struct intel_display *display, +const struct i915_power_well *power_well) {enum aux_ch aux_ch =icl_aux_pw_to_ch (power_well);struct intel_digital_port *dig_port =aux_ch_to_digital_port (display, aux_ch);@@ -271,7 +272,15 @@ static enum phy icl_aux_pw_to_phy(struct intel_display *display,* as HDMI-only and routed to a combo PHY, the encoder either won't be * present at all or it will not have an aux_ch assigned. */ -return dig_port ?intel_encoder_to_phy (&dig_port->base) :PHY_NONE ; +return dig_port ? &dig_port->base :NULL ; +} + +static enum phy icl_aux_pw_to_phy (struct intel_display *display, +const struct i915_power_well *power_well) +{ +struct intel_encoder *encoder =icl_aux_pw_to_encoder (display, power_well); + +return encoder ?intel_encoder_to_phy (encoder) :PHY_NONE ; } static void hsw_wait_for_power_well_enable(struct intel_display *display,@@ -570,9 +579,9 @@ static void icl_aux_power_well_enable(struct intel_display *display, struct i915_power_well *power_well) { - enum phy phy = icl_aux_pw_to_phy(display, power_well); + struct intel_encoder *encoder = icl_aux_pw_to_encoder(display, power_well);
Quoted 5 lines
drivers/gpu/drm/i915/display/intel_display_power_well.c static void · line 584
Quoted 2 lines
drivers/gpu/drm/i915/display/intel_display_power_well.c +1
-1-if (intel_phy_is_tc (display, phy)) +if (encoder &&intel_encoder_is_tc (encoder))Adding an
icl_aux_pw_is_tc_phy(display, power_well)helper would simplify things avoiding the need to retrieve the encoder.
Ack.
--
Gustavo Sousa
Quoted 33 lines
Quoted 33 lines
drivers/gpu/drm/i915/display/intel_display_power_well.c +4
-3return icl_tc_phy_aux_power_well_enable (display, power_well); else if (display->platform.icelake) return icl_combo_phy_aux_power_well_enable(display,@@ -585,9 +594,9 @@ static void icl_aux_power_well_disable(struct intel_display *display, struct i915_power_well *power_well) { - enum phy phy = icl_aux_pw_to_phy(display, power_well); + struct intel_encoder *encoder = icl_aux_pw_to_encoder(display, power_well); -if (intel_phy_is_tc (display, phy)) +if (encoder &&intel_encoder_is_tc (encoder))return hsw_power_well_disable (display, power_well); else if (display->platform.icelake) return icl_combo_phy_aux_power_well_disable(display,@@ -1849,10 +1858,11 @@ tgl_tc_cold_off_power_well_is_enabled(struct intel_display *display,static void xelpdp_aux_power_well_enable (struct intel_display *display,struct i915_power_well *power_well) { +struct intel_encoder *encoder =icl_aux_pw_to_encoder (display, power_well);enum aux_ch aux_ch =i915_power_well_instance (power_well)->xelpdp.aux_ch;enum phy phy =icl_aux_pw_to_phy (display, power_well); -if (intel_phy_is_tc (display, phy)) +if (encoder &&intel_encoder_is_tc (encoder))icl_tc_port_assert_ref_held (display, power_well,aux_ch_to_digital_port (display, aux_ch));Signature · 2 lines
-- 2.51.0
PATCH v4 4/11 drm/i915/display: Handle dedicated external ports in intel_encoder_is_tc()
In reply to Gustavo SousaStarting with Xe3p_LPD, the VBT has a new field, called in the driver "dedicated_external", which tells that a Type-C capable port is physically connected to a PHY outside of the Type-C subsystem. When that's the case, the driver must not do the extra Type-C programming for that port. Update intel_encoder_is_tc() to check for that case.
While at it, add a note to intel_phy_is_tc() to remind us that it is about whether the respective port is a Type-C capable port rather than the PHY itself.
(Maybe it would be a nice idea to rename intel_phy_is_tc()?)
Note that this was handled with a new bool member added to struct intel_digital_port instead of having querying the VBT directly because VBT memory is freed (intel_bios_driver_remove) before encoder cleanup (intel_ddi_encoder_destroy), which would cause an oops to happen when the latter calls intel_encoder_is_tc(). This could be fixed by keeping VBT data around longer, but that's left for a follow-up work, if deemed necessary.
v2:
- Drop printing info about dedicated external, now that we are doing it when parsing the VBT. (Jani)
- Add a FIXME comment on the code explaining why we need to store dedicated_external in struct intel_digital_port. (Jani)
--- drivers/gpu/drm/i915/display/intel_ddi.c | 11 +++++++++++ drivers/gpu/drm/i915/display/intel_display.c | 19 ++++++++++++++++++- drivers/gpu/drm/i915/display/intel_display_types.h | 1 + 3 files changed, 30 insertions(+), 1 deletion(-)
drivers/gpu/drm/i915/display/intel_ddi.c +11 -0
@@ -5376,6 +5376,17 @@ void intel_ddi_init(struct intel_display *display, goto err; } +/* +* FIXME: We currently need to store dedicated_external because devdata +* does not live long enough for when intel_encoder_is_tc() is called on +* the unbind path. This needs to be fixed by making sure that the VBT +* data is kept long enough, so that +* intel_bios_encoder_is_dedicated_external() can be called directly +* from intel_encoder_is_tc(). +*/ +if (intel_bios_encoder_is_dedicated_external (devdata)) + dig_port->dedicated_external = true; +if (intel_encoder_is_tc (encoder)) {bool is_legacy = !intel_bios_encoder_supports_typec_usb(devdata) &&
drivers/gpu/drm/i915/display/intel_display.c +18 -1
@@ -1800,7 +1800,17 @@ bool intel_phy_is_combo(struct intel_display *display, enum phy phy)return false; } -/* Prefer intel_encoder_is_tc() */ +/* +* This function returns true if the DDI port respective to the PHY enumeration +* is a Type-C capable port. +* +* Depending on the VBT, the port might be configured +* as a "dedicated external" port, meaning that actual physical PHY is outside +* of the Type-C subsystem and, as such, not really a "Type-C PHY". +* +* Prefer intel_encoder_is_tc(), especially if you really need to know if we +* are dealing with Type-C connections. +*/ bool intel_phy_is_tc (struct intel_display *display,enum phy phy) {/*
@@ -1885,6 +1895,13 @@ bool intel_encoder_is_tc(struct intel_encoder *encoder) {struct intel_display *display =to_intel_display (encoder); +if (intel_encoder_is_dig_port (encoder)) { +struct intel_digital_port *dig_port =enc_to_dig_port (encoder); + +if (dig_port->dedicated_external) +return false; + } +return intel_phy_is_tc (display,intel_encoder_to_phy (encoder)); }
drivers/gpu/drm/i915/display/intel_display_types.h +1 -0
@@ -1937,6 +1937,7 @@ struct intel_digital_port {bool lane_reversal;bool ddi_a_4_lanes;bool release_cl2_override; +bool dedicated_external;u8 max_lanes;/* Used for DP and ICL+ TypeC/DP and TypeC/HDMI ports. */ enum aux_ch aux_ch;
Signature · 1 line
2.51.0
Re: [PATCH v4 04/11] drm/i915/display: Handle dedicated external ports in intel_encoder_is_tc()
Quoted 81 lines · Gustavo Sousa
Starting with
Xe3p_LPD, the VBT has a new field, called in the driver "dedicated_external", which tells that a Type-C capable port is physically connected to a PHY outside of the Type-C subsystem. When that's the case, the driver must not do the extra Type-C programming for that port. Updateintel_encoder_is_tc()to check for that case.While at it, add a note to
intel_phy_is_tc()to remind us that it is about whether the respective port is a Type-C capable port rather than the PHY itself.(Maybe it would be a nice idea to rename
intel_phy_is_tc()?)Note that this was handled with a new bool member added to struct
intel_digital_portinstead of having querying the VBT directly because VBT memory is freed (intel_bios_driver_remove) before encoder cleanup (intel_ddi_encoder_destroy), which would cause an oops to happen when the latter callsintel_encoder_is_tc(). This could be fixed by keeping VBT data around longer, but that's left for a follow-up work, if deemed necessary.v2:
- Drop printing info about dedicated external, now that we are doing it when parsing the VBT. (Jani)
- Add a FIXME comment on the code explaining why we need to storededicated_externalin structintel_digital_port. (Jani)Cc Jani Nikula <[email protected]>Cc Shekhar Chauhan <[email protected]>Signed-off-by Gustavo Sousa <[email protected]>--- drivers/gpu/drm/i915/display/intel_ddi.c | 11 +++++++++++ drivers/gpu/drm/i915/display/intel_display.c | 19 ++++++++++++++++++- drivers/gpu/drm/i915/display/intel_display_types.h | 1 + 3 files changed, 30 insertions(+), 1 deletion(-)drivers/gpu/drm/i915/display/intel_ddi.c +11
-0@@ -5376,6 +5376,17 @@ void intel_ddi_init(struct intel_display *display, goto err; } +/* +* FIXME: We currently need to store dedicated_external because devdata +* does not live long enough for when intel_encoder_is_tc() is called on +* the unbind path. This needs to be fixed by making sure that the VBT +* data is kept long enough, so that +* intel_bios_encoder_is_dedicated_external() can be called directly +* from intel_encoder_is_tc(). +*/ +if (intel_bios_encoder_is_dedicated_external (devdata)) + dig_port->dedicated_external = true; +if (intel_encoder_is_tc (encoder)) {bool is_legacy = !intel_bios_encoder_supports_typec_usb(devdata) &&drivers/gpu/drm/i915/display/intel_display.c +11
-1@@ -1800,7 +1800,17 @@ bool intel_phy_is_combo(struct intel_display *display, enum phy phy)return false; } -/* Prefer intel_encoder_is_tc() */ +/* +* This function returns true if the DDI port respective to the PHY enumeration +* is a Type-C capable port. +* +* Depending on the VBT, the port might be configured +* as a "dedicated external" port, meaning that actual physical PHY is outside +* of the Type-C subsystem and, as such, not really a "Type-C PHY". +* +* Prefer intel_encoder_is_tc(), especially if you really need to know if we +* are dealing with Type-C connections. +*/ bool intel_phy_is_tc (struct intel_display *display,enum phy phy) {/*
drivers/gpu/drm/i915/display/intel_display.c bool intel_encoder_is_tc(struct intel_encoder *encoder) · line 1899
Quoted 5 lines
drivers/gpu/drm/i915/display/intel_display.c +2
-0@@ -1885,6 +1895,13 @@ bool intel_encoder_is_tc(struct intel_encoder *encoder) {struct intel_display *display =to_intel_display (encoder); +if (intel_encoder_is_dig_port (encoder)) { +struct intel_digital_port *dig_port =enc_to_dig_port (encoder);
Just dig_port = enc_to_dig_port(encoder); ... if (dig_port && dig_port->dedicated_external) would be simpler and would be also more consistent wrt. MST encoders.
Quoted 24 lines
drivers/gpu/drm/i915/display/intel_display.c +5
-0+ +if (dig_port->dedicated_external) +return false; + } +return intel_phy_is_tc (display,intel_encoder_to_phy (encoder)); }drivers/gpu/drm/i915/display/intel_display_types.h +1
-0@@ -1937,6 +1937,7 @@ struct intel_digital_port {bool lane_reversal;bool ddi_a_4_lanes;bool release_cl2_override; +bool dedicated_external;u8 max_lanes;/* Used for DP and ICL+ TypeC/DP and TypeC/HDMI ports. */ enum aux_ch aux_ch;Signature · 2 lines
-- 2.51.0
Re: [PATCH v4 04/11] drm/i915/display: Handle dedicated external ports in intel_encoder_is_tc()
Quoting Imre Deak (2025-11-12 13:24:30-03:00)
Quoted 85 lines · Gustavo Sousa
Quoted 84 lines
Starting with
Xe3p_LPD, the VBT has a new field, called in the driver "dedicated_external", which tells that a Type-C capable port is physically connected to a PHY outside of the Type-C subsystem. When that's the case, the driver must not do the extra Type-C programming for that port. Updateintel_encoder_is_tc()to check for that case.While at it, add a note to
intel_phy_is_tc()to remind us that it is about whether the respective port is a Type-C capable port rather than the PHY itself.(Maybe it would be a nice idea to rename
intel_phy_is_tc()?)Note that this was handled with a new bool member added to struct
intel_digital_portinstead of having querying the VBT directly because VBT memory is freed (intel_bios_driver_remove) before encoder cleanup (intel_ddi_encoder_destroy), which would cause an oops to happen when the latter callsintel_encoder_is_tc(). This could be fixed by keeping VBT data around longer, but that's left for a follow-up work, if deemed necessary.v2:
- Drop printing info about dedicated external, now that we are doing it when parsing the VBT. (Jani)
- Add a FIXME comment on the code explaining why we need to storededicated_externalin structintel_digital_port. (Jani)Cc Jani Nikula <[email protected]>Cc Shekhar Chauhan <[email protected]>Signed-off-by Gustavo Sousa <[email protected]>--- drivers/gpu/drm/i915/display/intel_ddi.c | 11 +++++++++++ drivers/gpu/drm/i915/display/intel_display.c | 19 ++++++++++++++++++- drivers/gpu/drm/i915/display/intel_display_types.h | 1 + 3 files changed, 30 insertions(+), 1 deletion(-)drivers/gpu/drm/i915/display/intel_ddi.c +11
-0@@ -5376,6 +5376,17 @@ void intel_ddi_init(struct intel_display *display, goto err; } +/* +* FIXME: We currently need to store dedicated_external because devdata +* does not live long enough for when intel_encoder_is_tc() is called on +* the unbind path. This needs to be fixed by making sure that the VBT +* data is kept long enough, so that +* intel_bios_encoder_is_dedicated_external() can be called directly +* from intel_encoder_is_tc(). +*/ +if (intel_bios_encoder_is_dedicated_external (devdata)) + dig_port->dedicated_external = true; +if (intel_encoder_is_tc (encoder)) {bool is_legacy = !intel_bios_encoder_supports_typec_usb(devdata) &&drivers/gpu/drm/i915/display/intel_display.c +11
-1@@ -1800,7 +1800,17 @@ bool intel_phy_is_combo(struct intel_display *display, enum phy phy)return false; } -/* Prefer intel_encoder_is_tc() */ +/* +* This function returns true if the DDI port respective to the PHY enumeration +* is a Type-C capable port. +* +* Depending on the VBT, the port might be configured +* as a "dedicated external" port, meaning that actual physical PHY is outside +* of the Type-C subsystem and, as such, not really a "Type-C PHY". +* +* Prefer intel_encoder_is_tc(), especially if you really need to know if we +* are dealing with Type-C connections. +*/ bool intel_phy_is_tc (struct intel_display *display,enum phy phy) {/* @@ -1885,6 +1895,13 @@ bool intel_encoder_is_tc(struct intel_encoder *encoder) {struct intel_display *display =to_intel_display (encoder);
Quoted 6 lines
drivers/gpu/drm/i915/display/intel_display.c bool intel_encoder_is_tc(struct intel_encoder *encoder) · line 1899
Quoted 2 lines
drivers/gpu/drm/i915/display/intel_display.c +2
-0+if (intel_encoder_is_dig_port (encoder)) { +struct intel_digital_port *dig_port =enc_to_dig_port (encoder);Just
dig_port=enc_to_dig_port(encoder); ... if (dig_port&&dig_port->dedicated_external) would be simpler and would be also more consistent wrt. MST encoders.
Ack.
Thanks!
--
Gustavo Sousa
Quoted 25 lines
Quoted 25 lines
drivers/gpu/drm/i915/display/intel_display.c +5
-0+ +if (dig_port->dedicated_external) +return false; + } +return intel_phy_is_tc (display,intel_encoder_to_phy (encoder)); }drivers/gpu/drm/i915/display/intel_display_types.h +1
-0@@ -1937,6 +1937,7 @@ struct intel_digital_port {bool lane_reversal;bool ddi_a_4_lanes;bool release_cl2_override; +bool dedicated_external;u8 max_lanes;/* Used for DP and ICL+ TypeC/DP and TypeC/HDMI ports. */ enum aux_ch aux_ch;Signature · 2 lines
-- 2.51.0
PATCH v4 5/11 drm/i915/fbc: Add intel_fbc_id_for_pipe()
In reply to Gustavo SousaWe will need to know the FBC id respective to the pipe in other parts of the driver. Let's promote the static function skl_fbc_id_for_pipe() to a public one named intel_fbc_id_for_pipe().
--- drivers/gpu/drm/i915/display/intel_fbc.c | 5 +++++ drivers/gpu/drm/i915/display/intel_fbc.h | 2 ++ drivers/gpu/drm/i915/display/skl_universal_plane.c | 9 ++------- 3 files changed, 9 insertions(+), 7 deletions(-)
drivers/gpu/drm/i915/display/intel_fbc.c +5 -0
@@ -129,6 +129,11 @@ struct intel_fbc {const char *no_fbc_reason; }; +enum intel_fbc_id intel_fbc_id_for_pipe (enum pipe pipe) +{ +return pipe -PIPE_A +INTEL_FBC_A ; +} +/* plane stride in pixels */ static unsigned int intel_fbc_plane_stride (const struct intel_plane_state *plane_state) {
drivers/gpu/drm/i915/display/intel_fbc.h +2 -0
@@ -9,6 +9,7 @@#include <linux/types.h> enum fb_op_origin ; +enum pipe ;struct intel_atomic_state ;struct intel_crtc ;struct intel_crtc_state ;
@@ -27,6 +28,7 @@ enum intel_fbc_id { I915_MAX_FBCS, }; +enum intel_fbc_id intel_fbc_id_for_pipe (enum pipe pipe);int intel_fbc_atomic_check (struct intel_atomic_state *state);int intel_fbc_min_cdclk (const struct intel_crtc_state *crtc_state); bool intel_fbc_pre_update(struct intel_atomic_state *state,
drivers/gpu/drm/i915/display/skl_universal_plane.c +2 -7
@@ -439,11 +439,6 @@ static int skl_plane_max_height(const struct drm_framebuffer *fb,return 4096 ; } -static enum intel_fbc_id skl_fbc_id_for_pipe (enum pipe pipe) -{ -return pipe -PIPE_A +INTEL_FBC_A ; -} -static bool skl_plane_has_fbc (struct intel_display *display,enum intel_fbc_id fbc_id,enum plane_id plane_id) {
@@ -896,7 +891,7 @@ static void x3p_lpd_plane_update_pixel_normalizer(struct intel_dsb *dsb, bool enable) {struct intel_display *display =to_intel_display (plane); -enum intel_fbc_id fbc_id =skl_fbc_id_for_pipe (plane->pipe); +enum intel_fbc_id fbc_id =intel_fbc_id_for_pipe (plane->pipe);u32 val;/* Only HDR planes have pixel normalizer and don't matter if no FBC */
@@ -2442,7 +2437,7 @@ void icl_link_nv12_planes(struct intel_plane_state *uv_plane_state,static struct intel_fbc *skl_plane_fbc (struct intel_display *display,enum pipe pipe,enum plane_id plane_id) { -enum intel_fbc_id fbc_id =skl_fbc_id_for_pipe (pipe); +enum intel_fbc_id fbc_id =intel_fbc_id_for_pipe (pipe);if (skl_plane_has_fbc (display, fbc_id, plane_id))return display->fbc[fbc_id];
Signature · 1 line
2.51.0
Re: [PATCH v4 05/11] drm/i915/fbc: Add intel_fbc_id_for_pipe()
Quoted 16 lines · Gustavo Sousa
We will need to know the FBC id respective to the pipe in other parts of the driver. Let's promote the static function
skl_fbc_id_for_pipe()to a public one namedintel_fbc_id_for_pipe().Signed-off-by Gustavo Sousa <[email protected]>--- drivers/gpu/drm/i915/display/intel_fbc.c | 5 +++++ drivers/gpu/drm/i915/display/intel_fbc.h | 2 ++ drivers/gpu/drm/i915/display/skl_universal_plane.c | 9 ++------- 3 files changed, 9 insertions(+), 7 deletions(-)drivers/gpu/drm/i915/display/intel_fbc.c +0
-0
drivers/gpu/drm/i915/display/intel_fbc.c struct intel_fbc { · line 134
Quoted 6 lines
drivers/gpu/drm/i915/display/intel_fbc.c +3
-0@@ -129,6 +129,11 @@ struct intel_fbc {const char *no_fbc_reason; }; +enum intel_fbc_id intel_fbc_id_for_pipe (enum pipe pipe) +{ +return pipe -PIPE_A +INTEL_FBC_A ;
The existing usage of skl_fbc_id_for_pipe() was to call this function to receive a (possibly bogus) FBC ID, and then follow up with a call to skl_plane_has_fbc() which had checks to make sure the returned FBC ID actually existed on the platform. So, for example, calling skl_fbc_id_for_pipe(PIPE_B) on something like an ICL would return INTEL_FBC_B here, but then the subsequent call to skl_plane_has_fbc() would realize that there is no FBC_B on that platform and bail out. It's only relatively recently (MTL and beyond I think?) that FBC has become usable on pipes other than A.
Now that we're promoting this function to be more general, should we also adjust the logic so that this function either returns a *valid* FBC ID or and error? Otherwise it may not be apparent to people writing new code that the result returned here can't be immediately trusted without additional checking.
Matt
Quoted 63 lines
drivers/gpu/drm/i915/display/intel_fbc.c +2
-0+} +/* plane stride in pixels */ static unsigned int intel_fbc_plane_stride (const struct intel_plane_state *plane_state) {drivers/gpu/drm/i915/display/intel_fbc.h +2
-0@@ -9,6 +9,7 @@#include <linux/types.h> enum fb_op_origin ; +enum pipe ;struct intel_atomic_state ;struct intel_crtc ;struct intel_crtc_state ;@@ -27,6 +28,7 @@ enum intel_fbc_id { I915_MAX_FBCS, }; +enum intel_fbc_id intel_fbc_id_for_pipe (enum pipe pipe);int intel_fbc_atomic_check (struct intel_atomic_state *state);int intel_fbc_min_cdclk (const struct intel_crtc_state *crtc_state); bool intel_fbc_pre_update(struct intel_atomic_state *state,drivers/gpu/drm/i915/display/skl_universal_plane.c +2
-7@@ -439,11 +439,6 @@ static int skl_plane_max_height(const struct drm_framebuffer *fb,return 4096 ; } -static enum intel_fbc_id skl_fbc_id_for_pipe (enum pipe pipe) -{ -return pipe -PIPE_A +INTEL_FBC_A ; -} -static bool skl_plane_has_fbc (struct intel_display *display,enum intel_fbc_id fbc_id,enum plane_id plane_id) {@@ -896,7 +891,7 @@ static void x3p_lpd_plane_update_pixel_normalizer(struct intel_dsb *dsb, bool enable) {struct intel_display *display =to_intel_display (plane); -enum intel_fbc_id fbc_id =skl_fbc_id_for_pipe (plane->pipe); +enum intel_fbc_id fbc_id =intel_fbc_id_for_pipe (plane->pipe);u32 val;/* Only HDR planes have pixel normalizer and don't matter if no FBC */ @@ -2442,7 +2437,7 @@ void icl_link_nv12_planes(struct intel_plane_state *uv_plane_state,static struct intel_fbc *skl_plane_fbc (struct intel_display *display,enum pipe pipe,enum plane_id plane_id) { -enum intel_fbc_id fbc_id =skl_fbc_id_for_pipe (pipe); +enum intel_fbc_id fbc_id =intel_fbc_id_for_pipe (pipe);if (skl_plane_has_fbc (display, fbc_id, plane_id))return display->fbc[fbc_id];Signature · 2 lines
-- 2.51.0
Signature · 4 lines
Matt Roper Graphics Software Engineer Linux GPU Platform Enablement Intel Corporation
Re: [PATCH v4 05/11] drm/i915/fbc: Add intel_fbc_id_for_pipe()
Quoted 34 lines · Matt Roper
Quoted 16 lines · Gustavo Sousa
We will need to know the FBC id respective to the pipe in other parts of the driver. Let's promote the static function
skl_fbc_id_for_pipe()to a public one namedintel_fbc_id_for_pipe().Signed-off-by Gustavo Sousa <[email protected]>--- drivers/gpu/drm/i915/display/intel_fbc.c | 5 +++++ drivers/gpu/drm/i915/display/intel_fbc.h | 2 ++ drivers/gpu/drm/i915/display/skl_universal_plane.c | 9 ++------- 3 files changed, 9 insertions(+), 7 deletions(-)drivers/gpu/drm/i915/display/intel_fbc.c +0
-0drivers/gpu/drm/i915/display/intel_fbc.c struct intel_fbc { · line 134
Quoted 6 lines
drivers/gpu/drm/i915/display/intel_fbc.c +3
-0@@ -129,6 +129,11 @@ struct intel_fbc {const char *no_fbc_reason; }; +enum intel_fbc_id intel_fbc_id_for_pipe (enum pipe pipe) +{ +return pipe -PIPE_A +INTEL_FBC_A ;The existing usage of
skl_fbc_id_for_pipe()was to call this function to receive a (possibly bogus) FBC ID, and then follow up with a call toskl_plane_has_fbc()which had checks to make sure the returned FBC ID actually existed on the platform. So, for example, callingskl_fbc_id_for_pipe(PIPE_B)on something like an ICL would returnINTEL_FBC_Bhere, but then the subsequent call toskl_plane_has_fbc()would realize that there is noFBC_Bon that platform and bail out. It's only relatively recently (MTL and beyond I think?) that FBC has become usable on pipes other than A.
Quoted 5 lines
Now that we're promoting this function to be more general, should we also adjust the logic so that this function either returns a *valid* FBC ID or and error? Otherwise it may not be apparent to people writing new code that the result returned here can't be immediately trusted without additional checking.
The simples way to find the FBC instance for a pipe is to grab it from the primary plane. That is already used elsewhere so won't make things any less generic.
Quoted 73 lines
Matt
Quoted 63 lines
drivers/gpu/drm/i915/display/intel_fbc.c +2
-0+} +/* plane stride in pixels */ static unsigned int intel_fbc_plane_stride (const struct intel_plane_state *plane_state) {drivers/gpu/drm/i915/display/intel_fbc.h +2
-0@@ -9,6 +9,7 @@#include <linux/types.h> enum fb_op_origin ; +enum pipe ;struct intel_atomic_state ;struct intel_crtc ;struct intel_crtc_state ;@@ -27,6 +28,7 @@ enum intel_fbc_id { I915_MAX_FBCS, }; +enum intel_fbc_id intel_fbc_id_for_pipe (enum pipe pipe);int intel_fbc_atomic_check (struct intel_atomic_state *state);int intel_fbc_min_cdclk (const struct intel_crtc_state *crtc_state); bool intel_fbc_pre_update(struct intel_atomic_state *state,drivers/gpu/drm/i915/display/skl_universal_plane.c +2
-7@@ -439,11 +439,6 @@ static int skl_plane_max_height(const struct drm_framebuffer *fb,return 4096 ; } -static enum intel_fbc_id skl_fbc_id_for_pipe (enum pipe pipe) -{ -return pipe -PIPE_A +INTEL_FBC_A ; -} -static bool skl_plane_has_fbc (struct intel_display *display,enum intel_fbc_id fbc_id,enum plane_id plane_id) {@@ -896,7 +891,7 @@ static void x3p_lpd_plane_update_pixel_normalizer(struct intel_dsb *dsb, bool enable) {struct intel_display *display =to_intel_display (plane); -enum intel_fbc_id fbc_id =skl_fbc_id_for_pipe (plane->pipe); +enum intel_fbc_id fbc_id =intel_fbc_id_for_pipe (plane->pipe);u32 val;/* Only HDR planes have pixel normalizer and don't matter if no FBC */ @@ -2442,7 +2437,7 @@ void icl_link_nv12_planes(struct intel_plane_state *uv_plane_state,static struct intel_fbc *skl_plane_fbc (struct intel_display *display,enum pipe pipe,enum plane_id plane_id) { -enum intel_fbc_id fbc_id =skl_fbc_id_for_pipe (pipe); +enum intel_fbc_id fbc_id =intel_fbc_id_for_pipe (pipe);if (skl_plane_has_fbc (display, fbc_id, plane_id))return display->fbc[fbc_id];Signature · 2 lines
-- 2.51.0Signature · 4 lines
Matt Roper Graphics Software Engineer Linux GPU Platform Enablement Intel Corporation
Signature · 2 lines
Ville Syrjälä Intel
Re: [PATCH v4 05/11] drm/i915/fbc: Add intel_fbc_id_for_pipe()
Quoting Ville Syrjälä (2025-11-10 14:03:03-03:00)
Quoted 41 lines · Matt Roper
Quoted 34 lines · Gustavo Sousa
Quoted 16 lines
We will need to know the FBC id respective to the pipe in other parts of the driver. Let's promote the static function
skl_fbc_id_for_pipe()to a public one namedintel_fbc_id_for_pipe().Signed-off-by Gustavo Sousa <[email protected]>--- drivers/gpu/drm/i915/display/intel_fbc.c | 5 +++++ drivers/gpu/drm/i915/display/intel_fbc.h | 2 ++ drivers/gpu/drm/i915/display/skl_universal_plane.c | 9 ++------- 3 files changed, 9 insertions(+), 7 deletions(-)drivers/gpu/drm/i915/display/intel_fbc.c +0
-0drivers/gpu/drm/i915/display/intel_fbc.c struct intel_fbc { · line 134
Quoted 6 lines
drivers/gpu/drm/i915/display/intel_fbc.c +3
-0@@ -129,6 +129,11 @@ struct intel_fbc {const char *no_fbc_reason; }; +enum intel_fbc_id intel_fbc_id_for_pipe (enum pipe pipe) +{ +return pipe -PIPE_A +INTEL_FBC_A ;The existing usage of
skl_fbc_id_for_pipe()was to call this function to receive a (possibly bogus) FBC ID, and then follow up with a call toskl_plane_has_fbc()which had checks to make sure the returned FBC ID actually existed on the platform. So, for example, callingskl_fbc_id_for_pipe(PIPE_B)on something like an ICL would returnINTEL_FBC_Bhere, but then the subsequent call toskl_plane_has_fbc()would realize that there is noFBC_Bon that platform and bail out. It's only relatively recently (MTL and beyond I think?) that FBC has become usable on pipes other than A.Quoted 5 lines
Now that we're promoting this function to be more general, should we also adjust the logic so that this function either returns a *valid* FBC ID or and error? Otherwise it may not be apparent to people writing new code that the result returned here can't be immediately trusted without additional checking.
Quoted 3 lines
The simples way to find the FBC instance for a pipe is to grab it from the primary plane. That is already used elsewhere so won't make things any less generic.
And do that internally without a public function, right? Because the feedback in the next patch is that the part that handles the "FBC decompressing" bit should be in intel_fbc.c.
How should the primary plane be found? Loop with for_each_intel_plane_on_crtc() and get the one with type DRM_PLANE_TYPE_PRIMARY? For example:
static struct intel_fbc *intel_fbc_for_pipe(struct intel_display *display, enum pipe pipe)
{
struct intel_crtc *crtc = intel_crtc_for_pipe(display, pipe);
struct intel_plane *primary = NULL;
struct intel_plane *plane;
for_each_intel_plane_on_crtc(display->drm, crtc, plane) {
if (plane->base.type == DRM_PLANE_TYPE_PRIMARY) {
primary = plane;
break;
}
}
if (drm_WARN_ON(display->drm, primary == NULL))
return NULL;
return primary->fbc;
}I saw that the DRM layer keeps a "primary" plane in struct drm_crtc, but, reading the kerneldoc for that member, I get the feeling that we should not use it.
--
Gustavo Sousa
Quoted 78 lines
Quoted 74 lines
Matt
Quoted 63 lines
drivers/gpu/drm/i915/display/intel_fbc.c +2
-0+} +/* plane stride in pixels */ static unsigned int intel_fbc_plane_stride (const struct intel_plane_state *plane_state) {drivers/gpu/drm/i915/display/intel_fbc.h +2
-0@@ -9,6 +9,7 @@#include <linux/types.h> enum fb_op_origin ; +enum pipe ;struct intel_atomic_state ;struct intel_crtc ;struct intel_crtc_state ;@@ -27,6 +28,7 @@ enum intel_fbc_id { I915_MAX_FBCS, }; +enum intel_fbc_id intel_fbc_id_for_pipe (enum pipe pipe);int intel_fbc_atomic_check (struct intel_atomic_state *state);int intel_fbc_min_cdclk (const struct intel_crtc_state *crtc_state); bool intel_fbc_pre_update(struct intel_atomic_state *state,drivers/gpu/drm/i915/display/skl_universal_plane.c +2
-7@@ -439,11 +439,6 @@ static int skl_plane_max_height(const struct drm_framebuffer *fb,return 4096 ; } -static enum intel_fbc_id skl_fbc_id_for_pipe (enum pipe pipe) -{ -return pipe -PIPE_A +INTEL_FBC_A ; -} -static bool skl_plane_has_fbc (struct intel_display *display,enum intel_fbc_id fbc_id,enum plane_id plane_id) {@@ -896,7 +891,7 @@ static void x3p_lpd_plane_update_pixel_normalizer(struct intel_dsb *dsb, bool enable) {struct intel_display *display =to_intel_display (plane); -enum intel_fbc_id fbc_id =skl_fbc_id_for_pipe (plane->pipe); +enum intel_fbc_id fbc_id =intel_fbc_id_for_pipe (plane->pipe);u32 val;/* Only HDR planes have pixel normalizer and don't matter if no FBC */ @@ -2442,7 +2437,7 @@ void icl_link_nv12_planes(struct intel_plane_state *uv_plane_state,static struct intel_fbc *skl_plane_fbc (struct intel_display *display,enum pipe pipe,enum plane_id plane_id) { -enum intel_fbc_id fbc_id =skl_fbc_id_for_pipe (pipe); +enum intel_fbc_id fbc_id =intel_fbc_id_for_pipe (pipe);if (skl_plane_has_fbc (display, fbc_id, plane_id))return display->fbc[fbc_id];Signature · 2 lines
-- 2.51.0Signature · 4 lines
Matt Roper Graphics Software Engineer Linux GPU Platform Enablement Intel CorporationSignature · 2 lines
Ville Syrjälä Intel
PATCH v4 6/11 drm/i915/xe3p_lpd: Handle underrun debug bits
In reply to Gustavo SousaXe3p_LPD added several bits containing information that can be relevant to debugging FIFO underruns. Add the logic necessary to handle them when reporting underruns.
This was adapted from the initial patch[1] from Sai Teja Pottumuttu.
[1] https://lore.kernel.org/all/[email protected]/
Bspec: 69111, 69561, 74411, 74412
---
I tested this by adding a change on top of this series that updates Xe3p_LPD's CDCLK table to use bad values and I got the following messages:
[ +0.000237] xe 0000:00:02.0: [drm:intel_modeset_verify_crtc [xe]] [CRTC:88:pipe A]
[ +0.000674] xe 0000:00:02.0: [drm] *ERROR* CPU pipe A FIFO underrun
[ +0.000015] xe 0000:00:02.0: [drm] *ERROR* Pipe A FIFO underrun info: DBUF block not valid on planes: [1]
[ +0.000001] xe 0000:00:02.0: [drm] *ERROR* Pipe A FIFO underrun info: DDB empty on planes: [1]
[ +0.000001] xe 0000:00:02.0: [drm] *ERROR* Pipe A FIFO underrun info: DBUF below WM0 on planes: [1]
[ +0.000004] xe 0000:00:02.0: [drm] *ERROR* Pipe A FIFO underrun info: frame count: 1890, line count: 44
---
.../gpu/drm/i915/display/intel_display_device.h | 1 +
drivers/gpu/drm/i915/display/intel_display_regs.h | 16 +++
drivers/gpu/drm/i915/display/intel_fbc_regs.h | 2 +
drivers/gpu/drm/i915/display/intel_fifo_underrun.c | 128 +++++++++++++++++++++
4 files changed, 147 insertions(+)drivers/gpu/drm/i915/display/intel_display_device.h +1 -0
@@ -197,6 +197,7 @@ struct intel_display_platforms {#define HAS_TRANSCODER (__display, trans) ((DISPLAY_RUNTIME_INFO(__display)->cpu_transcoder_mask & \ BIT(trans)) != 0)#define HAS_UNCOMPRESSED_JOINER (__display) (DISPLAY_VER(__display) >= 13) +#define HAS_UNDERRUN_DBG_INFO (__display) (DISPLAY_VER(__display) >= 35)#define HAS_ULTRAJOINER (__display) (((__display)->platform.dgfx && \ DISPLAY_VER(__display) == 14) && HAS_DSC(__display))#define HAS_VRR (__display) (DISPLAY_VER(__display) >= 11)
drivers/gpu/drm/i915/display/intel_display_regs.h +16 -0
@@ -882,6 +882,21 @@#define PIPE_MISC2_FLIP_INFO_PLANE_SEL_MASK REG_GENMASK(2, 0)/* tgl+ */ #define PIPE_MISC2_FLIP_INFO_PLANE_SEL (plane_id) REG_FIELD_PREP(PIPE_MISC2_FLIP_INFO_PLANE_SEL_MASK, (plane_id)) +#define _UNDERRUN_DBG1_A 0x70064 +#define _UNDERRUN_DBG1_B 0x71064 +#define UNDERRUN_DBG1 (pipe) _MMIO_PIPE(pipe, _UNDERRUN_DBG1_A, _UNDERRUN_DBG1_B) +#define UNDERRUN_DBUF_BLOCK_NOT_VALID_MASK REG_GENMASK(29, 24) +#define UNDERRUN_DDB_EMPTY_MASK REG_GENMASK(21, 16) +#define UNDERRUN_DBUF_NOT_FILLED_MASK REG_GENMASK(13, 8) +#define UNDERRUN_BELOW_WM0_MASK REG_GENMASK(5, 0) + +#define _UNDERRUN_DBG2_A 0x70068 +#define _UNDERRUN_DBG2_B 0x71068 +#define UNDERRUN_DBG2 (pipe) _MMIO_PIPE(pipe, _UNDERRUN_DBG2_A, _UNDERRUN_DBG2_B) +#define UNDERRUN_FRAME_LINE_COUNTERS_FROZEN REG_BIT(31) +#define UNDERRUN_PIPE_FRAME_COUNT_MASK REG_GENMASK(30, 20) +#define UNDERRUN_LINE_COUNT_MASK REG_GENMASK(19, 0) +#define DPINVGTT _MMIO(VLV_DISPLAY_BASE + 0x7002c)/* VLV/CHV only */ #define DPINVGTT_EN_MASK_CHV REG_GENMASK(27, 16)#define DPINVGTT_EN_MASK_VLV REG_GENMASK(23, 16)
@@ -1416,6 +1431,7 @@#define GEN12_DCPR_STATUS_1 _MMIO(0x46440)#define XELPDP_PMDEMAND_INFLIGHT_STATUS REG_BIT(26) +#define XE3P_UNDERRUN_PKGC REG_BIT(21)#define FUSE_STRAP _MMIO(0x42014)#define ILK_INTERNAL_GRAPHICS_DISABLE REG_BIT(31)
drivers/gpu/drm/i915/display/intel_fbc_regs.h +2 -0
@@ -88,6 +88,8 @@#define DPFC_FENCE_YOFF _MMIO(0x3218)#define ILK_DPFC_FENCE_YOFF (fbc_id) _MMIO_PIPE((fbc_id), 0x43218, 0x43258)#define DPFC_CHICKEN _MMIO(0x3224) +#define FBC_DEBUG_STATUS (fbc_id) _MMIO_PIPE((fbc_id), 0x43220, 0x43260) +#define FBC_UNDERRUN_DECMPR REG_BIT(27)#define ILK_DPFC_CHICKEN (fbc_id) _MMIO_PIPE((fbc_id), 0x43224, 0x43264)#define DPFC_HT_MODIFY REG_BIT(31)/* pre-ivb */ #define DPFC_NUKE_ON_ANY_MODIFICATION REG_BIT(23)/* bdw+ */
drivers/gpu/drm/i915/display/intel_fifo_underrun.c +128 -0
158 lines not on this page · raw message
Signature · 1 line
2.51.0
Re: [PATCH v4 06/11] drm/i915/xe3p_lpd: Handle underrun debug bits
Quoted 112 lines · Gustavo Sousa
Xe3p_LPDadded several bits containing information that can be relevant to debugging FIFO underruns. Add the logic necessary to handle them when reporting underruns.This was adapted from the initial patch[1] from Sai Teja Pottumuttu.
[1] https://lore.kernel.org/all/[email protected]/
Bspec: 69111, 69561, 74411, 74412
Cc Jani Nikula <[email protected]>Cc Matt Roper <[email protected]>Cc Ville Syrjälä <[email protected]>Signed-off-by Gustavo Sousa <[email protected]>---
I tested this by adding a change on top of this series that updates Xe3p_LPD's CDCLK table to use bad values and I got the following messages:[ +0.000237] xe 0000:00:02.0: [drm:intel_modeset_verify_crtc [xe]] [CRTC:88:pipe A] [ +0.000674] xe 0000:00:02.0: [drm] *ERROR* CPU pipe A FIFO underrun [ +0.000015] xe 0000:00:02.0: [drm] *ERROR* Pipe A FIFO underrun info: DBUF block not valid on planes: [1] [ +0.000001] xe 0000:00:02.0: [drm] *ERROR* Pipe A FIFO underrun info: DDB empty on planes: [1] [ +0.000001] xe 0000:00:02.0: [drm] *ERROR* Pipe A FIFO underrun info: DBUF below WM0 on planes: [1] [ +0.000004] xe 0000:00:02.0: [drm] *ERROR* Pipe A FIFO underrun info: frame count: 1890, line count: 44 --- .../gpu/drm/i915/display/intel_display_device.h | 1 + drivers/gpu/drm/i915/display/intel_display_regs.h | 16 +++ drivers/gpu/drm/i915/display/intel_fbc_regs.h | 2 + drivers/gpu/drm/i915/display/intel_fifo_underrun.c | 128 +++++++++++++++++++++ 4 files changed, 147 insertions(+)drivers/gpu/drm/i915/display/intel_display_device.h +1
-0@@ -197,6 +197,7 @@ struct intel_display_platforms {#define HAS_TRANSCODER (__display, trans) ((DISPLAY_RUNTIME_INFO(__display)->cpu_transcoder_mask & \ BIT(trans)) != 0)#define HAS_UNCOMPRESSED_JOINER (__display) (DISPLAY_VER(__display) >= 13) +#define HAS_UNDERRUN_DBG_INFO (__display) (DISPLAY_VER(__display) >= 35)#define HAS_ULTRAJOINER (__display) (((__display)->platform.dgfx && \ DISPLAY_VER(__display) == 14) && HAS_DSC(__display))#define HAS_VRR (__display) (DISPLAY_VER(__display) >= 11)drivers/gpu/drm/i915/display/intel_display_regs.h +16
-0@@ -882,6 +882,21 @@#define PIPE_MISC2_FLIP_INFO_PLANE_SEL_MASK REG_GENMASK(2, 0)/* tgl+ */ #define PIPE_MISC2_FLIP_INFO_PLANE_SEL (plane_id) REG_FIELD_PREP(PIPE_MISC2_FLIP_INFO_PLANE_SEL_MASK, (plane_id)) +#define _UNDERRUN_DBG1_A 0x70064 +#define _UNDERRUN_DBG1_B 0x71064 +#define UNDERRUN_DBG1 (pipe) _MMIO_PIPE(pipe, _UNDERRUN_DBG1_A, _UNDERRUN_DBG1_B) +#define UNDERRUN_DBUF_BLOCK_NOT_VALID_MASK REG_GENMASK(29, 24) +#define UNDERRUN_DDB_EMPTY_MASK REG_GENMASK(21, 16) +#define UNDERRUN_DBUF_NOT_FILLED_MASK REG_GENMASK(13, 8) +#define UNDERRUN_BELOW_WM0_MASK REG_GENMASK(5, 0) + +#define _UNDERRUN_DBG2_A 0x70068 +#define _UNDERRUN_DBG2_B 0x71068 +#define UNDERRUN_DBG2 (pipe) _MMIO_PIPE(pipe, _UNDERRUN_DBG2_A, _UNDERRUN_DBG2_B) +#define UNDERRUN_FRAME_LINE_COUNTERS_FROZEN REG_BIT(31) +#define UNDERRUN_PIPE_FRAME_COUNT_MASK REG_GENMASK(30, 20) +#define UNDERRUN_LINE_COUNT_MASK REG_GENMASK(19, 0) +#define DPINVGTT _MMIO(VLV_DISPLAY_BASE + 0x7002c)/* VLV/CHV only */ #define DPINVGTT_EN_MASK_CHV REG_GENMASK(27, 16)#define DPINVGTT_EN_MASK_VLV REG_GENMASK(23, 16)@@ -1416,6 +1431,7 @@#define GEN12_DCPR_STATUS_1 _MMIO(0x46440)#define XELPDP_PMDEMAND_INFLIGHT_STATUS REG_BIT(26) +#define XE3P_UNDERRUN_PKGC REG_BIT(21)#define FUSE_STRAP _MMIO(0x42014)#define ILK_INTERNAL_GRAPHICS_DISABLE REG_BIT(31)drivers/gpu/drm/i915/display/intel_fbc_regs.h +2
-0@@ -88,6 +88,8 @@#define DPFC_FENCE_YOFF _MMIO(0x3218)#define ILK_DPFC_FENCE_YOFF (fbc_id) _MMIO_PIPE((fbc_id), 0x43218, 0x43258)#define DPFC_CHICKEN _MMIO(0x3224) +#define FBC_DEBUG_STATUS (fbc_id) _MMIO_PIPE((fbc_id), 0x43220, 0x43260) +#define FBC_UNDERRUN_DECMPR REG_BIT(27)#define ILK_DPFC_CHICKEN (fbc_id) _MMIO_PIPE((fbc_id), 0x43224, 0x43264)#define DPFC_HT_MODIFY REG_BIT(31)/* pre-ivb */ #define DPFC_NUKE_ON_ANY_MODIFICATION REG_BIT(23)/* bdw+ */ drivers/gpu/drm/i915/display/intel_fifo_underrun.c +3
-0@@ -25,6 +25,8 @@* */ +#include <linux/seq_buf.h> +#include <drm/drm_print.h> #include "i915_reg.h" @@ -34,6 +36,7 @@#include "intel_display_trace.h" #include "intel_display_types.h" #include "intel_fbc.h" +#include "intel_fbc_regs.h" #include "intel_fifo_underrun.h" #include "intel_pch_display.h"
drivers/gpu/drm/i915/display/intel_fifo_underrun.c line 67
Quoted 8 lines
drivers/gpu/drm/i915/display/intel_fifo_underrun.c +5
-0@@ -57,6 +60,118 @@* The code also supports underrun detection on the PCH transcoder. */ +#define UNDERRUN_DBG1_NUM_PLANES 6 + +static void read_underrun_dbg1 (struct intel_display *display,enum pipe pipe,bool log) +{ +u32 val =intel_de_read (display,UNDERRUN_DBG1 (pipe));
Nitpick, I really don't like the style of using "functional" (for want of a better word) initializers. Complicated is fine, like below for masks[], but doing something with the hardware or something that can fail, feels iffy.
drivers/gpu/drm/i915/display/intel_fifo_underrun.c line 78
Quoted 11 lines
drivers/gpu/drm/i915/display/intel_fifo_underrun.c +11
-0+struct { +u32 plane_mask; +const char *info; + } masks[] = { + {REG_FIELD_GET (UNDERRUN_DBUF_BLOCK_NOT_VALID_MASK , val),"DBUF block not valid" }, + {REG_FIELD_GET (UNDERRUN_DDB_EMPTY_MASK , val),"DDB empty" }, + {REG_FIELD_GET (UNDERRUN_DBUF_NOT_FILLED_MASK , val),"DBUF not completely filled" }, + {REG_FIELD_GET (UNDERRUN_BELOW_WM0_MASK , val),"DBUF below WM0" }, + }; +DECLARE_SEQ_BUF (planes_desc,32 ); +
IMO there's also a lot more clarity in having the assignment and the check back to back here:
val = intel_de_read(display, UNDERRUN_DBG1(pipe)); if (!val) return;
Ditto below.
BR,
Jani.
Quoted 126 lines
drivers/gpu/drm/i915/display/intel_fifo_underrun.c +109
-0+if (!val) +return ; + +intel_de_write (display,UNDERRUN_DBG1 (pipe), val); + +if (!log) +return ; + +for (int i =0 ; i <ARRAY_SIZE (masks); i++) { +if (!masks[i].plane_mask) +continue ; + +seq_buf_clear (&planes_desc); + +for (int j =0 ; j <UNDERRUN_DBG1_NUM_PLANES ; j++) { +if (!(masks[i].plane_mask ®_BIT (j))) +continue ; + +if (j ==0 ) +seq_buf_puts (&planes_desc,"[C]" ); +else +seq_buf_printf (&planes_desc,"[%d]" , j); + } + +drm_err (display->drm, +"Pipe %c FIFO underrun info: %s on planes: %s\n" , +pipe_name (pipe), masks[i].info,seq_buf_str (&planes_desc)); + +drm_WARN_ON (display->drm,seq_buf_has_overflowed (&planes_desc)); + } +} + +static void read_underrun_dbg2 (struct intel_display *display,enum pipe pipe,bool log) +{ +u32 val =intel_de_read (display,UNDERRUN_DBG2 (pipe)); + +if (!(val &UNDERRUN_FRAME_LINE_COUNTERS_FROZEN )) +return ; + +intel_de_write (display,UNDERRUN_DBG2 (pipe),UNDERRUN_FRAME_LINE_COUNTERS_FROZEN ); + +if (log) +drm_err (display->drm, +"Pipe %c FIFO underrun info: frame count: %u, line count: %u\n" , +pipe_name (pipe), +REG_FIELD_GET (UNDERRUN_PIPE_FRAME_COUNT_MASK , val), +REG_FIELD_GET (UNDERRUN_LINE_COUNT_MASK , val)); +} + +static void read_underrun_dbg_fbc (struct intel_display *display,enum pipe pipe,bool log) +{ +enum intel_fbc_id fbc_id =intel_fbc_id_for_pipe (pipe); +u32 val =intel_de_read (display,FBC_DEBUG_STATUS (fbc_id)); + +if (!(val &FBC_UNDERRUN_DECMPR )) +return ; + +intel_de_write (display,FBC_DEBUG_STATUS (fbc_id),FBC_UNDERRUN_DECMPR ); + +if (log) +drm_err (display->drm, +"Pipe %c FIFO underrun info: FBC decompressing\n" , +pipe_name (pipe)); +} + +static void read_underrun_dbg_pkgc (struct intel_display *display,bool log) +{ +u32 val =intel_de_read (display,GEN12_DCPR_STATUS_1 ); + +if (!(val &XE3P_UNDERRUN_PKGC )) +return ; + +/* +* Note: If there are multiple pipes enabled, only one of them will see +* XE3P_UNDERRUN_PKGC set. +*/ +intel_de_write (display,GEN12_DCPR_STATUS_1 ,XE3P_UNDERRUN_PKGC ); + +if (log) +drm_err (display->drm, +"General FIFO underrun info: Package C-state blocking memory\n" ); +} + +static void read_underrun_dbg_info (struct intel_display *display, +enum pipe pipe, +bool log) +{ +if (!HAS_UNDERRUN_DBG_INFO (display)) +return ; + +read_underrun_dbg1 (display, pipe, log); +read_underrun_dbg2 (display, pipe, log); +read_underrun_dbg_fbc (display, pipe, log); +read_underrun_dbg_pkgc (display, log); +} +static bool ivb_can_enable_err_int (struct intel_display *display) {struct intel_crtc *crtc;@@ -262,6 +377,17 @@ static bool __intel_set_cpu_fifo_underrun_reporting(struct intel_display *displa old = !crtc->cpu_fifo_underrun_disabled; crtc->cpu_fifo_underrun_disabled = !enable; +/* +* The debug bits get latched at the time of the FIFO underrun ISR bit +* getting set. That means that any existing debug bit that is set when +* handling a FIFO underrun interrupt has the potential to belong to +* another underrun event (past or future). To alleviate this problem, +* let's clear existing bits before enabling the interrupt, so that at +* least we don't get information that is too out-of-date. +*/ +if (enable && !old) +read_underrun_dbg_info (display, pipe, false); +if (HAS_GMCH (display))i9xx_set_fifo_underrun_reporting (display, pipe, enable, old);else if (display->platform.ironlake || display->platform.sandybridge)@@ -379,6 +505,8 @@ void intel_cpu_fifo_underrun_irq_handler(struct intel_display *display,trace_intel_cpu_fifo_underrun (display, pipe);drm_err (display->drm,"CPU pipe %c FIFO underrun\n" ,pipe_name (pipe)); + +read_underrun_dbg_info (display, pipe, true); }intel_fbc_handle_fifo_underrun_irq (display);
Signature · 1 line
Jani Nikula, Intel
Re: [PATCH v4 06/11] drm/i915/xe3p_lpd: Handle underrun debug bits
Quoting Jani Nikula (2025-11-10 08:45:48-03:00)
Quoted 116 lines · Gustavo Sousa
Quoted 115 lines
Xe3p_LPDadded several bits containing information that can be relevant to debugging FIFO underruns. Add the logic necessary to handle them when reporting underruns.This was adapted from the initial patch[1] from Sai Teja Pottumuttu.
[1] https://lore.kernel.org/all/[email protected]/
Bspec: 69111, 69561, 74411, 74412
Cc Jani Nikula <[email protected]>Cc Matt Roper <[email protected]>Cc Ville Syrjälä <[email protected]>Signed-off-by Gustavo Sousa <[email protected]>---
I tested this by adding a change on top of this series that updates Xe3p_LPD's CDCLK table to use bad values and I got the following messages:[ +0.000237] xe 0000:00:02.0: [drm:intel_modeset_verify_crtc [xe]] [CRTC:88:pipe A] [ +0.000674] xe 0000:00:02.0: [drm] *ERROR* CPU pipe A FIFO underrun [ +0.000015] xe 0000:00:02.0: [drm] *ERROR* Pipe A FIFO underrun info: DBUF block not valid on planes: [1] [ +0.000001] xe 0000:00:02.0: [drm] *ERROR* Pipe A FIFO underrun info: DDB empty on planes: [1] [ +0.000001] xe 0000:00:02.0: [drm] *ERROR* Pipe A FIFO underrun info: DBUF below WM0 on planes: [1] [ +0.000004] xe 0000:00:02.0: [drm] *ERROR* Pipe A FIFO underrun info: frame count: 1890, line count: 44 --- .../gpu/drm/i915/display/intel_display_device.h | 1 + drivers/gpu/drm/i915/display/intel_display_regs.h | 16 +++ drivers/gpu/drm/i915/display/intel_fbc_regs.h | 2 + drivers/gpu/drm/i915/display/intel_fifo_underrun.c | 128 +++++++++++++++++++++ 4 files changed, 147 insertions(+)drivers/gpu/drm/i915/display/intel_display_device.h +1
-0@@ -197,6 +197,7 @@ struct intel_display_platforms {#define HAS_TRANSCODER (__display, trans) ((DISPLAY_RUNTIME_INFO(__display)->cpu_transcoder_mask & \ BIT(trans)) != 0)#define HAS_UNCOMPRESSED_JOINER (__display) (DISPLAY_VER(__display) >= 13) +#define HAS_UNDERRUN_DBG_INFO (__display) (DISPLAY_VER(__display) >= 35)#define HAS_ULTRAJOINER (__display) (((__display)->platform.dgfx && \ DISPLAY_VER(__display) == 14) && HAS_DSC(__display))#define HAS_VRR (__display) (DISPLAY_VER(__display) >= 11)drivers/gpu/drm/i915/display/intel_display_regs.h +16
-0@@ -882,6 +882,21 @@#define PIPE_MISC2_FLIP_INFO_PLANE_SEL_MASK REG_GENMASK(2, 0)/* tgl+ */ #define PIPE_MISC2_FLIP_INFO_PLANE_SEL (plane_id) REG_FIELD_PREP(PIPE_MISC2_FLIP_INFO_PLANE_SEL_MASK, (plane_id)) +#define _UNDERRUN_DBG1_A 0x70064 +#define _UNDERRUN_DBG1_B 0x71064 +#define UNDERRUN_DBG1 (pipe) _MMIO_PIPE(pipe, _UNDERRUN_DBG1_A, _UNDERRUN_DBG1_B) +#define UNDERRUN_DBUF_BLOCK_NOT_VALID_MASK REG_GENMASK(29, 24) +#define UNDERRUN_DDB_EMPTY_MASK REG_GENMASK(21, 16) +#define UNDERRUN_DBUF_NOT_FILLED_MASK REG_GENMASK(13, 8) +#define UNDERRUN_BELOW_WM0_MASK REG_GENMASK(5, 0) + +#define _UNDERRUN_DBG2_A 0x70068 +#define _UNDERRUN_DBG2_B 0x71068 +#define UNDERRUN_DBG2 (pipe) _MMIO_PIPE(pipe, _UNDERRUN_DBG2_A, _UNDERRUN_DBG2_B) +#define UNDERRUN_FRAME_LINE_COUNTERS_FROZEN REG_BIT(31) +#define UNDERRUN_PIPE_FRAME_COUNT_MASK REG_GENMASK(30, 20) +#define UNDERRUN_LINE_COUNT_MASK REG_GENMASK(19, 0) +#define DPINVGTT _MMIO(VLV_DISPLAY_BASE + 0x7002c)/* VLV/CHV only */ #define DPINVGTT_EN_MASK_CHV REG_GENMASK(27, 16)#define DPINVGTT_EN_MASK_VLV REG_GENMASK(23, 16)@@ -1416,6 +1431,7 @@#define GEN12_DCPR_STATUS_1 _MMIO(0x46440)#define XELPDP_PMDEMAND_INFLIGHT_STATUS REG_BIT(26) +#define XE3P_UNDERRUN_PKGC REG_BIT(21)#define FUSE_STRAP _MMIO(0x42014)#define ILK_INTERNAL_GRAPHICS_DISABLE REG_BIT(31)drivers/gpu/drm/i915/display/intel_fbc_regs.h +2
-0@@ -88,6 +88,8 @@#define DPFC_FENCE_YOFF _MMIO(0x3218)#define ILK_DPFC_FENCE_YOFF (fbc_id) _MMIO_PIPE((fbc_id), 0x43218, 0x43258)#define DPFC_CHICKEN _MMIO(0x3224) +#define FBC_DEBUG_STATUS (fbc_id) _MMIO_PIPE((fbc_id), 0x43220, 0x43260) +#define FBC_UNDERRUN_DECMPR REG_BIT(27)#define ILK_DPFC_CHICKEN (fbc_id) _MMIO_PIPE((fbc_id), 0x43224, 0x43264)#define DPFC_HT_MODIFY REG_BIT(31)/* pre-ivb */ #define DPFC_NUKE_ON_ANY_MODIFICATION REG_BIT(23)/* bdw+ */ drivers/gpu/drm/i915/display/intel_fifo_underrun.c +3
-0@@ -25,6 +25,8 @@* */ +#include <linux/seq_buf.h> +#include <drm/drm_print.h> #include "i915_reg.h" @@ -34,6 +36,7 @@#include "intel_display_trace.h" #include "intel_display_types.h" #include "intel_fbc.h" +#include "intel_fbc_regs.h" #include "intel_fifo_underrun.h" #include "intel_pch_display.h" @@ -57,6 +60,118 @@* The code also supports underrun detection on the PCH transcoder. */
Quoted 10 lines
drivers/gpu/drm/i915/display/intel_fifo_underrun.c line 67
Quoted 5 lines
drivers/gpu/drm/i915/display/intel_fifo_underrun.c +5
-0+#define UNDERRUN_DBG1_NUM_PLANES 6 + +static void read_underrun_dbg1 (struct intel_display *display,enum pipe pipe,bool log) +{ +u32 val =intel_de_read (display,UNDERRUN_DBG1 (pipe));Nitpick, I really don't like the style of using "functional" (for want of a better word) initializers. Complicated is fine, like below for masks[], but doing something with the hardware or something that can fail, feels iffy.
Alright. I'll update this to do as you suggested below. One little annoyance is that we will need to open code REG_FIELD_GET() (as done in [1]), because the mask parameter needs to be a constant expression.
[1] https://lore.kernel.org/all/[email protected]/
Quoted 13 lines
drivers/gpu/drm/i915/display/intel_fifo_underrun.c line 78
Quoted 12 lines
drivers/gpu/drm/i915/display/intel_fifo_underrun.c +11
-0+struct { +u32 plane_mask; +const char *info; + } masks[] = { + {REG_FIELD_GET (UNDERRUN_DBUF_BLOCK_NOT_VALID_MASK , val),"DBUF block not valid" }, + {REG_FIELD_GET (UNDERRUN_DDB_EMPTY_MASK , val),"DDB empty" }, + {REG_FIELD_GET (UNDERRUN_DBUF_NOT_FILLED_MASK , val),"DBUF not completely filled" }, + {REG_FIELD_GET (UNDERRUN_BELOW_WM0_MASK , val),"DBUF below WM0" }, + }; +DECLARE_SEQ_BUF (planes_desc,32 ); +
Quoted 8 lines
IMO there's also a lot more clarity in having the assignment and the check back to back here:
val = intel_de_read(display, UNDERRUN_DBG1(pipe)); if (!val) return;Ditto below.
I'll update those as well.
That said, for curiosity:
Do you prefer to always use the pattern of declaring a variable for register values and assigning the result of the reading as separate statements? Or is this a preference for specific cases, like this one?
I did
git grep -W 'u32\s\+\w\+\s*=\s*intel_de_read' -- drivers/gpu/drm/i915/display/
and found cases where the pattern "u32 val = intel_de_read(...)" appears to make the code a bit more concise IMO.
While here in read_underrun_dbg1() the other variables and initializers do get in the way of readability/clarity, I see cases like:
u32 val = intel_de_read(...);
do_something_with(val);to be still clear, and each saves up 1 line of editor real estate.
--
Gustavo Sousa
Quoted 134 lines
BR,
Jani.Quoted 126 lines
drivers/gpu/drm/i915/display/intel_fifo_underrun.c +109
-0+if (!val) +return ; + +intel_de_write (display,UNDERRUN_DBG1 (pipe), val); + +if (!log) +return ; + +for (int i =0 ; i <ARRAY_SIZE (masks); i++) { +if (!masks[i].plane_mask) +continue ; + +seq_buf_clear (&planes_desc); + +for (int j =0 ; j <UNDERRUN_DBG1_NUM_PLANES ; j++) { +if (!(masks[i].plane_mask ®_BIT (j))) +continue ; + +if (j ==0 ) +seq_buf_puts (&planes_desc,"[C]" ); +else +seq_buf_printf (&planes_desc,"[%d]" , j); + } + +drm_err (display->drm, +"Pipe %c FIFO underrun info: %s on planes: %s\n" , +pipe_name (pipe), masks[i].info,seq_buf_str (&planes_desc)); + +drm_WARN_ON (display->drm,seq_buf_has_overflowed (&planes_desc)); + } +} + +static void read_underrun_dbg2 (struct intel_display *display,enum pipe pipe,bool log) +{ +u32 val =intel_de_read (display,UNDERRUN_DBG2 (pipe)); + +if (!(val &UNDERRUN_FRAME_LINE_COUNTERS_FROZEN )) +return ; + +intel_de_write (display,UNDERRUN_DBG2 (pipe),UNDERRUN_FRAME_LINE_COUNTERS_FROZEN ); + +if (log) +drm_err (display->drm, +"Pipe %c FIFO underrun info: frame count: %u, line count: %u\n" , +pipe_name (pipe), +REG_FIELD_GET (UNDERRUN_PIPE_FRAME_COUNT_MASK , val), +REG_FIELD_GET (UNDERRUN_LINE_COUNT_MASK , val)); +} + +static void read_underrun_dbg_fbc (struct intel_display *display,enum pipe pipe,bool log) +{ +enum intel_fbc_id fbc_id =intel_fbc_id_for_pipe (pipe); +u32 val =intel_de_read (display,FBC_DEBUG_STATUS (fbc_id)); + +if (!(val &FBC_UNDERRUN_DECMPR )) +return ; + +intel_de_write (display,FBC_DEBUG_STATUS (fbc_id),FBC_UNDERRUN_DECMPR ); + +if (log) +drm_err (display->drm, +"Pipe %c FIFO underrun info: FBC decompressing\n" , +pipe_name (pipe)); +} + +static void read_underrun_dbg_pkgc (struct intel_display *display,bool log) +{ +u32 val =intel_de_read (display,GEN12_DCPR_STATUS_1 ); + +if (!(val &XE3P_UNDERRUN_PKGC )) +return ; + +/* +* Note: If there are multiple pipes enabled, only one of them will see +* XE3P_UNDERRUN_PKGC set. +*/ +intel_de_write (display,GEN12_DCPR_STATUS_1 ,XE3P_UNDERRUN_PKGC ); + +if (log) +drm_err (display->drm, +"General FIFO underrun info: Package C-state blocking memory\n" ); +} + +static void read_underrun_dbg_info (struct intel_display *display, +enum pipe pipe, +bool log) +{ +if (!HAS_UNDERRUN_DBG_INFO (display)) +return ; + +read_underrun_dbg1 (display, pipe, log); +read_underrun_dbg2 (display, pipe, log); +read_underrun_dbg_fbc (display, pipe, log); +read_underrun_dbg_pkgc (display, log); +} +static bool ivb_can_enable_err_int (struct intel_display *display) {struct intel_crtc *crtc;@@ -262,6 +377,17 @@ static bool __intel_set_cpu_fifo_underrun_reporting(struct intel_display *displa old = !crtc->cpu_fifo_underrun_disabled; crtc->cpu_fifo_underrun_disabled = !enable; +/* +* The debug bits get latched at the time of the FIFO underrun ISR bit +* getting set. That means that any existing debug bit that is set when +* handling a FIFO underrun interrupt has the potential to belong to +* another underrun event (past or future). To alleviate this problem, +* let's clear existing bits before enabling the interrupt, so that at +* least we don't get information that is too out-of-date. +*/ +if (enable && !old) +read_underrun_dbg_info (display, pipe, false); +if (HAS_GMCH (display))i9xx_set_fifo_underrun_reporting (display, pipe, enable, old);else if (display->platform.ironlake || display->platform.sandybridge)@@ -379,6 +505,8 @@ void intel_cpu_fifo_underrun_irq_handler(struct intel_display *display,trace_intel_cpu_fifo_underrun (display, pipe);drm_err (display->drm,"CPU pipe %c FIFO underrun\n" ,pipe_name (pipe)); + +read_underrun_dbg_info (display, pipe, true); }intel_fbc_handle_fifo_underrun_irq (display);Signature · 1 line
Jani Nikula, Intel
Re: [PATCH v4 06/11] drm/i915/xe3p_lpd: Handle underrun debug bits
Quoted 128 lines · Gustavo Sousa
Quoting Jani Nikula (2025-11-10 08:45:48-03:00)
Quoted 116 lines · Gustavo Sousa
Quoted 115 lines
Xe3p_LPDadded several bits containing information that can be relevant to debugging FIFO underruns. Add the logic necessary to handle them when reporting underruns.This was adapted from the initial patch[1] from Sai Teja Pottumuttu.
[1] https://lore.kernel.org/all/[email protected]/
Bspec: 69111, 69561, 74411, 74412
Cc Jani Nikula <[email protected]>Cc Matt Roper <[email protected]>Cc Ville Syrjälä <[email protected]>Signed-off-by Gustavo Sousa <[email protected]>---
I tested this by adding a change on top of this series that updates Xe3p_LPD's CDCLK table to use bad values and I got the following messages:[ +0.000237] xe 0000:00:02.0: [drm:intel_modeset_verify_crtc [xe]] [CRTC:88:pipe A] [ +0.000674] xe 0000:00:02.0: [drm] *ERROR* CPU pipe A FIFO underrun [ +0.000015] xe 0000:00:02.0: [drm] *ERROR* Pipe A FIFO underrun info: DBUF block not valid on planes: [1] [ +0.000001] xe 0000:00:02.0: [drm] *ERROR* Pipe A FIFO underrun info: DDB empty on planes: [1] [ +0.000001] xe 0000:00:02.0: [drm] *ERROR* Pipe A FIFO underrun info: DBUF below WM0 on planes: [1] [ +0.000004] xe 0000:00:02.0: [drm] *ERROR* Pipe A FIFO underrun info: frame count: 1890, line count: 44 --- .../gpu/drm/i915/display/intel_display_device.h | 1 + drivers/gpu/drm/i915/display/intel_display_regs.h | 16 +++ drivers/gpu/drm/i915/display/intel_fbc_regs.h | 2 + drivers/gpu/drm/i915/display/intel_fifo_underrun.c | 128 +++++++++++++++++++++ 4 files changed, 147 insertions(+)drivers/gpu/drm/i915/display/intel_display_device.h +1
-0@@ -197,6 +197,7 @@ struct intel_display_platforms {#define HAS_TRANSCODER (__display, trans) ((DISPLAY_RUNTIME_INFO(__display)->cpu_transcoder_mask & \ BIT(trans)) != 0)#define HAS_UNCOMPRESSED_JOINER (__display) (DISPLAY_VER(__display) >= 13) +#define HAS_UNDERRUN_DBG_INFO (__display) (DISPLAY_VER(__display) >= 35)#define HAS_ULTRAJOINER (__display) (((__display)->platform.dgfx && \ DISPLAY_VER(__display) == 14) && HAS_DSC(__display))#define HAS_VRR (__display) (DISPLAY_VER(__display) >= 11)drivers/gpu/drm/i915/display/intel_display_regs.h +16
-0@@ -882,6 +882,21 @@#define PIPE_MISC2_FLIP_INFO_PLANE_SEL_MASK REG_GENMASK(2, 0)/* tgl+ */ #define PIPE_MISC2_FLIP_INFO_PLANE_SEL (plane_id) REG_FIELD_PREP(PIPE_MISC2_FLIP_INFO_PLANE_SEL_MASK, (plane_id)) +#define _UNDERRUN_DBG1_A 0x70064 +#define _UNDERRUN_DBG1_B 0x71064 +#define UNDERRUN_DBG1 (pipe) _MMIO_PIPE(pipe, _UNDERRUN_DBG1_A, _UNDERRUN_DBG1_B) +#define UNDERRUN_DBUF_BLOCK_NOT_VALID_MASK REG_GENMASK(29, 24) +#define UNDERRUN_DDB_EMPTY_MASK REG_GENMASK(21, 16) +#define UNDERRUN_DBUF_NOT_FILLED_MASK REG_GENMASK(13, 8) +#define UNDERRUN_BELOW_WM0_MASK REG_GENMASK(5, 0) + +#define _UNDERRUN_DBG2_A 0x70068 +#define _UNDERRUN_DBG2_B 0x71068 +#define UNDERRUN_DBG2 (pipe) _MMIO_PIPE(pipe, _UNDERRUN_DBG2_A, _UNDERRUN_DBG2_B) +#define UNDERRUN_FRAME_LINE_COUNTERS_FROZEN REG_BIT(31) +#define UNDERRUN_PIPE_FRAME_COUNT_MASK REG_GENMASK(30, 20) +#define UNDERRUN_LINE_COUNT_MASK REG_GENMASK(19, 0) +#define DPINVGTT _MMIO(VLV_DISPLAY_BASE + 0x7002c)/* VLV/CHV only */ #define DPINVGTT_EN_MASK_CHV REG_GENMASK(27, 16)#define DPINVGTT_EN_MASK_VLV REG_GENMASK(23, 16)@@ -1416,6 +1431,7 @@#define GEN12_DCPR_STATUS_1 _MMIO(0x46440)#define XELPDP_PMDEMAND_INFLIGHT_STATUS REG_BIT(26) +#define XE3P_UNDERRUN_PKGC REG_BIT(21)#define FUSE_STRAP _MMIO(0x42014)#define ILK_INTERNAL_GRAPHICS_DISABLE REG_BIT(31)drivers/gpu/drm/i915/display/intel_fbc_regs.h +2
-0@@ -88,6 +88,8 @@#define DPFC_FENCE_YOFF _MMIO(0x3218)#define ILK_DPFC_FENCE_YOFF (fbc_id) _MMIO_PIPE((fbc_id), 0x43218, 0x43258)#define DPFC_CHICKEN _MMIO(0x3224) +#define FBC_DEBUG_STATUS (fbc_id) _MMIO_PIPE((fbc_id), 0x43220, 0x43260) +#define FBC_UNDERRUN_DECMPR REG_BIT(27)#define ILK_DPFC_CHICKEN (fbc_id) _MMIO_PIPE((fbc_id), 0x43224, 0x43264)#define DPFC_HT_MODIFY REG_BIT(31)/* pre-ivb */ #define DPFC_NUKE_ON_ANY_MODIFICATION REG_BIT(23)/* bdw+ */ drivers/gpu/drm/i915/display/intel_fifo_underrun.c +3
-0@@ -25,6 +25,8 @@* */ +#include <linux/seq_buf.h> +#include <drm/drm_print.h> #include "i915_reg.h" @@ -34,6 +36,7 @@#include "intel_display_trace.h" #include "intel_display_types.h" #include "intel_fbc.h" +#include "intel_fbc_regs.h" #include "intel_fifo_underrun.h" #include "intel_pch_display.h" @@ -57,6 +60,118 @@* The code also supports underrun detection on the PCH transcoder. */ Quoted 10 lines
drivers/gpu/drm/i915/display/intel_fifo_underrun.c line 67
Quoted 5 lines
drivers/gpu/drm/i915/display/intel_fifo_underrun.c +5
-0+#define UNDERRUN_DBG1_NUM_PLANES 6 + +static void read_underrun_dbg1 (struct intel_display *display,enum pipe pipe,bool log) +{ +u32 val =intel_de_read (display,UNDERRUN_DBG1 (pipe));Nitpick, I really don't like the style of using "functional" (for want of a better word) initializers. Complicated is fine, like below for masks[], but doing something with the hardware or something that can fail, feels iffy.
Quoted 18 lines
Alright. I'll update this to do as you suggested below. One little annoyance is that we will need to open code
REG_FIELD_GET()(as done in [1]), because the mask parameter needs to be a constant expression.[1] https://lore.kernel.org/all/[email protected]/
Quoted 12 lines
Quoted 12 lines
drivers/gpu/drm/i915/display/intel_fifo_underrun.c +11
-0+struct { +u32 plane_mask; +const char *info; + } masks[] = { + {REG_FIELD_GET (UNDERRUN_DBUF_BLOCK_NOT_VALID_MASK , val),"DBUF block not valid" }, + {REG_FIELD_GET (UNDERRUN_DDB_EMPTY_MASK , val),"DDB empty" }, + {REG_FIELD_GET (UNDERRUN_DBUF_NOT_FILLED_MASK , val),"DBUF not completely filled" }, + {REG_FIELD_GET (UNDERRUN_BELOW_WM0_MASK , val),"DBUF below WM0" }, + }; +DECLARE_SEQ_BUF (planes_desc,32 ); +
Mmh, right, I didn't even spot that val was being used in the masks[] initialization.
Here's a completely different approach that avoids some of the problems. I'm not sure if it's better or worse, just different. Two lines shorter than the original.
static void log_underrun_dbg(struct intel_display *display, unsigned long plane_mask,
enum pipe pipe, const char *info)
{
DECLARE_SEQ_BUF(planes_desc, 32);
unsigned int i;
if (!plane_mask)
return;
for_each_set_bit(i, &plane_mask, UNDERRUN_DBG1_NUM_PLANES) {
if (i == 0)
seq_buf_puts(&planes_desc, "[C]");
else
seq_buf_printf(&planes_desc, "[%d]", i);
}
drm_err(display->drm, "Pipe %c FIFO underrun info: %s on planes: %s\n",
pipe_name(pipe), info, seq_buf_str(&planes_desc));
drm_WARN_ON(display->drm, seq_buf_has_overflowed(&planes_desc));
}static void read_underrun_dbg1(struct intel_display *display, enum pipe pipe, bool log)
{
u32 val = intel_de_read(display, UNDERRUN_DBG1(pipe));
if (!val)
return;
intel_de_write(display, UNDERRUN_DBG1(pipe), val);
if (!log)
return;
log_underrun_dbg(display, REG_FIELD_GET(UNDERRUN_DBUF_BLOCK_NOT_VALID_MASK, val),
pipe, "DBUF block not valid");
log_underrun_dbg(display, REG_FIELD_GET(UNDERRUN_DDB_EMPTY_MASK, val),
pipe, "DDB empty");
log_underrun_dbg(display, REG_FIELD_GET(UNDERRUN_DBUF_NOT_FILLED_MASK, val),
pipe, "DBUF not completely filled");
log_underrun_dbg(display, REG_FIELD_GET(UNDERRUN_BELOW_WM0_MASK, val),
pipe, "DBUF below WM0");
}Quoted 24 lines
Quoted 8 lines
IMO there's also a lot more clarity in having the assignment and the check back to back here:
val = intel_de_read(display, UNDERRUN_DBG1(pipe)); if (!val) return;Ditto below.
I'll update those as well.
That said, for curiosity:
Do you prefer to always use the pattern of declaring a variable for register values and assigning the result of the reading as separate statements? Or is this a preference for specific cases, like this one?
I did
git grep -W 'u32\s\+\w\+\s*=\s*intel_de_read' -- drivers/gpu/drm/i915/display/and found cases where the pattern "u32 val =
intel_de_read(...)" appears to make the code a bit more concise IMO.
Quoted 8 lines
While here in
read_underrun_dbg1()the other variables and initializers do get in the way of readability/clarity, I see cases like:u32 val = intel_de_read(...); do_something_with(val);to be still clear, and each saves up 1 line of editor real estate.
Yeah, I guess it's a bit hard to have hard rules, and in small functions or blocks it's fine to combine. Let's maybe file this under a knee-jerk reaction to read_underrun_dbg1() where there's a bunch of declarations, and the actual code starts with if (!val) and you're like where did that come from. The other functions appear small enough. Fair?
BR,
Jani.
Quoted 138 lines
--
Gustavo SousaQuoted 134 lines
BR,
Jani.Quoted 126 lines
drivers/gpu/drm/i915/display/intel_fifo_underrun.c +109
-0+if (!val) +return ; + +intel_de_write (display,UNDERRUN_DBG1 (pipe), val); + +if (!log) +return ; + +for (int i =0 ; i <ARRAY_SIZE (masks); i++) { +if (!masks[i].plane_mask) +continue ; + +seq_buf_clear (&planes_desc); + +for (int j =0 ; j <UNDERRUN_DBG1_NUM_PLANES ; j++) { +if (!(masks[i].plane_mask ®_BIT (j))) +continue ; + +if (j ==0 ) +seq_buf_puts (&planes_desc,"[C]" ); +else +seq_buf_printf (&planes_desc,"[%d]" , j); + } + +drm_err (display->drm, +"Pipe %c FIFO underrun info: %s on planes: %s\n" , +pipe_name (pipe), masks[i].info,seq_buf_str (&planes_desc)); + +drm_WARN_ON (display->drm,seq_buf_has_overflowed (&planes_desc)); + } +} + +static void read_underrun_dbg2 (struct intel_display *display,enum pipe pipe,bool log) +{ +u32 val =intel_de_read (display,UNDERRUN_DBG2 (pipe)); + +if (!(val &UNDERRUN_FRAME_LINE_COUNTERS_FROZEN )) +return ; + +intel_de_write (display,UNDERRUN_DBG2 (pipe),UNDERRUN_FRAME_LINE_COUNTERS_FROZEN ); + +if (log) +drm_err (display->drm, +"Pipe %c FIFO underrun info: frame count: %u, line count: %u\n" , +pipe_name (pipe), +REG_FIELD_GET (UNDERRUN_PIPE_FRAME_COUNT_MASK , val), +REG_FIELD_GET (UNDERRUN_LINE_COUNT_MASK , val)); +} + +static void read_underrun_dbg_fbc (struct intel_display *display,enum pipe pipe,bool log) +{ +enum intel_fbc_id fbc_id =intel_fbc_id_for_pipe (pipe); +u32 val =intel_de_read (display,FBC_DEBUG_STATUS (fbc_id)); + +if (!(val &FBC_UNDERRUN_DECMPR )) +return ; + +intel_de_write (display,FBC_DEBUG_STATUS (fbc_id),FBC_UNDERRUN_DECMPR ); + +if (log) +drm_err (display->drm, +"Pipe %c FIFO underrun info: FBC decompressing\n" , +pipe_name (pipe)); +} + +static void read_underrun_dbg_pkgc (struct intel_display *display,bool log) +{ +u32 val =intel_de_read (display,GEN12_DCPR_STATUS_1 ); + +if (!(val &XE3P_UNDERRUN_PKGC )) +return ; + +/* +* Note: If there are multiple pipes enabled, only one of them will see +* XE3P_UNDERRUN_PKGC set. +*/ +intel_de_write (display,GEN12_DCPR_STATUS_1 ,XE3P_UNDERRUN_PKGC ); + +if (log) +drm_err (display->drm, +"General FIFO underrun info: Package C-state blocking memory\n" ); +} + +static void read_underrun_dbg_info (struct intel_display *display, +enum pipe pipe, +bool log) +{ +if (!HAS_UNDERRUN_DBG_INFO (display)) +return ; + +read_underrun_dbg1 (display, pipe, log); +read_underrun_dbg2 (display, pipe, log); +read_underrun_dbg_fbc (display, pipe, log); +read_underrun_dbg_pkgc (display, log); +} +static bool ivb_can_enable_err_int (struct intel_display *display) {struct intel_crtc *crtc;@@ -262,6 +377,17 @@ static bool __intel_set_cpu_fifo_underrun_reporting(struct intel_display *displa old = !crtc->cpu_fifo_underrun_disabled; crtc->cpu_fifo_underrun_disabled = !enable; +/* +* The debug bits get latched at the time of the FIFO underrun ISR bit +* getting set. That means that any existing debug bit that is set when +* handling a FIFO underrun interrupt has the potential to belong to +* another underrun event (past or future). To alleviate this problem, +* let's clear existing bits before enabling the interrupt, so that at +* least we don't get information that is too out-of-date. +*/ +if (enable && !old) +read_underrun_dbg_info (display, pipe, false); +if (HAS_GMCH (display))i9xx_set_fifo_underrun_reporting (display, pipe, enable, old);else if (display->platform.ironlake || display->platform.sandybridge)@@ -379,6 +505,8 @@ void intel_cpu_fifo_underrun_irq_handler(struct intel_display *display,trace_intel_cpu_fifo_underrun (display, pipe);drm_err (display->drm,"CPU pipe %c FIFO underrun\n" ,pipe_name (pipe)); + +read_underrun_dbg_info (display, pipe, true); }intel_fbc_handle_fifo_underrun_irq (display);Signature · 1 line
Jani Nikula, Intel
Signature · 1 line
Jani Nikula, Intel
Re: [PATCH v4 06/11] drm/i915/xe3p_lpd: Handle underrun debug bits
Quoting Jani Nikula (2025-11-11 07:22:43-03:00)
Quoted 190 lines · Gustavo Sousa
Quoted 128 lines
Quoting Jani Nikula (2025-11-10 08:45:48-03:00)
Quoted 116 lines · Gustavo Sousa
Quoted 115 lines
Xe3p_LPDadded several bits containing information that can be relevant to debugging FIFO underruns. Add the logic necessary to handle them when reporting underruns.This was adapted from the initial patch[1] from Sai Teja Pottumuttu.
[1] https://lore.kernel.org/all/[email protected]/
Bspec: 69111, 69561, 74411, 74412
Cc Jani Nikula <[email protected]>Cc Matt Roper <[email protected]>Cc Ville Syrjälä <[email protected]>Signed-off-by Gustavo Sousa <[email protected]>---
I tested this by adding a change on top of this series that updates Xe3p_LPD's CDCLK table to use bad values and I got the following messages:[ +0.000237] xe 0000:00:02.0: [drm:intel_modeset_verify_crtc [xe]] [CRTC:88:pipe A] [ +0.000674] xe 0000:00:02.0: [drm] *ERROR* CPU pipe A FIFO underrun [ +0.000015] xe 0000:00:02.0: [drm] *ERROR* Pipe A FIFO underrun info: DBUF block not valid on planes: [1] [ +0.000001] xe 0000:00:02.0: [drm] *ERROR* Pipe A FIFO underrun info: DDB empty on planes: [1] [ +0.000001] xe 0000:00:02.0: [drm] *ERROR* Pipe A FIFO underrun info: DBUF below WM0 on planes: [1] [ +0.000004] xe 0000:00:02.0: [drm] *ERROR* Pipe A FIFO underrun info: frame count: 1890, line count: 44 --- .../gpu/drm/i915/display/intel_display_device.h | 1 + drivers/gpu/drm/i915/display/intel_display_regs.h | 16 +++ drivers/gpu/drm/i915/display/intel_fbc_regs.h | 2 + drivers/gpu/drm/i915/display/intel_fifo_underrun.c | 128 +++++++++++++++++++++ 4 files changed, 147 insertions(+)drivers/gpu/drm/i915/display/intel_display_device.h +1
-0@@ -197,6 +197,7 @@ struct intel_display_platforms {#define HAS_TRANSCODER (__display, trans) ((DISPLAY_RUNTIME_INFO(__display)->cpu_transcoder_mask & \ BIT(trans)) != 0)#define HAS_UNCOMPRESSED_JOINER (__display) (DISPLAY_VER(__display) >= 13) +#define HAS_UNDERRUN_DBG_INFO (__display) (DISPLAY_VER(__display) >= 35)#define HAS_ULTRAJOINER (__display) (((__display)->platform.dgfx && \ DISPLAY_VER(__display) == 14) && HAS_DSC(__display))#define HAS_VRR (__display) (DISPLAY_VER(__display) >= 11)drivers/gpu/drm/i915/display/intel_display_regs.h +16
-0@@ -882,6 +882,21 @@#define PIPE_MISC2_FLIP_INFO_PLANE_SEL_MASK REG_GENMASK(2, 0)/* tgl+ */ #define PIPE_MISC2_FLIP_INFO_PLANE_SEL (plane_id) REG_FIELD_PREP(PIPE_MISC2_FLIP_INFO_PLANE_SEL_MASK, (plane_id)) +#define _UNDERRUN_DBG1_A 0x70064 +#define _UNDERRUN_DBG1_B 0x71064 +#define UNDERRUN_DBG1 (pipe) _MMIO_PIPE(pipe, _UNDERRUN_DBG1_A, _UNDERRUN_DBG1_B) +#define UNDERRUN_DBUF_BLOCK_NOT_VALID_MASK REG_GENMASK(29, 24) +#define UNDERRUN_DDB_EMPTY_MASK REG_GENMASK(21, 16) +#define UNDERRUN_DBUF_NOT_FILLED_MASK REG_GENMASK(13, 8) +#define UNDERRUN_BELOW_WM0_MASK REG_GENMASK(5, 0) + +#define _UNDERRUN_DBG2_A 0x70068 +#define _UNDERRUN_DBG2_B 0x71068 +#define UNDERRUN_DBG2 (pipe) _MMIO_PIPE(pipe, _UNDERRUN_DBG2_A, _UNDERRUN_DBG2_B) +#define UNDERRUN_FRAME_LINE_COUNTERS_FROZEN REG_BIT(31) +#define UNDERRUN_PIPE_FRAME_COUNT_MASK REG_GENMASK(30, 20) +#define UNDERRUN_LINE_COUNT_MASK REG_GENMASK(19, 0) +#define DPINVGTT _MMIO(VLV_DISPLAY_BASE + 0x7002c)/* VLV/CHV only */ #define DPINVGTT_EN_MASK_CHV REG_GENMASK(27, 16)#define DPINVGTT_EN_MASK_VLV REG_GENMASK(23, 16)@@ -1416,6 +1431,7 @@#define GEN12_DCPR_STATUS_1 _MMIO(0x46440)#define XELPDP_PMDEMAND_INFLIGHT_STATUS REG_BIT(26) +#define XE3P_UNDERRUN_PKGC REG_BIT(21)#define FUSE_STRAP _MMIO(0x42014)#define ILK_INTERNAL_GRAPHICS_DISABLE REG_BIT(31)drivers/gpu/drm/i915/display/intel_fbc_regs.h +2
-0@@ -88,6 +88,8 @@#define DPFC_FENCE_YOFF _MMIO(0x3218)#define ILK_DPFC_FENCE_YOFF (fbc_id) _MMIO_PIPE((fbc_id), 0x43218, 0x43258)#define DPFC_CHICKEN _MMIO(0x3224) +#define FBC_DEBUG_STATUS (fbc_id) _MMIO_PIPE((fbc_id), 0x43220, 0x43260) +#define FBC_UNDERRUN_DECMPR REG_BIT(27)#define ILK_DPFC_CHICKEN (fbc_id) _MMIO_PIPE((fbc_id), 0x43224, 0x43264)#define DPFC_HT_MODIFY REG_BIT(31)/* pre-ivb */ #define DPFC_NUKE_ON_ANY_MODIFICATION REG_BIT(23)/* bdw+ */ drivers/gpu/drm/i915/display/intel_fifo_underrun.c +3
-0@@ -25,6 +25,8 @@* */ +#include <linux/seq_buf.h> +#include <drm/drm_print.h> #include "i915_reg.h" @@ -34,6 +36,7 @@#include "intel_display_trace.h" #include "intel_display_types.h" #include "intel_fbc.h" +#include "intel_fbc_regs.h" #include "intel_fifo_underrun.h" #include "intel_pch_display.h" @@ -57,6 +60,118 @@* The code also supports underrun detection on the PCH transcoder. */ Quoted 10 lines
drivers/gpu/drm/i915/display/intel_fifo_underrun.c line 67
Quoted 5 lines
drivers/gpu/drm/i915/display/intel_fifo_underrun.c +5
-0+#define UNDERRUN_DBG1_NUM_PLANES 6 + +static void read_underrun_dbg1 (struct intel_display *display,enum pipe pipe,bool log) +{ +u32 val =intel_de_read (display,UNDERRUN_DBG1 (pipe));Nitpick, I really don't like the style of using "functional" (for want of a better word) initializers. Complicated is fine, like below for masks[], but doing something with the hardware or something that can fail, feels iffy.
Quoted 18 lines
Alright. I'll update this to do as you suggested below. One little annoyance is that we will need to open code
REG_FIELD_GET()(as done in [1]), because the mask parameter needs to be a constant expression.[1] https://lore.kernel.org/all/[email protected]/
Quoted 12 lines
Quoted 12 lines
drivers/gpu/drm/i915/display/intel_fifo_underrun.c +11
-0+struct { +u32 plane_mask; +const char *info; + } masks[] = { + {REG_FIELD_GET (UNDERRUN_DBUF_BLOCK_NOT_VALID_MASK , val),"DBUF block not valid" }, + {REG_FIELD_GET (UNDERRUN_DDB_EMPTY_MASK , val),"DDB empty" }, + {REG_FIELD_GET (UNDERRUN_DBUF_NOT_FILLED_MASK , val),"DBUF not completely filled" }, + {REG_FIELD_GET (UNDERRUN_BELOW_WM0_MASK , val),"DBUF below WM0" }, + }; +DECLARE_SEQ_BUF (planes_desc,32 ); +Mmh, right, I didn't even spot that val was being used in the masks[] initialization.
Here's a completely different approach that avoids some of the problems. I'm not sure if it's better or worse, just different. Two lines shorter than the original.
static void log_underrun_dbg(struct
intel_display*display, unsigned longplane_mask,
enum pipe pipe, const char *info){ DECLARE_SEQ_BUF(planes_desc, 32); unsigned int i; if (!plane_mask) return; for_each_set_bit(i, &plane_mask, UNDERRUN_DBG1_NUM_PLANES) { if (i == 0) seq_buf_puts(&planes_desc, "[C]"); else seq_buf_printf(&planes_desc, "[%d]", i); } drm_err(display->drm, "Pipe %c FIFO underrun info: %s on planes: %s\n", pipe_name(pipe), info, seq_buf_str(&planes_desc)); drm_WARN_ON(display->drm, seq_buf_has_overflowed(&planes_desc)); }static void
read_underrun_dbg1(struct intel_display *display, enum pipe pipe, bool log){ u32 val = intel_de_read(display, UNDERRUN_DBG1(pipe)); if (!val) return; intel_de_write(display, UNDERRUN_DBG1(pipe), val); if (!log) return; log_underrun_dbg(display, REG_FIELD_GET(UNDERRUN_DBUF_BLOCK_NOT_VALID_MASK, val),
Quoted 8 lines
pipe, "DBUF block not valid");
log_underrun_dbg(display, REG_FIELD_GET(UNDERRUN_DDB_EMPTY_MASK, val),
pipe, "DDB empty");
log_underrun_dbg(display, REG_FIELD_GET(UNDERRUN_DBUF_NOT_FILLED_MASK, val),
pipe, "DBUF not completely filled");
log_underrun_dbg(display, REG_FIELD_GET(UNDERRUN_BELOW_WM0_MASK, val),
pipe, "DBUF below WM0");
}I like this approach! I'll use it. Thanks! :-)
Quoted 32 lines
Quoted 32 lines
Quoted 9 lines
IMO there's also a lot more clarity in having the assignment and the check back to back here:
val = intel_de_read(display, UNDERRUN_DBG1(pipe)); if (!val) return;Ditto below.
I'll update those as well.
That said, for curiosity:
Do you prefer to always use the pattern of declaring a variable for register values and assigning the result of the reading as separate statements? Or is this a preference for specific cases, like this one?
I did
git grep -W 'u32\s\+\w\+\s*=\s*intel_de_read' -- drivers/gpu/drm/i915/display/and found cases where the pattern "u32 val =
intel_de_read(...)" appears to make the code a bit more concise IMO.While here in
read_underrun_dbg1()the other variables and initializers do get in the way of readability/clarity, I see cases like:u32 val = intel_de_read(...); do_something_with(val);
Quoted 7 lines
Quoted 1 line
to be still clear, and each saves up 1 line of editor real estate.
Yeah, I guess it's a bit hard to have hard rules, and in small functions or blocks it's fine to combine. Let's maybe file this under a knee-jerk reaction to
read_underrun_dbg1()where there's a bunch of declarations, and the actual code starts with if (!val) and you're like where did that come from. The other functions appear small enough. Fair?
Sounds good to me!
Thanks.
--
Gustavo Sousa
Quoted 145 lines
BR,
Jani.Quoted 138 lines
--
Gustavo SousaQuoted 134 lines
BR,
Jani.Quoted 126 lines
drivers/gpu/drm/i915/display/intel_fifo_underrun.c +109
-0+if (!val) +return ; + +intel_de_write (display,UNDERRUN_DBG1 (pipe), val); + +if (!log) +return ; + +for (int i =0 ; i <ARRAY_SIZE (masks); i++) { +if (!masks[i].plane_mask) +continue ; + +seq_buf_clear (&planes_desc); + +for (int j =0 ; j <UNDERRUN_DBG1_NUM_PLANES ; j++) { +if (!(masks[i].plane_mask ®_BIT (j))) +continue ; + +if (j ==0 ) +seq_buf_puts (&planes_desc,"[C]" ); +else +seq_buf_printf (&planes_desc,"[%d]" , j); + } + +drm_err (display->drm, +"Pipe %c FIFO underrun info: %s on planes: %s\n" , +pipe_name (pipe), masks[i].info,seq_buf_str (&planes_desc)); + +drm_WARN_ON (display->drm,seq_buf_has_overflowed (&planes_desc)); + } +} + +static void read_underrun_dbg2 (struct intel_display *display,enum pipe pipe,bool log) +{ +u32 val =intel_de_read (display,UNDERRUN_DBG2 (pipe)); + +if (!(val &UNDERRUN_FRAME_LINE_COUNTERS_FROZEN )) +return ; + +intel_de_write (display,UNDERRUN_DBG2 (pipe),UNDERRUN_FRAME_LINE_COUNTERS_FROZEN ); + +if (log) +drm_err (display->drm, +"Pipe %c FIFO underrun info: frame count: %u, line count: %u\n" , +pipe_name (pipe), +REG_FIELD_GET (UNDERRUN_PIPE_FRAME_COUNT_MASK , val), +REG_FIELD_GET (UNDERRUN_LINE_COUNT_MASK , val)); +} + +static void read_underrun_dbg_fbc (struct intel_display *display,enum pipe pipe,bool log) +{ +enum intel_fbc_id fbc_id =intel_fbc_id_for_pipe (pipe); +u32 val =intel_de_read (display,FBC_DEBUG_STATUS (fbc_id)); + +if (!(val &FBC_UNDERRUN_DECMPR )) +return ; + +intel_de_write (display,FBC_DEBUG_STATUS (fbc_id),FBC_UNDERRUN_DECMPR ); + +if (log) +drm_err (display->drm, +"Pipe %c FIFO underrun info: FBC decompressing\n" , +pipe_name (pipe)); +} + +static void read_underrun_dbg_pkgc (struct intel_display *display,bool log) +{ +u32 val =intel_de_read (display,GEN12_DCPR_STATUS_1 ); + +if (!(val &XE3P_UNDERRUN_PKGC )) +return ; + +/* +* Note: If there are multiple pipes enabled, only one of them will see +* XE3P_UNDERRUN_PKGC set. +*/ +intel_de_write (display,GEN12_DCPR_STATUS_1 ,XE3P_UNDERRUN_PKGC ); + +if (log) +drm_err (display->drm, +"General FIFO underrun info: Package C-state blocking memory\n" ); +} + +static void read_underrun_dbg_info (struct intel_display *display, +enum pipe pipe, +bool log) +{ +if (!HAS_UNDERRUN_DBG_INFO (display)) +return ; + +read_underrun_dbg1 (display, pipe, log); +read_underrun_dbg2 (display, pipe, log); +read_underrun_dbg_fbc (display, pipe, log); +read_underrun_dbg_pkgc (display, log); +} +static bool ivb_can_enable_err_int (struct intel_display *display) {struct intel_crtc *crtc;@@ -262,6 +377,17 @@ static bool __intel_set_cpu_fifo_underrun_reporting(struct intel_display *displa old = !crtc->cpu_fifo_underrun_disabled; crtc->cpu_fifo_underrun_disabled = !enable; +/* +* The debug bits get latched at the time of the FIFO underrun ISR bit +* getting set. That means that any existing debug bit that is set when +* handling a FIFO underrun interrupt has the potential to belong to +* another underrun event (past or future). To alleviate this problem, +* let's clear existing bits before enabling the interrupt, so that at +* least we don't get information that is too out-of-date. +*/ +if (enable && !old) +read_underrun_dbg_info (display, pipe, false); +if (HAS_GMCH (display))i9xx_set_fifo_underrun_reporting (display, pipe, enable, old);else if (display->platform.ironlake || display->platform.sandybridge)@@ -379,6 +505,8 @@ void intel_cpu_fifo_underrun_irq_handler(struct intel_display *display,trace_intel_cpu_fifo_underrun (display, pipe);drm_err (display->drm,"CPU pipe %c FIFO underrun\n" ,pipe_name (pipe)); + +read_underrun_dbg_info (display, pipe, true); }intel_fbc_handle_fifo_underrun_irq (display);Signature · 1 line
Jani Nikula, IntelSignature · 1 line
Jani Nikula, Intel
Re: [PATCH v4 06/11] drm/i915/xe3p_lpd: Handle underrun debug bits
In reply to Gustavo SousaQuoted 185 lines · Gustavo Sousa
Xe3p_LPDadded several bits containing information that can be relevant to debugging FIFO underruns. Add the logic necessary to handle them when reporting underruns.This was adapted from the initial patch[1] from Sai Teja Pottumuttu.
[1] https://lore.kernel.org/all/[email protected]/
Bspec: 69111, 69561, 74411, 74412
Cc Jani Nikula <[email protected]>Cc Matt Roper <[email protected]>Cc Ville Syrjälä <[email protected]>Signed-off-by Gustavo Sousa <[email protected]>---
I tested this by adding a change on top of this series that updates Xe3p_LPD's CDCLK table to use bad values and I got the following messages:[ +0.000237] xe 0000:00:02.0: [drm:intel_modeset_verify_crtc [xe]] [CRTC:88:pipe A] [ +0.000674] xe 0000:00:02.0: [drm] *ERROR* CPU pipe A FIFO underrun [ +0.000015] xe 0000:00:02.0: [drm] *ERROR* Pipe A FIFO underrun info: DBUF block not valid on planes: [1] [ +0.000001] xe 0000:00:02.0: [drm] *ERROR* Pipe A FIFO underrun info: DDB empty on planes: [1] [ +0.000001] xe 0000:00:02.0: [drm] *ERROR* Pipe A FIFO underrun info: DBUF below WM0 on planes: [1] [ +0.000004] xe 0000:00:02.0: [drm] *ERROR* Pipe A FIFO underrun info: frame count: 1890, line count: 44 --- .../gpu/drm/i915/display/intel_display_device.h | 1 + drivers/gpu/drm/i915/display/intel_display_regs.h | 16 +++ drivers/gpu/drm/i915/display/intel_fbc_regs.h | 2 + drivers/gpu/drm/i915/display/intel_fifo_underrun.c | 128 +++++++++++++++++++++ 4 files changed, 147 insertions(+)drivers/gpu/drm/i915/display/intel_display_device.h +1
-0@@ -197,6 +197,7 @@ struct intel_display_platforms {#define HAS_TRANSCODER (__display, trans) ((DISPLAY_RUNTIME_INFO(__display)->cpu_transcoder_mask & \ BIT(trans)) != 0)#define HAS_UNCOMPRESSED_JOINER (__display) (DISPLAY_VER(__display) >= 13) +#define HAS_UNDERRUN_DBG_INFO (__display) (DISPLAY_VER(__display) >= 35)#define HAS_ULTRAJOINER (__display) (((__display)->platform.dgfx && \ DISPLAY_VER(__display) == 14) && HAS_DSC(__display))#define HAS_VRR (__display) (DISPLAY_VER(__display) >= 11)drivers/gpu/drm/i915/display/intel_display_regs.h +16
-0@@ -882,6 +882,21 @@#define PIPE_MISC2_FLIP_INFO_PLANE_SEL_MASK REG_GENMASK(2, 0)/* tgl+ */ #define PIPE_MISC2_FLIP_INFO_PLANE_SEL (plane_id) REG_FIELD_PREP(PIPE_MISC2_FLIP_INFO_PLANE_SEL_MASK, (plane_id)) +#define _UNDERRUN_DBG1_A 0x70064 +#define _UNDERRUN_DBG1_B 0x71064 +#define UNDERRUN_DBG1 (pipe) _MMIO_PIPE(pipe, _UNDERRUN_DBG1_A, _UNDERRUN_DBG1_B) +#define UNDERRUN_DBUF_BLOCK_NOT_VALID_MASK REG_GENMASK(29, 24) +#define UNDERRUN_DDB_EMPTY_MASK REG_GENMASK(21, 16) +#define UNDERRUN_DBUF_NOT_FILLED_MASK REG_GENMASK(13, 8) +#define UNDERRUN_BELOW_WM0_MASK REG_GENMASK(5, 0) + +#define _UNDERRUN_DBG2_A 0x70068 +#define _UNDERRUN_DBG2_B 0x71068 +#define UNDERRUN_DBG2 (pipe) _MMIO_PIPE(pipe, _UNDERRUN_DBG2_A, _UNDERRUN_DBG2_B) +#define UNDERRUN_FRAME_LINE_COUNTERS_FROZEN REG_BIT(31) +#define UNDERRUN_PIPE_FRAME_COUNT_MASK REG_GENMASK(30, 20) +#define UNDERRUN_LINE_COUNT_MASK REG_GENMASK(19, 0) +#define DPINVGTT _MMIO(VLV_DISPLAY_BASE + 0x7002c)/* VLV/CHV only */ #define DPINVGTT_EN_MASK_CHV REG_GENMASK(27, 16)#define DPINVGTT_EN_MASK_VLV REG_GENMASK(23, 16)@@ -1416,6 +1431,7 @@#define GEN12_DCPR_STATUS_1 _MMIO(0x46440)#define XELPDP_PMDEMAND_INFLIGHT_STATUS REG_BIT(26) +#define XE3P_UNDERRUN_PKGC REG_BIT(21)#define FUSE_STRAP _MMIO(0x42014)#define ILK_INTERNAL_GRAPHICS_DISABLE REG_BIT(31)drivers/gpu/drm/i915/display/intel_fbc_regs.h +2
-0@@ -88,6 +88,8 @@#define DPFC_FENCE_YOFF _MMIO(0x3218)#define ILK_DPFC_FENCE_YOFF (fbc_id) _MMIO_PIPE((fbc_id), 0x43218, 0x43258)#define DPFC_CHICKEN _MMIO(0x3224) +#define FBC_DEBUG_STATUS (fbc_id) _MMIO_PIPE((fbc_id), 0x43220, 0x43260) +#define FBC_UNDERRUN_DECMPR REG_BIT(27)#define ILK_DPFC_CHICKEN (fbc_id) _MMIO_PIPE((fbc_id), 0x43224, 0x43264)#define DPFC_HT_MODIFY REG_BIT(31)/* pre-ivb */ #define DPFC_NUKE_ON_ANY_MODIFICATION REG_BIT(23)/* bdw+ */ drivers/gpu/drm/i915/display/intel_fifo_underrun.c +73
-0@@ -25,6 +25,8 @@* */ +#include <linux/seq_buf.h> +#include <drm/drm_print.h> #include "i915_reg.h" @@ -34,6 +36,7 @@#include "intel_display_trace.h" #include "intel_display_types.h" #include "intel_fbc.h" +#include "intel_fbc_regs.h" #include "intel_fifo_underrun.h" #include "intel_pch_display.h" @@ -57,6 +60,118 @@* The code also supports underrun detection on the PCH transcoder. */ +#define UNDERRUN_DBG1_NUM_PLANES 6 + +static void read_underrun_dbg1 (struct intel_display *display,enum pipe pipe,bool log) +{ +u32 val =intel_de_read (display,UNDERRUN_DBG1 (pipe)); +struct { +u32 plane_mask; +const char *info; + } masks[] = { + {REG_FIELD_GET (UNDERRUN_DBUF_BLOCK_NOT_VALID_MASK , val),"DBUF block not valid" }, + {REG_FIELD_GET (UNDERRUN_DDB_EMPTY_MASK , val),"DDB empty" }, + {REG_FIELD_GET (UNDERRUN_DBUF_NOT_FILLED_MASK , val),"DBUF not completely filled" }, + {REG_FIELD_GET (UNDERRUN_BELOW_WM0_MASK , val),"DBUF below WM0" }, + }; +DECLARE_SEQ_BUF (planes_desc,32 ); + +if (!val) +return ; + +intel_de_write (display,UNDERRUN_DBG1 (pipe), val); + +if (!log) +return ; + +for (int i =0 ; i <ARRAY_SIZE (masks); i++) { +if (!masks[i].plane_mask) +continue ; + +seq_buf_clear (&planes_desc); + +for (int j =0 ; j <UNDERRUN_DBG1_NUM_PLANES ; j++) { +if (!(masks[i].plane_mask ®_BIT (j))) +continue ; + +if (j ==0 ) +seq_buf_puts (&planes_desc,"[C]" ); +else +seq_buf_printf (&planes_desc,"[%d]" , j); + } + +drm_err (display->drm, +"Pipe %c FIFO underrun info: %s on planes: %s\n" , +pipe_name (pipe), masks[i].info,seq_buf_str (&planes_desc)); + +drm_WARN_ON (display->drm,seq_buf_has_overflowed (&planes_desc)); + } +} + +static void read_underrun_dbg2 (struct intel_display *display,enum pipe pipe,bool log) +{ +u32 val =intel_de_read (display,UNDERRUN_DBG2 (pipe)); + +if (!(val &UNDERRUN_FRAME_LINE_COUNTERS_FROZEN )) +return ; + +intel_de_write (display,UNDERRUN_DBG2 (pipe),UNDERRUN_FRAME_LINE_COUNTERS_FROZEN ); + +if (log) +drm_err (display->drm, +"Pipe %c FIFO underrun info: frame count: %u, line count: %u\n" , +pipe_name (pipe), +REG_FIELD_GET (UNDERRUN_PIPE_FRAME_COUNT_MASK , val), +REG_FIELD_GET (UNDERRUN_LINE_COUNT_MASK , val)); +} + +static void read_underrun_dbg_fbc (struct intel_display *display,enum pipe pipe,bool log) +{ +enum intel_fbc_id fbc_id =intel_fbc_id_for_pipe (pipe); +u32 val =intel_de_read (display,FBC_DEBUG_STATUS (fbc_id)); +
drivers/gpu/drm/i915/display/intel_fifo_underrun.c line 142
Quoted 10 lines
drivers/gpu/drm/i915/display/intel_fifo_underrun.c +10
-0+if (!(val &FBC_UNDERRUN_DECMPR )) +return ; + +intel_de_write (display,FBC_DEBUG_STATUS (fbc_id),FBC_UNDERRUN_DECMPR ); + +if (log) +drm_err (display->drm, +"Pipe %c FIFO underrun info: FBC decompressing\n" , +pipe_name (pipe)); +}
FBC code belongs in intel_fbc.c
Quoted 65 lines
drivers/gpu/drm/i915/display/intel_fifo_underrun.c +45
-0+ +static void read_underrun_dbg_pkgc (struct intel_display *display,bool log) +{ +u32 val =intel_de_read (display,GEN12_DCPR_STATUS_1 ); + +if (!(val &XE3P_UNDERRUN_PKGC )) +return ; + +/* +* Note: If there are multiple pipes enabled, only one of them will see +* XE3P_UNDERRUN_PKGC set. +*/ +intel_de_write (display,GEN12_DCPR_STATUS_1 ,XE3P_UNDERRUN_PKGC ); + +if (log) +drm_err (display->drm, +"General FIFO underrun info: Package C-state blocking memory\n" ); +} + +static void read_underrun_dbg_info (struct intel_display *display, +enum pipe pipe, +bool log) +{ +if (!HAS_UNDERRUN_DBG_INFO (display)) +return ; + +read_underrun_dbg1 (display, pipe, log); +read_underrun_dbg2 (display, pipe, log); +read_underrun_dbg_fbc (display, pipe, log); +read_underrun_dbg_pkgc (display, log); +} +static bool ivb_can_enable_err_int (struct intel_display *display) {struct intel_crtc *crtc;@@ -262,6 +377,17 @@ static bool __intel_set_cpu_fifo_underrun_reporting(struct intel_display *displa old = !crtc->cpu_fifo_underrun_disabled; crtc->cpu_fifo_underrun_disabled = !enable; +/* +* The debug bits get latched at the time of the FIFO underrun ISR bit +* getting set. That means that any existing debug bit that is set when +* handling a FIFO underrun interrupt has the potential to belong to +* another underrun event (past or future). To alleviate this problem, +* let's clear existing bits before enabling the interrupt, so that at +* least we don't get information that is too out-of-date. +*/ +if (enable && !old) +read_underrun_dbg_info (display, pipe, false); +if (HAS_GMCH (display))i9xx_set_fifo_underrun_reporting (display, pipe, enable, old);else if (display->platform.ironlake || display->platform.sandybridge)@@ -379,6 +505,8 @@ void intel_cpu_fifo_underrun_irq_handler(struct intel_display *display,trace_intel_cpu_fifo_underrun (display, pipe);drm_err (display->drm,"CPU pipe %c FIFO underrun\n" ,pipe_name (pipe)); + +read_underrun_dbg_info (display, pipe, true); }intel_fbc_handle_fifo_underrun_irq (display);Signature · 2 lines
-- 2.51.0
Signature · 2 lines
Ville Syrjälä Intel
Re: [PATCH v4 06/11] drm/i915/xe3p_lpd: Handle underrun debug bits
Quoting Ville Syrjälä (2025-11-10 14:03:44-03:00)
Quoted 190 lines · Gustavo Sousa
Quoted 189 lines
Xe3p_LPDadded several bits containing information that can be relevant to debugging FIFO underruns. Add the logic necessary to handle them when reporting underruns.This was adapted from the initial patch[1] from Sai Teja Pottumuttu.
[1] https://lore.kernel.org/all/[email protected]/
Bspec: 69111, 69561, 74411, 74412
Cc Jani Nikula <[email protected]>Cc Matt Roper <[email protected]>Cc Ville Syrjälä <[email protected]>Signed-off-by Gustavo Sousa <[email protected]>---
I tested this by adding a change on top of this series that updates Xe3p_LPD's CDCLK table to use bad values and I got the following messages:[ +0.000237] xe 0000:00:02.0: [drm:intel_modeset_verify_crtc [xe]] [CRTC:88:pipe A] [ +0.000674] xe 0000:00:02.0: [drm] *ERROR* CPU pipe A FIFO underrun [ +0.000015] xe 0000:00:02.0: [drm] *ERROR* Pipe A FIFO underrun info: DBUF block not valid on planes: [1] [ +0.000001] xe 0000:00:02.0: [drm] *ERROR* Pipe A FIFO underrun info: DDB empty on planes: [1] [ +0.000001] xe 0000:00:02.0: [drm] *ERROR* Pipe A FIFO underrun info: DBUF below WM0 on planes: [1] [ +0.000004] xe 0000:00:02.0: [drm] *ERROR* Pipe A FIFO underrun info: frame count: 1890, line count: 44 --- .../gpu/drm/i915/display/intel_display_device.h | 1 + drivers/gpu/drm/i915/display/intel_display_regs.h | 16 +++ drivers/gpu/drm/i915/display/intel_fbc_regs.h | 2 + drivers/gpu/drm/i915/display/intel_fifo_underrun.c | 128 +++++++++++++++++++++ 4 files changed, 147 insertions(+)drivers/gpu/drm/i915/display/intel_display_device.h +1
-0@@ -197,6 +197,7 @@ struct intel_display_platforms {#define HAS_TRANSCODER (__display, trans) ((DISPLAY_RUNTIME_INFO(__display)->cpu_transcoder_mask & \ BIT(trans)) != 0)#define HAS_UNCOMPRESSED_JOINER (__display) (DISPLAY_VER(__display) >= 13) +#define HAS_UNDERRUN_DBG_INFO (__display) (DISPLAY_VER(__display) >= 35)#define HAS_ULTRAJOINER (__display) (((__display)->platform.dgfx && \ DISPLAY_VER(__display) == 14) && HAS_DSC(__display))#define HAS_VRR (__display) (DISPLAY_VER(__display) >= 11)drivers/gpu/drm/i915/display/intel_display_regs.h +16
-0@@ -882,6 +882,21 @@#define PIPE_MISC2_FLIP_INFO_PLANE_SEL_MASK REG_GENMASK(2, 0)/* tgl+ */ #define PIPE_MISC2_FLIP_INFO_PLANE_SEL (plane_id) REG_FIELD_PREP(PIPE_MISC2_FLIP_INFO_PLANE_SEL_MASK, (plane_id)) +#define _UNDERRUN_DBG1_A 0x70064 +#define _UNDERRUN_DBG1_B 0x71064 +#define UNDERRUN_DBG1 (pipe) _MMIO_PIPE(pipe, _UNDERRUN_DBG1_A, _UNDERRUN_DBG1_B) +#define UNDERRUN_DBUF_BLOCK_NOT_VALID_MASK REG_GENMASK(29, 24) +#define UNDERRUN_DDB_EMPTY_MASK REG_GENMASK(21, 16) +#define UNDERRUN_DBUF_NOT_FILLED_MASK REG_GENMASK(13, 8) +#define UNDERRUN_BELOW_WM0_MASK REG_GENMASK(5, 0) + +#define _UNDERRUN_DBG2_A 0x70068 +#define _UNDERRUN_DBG2_B 0x71068 +#define UNDERRUN_DBG2 (pipe) _MMIO_PIPE(pipe, _UNDERRUN_DBG2_A, _UNDERRUN_DBG2_B) +#define UNDERRUN_FRAME_LINE_COUNTERS_FROZEN REG_BIT(31) +#define UNDERRUN_PIPE_FRAME_COUNT_MASK REG_GENMASK(30, 20) +#define UNDERRUN_LINE_COUNT_MASK REG_GENMASK(19, 0) +#define DPINVGTT _MMIO(VLV_DISPLAY_BASE + 0x7002c)/* VLV/CHV only */ #define DPINVGTT_EN_MASK_CHV REG_GENMASK(27, 16)#define DPINVGTT_EN_MASK_VLV REG_GENMASK(23, 16)@@ -1416,6 +1431,7 @@#define GEN12_DCPR_STATUS_1 _MMIO(0x46440)#define XELPDP_PMDEMAND_INFLIGHT_STATUS REG_BIT(26) +#define XE3P_UNDERRUN_PKGC REG_BIT(21)#define FUSE_STRAP _MMIO(0x42014)#define ILK_INTERNAL_GRAPHICS_DISABLE REG_BIT(31)drivers/gpu/drm/i915/display/intel_fbc_regs.h +2
-0@@ -88,6 +88,8 @@#define DPFC_FENCE_YOFF _MMIO(0x3218)#define ILK_DPFC_FENCE_YOFF (fbc_id) _MMIO_PIPE((fbc_id), 0x43218, 0x43258)#define DPFC_CHICKEN _MMIO(0x3224) +#define FBC_DEBUG_STATUS (fbc_id) _MMIO_PIPE((fbc_id), 0x43220, 0x43260) +#define FBC_UNDERRUN_DECMPR REG_BIT(27)#define ILK_DPFC_CHICKEN (fbc_id) _MMIO_PIPE((fbc_id), 0x43224, 0x43264)#define DPFC_HT_MODIFY REG_BIT(31)/* pre-ivb */ #define DPFC_NUKE_ON_ANY_MODIFICATION REG_BIT(23)/* bdw+ */ drivers/gpu/drm/i915/display/intel_fifo_underrun.c +77
-0@@ -25,6 +25,8 @@* */ +#include <linux/seq_buf.h> +#include <drm/drm_print.h> #include "i915_reg.h" @@ -34,6 +36,7 @@#include "intel_display_trace.h" #include "intel_display_types.h" #include "intel_fbc.h" +#include "intel_fbc_regs.h" #include "intel_fifo_underrun.h" #include "intel_pch_display.h" @@ -57,6 +60,118 @@* The code also supports underrun detection on the PCH transcoder. */ +#define UNDERRUN_DBG1_NUM_PLANES 6 + +static void read_underrun_dbg1 (struct intel_display *display,enum pipe pipe,bool log) +{ +u32 val =intel_de_read (display,UNDERRUN_DBG1 (pipe)); +struct { +u32 plane_mask; +const char *info; + } masks[] = { + {REG_FIELD_GET (UNDERRUN_DBUF_BLOCK_NOT_VALID_MASK , val),"DBUF block not valid" }, + {REG_FIELD_GET (UNDERRUN_DDB_EMPTY_MASK , val),"DDB empty" }, + {REG_FIELD_GET (UNDERRUN_DBUF_NOT_FILLED_MASK , val),"DBUF not completely filled" }, + {REG_FIELD_GET (UNDERRUN_BELOW_WM0_MASK , val),"DBUF below WM0" }, + }; +DECLARE_SEQ_BUF (planes_desc,32 ); + +if (!val) +return ; + +intel_de_write (display,UNDERRUN_DBG1 (pipe), val); + +if (!log) +return ; + +for (int i =0 ; i <ARRAY_SIZE (masks); i++) { +if (!masks[i].plane_mask) +continue ; + +seq_buf_clear (&planes_desc); + +for (int j =0 ; j <UNDERRUN_DBG1_NUM_PLANES ; j++) { +if (!(masks[i].plane_mask ®_BIT (j))) +continue ; + +if (j ==0 ) +seq_buf_puts (&planes_desc,"[C]" ); +else +seq_buf_printf (&planes_desc,"[%d]" , j); + } + +drm_err (display->drm, +"Pipe %c FIFO underrun info: %s on planes: %s\n" , +pipe_name (pipe), masks[i].info,seq_buf_str (&planes_desc)); + +drm_WARN_ON (display->drm,seq_buf_has_overflowed (&planes_desc)); + } +} + +static void read_underrun_dbg2 (struct intel_display *display,enum pipe pipe,bool log) +{ +u32 val =intel_de_read (display,UNDERRUN_DBG2 (pipe)); + +if (!(val &UNDERRUN_FRAME_LINE_COUNTERS_FROZEN )) +return ; + +intel_de_write (display,UNDERRUN_DBG2 (pipe),UNDERRUN_FRAME_LINE_COUNTERS_FROZEN ); + +if (log) +drm_err (display->drm, +"Pipe %c FIFO underrun info: frame count: %u, line count: %u\n" , +pipe_name (pipe), +REG_FIELD_GET (UNDERRUN_PIPE_FRAME_COUNT_MASK , val), +REG_FIELD_GET (UNDERRUN_LINE_COUNT_MASK , val)); +} + +static void read_underrun_dbg_fbc (struct intel_display *display,enum pipe pipe,bool log) +{ +enum intel_fbc_id fbc_id =intel_fbc_id_for_pipe (pipe); +u32 val =intel_de_read (display,FBC_DEBUG_STATUS (fbc_id)); + +if (!(val &FBC_UNDERRUN_DECMPR )) +return ; + +intel_de_write (display,FBC_DEBUG_STATUS (fbc_id),FBC_UNDERRUN_DECMPR );
Quoted 8 lines
drivers/gpu/drm/i915/display/intel_fifo_underrun.c line 142
Quoted 6 lines
drivers/gpu/drm/i915/display/intel_fifo_underrun.c +6
-0+ +if (log) +drm_err (display->drm, +"Pipe %c FIFO underrun info: FBC decompressing\n" , +pipe_name (pipe)); +}FBC code belongs in
intel_fbc.c
Alright. Moving this to intel_fbc.c, then.
Thanks!
--
Gustavo Sousa
Quoted 70 lines
Quoted 66 lines
drivers/gpu/drm/i915/display/intel_fifo_underrun.c +45
-0+ +static void read_underrun_dbg_pkgc (struct intel_display *display,bool log) +{ +u32 val =intel_de_read (display,GEN12_DCPR_STATUS_1 ); + +if (!(val &XE3P_UNDERRUN_PKGC )) +return ; + +/* +* Note: If there are multiple pipes enabled, only one of them will see +* XE3P_UNDERRUN_PKGC set. +*/ +intel_de_write (display,GEN12_DCPR_STATUS_1 ,XE3P_UNDERRUN_PKGC ); + +if (log) +drm_err (display->drm, +"General FIFO underrun info: Package C-state blocking memory\n" ); +} + +static void read_underrun_dbg_info (struct intel_display *display, +enum pipe pipe, +bool log) +{ +if (!HAS_UNDERRUN_DBG_INFO (display)) +return ; + +read_underrun_dbg1 (display, pipe, log); +read_underrun_dbg2 (display, pipe, log); +read_underrun_dbg_fbc (display, pipe, log); +read_underrun_dbg_pkgc (display, log); +} +static bool ivb_can_enable_err_int (struct intel_display *display) {struct intel_crtc *crtc;@@ -262,6 +377,17 @@ static bool __intel_set_cpu_fifo_underrun_reporting(struct intel_display *displa old = !crtc->cpu_fifo_underrun_disabled; crtc->cpu_fifo_underrun_disabled = !enable; +/* +* The debug bits get latched at the time of the FIFO underrun ISR bit +* getting set. That means that any existing debug bit that is set when +* handling a FIFO underrun interrupt has the potential to belong to +* another underrun event (past or future). To alleviate this problem, +* let's clear existing bits before enabling the interrupt, so that at +* least we don't get information that is too out-of-date. +*/ +if (enable && !old) +read_underrun_dbg_info (display, pipe, false); +if (HAS_GMCH (display))i9xx_set_fifo_underrun_reporting (display, pipe, enable, old);else if (display->platform.ironlake || display->platform.sandybridge)@@ -379,6 +505,8 @@ void intel_cpu_fifo_underrun_irq_handler(struct intel_display *display,trace_intel_cpu_fifo_underrun (display, pipe);drm_err (display->drm,"CPU pipe %c FIFO underrun\n" ,pipe_name (pipe)); + +read_underrun_dbg_info (display, pipe, true); }intel_fbc_handle_fifo_underrun_irq (display);Signature · 2 lines
-- 2.51.0Signature · 2 lines
Ville Syrjälä Intel
PATCH v4 7/11 drm/i915/xe3p_lpd: Extend Type-C flow for static DDI allocation
In reply to Gustavo SousaXe3p_LPD has a new feature that allows the driver to allocate at runtime the DDI (TC ones) port to drive a legacy connection on the Type-C subsystem. This allows better resource utilization, because now there is no need to statically reserve ports for legacy connectors on the Type-C subsystem.
That said, our driver is not yet ready for the dynamic allocation. Thus, as an incremental step, let's add the logic containing the required programming sequence for the allocation, but, instead of selecting the first available port, we try so use the 1:1 mapping expected by the driver today.
Bspec: 68954
---
NOTE: This patch is still a WIP. There are some opens to resolve here. Nevertheless, I'm sending it here for early feedback.
For the HIP-index stuff, I have a local refactor started and need to finish it up and send it.
The other open is about concurrent calls to iom_dp_resource_lock(). It is likely that we need to have a software lock to prevent concurrent access to IOM_DP_HW_RESOURCE_SEMAPHORE from our driver.
--- drivers/gpu/drm/i915/display/intel_display_regs.h | 20 ++- drivers/gpu/drm/i915/display/intel_tc.c | 151 +++++++++++++++++++++- 2 files changed, 169 insertions(+), 2 deletions(-)
drivers/gpu/drm/i915/display/intel_display_regs.h +19 -1
@@ -2908,6 +2908,25 @@ enum skl_power_gate {#define DP_PIN_ASSIGNMENT (idx, x) ((x) << ((idx) * 4))/* See enum intel_tc_pin_assignment for the pin assignment field values. */ +/* +* FIXME: There is also a definition for this register in intel_dkl_phy_regs.h. +* We need to consolidate the definitions. +*/ +#define HIP_INDEX_REG0 _MMIO(0x1010a0) +#define HIP_168_INDEX_MASK REG_GENMASK(3, 0) +#define HIP_168_IOM_RES_MGMT REG_FIELD_PREP(HIP_168_INDEX_MASK, 0x1) + +#define IOM_DP_HW_RESOURCE_SEMAPHORE _MMIO(0x168038) +#define IOM_DP_HW_SEMLOCK REG_BIT(31) +#define IOM_REQUESTOR_ID_MASK REG_GENMASK(3, 0) +#define IOM_REQUESTOR_ID_DISPLAY_ENGINE REG_FIELD_PREP(IOM_REQUESTOR_ID_MASK, 0x4) + +#define IOM_DP_RESOURCE_MNG _MMIO(0x16802c) +#define IOM_DDI_CONSUMER_SHIFT (tc_port) ((tc_port) * 4) +#define IOM_DDI_CONSUMER_MASK (tc_port) (0xf << IOM_DDI_CONSUMER_SHIFT(tc_port)) +#define IOM_DDI_CONSUMER (tc_port, x) ((x) << IOM_DDI_CONSUMER_SHIFT(tc_port)) +#define IOM_DDI_CONSUMER_STATIC_TC (tc_port) IOM_DDI_CONSUMER(tc_port, 0x8 + (tc_port)) +#define _TCSS_DDI_STATUS_1 0x161500#define _TCSS_DDI_STATUS_2 0x161504#define TCSS_DDI_STATUS (tc) _MMIO(_PICK_EVEN(tc, \
@@ -2946,5 +2965,4 @@ enum skl_power_gate {#define MTL_TRDPRE_MASK REG_GENMASK(7, 0) -#endif /* __INTEL_DISPLAY_REGS_H__ */
drivers/gpu/drm/i915/display/intel_tc.c +150 -1
189 lines not on this page · raw message
Signature · 1 line
2.51.0
Re: [PATCH v4 07/11] drm/i915/xe3p_lpd: Extend Type-C flow for static DDI allocation
Quoted 48 lines · Gustavo Sousa
Xe3p_LPDhas a new feature that allows the driver to allocate at runtime the DDI (TC ones) port to drive a legacy connection on the Type-C subsystem. This allows better resource utilization, because now there is no need to statically reserve ports for legacy connectors on the Type-C subsystem.That said, our driver is not yet ready for the dynamic allocation. Thus, as an incremental step, let's add the logic containing the required programming sequence for the allocation, but, instead of selecting the first available port, we try so use the 1:1 mapping expected by the driver today.
Bspec: 68954
Co-developed-by Dnyaneshwar Bhadane <[email protected]>Signed-off-by Dnyaneshwar Bhadane <[email protected]>Signed-off-by Gustavo Sousa <[email protected]>---
NOTE: This patch is still a WIP. There are some opens to resolve here. Nevertheless, I'm sending it here for early feedback.
For the HIP-index stuff, I have a local refactor started and need to finish it up and send it.
The other open is about concurrent calls to
iom_dp_resource_lock(). It is likely that we need to have a software lock to prevent concurrent access toIOM_DP_HW_RESOURCE_SEMAPHOREfrom our driver.--- drivers/gpu/drm/i915/display/intel_display_regs.h | 20 ++- drivers/gpu/drm/i915/display/intel_tc.c | 151 +++++++++++++++++++++- 2 files changed, 169 insertions(+), 2 deletions(-)drivers/gpu/drm/i915/display/intel_display_regs.h +8
-0@@ -2908,6 +2908,25 @@ enum skl_power_gate {#define DP_PIN_ASSIGNMENT (idx, x) ((x) << ((idx) * 4))/* See enum intel_tc_pin_assignment for the pin assignment field values. */ +/* +* FIXME: There is also a definition for this register in intel_dkl_phy_regs.h. +* We need to consolidate the definitions. +*/ +#define HIP_INDEX_REG0 _MMIO(0x1010a0) +#define HIP_168_INDEX_MASK REG_GENMASK(3, 0) +#define HIP_168_IOM_RES_MGMT REG_FIELD_PREP(HIP_168_INDEX_MASK, 0x1) +
drivers/gpu/drm/i915/display/intel_display_regs.h enum skl_power_gate { · line 2928
Quoted 10 lines
drivers/gpu/drm/i915/display/intel_display_regs.h +10
-0+#define IOM_DP_HW_RESOURCE_SEMAPHORE _MMIO(0x168038) +#define IOM_DP_HW_SEMLOCK REG_BIT(31) +#define IOM_REQUESTOR_ID_MASK REG_GENMASK(3, 0) +#define IOM_REQUESTOR_ID_DISPLAY_ENGINE REG_FIELD_PREP(IOM_REQUESTOR_ID_MASK, 0x4) + +#define IOM_DP_RESOURCE_MNG _MMIO(0x16802c) +#define IOM_DDI_CONSUMER_SHIFT (tc_port) ((tc_port) * 4) +#define IOM_DDI_CONSUMER_MASK (tc_port) (0xf << IOM_DDI_CONSUMER_SHIFT(tc_port)) +#define IOM_DDI_CONSUMER (tc_port, x) ((x) << IOM_DDI_CONSUMER_SHIFT(tc_port)) +#define IOM_DDI_CONSUMER_STATIC_TC (tc_port) IOM_DDI_CONSUMER(tc_port, 0x8 + (tc_port))
It would be simpler to define the above without the shift, i.e. as 8 + tc_port.
Quoted 23 lines
drivers/gpu/drm/i915/display/intel_display_regs.h +1
-1+#define _TCSS_DDI_STATUS_1 0x161500#define _TCSS_DDI_STATUS_2 0x161504#define TCSS_DDI_STATUS (tc) _MMIO(_PICK_EVEN(tc, \@@ -2946,5 +2965,4 @@ enum skl_power_gate {#define MTL_TRDPRE_MASK REG_GENMASK(7, 0) -#endif /* __INTEL_DISPLAY_REGS_H__ */ drivers/gpu/drm/i915/display/intel_tc.c +1
-0@@ -9,6 +9,7 @@#include "i915_reg.h" #include "intel_atomic.h" +#include "intel_bios.h" #include "intel_cx0_phy_regs.h" #include "intel_ddi.h" #include "intel_de.h"
drivers/gpu/drm/i915/display/intel_tc.c line 30
Quoted 5 lines
drivers/gpu/drm/i915/display/intel_tc.c +2
-0@@ -25,6 +26,9 @@#include "intel_modeset_lock.h" #include "intel_tc.h" +#define IOM_DP_RES_SEMAPHORE_LOCK_TIMEOUT_US 10 +#define IOM_DP_RES_SEMAPHORE_RETRY_TIMEOUT_US 10000
The above param names should make it clear how poll_timeout_us() uses them (i.e. stg like sleep vs. timeout instead of lock_timeout vs. retry_timeout), but probably even clearer to just drop the defines and inline the values in the call.
Quoted 11 lines
drivers/gpu/drm/i915/display/intel_tc.c +4
-0+enum tc_port_mode {TC_PORT_DISCONNECTED ,TC_PORT_TBT_ALT ,@@ -1200,6 +1204,143 @@ static void xelpdp_tc_phy_get_hw_state(struct intel_tc_port *tc)__tc_cold_unblock (tc, domain, tc_cold_wref); } +static void iom_res_mgmt_prepare_reg_access (struct intel_display *display) +{ +/*
drivers/gpu/drm/i915/display/intel_tc.c static void xelpdp_tc_phy_get_hw_state(struct intel_tc_port *tc) · line 1219
Quoted 10 lines
drivers/gpu/drm/i915/display/intel_tc.c +10
-0+* IOM resource management registers live in the 2nd 4KB page of IOM +* address space. So we need to configure HIP_INDEX_REG0 with the +* correct index. +* +* FIXME: We need to have this and dekel PHY implementation using a +* common abstraction to access registers on the HIP-indexed ranges, and +* this function would then be dropped. +*/ +intel_de_rmw (display,HIP_INDEX_REG0 , +HIP_168_INDEX_MASK ,HIP_168_IOM_RES_MGMT );
This matches what intel_dkl_phy.c does, that one also taking the required lock around the access. At one point the intel_dkl_phy file/interface could be renamed to intel_tc_reg or similar accordingly.
Quoted 5 lines
drivers/gpu/drm/i915/display/intel_tc.c +5
-0+} + +/* +* FIXME: This function also needs to avoid concurrent accesses from the driver +* itself, possibly via a software lock.
drivers/gpu/drm/i915/display/intel_tc.c static void xelpdp_tc_phy_get_hw_state(struct intel_tc_port *tc) · line 1234
Quoted 10 lines
drivers/gpu/drm/i915/display/intel_tc.c +10
-0+*/ +static int iom_dp_resource_lock (struct intel_tc_port *tc) +{ +struct intel_display *display =to_intel_display (tc->dig_port); +u32 val =IOM_DP_HW_SEMLOCK |IOM_REQUESTOR_ID_DISPLAY_ENGINE ; +int ret; + +iom_res_mgmt_prepare_reg_access (display); + ret = poll_timeout_us(intel_de_write(display, IOM_DP_HW_RESOURCE_SEMAPHORE, val), + (intel_de_read(display, IOM_DP_HW_RESOURCE_SEMAPHORE) & val) == val,
This happens to work, but it's more future proof/bspec conformant to properly mask the requestor ID field when reading it back.
Quoted 25 lines
drivers/gpu/drm/i915/display/intel_tc.c +25
-0+IOM_DP_RES_SEMAPHORE_LOCK_TIMEOUT_US , + IOM_DP_RES_SEMAPHORE_RETRY_TIMEOUT_US, false); + +if (ret) +drm_err (display->drm,"Port %s: timeout trying to lock IOM semaphore\n" , + tc->port_name); + +return ret; +} + +static void iom_dp_resource_unlock (struct intel_tc_port *tc) +{ +struct intel_display *display =to_intel_display (tc->dig_port); + +iom_res_mgmt_prepare_reg_access (display); +intel_de_write (display,IOM_DP_HW_RESOURCE_SEMAPHORE ,IOM_REQUESTOR_ID_DISPLAY_ENGINE ); +} + +static bool xe3p_tc_iom_allocate_ddi (struct intel_tc_port *tc,bool allocate) +{ +struct intel_display *display =to_intel_display (tc->dig_port); +struct intel_digital_port *dig_port = tc->dig_port; +enum tc_port tc_port =intel_encoder_to_tc (&dig_port->base); +u32 val; +u32 consumer;
drivers/gpu/drm/i915/display/intel_tc.c static void xelpdp_tc_phy_get_hw_state(struct intel_tc_port *tc) · line 1269
Quoted 10 lines
drivers/gpu/drm/i915/display/intel_tc.c +10
-0+u32 expected_consumer; +bool ret; + +if (DISPLAY_VER (display) <35 ) +return true; + +if (tc->mode !=TC_PORT_LEGACY ) +return true; + +if (!intel_bios_encoder_supports_dyn_port_over_tc (dig_port->base.devdata))
dedicated_external is stored separately in dig_port, why the "related" dyn_port_over_tc flag isn't?
Quoted 78 lines
drivers/gpu/drm/i915/display/intel_tc.c +74
-0+return true; + +if (iom_dp_resource_lock (tc)) +return false; + + val =intel_de_read (display,IOM_DP_RESOURCE_MNG ); + + consumer = val &IOM_DDI_CONSUMER_MASK (tc_port); + consumer >>=IOM_DDI_CONSUMER_SHIFT (tc_port); + +/* +* Bspec instructs to select first available DDI, but our driver is not +* ready for such dynamic allocation yet. For now, we force a "static" +* allocation: map the physical port (where HPD happens) to the +* encoder's DDI (logical TC port, represented by tc_port). +*/ + expected_consumer =IOM_DDI_CONSUMER_STATIC_TC (tc_port); + expected_consumer >>=IOM_DDI_CONSUMER_SHIFT (tc_port); + +if (allocate) { +struct intel_encoder *other_encoder; + +/* +* Check if this encoder's DDI is already allocated for another +* physical port, which could have happened prior to the driver +* taking over (e.g. GOP). +*/ +for_each_intel_encoder (display->drm, other_encoder) { +enum tc_port other_tc_port =intel_encoder_to_tc (other_encoder); +u32 other_consumer; + +if (tc_port ==TC_PORT_NONE || other_tc_port == tc_port) +continue ; + + other_consumer = val &IOM_DDI_CONSUMER_MASK (other_tc_port); + other_consumer >>=IOM_DDI_CONSUMER_SHIFT (other_tc_port); +if (other_consumer == expected_consumer) { +drm_err (display->drm,"Port %s: expected consumer %u already allocated another DDI; IOM_DP_RESOURCE_MNG=0x%08x\n" , + tc->port_name, expected_consumer, val); + ret = false; + goto out_resource_unlock; + } + } + +if (consumer ==0 ) { +/* DDI is free to use, let's allocate it. */ + val &= ~IOM_DDI_CONSUMER_MASK (tc_port); + val |=IOM_DDI_CONSUMER (tc_port, expected_consumer); +intel_de_write (display,IOM_DP_RESOURCE_MNG , val); + ret = true; + }else if (consumer == expected_consumer) { +/* +* Nothing to do, as the expected "static" DDI allocation is +* already in place. +*/ + ret = true; + }else { +drm_err (display->drm,"Port %s: DDI already allocated for consumer %u; IOM_DP_RESOURCE_MNG=0x%08x\n" , + tc->port_name, consumer, val); + ret = false; + } + }else { +drm_WARN_ON (display->drm, consumer != expected_consumer); + val &= ~IOM_DDI_CONSUMER_MASK (tc_port); +intel_de_write (display,IOM_DP_RESOURCE_MNG , val); + ret = true; + } + +out_resource_unlock: +iom_dp_resource_unlock (tc); + +return ret; +} +static bool xelpdp_tc_phy_connect (struct intel_tc_port *tc,int required_lanes) { tc->lock_wakeref =tc_cold_block (tc);
drivers/gpu/drm/i915/display/intel_tc.c static bool xelpdp_tc_phy_connect(struct intel_tc_port *tc, int required_lanes) · line 1354
Quoted 5 lines
drivers/gpu/drm/i915/display/intel_tc.c +1
-1@@ -1210,9 +1351,12 @@ static bool xelpdp_tc_phy_connect(struct intel_tc_port *tc, int required_lanes)return true; } -if (!xelpdp_tc_phy_enable_tcss_power (tc, true)) +if (!xe3p_tc_iom_allocate_ddi (tc, true))
This doesn't work. A connector registered to userspace must be always functional (except for MST connectors which are dynamically registered). So the DDI allocation and with that connecting the PHY cannot fail here for a legacy connector/PHY. Instead of this the allocation could be moved to happen already in intel_tc_phy_ops::init for now, allocating a DDI for a legacy PHY (intel_tc_port::legacy_port == true) and if that fails also fail the corresponding connector/encoder registration in intel_ddi_init(). The DDI would need to be released by intel_tc_port_cleanup().
Quoted 31 lines
drivers/gpu/drm/i915/display/intel_tc.c +8
-0goto out_unblock_tccold; +if (!xelpdp_tc_phy_enable_tcss_power (tc, true)) + goto out_deallocate_ddi; +xelpdp_tc_phy_take_ownership (tc, true);read_pin_configuration (tc);@@ -1226,6 +1370,9 @@ static bool xelpdp_tc_phy_connect(struct intel_tc_port *tc, int required_lanes)xelpdp_tc_phy_take_ownership (tc, false);xelpdp_tc_phy_wait_for_tcss_power (tc, false); +out_deallocate_ddi: +xe3p_tc_iom_allocate_ddi (tc, false); + out_unblock_tccold:tc_cold_unblock (tc,fetch_and_zero (&tc->lock_wakeref));@@ -1236,6 +1383,8 @@ static void xelpdp_tc_phy_disconnect(struct intel_tc_port *tc) {switch (tc->mode) {case TC_PORT_LEGACY : +xe3p_tc_iom_allocate_ddi (tc, false); + fallthrough;case TC_PORT_DP_ALT :xelpdp_tc_phy_take_ownership (tc, false);xelpdp_tc_phy_enable_tcss_power (tc, false);Signature · 2 lines
-- 2.51.0
Re: [PATCH v4 07/11] drm/i915/xe3p_lpd: Extend Type-C flow for static DDI allocation
Quoting Imre Deak (2025-11-12 14:53:47-03:00)
Quoted 54 lines · Gustavo Sousa
Quoted 53 lines
Xe3p_LPDhas a new feature that allows the driver to allocate at runtime the DDI (TC ones) port to drive a legacy connection on the Type-C subsystem. This allows better resource utilization, because now there is no need to statically reserve ports for legacy connectors on the Type-C subsystem.That said, our driver is not yet ready for the dynamic allocation. Thus, as an incremental step, let's add the logic containing the required programming sequence for the allocation, but, instead of selecting the first available port, we try so use the 1:1 mapping expected by the driver today.
Bspec: 68954
Co-developed-by Dnyaneshwar Bhadane <[email protected]>Signed-off-by Dnyaneshwar Bhadane <[email protected]>Signed-off-by Gustavo Sousa <[email protected]>---
NOTE: This patch is still a WIP. There are some opens to resolve here. Nevertheless, I'm sending it here for early feedback.
For the HIP-index stuff, I have a local refactor started and need to finish it up and send it.
The other open is about concurrent calls to
iom_dp_resource_lock(). It is likely that we need to have a software lock to prevent concurrent access toIOM_DP_HW_RESOURCE_SEMAPHOREfrom our driver.--- drivers/gpu/drm/i915/display/intel_display_regs.h | 20 ++- drivers/gpu/drm/i915/display/intel_tc.c | 151 +++++++++++++++++++++- 2 files changed, 169 insertions(+), 2 deletions(-)drivers/gpu/drm/i915/display/intel_display_regs.h +13
-0@@ -2908,6 +2908,25 @@ enum skl_power_gate {#define DP_PIN_ASSIGNMENT (idx, x) ((x) << ((idx) * 4))/* See enum intel_tc_pin_assignment for the pin assignment field values. */ +/* +* FIXME: There is also a definition for this register in intel_dkl_phy_regs.h. +* We need to consolidate the definitions. +*/ +#define HIP_INDEX_REG0 _MMIO(0x1010a0) +#define HIP_168_INDEX_MASK REG_GENMASK(3, 0) +#define HIP_168_IOM_RES_MGMT REG_FIELD_PREP(HIP_168_INDEX_MASK, 0x1) + +#define IOM_DP_HW_RESOURCE_SEMAPHORE _MMIO(0x168038) +#define IOM_DP_HW_SEMLOCK REG_BIT(31) +#define IOM_REQUESTOR_ID_MASK REG_GENMASK(3, 0) +#define IOM_REQUESTOR_ID_DISPLAY_ENGINE REG_FIELD_PREP(IOM_REQUESTOR_ID_MASK, 0x4) +
Quoted 8 lines
drivers/gpu/drm/i915/display/intel_display_regs.h enum skl_power_gate { · line 2928
Quoted 5 lines
drivers/gpu/drm/i915/display/intel_display_regs.h +5
-0+#define IOM_DP_RESOURCE_MNG _MMIO(0x16802c) +#define IOM_DDI_CONSUMER_SHIFT (tc_port) ((tc_port) * 4) +#define IOM_DDI_CONSUMER_MASK (tc_port) (0xf << IOM_DDI_CONSUMER_SHIFT(tc_port)) +#define IOM_DDI_CONSUMER (tc_port, x) ((x) << IOM_DDI_CONSUMER_SHIFT(tc_port)) +#define IOM_DDI_CONSUMER_STATIC_TC (tc_port) IOM_DDI_CONSUMER(tc_port, 0x8 + (tc_port))It would be simpler to define the above without the shift, i.e. as 8 +
tc_port.
You mean something like this?
#define IOM_DDI_CONSUMER_STATIC_TC(tc_port) (0x8 + (tc_port))
?
Yeah... Looking at the code, we wouldn't need to shift back when defining expected_consumer.
Quoted 27 lines
Quoted 27 lines
drivers/gpu/drm/i915/display/intel_display_regs.h +1
-1+#define _TCSS_DDI_STATUS_1 0x161500#define _TCSS_DDI_STATUS_2 0x161504#define TCSS_DDI_STATUS (tc) _MMIO(_PICK_EVEN(tc, \@@ -2946,5 +2965,4 @@ enum skl_power_gate {#define MTL_TRDPRE_MASK REG_GENMASK(7, 0) -#endif /* __INTEL_DISPLAY_REGS_H__ */ drivers/gpu/drm/i915/display/intel_tc.c +1
-0@@ -9,6 +9,7 @@#include "i915_reg.h" #include "intel_atomic.h" +#include "intel_bios.h" #include "intel_cx0_phy_regs.h" #include "intel_ddi.h" #include "intel_de.h" @@ -25,6 +26,9 @@#include "intel_modeset_lock.h" #include "intel_tc.h"
Quoted 7 lines
drivers/gpu/drm/i915/display/intel_tc.c line 30
Quoted 2 lines
drivers/gpu/drm/i915/display/intel_tc.c +2
-0+#define IOM_DP_RES_SEMAPHORE_LOCK_TIMEOUT_US 10 +#define IOM_DP_RES_SEMAPHORE_RETRY_TIMEOUT_US 10000The above param names should make it clear how
poll_timeout_us()uses them (i.e. stg like sleep vs. timeout instead oflock_timeoutvs.retry_timeout), but probably even clearer to just drop the defines and inline the values in the call.
Ack. I going with the latter.
Quoted 18 lines
Quoted 18 lines
drivers/gpu/drm/i915/display/intel_tc.c +10
-0+enum tc_port_mode {TC_PORT_DISCONNECTED ,TC_PORT_TBT_ALT ,@@ -1200,6 +1204,143 @@ static void xelpdp_tc_phy_get_hw_state(struct intel_tc_port *tc)__tc_cold_unblock (tc, domain, tc_cold_wref); } +static void iom_res_mgmt_prepare_reg_access (struct intel_display *display) +{ +/* +* IOM resource management registers live in the 2nd 4KB page of IOM +* address space. So we need to configure HIP_INDEX_REG0 with the +* correct index. +* +* FIXME: We need to have this and dekel PHY implementation using a +* common abstraction to access registers on the HIP-indexed ranges, and
Quoted 8 lines
drivers/gpu/drm/i915/display/intel_tc.c static void xelpdp_tc_phy_get_hw_state(struct intel_tc_port *tc) · line 1219
Quoted 4 lines
drivers/gpu/drm/i915/display/intel_tc.c +4
-0+* this function would then be dropped. +*/ +intel_de_rmw (display,HIP_INDEX_REG0 , +HIP_168_INDEX_MASK ,HIP_168_IOM_RES_MGMT );This matches what
intel_dkl_phy.cdoes, that one also taking the required lock around the access. At one point theintel_dkl_phyfile/interface could be renamed tointel_tc_regor similar accordingly.
I have already started a local series that introduces the "HIP-index based registers" abstraction. I need to go back to finish it up.
The basic idea is that both intel_dkl_phy.c and this IOM stuff would use functions specific to accessing registers behind the HIP-based ranges.
To give an idea, here is a copy/paste of the kerneldoc I currently have in that WIP series:
| diff --git a/drivers/gpu/drm/i915/display/intel_hip_idx.c b/drivers/gpu/drm/i915/display/intel_hip_idx.c | new file mode 100644 | index 000000000000..ff2492b8275d | --- /dev/null | +++ b/drivers/gpu/drm/i915/display/intel_hip_idx.c | @@ -0,0 +1,110 @@ | +// SPDX-License-Identifier: MIT | +/* | + * Copyright (C) 2025 Intel Corporation | + */ | + | +/** | + * DOC: Display HIP-indexed register access | + * | + * Display MMIO mapping for offsets in [0x168000,0x16ffff] are governed by | + * configurations in the HIP_INDEX registers provided by the hardware. | + * | + * Usually each of the valid 4KB range in that space will be mapped to some IP | + * block, providing access to registers of that IP. The HIP_INDEX registers | + * expose an 8-bit index value for each 4KB range. Those indices provide a way | + * to access data that is beyond the initial 4KB block provided by the target | + * IP. | + * | + * As an example, say that the range [0x16a000,0x16afff] is mapped to some | + * sub-IP that contains a 8KB register file. To access the initial 4KB of that | + * register file, we would need to set the index respective to | + * [0x16a000,0x16afff] in HIP_INDEX to 0; to access data in the second 4KB | + * window, we would need to set the index to 1. | + * | + * For simple read, write or rmw operations on a single register, the | + * functions intel_hip_idx_reg_read(), intel_hip_idx_reg_write() and | + * intel_hip_idx_reg_rmw() can be used, which will call intel_hip_idx_lock() | + * and intel_hip_idx_unlock() internally. | + * | + * For other scenarios, then it is necessary to wrap the register accesses | + * with explicit calls to intel_hip_idx_lock() and intel_hip_idx_unlock(), and | + * use the MMIO functions provided by intel_de.h. For the latter, the function | + * intel_hip_idx_reg_to_i915_reg() needs to be used in order to provide the | + * correct reg argument to those functions. | + */ | (...)
Quoted 11 lines
Quoted 11 lines
drivers/gpu/drm/i915/display/intel_tc.c +10
-0+} + +/* +* FIXME: This function also needs to avoid concurrent accesses from the driver +* itself, possibly via a software lock. +*/ +static int iom_dp_resource_lock (struct intel_tc_port *tc) +{ +struct intel_display *display =to_intel_display (tc->dig_port); +u32 val =IOM_DP_HW_SEMLOCK |IOM_REQUESTOR_ID_DISPLAY_ENGINE ;
Quoted 8 lines
drivers/gpu/drm/i915/display/intel_tc.c static void xelpdp_tc_phy_get_hw_state(struct intel_tc_port *tc) · line 1234
Quoted 5 lines
drivers/gpu/drm/i915/display/intel_tc.c +5
-0+int ret; + +iom_res_mgmt_prepare_reg_access (display); + ret = poll_timeout_us(intel_de_write(display, IOM_DP_HW_RESOURCE_SEMAPHORE, val), + (intel_de_read(display, IOM_DP_HW_RESOURCE_SEMAPHORE) & val) == val,This happens to work, but it's more future proof/bspec conformant to properly mask the requestor ID field when reading it back.
Agreed.
Quoted 31 lines
Quoted 31 lines
drivers/gpu/drm/i915/display/intel_tc.c +30
-0+IOM_DP_RES_SEMAPHORE_LOCK_TIMEOUT_US , + IOM_DP_RES_SEMAPHORE_RETRY_TIMEOUT_US, false); + +if (ret) +drm_err (display->drm,"Port %s: timeout trying to lock IOM semaphore\n" , + tc->port_name); + +return ret; +} + +static void iom_dp_resource_unlock (struct intel_tc_port *tc) +{ +struct intel_display *display =to_intel_display (tc->dig_port); + +iom_res_mgmt_prepare_reg_access (display); +intel_de_write (display,IOM_DP_HW_RESOURCE_SEMAPHORE ,IOM_REQUESTOR_ID_DISPLAY_ENGINE ); +} + +static bool xe3p_tc_iom_allocate_ddi (struct intel_tc_port *tc,bool allocate) +{ +struct intel_display *display =to_intel_display (tc->dig_port); +struct intel_digital_port *dig_port = tc->dig_port; +enum tc_port tc_port =intel_encoder_to_tc (&dig_port->base); +u32 val; +u32 consumer; +u32 expected_consumer; +bool ret; + +if (DISPLAY_VER (display) <35 ) +return true;
Quoted 8 lines
drivers/gpu/drm/i915/display/intel_tc.c static void xelpdp_tc_phy_get_hw_state(struct intel_tc_port *tc) · line 1269
Quoted 5 lines
drivers/gpu/drm/i915/display/intel_tc.c +5
-0+ +if (tc->mode !=TC_PORT_LEGACY ) +return true; + +if (!intel_bios_encoder_supports_dyn_port_over_tc (dig_port->base.devdata))
dedicated_externalis stored separately indig_port, why the "related"dyn_port_over_tcflag isn't?
The only reason dedicated_external is stored is because VBT data is already freed by the time intel_encoder_is_tc() is called in the driver unbind path. In the future we should fix the VBT lifetime issue in order to be able to drop the dedicated_external member of dig_port.
Quoted 82 lines
Quoted 82 lines
drivers/gpu/drm/i915/display/intel_tc.c +74
-0+return true; + +if (iom_dp_resource_lock (tc)) +return false; + + val =intel_de_read (display,IOM_DP_RESOURCE_MNG ); + + consumer = val &IOM_DDI_CONSUMER_MASK (tc_port); + consumer >>=IOM_DDI_CONSUMER_SHIFT (tc_port); + +/* +* Bspec instructs to select first available DDI, but our driver is not +* ready for such dynamic allocation yet. For now, we force a "static" +* allocation: map the physical port (where HPD happens) to the +* encoder's DDI (logical TC port, represented by tc_port). +*/ + expected_consumer =IOM_DDI_CONSUMER_STATIC_TC (tc_port); + expected_consumer >>=IOM_DDI_CONSUMER_SHIFT (tc_port); + +if (allocate) { +struct intel_encoder *other_encoder; + +/* +* Check if this encoder's DDI is already allocated for another +* physical port, which could have happened prior to the driver +* taking over (e.g. GOP). +*/ +for_each_intel_encoder (display->drm, other_encoder) { +enum tc_port other_tc_port =intel_encoder_to_tc (other_encoder); +u32 other_consumer; + +if (tc_port ==TC_PORT_NONE || other_tc_port == tc_port) +continue ; + + other_consumer = val &IOM_DDI_CONSUMER_MASK (other_tc_port); + other_consumer >>=IOM_DDI_CONSUMER_SHIFT (other_tc_port); +if (other_consumer == expected_consumer) { +drm_err (display->drm,"Port %s: expected consumer %u already allocated another DDI; IOM_DP_RESOURCE_MNG=0x%08x\n" , + tc->port_name, expected_consumer, val); + ret = false; + goto out_resource_unlock; + } + } + +if (consumer ==0 ) { +/* DDI is free to use, let's allocate it. */ + val &= ~IOM_DDI_CONSUMER_MASK (tc_port); + val |=IOM_DDI_CONSUMER (tc_port, expected_consumer); +intel_de_write (display,IOM_DP_RESOURCE_MNG , val); + ret = true; + }else if (consumer == expected_consumer) { +/* +* Nothing to do, as the expected "static" DDI allocation is +* already in place. +*/ + ret = true; + }else { +drm_err (display->drm,"Port %s: DDI already allocated for consumer %u; IOM_DP_RESOURCE_MNG=0x%08x\n" , + tc->port_name, consumer, val); + ret = false; + } + }else { +drm_WARN_ON (display->drm, consumer != expected_consumer); + val &= ~IOM_DDI_CONSUMER_MASK (tc_port); +intel_de_write (display,IOM_DP_RESOURCE_MNG , val); + ret = true; + } + +out_resource_unlock: +iom_dp_resource_unlock (tc); + +return ret; +} +static bool xelpdp_tc_phy_connect (struct intel_tc_port *tc,int required_lanes) { tc->lock_wakeref =tc_cold_block (tc);@@ -1210,9 +1351,12 @@ static bool xelpdp_tc_phy_connect(struct intel_tc_port *tc, int required_lanes)return true; }
Quoted 12 lines
drivers/gpu/drm/i915/display/intel_tc.c static bool xelpdp_tc_phy_connect(struct intel_tc_port *tc, int required_lanes) · line 1354
Quoted 2 lines
drivers/gpu/drm/i915/display/intel_tc.c +1
-1-if (!xelpdp_tc_phy_enable_tcss_power (tc, true)) +if (!xe3p_tc_iom_allocate_ddi (tc, true))This doesn't work. A connector registered to userspace must be always functional (except for MST connectors which are dynamically registered). So the DDI allocation and with that connecting the PHY cannot fail here for a legacy connector/PHY. Instead of this the allocation could be moved to happen already in
intel_tc_phy_ops::initfor now, allocating a DDI for a legacy PHY (intel_tc_port::legacy_port== true) and if that fails also fail the corresponding connector/encoder registration inintel_ddi_init(). The DDI would need to be released byintel_tc_port_cleanup().
Ah, I see. Well, I guess for legacy connections, doing your suggestion seems fine.
Is there any power management aspect that we should be aware here? Like, some power well being disabled and causing the allocation to be "lost" somehow. Since this thing is in the TCSS, I think no display power wells could cause that, right?
By the way, I wonder how we would handle things in the future when/if we enable the dynamic DDI allocation thing.
--
Gustavo Sousa
Quoted 32 lines
Quoted 32 lines
drivers/gpu/drm/i915/display/intel_tc.c +8
-0goto out_unblock_tccold; +if (!xelpdp_tc_phy_enable_tcss_power (tc, true)) + goto out_deallocate_ddi; +xelpdp_tc_phy_take_ownership (tc, true);read_pin_configuration (tc);@@ -1226,6 +1370,9 @@ static bool xelpdp_tc_phy_connect(struct intel_tc_port *tc, int required_lanes)xelpdp_tc_phy_take_ownership (tc, false);xelpdp_tc_phy_wait_for_tcss_power (tc, false); +out_deallocate_ddi: +xe3p_tc_iom_allocate_ddi (tc, false); + out_unblock_tccold:tc_cold_unblock (tc,fetch_and_zero (&tc->lock_wakeref));@@ -1236,6 +1383,8 @@ static void xelpdp_tc_phy_disconnect(struct intel_tc_port *tc) {switch (tc->mode) {case TC_PORT_LEGACY : +xe3p_tc_iom_allocate_ddi (tc, false); + fallthrough;case TC_PORT_DP_ALT :xelpdp_tc_phy_take_ownership (tc, false);xelpdp_tc_phy_enable_tcss_power (tc, false);Signature · 2 lines
-- 2.51.0
Re: [PATCH v4 07/11] drm/i915/xe3p_lpd: Extend Type-C flow for static DDI allocation
Quoted 64 lines · Gustavo Sousa
Quoting Imre Deak (2025-11-12 14:53:47-03:00)
Quoted 54 lines · Gustavo Sousa
Quoted 53 lines
Xe3p_LPDhas a new feature that allows the driver to allocate at runtime the DDI (TC ones) port to drive a legacy connection on the Type-C subsystem. This allows better resource utilization, because now there is no need to statically reserve ports for legacy connectors on the Type-C subsystem.That said, our driver is not yet ready for the dynamic allocation. Thus, as an incremental step, let's add the logic containing the required programming sequence for the allocation, but, instead of selecting the first available port, we try so use the 1:1 mapping expected by the driver today.
Bspec: 68954
Co-developed-by Dnyaneshwar Bhadane <[email protected]>Signed-off-by Dnyaneshwar Bhadane <[email protected]>Signed-off-by Gustavo Sousa <[email protected]>---
NOTE: This patch is still a WIP. There are some opens to resolve here. Nevertheless, I'm sending it here for early feedback.
For the HIP-index stuff, I have a local refactor started and need to finish it up and send it.
The other open is about concurrent calls to
iom_dp_resource_lock(). It is likely that we need to have a software lock to prevent concurrent access toIOM_DP_HW_RESOURCE_SEMAPHOREfrom our driver.--- drivers/gpu/drm/i915/display/intel_display_regs.h | 20 ++- drivers/gpu/drm/i915/display/intel_tc.c | 151 +++++++++++++++++++++- 2 files changed, 169 insertions(+), 2 deletions(-)drivers/gpu/drm/i915/display/intel_display_regs.h +13
-0@@ -2908,6 +2908,25 @@ enum skl_power_gate {#define DP_PIN_ASSIGNMENT (idx, x) ((x) << ((idx) * 4))/* See enum intel_tc_pin_assignment for the pin assignment field values. */ +/* +* FIXME: There is also a definition for this register in intel_dkl_phy_regs.h. +* We need to consolidate the definitions. +*/ +#define HIP_INDEX_REG0 _MMIO(0x1010a0) +#define HIP_168_INDEX_MASK REG_GENMASK(3, 0) +#define HIP_168_IOM_RES_MGMT REG_FIELD_PREP(HIP_168_INDEX_MASK, 0x1) + +#define IOM_DP_HW_RESOURCE_SEMAPHORE _MMIO(0x168038) +#define IOM_DP_HW_SEMLOCK REG_BIT(31) +#define IOM_REQUESTOR_ID_MASK REG_GENMASK(3, 0) +#define IOM_REQUESTOR_ID_DISPLAY_ENGINE REG_FIELD_PREP(IOM_REQUESTOR_ID_MASK, 0x4) +Quoted 8 lines
drivers/gpu/drm/i915/display/intel_display_regs.h enum skl_power_gate { · line 2928
Quoted 5 lines
drivers/gpu/drm/i915/display/intel_display_regs.h +5
-0+#define IOM_DP_RESOURCE_MNG _MMIO(0x16802c) +#define IOM_DDI_CONSUMER_SHIFT (tc_port) ((tc_port) * 4) +#define IOM_DDI_CONSUMER_MASK (tc_port) (0xf << IOM_DDI_CONSUMER_SHIFT(tc_port)) +#define IOM_DDI_CONSUMER (tc_port, x) ((x) << IOM_DDI_CONSUMER_SHIFT(tc_port)) +#define IOM_DDI_CONSUMER_STATIC_TC (tc_port) IOM_DDI_CONSUMER(tc_port, 0x8 + (tc_port))It would be simpler to define the above without the shift, i.e. as 8 +
tc_port.
Quoted 8 lines
You mean something like this?
#define
IOM_DDI_CONSUMER_STATIC_TC(tc_port)(0x8+ (tc_port))?
Yeah... Looking at the code, we wouldn't need to shift back when defining
expected_consumer.
Yes.
Quoted 65 lines
Quoted 28 lines
Quoted 28 lines
drivers/gpu/drm/i915/display/intel_display_regs.h +1
-1+#define _TCSS_DDI_STATUS_1 0x161500#define _TCSS_DDI_STATUS_2 0x161504#define TCSS_DDI_STATUS (tc) _MMIO(_PICK_EVEN(tc, \@@ -2946,5 +2965,4 @@ enum skl_power_gate {#define MTL_TRDPRE_MASK REG_GENMASK(7, 0) -#endif /* __INTEL_DISPLAY_REGS_H__ */ drivers/gpu/drm/i915/display/intel_tc.c +1
-0@@ -9,6 +9,7 @@#include "i915_reg.h" #include "intel_atomic.h" +#include "intel_bios.h" #include "intel_cx0_phy_regs.h" #include "intel_ddi.h" #include "intel_de.h" @@ -25,6 +26,9 @@#include "intel_modeset_lock.h" #include "intel_tc.h" Quoted 7 lines
drivers/gpu/drm/i915/display/intel_tc.c line 30
Quoted 2 lines
drivers/gpu/drm/i915/display/intel_tc.c +2
-0+#define IOM_DP_RES_SEMAPHORE_LOCK_TIMEOUT_US 10 +#define IOM_DP_RES_SEMAPHORE_RETRY_TIMEOUT_US 10000The above param names should make it clear how
poll_timeout_us()uses them (i.e. stg like sleep vs. timeout instead oflock_timeoutvs.retry_timeout), but probably even clearer to just drop the defines and inline the values in the call.Ack. I going with the latter.
Quoted 18 lines
Quoted 18 lines
drivers/gpu/drm/i915/display/intel_tc.c +10
-0+enum tc_port_mode {TC_PORT_DISCONNECTED ,TC_PORT_TBT_ALT ,@@ -1200,6 +1204,143 @@ static void xelpdp_tc_phy_get_hw_state(struct intel_tc_port *tc)__tc_cold_unblock (tc, domain, tc_cold_wref); } +static void iom_res_mgmt_prepare_reg_access (struct intel_display *display) +{ +/* +* IOM resource management registers live in the 2nd 4KB page of IOM +* address space. So we need to configure HIP_INDEX_REG0 with the +* correct index. +* +* FIXME: We need to have this and dekel PHY implementation using a +* common abstraction to access registers on the HIP-indexed ranges, and Quoted 8 lines
drivers/gpu/drm/i915/display/intel_tc.c static void xelpdp_tc_phy_get_hw_state(struct intel_tc_port *tc) · line 1219
Quoted 4 lines
drivers/gpu/drm/i915/display/intel_tc.c +4
-0+* this function would then be dropped. +*/ +intel_de_rmw (display,HIP_INDEX_REG0 , +HIP_168_INDEX_MASK ,HIP_168_IOM_RES_MGMT );This matches what
intel_dkl_phy.cdoes, that one also taking the required lock around the access. At one point theintel_dkl_phyfile/interface could be renamed tointel_tc_regor similar accordingly.
Quoted 5 lines
I have already started a local series that introduces the "HIP-index based registers" abstraction. I need to go back to finish it up.
The basic idea is that both
intel_dkl_phy.cand this IOM stuff would use functions specific to accessing registers behind the HIP-based ranges.
Using intel_hip_reg instead of intel_tc_reg is probably better, but I still think the current interface should be just renamed, instead of adding a new interface and making the current intel_dkl_phy_read/write/rmw() use that new interface.
I went ahead and put the above together now:
https://github.com/ideak/linux/commits/hip-reg
Quoted 124 lines
To give an idea, here is a copy/paste of the kerneldoc I currently have in that WIP series:
| diff --git a/drivers/gpu/drm/i915/display/intel_hip_idx.c b/drivers/gpu/drm/i915/display/intel_hip_idx.c | new file mode 100644 | index 000000000000..ff2492b8275d | --- /dev/null | +++ b/drivers/gpu/drm/i915/display/intel_hip_idx.c | @@ -0,0 +1,110 @@ | +// SPDX-License-Identifier: MIT | +/* | + * Copyright (C) 2025 Intel Corporation | + */ | + | +/** | + * DOC: Display HIP-indexed register access | + * | + * Display MMIO mapping for offsets in [0x168000,0x16ffff] are governed by | + * configurations in the HIP_INDEX registers provided by the hardware. | + * | + * Usually each of the valid 4KB range in that space will be mapped to some IP | + * block, providing access to registers of that IP. The HIP_INDEX registers | + * expose an 8-bit index value for each 4KB range. Those indices provide a way | + * to access data that is beyond the initial 4KB block provided by the target | + * IP. | + * | + * As an example, say that the range [0x16a000,0x16afff] is mapped to some | + * sub-IP that contains a 8KB register file. To access the initial 4KB of that | + * register file, we would need to set the index respective to | + * [0x16a000,0x16afff] in HIP_INDEX to 0; to access data in the second 4KB | + * window, we would need to set the index to 1. | + * | + * For simple read, write or rmw operations on a single register, the | + * functions intel_hip_idx_reg_read(), intel_hip_idx_reg_write() and | + * intel_hip_idx_reg_rmw() can be used, which will call intel_hip_idx_lock() | + * and intel_hip_idx_unlock() internally. | + * | + * For other scenarios, then it is necessary to wrap the register accesses | + * with explicit calls to intel_hip_idx_lock() and intel_hip_idx_unlock(), and | + * use the MMIO functions provided by intel_de.h. For the latter, the function | + * intel_hip_idx_reg_to_i915_reg() needs to be used in order to provide the | + * correct reg argument to those functions. | + */ | (...)Quoted 11 lines
Quoted 11 lines
drivers/gpu/drm/i915/display/intel_tc.c +10
-0+} + +/* +* FIXME: This function also needs to avoid concurrent accesses from the driver +* itself, possibly via a software lock. +*/ +static int iom_dp_resource_lock (struct intel_tc_port *tc) +{ +struct intel_display *display =to_intel_display (tc->dig_port); +u32 val =IOM_DP_HW_SEMLOCK |IOM_REQUESTOR_ID_DISPLAY_ENGINE ;Quoted 8 lines
drivers/gpu/drm/i915/display/intel_tc.c static void xelpdp_tc_phy_get_hw_state(struct intel_tc_port *tc) · line 1234
Quoted 5 lines
drivers/gpu/drm/i915/display/intel_tc.c +5
-0+int ret; + +iom_res_mgmt_prepare_reg_access (display); + ret = poll_timeout_us(intel_de_write(display, IOM_DP_HW_RESOURCE_SEMAPHORE, val), + (intel_de_read(display, IOM_DP_HW_RESOURCE_SEMAPHORE) & val) == val,This happens to work, but it's more future proof/bspec conformant to properly mask the requestor ID field when reading it back.
Agreed.
Quoted 31 lines
Quoted 31 lines
drivers/gpu/drm/i915/display/intel_tc.c +30
-0+IOM_DP_RES_SEMAPHORE_LOCK_TIMEOUT_US , + IOM_DP_RES_SEMAPHORE_RETRY_TIMEOUT_US, false); + +if (ret) +drm_err (display->drm,"Port %s: timeout trying to lock IOM semaphore\n" , + tc->port_name); + +return ret; +} + +static void iom_dp_resource_unlock (struct intel_tc_port *tc) +{ +struct intel_display *display =to_intel_display (tc->dig_port); + +iom_res_mgmt_prepare_reg_access (display); +intel_de_write (display,IOM_DP_HW_RESOURCE_SEMAPHORE ,IOM_REQUESTOR_ID_DISPLAY_ENGINE ); +} + +static bool xe3p_tc_iom_allocate_ddi (struct intel_tc_port *tc,bool allocate) +{ +struct intel_display *display =to_intel_display (tc->dig_port); +struct intel_digital_port *dig_port = tc->dig_port; +enum tc_port tc_port =intel_encoder_to_tc (&dig_port->base); +u32 val; +u32 consumer; +u32 expected_consumer; +bool ret; + +if (DISPLAY_VER (display) <35 ) +return true;Quoted 8 lines
drivers/gpu/drm/i915/display/intel_tc.c static void xelpdp_tc_phy_get_hw_state(struct intel_tc_port *tc) · line 1269
Quoted 5 lines
drivers/gpu/drm/i915/display/intel_tc.c +5
-0+ +if (tc->mode !=TC_PORT_LEGACY ) +return true; + +if (!intel_bios_encoder_supports_dyn_port_over_tc (dig_port->base.devdata))
dedicated_externalis stored separately indig_port, why the "related"dyn_port_over_tcflag isn't?The only reason
dedicated_externalis stored is because VBT data is already freed by the timeintel_encoder_is_tc()is called in the driver unbind path. In the future we should fix the VBT lifetime issue in order to be able to drop thededicated_externalmember ofdig_port.Quoted 11 lines
Quoted 11 lines
drivers/gpu/drm/i915/display/intel_tc.c +10
-0+return true; + +if (iom_dp_resource_lock (tc)) +return false; + + val =intel_de_read (display,IOM_DP_RESOURCE_MNG ); + + consumer = val &IOM_DDI_CONSUMER_MASK (tc_port); + consumer >>=IOM_DDI_CONSUMER_SHIFT (tc_port); +
Quoted 8 lines
Quoted 8 lines
drivers/gpu/drm/i915/display/intel_tc.c static void xelpdp_tc_phy_get_hw_state(struct intel_tc_port *tc) · line 1287
Quoted 8 lines
drivers/gpu/drm/i915/display/intel_tc.c +8
-0+/* +* Bspec instructs to select first available DDI, but our driver is not +* ready for such dynamic allocation yet. For now, we force a "static" +* allocation: map the physical port (where HPD happens) to the +* encoder's DDI (logical TC port, represented by tc_port). +*/ + expected_consumer =IOM_DDI_CONSUMER_STATIC_TC (tc_port); + expected_consumer >>=IOM_DDI_CONSUMER_SHIFT (tc_port);
One more thing occured to me: why can't this allocate any free DDI? IOW does the address of DDI_BUF_CTL (aka DDI_CTL_DE) used for tc_port depend on which DDI gets allocated (or is there any other dependency on which DDI got allocated)? AFAICS there is no such dependency and the above address would be DDI_BUF_CTL(encoder->port) regardless of the allocated DDI. In that case any free DDI could be allocated here.
Quoted 76 lines
Quoted 63 lines
Quoted 63 lines
drivers/gpu/drm/i915/display/intel_tc.c +56
-0+ +if (allocate) { +struct intel_encoder *other_encoder; + +/* +* Check if this encoder's DDI is already allocated for another +* physical port, which could have happened prior to the driver +* taking over (e.g. GOP). +*/ +for_each_intel_encoder (display->drm, other_encoder) { +enum tc_port other_tc_port =intel_encoder_to_tc (other_encoder); +u32 other_consumer; + +if (tc_port ==TC_PORT_NONE || other_tc_port == tc_port) +continue ; + + other_consumer = val &IOM_DDI_CONSUMER_MASK (other_tc_port); + other_consumer >>=IOM_DDI_CONSUMER_SHIFT (other_tc_port); +if (other_consumer == expected_consumer) { +drm_err (display->drm,"Port %s: expected consumer %u already allocated another DDI; IOM_DP_RESOURCE_MNG=0x%08x\n" , + tc->port_name, expected_consumer, val); + ret = false; + goto out_resource_unlock; + } + } + +if (consumer ==0 ) { +/* DDI is free to use, let's allocate it. */ + val &= ~IOM_DDI_CONSUMER_MASK (tc_port); + val |=IOM_DDI_CONSUMER (tc_port, expected_consumer); +intel_de_write (display,IOM_DP_RESOURCE_MNG , val); + ret = true; + }else if (consumer == expected_consumer) { +/* +* Nothing to do, as the expected "static" DDI allocation is +* already in place. +*/ + ret = true; + }else { +drm_err (display->drm,"Port %s: DDI already allocated for consumer %u; IOM_DP_RESOURCE_MNG=0x%08x\n" , + tc->port_name, consumer, val); + ret = false; + } + }else { +drm_WARN_ON (display->drm, consumer != expected_consumer); + val &= ~IOM_DDI_CONSUMER_MASK (tc_port); +intel_de_write (display,IOM_DP_RESOURCE_MNG , val); + ret = true; + } + +out_resource_unlock: +iom_dp_resource_unlock (tc); + +return ret; +} +static bool xelpdp_tc_phy_connect (struct intel_tc_port *tc,int required_lanes) { tc->lock_wakeref =tc_cold_block (tc);@@ -1210,9 +1351,12 @@ static bool xelpdp_tc_phy_connect(struct intel_tc_port *tc, int required_lanes)return true; }Quoted 12 lines
drivers/gpu/drm/i915/display/intel_tc.c static bool xelpdp_tc_phy_connect(struct intel_tc_port *tc, int required_lanes) · line 1354
Quoted 2 lines
drivers/gpu/drm/i915/display/intel_tc.c +1
-1-if (!xelpdp_tc_phy_enable_tcss_power (tc, true)) +if (!xe3p_tc_iom_allocate_ddi (tc, true))This doesn't work. A connector registered to userspace must be always functional (except for MST connectors which are dynamically registered). So the DDI allocation and with that connecting the PHY cannot fail here for a legacy connector/PHY. Instead of this the allocation could be moved to happen already in
intel_tc_phy_ops::initfor now, allocating a DDI for a legacy PHY (intel_tc_port::legacy_port== true) and if that fails also fail the corresponding connector/encoder registration inintel_ddi_init(). The DDI would need to be released byintel_tc_port_cleanup().
Quoted 7 lines
Ah, I see. Well, I guess for legacy connections, doing your suggestion seems fine.
Is there any power management aspect that we should be aware here? Like, some power well being disabled and causing the allocation to be "lost" somehow. Since this thing is in the TCSS, I think no display power wells could cause that, right?
It would make sense to me that the allocations are preserved by the HW/FW across power transitions. If that's not the case then they should be restored by the driver.
Quoted 2 lines
By the way, I wonder how we would handle things in the future when/if we enable the dynamic DDI allocation thing.
In case of a DDI allocation failure, the modeset will still succeed, but the corresponding port/pipe will not get enabled.
Quoted 35 lines
--
Gustavo SousaQuoted 32 lines
Quoted 32 lines
drivers/gpu/drm/i915/display/intel_tc.c +8
-0goto out_unblock_tccold; +if (!xelpdp_tc_phy_enable_tcss_power (tc, true)) + goto out_deallocate_ddi; +xelpdp_tc_phy_take_ownership (tc, true);read_pin_configuration (tc);@@ -1226,6 +1370,9 @@ static bool xelpdp_tc_phy_connect(struct intel_tc_port *tc, int required_lanes)xelpdp_tc_phy_take_ownership (tc, false);xelpdp_tc_phy_wait_for_tcss_power (tc, false); +out_deallocate_ddi: +xe3p_tc_iom_allocate_ddi (tc, false); + out_unblock_tccold:tc_cold_unblock (tc,fetch_and_zero (&tc->lock_wakeref));@@ -1236,6 +1383,8 @@ static void xelpdp_tc_phy_disconnect(struct intel_tc_port *tc) {switch (tc->mode) {case TC_PORT_LEGACY : +xe3p_tc_iom_allocate_ddi (tc, false); + fallthrough;case TC_PORT_DP_ALT :xelpdp_tc_phy_take_ownership (tc, false);xelpdp_tc_phy_enable_tcss_power (tc, false);Signature · 2 lines
-- 2.51.0
Re: [PATCH v4 07/11] drm/i915/xe3p_lpd: Extend Type-C flow for static DDI allocation
Quoted 286 lines · Imre Deak
Quoted 64 lines · Gustavo Sousa
Quoting Imre Deak (2025-11-12 14:53:47-03:00)
Quoted 54 lines · Gustavo Sousa
Quoted 53 lines
Xe3p_LPDhas a new feature that allows the driver to allocate at runtime the DDI (TC ones) port to drive a legacy connection on the Type-C subsystem. This allows better resource utilization, because now there is no need to statically reserve ports for legacy connectors on the Type-C subsystem.That said, our driver is not yet ready for the dynamic allocation. Thus, as an incremental step, let's add the logic containing the required programming sequence for the allocation, but, instead of selecting the first available port, we try so use the 1:1 mapping expected by the driver today.
Bspec: 68954
Co-developed-by Dnyaneshwar Bhadane <[email protected]>Signed-off-by Dnyaneshwar Bhadane <[email protected]>Signed-off-by Gustavo Sousa <[email protected]>---
NOTE: This patch is still a WIP. There are some opens to resolve here. Nevertheless, I'm sending it here for early feedback.
For the HIP-index stuff, I have a local refactor started and need to finish it up and send it.
The other open is about concurrent calls to
iom_dp_resource_lock(). It is likely that we need to have a software lock to prevent concurrent access toIOM_DP_HW_RESOURCE_SEMAPHOREfrom our driver.--- drivers/gpu/drm/i915/display/intel_display_regs.h | 20 ++- drivers/gpu/drm/i915/display/intel_tc.c | 151 +++++++++++++++++++++- 2 files changed, 169 insertions(+), 2 deletions(-)drivers/gpu/drm/i915/display/intel_display_regs.h +13
-0@@ -2908,6 +2908,25 @@ enum skl_power_gate {#define DP_PIN_ASSIGNMENT (idx, x) ((x) << ((idx) * 4))/* See enum intel_tc_pin_assignment for the pin assignment field values. */ +/* +* FIXME: There is also a definition for this register in intel_dkl_phy_regs.h. +* We need to consolidate the definitions. +*/ +#define HIP_INDEX_REG0 _MMIO(0x1010a0) +#define HIP_168_INDEX_MASK REG_GENMASK(3, 0) +#define HIP_168_IOM_RES_MGMT REG_FIELD_PREP(HIP_168_INDEX_MASK, 0x1) + +#define IOM_DP_HW_RESOURCE_SEMAPHORE _MMIO(0x168038) +#define IOM_DP_HW_SEMLOCK REG_BIT(31) +#define IOM_REQUESTOR_ID_MASK REG_GENMASK(3, 0) +#define IOM_REQUESTOR_ID_DISPLAY_ENGINE REG_FIELD_PREP(IOM_REQUESTOR_ID_MASK, 0x4) +Quoted 8 lines
drivers/gpu/drm/i915/display/intel_display_regs.h enum skl_power_gate { · line 2928
Quoted 5 lines
drivers/gpu/drm/i915/display/intel_display_regs.h +5
-0+#define IOM_DP_RESOURCE_MNG _MMIO(0x16802c) +#define IOM_DDI_CONSUMER_SHIFT (tc_port) ((tc_port) * 4) +#define IOM_DDI_CONSUMER_MASK (tc_port) (0xf << IOM_DDI_CONSUMER_SHIFT(tc_port)) +#define IOM_DDI_CONSUMER (tc_port, x) ((x) << IOM_DDI_CONSUMER_SHIFT(tc_port)) +#define IOM_DDI_CONSUMER_STATIC_TC (tc_port) IOM_DDI_CONSUMER(tc_port, 0x8 + (tc_port))It would be simpler to define the above without the shift, i.e. as 8 +
tc_port.Quoted 8 lines
You mean something like this?
#define
IOM_DDI_CONSUMER_STATIC_TC(tc_port)(0x8+ (tc_port))?
Yeah... Looking at the code, we wouldn't need to shift back when defining
expected_consumer.Yes.
Quoted 65 lines
Quoted 28 lines
Quoted 28 lines
drivers/gpu/drm/i915/display/intel_display_regs.h +1
-1+#define _TCSS_DDI_STATUS_1 0x161500#define _TCSS_DDI_STATUS_2 0x161504#define TCSS_DDI_STATUS (tc) _MMIO(_PICK_EVEN(tc, \@@ -2946,5 +2965,4 @@ enum skl_power_gate {#define MTL_TRDPRE_MASK REG_GENMASK(7, 0) -#endif /* __INTEL_DISPLAY_REGS_H__ */ drivers/gpu/drm/i915/display/intel_tc.c +1
-0@@ -9,6 +9,7 @@#include "i915_reg.h" #include "intel_atomic.h" +#include "intel_bios.h" #include "intel_cx0_phy_regs.h" #include "intel_ddi.h" #include "intel_de.h" @@ -25,6 +26,9 @@#include "intel_modeset_lock.h" #include "intel_tc.h" Quoted 7 lines
drivers/gpu/drm/i915/display/intel_tc.c line 30
Quoted 2 lines
drivers/gpu/drm/i915/display/intel_tc.c +2
-0+#define IOM_DP_RES_SEMAPHORE_LOCK_TIMEOUT_US 10 +#define IOM_DP_RES_SEMAPHORE_RETRY_TIMEOUT_US 10000The above param names should make it clear how
poll_timeout_us()uses them (i.e. stg like sleep vs. timeout instead oflock_timeoutvs.retry_timeout), but probably even clearer to just drop the defines and inline the values in the call.Ack. I going with the latter.
Quoted 18 lines
Quoted 18 lines
drivers/gpu/drm/i915/display/intel_tc.c +10
-0+enum tc_port_mode {TC_PORT_DISCONNECTED ,TC_PORT_TBT_ALT ,@@ -1200,6 +1204,143 @@ static void xelpdp_tc_phy_get_hw_state(struct intel_tc_port *tc)__tc_cold_unblock (tc, domain, tc_cold_wref); } +static void iom_res_mgmt_prepare_reg_access (struct intel_display *display) +{ +/* +* IOM resource management registers live in the 2nd 4KB page of IOM +* address space. So we need to configure HIP_INDEX_REG0 with the +* correct index. +* +* FIXME: We need to have this and dekel PHY implementation using a +* common abstraction to access registers on the HIP-indexed ranges, and Quoted 8 lines
drivers/gpu/drm/i915/display/intel_tc.c static void xelpdp_tc_phy_get_hw_state(struct intel_tc_port *tc) · line 1219
Quoted 4 lines
drivers/gpu/drm/i915/display/intel_tc.c +4
-0+* this function would then be dropped. +*/ +intel_de_rmw (display,HIP_INDEX_REG0 , +HIP_168_INDEX_MASK ,HIP_168_IOM_RES_MGMT );This matches what
intel_dkl_phy.cdoes, that one also taking the required lock around the access. At one point theintel_dkl_phyfile/interface could be renamed tointel_tc_regor similar accordingly.Quoted 5 lines
I have already started a local series that introduces the "HIP-index based registers" abstraction. I need to go back to finish it up.
The basic idea is that both
intel_dkl_phy.cand this IOM stuff would use functions specific to accessing registers behind the HIP-based ranges.Using
intel_hip_reginstead ofintel_tc_regis probably better, but I still think the current interface should be just renamed, instead of adding a new interface and making the current intel_dkl_phy_read/write/rmw() use that new interface.I went ahead and put the above together now:
https://github.com/ideak/linux/commits/hip-regQuoted 131 lines
To give an idea, here is a copy/paste of the kerneldoc I currently have in that WIP series:
| diff --git a/drivers/gpu/drm/i915/display/intel_hip_idx.c b/drivers/gpu/drm/i915/display/intel_hip_idx.c | new file mode 100644 | index 000000000000..ff2492b8275d | --- /dev/null | +++ b/drivers/gpu/drm/i915/display/intel_hip_idx.c | @@ -0,0 +1,110 @@ | +// SPDX-License-Identifier: MIT | +/* | + * Copyright (C) 2025 Intel Corporation | + */ | + | +/** | + * DOC: Display HIP-indexed register access | + * | + * Display MMIO mapping for offsets in [0x168000,0x16ffff] are governed by | + * configurations in the HIP_INDEX registers provided by the hardware. | + * | + * Usually each of the valid 4KB range in that space will be mapped to some IP | + * block, providing access to registers of that IP. The HIP_INDEX registers | + * expose an 8-bit index value for each 4KB range. Those indices provide a way | + * to access data that is beyond the initial 4KB block provided by the target | + * IP. | + * | + * As an example, say that the range [0x16a000,0x16afff] is mapped to some | + * sub-IP that contains a 8KB register file. To access the initial 4KB of that | + * register file, we would need to set the index respective to | + * [0x16a000,0x16afff] in HIP_INDEX to 0; to access data in the second 4KB | + * window, we would need to set the index to 1. | + * | + * For simple read, write or rmw operations on a single register, the | + * functions intel_hip_idx_reg_read(), intel_hip_idx_reg_write() and | + * intel_hip_idx_reg_rmw() can be used, which will call intel_hip_idx_lock() | + * and intel_hip_idx_unlock() internally. | + * | + * For other scenarios, then it is necessary to wrap the register accesses | + * with explicit calls to intel_hip_idx_lock() and intel_hip_idx_unlock(), and | + * use the MMIO functions provided by intel_de.h. For the latter, the function | + * intel_hip_idx_reg_to_i915_reg() needs to be used in order to provide the | + * correct reg argument to those functions. | + */ | (...)Quoted 11 lines
Quoted 11 lines
drivers/gpu/drm/i915/display/intel_tc.c +10
-0+} + +/* +* FIXME: This function also needs to avoid concurrent accesses from the driver +* itself, possibly via a software lock. +*/ +static int iom_dp_resource_lock (struct intel_tc_port *tc) +{ +struct intel_display *display =to_intel_display (tc->dig_port); +u32 val =IOM_DP_HW_SEMLOCK |IOM_REQUESTOR_ID_DISPLAY_ENGINE ;Quoted 8 lines
drivers/gpu/drm/i915/display/intel_tc.c static void xelpdp_tc_phy_get_hw_state(struct intel_tc_port *tc) · line 1234
Quoted 5 lines
drivers/gpu/drm/i915/display/intel_tc.c +5
-0+int ret; + +iom_res_mgmt_prepare_reg_access (display); + ret = poll_timeout_us(intel_de_write(display, IOM_DP_HW_RESOURCE_SEMAPHORE, val), + (intel_de_read(display, IOM_DP_HW_RESOURCE_SEMAPHORE) & val) == val,This happens to work, but it's more future proof/bspec conformant to properly mask the requestor ID field when reading it back.
Agreed.
Quoted 31 lines
Quoted 31 lines
drivers/gpu/drm/i915/display/intel_tc.c +30
-0+IOM_DP_RES_SEMAPHORE_LOCK_TIMEOUT_US , + IOM_DP_RES_SEMAPHORE_RETRY_TIMEOUT_US, false); + +if (ret) +drm_err (display->drm,"Port %s: timeout trying to lock IOM semaphore\n" , + tc->port_name); + +return ret; +} + +static void iom_dp_resource_unlock (struct intel_tc_port *tc) +{ +struct intel_display *display =to_intel_display (tc->dig_port); + +iom_res_mgmt_prepare_reg_access (display); +intel_de_write (display,IOM_DP_HW_RESOURCE_SEMAPHORE ,IOM_REQUESTOR_ID_DISPLAY_ENGINE ); +} + +static bool xe3p_tc_iom_allocate_ddi (struct intel_tc_port *tc,bool allocate) +{ +struct intel_display *display =to_intel_display (tc->dig_port); +struct intel_digital_port *dig_port = tc->dig_port; +enum tc_port tc_port =intel_encoder_to_tc (&dig_port->base); +u32 val; +u32 consumer; +u32 expected_consumer; +bool ret; + +if (DISPLAY_VER (display) <35 ) +return true;Quoted 8 lines
drivers/gpu/drm/i915/display/intel_tc.c static void xelpdp_tc_phy_get_hw_state(struct intel_tc_port *tc) · line 1269
Quoted 5 lines
drivers/gpu/drm/i915/display/intel_tc.c +5
-0+ +if (tc->mode !=TC_PORT_LEGACY ) +return true; + +if (!intel_bios_encoder_supports_dyn_port_over_tc (dig_port->base.devdata))
dedicated_externalis stored separately indig_port, why the "related"dyn_port_over_tcflag isn't?The only reason
dedicated_externalis stored is because VBT data is already freed by the timeintel_encoder_is_tc()is called in the driver unbind path. In the future we should fix the VBT lifetime issue in order to be able to drop thededicated_externalmember ofdig_port.Quoted 18 lines
Quoted 18 lines
drivers/gpu/drm/i915/display/intel_tc.c +17
-0+return true; + +if (iom_dp_resource_lock (tc)) +return false; + + val =intel_de_read (display,IOM_DP_RESOURCE_MNG ); + + consumer = val &IOM_DDI_CONSUMER_MASK (tc_port); + consumer >>=IOM_DDI_CONSUMER_SHIFT (tc_port); + +/* +* Bspec instructs to select first available DDI, but our driver is not +* ready for such dynamic allocation yet. For now, we force a "static" +* allocation: map the physical port (where HPD happens) to the +* encoder's DDI (logical TC port, represented by tc_port). +*/ + expected_consumer =IOM_DDI_CONSUMER_STATIC_TC (tc_port);
Quoted 8 lines
Quoted 1 line
Quoted 1 line
drivers/gpu/drm/i915/display/intel_tc.c static void xelpdp_tc_phy_get_hw_state(struct intel_tc_port *tc) · line 1287
Quoted 1 line
drivers/gpu/drm/i915/display/intel_tc.c +1
-0+ expected_consumer >>=IOM_DDI_CONSUMER_SHIFT (tc_port);One more thing occured to me: why can't this allocate any free DDI? IOW does the address of
DDI_BUF_CTL(akaDDI_CTL_DE) used fortc_portdepend on which DDI gets allocated (or is there any other dependency on which DDI got allocated)? AFAICS there is no such dependency and the above address would beDDI_BUF_CTL(encoder->port)regardless of the allocated DDI. In that case any free DDI could be allocated here.
Ok, checking this again, DDI_BUF_CTL etc. DDI register addresses will depend on the allocated DDI. So nvm the above, the mapping needs to stay 1:1 for now until all the DDI reg accesses are converted to index the registers with the allocated DDI index.
Quoted 129 lines
Quoted 76 lines
Quoted 63 lines
Quoted 63 lines
drivers/gpu/drm/i915/display/intel_tc.c +56
-0+ +if (allocate) { +struct intel_encoder *other_encoder; + +/* +* Check if this encoder's DDI is already allocated for another +* physical port, which could have happened prior to the driver +* taking over (e.g. GOP). +*/ +for_each_intel_encoder (display->drm, other_encoder) { +enum tc_port other_tc_port =intel_encoder_to_tc (other_encoder); +u32 other_consumer; + +if (tc_port ==TC_PORT_NONE || other_tc_port == tc_port) +continue ; + + other_consumer = val &IOM_DDI_CONSUMER_MASK (other_tc_port); + other_consumer >>=IOM_DDI_CONSUMER_SHIFT (other_tc_port); +if (other_consumer == expected_consumer) { +drm_err (display->drm,"Port %s: expected consumer %u already allocated another DDI; IOM_DP_RESOURCE_MNG=0x%08x\n" , + tc->port_name, expected_consumer, val); + ret = false; + goto out_resource_unlock; + } + } + +if (consumer ==0 ) { +/* DDI is free to use, let's allocate it. */ + val &= ~IOM_DDI_CONSUMER_MASK (tc_port); + val |=IOM_DDI_CONSUMER (tc_port, expected_consumer); +intel_de_write (display,IOM_DP_RESOURCE_MNG , val); + ret = true; + }else if (consumer == expected_consumer) { +/* +* Nothing to do, as the expected "static" DDI allocation is +* already in place. +*/ + ret = true; + }else { +drm_err (display->drm,"Port %s: DDI already allocated for consumer %u; IOM_DP_RESOURCE_MNG=0x%08x\n" , + tc->port_name, consumer, val); + ret = false; + } + }else { +drm_WARN_ON (display->drm, consumer != expected_consumer); + val &= ~IOM_DDI_CONSUMER_MASK (tc_port); +intel_de_write (display,IOM_DP_RESOURCE_MNG , val); + ret = true; + } + +out_resource_unlock: +iom_dp_resource_unlock (tc); + +return ret; +} +static bool xelpdp_tc_phy_connect (struct intel_tc_port *tc,int required_lanes) { tc->lock_wakeref =tc_cold_block (tc);@@ -1210,9 +1351,12 @@ static bool xelpdp_tc_phy_connect(struct intel_tc_port *tc, int required_lanes)return true; }Quoted 12 lines
drivers/gpu/drm/i915/display/intel_tc.c static bool xelpdp_tc_phy_connect(struct intel_tc_port *tc, int required_lanes) · line 1354
Quoted 2 lines
drivers/gpu/drm/i915/display/intel_tc.c +1
-1-if (!xelpdp_tc_phy_enable_tcss_power (tc, true)) +if (!xe3p_tc_iom_allocate_ddi (tc, true))This doesn't work. A connector registered to userspace must be always functional (except for MST connectors which are dynamically registered). So the DDI allocation and with that connecting the PHY cannot fail here for a legacy connector/PHY. Instead of this the allocation could be moved to happen already in
intel_tc_phy_ops::initfor now, allocating a DDI for a legacy PHY (intel_tc_port::legacy_port== true) and if that fails also fail the corresponding connector/encoder registration inintel_ddi_init(). The DDI would need to be released byintel_tc_port_cleanup().Quoted 7 lines
Ah, I see. Well, I guess for legacy connections, doing your suggestion seems fine.
Is there any power management aspect that we should be aware here? Like, some power well being disabled and causing the allocation to be "lost" somehow. Since this thing is in the TCSS, I think no display power wells could cause that, right?
It would make sense to me that the allocations are preserved by the HW/FW across power transitions. If that's not the case then they should be restored by the driver.
Quoted 2 lines
By the way, I wonder how we would handle things in the future when/if we enable the dynamic DDI allocation thing.
In case of a DDI allocation failure, the modeset will still succeed, but the corresponding port/pipe will not get enabled.
Quoted 35 lines
--
Gustavo SousaQuoted 32 lines
Quoted 32 lines
drivers/gpu/drm/i915/display/intel_tc.c +8
-0goto out_unblock_tccold; +if (!xelpdp_tc_phy_enable_tcss_power (tc, true)) + goto out_deallocate_ddi; +xelpdp_tc_phy_take_ownership (tc, true);read_pin_configuration (tc);@@ -1226,6 +1370,9 @@ static bool xelpdp_tc_phy_connect(struct intel_tc_port *tc, int required_lanes)xelpdp_tc_phy_take_ownership (tc, false);xelpdp_tc_phy_wait_for_tcss_power (tc, false); +out_deallocate_ddi: +xe3p_tc_iom_allocate_ddi (tc, false); + out_unblock_tccold:tc_cold_unblock (tc,fetch_and_zero (&tc->lock_wakeref));@@ -1236,6 +1383,8 @@ static void xelpdp_tc_phy_disconnect(struct intel_tc_port *tc) {switch (tc->mode) {case TC_PORT_LEGACY : +xe3p_tc_iom_allocate_ddi (tc, false); + fallthrough;case TC_PORT_DP_ALT :xelpdp_tc_phy_take_ownership (tc, false);xelpdp_tc_phy_enable_tcss_power (tc, false);Signature · 2 lines
-- 2.51.0
Re: [PATCH v4 07/11] drm/i915/xe3p_lpd: Extend Type-C flow for static DDI allocation
Quoting Imre Deak (2025-11-14 22:22:32-03:00)
Quoted 296 lines · Imre Deak
Quoted 286 lines · Gustavo Sousa
Quoted 64 lines
Quoting Imre Deak (2025-11-12 14:53:47-03:00)
Quoted 54 lines · Gustavo Sousa
Quoted 53 lines
Xe3p_LPDhas a new feature that allows the driver to allocate at runtime the DDI (TC ones) port to drive a legacy connection on the Type-C subsystem. This allows better resource utilization, because now there is no need to statically reserve ports for legacy connectors on the Type-C subsystem.That said, our driver is not yet ready for the dynamic allocation. Thus, as an incremental step, let's add the logic containing the required programming sequence for the allocation, but, instead of selecting the first available port, we try so use the 1:1 mapping expected by the driver today.
Bspec: 68954
Co-developed-by Dnyaneshwar Bhadane <[email protected]>Signed-off-by Dnyaneshwar Bhadane <[email protected]>Signed-off-by Gustavo Sousa <[email protected]>---
NOTE: This patch is still a WIP. There are some opens to resolve here. Nevertheless, I'm sending it here for early feedback.
For the HIP-index stuff, I have a local refactor started and need to finish it up and send it.
The other open is about concurrent calls to
iom_dp_resource_lock(). It is likely that we need to have a software lock to prevent concurrent access toIOM_DP_HW_RESOURCE_SEMAPHOREfrom our driver.--- drivers/gpu/drm/i915/display/intel_display_regs.h | 20 ++- drivers/gpu/drm/i915/display/intel_tc.c | 151 +++++++++++++++++++++- 2 files changed, 169 insertions(+), 2 deletions(-)drivers/gpu/drm/i915/display/intel_display_regs.h +13
-0@@ -2908,6 +2908,25 @@ enum skl_power_gate {#define DP_PIN_ASSIGNMENT (idx, x) ((x) << ((idx) * 4))/* See enum intel_tc_pin_assignment for the pin assignment field values. */ +/* +* FIXME: There is also a definition for this register in intel_dkl_phy_regs.h. +* We need to consolidate the definitions. +*/ +#define HIP_INDEX_REG0 _MMIO(0x1010a0) +#define HIP_168_INDEX_MASK REG_GENMASK(3, 0) +#define HIP_168_IOM_RES_MGMT REG_FIELD_PREP(HIP_168_INDEX_MASK, 0x1) + +#define IOM_DP_HW_RESOURCE_SEMAPHORE _MMIO(0x168038) +#define IOM_DP_HW_SEMLOCK REG_BIT(31) +#define IOM_REQUESTOR_ID_MASK REG_GENMASK(3, 0) +#define IOM_REQUESTOR_ID_DISPLAY_ENGINE REG_FIELD_PREP(IOM_REQUESTOR_ID_MASK, 0x4) +Quoted 8 lines
drivers/gpu/drm/i915/display/intel_display_regs.h enum skl_power_gate { · line 2928
Quoted 5 lines
drivers/gpu/drm/i915/display/intel_display_regs.h +5
-0+#define IOM_DP_RESOURCE_MNG _MMIO(0x16802c) +#define IOM_DDI_CONSUMER_SHIFT (tc_port) ((tc_port) * 4) +#define IOM_DDI_CONSUMER_MASK (tc_port) (0xf << IOM_DDI_CONSUMER_SHIFT(tc_port)) +#define IOM_DDI_CONSUMER (tc_port, x) ((x) << IOM_DDI_CONSUMER_SHIFT(tc_port)) +#define IOM_DDI_CONSUMER_STATIC_TC (tc_port) IOM_DDI_CONSUMER(tc_port, 0x8 + (tc_port))It would be simpler to define the above without the shift, i.e. as 8 +
tc_port.Quoted 8 lines
You mean something like this?
#define
IOM_DDI_CONSUMER_STATIC_TC(tc_port)(0x8+ (tc_port))?
Yeah... Looking at the code, we wouldn't need to shift back when defining
expected_consumer.Yes.
Quoted 65 lines
Quoted 28 lines
Quoted 28 lines
drivers/gpu/drm/i915/display/intel_display_regs.h +1
-1+#define _TCSS_DDI_STATUS_1 0x161500#define _TCSS_DDI_STATUS_2 0x161504#define TCSS_DDI_STATUS (tc) _MMIO(_PICK_EVEN(tc, \@@ -2946,5 +2965,4 @@ enum skl_power_gate {#define MTL_TRDPRE_MASK REG_GENMASK(7, 0) -#endif /* __INTEL_DISPLAY_REGS_H__ */ drivers/gpu/drm/i915/display/intel_tc.c +1
-0@@ -9,6 +9,7 @@#include "i915_reg.h" #include "intel_atomic.h" +#include "intel_bios.h" #include "intel_cx0_phy_regs.h" #include "intel_ddi.h" #include "intel_de.h" @@ -25,6 +26,9 @@#include "intel_modeset_lock.h" #include "intel_tc.h" Quoted 7 lines
drivers/gpu/drm/i915/display/intel_tc.c line 30
Quoted 2 lines
drivers/gpu/drm/i915/display/intel_tc.c +2
-0+#define IOM_DP_RES_SEMAPHORE_LOCK_TIMEOUT_US 10 +#define IOM_DP_RES_SEMAPHORE_RETRY_TIMEOUT_US 10000The above param names should make it clear how
poll_timeout_us()uses them (i.e. stg like sleep vs. timeout instead oflock_timeoutvs.retry_timeout), but probably even clearer to just drop the defines and inline the values in the call.Ack. I going with the latter.
Quoted 18 lines
Quoted 18 lines
drivers/gpu/drm/i915/display/intel_tc.c +10
-0+enum tc_port_mode {TC_PORT_DISCONNECTED ,TC_PORT_TBT_ALT ,@@ -1200,6 +1204,143 @@ static void xelpdp_tc_phy_get_hw_state(struct intel_tc_port *tc)__tc_cold_unblock (tc, domain, tc_cold_wref); } +static void iom_res_mgmt_prepare_reg_access (struct intel_display *display) +{ +/* +* IOM resource management registers live in the 2nd 4KB page of IOM +* address space. So we need to configure HIP_INDEX_REG0 with the +* correct index. +* +* FIXME: We need to have this and dekel PHY implementation using a +* common abstraction to access registers on the HIP-indexed ranges, and Quoted 8 lines
drivers/gpu/drm/i915/display/intel_tc.c static void xelpdp_tc_phy_get_hw_state(struct intel_tc_port *tc) · line 1219
Quoted 4 lines
drivers/gpu/drm/i915/display/intel_tc.c +4
-0+* this function would then be dropped. +*/ +intel_de_rmw (display,HIP_INDEX_REG0 , +HIP_168_INDEX_MASK ,HIP_168_IOM_RES_MGMT );This matches what
intel_dkl_phy.cdoes, that one also taking the required lock around the access. At one point theintel_dkl_phyfile/interface could be renamed tointel_tc_regor similar accordingly.Quoted 5 lines
I have already started a local series that introduces the "HIP-index based registers" abstraction. I need to go back to finish it up.
The basic idea is that both
intel_dkl_phy.cand this IOM stuff would use functions specific to accessing registers behind the HIP-based ranges.Using
intel_hip_reginstead ofintel_tc_regis probably better, but I still think the current interface should be just renamed, instead of adding a new interface and making the current intel_dkl_phy_read/write/rmw() use that new interface.I went ahead and put the above together now:
https://github.com/ideak/linux/commits/hip-regQuoted 131 lines
To give an idea, here is a copy/paste of the kerneldoc I currently have in that WIP series:
| diff --git a/drivers/gpu/drm/i915/display/intel_hip_idx.c b/drivers/gpu/drm/i915/display/intel_hip_idx.c | new file mode 100644 | index 000000000000..ff2492b8275d | --- /dev/null | +++ b/drivers/gpu/drm/i915/display/intel_hip_idx.c | @@ -0,0 +1,110 @@ | +// SPDX-License-Identifier: MIT | +/* | + * Copyright (C) 2025 Intel Corporation | + */ | + | +/** | + * DOC: Display HIP-indexed register access | + * | + * Display MMIO mapping for offsets in [0x168000,0x16ffff] are governed by | + * configurations in the HIP_INDEX registers provided by the hardware. | + * | + * Usually each of the valid 4KB range in that space will be mapped to some IP | + * block, providing access to registers of that IP. The HIP_INDEX registers | + * expose an 8-bit index value for each 4KB range. Those indices provide a way | + * to access data that is beyond the initial 4KB block provided by the target | + * IP. | + * | + * As an example, say that the range [0x16a000,0x16afff] is mapped to some | + * sub-IP that contains a 8KB register file. To access the initial 4KB of that | + * register file, we would need to set the index respective to | + * [0x16a000,0x16afff] in HIP_INDEX to 0; to access data in the second 4KB | + * window, we would need to set the index to 1. | + * | + * For simple read, write or rmw operations on a single register, the | + * functions intel_hip_idx_reg_read(), intel_hip_idx_reg_write() and | + * intel_hip_idx_reg_rmw() can be used, which will call intel_hip_idx_lock() | + * and intel_hip_idx_unlock() internally. | + * | + * For other scenarios, then it is necessary to wrap the register accesses | + * with explicit calls to intel_hip_idx_lock() and intel_hip_idx_unlock(), and | + * use the MMIO functions provided by intel_de.h. For the latter, the function | + * intel_hip_idx_reg_to_i915_reg() needs to be used in order to provide the | + * correct reg argument to those functions. | + */ | (...)Quoted 11 lines
Quoted 11 lines
drivers/gpu/drm/i915/display/intel_tc.c +10
-0+} + +/* +* FIXME: This function also needs to avoid concurrent accesses from the driver +* itself, possibly via a software lock. +*/ +static int iom_dp_resource_lock (struct intel_tc_port *tc) +{ +struct intel_display *display =to_intel_display (tc->dig_port); +u32 val =IOM_DP_HW_SEMLOCK |IOM_REQUESTOR_ID_DISPLAY_ENGINE ;Quoted 8 lines
drivers/gpu/drm/i915/display/intel_tc.c static void xelpdp_tc_phy_get_hw_state(struct intel_tc_port *tc) · line 1234
Quoted 5 lines
drivers/gpu/drm/i915/display/intel_tc.c +5
-0+int ret; + +iom_res_mgmt_prepare_reg_access (display); + ret = poll_timeout_us(intel_de_write(display, IOM_DP_HW_RESOURCE_SEMAPHORE, val), + (intel_de_read(display, IOM_DP_HW_RESOURCE_SEMAPHORE) & val) == val,This happens to work, but it's more future proof/bspec conformant to properly mask the requestor ID field when reading it back.
Agreed.
Quoted 31 lines
Quoted 31 lines
drivers/gpu/drm/i915/display/intel_tc.c +30
-0+IOM_DP_RES_SEMAPHORE_LOCK_TIMEOUT_US , + IOM_DP_RES_SEMAPHORE_RETRY_TIMEOUT_US, false); + +if (ret) +drm_err (display->drm,"Port %s: timeout trying to lock IOM semaphore\n" , + tc->port_name); + +return ret; +} + +static void iom_dp_resource_unlock (struct intel_tc_port *tc) +{ +struct intel_display *display =to_intel_display (tc->dig_port); + +iom_res_mgmt_prepare_reg_access (display); +intel_de_write (display,IOM_DP_HW_RESOURCE_SEMAPHORE ,IOM_REQUESTOR_ID_DISPLAY_ENGINE ); +} + +static bool xe3p_tc_iom_allocate_ddi (struct intel_tc_port *tc,bool allocate) +{ +struct intel_display *display =to_intel_display (tc->dig_port); +struct intel_digital_port *dig_port = tc->dig_port; +enum tc_port tc_port =intel_encoder_to_tc (&dig_port->base); +u32 val; +u32 consumer; +u32 expected_consumer; +bool ret; + +if (DISPLAY_VER (display) <35 ) +return true;Quoted 8 lines
drivers/gpu/drm/i915/display/intel_tc.c static void xelpdp_tc_phy_get_hw_state(struct intel_tc_port *tc) · line 1269
Quoted 5 lines
drivers/gpu/drm/i915/display/intel_tc.c +5
-0+ +if (tc->mode !=TC_PORT_LEGACY ) +return true; + +if (!intel_bios_encoder_supports_dyn_port_over_tc (dig_port->base.devdata))
dedicated_externalis stored separately indig_port, why the "related"dyn_port_over_tcflag isn't?The only reason
dedicated_externalis stored is because VBT data is already freed by the timeintel_encoder_is_tc()is called in the driver unbind path. In the future we should fix the VBT lifetime issue in order to be able to drop thededicated_externalmember ofdig_port.Quoted 18 lines
Quoted 18 lines
drivers/gpu/drm/i915/display/intel_tc.c +17
-0+return true; + +if (iom_dp_resource_lock (tc)) +return false; + + val =intel_de_read (display,IOM_DP_RESOURCE_MNG ); + + consumer = val &IOM_DDI_CONSUMER_MASK (tc_port); + consumer >>=IOM_DDI_CONSUMER_SHIFT (tc_port); + +/* +* Bspec instructs to select first available DDI, but our driver is not +* ready for such dynamic allocation yet. For now, we force a "static" +* allocation: map the physical port (where HPD happens) to the +* encoder's DDI (logical TC port, represented by tc_port). +*/ + expected_consumer =IOM_DDI_CONSUMER_STATIC_TC (tc_port);Quoted 8 lines
Quoted 1 line
Quoted 1 line
drivers/gpu/drm/i915/display/intel_tc.c static void xelpdp_tc_phy_get_hw_state(struct intel_tc_port *tc) · line 1287
Quoted 1 line
drivers/gpu/drm/i915/display/intel_tc.c +1
-0+ expected_consumer >>=IOM_DDI_CONSUMER_SHIFT (tc_port);One more thing occured to me: why can't this allocate any free DDI? IOW does the address of
DDI_BUF_CTL(akaDDI_CTL_DE) used fortc_portdepend on which DDI gets allocated (or is there any other dependency on which DDI got allocated)? AFAICS there is no such dependency and the above address would beDDI_BUF_CTL(encoder->port)regardless of the allocated DDI. In that case any free DDI could be allocated here.
Quoted 4 lines
Ok, checking this again,
DDI_BUF_CTLetc. DDI register addresses will depend on the allocated DDI. So nvm the above, the mapping needs to stay 1:1 for now until all the DDI reg accesses are converted to index the registers with the allocated DDI index.
As far as I understand this, especially after talking with Windows folks, the allocated DDI will define the port index for the whole programming, including the registers used to program the PHY - and the hardware would take care of routing to the correct PHY.
Thus, it appears we would need to do the allocation at hotplug time, like saying "this PHY will be driven by DDI x".
One of the reasons I think we can't allocate a free DDI at the moment is that the driver is expecting a 1:1 static mapping for HPD interations. We will neeed to make the driver aware of the mapping in order to use the correct encoder when handling HPD events.
--
Gustavo Sousa
Re: [PATCH v4 07/11] drm/i915/xe3p_lpd: Extend Type-C flow for static DDI allocation
Quoted 30 lines · Gustavo Sousa
[...]
Quoted 24 lines
Quoted 15 lines
Quoted 15 lines
Quoted 15 lines
Quoted 15 lines
drivers/gpu/drm/i915/display/intel_tc.c +15
-0+if (iom_dp_resource_lock (tc)) +return false; + + val =intel_de_read (display,IOM_DP_RESOURCE_MNG ); + + consumer = val &IOM_DDI_CONSUMER_MASK (tc_port); + consumer >>=IOM_DDI_CONSUMER_SHIFT (tc_port); + +/* +* Bspec instructs to select first available DDI, but our driver is not +* ready for such dynamic allocation yet. For now, we force a "static" +* allocation: map the physical port (where HPD happens) to the +* encoder's DDI (logical TC port, represented by tc_port). +*/ + expected_consumer =IOM_DDI_CONSUMER_STATIC_TC (tc_port);Quoted 8 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
+
expected_consumer>>=IOM_DDI_CONSUMER_SHIFT(tc_port);One more thing occured to me: why can't this allocate any free DDI? IOW does the address of
DDI_BUF_CTL(akaDDI_CTL_DE) used fortc_portdepend on which DDI gets allocated (or is there any other dependency on which DDI got allocated)? AFAICS there is no such dependency and the above address would beDDI_BUF_CTL(encoder->port)regardless of the allocated DDI. In that case any free DDI could be allocated here.Quoted 4 lines
Ok, checking this again,
DDI_BUF_CTLetc. DDI register addresses will depend on the allocated DDI. So nvm the above, the mapping needs to stay 1:1 for now until all the DDI reg accesses are converted to index the registers with the allocated DDI index.
Quoted 4 lines
As far as I understand this, especially after talking with Windows folks, the allocated DDI will define the port index for the whole programming, including the registers used to program the PHY - and the hardware would take care of routing to the correct PHY.
Correct, that's how I also understood it after "checking this again".
Quoted 2 lines
Thus, it appears we would need to do the allocation at hotplug time, like saying "this PHY will be driven by DDI x".
To clarify, if the mapping is 1:1, as in this patch, the allocation can be done statically during driver loading as discussed earlier. This is the only way it will work atm, because the DDI allocation cannot fail during runtime.
Quoted 4 lines
One of the reasons I think we can't allocate a free DDI at the moment is that the driver is expecting a 1:1 static mapping for HPD interations. We will neeed to make the driver aware of the mapping in order to use the correct encoder when handling HPD events.
Again clarifying, that the above is true only for legacy connectors. IOW for a TBT/DP-alt connector, where IOM does the DDI allocation, the HPD IRQ delivered to the driver will be already according to the allocated DDI. That is those connectors are _different_ wrt. to the mapping requirement than the dynamic legacy connectors, for those TBT/DP-alt connectors the DDI registers will be accessed based on the tc_port/encoder->port to which the HPD IRQ is delivered.
Quoted 2 lines
--
Gustavo Sousa
Re: [PATCH v4 07/11] drm/i915/xe3p_lpd: Extend Type-C flow for static DDI allocation
Quoting Imre Deak (2025-11-17 12:17:48-03:00)
Quoted 38 lines · Gustavo Sousa
Quoted 30 lines
[...]
Quoted 24 lines
Quoted 15 lines
Quoted 15 lines
Quoted 15 lines
Quoted 15 lines
(quoted diff) +15
-0+ if (iom_dp_resource_lock(tc)) + return false; + + val = intel_de_read(display, IOM_DP_RESOURCE_MNG); + + consumer = val & IOM_DDI_CONSUMER_MASK(tc_port); + consumer >>= IOM_DDI_CONSUMER_SHIFT(tc_port); + + /* + * Bspec instructs to select first available DDI, but our driver is not + * ready for such dynamic allocation yet. For now, we force a "static" + * allocation: map the physical port (where HPD happens) to the + * encoder's DDI (logical TC port, represented by tc_port). + */ + expected_consumer = IOM_DDI_CONSUMER_STATIC_TC(tc_port);Quoted 8 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
+
expected_consumer>>=IOM_DDI_CONSUMER_SHIFT(tc_port);One more thing occured to me: why can't this allocate any free DDI? IOW does the address of
DDI_BUF_CTL(akaDDI_CTL_DE) used fortc_portdepend on which DDI gets allocated (or is there any other dependency on which DDI got allocated)? AFAICS there is no such dependency and the above address would beDDI_BUF_CTL(encoder->port)regardless of the allocated DDI. In that case any free DDI could be allocated here.Quoted 4 lines
Ok, checking this again,
DDI_BUF_CTLetc. DDI register addresses will depend on the allocated DDI. So nvm the above, the mapping needs to stay 1:1 for now until all the DDI reg accesses are converted to index the registers with the allocated DDI index.Quoted 4 lines
As far as I understand this, especially after talking with Windows folks, the allocated DDI will define the port index for the whole programming, including the registers used to program the PHY - and the hardware would take care of routing to the correct PHY.
Correct, that's how I also understood it after "checking this again".
Quoted 7 lines
Quoted 2 lines
Thus, it appears we would need to do the allocation at hotplug time, like saying "this PHY will be driven by DDI x".
To clarify, if the mapping is 1:1, as in this patch, the allocation can be done statically during driver loading as discussed earlier. This is the only way it will work atm, because the DDI allocation cannot fail during runtime.
Two scenarios that come to mind about doing this on probe time:
1) The driver could be loaded with nothing yet attached to the legacy connector. However, I believe the TCSS doesn't require the connector to be attached for the allocation to work. So, we are probably fine here.
2) If the legacy connector is never used during the driver's lifetime, we are basically holding a resource that could have been used by a DP-alt/TBT connection.
For the dynamic feature (to be implemented in the future), how to you see this?
1) Should we allocate the DDI at HPD time and fail report the connector as disconnected on failure?
2) Should we allocate the DDI as part of the atomic check phase and fail the modeset if we can't do it?
3) Should we allocate the DDI as part of the atomic tail (hardware commit) and raise errors if the allocation fails?
Another question: once we implement the dynamic feature, this "allocate on probe time" thing will have to go away, right? In that case, we would basically suffer the same runtime risks that we would be trying to avoid, no?
Perhaps I'm missing something, but, if not: I wonder if doing the "allocate on probe time" thing is really worth implementing, since it will be a "temporary" thing that would be reverted later. In that case, we could try implementing the static allocation in the same place where dynamic allocation would happen.
Quoted 6 lines
Quoted 5 lines
One of the reasons I think we can't allocate a free DDI at the moment is that the driver is expecting a 1:1 static mapping for HPD interations. We will neeed to make the driver aware of the mapping in order to use the correct encoder when handling HPD events.
Quoted 7 lines
Again clarifying, that the above is true only for legacy connectors. IOW for a TBT/DP-alt connector, where IOM does the DDI allocation, the HPD IRQ delivered to the driver will be already according to the allocated DDI. That is those connectors are _different_ wrt. to the mapping requirement than the dynamic legacy connectors, for those TBT/DP-alt connectors the DDI registers will be accessed based on the tc_port/encoder->port to which the HPD IRQ is delivered.
That's my understanding as well.
--
Gustavo Sousa
Re: [PATCH v4 07/11] drm/i915/xe3p_lpd: Extend Type-C flow for static DDI allocation
Quoted 49 lines · Gustavo Sousa
Quoting Imre Deak (2025-11-17 12:17:48-03:00)
Quoted 38 lines · Gustavo Sousa
Quoted 30 lines
[...]
Quoted 24 lines
Quoted 15 lines
Quoted 15 lines
Quoted 15 lines
Quoted 15 lines
(quoted diff) +15
-0+ if (iom_dp_resource_lock(tc)) + return false; + + val = intel_de_read(display, IOM_DP_RESOURCE_MNG); + + consumer = val & IOM_DDI_CONSUMER_MASK(tc_port); + consumer >>= IOM_DDI_CONSUMER_SHIFT(tc_port); + + /* + * Bspec instructs to select first available DDI, but our driver is not + * ready for such dynamic allocation yet. For now, we force a "static" + * allocation: map the physical port (where HPD happens) to the + * encoder's DDI (logical TC port, represented by tc_port). + */ + expected_consumer = IOM_DDI_CONSUMER_STATIC_TC(tc_port);Quoted 8 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
+
expected_consumer>>=IOM_DDI_CONSUMER_SHIFT(tc_port);One more thing occured to me: why can't this allocate any free DDI? IOW does the address of
DDI_BUF_CTL(akaDDI_CTL_DE) used fortc_portdepend on which DDI gets allocated (or is there any other dependency on which DDI got allocated)? AFAICS there is no such dependency and the above address would beDDI_BUF_CTL(encoder->port)regardless of the allocated DDI. In that case any free DDI could be allocated here.Quoted 4 lines
Ok, checking this again,
DDI_BUF_CTLetc. DDI register addresses will depend on the allocated DDI. So nvm the above, the mapping needs to stay 1:1 for now until all the DDI reg accesses are converted to index the registers with the allocated DDI index.Quoted 4 lines
As far as I understand this, especially after talking with Windows folks, the allocated DDI will define the port index for the whole programming, including the registers used to program the PHY - and the hardware would take care of routing to the correct PHY.
Correct, that's how I also understood it after "checking this again".
Quoted 7 lines
Quoted 2 lines
Thus, it appears we would need to do the allocation at hotplug time, like saying "this PHY will be driven by DDI x".
To clarify, if the mapping is 1:1, as in this patch, the allocation can be done statically during driver loading as discussed earlier. This is the only way it will work atm, because the DDI allocation cannot fail during runtime.
Two scenarios that come to mind about doing this on probe time:
Quoted 8 lines
1) The driver could be loaded with nothing yet attached to the legacy connector. However, I believe the TCSS doesn't require the connector to be attached for the allocation to work. So, we are probably fine here.
2) If the legacy connector is never used during the driver's lifetime, we are basically holding a resource that could have been used by a DP-alt/TBT connection.
Yes, this is also the way how things work at the moment: a legacy connector reserves a DDI whether or not a sink will be connected to it. I think keeping that existing behavior for now is what makes sense.
Quoted 9 lines
For the dynamic feature (to be implemented in the future), how to you see this?
1) Should we allocate the DDI at HPD time and fail report the connector as disconnected on failure?
2) Should we allocate the DDI as part of the atomic check phase and fail the modeset if we can't do it?
3) Should we allocate the DDI as part of the atomic tail (hardware commit) and raise errors if the allocation fails?
I think the only way for enabling the dynamic allocation of DDIs is to do that whenever the PHY is used, i.e. when the PHY is connected via intel_tc_port_lock() or intel_tc_port_get_link(). That's because even AUX transfers for a detection need an allocated DDI. This is what the patch is currently doing, however, that can be done only once the remapping of a connector/encoder -> allocated DDI is in place and the driver can also handle a modeset on a legacy connector for which the DDI allocation fails.
Quoted 2 lines
Another question: once we implement the dynamic feature, this "allocate on probe time" thing will have to go away, right?
The allocation would simply have to moved back to happen during connecting the PHY.
Quoted 2 lines
In that case, we would basically suffer the same runtime risks that we would be trying to avoid, no?
No, then the driver will be able to handle a modeset for a legacy connector without a DDI allocated to it.
Quoted 5 lines
Perhaps I'm missing something, but, if not: I wonder if doing the "allocate on probe time" thing is really worth implementing, since it will be a "temporary" thing that would be reverted later. In that case, we could try implementing the static allocation in the same place where dynamic allocation would happen.
I still think for now it makes sense to implement the allocate on probe time thing, which is simple enough and provides what we have now (legacy connectors keep a DDI reserved). Adding support for dynamic DDI allocations will allow enabling 3 TBT DP tunnels instead of the current 2 DP tunnels for instance, but this requires a lot of changes affecting current platforms as well. I think moving back the allocation to happen during connecting the PHY - when the changes for that are in place - would be also simple.
Quoted 17 lines
Quoted 5 lines
Quoted 4 lines
One of the reasons I think we can't allocate a free DDI at the moment is that the driver is expecting a 1:1 static mapping for HPD interations. We will neeed to make the driver aware of the mapping in order to use the correct encoder when handling HPD events.
Quoted 7 lines
Again clarifying, that the above is true only for legacy connectors. IOW for a TBT/DP-alt connector, where IOM does the DDI allocation, the HPD IRQ delivered to the driver will be already according to the allocated DDI. That is those connectors are _different_ wrt. to the mapping requirement than the dynamic legacy connectors, for those TBT/DP-alt connectors the DDI registers will be accessed based on the tc_port/encoder->port to which the HPD IRQ is delivered.
That's my understanding as well.
--
Gustavo Sousa
Re: [PATCH v4 07/11] drm/i915/xe3p_lpd: Extend Type-C flow for static DDI allocation
In reply to Imre DeakQuoting Imre Deak (2025-11-14 21:40:24-03:00)
Quoted 147 lines · Gustavo Sousa
Quoted 64 lines
Quoting Imre Deak (2025-11-12 14:53:47-03:00)
Quoted 54 lines · Gustavo Sousa
Quoted 53 lines
Xe3p_LPDhas a new feature that allows the driver to allocate at runtime the DDI (TC ones) port to drive a legacy connection on the Type-C subsystem. This allows better resource utilization, because now there is no need to statically reserve ports for legacy connectors on the Type-C subsystem.That said, our driver is not yet ready for the dynamic allocation. Thus, as an incremental step, let's add the logic containing the required programming sequence for the allocation, but, instead of selecting the first available port, we try so use the 1:1 mapping expected by the driver today.
Bspec: 68954
Co-developed-by Dnyaneshwar Bhadane <[email protected]>Signed-off-by Dnyaneshwar Bhadane <[email protected]>Signed-off-by Gustavo Sousa <[email protected]>---
NOTE: This patch is still a WIP. There are some opens to resolve here. Nevertheless, I'm sending it here for early feedback.
For the HIP-index stuff, I have a local refactor started and need to finish it up and send it.
The other open is about concurrent calls to
iom_dp_resource_lock(). It is likely that we need to have a software lock to prevent concurrent access toIOM_DP_HW_RESOURCE_SEMAPHOREfrom our driver.--- drivers/gpu/drm/i915/display/intel_display_regs.h | 20 ++- drivers/gpu/drm/i915/display/intel_tc.c | 151 +++++++++++++++++++++- 2 files changed, 169 insertions(+), 2 deletions(-)drivers/gpu/drm/i915/display/intel_display_regs.h +13
-0@@ -2908,6 +2908,25 @@ enum skl_power_gate {#define DP_PIN_ASSIGNMENT (idx, x) ((x) << ((idx) * 4))/* See enum intel_tc_pin_assignment for the pin assignment field values. */ +/* +* FIXME: There is also a definition for this register in intel_dkl_phy_regs.h. +* We need to consolidate the definitions. +*/ +#define HIP_INDEX_REG0 _MMIO(0x1010a0) +#define HIP_168_INDEX_MASK REG_GENMASK(3, 0) +#define HIP_168_IOM_RES_MGMT REG_FIELD_PREP(HIP_168_INDEX_MASK, 0x1) + +#define IOM_DP_HW_RESOURCE_SEMAPHORE _MMIO(0x168038) +#define IOM_DP_HW_SEMLOCK REG_BIT(31) +#define IOM_REQUESTOR_ID_MASK REG_GENMASK(3, 0) +#define IOM_REQUESTOR_ID_DISPLAY_ENGINE REG_FIELD_PREP(IOM_REQUESTOR_ID_MASK, 0x4) +Quoted 8 lines
drivers/gpu/drm/i915/display/intel_display_regs.h enum skl_power_gate { · line 2928
Quoted 5 lines
drivers/gpu/drm/i915/display/intel_display_regs.h +5
-0+#define IOM_DP_RESOURCE_MNG _MMIO(0x16802c) +#define IOM_DDI_CONSUMER_SHIFT (tc_port) ((tc_port) * 4) +#define IOM_DDI_CONSUMER_MASK (tc_port) (0xf << IOM_DDI_CONSUMER_SHIFT(tc_port)) +#define IOM_DDI_CONSUMER (tc_port, x) ((x) << IOM_DDI_CONSUMER_SHIFT(tc_port)) +#define IOM_DDI_CONSUMER_STATIC_TC (tc_port) IOM_DDI_CONSUMER(tc_port, 0x8 + (tc_port))It would be simpler to define the above without the shift, i.e. as 8 +
tc_port.Quoted 8 lines
You mean something like this?
#define
IOM_DDI_CONSUMER_STATIC_TC(tc_port)(0x8+ (tc_port))?
Yeah... Looking at the code, we wouldn't need to shift back when defining
expected_consumer.Yes.
Quoted 65 lines
Quoted 28 lines
Quoted 28 lines
drivers/gpu/drm/i915/display/intel_display_regs.h +1
-1+#define _TCSS_DDI_STATUS_1 0x161500#define _TCSS_DDI_STATUS_2 0x161504#define TCSS_DDI_STATUS (tc) _MMIO(_PICK_EVEN(tc, \@@ -2946,5 +2965,4 @@ enum skl_power_gate {#define MTL_TRDPRE_MASK REG_GENMASK(7, 0) -#endif /* __INTEL_DISPLAY_REGS_H__ */ drivers/gpu/drm/i915/display/intel_tc.c +1
-0@@ -9,6 +9,7 @@#include "i915_reg.h" #include "intel_atomic.h" +#include "intel_bios.h" #include "intel_cx0_phy_regs.h" #include "intel_ddi.h" #include "intel_de.h" @@ -25,6 +26,9 @@#include "intel_modeset_lock.h" #include "intel_tc.h" Quoted 7 lines
drivers/gpu/drm/i915/display/intel_tc.c line 30
Quoted 2 lines
drivers/gpu/drm/i915/display/intel_tc.c +2
-0+#define IOM_DP_RES_SEMAPHORE_LOCK_TIMEOUT_US 10 +#define IOM_DP_RES_SEMAPHORE_RETRY_TIMEOUT_US 10000The above param names should make it clear how
poll_timeout_us()uses them (i.e. stg like sleep vs. timeout instead oflock_timeoutvs.retry_timeout), but probably even clearer to just drop the defines and inline the values in the call.Ack. I going with the latter.
Quoted 18 lines
Quoted 18 lines
drivers/gpu/drm/i915/display/intel_tc.c +10
-0+enum tc_port_mode {TC_PORT_DISCONNECTED ,TC_PORT_TBT_ALT ,@@ -1200,6 +1204,143 @@ static void xelpdp_tc_phy_get_hw_state(struct intel_tc_port *tc)__tc_cold_unblock (tc, domain, tc_cold_wref); } +static void iom_res_mgmt_prepare_reg_access (struct intel_display *display) +{ +/* +* IOM resource management registers live in the 2nd 4KB page of IOM +* address space. So we need to configure HIP_INDEX_REG0 with the +* correct index. +* +* FIXME: We need to have this and dekel PHY implementation using a +* common abstraction to access registers on the HIP-indexed ranges, and Quoted 8 lines
drivers/gpu/drm/i915/display/intel_tc.c static void xelpdp_tc_phy_get_hw_state(struct intel_tc_port *tc) · line 1219
Quoted 4 lines
drivers/gpu/drm/i915/display/intel_tc.c +4
-0+* this function would then be dropped. +*/ +intel_de_rmw (display,HIP_INDEX_REG0 , +HIP_168_INDEX_MASK ,HIP_168_IOM_RES_MGMT );This matches what
intel_dkl_phy.cdoes, that one also taking the required lock around the access. At one point theintel_dkl_phyfile/interface could be renamed tointel_tc_regor similar accordingly.Quoted 5 lines
I have already started a local series that introduces the "HIP-index based registers" abstraction. I need to go back to finish it up.
The basic idea is that both
intel_dkl_phy.cand this IOM stuff would use functions specific to accessing registers behind the HIP-based ranges.
Quoted 7 lines
Using
intel_hip_reginstead ofintel_tc_regis probably better, but I still think the current interface should be just renamed, instead of adding a new interface and making the current intel_dkl_phy_read/write/rmw() use that new interface.I went ahead and put the above together now:
https://github.com/ideak/linux/commits/hip-reg
I didn't take a look yet; will do later. But, since we are sharing, here is a squashed and untested version of what I have in my local WIP:
https://gitlab.freedesktop.org/gustavo/kernel/-/commit/25d16a7302d9b1e9b214ccd26943fd7903d4ea11
--
Gustavo Sousa
Quoted 270 lines
Quoted 125 lines
To give an idea, here is a copy/paste of the kerneldoc I currently have in that WIP series:
| diff --git a/drivers/gpu/drm/i915/display/intel_hip_idx.c b/drivers/gpu/drm/i915/display/intel_hip_idx.c | new file mode 100644 | index 000000000000..ff2492b8275d | --- /dev/null | +++ b/drivers/gpu/drm/i915/display/intel_hip_idx.c | @@ -0,0 +1,110 @@ | +// SPDX-License-Identifier: MIT | +/* | + * Copyright (C) 2025 Intel Corporation | + */ | + | +/** | + * DOC: Display HIP-indexed register access | + * | + * Display MMIO mapping for offsets in [0x168000,0x16ffff] are governed by | + * configurations in the HIP_INDEX registers provided by the hardware. | + * | + * Usually each of the valid 4KB range in that space will be mapped to some IP | + * block, providing access to registers of that IP. The HIP_INDEX registers | + * expose an 8-bit index value for each 4KB range. Those indices provide a way | + * to access data that is beyond the initial 4KB block provided by the target | + * IP. | + * | + * As an example, say that the range [0x16a000,0x16afff] is mapped to some | + * sub-IP that contains a 8KB register file. To access the initial 4KB of that | + * register file, we would need to set the index respective to | + * [0x16a000,0x16afff] in HIP_INDEX to 0; to access data in the second 4KB | + * window, we would need to set the index to 1. | + * | + * For simple read, write or rmw operations on a single register, the | + * functions intel_hip_idx_reg_read(), intel_hip_idx_reg_write() and | + * intel_hip_idx_reg_rmw() can be used, which will call intel_hip_idx_lock() | + * and intel_hip_idx_unlock() internally. | + * | + * For other scenarios, then it is necessary to wrap the register accesses | + * with explicit calls to intel_hip_idx_lock() and intel_hip_idx_unlock(), and | + * use the MMIO functions provided by intel_de.h. For the latter, the function | + * intel_hip_idx_reg_to_i915_reg() needs to be used in order to provide the | + * correct reg argument to those functions. | + */ | (...)Quoted 11 lines
Quoted 11 lines
drivers/gpu/drm/i915/display/intel_tc.c +10
-0+} + +/* +* FIXME: This function also needs to avoid concurrent accesses from the driver +* itself, possibly via a software lock. +*/ +static int iom_dp_resource_lock (struct intel_tc_port *tc) +{ +struct intel_display *display =to_intel_display (tc->dig_port); +u32 val =IOM_DP_HW_SEMLOCK |IOM_REQUESTOR_ID_DISPLAY_ENGINE ;Quoted 8 lines
drivers/gpu/drm/i915/display/intel_tc.c static void xelpdp_tc_phy_get_hw_state(struct intel_tc_port *tc) · line 1234
Quoted 5 lines
drivers/gpu/drm/i915/display/intel_tc.c +5
-0+int ret; + +iom_res_mgmt_prepare_reg_access (display); + ret = poll_timeout_us(intel_de_write(display, IOM_DP_HW_RESOURCE_SEMAPHORE, val), + (intel_de_read(display, IOM_DP_HW_RESOURCE_SEMAPHORE) & val) == val,This happens to work, but it's more future proof/bspec conformant to properly mask the requestor ID field when reading it back.
Agreed.
Quoted 31 lines
Quoted 31 lines
drivers/gpu/drm/i915/display/intel_tc.c +30
-0+IOM_DP_RES_SEMAPHORE_LOCK_TIMEOUT_US , + IOM_DP_RES_SEMAPHORE_RETRY_TIMEOUT_US, false); + +if (ret) +drm_err (display->drm,"Port %s: timeout trying to lock IOM semaphore\n" , + tc->port_name); + +return ret; +} + +static void iom_dp_resource_unlock (struct intel_tc_port *tc) +{ +struct intel_display *display =to_intel_display (tc->dig_port); + +iom_res_mgmt_prepare_reg_access (display); +intel_de_write (display,IOM_DP_HW_RESOURCE_SEMAPHORE ,IOM_REQUESTOR_ID_DISPLAY_ENGINE ); +} + +static bool xe3p_tc_iom_allocate_ddi (struct intel_tc_port *tc,bool allocate) +{ +struct intel_display *display =to_intel_display (tc->dig_port); +struct intel_digital_port *dig_port = tc->dig_port; +enum tc_port tc_port =intel_encoder_to_tc (&dig_port->base); +u32 val; +u32 consumer; +u32 expected_consumer; +bool ret; + +if (DISPLAY_VER (display) <35 ) +return true;Quoted 8 lines
drivers/gpu/drm/i915/display/intel_tc.c static void xelpdp_tc_phy_get_hw_state(struct intel_tc_port *tc) · line 1269
Quoted 5 lines
drivers/gpu/drm/i915/display/intel_tc.c +5
-0+ +if (tc->mode !=TC_PORT_LEGACY ) +return true; + +if (!intel_bios_encoder_supports_dyn_port_over_tc (dig_port->base.devdata))
dedicated_externalis stored separately indig_port, why the "related"dyn_port_over_tcflag isn't?The only reason
dedicated_externalis stored is because VBT data is already freed by the timeintel_encoder_is_tc()is called in the driver unbind path. In the future we should fix the VBT lifetime issue in order to be able to drop thededicated_externalmember ofdig_port.Quoted 11 lines
Quoted 11 lines
drivers/gpu/drm/i915/display/intel_tc.c +10
-0+return true; + +if (iom_dp_resource_lock (tc)) +return false; + + val =intel_de_read (display,IOM_DP_RESOURCE_MNG ); + + consumer = val &IOM_DDI_CONSUMER_MASK (tc_port); + consumer >>=IOM_DDI_CONSUMER_SHIFT (tc_port); +Quoted 8 lines
Quoted 8 lines
drivers/gpu/drm/i915/display/intel_tc.c static void xelpdp_tc_phy_get_hw_state(struct intel_tc_port *tc) · line 1287
Quoted 8 lines
drivers/gpu/drm/i915/display/intel_tc.c +8
-0+/* +* Bspec instructs to select first available DDI, but our driver is not +* ready for such dynamic allocation yet. For now, we force a "static" +* allocation: map the physical port (where HPD happens) to the +* encoder's DDI (logical TC port, represented by tc_port). +*/ + expected_consumer =IOM_DDI_CONSUMER_STATIC_TC (tc_port); + expected_consumer >>=IOM_DDI_CONSUMER_SHIFT (tc_port);One more thing occured to me: why can't this allocate any free DDI? IOW does the address of
DDI_BUF_CTL(akaDDI_CTL_DE) used fortc_portdepend on which DDI gets allocated (or is there any other dependency on which DDI got allocated)? AFAICS there is no such dependency and the above address would beDDI_BUF_CTL(encoder->port)regardless of the allocated DDI. In that case any free DDI could be allocated here.Quoted 76 lines
Quoted 63 lines
Quoted 63 lines
drivers/gpu/drm/i915/display/intel_tc.c +56
-0+ +if (allocate) { +struct intel_encoder *other_encoder; + +/* +* Check if this encoder's DDI is already allocated for another +* physical port, which could have happened prior to the driver +* taking over (e.g. GOP). +*/ +for_each_intel_encoder (display->drm, other_encoder) { +enum tc_port other_tc_port =intel_encoder_to_tc (other_encoder); +u32 other_consumer; + +if (tc_port ==TC_PORT_NONE || other_tc_port == tc_port) +continue ; + + other_consumer = val &IOM_DDI_CONSUMER_MASK (other_tc_port); + other_consumer >>=IOM_DDI_CONSUMER_SHIFT (other_tc_port); +if (other_consumer == expected_consumer) { +drm_err (display->drm,"Port %s: expected consumer %u already allocated another DDI; IOM_DP_RESOURCE_MNG=0x%08x\n" , + tc->port_name, expected_consumer, val); + ret = false; + goto out_resource_unlock; + } + } + +if (consumer ==0 ) { +/* DDI is free to use, let's allocate it. */ + val &= ~IOM_DDI_CONSUMER_MASK (tc_port); + val |=IOM_DDI_CONSUMER (tc_port, expected_consumer); +intel_de_write (display,IOM_DP_RESOURCE_MNG , val); + ret = true; + }else if (consumer == expected_consumer) { +/* +* Nothing to do, as the expected "static" DDI allocation is +* already in place. +*/ + ret = true; + }else { +drm_err (display->drm,"Port %s: DDI already allocated for consumer %u; IOM_DP_RESOURCE_MNG=0x%08x\n" , + tc->port_name, consumer, val); + ret = false; + } + }else { +drm_WARN_ON (display->drm, consumer != expected_consumer); + val &= ~IOM_DDI_CONSUMER_MASK (tc_port); +intel_de_write (display,IOM_DP_RESOURCE_MNG , val); + ret = true; + } + +out_resource_unlock: +iom_dp_resource_unlock (tc); + +return ret; +} +static bool xelpdp_tc_phy_connect (struct intel_tc_port *tc,int required_lanes) { tc->lock_wakeref =tc_cold_block (tc);@@ -1210,9 +1351,12 @@ static bool xelpdp_tc_phy_connect(struct intel_tc_port *tc, int required_lanes)return true; }Quoted 12 lines
drivers/gpu/drm/i915/display/intel_tc.c static bool xelpdp_tc_phy_connect(struct intel_tc_port *tc, int required_lanes) · line 1354
Quoted 2 lines
drivers/gpu/drm/i915/display/intel_tc.c +1
-1-if (!xelpdp_tc_phy_enable_tcss_power (tc, true)) +if (!xe3p_tc_iom_allocate_ddi (tc, true))This doesn't work. A connector registered to userspace must be always functional (except for MST connectors which are dynamically registered). So the DDI allocation and with that connecting the PHY cannot fail here for a legacy connector/PHY. Instead of this the allocation could be moved to happen already in
intel_tc_phy_ops::initfor now, allocating a DDI for a legacy PHY (intel_tc_port::legacy_port== true) and if that fails also fail the corresponding connector/encoder registration inintel_ddi_init(). The DDI would need to be released byintel_tc_port_cleanup().Quoted 7 lines
Ah, I see. Well, I guess for legacy connections, doing your suggestion seems fine.
Is there any power management aspect that we should be aware here? Like, some power well being disabled and causing the allocation to be "lost" somehow. Since this thing is in the TCSS, I think no display power wells could cause that, right?
It would make sense to me that the allocations are preserved by the HW/FW across power transitions. If that's not the case then they should be restored by the driver.
Quoted 2 lines
By the way, I wonder how we would handle things in the future when/if we enable the dynamic DDI allocation thing.
In case of a DDI allocation failure, the modeset will still succeed, but the corresponding port/pipe will not get enabled.
Quoted 35 lines
--
Gustavo SousaQuoted 32 lines
Quoted 32 lines
drivers/gpu/drm/i915/display/intel_tc.c +8
-0goto out_unblock_tccold; +if (!xelpdp_tc_phy_enable_tcss_power (tc, true)) + goto out_deallocate_ddi; +xelpdp_tc_phy_take_ownership (tc, true);read_pin_configuration (tc);@@ -1226,6 +1370,9 @@ static bool xelpdp_tc_phy_connect(struct intel_tc_port *tc, int required_lanes)xelpdp_tc_phy_take_ownership (tc, false);xelpdp_tc_phy_wait_for_tcss_power (tc, false); +out_deallocate_ddi: +xe3p_tc_iom_allocate_ddi (tc, false); + out_unblock_tccold:tc_cold_unblock (tc,fetch_and_zero (&tc->lock_wakeref));@@ -1236,6 +1383,8 @@ static void xelpdp_tc_phy_disconnect(struct intel_tc_port *tc) {switch (tc->mode) {case TC_PORT_LEGACY : +xe3p_tc_iom_allocate_ddi (tc, false); + fallthrough;case TC_PORT_DP_ALT :xelpdp_tc_phy_take_ownership (tc, false);xelpdp_tc_phy_enable_tcss_power (tc, false);Signature · 2 lines
-- 2.51.0
Re: [PATCH v4 07/11] drm/i915/xe3p_lpd: Extend Type-C flow for static DDI allocation
Quoted 153 lines · Gustavo Sousa
Quoting Imre Deak (2025-11-14 21:40:24-03:00)
Quoted 152 lines · Gustavo Sousa
Quoted 64 lines
Quoting Imre Deak (2025-11-12 14:53:47-03:00)
Quoted 54 lines · Gustavo Sousa
Quoted 53 lines
Xe3p_LPDhas a new feature that allows the driver to allocate at runtime the DDI (TC ones) port to drive a legacy connection on the Type-C subsystem. This allows better resource utilization, because now there is no need to statically reserve ports for legacy connectors on the Type-C subsystem.That said, our driver is not yet ready for the dynamic allocation. Thus, as an incremental step, let's add the logic containing the required programming sequence for the allocation, but, instead of selecting the first available port, we try so use the 1:1 mapping expected by the driver today.
Bspec: 68954
Co-developed-by Dnyaneshwar Bhadane <[email protected]>Signed-off-by Dnyaneshwar Bhadane <[email protected]>Signed-off-by Gustavo Sousa <[email protected]>---
NOTE: This patch is still a WIP. There are some opens to resolve here. Nevertheless, I'm sending it here for early feedback.
For the HIP-index stuff, I have a local refactor started and need to finish it up and send it.
The other open is about concurrent calls to
iom_dp_resource_lock(). It is likely that we need to have a software lock to prevent concurrent access toIOM_DP_HW_RESOURCE_SEMAPHOREfrom our driver.--- drivers/gpu/drm/i915/display/intel_display_regs.h | 20 ++- drivers/gpu/drm/i915/display/intel_tc.c | 151 +++++++++++++++++++++- 2 files changed, 169 insertions(+), 2 deletions(-)drivers/gpu/drm/i915/display/intel_display_regs.h +13
-0@@ -2908,6 +2908,25 @@ enum skl_power_gate {#define DP_PIN_ASSIGNMENT (idx, x) ((x) << ((idx) * 4))/* See enum intel_tc_pin_assignment for the pin assignment field values. */ +/* +* FIXME: There is also a definition for this register in intel_dkl_phy_regs.h. +* We need to consolidate the definitions. +*/ +#define HIP_INDEX_REG0 _MMIO(0x1010a0) +#define HIP_168_INDEX_MASK REG_GENMASK(3, 0) +#define HIP_168_IOM_RES_MGMT REG_FIELD_PREP(HIP_168_INDEX_MASK, 0x1) + +#define IOM_DP_HW_RESOURCE_SEMAPHORE _MMIO(0x168038) +#define IOM_DP_HW_SEMLOCK REG_BIT(31) +#define IOM_REQUESTOR_ID_MASK REG_GENMASK(3, 0) +#define IOM_REQUESTOR_ID_DISPLAY_ENGINE REG_FIELD_PREP(IOM_REQUESTOR_ID_MASK, 0x4) +Quoted 8 lines
drivers/gpu/drm/i915/display/intel_display_regs.h enum skl_power_gate { · line 2928
Quoted 5 lines
drivers/gpu/drm/i915/display/intel_display_regs.h +5
-0+#define IOM_DP_RESOURCE_MNG _MMIO(0x16802c) +#define IOM_DDI_CONSUMER_SHIFT (tc_port) ((tc_port) * 4) +#define IOM_DDI_CONSUMER_MASK (tc_port) (0xf << IOM_DDI_CONSUMER_SHIFT(tc_port)) +#define IOM_DDI_CONSUMER (tc_port, x) ((x) << IOM_DDI_CONSUMER_SHIFT(tc_port)) +#define IOM_DDI_CONSUMER_STATIC_TC (tc_port) IOM_DDI_CONSUMER(tc_port, 0x8 + (tc_port))It would be simpler to define the above without the shift, i.e. as 8 +
tc_port.Quoted 8 lines
You mean something like this?
#define
IOM_DDI_CONSUMER_STATIC_TC(tc_port)(0x8+ (tc_port))?
Yeah... Looking at the code, we wouldn't need to shift back when defining
expected_consumer.Yes.
Quoted 65 lines
Quoted 28 lines
Quoted 28 lines
drivers/gpu/drm/i915/display/intel_display_regs.h +1
-1+#define _TCSS_DDI_STATUS_1 0x161500#define _TCSS_DDI_STATUS_2 0x161504#define TCSS_DDI_STATUS (tc) _MMIO(_PICK_EVEN(tc, \@@ -2946,5 +2965,4 @@ enum skl_power_gate {#define MTL_TRDPRE_MASK REG_GENMASK(7, 0) -#endif /* __INTEL_DISPLAY_REGS_H__ */ drivers/gpu/drm/i915/display/intel_tc.c +1
-0@@ -9,6 +9,7 @@#include "i915_reg.h" #include "intel_atomic.h" +#include "intel_bios.h" #include "intel_cx0_phy_regs.h" #include "intel_ddi.h" #include "intel_de.h" @@ -25,6 +26,9 @@#include "intel_modeset_lock.h" #include "intel_tc.h" Quoted 7 lines
drivers/gpu/drm/i915/display/intel_tc.c line 30
Quoted 2 lines
drivers/gpu/drm/i915/display/intel_tc.c +2
-0+#define IOM_DP_RES_SEMAPHORE_LOCK_TIMEOUT_US 10 +#define IOM_DP_RES_SEMAPHORE_RETRY_TIMEOUT_US 10000The above param names should make it clear how
poll_timeout_us()uses them (i.e. stg like sleep vs. timeout instead oflock_timeoutvs.retry_timeout), but probably even clearer to just drop the defines and inline the values in the call.Ack. I going with the latter.
Quoted 18 lines
Quoted 18 lines
drivers/gpu/drm/i915/display/intel_tc.c +10
-0+enum tc_port_mode {TC_PORT_DISCONNECTED ,TC_PORT_TBT_ALT ,@@ -1200,6 +1204,143 @@ static void xelpdp_tc_phy_get_hw_state(struct intel_tc_port *tc)__tc_cold_unblock (tc, domain, tc_cold_wref); } +static void iom_res_mgmt_prepare_reg_access (struct intel_display *display) +{ +/* +* IOM resource management registers live in the 2nd 4KB page of IOM +* address space. So we need to configure HIP_INDEX_REG0 with the +* correct index. +* +* FIXME: We need to have this and dekel PHY implementation using a +* common abstraction to access registers on the HIP-indexed ranges, and Quoted 8 lines
drivers/gpu/drm/i915/display/intel_tc.c static void xelpdp_tc_phy_get_hw_state(struct intel_tc_port *tc) · line 1219
Quoted 4 lines
drivers/gpu/drm/i915/display/intel_tc.c +4
-0+* this function would then be dropped. +*/ +intel_de_rmw (display,HIP_INDEX_REG0 , +HIP_168_INDEX_MASK ,HIP_168_IOM_RES_MGMT );This matches what
intel_dkl_phy.cdoes, that one also taking the required lock around the access. At one point theintel_dkl_phyfile/interface could be renamed tointel_tc_regor similar accordingly.Quoted 5 lines
I have already started a local series that introduces the "HIP-index based registers" abstraction. I need to go back to finish it up.
The basic idea is that both
intel_dkl_phy.cand this IOM stuff would use functions specific to accessing registers behind the HIP-based ranges.Using
intel_hip_reginstead ofintel_tc_regis probably better, but I still think the current interface should be just renamed, instead of adding a new interface and making the current intel_dkl_phy_read/write/rmw() use that new interface.
Quoted 7 lines
Quoted 2 lines
I went ahead and put the above together now:
https://github.com/ideak/linux/commits/hip-regI didn't take a look yet; will do later. But, since we are sharing, here is a squashed and untested version of what I have in my local WIP:
https://gitlab.freedesktop.org/gustavo/kernel/-/commit/25d16a7302d9b1e9b214ccd26943fd7903d4ea11
I'm not sure if having a separate set of
intel_hip_idx_reg_{read,write,rmw,posting_read}
and
intel_dkl_phy_{read,write,rmw,posting_read}
functions is justified. Then you'd also need to add the same set of functions for IOM registers or any other HW block using the same HIP register indexing.
Even when adding separate set of functions, I wouldn't reimplement something that already exists, if the end result practically matches the current implementation anyway. I'd still go with renaming the current intel_dkl_phy_* interface to intel_hip_reg_*, adding then the DKL, etc. set of functions as wrappers, as in:
https://github.com/ideak/linux/commit/e325c4d43e80f18
in the
https://github.com/ideak/linux/commits/hip-reg-dkl-phy-wrapper
branch.
Quoted 274 lines
--
Gustavo SousaQuoted 270 lines
Quoted 125 lines
To give an idea, here is a copy/paste of the kerneldoc I currently have in that WIP series:
| diff --git a/drivers/gpu/drm/i915/display/intel_hip_idx.c b/drivers/gpu/drm/i915/display/intel_hip_idx.c | new file mode 100644 | index 000000000000..ff2492b8275d | --- /dev/null | +++ b/drivers/gpu/drm/i915/display/intel_hip_idx.c | @@ -0,0 +1,110 @@ | +// SPDX-License-Identifier: MIT | +/* | + * Copyright (C) 2025 Intel Corporation | + */ | + | +/** | + * DOC: Display HIP-indexed register access | + * | + * Display MMIO mapping for offsets in [0x168000,0x16ffff] are governed by | + * configurations in the HIP_INDEX registers provided by the hardware. | + * | + * Usually each of the valid 4KB range in that space will be mapped to some IP | + * block, providing access to registers of that IP. The HIP_INDEX registers | + * expose an 8-bit index value for each 4KB range. Those indices provide a way | + * to access data that is beyond the initial 4KB block provided by the target | + * IP. | + * | + * As an example, say that the range [0x16a000,0x16afff] is mapped to some | + * sub-IP that contains a 8KB register file. To access the initial 4KB of that | + * register file, we would need to set the index respective to | + * [0x16a000,0x16afff] in HIP_INDEX to 0; to access data in the second 4KB | + * window, we would need to set the index to 1. | + * | + * For simple read, write or rmw operations on a single register, the | + * functions intel_hip_idx_reg_read(), intel_hip_idx_reg_write() and | + * intel_hip_idx_reg_rmw() can be used, which will call intel_hip_idx_lock() | + * and intel_hip_idx_unlock() internally. | + * | + * For other scenarios, then it is necessary to wrap the register accesses | + * with explicit calls to intel_hip_idx_lock() and intel_hip_idx_unlock(), and | + * use the MMIO functions provided by intel_de.h. For the latter, the function | + * intel_hip_idx_reg_to_i915_reg() needs to be used in order to provide the | + * correct reg argument to those functions. | + */ | (...)Quoted 11 lines
Quoted 11 lines
drivers/gpu/drm/i915/display/intel_tc.c +10
-0+} + +/* +* FIXME: This function also needs to avoid concurrent accesses from the driver +* itself, possibly via a software lock. +*/ +static int iom_dp_resource_lock (struct intel_tc_port *tc) +{ +struct intel_display *display =to_intel_display (tc->dig_port); +u32 val =IOM_DP_HW_SEMLOCK |IOM_REQUESTOR_ID_DISPLAY_ENGINE ;Quoted 8 lines
drivers/gpu/drm/i915/display/intel_tc.c static void xelpdp_tc_phy_get_hw_state(struct intel_tc_port *tc) · line 1234
Quoted 5 lines
drivers/gpu/drm/i915/display/intel_tc.c +5
-0+int ret; + +iom_res_mgmt_prepare_reg_access (display); + ret = poll_timeout_us(intel_de_write(display, IOM_DP_HW_RESOURCE_SEMAPHORE, val), + (intel_de_read(display, IOM_DP_HW_RESOURCE_SEMAPHORE) & val) == val,This happens to work, but it's more future proof/bspec conformant to properly mask the requestor ID field when reading it back.
Agreed.
Quoted 31 lines
Quoted 31 lines
drivers/gpu/drm/i915/display/intel_tc.c +30
-0+IOM_DP_RES_SEMAPHORE_LOCK_TIMEOUT_US , + IOM_DP_RES_SEMAPHORE_RETRY_TIMEOUT_US, false); + +if (ret) +drm_err (display->drm,"Port %s: timeout trying to lock IOM semaphore\n" , + tc->port_name); + +return ret; +} + +static void iom_dp_resource_unlock (struct intel_tc_port *tc) +{ +struct intel_display *display =to_intel_display (tc->dig_port); + +iom_res_mgmt_prepare_reg_access (display); +intel_de_write (display,IOM_DP_HW_RESOURCE_SEMAPHORE ,IOM_REQUESTOR_ID_DISPLAY_ENGINE ); +} + +static bool xe3p_tc_iom_allocate_ddi (struct intel_tc_port *tc,bool allocate) +{ +struct intel_display *display =to_intel_display (tc->dig_port); +struct intel_digital_port *dig_port = tc->dig_port; +enum tc_port tc_port =intel_encoder_to_tc (&dig_port->base); +u32 val; +u32 consumer; +u32 expected_consumer; +bool ret; + +if (DISPLAY_VER (display) <35 ) +return true;Quoted 8 lines
drivers/gpu/drm/i915/display/intel_tc.c static void xelpdp_tc_phy_get_hw_state(struct intel_tc_port *tc) · line 1269
Quoted 5 lines
drivers/gpu/drm/i915/display/intel_tc.c +5
-0+ +if (tc->mode !=TC_PORT_LEGACY ) +return true; + +if (!intel_bios_encoder_supports_dyn_port_over_tc (dig_port->base.devdata))
dedicated_externalis stored separately indig_port, why the "related"dyn_port_over_tcflag isn't?The only reason
dedicated_externalis stored is because VBT data is already freed by the timeintel_encoder_is_tc()is called in the driver unbind path. In the future we should fix the VBT lifetime issue in order to be able to drop thededicated_externalmember ofdig_port.Quoted 11 lines
Quoted 11 lines
drivers/gpu/drm/i915/display/intel_tc.c +10
-0+return true; + +if (iom_dp_resource_lock (tc)) +return false; + + val =intel_de_read (display,IOM_DP_RESOURCE_MNG ); + + consumer = val &IOM_DDI_CONSUMER_MASK (tc_port); + consumer >>=IOM_DDI_CONSUMER_SHIFT (tc_port); +Quoted 8 lines
Quoted 8 lines
drivers/gpu/drm/i915/display/intel_tc.c static void xelpdp_tc_phy_get_hw_state(struct intel_tc_port *tc) · line 1287
Quoted 8 lines
drivers/gpu/drm/i915/display/intel_tc.c +8
-0+/* +* Bspec instructs to select first available DDI, but our driver is not +* ready for such dynamic allocation yet. For now, we force a "static" +* allocation: map the physical port (where HPD happens) to the +* encoder's DDI (logical TC port, represented by tc_port). +*/ + expected_consumer =IOM_DDI_CONSUMER_STATIC_TC (tc_port); + expected_consumer >>=IOM_DDI_CONSUMER_SHIFT (tc_port);One more thing occured to me: why can't this allocate any free DDI? IOW does the address of
DDI_BUF_CTL(akaDDI_CTL_DE) used fortc_portdepend on which DDI gets allocated (or is there any other dependency on which DDI got allocated)? AFAICS there is no such dependency and the above address would beDDI_BUF_CTL(encoder->port)regardless of the allocated DDI. In that case any free DDI could be allocated here.Quoted 76 lines
Quoted 63 lines
Quoted 63 lines
drivers/gpu/drm/i915/display/intel_tc.c +56
-0+ +if (allocate) { +struct intel_encoder *other_encoder; + +/* +* Check if this encoder's DDI is already allocated for another +* physical port, which could have happened prior to the driver +* taking over (e.g. GOP). +*/ +for_each_intel_encoder (display->drm, other_encoder) { +enum tc_port other_tc_port =intel_encoder_to_tc (other_encoder); +u32 other_consumer; + +if (tc_port ==TC_PORT_NONE || other_tc_port == tc_port) +continue ; + + other_consumer = val &IOM_DDI_CONSUMER_MASK (other_tc_port); + other_consumer >>=IOM_DDI_CONSUMER_SHIFT (other_tc_port); +if (other_consumer == expected_consumer) { +drm_err (display->drm,"Port %s: expected consumer %u already allocated another DDI; IOM_DP_RESOURCE_MNG=0x%08x\n" , + tc->port_name, expected_consumer, val); + ret = false; + goto out_resource_unlock; + } + } + +if (consumer ==0 ) { +/* DDI is free to use, let's allocate it. */ + val &= ~IOM_DDI_CONSUMER_MASK (tc_port); + val |=IOM_DDI_CONSUMER (tc_port, expected_consumer); +intel_de_write (display,IOM_DP_RESOURCE_MNG , val); + ret = true; + }else if (consumer == expected_consumer) { +/* +* Nothing to do, as the expected "static" DDI allocation is +* already in place. +*/ + ret = true; + }else { +drm_err (display->drm,"Port %s: DDI already allocated for consumer %u; IOM_DP_RESOURCE_MNG=0x%08x\n" , + tc->port_name, consumer, val); + ret = false; + } + }else { +drm_WARN_ON (display->drm, consumer != expected_consumer); + val &= ~IOM_DDI_CONSUMER_MASK (tc_port); +intel_de_write (display,IOM_DP_RESOURCE_MNG , val); + ret = true; + } + +out_resource_unlock: +iom_dp_resource_unlock (tc); + +return ret; +} +static bool xelpdp_tc_phy_connect (struct intel_tc_port *tc,int required_lanes) { tc->lock_wakeref =tc_cold_block (tc);@@ -1210,9 +1351,12 @@ static bool xelpdp_tc_phy_connect(struct intel_tc_port *tc, int required_lanes)return true; }Quoted 12 lines
drivers/gpu/drm/i915/display/intel_tc.c static bool xelpdp_tc_phy_connect(struct intel_tc_port *tc, int required_lanes) · line 1354
Quoted 2 lines
drivers/gpu/drm/i915/display/intel_tc.c +1
-1-if (!xelpdp_tc_phy_enable_tcss_power (tc, true)) +if (!xe3p_tc_iom_allocate_ddi (tc, true))This doesn't work. A connector registered to userspace must be always functional (except for MST connectors which are dynamically registered). So the DDI allocation and with that connecting the PHY cannot fail here for a legacy connector/PHY. Instead of this the allocation could be moved to happen already in
intel_tc_phy_ops::initfor now, allocating a DDI for a legacy PHY (intel_tc_port::legacy_port== true) and if that fails also fail the corresponding connector/encoder registration inintel_ddi_init(). The DDI would need to be released byintel_tc_port_cleanup().Quoted 7 lines
Ah, I see. Well, I guess for legacy connections, doing your suggestion seems fine.
Is there any power management aspect that we should be aware here? Like, some power well being disabled and causing the allocation to be "lost" somehow. Since this thing is in the TCSS, I think no display power wells could cause that, right?
It would make sense to me that the allocations are preserved by the HW/FW across power transitions. If that's not the case then they should be restored by the driver.
Quoted 2 lines
By the way, I wonder how we would handle things in the future when/if we enable the dynamic DDI allocation thing.
In case of a DDI allocation failure, the modeset will still succeed, but the corresponding port/pipe will not get enabled.
Quoted 35 lines
--
Gustavo SousaQuoted 32 lines
Quoted 32 lines
drivers/gpu/drm/i915/display/intel_tc.c +8
-0goto out_unblock_tccold; +if (!xelpdp_tc_phy_enable_tcss_power (tc, true)) + goto out_deallocate_ddi; +xelpdp_tc_phy_take_ownership (tc, true);read_pin_configuration (tc);@@ -1226,6 +1370,9 @@ static bool xelpdp_tc_phy_connect(struct intel_tc_port *tc, int required_lanes)xelpdp_tc_phy_take_ownership (tc, false);xelpdp_tc_phy_wait_for_tcss_power (tc, false); +out_deallocate_ddi: +xe3p_tc_iom_allocate_ddi (tc, false); + out_unblock_tccold:tc_cold_unblock (tc,fetch_and_zero (&tc->lock_wakeref));@@ -1236,6 +1383,8 @@ static void xelpdp_tc_phy_disconnect(struct intel_tc_port *tc) {switch (tc->mode) {case TC_PORT_LEGACY : +xe3p_tc_iom_allocate_ddi (tc, false); + fallthrough;case TC_PORT_DP_ALT :xelpdp_tc_phy_take_ownership (tc, false);xelpdp_tc_phy_enable_tcss_power (tc, false);Signature · 2 lines
-- 2.51.0
PATCH v4 8/11 drm/i915/nvls: Add NVL-S display support
In reply to Gustavo SousaFrom: Sai Teja Pottumuttu <[email protected]>
Add platform description and PCI IDs for NVL-S.
BSpec: 74201
--- drivers/gpu/drm/i915/display/intel_display_device.c | 5 +++++ drivers/gpu/drm/i915/display/intel_display_device.h | 4 +++- 2 files changed, 8 insertions(+), 1 deletion(-)
drivers/gpu/drm/i915/display/intel_display_device.c +5 -0
@@ -1420,6 +1420,10 @@ static const struct platform_desc ptl_desc = { } }; +static const struct platform_desc nvl_desc = { +PLATFORM (novalake), +}; +__diag_pop ();/*
@@ -1495,6 +1499,7 @@ static const struct {INTEL_BMG_IDS (INTEL_DISPLAY_DEVICE , &bmg_desc),INTEL_PTL_IDS (INTEL_DISPLAY_DEVICE , &ptl_desc),INTEL_WCL_IDS (INTEL_DISPLAY_DEVICE , &ptl_desc), + INTEL_NVLS_IDS(INTEL_DISPLAY_DEVICE, &nvl_desc), }; static const struct {
drivers/gpu/drm/i915/display/intel_display_device.h +3 -1
@@ -103,7 +103,9 @@ struct pci_dev; func(battlemage) \ /* Display ver 30 (based on GMD ID) */ \ func(pantherlake) \ - func(pantherlake_wildcatlake) + func(pantherlake_wildcatlake) \ + /* Display ver 35 (based on GMD ID) */ \ + func(novalake) #define __MEMBER(name) unsigned long name:1;
Signature · 1 line
2.51.0
PATCH v4 9/11 drm/i915/display: Use platform check in HAS_LT_PHY()
In reply to Gustavo SousaNVL uses the Lake Tahoe PHY for display output and the driver recently added the macro HAS_LT_PHY() to allow selecting code paths specific for that type of PHY.
While NVL uses Xe3p_LPD as display IP, the type of PHY is actually defined at the SoC level, so use a platform check instead of display version.
Bspec: 74199
--- drivers/gpu/drm/i915/display/intel_lt_phy.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/i915/display/intel_lt_phy.h +1 -1
@@ -39,6 +39,6 @@ void intel_xe3plpd_pll_enable(struct intel_encoder *encoder, const struct intel_crtc_state *crtc_state);void intel_xe3plpd_pll_disable (struct intel_encoder *encoder); -#define HAS_LT_PHY (display) (DISPLAY_VER(display) >= 35) +#define HAS_LT_PHY (display) ((display)->platform.novalake)#endif /* __INTEL_LT_PHY_H__ */
Signature · 1 line
2.51.0
PATCH v4 10/11 drm/i915/display: Move HAS_LT_PHY() to intel_display_device.h
In reply to Gustavo SousaWe will need to HAS_LT_PHY() that macro in code outside of LT PHY implementation. Move its definition to intel_display_device.h.
--- drivers/gpu/drm/i915/display/intel_display_device.h | 1 + drivers/gpu/drm/i915/display/intel_lt_phy.h | 2 -- 2 files changed, 1 insertion(+), 2 deletions(-)
drivers/gpu/drm/i915/display/intel_display_device.h +1 -0
@@ -187,6 +187,7 @@ struct intel_display_platforms {#define HAS_IPS (__display) ((__display)->platform.haswell_ult || (__display)->platform.broadwell)#define HAS_LRR (__display) (DISPLAY_VER(__display) >= 12)#define HAS_LSPCON (__display) (IS_DISPLAY_VER(__display, 9, 10)) +#define HAS_LT_PHY (__display) ((__display)->platform.novalake)#define HAS_MBUS_JOINING (__display) ((__display)->platform.alderlake_p || DISPLAY_VER(__display) >= 14)#define HAS_MSO (__display) (DISPLAY_VER(__display) >= 12)#define HAS_OVERLAY (__display) (DISPLAY_INFO(__display)->has_overlay)
drivers/gpu/drm/i915/display/intel_lt_phy.h +0 -2
@@ -39,6 +39,4 @@ void intel_xe3plpd_pll_enable(struct intel_encoder *encoder, const struct intel_crtc_state *crtc_state);void intel_xe3plpd_pll_disable (struct intel_encoder *encoder); -#define HAS_LT_PHY (display) ((display)->platform.novalake) -#endif /* __INTEL_LT_PHY_H__ */
Signature · 1 line
2.51.0
PATCH v4 11/11 drm/i915/display: Use HAS_LT_PHY() for LT PHY AUX power
In reply to Gustavo SousaBspec states that the new AUX power enable/disable sequences are associated with the LT PHY. As such, use HAS_LT_PHY() instead of IP checks in those paths in the driver code.
While at it, also move the comment that we can't use the power status flag to the "else" branch, since that comment is not applicable for the LT PHY.
Bspec: 68967
--- drivers/gpu/drm/i915/display/intel_display_power_well.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-)
drivers/gpu/drm/i915/display/intel_display_power_well.c +8 -8
@@ -1870,19 +1870,19 @@ static void xelpdp_aux_power_well_enable(struct intel_display *display,XELPDP_DP_AUX_CH_CTL_POWER_REQUEST , XELPDP_DP_AUX_CH_CTL_POWER_REQUEST); -/* -* The power status flag cannot be used to determine whether aux -* power wells have finished powering up. Instead we're -* expected to just wait a fixed 600us after raising the request -* bit. -*/ -if (DISPLAY_VER (display) >=35 ) { +if (HAS_LT_PHY (display)) {if (intel_de_wait_for_set (display,XELPDP_DP_AUX_CH_CTL (display, aux_ch),XELPDP_DP_AUX_CH_CTL_POWER_STATUS ,2 ))drm_warn (display->drm,"Timeout waiting for PHY %c AUX channel power to be up\n" ,phy_name (phy)); }else { +/* +* The power status flag cannot be used to determine whether aux +* power wells have finished powering up. Instead we're +* expected to just wait a fixed 600us after raising the request +* bit. +*/ usleep_range (600 ,1200 ); } }
@@ -1897,7 +1897,7 @@ static void xelpdp_aux_power_well_disable(struct intel_display *display,XELPDP_DP_AUX_CH_CTL_POWER_REQUEST , 0); -if (DISPLAY_VER (display) >=35 ) { +if (HAS_LT_PHY (display)) {if (intel_de_wait_for_clear (display,XELPDP_DP_AUX_CH_CTL (display, aux_ch),XELPDP_DP_AUX_CH_CTL_POWER_STATUS ,1 )) drm_warn(display->drm,
Signature · 1 line
2.51.0
Quoting Gustavo Sousa (2025-11-07 21:05:33-03:00)
Quoted 8 lines
This series adds initial support for
Xe3p_LPD, Intel's display architecture with IP version 35.This series contains basic enabling patches and does not provide complete support for the display IP yet. More involved features, like the new PHY implementation and ALPM are implemented as separate patch series.
Quoted 8 lines
Signed-off-by Gustavo Sousa <[email protected]>---
Changes in v4:
- Skipped patches from v3 that were already applied.
- Dropped patch "drm/i915/xe3p_lpd: Enable system caching for FBC" with
the expectation that its next version will be sent as a standalone
patch.
- Link to v3: https://patch.msgid.link/[email protected]
I decided to post v4 even though there is still some ongoing discussion for "drm/i915/wm: Do not make latency values monotonic on Xe3 onward" in v3. The reason is that I will soon become unavailable for a few days and wanted to keep the series up-to-date with what I have locally.
--
Gustavo Sousa
Quoted 67 lines
Changes in v3:
- Reshuffled patches so that most of the ones already containing a r-b
are placed at the start.
- Dropped "drm/i915/xe3p_lpd: Wait for AUX channel power status", as a
similar patch was already applied from a patch series dedicated to LT
PHY
(https://lore.kernel.org/all/[email protected]/).
- Dropped patches related to UINT16 plane formats, as they were
incomplete and were not specific toXe3p_LPD.
- Dropped FBC related patches, as Vinod is handling them as a separated
series
(https://lore.kernel.org/intel-gfx/[email protected]/)
- Dropped "drm/i915/xe3p_lpd: PSR SU minimum lines is 4", since that
change is not valid according to Bspec.
- Incorporated review feedback on the other patches. Please check the
changelog in the individual patches for details.
- Link to v2: https://lore.kernel.org/r/[email protected]Changes in v2:
- Incorporated review feedback. Please check the changelog in the
patches for details.
- Link to v1: https://lore.kernel.org/r/[email protected]---
Gustavo Sousa (10):
drm/i915/wm: Do not make latency values monotonic on Xe3 onward drm/i915/vbt: Add fieldsdedicated_externalanddyn_port_over_tcdrm/i915/power: Useintel_encoder_is_tc()
drm/i915/display: Handle dedicated external ports inintel_encoder_is_tc()drm/i915/fbc: Addintel_fbc_id_for_pipe()
drm/i915/xe3p_lpd: Handle underrun debug bits drm/i915/xe3p_lpd: Extend Type-C flow for static DDI allocation drm/i915/display: Use platform check inHAS_LT_PHY()drm/i915/display: MoveHAS_LT_PHY()tointel_display_device.hdrm/i915/display: UseHAS_LT_PHY()for LT PHY AUX powerSai Teja Pottumuttu (1):
drm/i915/nvls: Add NVL-S display supportdrivers/gpu/drm/i915/display/intel_bios.c | 54 +++++++- drivers/gpu/drm/i915/display/intel_bios.h | 2 + drivers/gpu/drm/i915/display/intel_ddi.c | 11 ++ drivers/gpu/drm/i915/display/intel_display.c | 19 ++- .../gpu/drm/i915/display/intel_display_device.c | 5 + .../gpu/drm/i915/display/intel_display_device.h | 6 +- .../drm/i915/display/intel_display_power_well.c | 42 +++--- drivers/gpu/drm/i915/display/intel_display_regs.h | 36 ++++- drivers/gpu/drm/i915/display/intel_display_types.h | 1 + drivers/gpu/drm/i915/display/intel_fbc.c | 5 + drivers/gpu/drm/i915/display/intel_fbc.h | 2 + drivers/gpu/drm/i915/display/intel_fbc_regs.h | 2 + drivers/gpu/drm/i915/display/intel_fifo_underrun.c | 128 +++++++++++++++++ drivers/gpu/drm/i915/display/intel_lt_phy.h | 2 - drivers/gpu/drm/i915/display/intel_tc.c | 151 ++++++++++++++++++++- drivers/gpu/drm/i915/display/intel_vbt_defs.h | 3 +- drivers/gpu/drm/i915/display/skl_universal_plane.c | 9 +- drivers/gpu/drm/i915/display/skl_watermark.c | 17 ++- 18 files changed, 462 insertions(+), 33 deletions(-)---
base-commit:2bc418aa7efaae562e49d84e8b28f799cf624745
change-id: 20251014-xe3p_lpd-basic-enabling-eb4424698b44Best regards,
Signature · 1 line
Gustavo Sousa <[email protected]>
Patchwork
CI✓ i915.CI.BAT: success for drm/i915/display: Add initial support for Xe3p_LPD (rev4)
In reply to Gustavo Sousa== Series Details ==
== Series Details ==
Series: drm/i915/display: Add initial support for Xe3p_LPD (rev4)
URL : https://patchwork.freedesktop.org/series/155952/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_17515 -> Patchwork_155952v4
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/index.html
Participating hosts (45 -> 43)
------------------------------
Missing (2): fi-kbl-guc fi-snb-2520m
Known issues
------------
Here are the changes found in Patchwork_155952v4 that come from known issues:
### IGT changes ###
#### Possible fixes ####
* igt@i915_selftest@live@workarounds:
- bat-dg2-9: [DMESG-FAIL][1] ([i915#12061]) -> [PASS][2] +1 other test pass
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17515/bat-dg2-9/igt@i915_selftest@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/bat-dg2-9/igt@i915_selftest@[email protected]
#### Warnings ####
* igt@i915_selftest@live:
- bat-atsm-1: [DMESG-FAIL][3] ([i915#12061] / [i915#14204]) -> [DMESG-FAIL][4] ([i915#12061] / [i915#13929])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17515/bat-atsm-1/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/bat-atsm-1/igt@[email protected]
* igt@i915_selftest@live@mman:
- bat-atsm-1: [DMESG-FAIL][5] ([i915#14204]) -> [DMESG-FAIL][6] ([i915#13929])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17515/bat-atsm-1/igt@i915_selftest@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/bat-atsm-1/igt@i915_selftest@[email protected]
[i915#12061]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12061
[i915#13929]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/13929
[i915#14204]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/14204
Build changes
-------------
* Linux: CI_DRM_17515 -> Patchwork_155952v4
CI-20190529: 20190529
CI_DRM_17515: 2bc418aa7efaae562e49d84e8b28f799cf624745 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_8614: 8614
Patchwork_155952v4: 2bc418aa7efaae562e49d84e8b28f799cf624745 @ git://anongit.freedesktop.org/gfx-ci/linux
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/index.html
✗ CI.checkpatch: warning for drm/i915/display: Add initial support for Xe3p_LPD (rev4)
In reply to Gustavo Sousa== Series Details ==
== Series Details ==
Series: drm/i915/display: Add initial support for Xe3p_LPD (rev4)
URL : https://patchwork.freedesktop.org/series/155951/
State : warning
== Summary ==
+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master d9120d4d84745cf011b4b3efb338747e69179dfb
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit 8975da4a18ed8f2b3185357ac5b8c6a4ea4c94b5
Author: Gustavo Sousa <[email protected]> Date: Fri Nov 7 21:05:44 2025 -0300
drm/i915/display: Use HAS_LT_PHY() for LT PHY AUX power
Bspec states that the new AUX power enable/disable sequences are associated with the LT PHY. As such, use HAS_LT_PHY() instead of IP checks in those paths in the driver code.
While at it, also move the comment that we can't use the power status flag to the "else" branch, since that comment is not applicable for the LT PHY.
Bspec: 68967
+ /mt/dim checkpatch 2bc418aa7efaae562e49d84e8b28f799cf624745 drm-intel838858cf34e0 drm/i915/wm: Do not make latency values monotonic on Xe3 onwardfcd9b615992e drm/i915/vbt: Add fields dedicated_external and dyn_port_over_tcec551d2110d1 drm/i915/power: Use intel_encoder_is_tc()abb83f6d3cb3 drm/i915/display: Handle dedicated external ports in intel_encoder_is_tc() aa19ee63ea65 drm/i915/fbc: Add intel_fbc_id_for_pipe()9d40f63f7004 drm/i915/xe3p_lpd: Handle underrun debug bits
-:15: WARNING:COMMIT_LOG_LONG_LINE: Prefer a maximum 75 chars per line (possible unwrapped commit description?) #15:
[1] https://lore.kernel.org/all/[email protected]/
total: 0 errors, 1 warnings, 0 checks, 201 lines checked2057c8655f70 drm/i915/xe3p_lpd: Extend Type-C flow for static DDI allocation -:49: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'tc_port' - possible side-effects? #49: FILE: drivers/gpu/drm/i915/display/intel_display_regs.h:2928:
+#define IOM_DDI_CONSUMER_STATIC_TC(tc_port) IOM_DDI_CONSUMER(tc_port, 0x8 + (tc_port))
total: 0 errors, 0 warnings, 1 checks, 219 lines checked 92774145328a drm/i915/nvls: Add NVL-S display support 1392c6a263cc drm/i915/display: Use platform check in HAS_LT_PHY() 7ce295f55fad drm/i915/display: Move HAS_LT_PHY() to intel_display_device.h 8975da4a18ed drm/i915/display: Use HAS_LT_PHY() for LT PHY AUX power
Patchwork
CI✓ CI.KUnit: success for drm/i915/display: Add initial support for Xe3p_LPD (rev4)
In reply to Gustavo Sousa== Series Details ==
== Series Details ==
Series: drm/i915/display: Add initial support for Xe3p_LPD (rev4)
URL : https://patchwork.freedesktop.org/series/155951/
State : success
== Summary ==
+ trap cleanup EXIT
+ /kernel/tools/testing/kunit/kunit.py run --kunitconfig /kernel/drivers/gpu/drm/xe/.kunitconfig [01:52:59] Configuring KUnit Kernel ...
Generating .config ...
Populating config with:
$ make ARCH=um O=.kunit olddefconfig [01:53:03] Building KUnit Kernel ... Populating config with: $ make ARCH=um O=.kunit olddefconfig Building with: $ make all compile_commands.json scripts_gdb ARCH=um O=.kunit --jobs=48 [01:53:33] Starting KUnit Kernel (1/1)... [01:53:33] ============================================================ Running tests with: $ .kunit/linux kunit.enable=1 mem=1G console=tty kunit_shutdown=halt [01:53:33] ================== guc_buf (11 subtests) =================== [01:53:33] [PASSED] test_smallest [01:53:33] [PASSED] test_largest [01:53:33] [PASSED] test_granular [01:53:33] [PASSED] test_unique [01:53:33] [PASSED] test_overlap [01:53:33] [PASSED] test_reusable [01:53:33] [PASSED] test_too_big [01:53:33] [PASSED] test_flush [01:53:33] [PASSED] test_lookup [01:53:33] [PASSED] test_data [01:53:33] [PASSED] test_class [01:53:33] ===================== [PASSED] guc_buf ===================== [01:53:33] =================== guc_dbm (7 subtests) =================== [01:53:33] [PASSED] test_empty [01:53:33] [PASSED] test_default [01:53:33] ======================== test_size ======================== [01:53:33] [PASSED] 4 [01:53:33] [PASSED] 8 [01:53:33] [PASSED] 32 [01:53:33] [PASSED] 256 [01:53:33] ==================== [PASSED] test_size ==================== [01:53:33] ======================= test_reuse ======================== [01:53:33] [PASSED] 4 [01:53:33] [PASSED] 8 [01:53:33] [PASSED] 32 [01:53:33] [PASSED] 256 [01:53:33] =================== [PASSED] test_reuse ==================== [01:53:33] =================== test_range_overlap ==================== [01:53:33] [PASSED] 4 [01:53:33] [PASSED] 8 [01:53:33] [PASSED] 32 [01:53:33] [PASSED] 256 [01:53:33] =============== [PASSED] test_range_overlap ================ [01:53:33] =================== test_range_compact ==================== [01:53:33] [PASSED] 4 [01:53:33] [PASSED] 8 [01:53:33] [PASSED] 32 [01:53:33] [PASSED] 256 [01:53:33] =============== [PASSED] test_range_compact ================ [01:53:33] ==================== test_range_spare ===================== [01:53:33] [PASSED] 4 [01:53:33] [PASSED] 8 [01:53:33] [PASSED] 32 [01:53:33] [PASSED] 256 [01:53:33] ================ [PASSED] test_range_spare ================= [01:53:33] ===================== [PASSED] guc_dbm ===================== [01:53:33] =================== guc_idm (6 subtests) =================== [01:53:33] [PASSED] bad_init [01:53:33] [PASSED] no_init [01:53:33] [PASSED] init_fini [01:53:33] [PASSED] check_used [01:53:33] [PASSED] check_quota [01:53:33] [PASSED] check_all [01:53:33] ===================== [PASSED] guc_idm ===================== [01:53:33] ================== no_relay (3 subtests) =================== [01:53:33] [PASSED] xe_drops_guc2pf_if_not_ready [01:53:33] [PASSED] xe_drops_guc2vf_if_not_ready [01:53:33] [PASSED] xe_rejects_send_if_not_ready [01:53:33] ==================== [PASSED] no_relay ===================== [01:53:33] ================== pf_relay (14 subtests) ================== [01:53:33] [PASSED] pf_rejects_guc2pf_too_short [01:53:33] [PASSED] pf_rejects_guc2pf_too_long [01:53:33] [PASSED] pf_rejects_guc2pf_no_payload [01:53:33] [PASSED] pf_fails_no_payload [01:53:33] [PASSED] pf_fails_bad_origin [01:53:33] [PASSED] pf_fails_bad_type [01:53:33] [PASSED] pf_txn_reports_error [01:53:33] [PASSED] pf_txn_sends_pf2guc [01:53:33] [PASSED] pf_sends_pf2guc [01:53:33] [SKIPPED] pf_loopback_nop [01:53:33] [SKIPPED] pf_loopback_echo [01:53:33] [SKIPPED] pf_loopback_fail [01:53:33] [SKIPPED] pf_loopback_busy [01:53:33] [SKIPPED] pf_loopback_retry [01:53:33] ==================== [PASSED] pf_relay ===================== [01:53:33] ================== vf_relay (3 subtests) =================== [01:53:33] [PASSED] vf_rejects_guc2vf_too_short [01:53:33] [PASSED] vf_rejects_guc2vf_too_long [01:53:33] [PASSED] vf_rejects_guc2vf_no_payload [01:53:33] ==================== [PASSED] vf_relay ===================== [01:53:33] ================ pf_gt_config (4 subtests) ================= [01:53:33] [PASSED] fair_contexts_1vf [01:53:33] [PASSED] fair_doorbells_1vf [01:53:33] ====================== fair_contexts ====================== [01:53:33] [PASSED] 1 VF [01:53:33] [PASSED] 2 VFs [01:53:33] [PASSED] 3 VFs [01:53:33] [PASSED] 4 VFs [01:53:33] [PASSED] 5 VFs [01:53:33] [PASSED] 6 VFs [01:53:33] [PASSED] 7 VFs [01:53:33] [PASSED] 8 VFs [01:53:33] [PASSED] 9 VFs [01:53:33] [PASSED] 10 VFs [01:53:33] [PASSED] 11 VFs [01:53:33] [PASSED] 12 VFs [01:53:33] [PASSED] 13 VFs [01:53:33] [PASSED] 14 VFs [01:53:33] [PASSED] 15 VFs [01:53:33] [PASSED] 16 VFs [01:53:33] [PASSED] 17 VFs [01:53:33] [PASSED] 18 VFs [01:53:33] [PASSED] 19 VFs [01:53:33] [PASSED] 20 VFs [01:53:33] [PASSED] 21 VFs [01:53:33] [PASSED] 22 VFs [01:53:33] [PASSED] 23 VFs [01:53:33] [PASSED] 24 VFs [01:53:33] [PASSED] 25 VFs [01:53:33] [PASSED] 26 VFs [01:53:33] [PASSED] 27 VFs [01:53:33] [PASSED] 28 VFs [01:53:33] [PASSED] 29 VFs [01:53:33] [PASSED] 30 VFs [01:53:33] [PASSED] 31 VFs [01:53:33] [PASSED] 32 VFs [01:53:33] [PASSED] 33 VFs [01:53:33] [PASSED] 34 VFs [01:53:33] [PASSED] 35 VFs [01:53:33] [PASSED] 36 VFs [01:53:33] [PASSED] 37 VFs [01:53:33] [PASSED] 38 VFs [01:53:33] [PASSED] 39 VFs [01:53:33] [PASSED] 40 VFs [01:53:33] [PASSED] 41 VFs [01:53:33] [PASSED] 42 VFs [01:53:33] [PASSED] 43 VFs [01:53:33] [PASSED] 44 VFs [01:53:33] [PASSED] 45 VFs [01:53:33] [PASSED] 46 VFs [01:53:33] [PASSED] 47 VFs [01:53:33] [PASSED] 48 VFs [01:53:33] [PASSED] 49 VFs [01:53:33] [PASSED] 50 VFs [01:53:33] [PASSED] 51 VFs [01:53:33] [PASSED] 52 VFs [01:53:33] [PASSED] 53 VFs [01:53:33] [PASSED] 54 VFs [01:53:33] [PASSED] 55 VFs [01:53:33] [PASSED] 56 VFs [01:53:33] [PASSED] 57 VFs [01:53:33] [PASSED] 58 VFs [01:53:33] [PASSED] 59 VFs [01:53:33] [PASSED] 60 VFs [01:53:33] [PASSED] 61 VFs [01:53:33] [PASSED] 62 VFs [01:53:33] [PASSED] 63 VFs [01:53:33] ================== [PASSED] fair_contexts ================== [01:53:33] ===================== fair_doorbells ====================== [01:53:33] [PASSED] 1 VF [01:53:33] [PASSED] 2 VFs [01:53:33] [PASSED] 3 VFs [01:53:33] [PASSED] 4 VFs [01:53:33] [PASSED] 5 VFs [01:53:33] [PASSED] 6 VFs [01:53:33] [PASSED] 7 VFs [01:53:33] [PASSED] 8 VFs [01:53:33] [PASSED] 9 VFs [01:53:33] [PASSED] 10 VFs [01:53:33] [PASSED] 11 VFs [01:53:33] [PASSED] 12 VFs [01:53:33] [PASSED] 13 VFs [01:53:33] [PASSED] 14 VFs [01:53:33] [PASSED] 15 VFs [01:53:33] [PASSED] 16 VFs [01:53:33] [PASSED] 17 VFs [01:53:33] [PASSED] 18 VFs [01:53:33] [PASSED] 19 VFs [01:53:33] [PASSED] 20 VFs [01:53:33] [PASSED] 21 VFs [01:53:33] [PASSED] 22 VFs [01:53:33] [PASSED] 23 VFs [01:53:33] [PASSED] 24 VFs [01:53:33] [PASSED] 25 VFs [01:53:33] [PASSED] 26 VFs [01:53:33] [PASSED] 27 VFs [01:53:33] [PASSED] 28 VFs [01:53:33] [PASSED] 29 VFs [01:53:33] [PASSED] 30 VFs [01:53:33] [PASSED] 31 VFs [01:53:33] [PASSED] 32 VFs [01:53:33] [PASSED] 33 VFs [01:53:33] [PASSED] 34 VFs [01:53:33] [PASSED] 35 VFs [01:53:33] [PASSED] 36 VFs [01:53:33] [PASSED] 37 VFs [01:53:33] [PASSED] 38 VFs [01:53:33] [PASSED] 39 VFs [01:53:33] [PASSED] 40 VFs [01:53:33] [PASSED] 41 VFs [01:53:33] [PASSED] 42 VFs [01:53:33] [PASSED] 43 VFs [01:53:33] [PASSED] 44 VFs [01:53:33] [PASSED] 45 VFs [01:53:33] [PASSED] 46 VFs [01:53:33] [PASSED] 47 VFs [01:53:33] [PASSED] 48 VFs [01:53:33] [PASSED] 49 VFs [01:53:33] [PASSED] 50 VFs [01:53:33] [PASSED] 51 VFs [01:53:33] [PASSED] 52 VFs [01:53:33] [PASSED] 53 VFs [01:53:33] [PASSED] 54 VFs [01:53:33] [PASSED] 55 VFs [01:53:33] [PASSED] 56 VFs [01:53:33] [PASSED] 57 VFs [01:53:33] [PASSED] 58 VFs [01:53:33] [PASSED] 59 VFs [01:53:33] [PASSED] 60 VFs [01:53:33] [PASSED] 61 VFs [01:53:33] [PASSED] 62 VFs [01:53:33] [PASSED] 63 VFs [01:53:33] ================= [PASSED] fair_doorbells ================== [01:53:33] ================== [PASSED] pf_gt_config =================== [01:53:33] ===================== lmtt (1 subtest) ===================== [01:53:33] ======================== test_ops ========================= [01:53:33] [PASSED] 2-level [01:53:33] [PASSED] multi-level [01:53:33] ==================== [PASSED] test_ops ===================== [01:53:33] ====================== [PASSED] lmtt ======================= [01:53:33] ================= pf_service (11 subtests) ================= [01:53:33] [PASSED] pf_negotiate_any [01:53:33] [PASSED] pf_negotiate_base_match [01:53:33] [PASSED] pf_negotiate_base_newer [01:53:33] [PASSED] pf_negotiate_base_next [01:53:33] [SKIPPED] pf_negotiate_base_older [01:53:33] [PASSED] pf_negotiate_base_prev [01:53:33] [PASSED] pf_negotiate_latest_match [01:53:33] [PASSED] pf_negotiate_latest_newer [01:53:33] [PASSED] pf_negotiate_latest_next [01:53:33] [SKIPPED] pf_negotiate_latest_older [01:53:33] [SKIPPED] pf_negotiate_latest_prev [01:53:33] =================== [PASSED] pf_service ==================== [01:53:33] ================= xe_guc_g2g (2 subtests) ================== [01:53:33] ============== xe_live_guc_g2g_kunit_default ============== [01:53:33] ========= [SKIPPED] xe_live_guc_g2g_kunit_default ========== [01:53:33] ============== xe_live_guc_g2g_kunit_allmem =============== [01:53:33] ========== [SKIPPED] xe_live_guc_g2g_kunit_allmem ========== [01:53:33] =================== [SKIPPED] xe_guc_g2g =================== [01:53:33] =================== xe_mocs (2 subtests) =================== [01:53:33] ================ xe_live_mocs_kernel_kunit ================ [01:53:33] =========== [SKIPPED] xe_live_mocs_kernel_kunit ============ [01:53:33] ================ xe_live_mocs_reset_kunit ================= [01:53:33] ============ [SKIPPED] xe_live_mocs_reset_kunit ============ [01:53:33] ==================== [SKIPPED] xe_mocs ===================== [01:53:33] ================= xe_migrate (2 subtests) ================== [01:53:33] ================= xe_migrate_sanity_kunit ================= [01:53:33] ============ [SKIPPED] xe_migrate_sanity_kunit ============= [01:53:33] ================== xe_validate_ccs_kunit ================== [01:53:33] ============= [SKIPPED] xe_validate_ccs_kunit ============== [01:53:33] =================== [SKIPPED] xe_migrate =================== [01:53:33] ================== xe_dma_buf (1 subtest) ================== [01:53:33] ==================== xe_dma_buf_kunit ===================== [01:53:33] ================ [SKIPPED] xe_dma_buf_kunit ================ [01:53:33] =================== [SKIPPED] xe_dma_buf =================== [01:53:33] ================= xe_bo_shrink (1 subtest) ================= [01:53:33] =================== xe_bo_shrink_kunit ==================== [01:53:33] =============== [SKIPPED] xe_bo_shrink_kunit =============== [01:53:33] ================== [SKIPPED] xe_bo_shrink ================== [01:53:33] ==================== xe_bo (2 subtests) ==================== [01:53:33] ================== xe_ccs_migrate_kunit =================== [01:53:33] ============== [SKIPPED] xe_ccs_migrate_kunit ============== [01:53:33] ==================== xe_bo_evict_kunit ==================== [01:53:33] =============== [SKIPPED] xe_bo_evict_kunit ================ [01:53:33] ===================== [SKIPPED] xe_bo ====================== [01:53:33] ==================== args (11 subtests) ==================== [01:53:33] [PASSED] count_args_test [01:53:33] [PASSED] call_args_example [01:53:33] [PASSED] call_args_test [01:53:33] [PASSED] drop_first_arg_example [01:53:33] [PASSED] drop_first_arg_test [01:53:33] [PASSED] first_arg_example [01:53:33] [PASSED] first_arg_test [01:53:33] [PASSED] last_arg_example [01:53:33] [PASSED] last_arg_test [01:53:33] [PASSED] pick_arg_example [01:53:33] [PASSED] sep_comma_example [01:53:33] ====================== [PASSED] args ======================= [01:53:33] =================== xe_pci (3 subtests) ==================== [01:53:33] ==================== check_graphics_ip ==================== [01:53:33] [PASSED] 12.00 Xe_LP [01:53:33] [PASSED] 12.10 Xe_LP+ [01:53:33] [PASSED] 12.55 Xe_HPG [01:53:33] [PASSED] 12.60 Xe_HPC [01:53:33] [PASSED] 12.70 Xe_LPG [01:53:33] [PASSED] 12.71 Xe_LPG [01:53:33] [PASSED] 12.74 Xe_LPG+ [01:53:33] [PASSED] 20.01 Xe2_HPG [01:53:33] [PASSED] 20.02 Xe2_HPG [01:53:33] [PASSED] 20.04 Xe2_LPG [01:53:33] [PASSED] 30.00 Xe3_LPG [01:53:33] [PASSED] 30.01 Xe3_LPG [01:53:33] [PASSED] 30.03 Xe3_LPG [01:53:33] [PASSED] 30.04 Xe3_LPG [01:53:33] [PASSED] 30.05 Xe3_LPG [01:53:33] [PASSED] 35.11 Xe3p_XPC [01:53:33] ================ [PASSED] check_graphics_ip ================ [01:53:33] ===================== check_media_ip ====================== [01:53:33] [PASSED] 12.00 Xe_M [01:53:33] [PASSED] 12.55 Xe_HPM [01:53:33] [PASSED] 13.00 Xe_LPM+ [01:53:33] [PASSED] 13.01 Xe2_HPM [01:53:33] [PASSED] 20.00 Xe2_LPM [01:53:33] [PASSED] 30.00 Xe3_LPM [01:53:33] [PASSED] 30.02 Xe3_LPM [01:53:33] [PASSED] 35.00 Xe3p_LPM [01:53:33] [PASSED] 35.03 Xe3p_HPM [01:53:33] ================= [PASSED] check_media_ip ================== [01:53:33] =================== check_platform_desc =================== [01:53:33] [PASSED] 0x9A60 (TIGERLAKE) [01:53:33] [PASSED] 0x9A68 (TIGERLAKE) [01:53:33] [PASSED] 0x9A70 (TIGERLAKE) [01:53:33] [PASSED] 0x9A40 (TIGERLAKE) [01:53:33] [PASSED] 0x9A49 (TIGERLAKE) [01:53:33] [PASSED] 0x9A59 (TIGERLAKE) [01:53:33] [PASSED] 0x9A78 (TIGERLAKE) [01:53:33] [PASSED] 0x9AC0 (TIGERLAKE) [01:53:33] [PASSED] 0x9AC9 (TIGERLAKE) [01:53:33] [PASSED] 0x9AD9 (TIGERLAKE) [01:53:33] [PASSED] 0x9AF8 (TIGERLAKE) [01:53:33] [PASSED] 0x4C80 (ROCKETLAKE) [01:53:33] [PASSED] 0x4C8A (ROCKETLAKE) [01:53:33] [PASSED] 0x4C8B (ROCKETLAKE) [01:53:33] [PASSED] 0x4C8C (ROCKETLAKE) [01:53:33] [PASSED] 0x4C90 (ROCKETLAKE) [01:53:33] [PASSED] 0x4C9A (ROCKETLAKE) [01:53:33] [PASSED] 0x4680 (ALDERLAKE_S) [01:53:33] [PASSED] 0x4682 (ALDERLAKE_S) [01:53:33] [PASSED] 0x4688 (ALDERLAKE_S) [01:53:33] [PASSED] 0x468A (ALDERLAKE_S) [01:53:33] [PASSED] 0x468B (ALDERLAKE_S) [01:53:33] [PASSED] 0x4690 (ALDERLAKE_S) [01:53:33] [PASSED] 0x4692 (ALDERLAKE_S) [01:53:33] [PASSED] 0x4693 (ALDERLAKE_S) [01:53:33] [PASSED] 0x46A0 (ALDERLAKE_P) [01:53:33] [PASSED] 0x46A1 (ALDERLAKE_P) [01:53:33] [PASSED] 0x46A2 (ALDERLAKE_P) [01:53:33] [PASSED] 0x46A3 (ALDERLAKE_P) [01:53:33] [PASSED] 0x46A6 (ALDERLAKE_P) [01:53:33] [PASSED] 0x46A8 (ALDERLAKE_P) [01:53:33] [PASSED] 0x46AA (ALDERLAKE_P) [01:53:33] [PASSED] 0x462A (ALDERLAKE_P) [01:53:33] [PASSED] 0x4626 (ALDERLAKE_P) [01:53:33] [PASSED] 0x4628 (ALDERLAKE_P) [01:53:33] [PASSED] 0x46B0 (ALDERLAKE_P) [01:53:33] [PASSED] 0x46B1 (ALDERLAKE_P) [01:53:33] [PASSED] 0x46B2 (ALDERLAKE_P) [01:53:33] [PASSED] 0x46B3 (ALDERLAKE_P) [01:53:33] [PASSED] 0x46C0 (ALDERLAKE_P) [01:53:33] [PASSED] 0x46C1 (ALDERLAKE_P) [01:53:33] [PASSED] 0x46C2 (ALDERLAKE_P) [01:53:33] [PASSED] 0x46C3 (ALDERLAKE_P) [01:53:33] [PASSED] 0x46D0 (ALDERLAKE_N) [01:53:33] [PASSED] 0x46D1 (ALDERLAKE_N) [01:53:33] [PASSED] 0x46D2 (ALDERLAKE_N) [01:53:33] [PASSED] 0x46D3 (ALDERLAKE_N) [01:53:33] [PASSED] 0x46D4 (ALDERLAKE_N) [01:53:33] [PASSED] 0xA721 (ALDERLAKE_P) [01:53:33] [PASSED] 0xA7A1 (ALDERLAKE_P) [01:53:33] [PASSED] 0xA7A9 (ALDERLAKE_P) [01:53:33] [PASSED] 0xA7AC (ALDERLAKE_P) [01:53:33] [PASSED] 0xA7AD (ALDERLAKE_P) [01:53:33] [PASSED] 0xA720 (ALDERLAKE_P) [01:53:33] [PASSED] 0xA7A0 (ALDERLAKE_P) [01:53:33] [PASSED] 0xA7A8 (ALDERLAKE_P) [01:53:33] [PASSED] 0xA7AA (ALDERLAKE_P) [01:53:33] [PASSED] 0xA7AB (ALDERLAKE_P) [01:53:33] [PASSED] 0xA780 (ALDERLAKE_S) [01:53:33] [PASSED] 0xA781 (ALDERLAKE_S) [01:53:33] [PASSED] 0xA782 (ALDERLAKE_S) [01:53:33] [PASSED] 0xA783 (ALDERLAKE_S) [01:53:33] [PASSED] 0xA788 (ALDERLAKE_S) [01:53:33] [PASSED] 0xA789 (ALDERLAKE_S) [01:53:33] [PASSED] 0xA78A (ALDERLAKE_S) [01:53:33] [PASSED] 0xA78B (ALDERLAKE_S) [01:53:33] [PASSED] 0x4905 (DG1) [01:53:33] [PASSED] 0x4906 (DG1) [01:53:33] [PASSED] 0x4907 (DG1) [01:53:33] [PASSED] 0x4908 (DG1) [01:53:33] [PASSED] 0x4909 (DG1) [01:53:33] [PASSED] 0x56C0 (DG2) [01:53:33] [PASSED] 0x56C2 (DG2) [01:53:33] [PASSED] 0x56C1 (DG2) [01:53:33] [PASSED] 0x7D51 (METEORLAKE) [01:53:33] [PASSED] 0x7DD1 (METEORLAKE) [01:53:33] [PASSED] 0x7D41 (METEORLAKE) [01:53:33] [PASSED] 0x7D67 (METEORLAKE) [01:53:33] [PASSED] 0xB640 (METEORLAKE) [01:53:33] [PASSED] 0x56A0 (DG2) [01:53:33] [PASSED] 0x56A1 (DG2) [01:53:33] [PASSED] 0x56A2 (DG2) [01:53:33] [PASSED] 0x56BE (DG2) [01:53:33] [PASSED] 0x56BF (DG2) [01:53:33] [PASSED] 0x5690 (DG2) stty: 'standard input': Inappropriate ioctl for device [01:53:33] [PASSED] 0x5691 (DG2) [01:53:33] [PASSED] 0x5692 (DG2) [01:53:33] [PASSED] 0x56A5 (DG2) [01:53:33] [PASSED] 0x56A6 (DG2) [01:53:33] [PASSED] 0x56B0 (DG2) [01:53:33] [PASSED] 0x56B1 (DG2) [01:53:33] [PASSED] 0x56BA (DG2) [01:53:33] [PASSED] 0x56BB (DG2) [01:53:33] [PASSED] 0x56BC (DG2) [01:53:33] [PASSED] 0x56BD (DG2) [01:53:33] [PASSED] 0x5693 (DG2) [01:53:33] [PASSED] 0x5694 (DG2) [01:53:33] [PASSED] 0x5695 (DG2) [01:53:33] [PASSED] 0x56A3 (DG2) [01:53:33] [PASSED] 0x56A4 (DG2) [01:53:33] [PASSED] 0x56B2 (DG2) [01:53:33] [PASSED] 0x56B3 (DG2) [01:53:33] [PASSED] 0x5696 (DG2) [01:53:33] [PASSED] 0x5697 (DG2) [01:53:33] [PASSED] 0xB69 (PVC) [01:53:33] [PASSED] 0xB6E (PVC) [01:53:33] [PASSED] 0xBD4 (PVC) [01:53:33] [PASSED] 0xBD5 (PVC) [01:53:33] [PASSED] 0xBD6 (PVC) [01:53:33] [PASSED] 0xBD7 (PVC) [01:53:33] [PASSED] 0xBD8 (PVC) [01:53:33] [PASSED] 0xBD9 (PVC) [01:53:33] [PASSED] 0xBDA (PVC) [01:53:33] [PASSED] 0xBDB (PVC) [01:53:33] [PASSED] 0xBE0 (PVC) [01:53:33] [PASSED] 0xBE1 (PVC) [01:53:33] [PASSED] 0xBE5 (PVC) [01:53:33] [PASSED] 0x7D40 (METEORLAKE) [01:53:33] [PASSED] 0x7D45 (METEORLAKE) [01:53:33] [PASSED] 0x7D55 (METEORLAKE) [01:53:33] [PASSED] 0x7D60 (METEORLAKE) [01:53:33] [PASSED] 0x7DD5 (METEORLAKE) [01:53:33] [PASSED] 0x6420 (LUNARLAKE) [01:53:33] [PASSED] 0x64A0 (LUNARLAKE) [01:53:33] [PASSED] 0x64B0 (LUNARLAKE) [01:53:33] [PASSED] 0xE202 (BATTLEMAGE) [01:53:33] [PASSED] 0xE209 (BATTLEMAGE) [01:53:33] [PASSED] 0xE20B (BATTLEMAGE) [01:53:33] [PASSED] 0xE20C (BATTLEMAGE) [01:53:33] [PASSED] 0xE20D (BATTLEMAGE) [01:53:33] [PASSED] 0xE210 (BATTLEMAGE) [01:53:33] [PASSED] 0xE211 (BATTLEMAGE) [01:53:33] [PASSED] 0xE212 (BATTLEMAGE) [01:53:33] [PASSED] 0xE216 (BATTLEMAGE) [01:53:33] [PASSED] 0xE220 (BATTLEMAGE) [01:53:33] [PASSED] 0xE221 (BATTLEMAGE) [01:53:33] [PASSED] 0xE222 (BATTLEMAGE) [01:53:33] [PASSED] 0xE223 (BATTLEMAGE) [01:53:33] [PASSED] 0xB080 (PANTHERLAKE) [01:53:33] [PASSED] 0xB081 (PANTHERLAKE) [01:53:33] [PASSED] 0xB082 (PANTHERLAKE) [01:53:33] [PASSED] 0xB083 (PANTHERLAKE) [01:53:33] [PASSED] 0xB084 (PANTHERLAKE) [01:53:33] [PASSED] 0xB085 (PANTHERLAKE) [01:53:33] [PASSED] 0xB086 (PANTHERLAKE) [01:53:33] [PASSED] 0xB087 (PANTHERLAKE) [01:53:33] [PASSED] 0xB08F (PANTHERLAKE) [01:53:33] [PASSED] 0xB090 (PANTHERLAKE) [01:53:33] [PASSED] 0xB0A0 (PANTHERLAKE) [01:53:33] [PASSED] 0xB0B0 (PANTHERLAKE) [01:53:33] [PASSED] 0xD740 (NOVALAKE_S) [01:53:33] [PASSED] 0xD741 (NOVALAKE_S) [01:53:33] [PASSED] 0xD742 (NOVALAKE_S) [01:53:33] [PASSED] 0xD743 (NOVALAKE_S) [01:53:33] [PASSED] 0xD744 (NOVALAKE_S) [01:53:33] [PASSED] 0xD745 (NOVALAKE_S) [01:53:33] [PASSED] 0x674C (CRESCENTISLAND) [01:53:33] [PASSED] 0xFD80 (PANTHERLAKE) [01:53:33] [PASSED] 0xFD81 (PANTHERLAKE) [01:53:33] =============== [PASSED] check_platform_desc =============== [01:53:33] ===================== [PASSED] xe_pci ====================== [01:53:33] =================== xe_rtp (2 subtests) ==================== [01:53:33] =============== xe_rtp_process_to_sr_tests ================ [01:53:33] [PASSED] coalesce-same-reg [01:53:33] [PASSED] no-match-no-add [01:53:33] [PASSED] match-or [01:53:33] [PASSED] match-or-xfail [01:53:33] [PASSED] no-match-no-add-multiple-rules [01:53:33] [PASSED] two-regs-two-entries [01:53:33] [PASSED] clr-one-set-other [01:53:33] [PASSED] set-field [01:53:33] [PASSED] conflict-duplicate [01:53:33] [PASSED] conflict-not-disjoint [01:53:33] [PASSED] conflict-reg-type [01:53:33] =========== [PASSED] xe_rtp_process_to_sr_tests ============ [01:53:33] ================== xe_rtp_process_tests =================== [01:53:33] [PASSED] active1 [01:53:33] [PASSED] active2 [01:53:33] [PASSED] active-inactive [01:53:33] [PASSED] inactive-active [01:53:33] [PASSED] inactive-1st_or_active-inactive [01:53:33] [PASSED] inactive-2nd_or_active-inactive [01:53:33] [PASSED] inactive-last_or_active-inactive [01:53:33] [PASSED] inactive-no_or_active-inactive [01:53:33] ============== [PASSED] xe_rtp_process_tests =============== [01:53:33] ===================== [PASSED] xe_rtp ====================== [01:53:33] ==================== xe_wa (1 subtest) ===================== [01:53:33] ======================== xe_wa_gt ========================= [01:53:33] [PASSED] TIGERLAKE B0 [01:53:33] [PASSED] DG1 A0 [01:53:33] [PASSED] DG1 B0 [01:53:33] [PASSED] ALDERLAKE_S A0 [01:53:33] [PASSED] ALDERLAKE_S B0 [01:53:33] [PASSED] ALDERLAKE_S C0 [01:53:33] [PASSED] ALDERLAKE_S D0 [01:53:33] [PASSED] ALDERLAKE_P A0 [01:53:33] [PASSED] ALDERLAKE_P B0 [01:53:33] [PASSED] ALDERLAKE_P C0 [01:53:33] [PASSED] ALDERLAKE_S RPLS D0 [01:53:33] [PASSED] ALDERLAKE_P RPLU E0 [01:53:33] [PASSED] DG2 G10 C0 [01:53:33] [PASSED] DG2 G11 B1 [01:53:33] [PASSED] DG2 G12 A1 [01:53:33] [PASSED] METEORLAKE 12.70(Xe_LPG) A0 13.00(Xe_LPM+) A0 [01:53:33] [PASSED] METEORLAKE 12.71(Xe_LPG) A0 13.00(Xe_LPM+) A0 [01:53:33] [PASSED] METEORLAKE 12.74(Xe_LPG+) A0 13.00(Xe_LPM+) A0 [01:53:33] [PASSED] LUNARLAKE 20.04(Xe2_LPG) A0 20.00(Xe2_LPM) A0 [01:53:33] [PASSED] LUNARLAKE 20.04(Xe2_LPG) B0 20.00(Xe2_LPM) A0 [01:53:33] [PASSED] BATTLEMAGE 20.01(Xe2_HPG) A0 13.01(Xe2_HPM) A1 [01:53:33] [PASSED] PANTHERLAKE 30.00(Xe3_LPG) A0 30.00(Xe3_LPM) A0 [01:53:33] ==================== [PASSED] xe_wa_gt ===================== [01:53:33] ====================== [PASSED] xe_wa ====================== [01:53:33] ============================================================ [01:53:33] Testing complete. Ran 446 tests: passed: 428, skipped: 18 [01:53:33] Elapsed time: 34.802s total, 4.163s configuring, 30.173s building, 0.429s running
+ /kernel/tools/testing/kunit/kunit.py run --kunitconfig /kernel/drivers/gpu/drm/tests/.kunitconfig [01:53:33] Configuring KUnit Kernel ...
Regenerating .config ...
Populating config with:
$ make ARCH=um O=.kunit olddefconfig [01:53:35] Building KUnit Kernel ... Populating config with: $ make ARCH=um O=.kunit olddefconfig Building with: $ make all compile_commands.json scripts_gdb ARCH=um O=.kunit --jobs=48 [01:54:00] Starting KUnit Kernel (1/1)... [01:54:00] ============================================================ Running tests with: $ .kunit/linux kunit.enable=1 mem=1G console=tty kunit_shutdown=halt [01:54:00] ============ drm_test_pick_cmdline (2 subtests) ============ [01:54:00] [PASSED] drm_test_pick_cmdline_res_1920_1080_60 [01:54:00] =============== drm_test_pick_cmdline_named =============== [01:54:00] [PASSED] NTSC [01:54:00] [PASSED] NTSC-J [01:54:00] [PASSED] PAL [01:54:00] [PASSED] PAL-M [01:54:00] =========== [PASSED] drm_test_pick_cmdline_named =========== [01:54:00] ============== [PASSED] drm_test_pick_cmdline ============== [01:54:00] == drm_test_atomic_get_connector_for_encoder (1 subtest) === [01:54:00] [PASSED] drm_test_drm_atomic_get_connector_for_encoder [01:54:00] ==== [PASSED] drm_test_atomic_get_connector_for_encoder ==== [01:54:00] =========== drm_validate_clone_mode (2 subtests) =========== [01:54:00] ============== drm_test_check_in_clone_mode =============== [01:54:00] [PASSED] in_clone_mode [01:54:00] [PASSED] not_in_clone_mode [01:54:00] ========== [PASSED] drm_test_check_in_clone_mode =========== [01:54:00] =============== drm_test_check_valid_clones =============== [01:54:00] [PASSED] not_in_clone_mode [01:54:00] [PASSED] valid_clone [01:54:00] [PASSED] invalid_clone [01:54:00] =========== [PASSED] drm_test_check_valid_clones =========== [01:54:00] ============= [PASSED] drm_validate_clone_mode ============= [01:54:00] ============= drm_validate_modeset (1 subtest) ============= [01:54:00] [PASSED] drm_test_check_connector_changed_modeset [01:54:00] ============== [PASSED] drm_validate_modeset =============== [01:54:00] ====== drm_test_bridge_get_current_state (2 subtests) ====== [01:54:00] [PASSED] drm_test_drm_bridge_get_current_state_atomic [01:54:00] [PASSED] drm_test_drm_bridge_get_current_state_legacy [01:54:00] ======== [PASSED] drm_test_bridge_get_current_state ======== [01:54:00] ====== drm_test_bridge_helper_reset_crtc (3 subtests) ====== [01:54:00] [PASSED] drm_test_drm_bridge_helper_reset_crtc_atomic [01:54:00] [PASSED] drm_test_drm_bridge_helper_reset_crtc_atomic_disabled [01:54:00] [PASSED] drm_test_drm_bridge_helper_reset_crtc_legacy [01:54:00] ======== [PASSED] drm_test_bridge_helper_reset_crtc ======== [01:54:00] ============== drm_bridge_alloc (2 subtests) =============== [01:54:00] [PASSED] drm_test_drm_bridge_alloc_basic [01:54:00] [PASSED] drm_test_drm_bridge_alloc_get_put [01:54:00] ================ [PASSED] drm_bridge_alloc ================= [01:54:00] ================== drm_buddy (8 subtests) ================== [01:54:00] [PASSED] drm_test_buddy_alloc_limit [01:54:00] [PASSED] drm_test_buddy_alloc_optimistic [01:54:00] [PASSED] drm_test_buddy_alloc_pessimistic [01:54:00] [PASSED] drm_test_buddy_alloc_pathological [01:54:00] [PASSED] drm_test_buddy_alloc_contiguous [01:54:00] [PASSED] drm_test_buddy_alloc_clear [01:54:00] [PASSED] drm_test_buddy_alloc_range_bias [01:54:00] [PASSED] drm_test_buddy_fragmentation_performance [01:54:00] ==================== [PASSED] drm_buddy ==================== [01:54:00] ============= drm_cmdline_parser (40 subtests) ============= [01:54:00] [PASSED] drm_test_cmdline_force_d_only [01:54:00] [PASSED] drm_test_cmdline_force_D_only_dvi [01:54:00] [PASSED] drm_test_cmdline_force_D_only_hdmi [01:54:00] [PASSED] drm_test_cmdline_force_D_only_not_digital [01:54:00] [PASSED] drm_test_cmdline_force_e_only [01:54:00] [PASSED] drm_test_cmdline_res [01:54:00] [PASSED] drm_test_cmdline_res_vesa [01:54:00] [PASSED] drm_test_cmdline_res_vesa_rblank [01:54:00] [PASSED] drm_test_cmdline_res_rblank [01:54:00] [PASSED] drm_test_cmdline_res_bpp [01:54:00] [PASSED] drm_test_cmdline_res_refresh [01:54:00] [PASSED] drm_test_cmdline_res_bpp_refresh [01:54:00] [PASSED] drm_test_cmdline_res_bpp_refresh_interlaced [01:54:00] [PASSED] drm_test_cmdline_res_bpp_refresh_margins [01:54:00] [PASSED] drm_test_cmdline_res_bpp_refresh_force_off [01:54:00] [PASSED] drm_test_cmdline_res_bpp_refresh_force_on [01:54:00] [PASSED] drm_test_cmdline_res_bpp_refresh_force_on_analog [01:54:00] [PASSED] drm_test_cmdline_res_bpp_refresh_force_on_digital [01:54:00] [PASSED] drm_test_cmdline_res_bpp_refresh_interlaced_margins_force_on [01:54:00] [PASSED] drm_test_cmdline_res_margins_force_on [01:54:00] [PASSED] drm_test_cmdline_res_vesa_margins [01:54:00] [PASSED] drm_test_cmdline_name [01:54:00] [PASSED] drm_test_cmdline_name_bpp [01:54:00] [PASSED] drm_test_cmdline_name_option [01:54:00] [PASSED] drm_test_cmdline_name_bpp_option [01:54:00] [PASSED] drm_test_cmdline_rotate_0 [01:54:00] [PASSED] drm_test_cmdline_rotate_90 [01:54:00] [PASSED] drm_test_cmdline_rotate_180 [01:54:00] [PASSED] drm_test_cmdline_rotate_270 [01:54:00] [PASSED] drm_test_cmdline_hmirror [01:54:00] [PASSED] drm_test_cmdline_vmirror [01:54:00] [PASSED] drm_test_cmdline_margin_options [01:54:00] [PASSED] drm_test_cmdline_multiple_options [01:54:00] [PASSED] drm_test_cmdline_bpp_extra_and_option [01:54:00] [PASSED] drm_test_cmdline_extra_and_option [01:54:00] [PASSED] drm_test_cmdline_freestanding_options [01:54:00] [PASSED] drm_test_cmdline_freestanding_force_e_and_options [01:54:00] [PASSED] drm_test_cmdline_panel_orientation [01:54:00] ================ drm_test_cmdline_invalid ================= [01:54:00] [PASSED] margin_only [01:54:00] [PASSED] interlace_only [01:54:00] [PASSED] res_missing_x [01:54:00] [PASSED] res_missing_y [01:54:00] [PASSED] res_bad_y [01:54:00] [PASSED] res_missing_y_bpp [01:54:00] [PASSED] res_bad_bpp [01:54:00] [PASSED] res_bad_refresh [01:54:00] [PASSED] res_bpp_refresh_force_on_off [01:54:00] [PASSED] res_invalid_mode [01:54:00] [PASSED] res_bpp_wrong_place_mode [01:54:00] [PASSED] name_bpp_refresh [01:54:00] [PASSED] name_refresh [01:54:00] [PASSED] name_refresh_wrong_mode [01:54:00] [PASSED] name_refresh_invalid_mode [01:54:00] [PASSED] rotate_multiple [01:54:00] [PASSED] rotate_invalid_val [01:54:00] [PASSED] rotate_truncated [01:54:00] [PASSED] invalid_option [01:54:00] [PASSED] invalid_tv_option [01:54:00] [PASSED] truncated_tv_option [01:54:00] ============ [PASSED] drm_test_cmdline_invalid ============= [01:54:00] =============== drm_test_cmdline_tv_options =============== [01:54:00] [PASSED] NTSC [01:54:00] [PASSED] NTSC_443 [01:54:00] [PASSED] NTSC_J [01:54:00] [PASSED] PAL [01:54:00] [PASSED] PAL_M [01:54:00] [PASSED] PAL_N [01:54:00] [PASSED] SECAM [01:54:00] [PASSED] MONO_525 [01:54:00] [PASSED] MONO_625 [01:54:00] =========== [PASSED] drm_test_cmdline_tv_options =========== [01:54:00] =============== [PASSED] drm_cmdline_parser ================ [01:54:00] ========== drmm_connector_hdmi_init (20 subtests) ========== [01:54:00] [PASSED] drm_test_connector_hdmi_init_valid [01:54:00] [PASSED] drm_test_connector_hdmi_init_bpc_8 [01:54:00] [PASSED] drm_test_connector_hdmi_init_bpc_10 [01:54:00] [PASSED] drm_test_connector_hdmi_init_bpc_12 [01:54:00] [PASSED] drm_test_connector_hdmi_init_bpc_invalid [01:54:00] [PASSED] drm_test_connector_hdmi_init_bpc_null [01:54:00] [PASSED] drm_test_connector_hdmi_init_formats_empty [01:54:00] [PASSED] drm_test_connector_hdmi_init_formats_no_rgb [01:54:00] === drm_test_connector_hdmi_init_formats_yuv420_allowed === [01:54:00] [PASSED] supported_formats=0x9 yuv420_allowed=1 [01:54:00] [PASSED] supported_formats=0x9 yuv420_allowed=0 [01:54:00] [PASSED] supported_formats=0x3 yuv420_allowed=1 [01:54:00] [PASSED] supported_formats=0x3 yuv420_allowed=0 [01:54:00] === [PASSED] drm_test_connector_hdmi_init_formats_yuv420_allowed === [01:54:00] [PASSED] drm_test_connector_hdmi_init_null_ddc [01:54:00] [PASSED] drm_test_connector_hdmi_init_null_product [01:54:00] [PASSED] drm_test_connector_hdmi_init_null_vendor [01:54:00] [PASSED] drm_test_connector_hdmi_init_product_length_exact [01:54:00] [PASSED] drm_test_connector_hdmi_init_product_length_too_long [01:54:00] [PASSED] drm_test_connector_hdmi_init_product_valid [01:54:00] [PASSED] drm_test_connector_hdmi_init_vendor_length_exact [01:54:00] [PASSED] drm_test_connector_hdmi_init_vendor_length_too_long [01:54:00] [PASSED] drm_test_connector_hdmi_init_vendor_valid [01:54:00] ========= drm_test_connector_hdmi_init_type_valid ========= [01:54:00] [PASSED] HDMI-A [01:54:00] [PASSED] HDMI-B [01:54:00] ===== [PASSED] drm_test_connector_hdmi_init_type_valid ===== [01:54:00] ======== drm_test_connector_hdmi_init_type_invalid ======== [01:54:00] [PASSED] Unknown [01:54:00] [PASSED] VGA [01:54:00] [PASSED] DVI-I [01:54:00] [PASSED] DVI-D [01:54:00] [PASSED] DVI-A [01:54:00] [PASSED] Composite [01:54:00] [PASSED] SVIDEO [01:54:00] [PASSED] LVDS [01:54:00] [PASSED] Component [01:54:00] [PASSED] DIN [01:54:00] [PASSED] DP [01:54:00] [PASSED] TV [01:54:00] [PASSED] eDP [01:54:00] [PASSED] Virtual [01:54:00] [PASSED] DSI [01:54:00] [PASSED] DPI [01:54:00] [PASSED] Writeback [01:54:00] [PASSED] SPI [01:54:00] [PASSED] USB [01:54:00] ==== [PASSED] drm_test_connector_hdmi_init_type_invalid ==== [01:54:00] ============ [PASSED] drmm_connector_hdmi_init ============= [01:54:00] ============= drmm_connector_init (3 subtests) ============= [01:54:00] [PASSED] drm_test_drmm_connector_init [01:54:00] [PASSED] drm_test_drmm_connector_init_null_ddc [01:54:00] ========= drm_test_drmm_connector_init_type_valid ========= [01:54:00] [PASSED] Unknown [01:54:00] [PASSED] VGA [01:54:00] [PASSED] DVI-I [01:54:00] [PASSED] DVI-D [01:54:00] [PASSED] DVI-A [01:54:00] [PASSED] Composite [01:54:00] [PASSED] SVIDEO [01:54:00] [PASSED] LVDS [01:54:00] [PASSED] Component [01:54:00] [PASSED] DIN [01:54:00] [PASSED] DP [01:54:00] [PASSED] HDMI-A [01:54:00] [PASSED] HDMI-B [01:54:00] [PASSED] TV [01:54:00] [PASSED] eDP [01:54:00] [PASSED] Virtual [01:54:00] [PASSED] DSI [01:54:00] [PASSED] DPI [01:54:00] [PASSED] Writeback [01:54:00] [PASSED] SPI [01:54:00] [PASSED] USB [01:54:00] ===== [PASSED] drm_test_drmm_connector_init_type_valid ===== [01:54:00] =============== [PASSED] drmm_connector_init =============== [01:54:00] ========= drm_connector_dynamic_init (6 subtests) ========== [01:54:00] [PASSED] drm_test_drm_connector_dynamic_init [01:54:00] [PASSED] drm_test_drm_connector_dynamic_init_null_ddc [01:54:00] [PASSED] drm_test_drm_connector_dynamic_init_not_added [01:54:00] [PASSED] drm_test_drm_connector_dynamic_init_properties [01:54:00] ===== drm_test_drm_connector_dynamic_init_type_valid ====== [01:54:00] [PASSED] Unknown [01:54:00] [PASSED] VGA [01:54:00] [PASSED] DVI-I [01:54:00] [PASSED] DVI-D [01:54:00] [PASSED] DVI-A [01:54:00] [PASSED] Composite [01:54:00] [PASSED] SVIDEO [01:54:00] [PASSED] LVDS [01:54:00] [PASSED] Component [01:54:00] [PASSED] DIN [01:54:00] [PASSED] DP [01:54:00] [PASSED] HDMI-A [01:54:00] [PASSED] HDMI-B [01:54:00] [PASSED] TV [01:54:00] [PASSED] eDP [01:54:00] [PASSED] Virtual [01:54:00] [PASSED] DSI [01:54:00] [PASSED] DPI [01:54:00] [PASSED] Writeback [01:54:00] [PASSED] SPI [01:54:00] [PASSED] USB [01:54:00] = [PASSED] drm_test_drm_connector_dynamic_init_type_valid == [01:54:00] ======== drm_test_drm_connector_dynamic_init_name ========= [01:54:00] [PASSED] Unknown [01:54:00] [PASSED] VGA [01:54:00] [PASSED] DVI-I [01:54:00] [PASSED] DVI-D [01:54:00] [PASSED] DVI-A [01:54:00] [PASSED] Composite [01:54:00] [PASSED] SVIDEO [01:54:00] [PASSED] LVDS [01:54:00] [PASSED] Component [01:54:00] [PASSED] DIN [01:54:00] [PASSED] DP [01:54:00] [PASSED] HDMI-A [01:54:00] [PASSED] HDMI-B [01:54:00] [PASSED] TV [01:54:00] [PASSED] eDP [01:54:00] [PASSED] Virtual [01:54:00] [PASSED] DSI [01:54:00] [PASSED] DPI [01:54:00] [PASSED] Writeback [01:54:00] [PASSED] SPI [01:54:00] [PASSED] USB [01:54:00] ==== [PASSED] drm_test_drm_connector_dynamic_init_name ===== [01:54:00] =========== [PASSED] drm_connector_dynamic_init ============ [01:54:00] ==== drm_connector_dynamic_register_early (4 subtests) ===== [01:54:00] [PASSED] drm_test_drm_connector_dynamic_register_early_on_list [01:54:00] [PASSED] drm_test_drm_connector_dynamic_register_early_defer [01:54:00] [PASSED] drm_test_drm_connector_dynamic_register_early_no_init [01:54:00] [PASSED] drm_test_drm_connector_dynamic_register_early_no_mode_object [01:54:00] ====== [PASSED] drm_connector_dynamic_register_early ======= [01:54:00] ======= drm_connector_dynamic_register (7 subtests) ======== [01:54:00] [PASSED] drm_test_drm_connector_dynamic_register_on_list [01:54:00] [PASSED] drm_test_drm_connector_dynamic_register_no_defer [01:54:00] [PASSED] drm_test_drm_connector_dynamic_register_no_init [01:54:00] [PASSED] drm_test_drm_connector_dynamic_register_mode_object [01:54:00] [PASSED] drm_test_drm_connector_dynamic_register_sysfs [01:54:00] [PASSED] drm_test_drm_connector_dynamic_register_sysfs_name [01:54:00] [PASSED] drm_test_drm_connector_dynamic_register_debugfs [01:54:00] ========= [PASSED] drm_connector_dynamic_register ========== [01:54:00] = drm_connector_attach_broadcast_rgb_property (2 subtests) = [01:54:00] [PASSED] drm_test_drm_connector_attach_broadcast_rgb_property [01:54:00] [PASSED] drm_test_drm_connector_attach_broadcast_rgb_property_hdmi_connector [01:54:00] === [PASSED] drm_connector_attach_broadcast_rgb_property === [01:54:00] ========== drm_get_tv_mode_from_name (2 subtests) ========== [01:54:00] ========== drm_test_get_tv_mode_from_name_valid =========== [01:54:00] [PASSED] NTSC [01:54:00] [PASSED] NTSC-443 [01:54:00] [PASSED] NTSC-J [01:54:00] [PASSED] PAL [01:54:00] [PASSED] PAL-M [01:54:00] [PASSED] PAL-N [01:54:00] [PASSED] SECAM [01:54:00] [PASSED] Mono [01:54:00] ====== [PASSED] drm_test_get_tv_mode_from_name_valid ======= [01:54:00] [PASSED] drm_test_get_tv_mode_from_name_truncated [01:54:00] ============ [PASSED] drm_get_tv_mode_from_name ============ [01:54:00] = drm_test_connector_hdmi_compute_mode_clock (12 subtests) = [01:54:00] [PASSED] drm_test_drm_hdmi_compute_mode_clock_rgb [01:54:00] [PASSED] drm_test_drm_hdmi_compute_mode_clock_rgb_10bpc [01:54:00] [PASSED] drm_test_drm_hdmi_compute_mode_clock_rgb_10bpc_vic_1 [01:54:00] [PASSED] drm_test_drm_hdmi_compute_mode_clock_rgb_12bpc [01:54:00] [PASSED] drm_test_drm_hdmi_compute_mode_clock_rgb_12bpc_vic_1 [01:54:00] [PASSED] drm_test_drm_hdmi_compute_mode_clock_rgb_double [01:54:00] = drm_test_connector_hdmi_compute_mode_clock_yuv420_valid = [01:54:00] [PASSED] VIC 96 [01:54:00] [PASSED] VIC 97 [01:54:00] [PASSED] VIC 101 [01:54:00] [PASSED] VIC 102 [01:54:00] [PASSED] VIC 106 [01:54:00] [PASSED] VIC 107 [01:54:00] === [PASSED] drm_test_connector_hdmi_compute_mode_clock_yuv420_valid === [01:54:00] [PASSED] drm_test_connector_hdmi_compute_mode_clock_yuv420_10_bpc [01:54:00] [PASSED] drm_test_connector_hdmi_compute_mode_clock_yuv420_12_bpc [01:54:00] [PASSED] drm_test_connector_hdmi_compute_mode_clock_yuv422_8_bpc [01:54:00] [PASSED] drm_test_connector_hdmi_compute_mode_clock_yuv422_10_bpc [01:54:00] [PASSED] drm_test_connector_hdmi_compute_mode_clock_yuv422_12_bpc [01:54:00] === [PASSED] drm_test_connector_hdmi_compute_mode_clock ==== [01:54:00] == drm_hdmi_connector_get_broadcast_rgb_name (2 subtests) == [01:54:00] === drm_test_drm_hdmi_connector_get_broadcast_rgb_name ==== [01:54:00] [PASSED] Automatic [01:54:00] [PASSED] Full [01:54:00] [PASSED] Limited 16:235 [01:54:00] === [PASSED] drm_test_drm_hdmi_connector_get_broadcast_rgb_name === [01:54:00] [PASSED] drm_test_drm_hdmi_connector_get_broadcast_rgb_name_invalid [01:54:00] ==== [PASSED] drm_hdmi_connector_get_broadcast_rgb_name ==== [01:54:00] == drm_hdmi_connector_get_output_format_name (2 subtests) == [01:54:00] === drm_test_drm_hdmi_connector_get_output_format_name ==== [01:54:00] [PASSED] RGB [01:54:00] [PASSED] YUV 4:2:0 [01:54:00] [PASSED] YUV 4:2:2 [01:54:00] [PASSED] YUV 4:4:4 [01:54:00] === [PASSED] drm_test_drm_hdmi_connector_get_output_format_name === [01:54:00] [PASSED] drm_test_drm_hdmi_connector_get_output_format_name_invalid [01:54:00] ==== [PASSED] drm_hdmi_connector_get_output_format_name ==== [01:54:00] ============= drm_damage_helper (21 subtests) ============== [01:54:00] [PASSED] drm_test_damage_iter_no_damage [01:54:00] [PASSED] drm_test_damage_iter_no_damage_fractional_src [01:54:00] [PASSED] drm_test_damage_iter_no_damage_src_moved [01:54:00] [PASSED] drm_test_damage_iter_no_damage_fractional_src_moved [01:54:00] [PASSED] drm_test_damage_iter_no_damage_not_visible [01:54:00] [PASSED] drm_test_damage_iter_no_damage_no_crtc [01:54:00] [PASSED] drm_test_damage_iter_no_damage_no_fb [01:54:00] [PASSED] drm_test_damage_iter_simple_damage [01:54:00] [PASSED] drm_test_damage_iter_single_damage [01:54:00] [PASSED] drm_test_damage_iter_single_damage_intersect_src [01:54:00] [PASSED] drm_test_damage_iter_single_damage_outside_src [01:54:00] [PASSED] drm_test_damage_iter_single_damage_fractional_src [01:54:00] [PASSED] drm_test_damage_iter_single_damage_intersect_fractional_src [01:54:00] [PASSED] drm_test_damage_iter_single_damage_outside_fractional_src [01:54:00] [PASSED] drm_test_damage_iter_single_damage_src_moved [01:54:00] [PASSED] drm_test_damage_iter_single_damage_fractional_src_moved [01:54:00] [PASSED] drm_test_damage_iter_damage [01:54:00] [PASSED] drm_test_damage_iter_damage_one_intersect [01:54:00] [PASSED] drm_test_damage_iter_damage_one_outside [01:54:00] [PASSED] drm_test_damage_iter_damage_src_moved [01:54:00] [PASSED] drm_test_damage_iter_damage_not_visible [01:54:00] ================ [PASSED] drm_damage_helper ================ [01:54:00] ============== drm_dp_mst_helper (3 subtests) ============== [01:54:00] ============== drm_test_dp_mst_calc_pbn_mode ============== [01:54:00] [PASSED] Clock 154000 BPP 30 DSC disabled [01:54:00] [PASSED] Clock 234000 BPP 30 DSC disabled [01:54:00] [PASSED] Clock 297000 BPP 24 DSC disabled [01:54:00] [PASSED] Clock 332880 BPP 24 DSC enabled [01:54:00] [PASSED] Clock 324540 BPP 24 DSC enabled [01:54:00] ========== [PASSED] drm_test_dp_mst_calc_pbn_mode ========== [01:54:00] ============== drm_test_dp_mst_calc_pbn_div =============== [01:54:00] [PASSED] Link rate 2000000 lane count 4 [01:54:00] [PASSED] Link rate 2000000 lane count 2 [01:54:00] [PASSED] Link rate 2000000 lane count 1 [01:54:00] [PASSED] Link rate 1350000 lane count 4 [01:54:00] [PASSED] Link rate 1350000 lane count 2 [01:54:00] [PASSED] Link rate 1350000 lane count 1 [01:54:00] [PASSED] Link rate 1000000 lane count 4 [01:54:00] [PASSED] Link rate 1000000 lane count 2 [01:54:00] [PASSED] Link rate 1000000 lane count 1 [01:54:00] [PASSED] Link rate 810000 lane count 4 [01:54:00] [PASSED] Link rate 810000 lane count 2 [01:54:00] [PASSED] Link rate 810000 lane count 1 [01:54:00] [PASSED] Link rate 540000 lane count 4 [01:54:00] [PASSED] Link rate 540000 lane count 2 [01:54:00] [PASSED] Link rate 540000 lane count 1 [01:54:00] [PASSED] Link rate 270000 lane count 4 [01:54:00] [PASSED] Link rate 270000 lane count 2 [01:54:00] [PASSED] Link rate 270000 lane count 1 [01:54:00] [PASSED] Link rate 162000 lane count 4 [01:54:00] [PASSED] Link rate 162000 lane count 2 [01:54:00] [PASSED] Link rate 162000 lane count 1 [01:54:00] ========== [PASSED] drm_test_dp_mst_calc_pbn_div =========== [01:54:00] ========= drm_test_dp_mst_sideband_msg_req_decode ========= [01:54:00] [PASSED] DP_ENUM_PATH_RESOURCES with port number [01:54:00] [PASSED] DP_POWER_UP_PHY with port number [01:54:00] [PASSED] DP_POWER_DOWN_PHY with port number [01:54:00] [PASSED] DP_ALLOCATE_PAYLOAD with SDP stream sinks [01:54:00] [PASSED] DP_ALLOCATE_PAYLOAD with port number [01:54:00] [PASSED] DP_ALLOCATE_PAYLOAD with VCPI [01:54:00] [PASSED] DP_ALLOCATE_PAYLOAD with PBN [01:54:00] [PASSED] DP_QUERY_PAYLOAD with port number [01:54:00] [PASSED] DP_QUERY_PAYLOAD with VCPI [01:54:00] [PASSED] DP_REMOTE_DPCD_READ with port number [01:54:00] [PASSED] DP_REMOTE_DPCD_READ with DPCD address [01:54:00] [PASSED] DP_REMOTE_DPCD_READ with max number of bytes [01:54:00] [PASSED] DP_REMOTE_DPCD_WRITE with port number [01:54:00] [PASSED] DP_REMOTE_DPCD_WRITE with DPCD address [01:54:00] [PASSED] DP_REMOTE_DPCD_WRITE with data array [01:54:00] [PASSED] DP_REMOTE_I2C_READ with port number [01:54:00] [PASSED] DP_REMOTE_I2C_READ with I2C device ID [01:54:00] [PASSED] DP_REMOTE_I2C_READ with transactions array [01:54:00] [PASSED] DP_REMOTE_I2C_WRITE with port number [01:54:00] [PASSED] DP_REMOTE_I2C_WRITE with I2C device ID [01:54:00] [PASSED] DP_REMOTE_I2C_WRITE with data array [01:54:00] [PASSED] DP_QUERY_STREAM_ENC_STATUS with stream ID [01:54:00] [PASSED] DP_QUERY_STREAM_ENC_STATUS with client ID [01:54:00] [PASSED] DP_QUERY_STREAM_ENC_STATUS with stream event [01:54:00] [PASSED] DP_QUERY_STREAM_ENC_STATUS with valid stream event [01:54:00] [PASSED] DP_QUERY_STREAM_ENC_STATUS with stream behavior [01:54:00] [PASSED] DP_QUERY_STREAM_ENC_STATUS with a valid stream behavior [01:54:00] ===== [PASSED] drm_test_dp_mst_sideband_msg_req_decode ===== [01:54:00] ================ [PASSED] drm_dp_mst_helper ================ [01:54:00] ================== drm_exec (7 subtests) =================== [01:54:00] [PASSED] sanitycheck [01:54:00] [PASSED] test_lock [01:54:00] [PASSED] test_lock_unlock [01:54:00] [PASSED] test_duplicates [01:54:00] [PASSED] test_prepare [01:54:00] [PASSED] test_prepare_array [01:54:00] [PASSED] test_multiple_loops [01:54:00] ==================== [PASSED] drm_exec ===================== [01:54:00] =========== drm_format_helper_test (17 subtests) =========== [01:54:00] ============== drm_test_fb_xrgb8888_to_gray8 ============== [01:54:00] [PASSED] single_pixel_source_buffer [01:54:00] [PASSED] single_pixel_clip_rectangle [01:54:00] [PASSED] well_known_colors [01:54:00] [PASSED] destination_pitch [01:54:00] ========== [PASSED] drm_test_fb_xrgb8888_to_gray8 ========== [01:54:00] ============= drm_test_fb_xrgb8888_to_rgb332 ============== [01:54:00] [PASSED] single_pixel_source_buffer [01:54:00] [PASSED] single_pixel_clip_rectangle [01:54:00] [PASSED] well_known_colors [01:54:00] [PASSED] destination_pitch [01:54:00] ========= [PASSED] drm_test_fb_xrgb8888_to_rgb332 ========== [01:54:00] ============= drm_test_fb_xrgb8888_to_rgb565 ============== [01:54:00] [PASSED] single_pixel_source_buffer [01:54:00] [PASSED] single_pixel_clip_rectangle [01:54:00] [PASSED] well_known_colors [01:54:00] [PASSED] destination_pitch [01:54:00] ========= [PASSED] drm_test_fb_xrgb8888_to_rgb565 ========== [01:54:00] ============ drm_test_fb_xrgb8888_to_xrgb1555 ============= [01:54:00] [PASSED] single_pixel_source_buffer [01:54:00] [PASSED] single_pixel_clip_rectangle [01:54:00] [PASSED] well_known_colors [01:54:00] [PASSED] destination_pitch [01:54:00] ======== [PASSED] drm_test_fb_xrgb8888_to_xrgb1555 ========= [01:54:00] ============ drm_test_fb_xrgb8888_to_argb1555 ============= [01:54:00] [PASSED] single_pixel_source_buffer [01:54:00] [PASSED] single_pixel_clip_rectangle [01:54:00] [PASSED] well_known_colors [01:54:00] [PASSED] destination_pitch [01:54:00] ======== [PASSED] drm_test_fb_xrgb8888_to_argb1555 ========= [01:54:00] ============ drm_test_fb_xrgb8888_to_rgba5551 ============= [01:54:00] [PASSED] single_pixel_source_buffer [01:54:00] [PASSED] single_pixel_clip_rectangle [01:54:00] [PASSED] well_known_colors [01:54:00] [PASSED] destination_pitch [01:54:00] ======== [PASSED] drm_test_fb_xrgb8888_to_rgba5551 ========= [01:54:00] ============= drm_test_fb_xrgb8888_to_rgb888 ============== [01:54:00] [PASSED] single_pixel_source_buffer [01:54:00] [PASSED] single_pixel_clip_rectangle [01:54:00] [PASSED] well_known_colors [01:54:00] [PASSED] destination_pitch [01:54:00] ========= [PASSED] drm_test_fb_xrgb8888_to_rgb888 ========== [01:54:00] ============= drm_test_fb_xrgb8888_to_bgr888 ============== [01:54:00] [PASSED] single_pixel_source_buffer [01:54:00] [PASSED] single_pixel_clip_rectangle [01:54:00] [PASSED] well_known_colors [01:54:00] [PASSED] destination_pitch [01:54:00] ========= [PASSED] drm_test_fb_xrgb8888_to_bgr888 ========== [01:54:00] ============ drm_test_fb_xrgb8888_to_argb8888 ============= [01:54:00] [PASSED] single_pixel_source_buffer [01:54:00] [PASSED] single_pixel_clip_rectangle [01:54:00] [PASSED] well_known_colors [01:54:00] [PASSED] destination_pitch [01:54:00] ======== [PASSED] drm_test_fb_xrgb8888_to_argb8888 ========= [01:54:00] =========== drm_test_fb_xrgb8888_to_xrgb2101010 =========== [01:54:00] [PASSED] single_pixel_source_buffer [01:54:00] [PASSED] single_pixel_clip_rectangle [01:54:00] [PASSED] well_known_colors [01:54:00] [PASSED] destination_pitch [01:54:00] ======= [PASSED] drm_test_fb_xrgb8888_to_xrgb2101010 ======= [01:54:00] =========== drm_test_fb_xrgb8888_to_argb2101010 =========== [01:54:00] [PASSED] single_pixel_source_buffer [01:54:00] [PASSED] single_pixel_clip_rectangle [01:54:00] [PASSED] well_known_colors [01:54:00] [PASSED] destination_pitch [01:54:00] ======= [PASSED] drm_test_fb_xrgb8888_to_argb2101010 ======= [01:54:00] ============== drm_test_fb_xrgb8888_to_mono =============== [01:54:00] [PASSED] single_pixel_source_buffer [01:54:00] [PASSED] single_pixel_clip_rectangle [01:54:00] [PASSED] well_known_colors [01:54:00] [PASSED] destination_pitch [01:54:00] ========== [PASSED] drm_test_fb_xrgb8888_to_mono =========== [01:54:00] ==================== drm_test_fb_swab ===================== [01:54:00] [PASSED] single_pixel_source_buffer [01:54:00] [PASSED] single_pixel_clip_rectangle [01:54:00] [PASSED] well_known_colors [01:54:00] [PASSED] destination_pitch [01:54:00] ================ [PASSED] drm_test_fb_swab ================= [01:54:00] ============ drm_test_fb_xrgb8888_to_xbgr8888 ============= [01:54:00] [PASSED] single_pixel_source_buffer [01:54:00] [PASSED] single_pixel_clip_rectangle [01:54:00] [PASSED] well_known_colors [01:54:00] [PASSED] destination_pitch [01:54:00] ======== [PASSED] drm_test_fb_xrgb8888_to_xbgr8888 ========= [01:54:00] ============ drm_test_fb_xrgb8888_to_abgr8888 ============= [01:54:00] [PASSED] single_pixel_source_buffer [01:54:00] [PASSED] single_pixel_clip_rectangle [01:54:00] [PASSED] well_known_colors [01:54:00] [PASSED] destination_pitch [01:54:00] ======== [PASSED] drm_test_fb_xrgb8888_to_abgr8888 ========= [01:54:00] ================= drm_test_fb_clip_offset ================= [01:54:00] [PASSED] pass through [01:54:00] [PASSED] horizontal offset [01:54:00] [PASSED] vertical offset [01:54:00] [PASSED] horizontal and vertical offset [01:54:00] [PASSED] horizontal offset (custom pitch) [01:54:00] [PASSED] vertical offset (custom pitch) [01:54:00] [PASSED] horizontal and vertical offset (custom pitch) [01:54:00] ============= [PASSED] drm_test_fb_clip_offset ============= [01:54:00] =================== drm_test_fb_memcpy ==================== [01:54:00] [PASSED] single_pixel_source_buffer: XR24 little-endian (0x34325258) [01:54:00] [PASSED] single_pixel_source_buffer: XRA8 little-endian (0x38415258) [01:54:00] [PASSED] single_pixel_source_buffer: YU24 little-endian (0x34325559) [01:54:00] [PASSED] single_pixel_clip_rectangle: XB24 little-endian (0x34324258) [01:54:00] [PASSED] single_pixel_clip_rectangle: XRA8 little-endian (0x38415258) [01:54:00] [PASSED] single_pixel_clip_rectangle: YU24 little-endian (0x34325559) [01:54:00] [PASSED] well_known_colors: XB24 little-endian (0x34324258) [01:54:00] [PASSED] well_known_colors: XRA8 little-endian (0x38415258) [01:54:00] [PASSED] well_known_colors: YU24 little-endian (0x34325559) [01:54:00] [PASSED] destination_pitch: XB24 little-endian (0x34324258) [01:54:00] [PASSED] destination_pitch: XRA8 little-endian (0x38415258) [01:54:00] [PASSED] destination_pitch: YU24 little-endian (0x34325559) [01:54:00] =============== [PASSED] drm_test_fb_memcpy ================ [01:54:00] ============= [PASSED] drm_format_helper_test ============== [01:54:00] ================= drm_format (18 subtests) ================= [01:54:00] [PASSED] drm_test_format_block_width_invalid [01:54:00] [PASSED] drm_test_format_block_width_one_plane [01:54:00] [PASSED] drm_test_format_block_width_two_plane [01:54:00] [PASSED] drm_test_format_block_width_three_plane [01:54:00] [PASSED] drm_test_format_block_width_tiled [01:54:00] [PASSED] drm_test_format_block_height_invalid [01:54:00] [PASSED] drm_test_format_block_height_one_plane [01:54:00] [PASSED] drm_test_format_block_height_two_plane [01:54:00] [PASSED] drm_test_format_block_height_three_plane [01:54:00] [PASSED] drm_test_format_block_height_tiled [01:54:00] [PASSED] drm_test_format_min_pitch_invalid [01:54:00] [PASSED] drm_test_format_min_pitch_one_plane_8bpp [01:54:00] [PASSED] drm_test_format_min_pitch_one_plane_16bpp [01:54:00] [PASSED] drm_test_format_min_pitch_one_plane_24bpp [01:54:00] [PASSED] drm_test_format_min_pitch_one_plane_32bpp [01:54:00] [PASSED] drm_test_format_min_pitch_two_plane [01:54:00] [PASSED] drm_test_format_min_pitch_three_plane_8bpp [01:54:00] [PASSED] drm_test_format_min_pitch_tiled [01:54:00] =================== [PASSED] drm_format ==================== [01:54:00] ============== drm_framebuffer (10 subtests) =============== [01:54:00] ========== drm_test_framebuffer_check_src_coords ========== [01:54:00] [PASSED] Success: source fits into fb [01:54:00] [PASSED] Fail: overflowing fb with x-axis coordinate [01:54:00] [PASSED] Fail: overflowing fb with y-axis coordinate [01:54:00] [PASSED] Fail: overflowing fb with source width [01:54:00] [PASSED] Fail: overflowing fb with source height [01:54:00] ====== [PASSED] drm_test_framebuffer_check_src_coords ====== [01:54:00] [PASSED] drm_test_framebuffer_cleanup [01:54:00] =============== drm_test_framebuffer_create =============== [01:54:00] [PASSED] ABGR8888 normal sizes [01:54:00] [PASSED] ABGR8888 max sizes [01:54:00] [PASSED] ABGR8888 pitch greater than min required [01:54:00] [PASSED] ABGR8888 pitch less than min required [01:54:00] [PASSED] ABGR8888 Invalid width [01:54:00] [PASSED] ABGR8888 Invalid buffer handle [01:54:00] [PASSED] No pixel format [01:54:00] [PASSED] ABGR8888 Width 0 [01:54:00] [PASSED] ABGR8888 Height 0 [01:54:00] [PASSED] ABGR8888 Out of bound height * pitch combination [01:54:00] [PASSED] ABGR8888 Large buffer offset [01:54:00] [PASSED] ABGR8888 Buffer offset for inexistent plane [01:54:00] [PASSED] ABGR8888 Invalid flag [01:54:00] [PASSED] ABGR8888 Set DRM_MODE_FB_MODIFIERS without modifiers [01:54:00] [PASSED] ABGR8888 Valid buffer modifier [01:54:00] [PASSED] ABGR8888 Invalid buffer modifier(DRM_FORMAT_MOD_SAMSUNG_64_32_TILE) [01:54:00] [PASSED] ABGR8888 Extra pitches without DRM_MODE_FB_MODIFIERS [01:54:00] [PASSED] ABGR8888 Extra pitches with DRM_MODE_FB_MODIFIERS [01:54:00] [PASSED] NV12 Normal sizes [01:54:00] [PASSED] NV12 Max sizes [01:54:00] [PASSED] NV12 Invalid pitch [01:54:00] [PASSED] NV12 Invalid modifier/missing DRM_MODE_FB_MODIFIERS flag [01:54:00] [PASSED] NV12 different modifier per-plane [01:54:00] [PASSED] NV12 with DRM_FORMAT_MOD_SAMSUNG_64_32_TILE [01:54:00] [PASSED] NV12 Valid modifiers without DRM_MODE_FB_MODIFIERS [01:54:00] [PASSED] NV12 Modifier for inexistent plane [01:54:00] [PASSED] NV12 Handle for inexistent plane [01:54:00] [PASSED] NV12 Handle for inexistent plane without DRM_MODE_FB_MODIFIERS [01:54:00] [PASSED] YVU420 DRM_MODE_FB_MODIFIERS set without modifier [01:54:00] [PASSED] YVU420 Normal sizes [01:54:00] [PASSED] YVU420 Max sizes [01:54:00] [PASSED] YVU420 Invalid pitch [01:54:00] [PASSED] YVU420 Different pitches [01:54:00] [PASSED] YVU420 Different buffer offsets/pitches [01:54:00] [PASSED] YVU420 Modifier set just for plane 0, without DRM_MODE_FB_MODIFIERS [01:54:00] [PASSED] YVU420 Modifier set just for planes 0, 1, without DRM_MODE_FB_MODIFIERS [01:54:00] [PASSED] YVU420 Modifier set just for plane 0, 1, with DRM_MODE_FB_MODIFIERS [01:54:00] [PASSED] YVU420 Valid modifier [01:54:00] [PASSED] YVU420 Different modifiers per plane [01:54:00] [PASSED] YVU420 Modifier for inexistent plane [01:54:00] [PASSED] YUV420_10BIT Invalid modifier(DRM_FORMAT_MOD_LINEAR) [01:54:00] [PASSED] X0L2 Normal sizes [01:54:00] [PASSED] X0L2 Max sizes [01:54:00] [PASSED] X0L2 Invalid pitch [01:54:00] [PASSED] X0L2 Pitch greater than minimum required [01:54:00] [PASSED] X0L2 Handle for inexistent plane [01:54:00] [PASSED] X0L2 Offset for inexistent plane, without DRM_MODE_FB_MODIFIERS set [01:54:00] [PASSED] X0L2 Modifier without DRM_MODE_FB_MODIFIERS set [01:54:00] [PASSED] X0L2 Valid modifier [01:54:00] [PASSED] X0L2 Modifier for inexistent plane [01:54:00] =========== [PASSED] drm_test_framebuffer_create =========== [01:54:00] [PASSED] drm_test_framebuffer_free [01:54:00] [PASSED] drm_test_framebuffer_init [01:54:00] [PASSED] drm_test_framebuffer_init_bad_format [01:54:00] [PASSED] drm_test_framebuffer_init_dev_mismatch [01:54:00] [PASSED] drm_test_framebuffer_lookup [01:54:00] [PASSED] drm_test_framebuffer_lookup_inexistent [01:54:00] [PASSED] drm_test_framebuffer_modifiers_not_supported [01:54:00] ================= [PASSED] drm_framebuffer ================= [01:54:00] ================ drm_gem_shmem (8 subtests) ================ [01:54:00] [PASSED] drm_gem_shmem_test_obj_create [01:54:00] [PASSED] drm_gem_shmem_test_obj_create_private [01:54:00] [PASSED] drm_gem_shmem_test_pin_pages [01:54:00] [PASSED] drm_gem_shmem_test_vmap [01:54:00] [PASSED] drm_gem_shmem_test_get_pages_sgt [01:54:00] [PASSED] drm_gem_shmem_test_get_sg_table [01:54:00] [PASSED] drm_gem_shmem_test_madvise [01:54:00] [PASSED] drm_gem_shmem_test_purge [01:54:00] ================== [PASSED] drm_gem_shmem ================== [01:54:00] === drm_atomic_helper_connector_hdmi_check (27 subtests) === [01:54:00] [PASSED] drm_test_check_broadcast_rgb_auto_cea_mode [01:54:00] [PASSED] drm_test_check_broadcast_rgb_auto_cea_mode_vic_1 [01:54:00] [PASSED] drm_test_check_broadcast_rgb_full_cea_mode [01:54:00] [PASSED] drm_test_check_broadcast_rgb_full_cea_mode_vic_1 [01:54:00] [PASSED] drm_test_check_broadcast_rgb_limited_cea_mode [01:54:00] [PASSED] drm_test_check_broadcast_rgb_limited_cea_mode_vic_1 [01:54:00] ====== drm_test_check_broadcast_rgb_cea_mode_yuv420 ======= [01:54:00] [PASSED] Automatic [01:54:00] [PASSED] Full [01:54:00] [PASSED] Limited 16:235 [01:54:00] == [PASSED] drm_test_check_broadcast_rgb_cea_mode_yuv420 === [01:54:00] [PASSED] drm_test_check_broadcast_rgb_crtc_mode_changed [01:54:00] [PASSED] drm_test_check_broadcast_rgb_crtc_mode_not_changed [01:54:00] [PASSED] drm_test_check_disable_connector [01:54:00] [PASSED] drm_test_check_hdmi_funcs_reject_rate [01:54:00] [PASSED] drm_test_check_max_tmds_rate_bpc_fallback_rgb [01:54:00] [PASSED] drm_test_check_max_tmds_rate_bpc_fallback_yuv420 [01:54:00] [PASSED] drm_test_check_max_tmds_rate_bpc_fallback_ignore_yuv422 [01:54:00] [PASSED] drm_test_check_max_tmds_rate_bpc_fallback_ignore_yuv420 [01:54:00] [PASSED] drm_test_check_driver_unsupported_fallback_yuv420 [01:54:00] [PASSED] drm_test_check_output_bpc_crtc_mode_changed [01:54:00] [PASSED] drm_test_check_output_bpc_crtc_mode_not_changed [01:54:00] [PASSED] drm_test_check_output_bpc_dvi [01:54:00] [PASSED] drm_test_check_output_bpc_format_vic_1 [01:54:00] [PASSED] drm_test_check_output_bpc_format_display_8bpc_only [01:54:00] [PASSED] drm_test_check_output_bpc_format_display_rgb_only [01:54:00] [PASSED] drm_test_check_output_bpc_format_driver_8bpc_only [01:54:00] [PASSED] drm_test_check_output_bpc_format_driver_rgb_only [01:54:00] [PASSED] drm_test_check_tmds_char_rate_rgb_8bpc [01:54:00] [PASSED] drm_test_check_tmds_char_rate_rgb_10bpc [01:54:00] [PASSED] drm_test_check_tmds_char_rate_rgb_12bpc [01:54:00] ===== [PASSED] drm_atomic_helper_connector_hdmi_check ====== [01:54:00] === drm_atomic_helper_connector_hdmi_reset (6 subtests) ==== [01:54:00] [PASSED] drm_test_check_broadcast_rgb_value [01:54:00] [PASSED] drm_test_check_bpc_8_value [01:54:00] [PASSED] drm_test_check_bpc_10_value [01:54:00] [PASSED] drm_test_check_bpc_12_value [01:54:00] [PASSED] drm_test_check_format_value [01:54:00] [PASSED] drm_test_check_tmds_char_value [01:54:00] ===== [PASSED] drm_atomic_helper_connector_hdmi_reset ====== [01:54:00] = drm_atomic_helper_connector_hdmi_mode_valid (4 subtests) = [01:54:00] [PASSED] drm_test_check_mode_valid [01:54:00] [PASSED] drm_test_check_mode_valid_reject [01:54:00] [PASSED] drm_test_check_mode_valid_reject_rate [01:54:00] [PASSED] drm_test_check_mode_valid_reject_max_clock [01:54:00] === [PASSED] drm_atomic_helper_connector_hdmi_mode_valid === [01:54:00] ================= drm_managed (2 subtests) ================= [01:54:00] [PASSED] drm_test_managed_release_action [01:54:00] [PASSED] drm_test_managed_run_action [01:54:00] =================== [PASSED] drm_managed =================== [01:54:00] =================== drm_mm (6 subtests) ==================== [01:54:00] [PASSED] drm_test_mm_init [01:54:00] [PASSED] drm_test_mm_debug [01:54:00] [PASSED] drm_test_mm_align32 [01:54:00] [PASSED] drm_test_mm_align64 [01:54:00] [PASSED] drm_test_mm_lowest [01:54:00] [PASSED] drm_test_mm_highest [01:54:00] ===================== [PASSED] drm_mm ====================== [01:54:00] ============= drm_modes_analog_tv (5 subtests) ============= [01:54:00] [PASSED] drm_test_modes_analog_tv_mono_576i [01:54:00] [PASSED] drm_test_modes_analog_tv_ntsc_480i [01:54:00] [PASSED] drm_test_modes_analog_tv_ntsc_480i_inlined [01:54:00] [PASSED] drm_test_modes_analog_tv_pal_576i [01:54:00] [PASSED] drm_test_modes_analog_tv_pal_576i_inlined [01:54:00] =============== [PASSED] drm_modes_analog_tv =============== [01:54:00] ============== drm_plane_helper (2 subtests) =============== [01:54:00] =============== drm_test_check_plane_state ================ [01:54:00] [PASSED] clipping_simple [01:54:00] [PASSED] clipping_rotate_reflect [01:54:00] [PASSED] positioning_simple [01:54:00] [PASSED] upscaling [01:54:00] [PASSED] downscaling [01:54:00] [PASSED] rounding1 [01:54:00] [PASSED] rounding2 [01:54:00] [PASSED] rounding3 [01:54:00] [PASSED] rounding4 [01:54:00] =========== [PASSED] drm_test_check_plane_state ============ [01:54:00] =========== drm_test_check_invalid_plane_state ============ [01:54:00] [PASSED] positioning_invalid [01:54:00] [PASSED] upscaling_invalid [01:54:00] [PASSED] downscaling_invalid [01:54:00] ======= [PASSED] drm_test_check_invalid_plane_state ======== [01:54:00] ================ [PASSED] drm_plane_helper ================= [01:54:00] ====== drm_connector_helper_tv_get_modes (1 subtest) ======= [01:54:00] ====== drm_test_connector_helper_tv_get_modes_check ======= [01:54:00] [PASSED] None [01:54:00] [PASSED] PAL [01:54:00] [PASSED] NTSC [01:54:00] [PASSED] Both, NTSC Default [01:54:00] [PASSED] Both, PAL Default [01:54:00] [PASSED] Both, NTSC Default, with PAL on command-line [01:54:00] [PASSED] Both, PAL Default, with NTSC on command-line [01:54:00] == [PASSED] drm_test_connector_helper_tv_get_modes_check === [01:54:00] ======== [PASSED] drm_connector_helper_tv_get_modes ======== [01:54:00] ================== drm_rect (9 subtests) =================== [01:54:00] [PASSED] drm_test_rect_clip_scaled_div_by_zero [01:54:00] [PASSED] drm_test_rect_clip_scaled_not_clipped [01:54:00] [PASSED] drm_test_rect_clip_scaled_clipped [01:54:00] [PASSED] drm_test_rect_clip_scaled_signed_vs_unsigned [01:54:00] ================= drm_test_rect_intersect ================= [01:54:00] [PASSED] top-left x bottom-right: 2x2+1+1 x 2x2+0+0 [01:54:00] [PASSED] top-right x bottom-left: 2x2+0+0 x 2x2+1-1 [01:54:00] [PASSED] bottom-left x top-right: 2x2+1-1 x 2x2+0+0 [01:54:00] [PASSED] bottom-right x top-left: 2x2+0+0 x 2x2+1+1 [01:54:00] [PASSED] right x left: 2x1+0+0 x 3x1+1+0 [01:54:00] [PASSED] left x right: 3x1+1+0 x 2x1+0+0 [01:54:00] [PASSED] up x bottom: 1x2+0+0 x 1x3+0-1 [01:54:00] [PASSED] bottom x up: 1x3+0-1 x 1x2+0+0 [01:54:00] [PASSED] touching corner: 1x1+0+0 x 2x2+1+1 [01:54:00] [PASSED] touching side: 1x1+0+0 x 1x1+1+0 [01:54:00] [PASSED] equal rects: 2x2+0+0 x 2x2+0+0 [01:54:00] [PASSED] inside another: 2x2+0+0 x 1x1+1+1 [01:54:00] [PASSED] far away: 1x1+0+0 x 1x1+3+6 [01:54:00] [PASSED] points intersecting: 0x0+5+10 x 0x0+5+10 [01:54:00] [PASSED] points not intersecting: 0x0+0+0 x 0x0+5+10 [01:54:00] ============= [PASSED] drm_test_rect_intersect ============= [01:54:00] ================ drm_test_rect_calc_hscale ================ [01:54:00] [PASSED] normal use [01:54:00] [PASSED] out of max range [01:54:00] [PASSED] out of min range [01:54:00] [PASSED] zero dst [01:54:00] [PASSED] negative src [01:54:00] [PASSED] negative dst [01:54:00] ============ [PASSED] drm_test_rect_calc_hscale ============ [01:54:00] ================ drm_test_rect_calc_vscale ================ [01:54:00] [PASSED] normal use stty: 'standard input': Inappropriate ioctl for device [01:54:00] [PASSED] out of max range [01:54:00] [PASSED] out of min range [01:54:00] [PASSED] zero dst [01:54:00] [PASSED] negative src [01:54:00] [PASSED] negative dst [01:54:00] ============ [PASSED] drm_test_rect_calc_vscale ============ [01:54:00] ================== drm_test_rect_rotate =================== [01:54:00] [PASSED] reflect-x [01:54:00] [PASSED] reflect-y [01:54:00] [PASSED] rotate-0 [01:54:00] [PASSED] rotate-90 [01:54:00] [PASSED] rotate-180 [01:54:00] [PASSED] rotate-270 [01:54:00] ============== [PASSED] drm_test_rect_rotate =============== [01:54:00] ================ drm_test_rect_rotate_inv ================= [01:54:00] [PASSED] reflect-x [01:54:00] [PASSED] reflect-y [01:54:00] [PASSED] rotate-0 [01:54:00] [PASSED] rotate-90 [01:54:00] [PASSED] rotate-180 [01:54:00] [PASSED] rotate-270 [01:54:00] ============ [PASSED] drm_test_rect_rotate_inv ============= [01:54:00] ==================== [PASSED] drm_rect ===================== [01:54:00] ============ drm_sysfb_modeset_test (1 subtest) ============ [01:54:00] ============ drm_test_sysfb_build_fourcc_list ============= [01:54:00] [PASSED] no native formats [01:54:00] [PASSED] XRGB8888 as native format [01:54:00] [PASSED] remove duplicates [01:54:00] [PASSED] convert alpha formats [01:54:00] [PASSED] random formats [01:54:00] ======== [PASSED] drm_test_sysfb_build_fourcc_list ========= [01:54:00] ============= [PASSED] drm_sysfb_modeset_test ============== [01:54:00] ============================================================ [01:54:00] Testing complete. Ran 622 tests: passed: 622 [01:54:00] Elapsed time: 26.775s total, 1.726s configuring, 24.622s building, 0.424s running
+ /kernel/tools/testing/kunit/kunit.py run --kunitconfig /kernel/drivers/gpu/drm/ttm/tests/.kunitconfig [01:54:00] Configuring KUnit Kernel ...
Regenerating .config ...
Populating config with:
$ make ARCH=um O=.kunit olddefconfig [01:54:02] Building KUnit Kernel ... Populating config with: $ make ARCH=um O=.kunit olddefconfig Building with: $ make all compile_commands.json scripts_gdb ARCH=um O=.kunit --jobs=48 [01:54:11] Starting KUnit Kernel (1/1)... [01:54:11] ============================================================ Running tests with: $ .kunit/linux kunit.enable=1 mem=1G console=tty kunit_shutdown=halt [01:54:11] ================= ttm_device (5 subtests) ================== [01:54:11] [PASSED] ttm_device_init_basic [01:54:11] [PASSED] ttm_device_init_multiple [01:54:11] [PASSED] ttm_device_fini_basic [01:54:11] [PASSED] ttm_device_init_no_vma_man [01:54:11] ================== ttm_device_init_pools ================== [01:54:11] [PASSED] No DMA allocations, no DMA32 required [01:54:11] [PASSED] DMA allocations, DMA32 required [01:54:11] [PASSED] No DMA allocations, DMA32 required [01:54:11] [PASSED] DMA allocations, no DMA32 required [01:54:11] ============== [PASSED] ttm_device_init_pools ============== [01:54:11] =================== [PASSED] ttm_device ==================== [01:54:11] ================== ttm_pool (8 subtests) =================== [01:54:11] ================== ttm_pool_alloc_basic =================== [01:54:11] [PASSED] One page [01:54:11] [PASSED] More than one page [01:54:11] [PASSED] Above the allocation limit [01:54:11] [PASSED] One page, with coherent DMA mappings enabled [01:54:11] [PASSED] Above the allocation limit, with coherent DMA mappings enabled [01:54:11] ============== [PASSED] ttm_pool_alloc_basic =============== [01:54:11] ============== ttm_pool_alloc_basic_dma_addr ============== [01:54:11] [PASSED] One page [01:54:11] [PASSED] More than one page [01:54:11] [PASSED] Above the allocation limit [01:54:11] [PASSED] One page, with coherent DMA mappings enabled [01:54:11] [PASSED] Above the allocation limit, with coherent DMA mappings enabled [01:54:11] ========== [PASSED] ttm_pool_alloc_basic_dma_addr ========== [01:54:11] [PASSED] ttm_pool_alloc_order_caching_match [01:54:11] [PASSED] ttm_pool_alloc_caching_mismatch [01:54:11] [PASSED] ttm_pool_alloc_order_mismatch [01:54:11] [PASSED] ttm_pool_free_dma_alloc [01:54:11] [PASSED] ttm_pool_free_no_dma_alloc [01:54:11] [PASSED] ttm_pool_fini_basic [01:54:11] ==================== [PASSED] ttm_pool ===================== [01:54:11] ================ ttm_resource (8 subtests) ================= [01:54:11] ================= ttm_resource_init_basic ================= [01:54:11] [PASSED] Init resource in TTM_PL_SYSTEM [01:54:11] [PASSED] Init resource in TTM_PL_VRAM [01:54:11] [PASSED] Init resource in a private placement [01:54:11] [PASSED] Init resource in TTM_PL_SYSTEM, set placement flags [01:54:11] ============= [PASSED] ttm_resource_init_basic ============= [01:54:11] [PASSED] ttm_resource_init_pinned [01:54:11] [PASSED] ttm_resource_fini_basic [01:54:11] [PASSED] ttm_resource_manager_init_basic [01:54:11] [PASSED] ttm_resource_manager_usage_basic [01:54:11] [PASSED] ttm_resource_manager_set_used_basic [01:54:11] [PASSED] ttm_sys_man_alloc_basic [01:54:11] [PASSED] ttm_sys_man_free_basic [01:54:11] ================== [PASSED] ttm_resource =================== [01:54:11] =================== ttm_tt (15 subtests) =================== [01:54:11] ==================== ttm_tt_init_basic ==================== [01:54:11] [PASSED] Page-aligned size [01:54:11] [PASSED] Extra pages requested [01:54:11] ================ [PASSED] ttm_tt_init_basic ================ [01:54:11] [PASSED] ttm_tt_init_misaligned [01:54:11] [PASSED] ttm_tt_fini_basic [01:54:11] [PASSED] ttm_tt_fini_sg [01:54:11] [PASSED] ttm_tt_fini_shmem [01:54:11] [PASSED] ttm_tt_create_basic [01:54:11] [PASSED] ttm_tt_create_invalid_bo_type [01:54:11] [PASSED] ttm_tt_create_ttm_exists [01:54:11] [PASSED] ttm_tt_create_failed [01:54:11] [PASSED] ttm_tt_destroy_basic [01:54:11] [PASSED] ttm_tt_populate_null_ttm [01:54:11] [PASSED] ttm_tt_populate_populated_ttm [01:54:11] [PASSED] ttm_tt_unpopulate_basic [01:54:11] [PASSED] ttm_tt_unpopulate_empty_ttm [01:54:11] [PASSED] ttm_tt_swapin_basic [01:54:11] ===================== [PASSED] ttm_tt ====================== [01:54:11] =================== ttm_bo (14 subtests) =================== [01:54:11] =========== ttm_bo_reserve_optimistic_no_ticket =========== [01:54:11] [PASSED] Cannot be interrupted and sleeps [01:54:11] [PASSED] Cannot be interrupted, locks straight away [01:54:11] [PASSED] Can be interrupted, sleeps [01:54:11] ======= [PASSED] ttm_bo_reserve_optimistic_no_ticket ======= [01:54:11] [PASSED] ttm_bo_reserve_locked_no_sleep [01:54:11] [PASSED] ttm_bo_reserve_no_wait_ticket [01:54:11] [PASSED] ttm_bo_reserve_double_resv [01:54:11] [PASSED] ttm_bo_reserve_interrupted [01:54:11] [PASSED] ttm_bo_reserve_deadlock [01:54:11] [PASSED] ttm_bo_unreserve_basic [01:54:11] [PASSED] ttm_bo_unreserve_pinned [01:54:11] [PASSED] ttm_bo_unreserve_bulk [01:54:11] [PASSED] ttm_bo_fini_basic [01:54:11] [PASSED] ttm_bo_fini_shared_resv [01:54:11] [PASSED] ttm_bo_pin_basic [01:54:11] [PASSED] ttm_bo_pin_unpin_resource [01:54:11] [PASSED] ttm_bo_multiple_pin_one_unpin [01:54:11] ===================== [PASSED] ttm_bo ====================== [01:54:11] ============== ttm_bo_validate (21 subtests) =============== [01:54:11] ============== ttm_bo_init_reserved_sys_man =============== [01:54:11] [PASSED] Buffer object for userspace [01:54:11] [PASSED] Kernel buffer object [01:54:11] [PASSED] Shared buffer object [01:54:11] ========== [PASSED] ttm_bo_init_reserved_sys_man =========== [01:54:11] ============== ttm_bo_init_reserved_mock_man ============== [01:54:11] [PASSED] Buffer object for userspace [01:54:11] [PASSED] Kernel buffer object [01:54:11] [PASSED] Shared buffer object [01:54:11] ========== [PASSED] ttm_bo_init_reserved_mock_man ========== [01:54:11] [PASSED] ttm_bo_init_reserved_resv [01:54:11] ================== ttm_bo_validate_basic ================== [01:54:11] [PASSED] Buffer object for userspace [01:54:11] [PASSED] Kernel buffer object [01:54:11] [PASSED] Shared buffer object [01:54:11] ============== [PASSED] ttm_bo_validate_basic ============== [01:54:11] [PASSED] ttm_bo_validate_invalid_placement [01:54:11] ============= ttm_bo_validate_same_placement ============== [01:54:11] [PASSED] System manager [01:54:11] [PASSED] VRAM manager [01:54:11] ========= [PASSED] ttm_bo_validate_same_placement ========== [01:54:11] [PASSED] ttm_bo_validate_failed_alloc [01:54:11] [PASSED] ttm_bo_validate_pinned [01:54:11] [PASSED] ttm_bo_validate_busy_placement [01:54:11] ================ ttm_bo_validate_multihop ================= [01:54:11] [PASSED] Buffer object for userspace [01:54:11] [PASSED] Kernel buffer object [01:54:11] [PASSED] Shared buffer object [01:54:11] ============ [PASSED] ttm_bo_validate_multihop ============= [01:54:11] ========== ttm_bo_validate_no_placement_signaled ========== [01:54:11] [PASSED] Buffer object in system domain, no page vector [01:54:11] [PASSED] Buffer object in system domain with an existing page vector [01:54:11] ====== [PASSED] ttm_bo_validate_no_placement_signaled ====== [01:54:11] ======== ttm_bo_validate_no_placement_not_signaled ======== [01:54:11] [PASSED] Buffer object for userspace [01:54:11] [PASSED] Kernel buffer object [01:54:11] [PASSED] Shared buffer object [01:54:11] ==== [PASSED] ttm_bo_validate_no_placement_not_signaled ==== [01:54:11] [PASSED] ttm_bo_validate_move_fence_signaled [01:54:12] ========= ttm_bo_validate_move_fence_not_signaled ========= [01:54:12] [PASSED] Waits for GPU [01:54:12] [PASSED] Tries to lock straight away [01:54:12] ===== [PASSED] ttm_bo_validate_move_fence_not_signaled ===== [01:54:12] [PASSED] ttm_bo_validate_happy_evict [01:54:12] [PASSED] ttm_bo_validate_all_pinned_evict [01:54:12] [PASSED] ttm_bo_validate_allowed_only_evict [01:54:12] [PASSED] ttm_bo_validate_deleted_evict [01:54:12] [PASSED] ttm_bo_validate_busy_domain_evict [01:54:12] [PASSED] ttm_bo_validate_evict_gutting [01:54:12] [PASSED] ttm_bo_validate_recrusive_evict stty: 'standard input': Inappropriate ioctl for device [01:54:12] ================= [PASSED] ttm_bo_validate ================= [01:54:12] ============================================================ [01:54:12] Testing complete. Ran 101 tests: passed: 101 [01:54:12] Elapsed time: 11.234s total, 1.714s configuring, 9.304s building, 0.184s running
+ cleanup
++ stat -c %u:%g /kernel
+ chown -R 1003:1003 /kernel
Patchwork
CI✗ CI.checksparse: warning for drm/i915/display: Add initial support for Xe3p_LPD (rev4)
In reply to Gustavo Sousa== Series Details ==
== Series Details ==
Series: drm/i915/display: Add initial support for Xe3p_LPD (rev4)
URL : https://patchwork.freedesktop.org/series/155951/
State : warning
== Summary ==
+ trap cleanup EXIT
+ KERNEL=/kernel
+ MT=/root/linux/maintainer-tools
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools /root/linux/maintainer-tools Cloning into '/root/linux/maintainer-tools'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ make -C /root/linux/maintainer-tools
make: Entering directory '/root/linux/maintainer-tools'
cc -O2 -g -Wextra -o remap-log remap-log.c
make: Leaving directory '/root/linux/maintainer-tools'
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ /root/linux/maintainer-tools/dim sparse --fast 2bc418aa7efaae562e49d84e8b28f799cf624745 Sparse version: 0.6.4 (Ubuntu: 0.6.4-4ubuntu3)
Fast mode used, each commit won't be checked separately.
-+drivers/gpu/drm/i915/display/intel_alpm.c: note: in included file:+drivers/gpu/drm/i915/display/intel_casf.c:147:21: error: too long token expansion +drivers/gpu/drm/i915/display/intel_cdclk.c: note: in included file:+drivers/gpu/drm/i915/display/intel_ddi.c: note: in included file:+drivers/gpu/drm/i915/display/intel_display_types.h:2074:24: warning: unreplaced symbol '<noident>' +drivers/gpu/drm/i915/display/intel_display_types.h:2074:24: warning: unreplaced symbol '<noident>' +drivers/gpu/drm/i915/display/intel_display_types.h:2074:24: warning: unreplaced symbol '<noident>' +drivers/gpu/drm/i915/display/intel_display_types.h:2074:24: warning: unreplaced symbol '<noident>' +drivers/gpu/drm/i915/display/intel_display_types.h:2074:24: warning: unreplaced symbol '<noident>' +drivers/gpu/drm/i915/display/intel_display_types.h:2074:24: warning: unreplaced symbol '<noident>' +drivers/gpu/drm/i915/display/intel_display_types.h:2074:24: warning: unreplaced symbol '<noident>' +drivers/gpu/drm/i915/display/intel_display_types.h:2074:24: warning: unreplaced symbol '<noident>' +drivers/gpu/drm/i915/display/intel_display_types.h:2074:24: warning: unreplaced symbol '<noident>' +drivers/gpu/drm/i915/display/intel_display_types.h:2074:24: warning: unreplaced symbol '<noident>' +drivers/gpu/drm/i915/display/intel_display_types.h:2074:24: warning: unreplaced symbol '<noident>' +drivers/gpu/drm/i915/display/intel_display_types.h:2074:24: warning: unreplaced symbol '<noident>' +drivers/gpu/drm/i915/display/intel_display_types.h:2074:24: warning: unreplaced symbol '<noident>' +drivers/gpu/drm/i915/display/intel_display_types.h:2074:24: warning: unreplaced symbol '<noident>' +drivers/gpu/drm/i915/display/intel_display_types.h:2074:24: warning: unreplaced symbol '<noident>' +drivers/gpu/drm/i915/display/intel_display_types.h:2074:24: warning: unreplaced symbol '<noident>' +drivers/gpu/drm/i915/display/intel_display_types.h:2087:24: warning: unreplaced symbol '<noident>' +drivers/gpu/drm/i915/display/intel_display_types.h:2087:24: warning: unreplaced symbol '<noident>' +drivers/gpu/drm/i915/display/intel_display_types.h:2087:24: warning: unreplaced symbol '<noident>' +drivers/gpu/drm/i915/display/intel_hdcp.c: note: in included file:+drivers/gpu/drm/i915/display/intel_hotplug.c: note: in included file:+drivers/gpu/drm/i915/display/intel_lt_phy.c:1603:35: warning: Using plain integer as NULL pointer +drivers/gpu/drm/i915/display/intel_pps.c: note: in included file:+drivers/gpu/drm/i915/display/intel_psr.c: note: in included file:+drivers/gpu/drm/i915/intel_uncore.c:1930:1: warning: context imbalance in 'fwtable_read8' - unexpected unlock +drivers/gpu/drm/i915/intel_uncore.c:1931:1: warning: context imbalance in 'fwtable_read16' - unexpected unlock +drivers/gpu/drm/i915/intel_uncore.c:1932:1: warning: context imbalance in 'fwtable_read32' - unexpected unlock +drivers/gpu/drm/i915/intel_uncore.c:1933:1: warning: context imbalance in 'fwtable_read64' - unexpected unlock +drivers/gpu/drm/i915/intel_uncore.c:1998:1: warning: context imbalance in 'gen6_write8' - unexpected unlock +drivers/gpu/drm/i915/intel_uncore.c:1999:1: warning: context imbalance in 'gen6_write16' - unexpected unlock +drivers/gpu/drm/i915/intel_uncore.c:2000:1: warning: context imbalance in 'gen6_write32' - unexpected unlock +drivers/gpu/drm/i915/intel_uncore.c:2020:1: warning: context imbalance in 'fwtable_write8' - unexpected unlock +drivers/gpu/drm/i915/intel_uncore.c:2021:1: warning: context imbalance in 'fwtable_write16' - unexpected unlock +drivers/gpu/drm/i915/intel_uncore.c:2022:1: warning: context imbalance in 'fwtable_write32' - unexpected unlock
+ cleanup
++ stat -c %u:%g /kernel
+ chown -R 1003:1003 /kernel
Patchwork
CI✗ Xe.CI.BAT: failure for drm/i915/display: Add initial support for Xe3p_LPD (rev4)
In reply to Gustavo Sousa== Series Details ==
== Series Details ==
Series: drm/i915/display: Add initial support for Xe3p_LPD (rev4)
URL : https://patchwork.freedesktop.org/series/155951/
State : failure
== Summary ==
CI Bug Log - changes from xe-4074-2bc418aa7efaae562e49d84e8b28f799cf624745_BAT -> xe-pw-155951v4_BAT
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with xe-pw-155951v4_BAT absolutely need to be verified manually.
If you think the reported changes have nothing to do with the changes
introduced in xe-pw-155951v4_BAT, please notify your bug team ([email protected]) to allow them to document this new failure mode, which will reduce false positives in CI.
Participating hosts (13 -> 13)
------------------------------
No changes in participating hosts
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in xe-pw-155951v4_BAT:
### IGT changes ###
#### Possible regressions ####
* igt@xe_module_load@load:
- bat-bmg-2: [PASS][1] -> [ABORT][2]
[1]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4074-2bc418aa7efaae562e49d84e8b28f799cf624745/bat-bmg-2/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155951v4/bat-bmg-2/igt@[email protected]
- bat-bmg-3: [PASS][3] -> [ABORT][4]
[3]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4074-2bc418aa7efaae562e49d84e8b28f799cf624745/bat-bmg-3/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155951v4/bat-bmg-3/igt@[email protected]
- bat-bmg-1: [PASS][5] -> [ABORT][6]
[5]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4074-2bc418aa7efaae562e49d84e8b28f799cf624745/bat-bmg-1/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155951v4/bat-bmg-1/igt@[email protected]
Known issues
------------
Here are the changes found in xe-pw-155951v4_BAT that come from known issues:
### IGT changes ###
#### Possible fixes ####
* igt@kms_flip@basic-flip-vs-modeset@d-edp1:
- bat-adlp-7: [DMESG-WARN][7] ([Intel XE#4543]) -> [PASS][8] +1 other test pass
[7]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4074-2bc418aa7efaae562e49d84e8b28f799cf624745/bat-adlp-7/igt@kms_flip@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155951v4/bat-adlp-7/igt@kms_flip@[email protected]
[Intel XE#4543]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/4543
Build changes
-------------
* Linux: xe-4074-2bc418aa7efaae562e49d84e8b28f799cf624745 -> xe-pw-155951v4
IGT_8614: 8614
xe-4074-2bc418aa7efaae562e49d84e8b28f799cf624745: 2bc418aa7efaae562e49d84e8b28f799cf624745
xe-pw-155951v4: 155951v4
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155951v4/index.html
Patchwork
CI✗ i915.CI.Full: failure for drm/i915/display: Add initial support for Xe3p_LPD (rev4)
In reply to Gustavo Sousa== Series Details ==
== Series Details ==
Series: drm/i915/display: Add initial support for Xe3p_LPD (rev4)
URL : https://patchwork.freedesktop.org/series/155952/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_17515_full -> Patchwork_155952v4_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_155952v4_full absolutely need to be verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_155952v4_full, please notify your bug team ([email protected]) to allow them to document this new failure mode, which will reduce false positives in CI.
Participating hosts (12 -> 11)
------------------------------
Missing (1): shard-snb-0
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_155952v4_full:
### IGT changes ###
#### Possible regressions ####
* igt@panthor/panthor_gem@bo_mmap_offset:
- shard-dg2: NOTRUN -> [SKIP][1]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-dg2-3/igt@panthor/panthor_gem@bo_mmap_offset.html
* igt@vgem_basic@unload:
- shard-snb: NOTRUN -> [INCOMPLETE][2]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-snb6/igt@[email protected]
#### Warnings ####
* igt@panthor/panthor_vm@vm_create_destroy:
- shard-rkl: [SKIP][3] ([i915#14544]) -> [SKIP][4] +3 other tests skip
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17515/shard-rkl-6/igt@panthor/panthor_vm@vm_create_destroy.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-rkl-2/igt@panthor/panthor_vm@vm_create_destroy.html
Known issues
------------
Here are the changes found in Patchwork_155952v4_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@api_intel_bb@object-reloc-keep-cache:
- shard-rkl: NOTRUN -> [SKIP][5] ([i915#14544] / [i915#8411])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-rkl-6/igt@[email protected]
- shard-mtlp: NOTRUN -> [SKIP][6] ([i915#8411])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-mtlp-6/igt@[email protected]
* igt@api_intel_bb@object-reloc-purge-cache:
- shard-rkl: NOTRUN -> [SKIP][7] ([i915#8411])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-rkl-8/igt@[email protected]
* igt@drm_buddy@drm_buddy:
- shard-dg2: NOTRUN -> [DMESG-WARN][8] ([i915#15095]) +1 other test dmesg-warn
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-dg2-3/igt@drm_buddy@drm_buddy.html
* igt@fbdev@eof:
- shard-rkl: [PASS][9] -> [SKIP][10] ([i915#14544] / [i915#2582]) +1 other test skip
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17515/shard-rkl-4/igt@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-rkl-6/igt@[email protected]
* igt@fbdev@info:
- shard-rkl: [PASS][11] -> [SKIP][12] ([i915#14544] / [i915#1849] / [i915#2582])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17515/shard-rkl-5/igt@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-rkl-6/igt@[email protected]
* igt@gem_bad_reloc@negative-reloc-lut:
- shard-rkl: NOTRUN -> [SKIP][13] ([i915#3281]) +2 other tests skip
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-rkl-8/igt@[email protected]
* igt@gem_ccs@suspend-resume@xmajor-compressed-compfmt0-lmem0-lmem0:
- shard-dg2: NOTRUN -> [INCOMPLETE][14] ([i915#12392] / [i915#13356])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-dg2-1/igt@gem_ccs@[email protected]
* igt@gem_close_race@multigpu-basic-process:
- shard-dg2: NOTRUN -> [SKIP][15] ([i915#7697])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-dg2-6/igt@[email protected]
* igt@gem_eio@in-flight-suspend:
- shard-glk: NOTRUN -> [INCOMPLETE][16] ([i915#13390])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-glk5/igt@[email protected]
* igt@gem_eio@kms:
- shard-tglu: NOTRUN -> [DMESG-WARN][17] ([i915#13363])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-tglu-3/igt@[email protected]
* igt@gem_exec_balancer@bonded-dual:
- shard-dg2: NOTRUN -> [SKIP][18] ([i915#4771])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-dg2-3/igt@[email protected]
* igt@gem_exec_balancer@parallel-bb-first:
- shard-rkl: NOTRUN -> [SKIP][19] ([i915#4525])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-rkl-8/igt@[email protected]
* igt@gem_exec_balancer@parallel-dmabuf-import-out-fence:
- shard-rkl: NOTRUN -> [SKIP][20] ([i915#14544] / [i915#4525])
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-rkl-6/igt@[email protected]
- shard-tglu: NOTRUN -> [SKIP][21] ([i915#4525])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-tglu-4/igt@[email protected]
* igt@gem_exec_balancer@parallel-out-fence:
- shard-tglu-1: NOTRUN -> [SKIP][22] ([i915#4525])
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-tglu-1/igt@[email protected]
* igt@gem_exec_capture@capture-invisible:
- shard-dg2: NOTRUN -> [SKIP][23] ([i915#6334]) +2 other tests skip
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-dg2-3/igt@[email protected]
* igt@gem_exec_flush@basic-wb-pro-default:
- shard-rkl: [PASS][24] -> [DMESG-WARN][25] ([i915#12964]) +11 other tests dmesg-warn
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17515/shard-rkl-3/igt@[email protected]
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-rkl-6/igt@[email protected]
* igt@gem_exec_gttfill@basic:
- shard-rkl: [PASS][26] -> [DMESG-WARN][27] ([i915#12917] / [i915#12964]) +1 other test dmesg-warn
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17515/shard-rkl-6/igt@[email protected]
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-rkl-2/igt@[email protected]
* igt@gem_exec_reloc@basic-cpu-read:
- shard-rkl: NOTRUN -> [SKIP][28] ([i915#14544] / [i915#3281]) +1 other test skip
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-rkl-6/igt@[email protected]
* igt@gem_exec_reloc@basic-gtt-read-active:
- shard-mtlp: NOTRUN -> [SKIP][29] ([i915#3281])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-mtlp-6/igt@[email protected]
* igt@gem_exec_reloc@basic-write-gtt:
- shard-dg2: NOTRUN -> [SKIP][30] ([i915#3281]) +1 other test skip
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-dg2-3/igt@[email protected]
* igt@gem_lmem_evict@dontneed-evict-race:
- shard-tglu: NOTRUN -> [SKIP][31] ([i915#4613] / [i915#7582])
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-tglu-3/igt@[email protected]
* igt@gem_lmem_swapping@heavy-random:
- shard-glk: NOTRUN -> [SKIP][32] ([i915#4613]) +3 other tests skip
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-glk5/igt@[email protected]
* igt@gem_lmem_swapping@parallel-random-verify:
- shard-tglu: NOTRUN -> [SKIP][33] ([i915#4613])
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-tglu-3/igt@[email protected]
* igt@gem_lmem_swapping@verify-random:
- shard-rkl: NOTRUN -> [SKIP][34] ([i915#4613]) +1 other test skip
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-rkl-8/igt@[email protected]
* igt@gem_mmap_gtt@basic-small-bo:
- shard-dg2: NOTRUN -> [SKIP][35] ([i915#4077]) +9 other tests skip
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-dg2-3/igt@[email protected]
* igt@gem_mmap_wc@invalid-flags:
- shard-dg2: NOTRUN -> [SKIP][36] ([i915#4083]) +5 other tests skip
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-dg2-6/igt@[email protected]
* igt@gem_mmap_wc@set-cache-level:
- shard-rkl: [PASS][37] -> [SKIP][38] ([i915#14544] / [i915#1850])
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17515/shard-rkl-5/igt@[email protected]
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-rkl-6/igt@[email protected]
* igt@gem_pread@exhaustion:
- shard-glk: NOTRUN -> [WARN][39] ([i915#2658])
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-glk5/igt@[email protected]
* igt@gem_pread@snoop:
- shard-dg2: NOTRUN -> [SKIP][40] ([i915#3282]) +2 other tests skip
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-dg2-3/igt@[email protected]
* igt@gem_pread@uncached:
- shard-rkl: NOTRUN -> [SKIP][41] ([i915#3282])
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-rkl-8/igt@[email protected]
* igt@gem_pwrite@basic-exhaustion:
- shard-tglu: NOTRUN -> [WARN][42] ([i915#2658])
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-tglu-3/igt@[email protected]
* igt@gem_pxp@display-protected-crc:
- shard-rkl: [PASS][43] -> [TIMEOUT][44] ([i915#12917] / [i915#12964]) +2 other tests timeout
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17515/shard-rkl-8/igt@[email protected]
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-rkl-7/igt@[email protected]
* igt@gem_pxp@hw-rejects-pxp-context:
- shard-rkl: NOTRUN -> [SKIP][45] ([i915#13717])
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-rkl-8/igt@[email protected]
* igt@gem_pxp@reject-modify-context-protection-on:
- shard-dg2: NOTRUN -> [SKIP][46] ([i915#4270])
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-dg2-6/igt@[email protected]
* igt@gem_readwrite@beyond-eob:
- shard-rkl: NOTRUN -> [SKIP][47] ([i915#14544] / [i915#3282])
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-rkl-6/igt@[email protected]
* igt@gem_render_copy@yf-tiled-ccs-to-y-tiled:
- shard-dg2: NOTRUN -> [SKIP][48] ([i915#5190] / [i915#8428]) +1 other test skip
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-dg2-3/igt@[email protected]
* igt@gem_userptr_blits@unsync-unmap:
- shard-dg2: NOTRUN -> [SKIP][49] ([i915#3297])
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-dg2-3/igt@[email protected]
* igt@gem_userptr_blits@unsync-unmap-after-close:
- shard-tglu: NOTRUN -> [SKIP][50] ([i915#3297]) +1 other test skip
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-tglu-3/igt@[email protected]
* igt@gem_workarounds@suspend-resume:
- shard-rkl: [PASS][51] -> [ABORT][52] ([i915#15152])
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17515/shard-rkl-7/igt@[email protected]
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-rkl-4/igt@[email protected]
* igt@gen9_exec_parse@batch-invalid-length:
- shard-tglu-1: NOTRUN -> [SKIP][53] ([i915#2527] / [i915#2856])
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-tglu-1/igt@[email protected]
* igt@gen9_exec_parse@bb-oversize:
- shard-rkl: NOTRUN -> [SKIP][54] ([i915#2527])
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-rkl-8/igt@[email protected]
* igt@gen9_exec_parse@bb-secure:
- shard-tglu: NOTRUN -> [SKIP][55] ([i915#2527] / [i915#2856]) +1 other test skip
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-tglu-3/igt@[email protected]
* igt@gen9_exec_parse@bb-start-far:
- shard-dg2: NOTRUN -> [SKIP][56] ([i915#2856]) +2 other tests skip
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-dg2-3/igt@[email protected]
* igt@i915_module_load@resize-bar:
- shard-tglu-1: NOTRUN -> [SKIP][57] ([i915#6412])
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-tglu-1/igt@[email protected]
* igt@i915_pm_freq_mult@media-freq@gt0:
- shard-rkl: NOTRUN -> [SKIP][58] ([i915#6590]) +1 other test skip
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-rkl-8/igt@i915_pm_freq_mult@[email protected]
* igt@i915_pm_rc6_residency@rc6-fence:
- shard-tglu: [PASS][59] -> [WARN][60] ([i915#13790] / [i915#2681]) +1 other test warn
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17515/shard-tglu-6/igt@[email protected]
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-tglu-10/igt@[email protected]
* igt@i915_pm_rps@thresholds-idle-park:
- shard-dg2: NOTRUN -> [SKIP][61] ([i915#11681])
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-dg2-6/igt@[email protected]
* igt@i915_query@hwconfig_table:
- shard-tglu-1: NOTRUN -> [SKIP][62] ([i915#6245])
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-tglu-1/igt@i915_query@hwconfig_table.html
* igt@i915_query@test-query-geometry-subslices:
- shard-tglu: NOTRUN -> [SKIP][63] ([i915#5723])
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-tglu-3/igt@[email protected]
* igt@i915_selftest@live@workarounds:
- shard-mtlp: [PASS][64] -> [DMESG-FAIL][65] ([i915#12061]) +1 other test dmesg-fail
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17515/shard-mtlp-7/igt@i915_selftest@[email protected]
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-mtlp-5/igt@i915_selftest@[email protected]
* igt@i915_suspend@fence-restore-untiled:
- shard-rkl: [PASS][66] -> [INCOMPLETE][67] ([i915#4817])
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17515/shard-rkl-8/igt@[email protected]
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-rkl-3/igt@[email protected]
* igt@kms_addfb_basic@addfb25-y-tiled-small-legacy:
- shard-dg2: NOTRUN -> [SKIP][68] ([i915#5190]) +2 other tests skip
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-dg2-6/igt@[email protected]
* igt@kms_addfb_basic@basic-y-tiled-legacy:
- shard-dg2: NOTRUN -> [SKIP][69] ([i915#4215] / [i915#5190])
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-dg2-3/igt@[email protected]
* igt@kms_atomic_transition@plane-all-modeset-transition-fencing-internal-panels:
- shard-dg2: NOTRUN -> [SKIP][70] ([i915#1769] / [i915#3555])
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-dg2-3/igt@kms_atomic_transition@plane-all-modeset-transition-fencing-internal-panels.html
* igt@kms_atomic_transition@plane-all-modeset-transition-internal-panels:
- shard-glk10: NOTRUN -> [SKIP][71] ([i915#1769])
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-glk10/igt@kms_atomic_transition@plane-all-modeset-transition-internal-panels.html
* igt@kms_big_fb@4-tiled-64bpp-rotate-0:
- shard-rkl: NOTRUN -> [SKIP][72] ([i915#5286]) +1 other test skip
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-rkl-8/igt@[email protected]
* igt@kms_big_fb@4-tiled-64bpp-rotate-270:
- shard-tglu-1: NOTRUN -> [SKIP][73] ([i915#5286]) +1 other test skip
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-tglu-1/igt@[email protected]
* igt@kms_big_fb@4-tiled-64bpp-rotate-90:
- shard-tglu: NOTRUN -> [SKIP][74] ([i915#5286]) +2 other tests skip
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-tglu-4/igt@[email protected]
* igt@kms_big_fb@4-tiled-max-hw-stride-64bpp-rotate-0-hflip:
- shard-mtlp: [PASS][75] -> [FAIL][76] ([i915#5138])
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17515/shard-mtlp-2/igt@[email protected]
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-mtlp-6/igt@[email protected]
* igt@kms_big_fb@linear-32bpp-rotate-0:
- shard-rkl: NOTRUN -> [SKIP][77] ([i915#14544]) +34 other tests skip
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-rkl-6/igt@[email protected]
* igt@kms_big_fb@y-tiled-8bpp-rotate-270:
- shard-rkl: NOTRUN -> [SKIP][78] ([i915#3638]) +1 other test skip
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-rkl-8/igt@[email protected]
* igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-180:
- shard-dg2: NOTRUN -> [SKIP][79] ([i915#4538] / [i915#5190]) +5 other tests skip
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-dg2-3/igt@[email protected]
* igt@kms_ccs@bad-aux-stride-4-tiled-mtl-rc-ccs-cc@pipe-d-hdmi-a-1:
- shard-dg2: NOTRUN -> [SKIP][80] ([i915#10307] / [i915#10434] / [i915#6095]) +1 other test skip
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-dg2-4/igt@kms_ccs@[email protected]
* igt@kms_ccs@bad-rotation-90-4-tiled-dg2-rc-ccs-cc@pipe-b-hdmi-a-1:
- shard-tglu-1: NOTRUN -> [SKIP][81] ([i915#6095]) +29 other tests skip
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-tglu-1/igt@kms_ccs@[email protected]
* igt@kms_ccs@bad-rotation-90-4-tiled-mtl-rc-ccs-cc@pipe-b-hdmi-a-4:
- shard-dg1: NOTRUN -> [SKIP][82] ([i915#6095]) +126 other tests skip
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-dg1-19/igt@kms_ccs@[email protected]
* igt@kms_ccs@ccs-on-another-bo-yf-tiled-ccs@pipe-a-hdmi-a-3:
- shard-dg2: NOTRUN -> [SKIP][83] ([i915#10307] / [i915#6095]) +104 other tests skip
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-dg2-6/igt@kms_ccs@[email protected]
* igt@kms_ccs@crc-primary-basic-4-tiled-mtl-rc-ccs@pipe-a-hdmi-a-3:
- shard-dg1: NOTRUN -> [SKIP][84] ([i915#4423] / [i915#6095])
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-dg1-13/igt@kms_ccs@[email protected]
* igt@kms_ccs@crc-primary-basic-yf-tiled-ccs@pipe-c-hdmi-a-1:
- shard-tglu: NOTRUN -> [SKIP][85] ([i915#6095]) +29 other tests skip
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-tglu-3/igt@kms_ccs@[email protected]
* igt@kms_ccs@crc-primary-suspend-4-tiled-bmg-ccs:
- shard-tglu-1: NOTRUN -> [SKIP][86] ([i915#12805])
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-tglu-1/igt@[email protected]
* igt@kms_ccs@crc-primary-suspend-4-tiled-dg2-rc-ccs-cc:
- shard-mtlp: NOTRUN -> [SKIP][87] ([i915#6095]) +14 other tests skip
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-mtlp-6/igt@[email protected]
* igt@kms_ccs@crc-primary-suspend-y-tiled-ccs@pipe-a-hdmi-a-2:
- shard-glk: NOTRUN -> [INCOMPLETE][88] ([i915#12796]) +1 other test incomplete
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-glk6/igt@kms_ccs@[email protected]
* igt@kms_ccs@crc-primary-suspend-y-tiled-gen12-rc-ccs@pipe-d-hdmi-a-3:
- shard-dg2: NOTRUN -> [SKIP][89] ([i915#6095]) +8 other tests skip
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-dg2-3/igt@kms_ccs@[email protected]
* igt@kms_ccs@crc-sprite-planes-basic-4-tiled-bmg-ccs:
- shard-tglu: NOTRUN -> [SKIP][90] ([i915#12313])
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-tglu-4/igt@[email protected]
* igt@kms_ccs@crc-sprite-planes-basic-4-tiled-dg2-rc-ccs@pipe-b-hdmi-a-2:
- shard-rkl: NOTRUN -> [SKIP][91] ([i915#14098] / [i915#6095]) +41 other tests skip
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-rkl-5/igt@kms_ccs@[email protected]
* igt@kms_ccs@random-ccs-data-4-tiled-mtl-rc-ccs@pipe-b-hdmi-a-2:
- shard-rkl: NOTRUN -> [SKIP][92] ([i915#6095]) +49 other tests skip
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-rkl-8/igt@kms_ccs@[email protected]
* igt@kms_ccs@random-ccs-data-y-tiled-gen12-mc-ccs@pipe-c-hdmi-a-1:
- shard-glk10: NOTRUN -> [SKIP][93] +56 other tests skip
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-glk10/igt@kms_ccs@[email protected]
* igt@kms_cdclk@mode-transition@pipe-d-hdmi-a-3:
- shard-dg2: NOTRUN -> [SKIP][94] ([i915#13781]) +3 other tests skip
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-dg2-7/igt@kms_cdclk@[email protected]
* igt@kms_cdclk@plane-scaling:
- shard-tglu: NOTRUN -> [SKIP][95] ([i915#3742])
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-tglu-3/igt@[email protected]
* igt@kms_cdclk@plane-scaling@pipe-b-hdmi-a-3:
- shard-dg2: NOTRUN -> [SKIP][96] ([i915#13783]) +3 other tests skip
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-dg2-1/igt@kms_cdclk@[email protected]
* igt@kms_chamelium_audio@dp-audio-edid:
- shard-rkl: NOTRUN -> [SKIP][97] ([i915#11151] / [i915#14544] / [i915#7828]) +1 other test skip
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-rkl-6/igt@[email protected]
* igt@kms_chamelium_edid@dp-edid-stress-resolution-non-4k:
- shard-rkl: NOTRUN -> [SKIP][98] ([i915#11151] / [i915#7828])
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-rkl-8/igt@[email protected]
* igt@kms_chamelium_frames@dp-crc-fast:
- shard-dg2: NOTRUN -> [SKIP][99] ([i915#11151] / [i915#7828]) +7 other tests skip
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-dg2-3/igt@[email protected]
* igt@kms_chamelium_frames@dp-crc-single:
- shard-tglu: NOTRUN -> [SKIP][100] ([i915#11151] / [i915#7828]) +3 other tests skip
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-tglu-3/igt@[email protected]
* igt@kms_chamelium_hpd@dp-hpd-storm-disable:
- shard-tglu-1: NOTRUN -> [SKIP][101] ([i915#11151] / [i915#7828]) +2 other tests skip
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-tglu-1/igt@[email protected]
* igt@kms_color@ctm-0-75:
- shard-rkl: NOTRUN -> [SKIP][102] ([i915#12655] / [i915#14544])
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-rkl-6/igt@[email protected]
* igt@kms_color@deep-color:
- shard-dg2: NOTRUN -> [SKIP][103] ([i915#12655] / [i915#3555])
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-dg2-3/igt@[email protected]
* igt@kms_content_protection@atomic:
- shard-tglu: NOTRUN -> [SKIP][104] ([i915#6944] / [i915#7116] / [i915#7118] / [i915#9424])
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-tglu-4/igt@[email protected]
* igt@kms_content_protection@atomic-dpms@pipe-a-dp-3:
- shard-dg2: NOTRUN -> [FAIL][105] ([i915#7173]) +1 other test fail
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-dg2-10/igt@kms_content_protection@[email protected]
* igt@kms_content_protection@content-type-change:
- shard-dg2: NOTRUN -> [SKIP][106] ([i915#9424])
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-dg2-6/igt@[email protected]
* igt@kms_content_protection@dp-mst-lic-type-0:
- shard-tglu-1: NOTRUN -> [SKIP][107] ([i915#3116] / [i915#3299])
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-tglu-1/igt@[email protected]
* igt@kms_content_protection@legacy:
- shard-tglu-1: NOTRUN -> [SKIP][108] ([i915#6944] / [i915#7116] / [i915#7118] / [i915#9424])
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-tglu-1/igt@[email protected]
* igt@kms_cursor_crc@cursor-offscreen-256x85:
- shard-rkl: [PASS][109] -> [SKIP][110] ([i915#14544]) +46 other tests skip
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17515/shard-rkl-5/igt@[email protected]
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-rkl-6/igt@[email protected]
* igt@kms_cursor_crc@cursor-onscreen-512x512:
- shard-tglu: NOTRUN -> [SKIP][111] ([i915#13049])
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-tglu-4/igt@[email protected]
* igt@kms_cursor_crc@cursor-random-256x85@pipe-a-hdmi-a-1:
- shard-rkl: NOTRUN -> [FAIL][112] ([i915#13566])
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-rkl-2/igt@kms_cursor_crc@[email protected]
* igt@kms_cursor_crc@cursor-random-512x170:
- shard-tglu-1: NOTRUN -> [SKIP][113] ([i915#13049]) +1 other test skip
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-tglu-1/igt@[email protected]
* igt@kms_cursor_crc@cursor-random-512x512:
- shard-rkl: NOTRUN -> [SKIP][114] ([i915#13049])
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-rkl-8/igt@[email protected]
* igt@kms_cursor_crc@cursor-sliding-256x85:
- shard-tglu: [PASS][115] -> [FAIL][116] ([i915#13566]) +1 other test fail
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17515/shard-tglu-10/igt@[email protected]
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-tglu-7/igt@[email protected]
* igt@kms_cursor_crc@cursor-sliding-32x10:
- shard-dg2: NOTRUN -> [SKIP][117] ([i915#3555]) +2 other tests skip
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-dg2-3/igt@[email protected]
* igt@kms_cursor_crc@cursor-sliding-max-size:
- shard-mtlp: NOTRUN -> [SKIP][118] ([i915#3555] / [i915#8814])
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-mtlp-6/igt@[email protected]
* igt@kms_cursor_crc@cursor-suspend:
- shard-glk10: NOTRUN -> [INCOMPLETE][119] ([i915#12358] / [i915#14152] / [i915#7882])
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-glk10/igt@[email protected]
* igt@kms_cursor_crc@cursor-suspend@pipe-a-hdmi-a-1:
- shard-glk10: NOTRUN -> [INCOMPLETE][120] ([i915#12358] / [i915#14152])
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-glk10/igt@kms_cursor_crc@[email protected]
* igt@kms_cursor_legacy@2x-flip-vs-cursor-atomic:
- shard-rkl: NOTRUN -> [SKIP][121] +2 other tests skip
[121]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-rkl-8/igt@[email protected]
* igt@kms_cursor_legacy@basic-flip-after-cursor-legacy:
- shard-rkl: [PASS][122] -> [SKIP][123] ([i915#11190] / [i915#14544])
[122]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17515/shard-rkl-5/igt@[email protected]
[123]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-rkl-6/igt@[email protected]
* igt@kms_cursor_legacy@cursorb-vs-flipb-legacy:
- shard-dg2: NOTRUN -> [SKIP][124] ([i915#13046] / [i915#5354]) +3 other tests skip
[124]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-dg2-3/igt@[email protected]
* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions:
- shard-glk: NOTRUN -> [FAIL][125] ([i915#2346])
[125]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-glk6/igt@[email protected]
* igt@kms_cursor_legacy@modeset-atomic-cursor-hotspot:
- shard-tglu: NOTRUN -> [SKIP][126] ([i915#9067])
[126]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-tglu-4/igt@[email protected]
* igt@kms_cursor_legacy@short-busy-flip-before-cursor-atomic-transitions-varying-size:
- shard-tglu-1: NOTRUN -> [SKIP][127] ([i915#4103])
[127]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-tglu-1/igt@kms_cursor_legacy@short-busy-flip-before-cursor-atomic-transitions-varying-size.html
* igt@kms_cursor_legacy@short-busy-flip-before-cursor-toggle:
- shard-rkl: NOTRUN -> [SKIP][128] ([i915#4103])
[128]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-rkl-8/igt@[email protected]
* igt@kms_dirtyfb@drrs-dirtyfb-ioctl:
- shard-dg2: NOTRUN -> [SKIP][129] ([i915#9833])
[129]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-dg2-3/igt@[email protected]
* igt@kms_dp_link_training@non-uhbr-mst:
- shard-tglu-1: NOTRUN -> [SKIP][130] ([i915#13749])
[130]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-tglu-1/igt@[email protected]
* igt@kms_dp_link_training@uhbr-mst:
- shard-tglu: NOTRUN -> [SKIP][131] ([i915#13748])
[131]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-tglu-4/igt@[email protected]
* igt@kms_dp_link_training@uhbr-sst:
- shard-tglu-1: NOTRUN -> [SKIP][132] ([i915#13748])
[132]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-tglu-1/igt@[email protected]
* igt@kms_dp_linktrain_fallback@dp-fallback:
- shard-tglu-1: NOTRUN -> [SKIP][133] ([i915#13707])
[133]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-tglu-1/igt@[email protected]
* igt@kms_dsc@dsc-fractional-bpp:
- shard-tglu: NOTRUN -> [SKIP][134] ([i915#3840])
[134]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-tglu-3/igt@[email protected]
* igt@kms_dsc@dsc-with-bpc:
- shard-dg2: NOTRUN -> [SKIP][135] ([i915#3555] / [i915#3840])
[135]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-dg2-3/igt@[email protected]
* igt@kms_dsc@dsc-with-bpc-formats:
- shard-rkl: NOTRUN -> [SKIP][136] ([i915#3555] / [i915#3840])
[136]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-rkl-8/igt@[email protected]
* igt@kms_feature_discovery@display-4x:
- shard-dg2: NOTRUN -> [SKIP][137] ([i915#1839])
[137]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-dg2-3/igt@[email protected]
* igt@kms_flip@2x-dpms-vs-vblank-race:
- shard-rkl: NOTRUN -> [SKIP][138] ([i915#9934]) +1 other test skip
[138]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-rkl-8/igt@[email protected]
* igt@kms_flip@2x-flip-vs-dpms-on-nop:
- shard-tglu: NOTRUN -> [SKIP][139] ([i915#9934])
[139]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-tglu-3/igt@[email protected]
* igt@kms_flip@2x-flip-vs-fences:
- shard-mtlp: NOTRUN -> [SKIP][140] ([i915#8381])
[140]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-mtlp-6/igt@[email protected]
* igt@kms_flip@2x-flip-vs-fences-interruptible:
- shard-tglu-1: NOTRUN -> [SKIP][141] ([i915#3637] / [i915#9934]) +2 other tests skip
[141]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-tglu-1/igt@[email protected]
* igt@kms_flip@2x-flip-vs-suspend-interruptible:
- shard-snb: [PASS][142] -> [TIMEOUT][143] ([i915#14033] / [i915#14350])
[142]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17515/shard-snb7/igt@[email protected]
[143]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-snb5/igt@[email protected]
* igt@kms_flip@2x-flip-vs-suspend-interruptible@ab-vga1-hdmi-a1:
- shard-snb: [PASS][144] -> [TIMEOUT][145] ([i915#14033])
[144]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17515/shard-snb7/igt@kms_flip@[email protected]
[145]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-snb5/igt@kms_flip@[email protected]
* igt@kms_flip@2x-plain-flip:
- shard-dg2: NOTRUN -> [SKIP][146] ([i915#9934]) +4 other tests skip
[146]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-dg2-6/igt@[email protected]
* igt@kms_flip@2x-plain-flip-fb-recreate:
- shard-tglu: NOTRUN -> [SKIP][147] ([i915#3637] / [i915#9934]) +3 other tests skip
[147]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-tglu-4/igt@[email protected]
* igt@kms_flip@2x-single-buffer-flip-vs-dpms-off-vs-modeset:
- shard-rkl: NOTRUN -> [SKIP][148] ([i915#14544] / [i915#9934]) +2 other tests skip
[148]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-rkl-6/igt@[email protected]
* igt@kms_flip@flip-vs-blocking-wf-vblank:
- shard-rkl: NOTRUN -> [SKIP][149] ([i915#14544] / [i915#3637]) +2 other tests skip
[149]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-rkl-6/igt@[email protected]
* igt@kms_flip@flip-vs-panning-interruptible@b-hdmi-a2:
- shard-rkl: NOTRUN -> [DMESG-WARN][150] ([i915#12964]) +3 other tests dmesg-warn
[150]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-rkl-5/igt@kms_flip@[email protected]
* igt@kms_flip@flip-vs-suspend:
- shard-rkl: [PASS][151] -> [SKIP][152] ([i915#14544] / [i915#3637]) +3 other tests skip
[151]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17515/shard-rkl-3/igt@[email protected]
[152]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-rkl-6/igt@[email protected]
* igt@kms_flip@flip-vs-suspend-interruptible:
- shard-glk: NOTRUN -> [INCOMPLETE][153] ([i915#12745] / [i915#4839])
[153]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-glk9/igt@[email protected]
* igt@kms_flip@flip-vs-suspend-interruptible@a-hdmi-a1:
- shard-glk: NOTRUN -> [INCOMPLETE][154] ([i915#12745])
[154]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-glk9/igt@kms_flip@[email protected]
* igt@kms_flip_scaled_crc@flip-32bpp-4tile-to-32bpp-4tiledg2rcccs-upscaling:
- shard-tglu-1: NOTRUN -> [SKIP][155] ([i915#2672] / [i915#3555]) +1 other test skip
[155]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-tglu-1/igt@kms_flip_scaled_crc@flip-32bpp-4tile-to-32bpp-4tiledg2rcccs-upscaling.html
* igt@kms_flip_scaled_crc@flip-32bpp-4tile-to-64bpp-4tile-downscaling:
- shard-tglu: NOTRUN -> [SKIP][156] ([i915#2672] / [i915#3555])
[156]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-tglu-4/igt@kms_flip_scaled_crc@flip-32bpp-4tile-to-64bpp-4tile-downscaling.html
* igt@kms_flip_scaled_crc@flip-32bpp-4tile-to-64bpp-4tile-downscaling@pipe-a-valid-mode:
- shard-tglu: NOTRUN -> [SKIP][157] ([i915#2587] / [i915#2672])
[157]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-tglu-4/igt@kms_flip_scaled_crc@flip-32bpp-4tile-to-64bpp-4tile-downscaling@pipe-a-valid-mode.html
* igt@kms_flip_scaled_crc@flip-32bpp-4tile-to-64bpp-4tile-upscaling@pipe-a-valid-mode:
- shard-tglu-1: NOTRUN -> [SKIP][158] ([i915#2587] / [i915#2672]) +2 other tests skip
[158]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-tglu-1/igt@kms_flip_scaled_crc@[email protected]
* igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytileccs-downscaling:
- shard-tglu-1: NOTRUN -> [SKIP][159] ([i915#2587] / [i915#2672] / [i915#3555])
[159]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-tglu-1/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytileccs-downscaling.html
* igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytileccs-upscaling@pipe-a-valid-mode:
- shard-rkl: NOTRUN -> [SKIP][160] ([i915#2672]) +4 other tests skip
[160]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-rkl-2/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytileccs-upscaling@pipe-a-valid-mode.html
* igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytilegen12rcccs-downscaling:
- shard-dg2: NOTRUN -> [SKIP][161] ([i915#2672] / [i915#3555] / [i915#5190]) +2 other tests skip
[161]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-dg2-3/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytilegen12rcccs-downscaling.html
* igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytilegen12rcccs-downscaling@pipe-a-valid-mode:
- shard-dg2: NOTRUN -> [SKIP][162] ([i915#2672]) +3 other tests skip
[162]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-dg2-3/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytilegen12rcccs-downscaling@pipe-a-valid-mode.html
* igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-64bpp-ytile-downscaling:
- shard-rkl: [PASS][163] -> [SKIP][164] ([i915#14544] / [i915#3555]) +1 other test skip
[163]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17515/shard-rkl-5/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-64bpp-ytile-downscaling.html
[164]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-rkl-6/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-64bpp-ytile-downscaling.html
* igt@kms_flip_scaled_crc@flip-64bpp-linear-to-32bpp-linear-downscaling:
- shard-rkl: NOTRUN -> [SKIP][165] ([i915#14544] / [i915#3555])
[165]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-rkl-6/igt@kms_flip_scaled_crc@flip-64bpp-linear-to-32bpp-linear-downscaling.html
* igt@kms_flip_scaled_crc@flip-64bpp-yftile-to-32bpp-yftile-upscaling:
- shard-dg2: NOTRUN -> [SKIP][166] ([i915#2672] / [i915#3555])
[166]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-dg2-6/igt@kms_flip_scaled_crc@flip-64bpp-yftile-to-32bpp-yftile-upscaling.html
* igt@kms_frontbuffer_tracking@fbc-1p-offscreen-pri-indfb-draw-render:
- shard-dg1: [PASS][167] -> [DMESG-WARN][168] ([i915#4423]) +8 other tests dmesg-warn
[167]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17515/shard-dg1-18/igt@kms_frontbuffer_tracking@fbc-1p-offscreen-pri-indfb-draw-render.html
[168]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-dg1-13/igt@kms_frontbuffer_tracking@fbc-1p-offscreen-pri-indfb-draw-render.html
* igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-shrfb-msflip-blt:
- shard-rkl: NOTRUN -> [SKIP][169] ([i915#14544] / [i915#1849] / [i915#5354]) +15 other tests skip
[169]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-rkl-6/igt@[email protected]
* igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-shrfb-pgflip-blt:
- shard-mtlp: NOTRUN -> [SKIP][170] ([i915#1825])
[170]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-mtlp-6/igt@[email protected]
* igt@kms_frontbuffer_tracking@fbc-modesetfrombusy:
- shard-rkl: [PASS][171] -> [SKIP][172] ([i915#14544] / [i915#1849] / [i915#5354]) +7 other tests skip
[171]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17515/shard-rkl-5/igt@[email protected]
[172]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-rkl-6/igt@[email protected]
* igt@kms_frontbuffer_tracking@fbc-rgb101010-draw-mmap-gtt:
- shard-mtlp: NOTRUN -> [SKIP][173] ([i915#8708])
[173]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-mtlp-6/igt@[email protected]
* igt@kms_frontbuffer_tracking@fbcpsr-1p-offscreen-pri-shrfb-draw-mmap-gtt:
- shard-dg2: NOTRUN -> [SKIP][174] ([i915#15104])
[174]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-dg2-3/igt@kms_frontbuffer_tracking@fbcpsr-1p-offscreen-pri-shrfb-draw-mmap-gtt.html
* igt@kms_frontbuffer_tracking@fbcpsr-1p-shrfb-fliptrack-mmap-gtt:
- shard-rkl: NOTRUN -> [SKIP][175] ([i915#15102] / [i915#3023]) +2 other tests skip
[175]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-rkl-8/igt@[email protected]
* igt@kms_frontbuffer_tracking@fbcpsr-2p-indfb-fliptrack-mmap-gtt:
- shard-tglu-1: NOTRUN -> [SKIP][176] +30 other tests skip
[176]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-tglu-1/igt@[email protected]
* igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-pri-shrfb-draw-render:
- shard-dg2: NOTRUN -> [SKIP][177] ([i915#5354]) +16 other tests skip
[177]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-dg2-3/igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-pri-shrfb-draw-render.html
* igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-spr-indfb-draw-render:
- shard-tglu: NOTRUN -> [SKIP][178] +28 other tests skip
[178]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-tglu-3/igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-spr-indfb-draw-render.html
* igt@kms_frontbuffer_tracking@fbcpsr-2p-shrfb-fliptrack-mmap-gtt:
- shard-dg2: NOTRUN -> [SKIP][179] ([i915#8708]) +1 other test skip
[179]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-dg2-6/igt@[email protected]
* igt@kms_frontbuffer_tracking@pipe-fbc-rte:
- shard-tglu-1: NOTRUN -> [SKIP][180] ([i915#9766])
[180]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-tglu-1/igt@[email protected]
* igt@kms_frontbuffer_tracking@psr-1p-offscreen-pri-indfb-draw-mmap-wc:
- shard-tglu-1: NOTRUN -> [SKIP][181] ([i915#15102]) +11 other tests skip
[181]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-tglu-1/igt@kms_frontbuffer_tracking@psr-1p-offscreen-pri-indfb-draw-mmap-wc.html
* igt@kms_frontbuffer_tracking@psr-1p-offscreen-pri-indfb-draw-pwrite:
- shard-dg2: NOTRUN -> [SKIP][182] ([i915#15102]) +1 other test skip
[182]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-dg2-6/igt@kms_frontbuffer_tracking@psr-1p-offscreen-pri-indfb-draw-pwrite.html
* igt@kms_frontbuffer_tracking@psr-1p-offscreen-pri-shrfb-draw-mmap-cpu:
- shard-rkl: NOTRUN -> [SKIP][183] ([i915#15102])
[183]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-rkl-8/igt@kms_frontbuffer_tracking@psr-1p-offscreen-pri-shrfb-draw-mmap-cpu.html
* igt@kms_frontbuffer_tracking@psr-2p-primscrn-cur-indfb-draw-mmap-gtt:
- shard-rkl: NOTRUN -> [SKIP][184] ([i915#1825]) +9 other tests skip
[184]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-rkl-8/igt@kms_frontbuffer_tracking@psr-2p-primscrn-cur-indfb-draw-mmap-gtt.html
* igt@kms_frontbuffer_tracking@psr-2p-primscrn-indfb-msflip-blt:
- shard-snb: NOTRUN -> [SKIP][185] +63 other tests skip
[185]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-snb6/igt@[email protected]
* igt@kms_frontbuffer_tracking@psr-rgb101010-draw-render:
- shard-dg2: NOTRUN -> [SKIP][186] ([i915#15102] / [i915#3458]) +10 other tests skip
[186]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-dg2-3/igt@[email protected]
* igt@kms_frontbuffer_tracking@psr-shrfb-scaledprimary:
- shard-tglu: NOTRUN -> [SKIP][187] ([i915#15102]) +9 other tests skip
[187]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-tglu-3/igt@[email protected]
* igt@kms_hdr@bpc-switch-suspend:
- shard-tglu: NOTRUN -> [SKIP][188] ([i915#3555] / [i915#8228])
[188]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-tglu-4/igt@[email protected]
* igt@kms_hdr@invalid-metadata-sizes:
- shard-rkl: NOTRUN -> [SKIP][189] ([i915#3555] / [i915#8228])
[189]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-rkl-8/igt@[email protected]
* igt@kms_invalid_mode@bad-hsync-end:
- shard-rkl: NOTRUN -> [SKIP][190] ([i915#14544] / [i915#3555] / [i915#8826])
[190]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-rkl-6/igt@[email protected]
* igt@kms_joiner@basic-big-joiner:
- shard-tglu-1: NOTRUN -> [SKIP][191] ([i915#10656])
[191]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-tglu-1/igt@[email protected]
* igt@kms_joiner@basic-force-big-joiner:
- shard-tglu-1: NOTRUN -> [SKIP][192] ([i915#12388])
[192]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-tglu-1/igt@[email protected]
* igt@kms_joiner@basic-force-ultra-joiner:
- shard-dg2: NOTRUN -> [SKIP][193] ([i915#10656])
[193]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-dg2-3/igt@[email protected]
* igt@kms_multipipe_modeset@basic-max-pipe-crc-check:
- shard-tglu-1: NOTRUN -> [SKIP][194] ([i915#1839])
[194]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-tglu-1/igt@[email protected]
* igt@kms_pipe_b_c_ivb@disable-pipe-b-enable-pipe-c:
- shard-dg2: NOTRUN -> [SKIP][195] +8 other tests skip
[195]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-dg2-3/igt@[email protected]
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-xr24:
- shard-rkl: NOTRUN -> [SKIP][196] ([i915#11190] / [i915#14544])
[196]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-rkl-6/igt@[email protected]
* igt@kms_plane@plane-panning-top-left:
- shard-rkl: [PASS][197] -> [SKIP][198] ([i915#14544] / [i915#8825])
[197]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17515/shard-rkl-5/igt@[email protected]
[198]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-rkl-6/igt@[email protected]
* igt@kms_plane_alpha_blend@alpha-7efc:
- shard-rkl: [PASS][199] -> [SKIP][200] ([i915#14544] / [i915#7294])
[199]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17515/shard-rkl-5/igt@[email protected]
[200]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-rkl-6/igt@[email protected]
* igt@kms_plane_alpha_blend@coverage-vs-premult-vs-constant:
- shard-rkl: NOTRUN -> [SKIP][201] ([i915#14544] / [i915#7294])
[201]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-rkl-6/igt@[email protected]
* igt@kms_plane_multiple@2x-tiling-y:
- shard-tglu-1: NOTRUN -> [SKIP][202] ([i915#13958])
[202]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-tglu-1/igt@[email protected]
* igt@kms_plane_multiple@2x-tiling-yf:
- shard-dg2: NOTRUN -> [SKIP][203] ([i915#13958])
[203]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-dg2-3/igt@[email protected]
* igt@kms_plane_multiple@tiling-4:
- shard-tglu-1: NOTRUN -> [SKIP][204] ([i915#14259])
[204]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-tglu-1/igt@[email protected]
* igt@kms_plane_scaling@intel-max-src-size:
- shard-dg2: NOTRUN -> [SKIP][205] ([i915#6953] / [i915#9423])
[205]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-dg2-6/igt@[email protected]
* igt@kms_plane_scaling@plane-downscale-factor-0-75-with-modifiers@pipe-a:
- shard-rkl: [PASS][206] -> [SKIP][207] ([i915#12247] / [i915#14544]) +3 other tests skip
[206]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17515/shard-rkl-5/igt@kms_plane_scaling@[email protected]
[207]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-rkl-6/igt@kms_plane_scaling@[email protected]
* igt@kms_plane_scaling@plane-downscale-factor-0-75-with-pixel-format:
- shard-rkl: NOTRUN -> [SKIP][208] ([i915#14544] / [i915#8152])
[208]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-rkl-6/igt@kms_plane_scaling@plane-downscale-factor-0-75-with-pixel-format.html
* igt@kms_plane_scaling@plane-downscale-factor-0-75-with-pixel-format@pipe-a:
- shard-rkl: NOTRUN -> [SKIP][209] ([i915#12247] / [i915#14544]) +1 other test skip
[209]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-rkl-6/igt@kms_plane_scaling@[email protected]
* igt@kms_plane_scaling@plane-scaler-unity-scaling-with-modifiers:
- shard-rkl: [PASS][210] -> [SKIP][211] ([i915#14544] / [i915#8152]) +1 other test skip
[210]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17515/shard-rkl-3/igt@[email protected]
[211]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-rkl-6/igt@[email protected]
* igt@kms_plane_scaling@plane-upscale-factor-0-25-with-rotation@pipe-b:
- shard-rkl: NOTRUN -> [SKIP][212] ([i915#12247] / [i915#14544] / [i915#8152]) +2 other tests skip
[212]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-rkl-6/igt@kms_plane_scaling@[email protected]
* igt@kms_plane_scaling@plane-upscale-factor-0-25-with-rotation@pipe-d:
- shard-tglu: NOTRUN -> [SKIP][213] ([i915#12247]) +4 other tests skip
[213]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-tglu-4/igt@kms_plane_scaling@[email protected]
* igt@kms_plane_scaling@planes-upscale-20x20:
- shard-rkl: [PASS][214] -> [SKIP][215] ([i915#14544] / [i915#6953] / [i915#8152])
[214]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17515/shard-rkl-3/igt@[email protected]
[215]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-rkl-6/igt@[email protected]
* igt@kms_plane_scaling@planes-upscale-20x20@pipe-b:
- shard-rkl: [PASS][216] -> [SKIP][217] ([i915#12247] / [i915#14544] / [i915#8152]) +4 other tests skip
[216]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17515/shard-rkl-3/igt@kms_plane_scaling@[email protected]
[217]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-rkl-6/igt@kms_plane_scaling@[email protected]
* igt@kms_pm_backlight@fade-with-dpms:
- shard-tglu-1: NOTRUN -> [SKIP][218] ([i915#9812])
[218]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-tglu-1/igt@[email protected]
* igt@kms_pm_backlight@fade-with-suspend:
- shard-tglu: NOTRUN -> [SKIP][219] ([i915#9812])
[219]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-tglu-3/igt@[email protected]
* igt@kms_pm_dc@dc5-retention-flops:
- shard-dg2: NOTRUN -> [SKIP][220] ([i915#3828])
[220]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-dg2-3/igt@[email protected]
* igt@kms_pm_lpsp@kms-lpsp:
- shard-tglu-1: NOTRUN -> [SKIP][221] ([i915#3828])
[221]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-tglu-1/igt@[email protected]
* igt@kms_pm_lpsp@screens-disabled:
- shard-dg2: NOTRUN -> [SKIP][222] ([i915#8430])
[222]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-dg2-3/igt@[email protected]
* igt@kms_pm_rpm@modeset-lpsp-stress:
- shard-rkl: NOTRUN -> [SKIP][223] ([i915#14544] / [i915#15073])
[223]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-rkl-6/igt@[email protected]
* igt@kms_pm_rpm@modeset-non-lpsp:
- shard-rkl: [PASS][224] -> [SKIP][225] ([i915#15073]) +1 other test skip
[224]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17515/shard-rkl-8/igt@[email protected]
[225]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-rkl-7/igt@[email protected]
* igt@kms_pm_rpm@modeset-non-lpsp-stress:
- shard-tglu: NOTRUN -> [SKIP][226] ([i915#15073]) +1 other test skip
[226]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-tglu-3/igt@[email protected]
* igt@kms_prime@basic-crc-vgem:
- shard-rkl: NOTRUN -> [SKIP][227] ([i915#14544] / [i915#6524])
[227]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-rkl-6/igt@[email protected]
* igt@kms_properties@plane-properties-legacy:
- shard-rkl: NOTRUN -> [SKIP][228] ([i915#11521] / [i915#14544])
[228]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-rkl-6/igt@[email protected]
* igt@kms_psr2_sf@fbc-pr-cursor-plane-update-sf:
- shard-glk: NOTRUN -> [SKIP][229] ([i915#11520]) +9 other tests skip
[229]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-glk6/igt@[email protected]
* igt@kms_psr2_sf@fbc-pr-overlay-plane-update-continuous-sf:
- shard-snb: NOTRUN -> [SKIP][230] ([i915#11520]) +1 other test skip
[230]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-snb6/igt@[email protected]
* igt@kms_psr2_sf@fbc-psr2-cursor-plane-move-continuous-sf:
- shard-rkl: NOTRUN -> [SKIP][231] ([i915#11520] / [i915#14544])
[231]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-rkl-6/igt@[email protected]
* igt@kms_psr2_sf@fbc-psr2-overlay-plane-move-continuous-sf:
- shard-glk10: NOTRUN -> [SKIP][232] ([i915#11520]) +1 other test skip
[232]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-glk10/igt@[email protected]
* igt@kms_psr2_sf@pr-overlay-plane-update-sf-dmg-area:
- shard-rkl: NOTRUN -> [SKIP][233] ([i915#11520]) +2 other tests skip
[233]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-rkl-8/igt@[email protected]
* igt@kms_psr2_sf@pr-primary-plane-update-sf-dmg-area:
- shard-tglu-1: NOTRUN -> [SKIP][234] ([i915#11520]) +3 other tests skip
[234]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-tglu-1/igt@[email protected]
* igt@kms_psr2_sf@psr2-overlay-plane-move-continuous-exceed-fully-sf:
- shard-tglu: NOTRUN -> [SKIP][235] ([i915#11520]) +3 other tests skip
[235]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-tglu-4/igt@kms_psr2_sf@psr2-overlay-plane-move-continuous-exceed-fully-sf.html
* igt@kms_psr2_sf@psr2-overlay-plane-move-continuous-exceed-sf:
- shard-dg2: NOTRUN -> [SKIP][236] ([i915#11520]) +3 other tests skip
[236]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-dg2-6/igt@[email protected]
* igt@kms_psr@fbc-pr-cursor-plane-onoff:
- shard-tglu-1: NOTRUN -> [SKIP][237] ([i915#9732]) +11 other tests skip
[237]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-tglu-1/igt@[email protected]
* igt@kms_psr@fbc-psr-cursor-plane-onoff:
- shard-tglu: NOTRUN -> [SKIP][238] ([i915#9732]) +10 other tests skip
[238]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-tglu-4/igt@[email protected]
* igt@kms_psr@fbc-psr-sprite-plane-move:
- shard-mtlp: NOTRUN -> [SKIP][239] ([i915#9688]) +3 other tests skip
[239]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-mtlp-6/igt@[email protected]
* igt@kms_psr@fbc-psr2-cursor-mmap-gtt:
- shard-glk: NOTRUN -> [SKIP][240] +327 other tests skip
[240]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-glk5/igt@[email protected]
* igt@kms_psr@fbc-psr2-sprite-blt:
- shard-rkl: NOTRUN -> [SKIP][241] ([i915#1072] / [i915#14544] / [i915#9732]) +7 other tests skip
[241]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-rkl-6/igt@[email protected]
* igt@kms_psr@pr-sprite-mmap-gtt:
- shard-rkl: NOTRUN -> [SKIP][242] ([i915#1072] / [i915#9732]) +3 other tests skip
[242]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-rkl-8/igt@[email protected]
* igt@kms_psr@psr2-no-drrs:
- shard-dg2: NOTRUN -> [SKIP][243] ([i915#1072] / [i915#9732]) +10 other tests skip
[243]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-dg2-3/igt@[email protected]
* igt@kms_psr_stress_test@flip-primary-invalidate-overlay:
- shard-dg2: NOTRUN -> [SKIP][244] ([i915#9685])
[244]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-dg2-3/igt@[email protected]
* igt@kms_rotation_crc@primary-rotation-270:
- shard-dg2: NOTRUN -> [SKIP][245] ([i915#12755]) +1 other test skip
[245]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-dg2-3/igt@[email protected]
* igt@kms_scaling_modes@scaling-mode-full-aspect:
- shard-tglu: NOTRUN -> [SKIP][246] ([i915#3555]) +2 other tests skip
[246]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-tglu-3/igt@[email protected]
* igt@kms_selftest@drm_framebuffer@drm_test_framebuffer_free:
- shard-glk10: NOTRUN -> [ABORT][247] ([i915#13179]) +1 other test abort
[247]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-glk10/igt@kms_selftest@drm_framebuffer@drm_test_framebuffer_free.html
* igt@kms_sharpness_filter@filter-basic:
- shard-rkl: NOTRUN -> [SKIP][248] ([i915#15232])
[248]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-rkl-8/igt@[email protected]
* igt@kms_sharpness_filter@filter-modifiers:
- shard-tglu: NOTRUN -> [SKIP][249] ([i915#15232])
[249]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-tglu-3/igt@[email protected]
* igt@kms_sharpness_filter@filter-strength:
- shard-tglu-1: NOTRUN -> [SKIP][250] ([i915#15232])
[250]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-tglu-1/igt@[email protected]
* igt@kms_vrr@flip-basic-fastset:
- shard-tglu-1: NOTRUN -> [SKIP][251] ([i915#9906])
[251]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-tglu-1/igt@[email protected]
* igt@kms_vrr@max-min:
- shard-tglu: NOTRUN -> [SKIP][252] ([i915#9906]) +1 other test skip
[252]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-tglu-4/igt@[email protected]
* igt@kms_writeback@writeback-check-output:
- shard-tglu-1: NOTRUN -> [SKIP][253] ([i915#2437])
[253]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-tglu-1/igt@[email protected]
* igt@kms_writeback@writeback-check-output-xrgb2101010:
- shard-glk: NOTRUN -> [SKIP][254] ([i915#2437])
[254]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-glk6/igt@[email protected]
* igt@perf@per-context-mode-unprivileged:
- shard-rkl: NOTRUN -> [SKIP][255] ([i915#2435])
[255]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-rkl-8/igt@[email protected]
* igt@perf_pmu@busy-double-start@vecs1:
- shard-dg2: [PASS][256] -> [FAIL][257] ([i915#4349]) +4 other tests fail
[256]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17515/shard-dg2-6/igt@perf_pmu@[email protected]
[257]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-dg2-5/igt@perf_pmu@[email protected]
* igt@perf_pmu@event-wait:
- shard-mtlp: NOTRUN -> [SKIP][258] ([i915#8807])
[258]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-mtlp-6/igt@[email protected]
* igt@perf_pmu@event-wait@rcs0:
- shard-mtlp: NOTRUN -> [SKIP][259] ([i915#3555] / [i915#8807])
[259]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-mtlp-6/igt@perf_pmu@[email protected]
* igt@perf_pmu@frequency@gt0:
- shard-dg2: NOTRUN -> [FAIL][260] ([i915#12549] / [i915#6806]) +1 other test fail
[260]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-dg2-3/igt@perf_pmu@[email protected]
* igt@prime_vgem@basic-gtt:
- shard-dg2: NOTRUN -> [SKIP][261] ([i915#3708] / [i915#4077])
[261]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-dg2-6/igt@[email protected]
* igt@sriov_basic@bind-unbind-vf@vf-1:
- shard-tglu-1: NOTRUN -> [FAIL][262] ([i915#12910]) +9 other tests fail
[262]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-tglu-1/igt@sriov_basic@[email protected]
* igt@sriov_basic@enable-vfs-bind-unbind-each-numvfs-all:
- shard-tglu: NOTRUN -> [FAIL][263] ([i915#12910])
[263]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-tglu-3/igt@[email protected]
#### Possible fixes ####
* igt@fbdev@nullptr:
- shard-rkl: [SKIP][264] ([i915#14544] / [i915#2582]) -> [PASS][265]
[264]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17515/shard-rkl-6/igt@[email protected]
[265]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-rkl-8/igt@[email protected]
* igt@gem_ccs@suspend-resume@linear-compressed-compfmt0-lmem0-lmem0:
- shard-dg2: [INCOMPLETE][266] ([i915#12392] / [i915#13356]) -> [PASS][267]
[266]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17515/shard-dg2-4/igt@gem_ccs@[email protected]
[267]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-dg2-1/igt@gem_ccs@[email protected]
* igt@gem_exec_suspend@basic-s0@smem:
- shard-dg2: [INCOMPLETE][268] ([i915#13356]) -> [PASS][269] +1 other test pass
[268]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17515/shard-dg2-5/igt@gem_exec_suspend@[email protected]
[269]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-dg2-3/igt@gem_exec_suspend@[email protected]
* igt@gem_lmem_swapping@smem-oom@lmem0:
- shard-dg1: [TIMEOUT][270] ([i915#5493]) -> [PASS][271] +1 other test pass
[270]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17515/shard-dg1-18/igt@gem_lmem_swapping@[email protected]
[271]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-dg1-12/igt@gem_lmem_swapping@[email protected]
* igt@gem_mmap_gtt@fault-concurrent:
- shard-rkl: [DMESG-WARN][272] ([i915#12964]) -> [PASS][273] +9 other tests pass
[272]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17515/shard-rkl-6/igt@[email protected]
[273]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-rkl-5/igt@[email protected]
* igt@gem_pxp@create-protected-buffer:
- shard-rkl: [SKIP][274] ([i915#14544] / [i915#4270]) -> [PASS][275] +1 other test pass
[274]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17515/shard-rkl-6/igt@[email protected]
[275]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-rkl-8/igt@[email protected]
* igt@gem_pxp@protected-encrypted-src-copy-not-readible:
- shard-rkl: [TIMEOUT][276] ([i915#12917] / [i915#12964]) -> [PASS][277] +1 other test pass
[276]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17515/shard-rkl-2/igt@[email protected]
[277]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-rkl-8/igt@[email protected]
* igt@i915_pm_freq_api@freq-suspend@gt0:
- shard-dg2: [INCOMPLETE][278] ([i915#13356] / [i915#13820]) -> [PASS][279] +1 other test pass
[278]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17515/shard-dg2-6/igt@i915_pm_freq_api@[email protected]
[279]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-dg2-3/igt@i915_pm_freq_api@[email protected]
* igt@i915_suspend@basic-s3-without-i915:
- shard-rkl: [INCOMPLETE][280] ([i915#4817]) -> [PASS][281]
[280]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17515/shard-rkl-3/igt@[email protected]
[281]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-rkl-6/igt@[email protected]
* igt@i915_suspend@forcewake:
- shard-rkl: [ABORT][282] ([i915#15140]) -> [PASS][283]
[282]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17515/shard-rkl-4/igt@[email protected]
[283]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-rkl-6/igt@[email protected]
* igt@kms_big_fb@4-tiled-max-hw-stride-64bpp-rotate-180-hflip:
- shard-mtlp: [FAIL][284] ([i915#5138]) -> [PASS][285]
[284]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17515/shard-mtlp-6/igt@[email protected]
[285]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-mtlp-2/igt@[email protected]
* igt@kms_color@ctm-green-to-red:
- shard-rkl: [SKIP][286] ([i915#12655] / [i915#14544]) -> [PASS][287] +1 other test pass
[286]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17515/shard-rkl-6/igt@[email protected]
[287]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-rkl-2/igt@[email protected]
* igt@kms_cursor_crc@cursor-onscreen-256x256:
- shard-rkl: [SKIP][288] ([i915#14544]) -> [PASS][289] +47 other tests pass
[288]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17515/shard-rkl-6/igt@[email protected]
[289]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-rkl-5/igt@[email protected]
* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size:
- shard-glk: [FAIL][290] ([i915#2346]) -> [PASS][291]
[290]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17515/shard-glk6/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
[291]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-glk9/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
* igt@kms_flip@flip-vs-expired-vblank-interruptible:
- shard-rkl: [SKIP][292] ([i915#14544] / [i915#3637]) -> [PASS][293] +6 other tests pass
[292]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17515/shard-rkl-6/igt@[email protected]
[293]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-rkl-2/igt@[email protected]
* igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytilegen12rcccs-upscaling:
- shard-rkl: [SKIP][294] ([i915#14544] / [i915#3555]) -> [PASS][295] +1 other test pass
[294]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17515/shard-rkl-6/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytilegen12rcccs-upscaling.html
[295]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-rkl-2/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytilegen12rcccs-upscaling.html
* igt@kms_frontbuffer_tracking@fbc-1p-pri-indfb-multidraw:
- shard-rkl: [SKIP][296] ([i915#14544] / [i915#1849] / [i915#5354]) -> [PASS][297] +10 other tests pass
[296]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17515/shard-rkl-6/igt@[email protected]
[297]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-rkl-2/igt@[email protected]
* igt@kms_hdr@static-toggle-suspend:
- shard-dg2: [SKIP][298] ([i915#3555] / [i915#8228]) -> [PASS][299] +1 other test pass
[298]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17515/shard-dg2-7/igt@[email protected]
[299]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-dg2-10/igt@[email protected]
* igt@kms_invalid_mode@overflow-vrefresh:
- shard-rkl: [SKIP][300] ([i915#14544] / [i915#8826]) -> [PASS][301]
[300]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17515/shard-rkl-6/igt@[email protected]
[301]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-rkl-2/igt@[email protected]
* igt@kms_invalid_mode@zero-clock:
- shard-rkl: [SKIP][302] ([i915#14544] / [i915#3555] / [i915#8826]) -> [PASS][303] +2 other tests pass
[302]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17515/shard-rkl-6/igt@[email protected]
[303]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-rkl-5/igt@[email protected]
* igt@kms_joiner@invalid-modeset-force-big-joiner:
- shard-dg2: [SKIP][304] ([i915#12388]) -> [PASS][305]
[304]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17515/shard-dg2-7/igt@[email protected]
[305]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-dg2-10/igt@[email protected]
* igt@kms_pipe_crc_basic@hang-read-crc:
- shard-rkl: [SKIP][306] ([i915#11190] / [i915#14544]) -> [PASS][307]
[306]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17515/shard-rkl-6/igt@[email protected]
[307]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-rkl-5/igt@[email protected]
* igt@kms_plane@planar-pixel-format-settings:
- shard-rkl: [SKIP][308] ([i915#14544] / [i915#9581]) -> [PASS][309]
[308]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17515/shard-rkl-6/igt@[email protected]
[309]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-rkl-2/igt@[email protected]
* igt@kms_plane@plane-position-hole:
- shard-rkl: [SKIP][310] ([i915#14544] / [i915#8825]) -> [PASS][311]
[310]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17515/shard-rkl-6/igt@[email protected]
[311]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-rkl-2/igt@[email protected]
* igt@kms_plane_alpha_blend@constant-alpha-mid:
- shard-rkl: [SKIP][312] ([i915#14544] / [i915#7294]) -> [PASS][313]
[312]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17515/shard-rkl-6/igt@[email protected]
[313]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-rkl-2/igt@[email protected]
* igt@kms_plane_scaling@plane-upscale-factor-0-25-with-modifiers:
- shard-rkl: [SKIP][314] ([i915#14544] / [i915#8152]) -> [PASS][315] +1 other test pass
[314]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17515/shard-rkl-6/igt@[email protected]
[315]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-rkl-2/igt@[email protected]
* igt@kms_plane_scaling@plane-upscale-factor-0-25-with-pixel-format@pipe-a:
- shard-rkl: [SKIP][316] ([i915#12247] / [i915#14544]) -> [PASS][317] +6 other tests pass
[316]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17515/shard-rkl-6/igt@kms_plane_scaling@[email protected]
[317]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-rkl-2/igt@kms_plane_scaling@[email protected]
* igt@kms_plane_scaling@planes-downscale-factor-0-75-upscale-factor-0-25:
- shard-rkl: [SKIP][318] ([i915#14544] / [i915#6953] / [i915#8152]) -> [PASS][319] +1 other test pass
[318]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17515/shard-rkl-6/igt@kms_plane_scaling@planes-downscale-factor-0-75-upscale-factor-0-25.html
[319]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-rkl-8/igt@kms_plane_scaling@planes-downscale-factor-0-75-upscale-factor-0-25.html
* igt@kms_plane_scaling@planes-unity-scaling-downscale-factor-0-75:
- shard-rkl: [SKIP][320] ([i915#14544] / [i915#3555] / [i915#6953] / [i915#8152]) -> [PASS][321]
[320]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17515/shard-rkl-6/igt@kms_plane_scaling@planes-unity-scaling-downscale-factor-0-75.html
[321]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-rkl-5/igt@kms_plane_scaling@planes-unity-scaling-downscale-factor-0-75.html
* igt@kms_plane_scaling@planes-unity-scaling-downscale-factor-0-75@pipe-b:
- shard-rkl: [SKIP][322] ([i915#12247] / [i915#14544] / [i915#8152]) -> [PASS][323] +8 other tests pass
[322]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17515/shard-rkl-6/igt@kms_plane_scaling@[email protected]
[323]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-rkl-5/igt@kms_plane_scaling@[email protected]
* igt@kms_pm_dc@dc5-dpms-negative:
- shard-rkl: [SKIP][324] ([i915#13441] / [i915#14544]) -> [PASS][325]
[324]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17515/shard-rkl-6/igt@[email protected]
[325]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-rkl-2/igt@[email protected]
* igt@kms_pm_rpm@cursor-dpms:
- shard-rkl: [SKIP][326] ([i915#14544] / [i915#1849]) -> [PASS][327]
[326]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17515/shard-rkl-6/igt@[email protected]
[327]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-rkl-8/igt@[email protected]
* igt@kms_pm_rpm@dpms-lpsp:
- shard-rkl: [SKIP][328] ([i915#14544] / [i915#15073]) -> [PASS][329]
[328]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17515/shard-rkl-6/igt@[email protected]
[329]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-rkl-2/igt@[email protected]
* igt@kms_pm_rpm@i2c:
- shard-dg1: [DMESG-WARN][330] ([i915#4423]) -> [PASS][331]
[330]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17515/shard-dg1-17/igt@[email protected]
[331]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-dg1-13/igt@[email protected]
* igt@kms_pm_rpm@modeset-non-lpsp-stress:
- shard-dg2: [SKIP][332] ([i915#15073]) -> [PASS][333] +1 other test pass
[332]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17515/shard-dg2-4/igt@[email protected]
[333]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-dg2-1/igt@[email protected]
#### Warnings ####
* igt@gem_bad_reloc@negative-reloc:
- shard-rkl: [SKIP][334] ([i915#3281]) -> [SKIP][335] ([i915#14544] / [i915#3281]) +6 other tests skip
[334]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17515/shard-rkl-3/igt@[email protected]
[335]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-rkl-6/igt@[email protected]
* igt@gem_ccs@block-multicopy-inplace:
- shard-rkl: [SKIP][336] ([i915#14544] / [i915#3555] / [i915#9323]) -> [SKIP][337] ([i915#3555] / [i915#9323]) +1 other test skip
[336]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17515/shard-rkl-6/igt@[email protected]
[337]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-rkl-2/igt@[email protected]
* igt@gem_ccs@suspend-resume:
- shard-rkl: [SKIP][338] ([i915#9323]) -> [SKIP][339] ([i915#14544] / [i915#9323])
[338]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17515/shard-rkl-3/igt@[email protected]
[339]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-rkl-6/igt@[email protected]
* igt@gem_close_race@multigpu-basic-threads:
- shard-rkl: [SKIP][340] ([i915#14544] / [i915#7697]) -> [SKIP][341] ([i915#7697])
[340]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17515/shard-rkl-6/igt@[email protected]
[341]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-rkl-5/igt@[email protected]
* igt@gem_create@create-ext-cpu-access-big:
- shard-rkl: [SKIP][342] ([i915#14544] / [i915#6335]) -> [SKIP][343] ([i915#6335])
[342]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17515/shard-rkl-6/igt@[email protected]
[343]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-rkl-2/igt@[email protected]
* igt@gem_create@create-ext-cpu-access-sanity-check:
- shard-rkl: [SKIP][344] ([i915#6335]) -> [SKIP][345] ([i915#14544] / [i915#6335])
[344]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17515/shard-rkl-8/igt@[email protected]
[345]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-rkl-6/igt@[email protected]
* igt@gem_eio@kms:
- shard-rkl: [DMESG-WARN][346] ([i915#13363]) -> [DMESG-WARN][347] ([i915#12964])
[346]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17515/shard-rkl-8/igt@[email protected]
[347]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-rkl-3/igt@[email protected]
* igt@gem_exec_balancer@parallel-contexts:
- shard-rkl: [SKIP][348] ([i915#14544] / [i915#4525]) -> [SKIP][349] ([i915#4525])
[348]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17515/shard-rkl-6/igt@[email protected]
[349]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-rkl-5/igt@[email protected]
* igt@gem_exec_balancer@parallel-out-fence:
- shard-rkl: [SKIP][350] ([i915#4525]) -> [SKIP][351] ([i915#14544] / [i915#4525])
[350]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17515/shard-rkl-5/igt@[email protected]
[351]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-rkl-6/igt@[email protected]
* igt@gem_exec_reloc@basic-cpu-gtt:
- shard-rkl: [SKIP][352] ([i915#14544] / [i915#3281]) -> [SKIP][353] ([i915#3281]) +10 other tests skip
[352]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17515/shard-rkl-6/igt@[email protected]
[353]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-rkl-8/igt@[email protected]
* igt@gem_huc_copy@huc-copy:
- shard-rkl: [SKIP][354] ([i915#2190]) -> [SKIP][355] ([i915#14544] / [i915#2190])
[354]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17515/shard-rkl-5/igt@[email protected]
[355]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-rkl-6/igt@[email protected]
* igt@gem_lmem_swapping@heavy-verify-random-ccs:
- shard-rkl: [SKIP][356] ([i915#14544] / [i915#4613]) -> [SKIP][357] ([i915#4613]) +3 other tests skip
[356]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17515/shard-rkl-6/igt@[email protected]
[357]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-rkl-2/igt@[email protected]
* igt@gem_lmem_swapping@parallel-random-engines:
- shard-rkl: [SKIP][358] ([i915#4613]) -> [SKIP][359] ([i915#14544] / [i915#4613]) +1 other test skip
[358]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17515/shard-rkl-8/igt@[email protected]
[359]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-rkl-6/igt@[email protected]
* igt@gem_partial_pwrite_pread@writes-after-reads:
- shard-rkl: [SKIP][360] ([i915#3282]) -> [SKIP][361] ([i915#14544] / [i915#3282]) +1 other test skip
[360]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17515/shard-rkl-5/igt@[email protected]
[361]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-rkl-6/igt@[email protected]
* igt@gem_pread@bench:
- shard-rkl: [SKIP][362] ([i915#14544] / [i915#3282]) -> [SKIP][363] ([i915#3282]) +5 other tests skip
[362]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17515/shard-rkl-6/igt@[email protected]
[363]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-rkl-5/igt@[email protected]
* igt@gem_set_tiling_vs_blt@tiled-to-tiled:
- shard-rkl: [SKIP][364] ([i915#8411]) -> [SKIP][365] ([i915#14544] / [i915#8411])
[364]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17515/shard-rkl-5/igt@[email protected]
[365]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-rkl-6/igt@[email protected]
* igt@gem_userptr_blits@access-control:
- shard-rkl: [SKIP][366] ([i915#14544] / [i915#3297]) -> [SKIP][367] ([i915#3297])
[366]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17515/shard-rkl-6/igt@[email protected]
[367]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-rkl-8/igt@[email protected]
* igt@gem_userptr_blits@dmabuf-sync:
- shard-rkl: [SKIP][368] ([i915#14544] / [i915#3297] / [i915#3323]) -> [SKIP][369] ([i915#3297] / [i915#3323])
[368]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17515/shard-rkl-6/igt@[email protected]
[369]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-rkl-5/igt@[email protected]
* igt@gen9_exec_parse@batch-invalid-length:
- shard-rkl: [SKIP][370] ([i915#2527]) -> [SKIP][371] ([i915#14544] / [i915#2527]) +4 other tests skip
[370]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17515/shard-rkl-5/igt@[email protected]
[371]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-rkl-6/igt@[email protected]
* igt@gen9_exec_parse@bb-start-out:
- shard-rkl: [SKIP][372] ([i915#14544] / [i915#2527]) -> [SKIP][373] ([i915#2527]) +3 other tests skip
[372]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17515/shard-rkl-6/igt@[email protected]
[373]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-rkl-2/igt@[email protected]
* igt@i915_module_load@resize-bar:
- shard-rkl: [SKIP][374] ([i915#6412]) -> [SKIP][375] ([i915#14544] / [i915#6412])
[374]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17515/shard-rkl-5/igt@[email protected]
[375]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-rkl-6/igt@[email protected]
* igt@i915_pm_sseu@full-enable:
- shard-rkl: [SKIP][376] ([i915#14544] / [i915#4387]) -> [SKIP][377] ([i915#4387])
[376]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17515/shard-rkl-6/igt@[email protected]
[377]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-rkl-2/igt@[email protected]
* igt@i915_query@hwconfig_table:
- shard-rkl: [SKIP][378] ([i915#6245]) -> [SKIP][379] ([i915#14544] / [i915#6245])
[378]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17515/shard-rkl-5/igt@i915_query@hwconfig_table.html
[379]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-rkl-6/igt@i915_query@hwconfig_table.html
* igt@intel_hwmon@hwmon-write:
- shard-rkl: [SKIP][380] ([i915#14544] / [i915#7707]) -> [SKIP][381] ([i915#7707]) +1 other test skip
[380]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17515/shard-rkl-6/igt@[email protected]
[381]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-rkl-5/igt@[email protected]
* igt@kms_addfb_basic@invalid-smem-bo-on-discrete:
- shard-rkl: [SKIP][382] ([i915#12454] / [i915#12712]) -> [SKIP][383] ([i915#12454] / [i915#12712] / [i915#14544])
[382]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17515/shard-rkl-3/igt@[email protected]
[383]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-rkl-6/igt@[email protected]
* igt@kms_atomic_transition@plane-all-modeset-transition-internal-panels:
- shard-rkl: [SKIP][384] ([i915#14544]) -> [SKIP][385] ([i915#1769] / [i915#3555])
[384]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17515/shard-rkl-6/igt@kms_atomic_transition@plane-all-modeset-transition-internal-panels.html
[385]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-rkl-5/igt@kms_atomic_transition@plane-all-modeset-transition-internal-panels.html
* igt@kms_big_fb@4-tiled-16bpp-rotate-180:
- shard-rkl: [SKIP][386] ([i915#14544]) -> [SKIP][387] ([i915#5286]) +6 other tests skip
[386]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17515/shard-rkl-6/igt@[email protected]
[387]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-rkl-2/igt@[email protected]
* igt@kms_big_fb@4-tiled-64bpp-rotate-270:
- shard-rkl: [SKIP][388] ([i915#5286]) -> [SKIP][389] ([i915#14544]) +2 other tests skip
[388]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17515/shard-rkl-5/igt@[email protected]
[389]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-rkl-6/igt@[email protected]
* igt@kms_big_fb@4-tiled-8bpp-rotate-90:
- shard-dg1: [SKIP][390] ([i915#4538] / [i915#5286]) -> [SKIP][391] ([i915#4423] / [i915#4538] / [i915#5286])
[390]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17515/shard-dg1-16/igt@[email protected]
[391]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-dg1-16/igt@[email protected]
* igt@kms_big_fb@linear-16bpp-rotate-0:
- shard-rkl: [SKIP][392] ([i915#14544]) -> [DMESG-WARN][393] ([i915#12964]) +1 other test dmesg-warn
[392]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17515/shard-rkl-6/igt@[email protected]
[393]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-rkl-2/igt@[email protected]
* igt@kms_big_fb@linear-8bpp-rotate-270:
- shard-rkl: [SKIP][394] ([i915#3638]) -> [SKIP][395] ([i915#14544]) +2 other tests skip
[394]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17515/shard-rkl-5/igt@[email protected]
[395]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-rkl-6/igt@[email protected]
* igt@kms_big_fb@x-tiled-64bpp-rotate-270:
- shard-rkl: [SKIP][396] ([i915#14544]) -> [SKIP][397] ([i915#3638]) +3 other tests skip
[396]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17515/shard-rkl-6/igt@[email protected]
[397]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-rkl-5/igt@[email protected]
* igt@kms_big_fb@x-tiled-8bpp-rotate-270:
- shard-dg1: [SKIP][398] ([i915#3638]) -> [SKIP][399] ([i915#3638] / [i915#4423])
[398]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17515/shard-dg1-16/igt@[email protected]
[399]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-dg1-16/igt@[email protected]
* igt@kms_big_fb@yf-tiled-32bpp-rotate-0:
- shard-dg1: [SKIP][400] ([i915#4538]) -> [SKIP][401] ([i915#4423] / [i915#4538])
[400]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17515/shard-dg1-18/igt@[email protected]
[401]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-dg1-13/igt@[email protected]
* igt@kms_ccs@bad-aux-stride-yf-tiled-ccs@pipe-b-hdmi-a-2:
- shard-rkl: [SKIP][402] ([i915#6095]) -> [SKIP][403] ([i915#14098] / [i915#6095]) +3 other tests skip
[402]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17515/shard-rkl-8/igt@kms_ccs@[email protected]
[403]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-rkl-3/igt@kms_ccs@[email protected]
* igt@kms_ccs@crc-primary-basic-4-tiled-lnl-ccs:
- shard-rkl: [SKIP][404] ([i915#14544]) -> [SKIP][405] ([i915#12313])
[404]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17515/shard-rkl-6/igt@[email protected]
[405]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-rkl-2/igt@[email protected]
* igt@kms_ccs@crc-primary-basic-4-tiled-mtl-rc-ccs:
- shard-dg1: [SKIP][406] ([i915#6095]) -> [SKIP][407] ([i915#4423] / [i915#6095])
[406]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17515/shard-dg1-18/igt@[email protected]
[407]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-dg1-13/igt@[email protected]
* igt@kms_ccs@crc-primary-rotation-180-4-tiled-dg2-rc-ccs:
- shard-rkl: [SKIP][408] ([i915#14098] / [i915#6095]) -> [SKIP][409] ([i915#14544]) +8 other tests skip
[408]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17515/shard-rkl-5/igt@[email protected]
[409]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-rkl-6/igt@[email protected]
* igt@kms_ccs@crc-primary-rotation-180-4-tiled-lnl-ccs:
- shard-dg1: [SKIP][410] ([i915#12313]) -> [SKIP][411] ([i915#12313] / [i915#4423])
[410]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17515/shard-dg1-18/igt@[email protected]
[411]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-dg1-13/igt@[email protected]
* igt@kms_ccs@crc-primary-suspend-4-tiled-lnl-ccs:
- shard-rkl: [SKIP][412] ([i915#14544]) -> [SKIP][413] ([i915#12805])
[412]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17515/shard-rkl-6/igt@[email protected]
[413]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-rkl-5/igt@[email protected]
* igt@kms_ccs@crc-primary-suspend-yf-tiled-ccs:
- shard-rkl: [SKIP][414] ([i915#14544]) -> [SKIP][415] ([i915#14098] / [i915#6095]) +14 other tests skip
[414]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17515/shard-rkl-6/igt@[email protected]
[415]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-rkl-2/igt@[email protected]
* igt@kms_ccs@random-ccs-data-4-tiled-lnl-ccs:
- shard-rkl: [SKIP][416] ([i915#12313]) -> [SKIP][417] ([i915#14544])
[416]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17515/shard-rkl-5/igt@[email protected]
[417]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-rkl-6/igt@[email protected]
* igt@kms_cdclk@mode-transition-all-outputs:
- shard-rkl: [SKIP][418] ([i915#14544] / [i915#3742]) -> [SKIP][419] ([i915#3742])
[418]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17515/shard-rkl-6/igt@[email protected]
[419]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-rkl-8/igt@[email protected]
* igt@kms_chamelium_frames@hdmi-crc-fast:
- shard-rkl: [SKIP][420] ([i915#11151] / [i915#7828]) -> [SKIP][421] ([i915#11151] / [i915#14544] / [i915#7828]) +6 other tests skip
[420]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17515/shard-rkl-5/igt@[email protected]
[421]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-rkl-6/igt@[email protected]
* igt@kms_chamelium_hpd@dp-hpd:
- shard-rkl: [SKIP][422] ([i915#11151] / [i915#14544] / [i915#7828]) -> [SKIP][423] ([i915#11151] / [i915#7828]) +6 other tests skip
[422]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17515/shard-rkl-6/igt@[email protected]
[423]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-rkl-8/igt@[email protected]
* igt@kms_content_protection@atomic-dpms:
- shard-dg2: [SKIP][424] ([i915#7118] / [i915#9424]) -> [FAIL][425] ([i915#7173]) +1 other test fail
[424]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17515/shard-dg2-7/igt@[email protected]
[425]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-dg2-10/igt@[email protected]
- shard-rkl: [SKIP][426] ([i915#7118] / [i915#9424]) -> [SKIP][427] ([i915#14544])
[426]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17515/shard-rkl-5/igt@[email protected]
[427]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-rkl-6/igt@[email protected]
* igt@kms_content_protection@dp-mst-lic-type-0:
- shard-rkl: [SKIP][428] ([i915#3116]) -> [SKIP][429] ([i915#14544])
[428]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17515/shard-rkl-5/igt@[email protected]
[429]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-rkl-6/igt@[email protected]
* igt@kms_content_protection@dp-mst-lic-type-1:
- shard-rkl: [SKIP][430] ([i915#14544]) -> [SKIP][431] ([i915#3116])
[430]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17515/shard-rkl-6/igt@[email protected]
[431]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-rkl-5/igt@[email protected]
* igt@kms_content_protection@lic-type-1:
- shard-rkl: [SKIP][432] ([i915#14544]) -> [SKIP][433] ([i915#9424])
[432]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17515/shard-rkl-6/igt@[email protected]
[433]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-rkl-2/igt@[email protected]
* igt@kms_content_protection@srm:
- shard-rkl: [SKIP][434] ([i915#14544]) -> [SKIP][435] ([i915#7118])
[434]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17515/shard-rkl-6/igt@[email protected]
[435]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-rkl-8/igt@[email protected]
* igt@kms_content_protection@type1:
- shard-dg2: [SKIP][436] ([i915#7118] / [i915#7162] / [i915#9424]) -> [SKIP][437] ([i915#7118] / [i915#9424])
[436]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17515/shard-dg2-11/igt@[email protected]
[437]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-dg2-7/igt@[email protected]
* igt@kms_cursor_crc@cursor-onscreen-32x10:
- shard-dg1: [SKIP][438] ([i915#3555]) -> [SKIP][439] ([i915#3555] / [i915#4423])
[438]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17515/shard-dg1-18/igt@[email protected]
[439]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-dg1-13/igt@[email protected]
* igt@kms_cursor_crc@cursor-random-512x170:
- shard-rkl: [SKIP][440] ([i915#13049]) -> [SKIP][441] ([i915#14544])
[440]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17515/shard-rkl-5/igt@[email protected]
[441]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-rkl-6/igt@[email protected]
* igt@kms_cursor_crc@cursor-rapid-movement-512x170:
- shard-rkl: [SKIP][442] ([i915#14544]) -> [SKIP][443] ([i915#13049])
[442]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17515/shard-rkl-6/igt@[email protected]
[443]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-rkl-8/igt@[email protected]
* igt@kms_cursor_crc@cursor-rapid-movement-max-size:
- shard-rkl: [SKIP][444] ([i915#14544]) -> [SKIP][445] ([i915#3555]) +2 other tests skip
[444]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17515/shard-rkl-6/igt@[email protected]
[445]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-rkl-2/igt@[email protected]
* igt@kms_cursor_crc@cursor-sliding-128x42:
- shard-rkl: [FAIL][446] ([i915#13566]) -> [SKIP][447] ([i915#14544])
[446]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17515/shard-rkl-5/igt@[email protected]
[447]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-rkl-6/igt@[email protected]
* igt@kms_cursor_legacy@2x-long-nonblocking-modeset-vs-cursor-atomic:
- shard-dg1: [SKIP][448] -> [SKIP][449] ([i915#4423]) +1 other test skip
[448]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17515/shard-dg1-18/igt@kms_cursor_legacy@2x-long-nonblocking-modeset-vs-cursor-atomic.html
[449]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-dg1-13/igt@kms_cursor_legacy@2x-long-nonblocking-modeset-vs-cursor-atomic.html
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy:
- shard-rkl: [SKIP][450] ([i915#4103]) -> [SKIP][451] ([i915#11190] / [i915#14544]) +1 other test skip
[450]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17515/shard-rkl-5/igt@[email protected]
[451]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-rkl-6/igt@[email protected]
* igt@kms_cursor_legacy@cursora-vs-flipb-atomic-transitions-varying-size:
- shard-rkl: [SKIP][452] ([i915#14544]) -> [SKIP][453] +17 other tests skip
[452]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17515/shard-rkl-6/igt@kms_cursor_legacy@cursora-vs-flipb-atomic-transitions-varying-size.html
[453]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-rkl-5/igt@kms_cursor_legacy@cursora-vs-flipb-atomic-transitions-varying-size.html
* igt@kms_cursor_legacy@cursora-vs-flipb-varying-size:
- shard-rkl: [SKIP][454] -> [SKIP][455] ([i915#14544]) +14 other tests skip
[454]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17515/shard-rkl-5/igt@[email protected]
[455]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-rkl-6/igt@[email protected]
* igt@kms_cursor_legacy@short-busy-flip-before-cursor-atomic-transitions-varying-size:
- shard-rkl: [SKIP][456] ([i915#4103]) -> [SKIP][457] ([i915#14544])
[456]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17515/shard-rkl-5/igt@kms_cursor_legacy@short-busy-flip-before-cursor-atomic-transitions-varying-size.html
[457]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-rkl-6/igt@kms_cursor_legacy@short-busy-flip-before-cursor-atomic-transitions-varying-size.html
* igt@kms_dirtyfb@psr-dirtyfb-ioctl:
- shard-rkl: [SKIP][458] ([i915#14544]) -> [SKIP][459] ([i915#9723])
[458]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17515/shard-rkl-6/igt@[email protected]
[459]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-rkl-2/igt@[email protected]
* igt@kms_dp_link_training@non-uhbr-mst:
- shard-rkl: [SKIP][460] ([i915#13749]) -> [SKIP][461] ([i915#14544])
[460]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17515/shard-rkl-5/igt@[email protected]
[461]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-rkl-6/igt@[email protected]
* igt@kms_dp_link_training@non-uhbr-sst:
- shard-rkl: [SKIP][462] ([i915#14544]) -> [SKIP][463] ([i915#13749])
[462]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17515/shard-rkl-6/igt@[email protected]
[463]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-rkl-5/igt@[email protected]
* igt@kms_dp_linktrain_fallback@dsc-fallback:
- shard-rkl: [SKIP][464] ([i915#14544]) -> [SKIP][465] ([i915#13707])
[464]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17515/shard-rkl-6/igt@[email protected]
[465]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-rkl-8/igt@[email protected]
* igt@kms_dsc@dsc-basic:
- shard-rkl: [SKIP][466] ([i915#11190] / [i915#14544]) -> [SKIP][467] ([i915#3555] / [i915#3840])
[466]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17515/shard-rkl-6/igt@[email protected]
[467]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-rkl-2/igt@[email protected]
* igt@kms_dsc@dsc-with-formats:
- shard-rkl: [SKIP][468] ([i915#14544]) -> [SKIP][469] ([i915#3555] / [i915#3840])
[468]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17515/shard-rkl-6/igt@[email protected]
[469]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-rkl-2/igt@[email protected]
* igt@kms_fbcon_fbt@psr-suspend:
- shard-rkl: [SKIP][470] ([i915#14544] / [i915#3955]) -> [SKIP][471] ([i915#3955])
[470]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17515/shard-rkl-6/igt@[email protected]
[471]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-rkl-8/igt@[email protected]
* igt@kms_feature_discovery@display-2x:
- shard-dg1: [SKIP][472] ([i915#1839]) -> [SKIP][473] ([i915#1839] / [i915#4423])
[472]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17515/shard-dg1-18/igt@[email protected]
[473]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-dg1-13/igt@[email protected]
* igt@kms_feature_discovery@dp-mst:
- shard-rkl: [SKIP][474] ([i915#14544] / [i915#9337]) -> [SKIP][475] ([i915#9337])
[474]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17515/shard-rkl-6/igt@[email protected]
[475]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-rkl-5/igt@[email protected]
* igt@kms_flip@2x-flip-vs-dpms-off-vs-modeset-interruptible:
- shard-rkl: [SKIP][476] ([i915#14544] / [i915#9934]) -> [SKIP][477] ([i915#9934]) +8 other tests skip
[476]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17515/shard-rkl-6/igt@[email protected]
[477]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-rkl-8/igt@[email protected]
* igt@kms_flip@2x-flip-vs-modeset-vs-hang:
- shard-rkl: [SKIP][478] ([i915#9934]) -> [SKIP][479] ([i915#14544] / [i915#9934]) +4 other tests skip
[478]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17515/shard-rkl-3/igt@[email protected]
[479]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-rkl-6/igt@[email protected]
* igt@kms_flip@flip-vs-panning-interruptible:
- shard-rkl: [SKIP][480] ([i915#14544] / [i915#3637]) -> [DMESG-WARN][481] ([i915#12964])
[480]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17515/shard-rkl-6/igt@[email protected]
[481]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-rkl-5/igt@[email protected]
* igt@kms_flip_scaled_crc@flip-32bpp-ytileccs-to-64bpp-ytile-upscaling:
- shard-rkl: [SKIP][482] ([i915#2672] / [i915#3555]) -> [SKIP][483] ([i915#14544] / [i915#3555]) +3 other tests skip
[482]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17515/shard-rkl-5/igt@kms_flip_scaled_crc@flip-32bpp-ytileccs-to-64bpp-ytile-upscaling.html
[483]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-rkl-6/igt@kms_flip_scaled_crc@flip-32bpp-ytileccs-to-64bpp-ytile-upscaling.html
* igt@kms_flip_scaled_crc@flip-64bpp-4tile-to-32bpp-4tiledg2rcccs-upscaling:
- shard-rkl: [SKIP][484] ([i915#14544] / [i915#3555]) -> [SKIP][485] ([i915#2672] / [i915#3555]) +4 other tests skip
[484]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17515/shard-rkl-6/igt@kms_flip_scaled_crc@flip-64bpp-4tile-to-32bpp-4tiledg2rcccs-upscaling.html
[485]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-rkl-8/igt@kms_flip_scaled_crc@flip-64bpp-4tile-to-32bpp-4tiledg2rcccs-upscaling.html
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-indfb-draw-pwrite:
- shard-rkl: [DMESG-WARN][486] ([i915#12964]) -> [SKIP][487] ([i915#14544] / [i915#1849] / [i915#5354])
[486]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17515/shard-rkl-5/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-indfb-draw-pwrite.html
[487]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-rkl-6/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-indfb-draw-pwrite.html
* igt@kms_frontbuffer_tracking@fbc-2p-indfb-fliptrack-mmap-gtt:
- shard-rkl: [SKIP][488] ([i915#14544] / [i915#1849] / [i915#5354]) -> [SKIP][489]
[488]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17515/shard-rkl-6/igt@[email protected]
[489]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-rkl-2/igt@[email protected]
* igt@kms_frontbuffer_tracking@fbc-tiling-4:
- shard-rkl: [SKIP][490] ([i915#14544] / [i915#1849] / [i915#5354]) -> [SKIP][491] ([i915#5439])
[490]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17515/shard-rkl-6/igt@[email protected]
[491]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-rkl-8/igt@[email protected]
* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-indfb-plflip-blt:
- shard-dg2: [SKIP][492] ([i915#15102] / [i915#3458]) -> [SKIP][493] ([i915#10433] / [i915#15102] / [i915#3458])
[492]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17515/shard-dg2-3/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-indfb-plflip-blt.html
[493]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-dg2-4/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-indfb-plflip-blt.html
* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-shrfb-plflip-blt:
- shard-dg2: [SKIP][494] ([i915#10433] / [i915#15102] / [i915#3458]) -> [SKIP][495] ([i915#15102] / [i915#3458])
[494]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17515/shard-dg2-4/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-shrfb-plflip-blt.html
[495]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-dg2-1/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-shrfb-plflip-blt.html
* igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-shrfb-plflip-blt:
- shard-rkl: [SKIP][496] ([i915#14544] / [i915#1849] / [i915#5354]) -> [SKIP][497] ([i915#1825]) +32 other tests skip
[496]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17515/shard-rkl-6/igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-shrfb-plflip-blt.html
[497]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-rkl-2/igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-shrfb-plflip-blt.html
* igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-shrfb-pgflip-blt:
- shard-rkl: [SKIP][498] ([i915#1825]) -> [SKIP][499] ([i915#14544] / [i915#1849] / [i915#5354]) +21 other tests skip
[498]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17515/shard-rkl-5/igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-shrfb-pgflip-blt.html
[499]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-rkl-6/igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-shrfb-pgflip-blt.html
* igt@kms_frontbuffer_tracking@fbcpsr-rgb101010-draw-mmap-wc:
- shard-rkl: [SKIP][500] ([i915#14544] / [i915#1849] / [i915#5354]) -> [SKIP][501] ([i915#15102] / [i915#3023]) +18 other tests skip
[500]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17515/shard-rkl-6/igt@[email protected]
[501]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-rkl-2/igt@[email protected]
* igt@kms_frontbuffer_tracking@pipe-fbc-rte:
- shard-rkl: [SKIP][502] ([i915#9766]) -> [SKIP][503] ([i915#14544] / [i915#1849] / [i915#5354])
[502]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17515/shard-rkl-5/igt@[email protected]
[503]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-rkl-6/igt@[email protected]
* igt@kms_frontbuffer_tracking@psr-1p-offscreen-pri-shrfb-draw-mmap-wc:
- shard-rkl: [SKIP][504] ([i915#15102]) -> [SKIP][505] ([i915#14544]) +2 other tests skip
[504]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17515/shard-rkl-5/igt@kms_frontbuffer_tracking@psr-1p-offscreen-pri-shrfb-draw-mmap-wc.html
[505]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-rkl-6/igt@kms_frontbuffer_tracking@psr-1p-offscreen-pri-shrfb-draw-mmap-wc.html
* igt@kms_frontbuffer_tracking@psr-1p-offscreen-pri-shrfb-draw-pwrite:
- shard-rkl: [SKIP][506] ([i915#14544]) -> [SKIP][507] ([i915#15102]) +1 other test skip
[506]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17515/shard-rkl-6/igt@kms_frontbuffer_tracking@psr-1p-offscreen-pri-shrfb-draw-pwrite.html
[507]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-rkl-2/igt@kms_frontbuffer_tracking@psr-1p-offscreen-pri-shrfb-draw-pwrite.html
* igt@kms_frontbuffer_tracking@psr-modesetfrombusy:
- shard-rkl: [SKIP][508] ([i915#15102] / [i915#3023]) -> [SKIP][509] ([i915#14544] / [i915#1849] / [i915#5354]) +17 other tests skip
[508]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17515/shard-rkl-3/igt@[email protected]
[509]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-rkl-6/igt@[email protected]
* igt@kms_hdr@static-toggle-suspend:
- shard-rkl: [SKIP][510] ([i915#3555] / [i915#8228]) -> [SKIP][511] ([i915#14544]) +1 other test skip
[510]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17515/shard-rkl-5/igt@[email protected]
[511]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-rkl-6/igt@[email protected]
* igt@kms_joiner@basic-ultra-joiner:
- shard-rkl: [SKIP][512] ([i915#12339]) -> [SKIP][513] ([i915#12339] / [i915#14544])
[512]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17515/shard-rkl-3/igt@[email protected]
[513]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-rkl-6/igt@[email protected]
* igt@kms_joiner@invalid-modeset-big-joiner:
- shard-rkl: [SKIP][514] ([i915#10656] / [i915#14544]) -> [SKIP][515] ([i915#10656])
[514]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17515/shard-rkl-6/igt@[email protected]
[515]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-rkl-2/igt@[email protected]
* igt@kms_joiner@invalid-modeset-force-big-joiner:
- shard-rkl: [SKIP][516] ([i915#12388]) -> [SKIP][517] ([i915#12388] / [i915#14544]) +1 other test skip
[516]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17515/shard-rkl-5/igt@[email protected]
[517]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-rkl-6/igt@[email protected]
* igt@kms_joiner@switch-modeset-ultra-joiner-big-joiner:
- shard-dg1: [SKIP][518] ([i915#13522]) -> [SKIP][519] ([i915#13522] / [i915#4423])
[518]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17515/shard-dg1-18/igt@[email protected]
[519]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-dg1-13/igt@[email protected]
* igt@kms_multipipe_modeset@basic-max-pipe-crc-check:
- shard-rkl: [SKIP][520] ([i915#4070] / [i915#4816]) -> [SKIP][521] ([i915#14544] / [i915#4070] / [i915#4816])
[520]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17515/shard-rkl-5/igt@[email protected]
[521]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-rkl-6/igt@[email protected]
* igt@kms_plane_multiple@2x-tiling-y:
- shard-rkl: [SKIP][522] ([i915#13958]) -> [SKIP][523] ([i915#14544]) +1 other test skip
[522]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17515/shard-rkl-5/igt@[email protected]
[523]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-rkl-6/igt@[email protected]
* igt@kms_plane_multiple@tiling-yf:
- shard-rkl: [SKIP][524] ([i915#14544]) -> [SKIP][525] ([i915#14259])
[524]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17515/shard-rkl-6/igt@[email protected]
[525]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-rkl-8/igt@[email protected]
* igt@kms_plane_scaling@plane-upscale-20x20-with-rotation@pipe-a:
- shard-rkl: [SKIP][526] ([i915#12247]) -> [SKIP][527] ([i915#12247] / [i915#14544])
[526]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17515/shard-rkl-5/igt@kms_plane_scaling@[email protected]
[527]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-rkl-6/igt@kms_plane_scaling@[email protected]
* igt@kms_plane_scaling@plane-upscale-20x20-with-rotation@pipe-b:
- shard-rkl: [SKIP][528] ([i915#12247]) -> [SKIP][529] ([i915#12247] / [i915#14544] / [i915#8152]) +1 other test skip
[528]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17515/shard-rkl-5/igt@kms_plane_scaling@[email protected]
[529]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-rkl-6/igt@kms_plane_scaling@[email protected]
* igt@kms_pm_backlight@brightness-with-dpms:
- shard-dg1: [SKIP][530] ([i915#12343]) -> [SKIP][531] ([i915#12343] / [i915#4423])
[530]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17515/shard-dg1-18/igt@[email protected]
[531]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-dg1-13/igt@[email protected]
* igt@kms_pm_dc@dc6-psr:
- shard-rkl: [SKIP][532] ([i915#9685]) -> [SKIP][533] ([i915#14544] / [i915#9685]) +1 other test skip
[532]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17515/shard-rkl-5/igt@[email protected]
[533]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-rkl-6/igt@[email protected]
* igt@kms_pm_dc@dc9-dpms:
- shard-rkl: [SKIP][534] ([i915#3361]) -> [SKIP][535] ([i915#4281])
[534]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17515/shard-rkl-8/igt@[email protected]
[535]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-rkl-2/igt@[email protected]
* igt@kms_pm_lpsp@kms-lpsp:
- shard-rkl: [SKIP][536] ([i915#9340]) -> [SKIP][537] ([i915#14544] / [i915#9340])
[536]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17515/shard-rkl-5/igt@[email protected]
[537]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-rkl-6/igt@[email protected]
* igt@kms_pm_rpm@dpms-mode-unset-lpsp:
- shard-rkl: [SKIP][538] ([i915#12916] / [i915#14544]) -> [SKIP][539] ([i915#15073])
[538]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17515/shard-rkl-6/igt@[email protected]
[539]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-rkl-5/igt@[email protected]
* igt@kms_pm_rpm@modeset-lpsp:
- shard-rkl: [SKIP][540] ([i915#15073]) -> [SKIP][541] ([i915#14544] / [i915#15073])
[540]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17515/shard-rkl-3/igt@[email protected]
[541]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-rkl-6/igt@[email protected]
* igt@kms_pm_rpm@modeset-lpsp-stress-no-wait:
- shard-dg1: [SKIP][542] ([i915#15073]) -> [SKIP][543] ([i915#15073] / [i915#4423])
[542]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17515/shard-dg1-16/igt@[email protected]
[543]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-dg1-16/igt@[email protected]
* igt@kms_prime@basic-crc-hybrid:
- shard-rkl: [SKIP][544] ([i915#6524]) -> [SKIP][545] ([i915#14544] / [i915#6524])
[544]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17515/shard-rkl-3/igt@[email protected]
[545]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-rkl-6/igt@[email protected]
* igt@kms_psr2_sf@fbc-pr-overlay-plane-update-continuous-sf:
- shard-rkl: [SKIP][546] ([i915#11520]) -> [SKIP][547] ([i915#11520] / [i915#14544]) +7 other tests skip
[546]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17515/shard-rkl-3/igt@[email protected]
[547]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-rkl-6/igt@[email protected]
* igt@kms_psr2_sf@fbc-pr-overlay-primary-update-sf-dmg-area:
- shard-rkl: [SKIP][548] ([i915#11520] / [i915#14544]) -> [SKIP][549] ([i915#11520]) +7 other tests skip
[548]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17515/shard-rkl-6/igt@[email protected]
[549]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-rkl-2/igt@[email protected]
* igt@kms_psr2_su@page_flip-nv12:
- shard-rkl: [SKIP][550] ([i915#9683]) -> [SKIP][551] ([i915#14544] / [i915#9683])
[550]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17515/shard-rkl-3/igt@kms_psr2_su@page_flip-nv12.html
[551]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-rkl-6/igt@kms_psr2_su@page_flip-nv12.html
* igt@kms_psr@fbc-psr2-sprite-render:
- shard-rkl: [SKIP][552] ([i915#1072] / [i915#14544] / [i915#9732]) -> [SKIP][553] ([i915#1072] / [i915#9732]) +19 other tests skip
[552]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17515/shard-rkl-6/igt@[email protected]
[553]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-rkl-5/igt@[email protected]
* igt@kms_psr@fbc-psr2-suspend:
- shard-dg1: [SKIP][554] ([i915#1072] / [i915#9732]) -> [SKIP][555] ([i915#1072] / [i915#4423] / [i915#9732]) +1 other test skip
[554]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17515/shard-dg1-18/igt@[email protected]
[555]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-dg1-13/igt@[email protected]
* igt@kms_psr@psr-sprite-plane-onoff:
- shard-rkl: [SKIP][556] ([i915#1072] / [i915#9732]) -> [SKIP][557] ([i915#1072] / [i915#14544] / [i915#9732]) +14 other tests skip
[556]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17515/shard-rkl-5/igt@[email protected]
[557]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-rkl-6/igt@[email protected]
* igt@kms_rotation_crc@primary-rotation-90:
- shard-rkl: [DMESG-WARN][558] ([i915#12964]) -> [SKIP][559] ([i915#14544]) +1 other test skip
[558]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17515/shard-rkl-5/igt@[email protected]
[559]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-rkl-6/igt@[email protected]
* igt@kms_rotation_crc@primary-yf-tiled-reflect-x-0:
- shard-rkl: [SKIP][560] ([i915#14544]) -> [SKIP][561] ([i915#5289]) +2 other tests skip
[560]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17515/shard-rkl-6/igt@[email protected]
[561]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-rkl-2/igt@[email protected]
* igt@kms_rotation_crc@primary-yf-tiled-reflect-x-270:
- shard-rkl: [SKIP][562] ([i915#5289]) -> [SKIP][563] ([i915#14544])
[562]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17515/shard-rkl-5/igt@[email protected]
[563]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-rkl-6/igt@[email protected]
* igt@kms_setmode@basic-clone-single-crtc:
- shard-rkl: [SKIP][564] ([i915#14544] / [i915#3555]) -> [SKIP][565] ([i915#3555]) +2 other tests skip
[564]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17515/shard-rkl-6/igt@[email protected]
[565]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-rkl-2/igt@[email protected]
* igt@kms_sharpness_filter@filter-scaler-downscale:
- shard-rkl: [SKIP][566] ([i915#14544]) -> [SKIP][567] ([i915#15232]) +3 other tests skip
[566]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17515/shard-rkl-6/igt@[email protected]
[567]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-rkl-8/igt@[email protected]
* igt@kms_vrr@flip-basic-fastset:
- shard-rkl: [SKIP][568] ([i915#9906]) -> [SKIP][569] ([i915#14544])
[568]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17515/shard-rkl-5/igt@[email protected]
[569]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-rkl-6/igt@[email protected]
* igt@kms_vrr@negative-basic:
- shard-rkl: [SKIP][570] ([i915#14544]) -> [SKIP][571] ([i915#3555] / [i915#9906])
[570]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17515/shard-rkl-6/igt@[email protected]
[571]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-rkl-8/igt@[email protected]
* igt@kms_writeback@writeback-fb-id:
- shard-dg1: [SKIP][572] ([i915#2437] / [i915#4423]) -> [SKIP][573] ([i915#2437])
[572]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17515/shard-dg1-19/igt@[email protected]
[573]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-dg1-17/igt@[email protected]
* igt@kms_writeback@writeback-fb-id-xrgb2101010:
- shard-rkl: [SKIP][574] ([i915#14544] / [i915#2437] / [i915#9412]) -> [SKIP][575] ([i915#2437] / [i915#9412])
[574]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17515/shard-rkl-6/igt@[email protected]
[575]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-rkl-2/igt@[email protected]
* igt@perf@mi-rpc:
- shard-rkl: [SKIP][576] ([i915#2434]) -> [SKIP][577] ([i915#14544] / [i915#2434])
[576]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17515/shard-rkl-3/igt@[email protected]
[577]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-rkl-6/igt@[email protected]
* igt@prime_vgem@basic-fence-read:
- shard-rkl: [SKIP][578] ([i915#14544] / [i915#3291] / [i915#3708]) -> [SKIP][579] ([i915#3291] / [i915#3708])
[578]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17515/shard-rkl-6/igt@[email protected]
[579]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-rkl-2/igt@[email protected]
* igt@prime_vgem@coherency-gtt:
- shard-rkl: [SKIP][580] ([i915#14544] / [i915#3708]) -> [SKIP][581] ([i915#3708]) +1 other test skip
[580]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17515/shard-rkl-6/igt@[email protected]
[581]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-rkl-5/igt@[email protected]
* igt@prime_vgem@fence-read-hang:
- shard-rkl: [SKIP][582] ([i915#3708]) -> [SKIP][583] ([i915#14544] / [i915#3708]) +1 other test skip
[582]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17515/shard-rkl-3/igt@[email protected]
[583]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-rkl-6/igt@[email protected]
* igt@sriov_basic@bind-unbind-vf:
- shard-rkl: [SKIP][584] ([i915#9917]) -> [SKIP][585] ([i915#14544] / [i915#9917])
[584]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17515/shard-rkl-5/igt@[email protected]
[585]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-rkl-6/igt@[email protected]
* igt@sriov_basic@enable-vfs-autoprobe-on:
- shard-rkl: [SKIP][586] ([i915#14544] / [i915#9917]) -> [SKIP][587] ([i915#9917])
[586]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17515/shard-rkl-6/igt@[email protected]
[587]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/shard-rkl-2/igt@[email protected]
[i915#10307]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10307
[i915#10433]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10433
[i915#10434]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10434
[i915#10656]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10656
[i915#1072]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/1072
[i915#11151]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/11151
[i915#11190]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/11190
[i915#11520]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/11520
[i915#11521]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/11521
[i915#11681]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/11681
[i915#12061]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12061
[i915#12247]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12247
[i915#12313]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12313
[i915#12339]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12339
[i915#12343]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12343
[i915#12358]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12358
[i915#12388]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12388
[i915#12392]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12392
[i915#12454]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12454
[i915#12549]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12549
[i915#12655]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12655
[i915#12712]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12712
[i915#12745]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12745
[i915#12755]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12755
[i915#12796]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12796
[i915#12805]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12805
[i915#12910]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12910
[i915#12916]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12916
[i915#12917]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12917
[i915#12964]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12964
[i915#13046]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/13046
[i915#13049]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/13049
[i915#13179]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/13179
[i915#13356]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/13356
[i915#13363]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/13363
[i915#13390]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/13390
[i915#13441]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/13441
[i915#13522]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/13522
[i915#13566]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/13566
[i915#13707]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/13707
[i915#13717]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/13717
[i915#13748]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/13748
[i915#13749]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/13749
[i915#13781]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/13781
[i915#13783]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/13783
[i915#13790]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/13790
[i915#13820]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/13820
[i915#13958]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/13958
[i915#14033]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/14033
[i915#14098]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/14098
[i915#14152]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/14152
[i915#14259]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/14259
[i915#14350]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/14350
[i915#14544]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/14544
[i915#15073]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/15073
[i915#15095]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/15095
[i915#15102]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/15102
[i915#15104]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/15104
[i915#15140]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/15140
[i915#15152]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/15152
[i915#15232]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/15232
[i915#1769]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/1769
[i915#1825]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/1825
[i915#1839]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/1839
[i915#1849]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/1849
[i915#1850]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/1850
[i915#2190]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/2190
[i915#2346]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/2346
[i915#2434]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/2434
[i915#2435]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/2435
[i915#2437]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/2437
[i915#2527]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/2527
[i915#2582]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/2582
[i915#2587]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/2587
[i915#2658]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/2658
[i915#2672]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/2672
[i915#2681]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/2681
[i915#2856]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/2856
[i915#3023]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3023
[i915#3116]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3116
[i915#3281]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3281
[i915#3282]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3282
[i915#3291]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3291
[i915#3297]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3297
[i915#3299]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3299
[i915#3323]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3323
[i915#3361]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3361
[i915#3458]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3458
[i915#3555]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3555
[i915#3637]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3637
[i915#3638]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3638
[i915#3708]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3708
[i915#3742]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3742
[i915#3828]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3828
[i915#3840]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3840
[i915#3955]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3955
[i915#4070]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4070
[i915#4077]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4077
[i915#4083]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4083
[i915#4103]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4103
[i915#4215]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4215
[i915#4270]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4270
[i915#4281]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4281
[i915#4349]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4349
[i915#4387]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4387
[i915#4423]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4423
[i915#4525]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4525
[i915#4538]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4538
[i915#4613]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4613
[i915#4771]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4771
[i915#4816]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4816
[i915#4817]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4817
[i915#4839]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4839
[i915#5138]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/5138
[i915#5190]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/5190
[i915#5286]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/5286
[i915#5289]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/5289
[i915#5354]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/5354
[i915#5439]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/5439
[i915#5493]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/5493
[i915#5723]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/5723
[i915#6095]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/6095
[i915#6245]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/6245
[i915#6334]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/6334
[i915#6335]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/6335
[i915#6412]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/6412
[i915#6524]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/6524
[i915#6590]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/6590
[i915#6806]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/6806
[i915#6944]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/6944
[i915#6953]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/6953
[i915#7116]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/7116
[i915#7118]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/7118
[i915#7162]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/7162
[i915#7173]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/7173
[i915#7294]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/7294
[i915#7582]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/7582
[i915#7697]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/7697
[i915#7707]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/7707
[i915#7828]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/7828
[i915#7882]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/7882
[i915#8152]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/8152
[i915#8228]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/8228
[i915#8381]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/8381
[i915#8411]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/8411
[i915#8428]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/8428
[i915#8430]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/8430
[i915#8708]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/8708
[i915#8807]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/8807
[i915#8814]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/8814
[i915#8825]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/8825
[i915#8826]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/8826
[i915#9067]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9067
[i915#9323]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9323
[i915#9337]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9337
[i915#9340]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9340
[i915#9412]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9412
[i915#9423]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9423
[i915#9424]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9424
[i915#9581]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9581
[i915#9683]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9683
[i915#9685]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9685
[i915#9688]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9688
[i915#9723]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9723
[i915#9732]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9732
[i915#9766]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9766
[i915#9812]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9812
[i915#9833]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9833
[i915#9906]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9906
[i915#9917]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9917
[i915#9934]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9934
Build changes
-------------
* Linux: CI_DRM_17515 -> Patchwork_155952v4
CI-20190529: 20190529
CI_DRM_17515: 2bc418aa7efaae562e49d84e8b28f799cf624745 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_8614: 8614
Patchwork_155952v4: 2bc418aa7efaae562e49d84e8b28f799cf624745 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_155952v4/index.html
Patchwork
CI✗ Xe.CI.Full: failure for drm/i915/display: Add initial support for Xe3p_LPD (rev4)
In reply to Gustavo Sousa== Series Details ==
== Series Details ==
Series: drm/i915/display: Add initial support for Xe3p_LPD (rev4)
URL : https://patchwork.freedesktop.org/series/155951/
State : failure
== Summary ==
CI Bug Log - changes from xe-4074-2bc418aa7efaae562e49d84e8b28f799cf624745_FULL -> xe-pw-155951v4_FULL
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with xe-pw-155951v4_FULL absolutely need to be verified manually.
If you think the reported changes have nothing to do with the changes
introduced in xe-pw-155951v4_FULL, please notify your bug team ([email protected]) to allow them to document this new failure mode, which will reduce false positives in CI.
Participating hosts (4 -> 4)
------------------------------
No changes in participating hosts
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in xe-pw-155951v4_FULL:
### IGT changes ###
#### Possible regressions ####
* igt@xe_module_load@load:
- shard-bmg: ([PASS][1], [PASS][2], [PASS][3], [PASS][4], [PASS][5], [PASS][6], [PASS][7], [PASS][8], [PASS][9], [PASS][10], [PASS][11], [PASS][12], [PASS][13], [PASS][14], [PASS][15], [PASS][16], [PASS][17], [PASS][18], [PASS][19]) -> ([DMESG-WARN][20], [DMESG-WARN][21], [DMESG-WARN][22], [DMESG-WARN][23], [DMESG-WARN][24], [DMESG-WARN][25], [DMESG-WARN][26], [DMESG-WARN][27], [DMESG-WARN][28], [DMESG-WARN][29], [DMESG-WARN][30], [DMESG-WARN][31], [DMESG-WARN][32], [DMESG-WARN][33], [DMESG-WARN][34], [DMESG-WARN][35], [DMESG-WARN][36], [DMESG-WARN][37], [DMESG-WARN][38], [DMESG-WARN][39], [DMESG-WARN][40], [DMESG-WARN][41], [DMESG-WARN][42])
[1]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4074-2bc418aa7efaae562e49d84e8b28f799cf624745/shard-bmg-6/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4074-2bc418aa7efaae562e49d84e8b28f799cf624745/shard-bmg-2/igt@[email protected]
[3]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4074-2bc418aa7efaae562e49d84e8b28f799cf624745/shard-bmg-6/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4074-2bc418aa7efaae562e49d84e8b28f799cf624745/shard-bmg-4/igt@[email protected]
[5]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4074-2bc418aa7efaae562e49d84e8b28f799cf624745/shard-bmg-4/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4074-2bc418aa7efaae562e49d84e8b28f799cf624745/shard-bmg-4/igt@[email protected]
[7]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4074-2bc418aa7efaae562e49d84e8b28f799cf624745/shard-bmg-8/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4074-2bc418aa7efaae562e49d84e8b28f799cf624745/shard-bmg-8/igt@[email protected]
[9]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4074-2bc418aa7efaae562e49d84e8b28f799cf624745/shard-bmg-1/igt@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4074-2bc418aa7efaae562e49d84e8b28f799cf624745/shard-bmg-1/igt@[email protected]
[11]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4074-2bc418aa7efaae562e49d84e8b28f799cf624745/shard-bmg-1/igt@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4074-2bc418aa7efaae562e49d84e8b28f799cf624745/shard-bmg-7/igt@[email protected]
[13]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4074-2bc418aa7efaae562e49d84e8b28f799cf624745/shard-bmg-7/igt@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4074-2bc418aa7efaae562e49d84e8b28f799cf624745/shard-bmg-2/igt@[email protected]
[15]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4074-2bc418aa7efaae562e49d84e8b28f799cf624745/shard-bmg-5/igt@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4074-2bc418aa7efaae562e49d84e8b28f799cf624745/shard-bmg-1/igt@[email protected]
[17]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4074-2bc418aa7efaae562e49d84e8b28f799cf624745/shard-bmg-5/igt@[email protected]
[18]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4074-2bc418aa7efaae562e49d84e8b28f799cf624745/shard-bmg-6/igt@[email protected]
[19]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4074-2bc418aa7efaae562e49d84e8b28f799cf624745/shard-bmg-8/igt@[email protected]
[20]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155951v4/shard-bmg-4/igt@[email protected]
[21]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155951v4/shard-bmg-4/igt@[email protected]
[22]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155951v4/shard-bmg-4/igt@[email protected]
[23]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155951v4/shard-bmg-6/igt@[email protected]
[24]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155951v4/shard-bmg-6/igt@[email protected]
[25]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155951v4/shard-bmg-6/igt@[email protected]
[26]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155951v4/shard-bmg-6/igt@[email protected]
[27]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155951v4/shard-bmg-5/igt@[email protected]
[28]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155951v4/shard-bmg-8/igt@[email protected]
[29]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155951v4/shard-bmg-8/igt@[email protected]
[30]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155951v4/shard-bmg-7/igt@[email protected]
[31]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155951v4/shard-bmg-7/igt@[email protected]
[32]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155951v4/shard-bmg-7/igt@[email protected]
[33]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155951v4/shard-bmg-7/igt@[email protected]
[34]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155951v4/shard-bmg-8/igt@[email protected]
[35]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155951v4/shard-bmg-1/igt@[email protected]
[36]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155951v4/shard-bmg-1/igt@[email protected]
[37]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155951v4/shard-bmg-1/igt@[email protected]
[38]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155951v4/shard-bmg-1/igt@[email protected]
[39]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155951v4/shard-bmg-2/igt@[email protected]
[40]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155951v4/shard-bmg-2/igt@[email protected]
[41]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155951v4/shard-bmg-2/igt@[email protected]
[42]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155951v4/shard-bmg-5/igt@[email protected]
Known issues
------------
Here are the changes found in xe-pw-155951v4_FULL that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@kms_async_flips@async-flip-dpms@pipe-a-hdmi-a-1:
- shard-adlp: [PASS][43] -> [DMESG-WARN][44] ([Intel XE#2953] / [Intel XE#4173]) +2 other tests dmesg-warn
[43]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4074-2bc418aa7efaae562e49d84e8b28f799cf624745/shard-adlp-1/igt@kms_async_flips@[email protected]
[44]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155951v4/shard-adlp-1/igt@kms_async_flips@[email protected]
* igt@kms_big_fb@x-tiled-16bpp-rotate-270:
- shard-dg2-set2: NOTRUN -> [SKIP][45] ([Intel XE#316]) +2 other tests skip
[45]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155951v4/shard-dg2-466/igt@[email protected]
* igt@kms_big_fb@y-tiled-max-hw-stride-64bpp-rotate-180-hflip-async-flip:
- shard-adlp: [PASS][46] -> [DMESG-FAIL][47] ([Intel XE#4543]) +1 other test dmesg-fail
[46]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4074-2bc418aa7efaae562e49d84e8b28f799cf624745/shard-adlp-6/igt@kms_big_fb@y-tiled-max-hw-stride-64bpp-rotate-180-hflip-async-flip.html
[47]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155951v4/shard-adlp-1/igt@kms_big_fb@y-tiled-max-hw-stride-64bpp-rotate-180-hflip-async-flip.html
* igt@kms_big_fb@yf-tiled-addfb:
- shard-dg2-set2: NOTRUN -> [SKIP][48] ([Intel XE#619])
[48]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155951v4/shard-dg2-433/igt@[email protected]
* igt@kms_big_fb@yf-tiled-max-hw-stride-64bpp-rotate-180-hflip-async-flip:
- shard-dg2-set2: NOTRUN -> [SKIP][49] ([Intel XE#1124]) +7 other tests skip
[49]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155951v4/shard-dg2-466/igt@kms_big_fb@yf-tiled-max-hw-stride-64bpp-rotate-180-hflip-async-flip.html
* igt@kms_bw@linear-tiling-1-displays-2560x1440p:
- shard-dg2-set2: NOTRUN -> [SKIP][50] ([Intel XE#367]) +1 other test skip
[50]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155951v4/shard-dg2-433/igt@[email protected]
* igt@kms_ccs@bad-pixel-format-yf-tiled-ccs:
- shard-dg2-set2: NOTRUN -> [SKIP][51] ([Intel XE#455] / [Intel XE#787]) +27 other tests skip
[51]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155951v4/shard-dg2-464/igt@[email protected]
* igt@kms_ccs@bad-rotation-90-4-tiled-lnl-ccs:
- shard-dg2-set2: NOTRUN -> [SKIP][52] ([Intel XE#2907])
[52]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155951v4/shard-dg2-435/igt@[email protected]
* igt@kms_ccs@random-ccs-data-yf-tiled-ccs@pipe-b-dp-4:
- shard-dg2-set2: NOTRUN -> [SKIP][53] ([Intel XE#787]) +90 other tests skip
[53]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155951v4/shard-dg2-464/igt@kms_ccs@[email protected]
* igt@kms_chamelium_color@ctm-blue-to-red:
- shard-dg2-set2: NOTRUN -> [SKIP][54] ([Intel XE#306])
[54]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155951v4/shard-dg2-433/igt@[email protected]
* igt@kms_chamelium_hpd@vga-hpd-without-ddc:
- shard-dg2-set2: NOTRUN -> [SKIP][55] ([Intel XE#373]) +9 other tests skip
[55]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155951v4/shard-dg2-466/igt@[email protected]
* igt@kms_chamelium_sharpness_filter@filter-basic:
- shard-dg2-set2: NOTRUN -> [SKIP][56] ([Intel XE#6507])
[56]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155951v4/shard-dg2-433/igt@[email protected]
* igt@kms_content_protection@atomic:
- shard-dg2-set2: NOTRUN -> [FAIL][57] ([Intel XE#1178]) +1 other test fail
[57]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155951v4/shard-dg2-433/igt@[email protected]
* igt@kms_content_protection@dp-mst-type-0:
- shard-dg2-set2: NOTRUN -> [SKIP][58] ([Intel XE#307])
[58]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155951v4/shard-dg2-466/igt@[email protected]
* igt@kms_cursor_crc@cursor-sliding-512x512:
- shard-dg2-set2: NOTRUN -> [SKIP][59] ([Intel XE#308]) +2 other tests skip
[59]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155951v4/shard-dg2-435/igt@[email protected]
* igt@kms_cursor_legacy@short-busy-flip-before-cursor-atomic-transitions:
- shard-dg2-set2: NOTRUN -> [SKIP][60] ([Intel XE#323])
[60]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155951v4/shard-dg2-466/igt@kms_cursor_legacy@short-busy-flip-before-cursor-atomic-transitions.html
* igt@kms_dp_link_training@non-uhbr-mst:
- shard-dg2-set2: NOTRUN -> [SKIP][61] ([Intel XE#4354])
[61]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155951v4/shard-dg2-466/igt@[email protected]
* igt@kms_dp_linktrain_fallback@dsc-fallback:
- shard-dg2-set2: NOTRUN -> [SKIP][62] ([Intel XE#4331])
[62]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155951v4/shard-dg2-464/igt@[email protected]
* igt@kms_dsc@dsc-with-output-formats-with-bpc:
- shard-dg2-set2: NOTRUN -> [SKIP][63] ([Intel XE#455]) +17 other tests skip
[63]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155951v4/shard-dg2-464/igt@[email protected]
* igt@kms_feature_discovery@psr2:
- shard-dg2-set2: NOTRUN -> [SKIP][64] ([Intel XE#1135])
[64]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155951v4/shard-dg2-433/igt@[email protected]
* igt@kms_flip@flip-vs-expired-vblank@c-edp1:
- shard-lnl: [PASS][65] -> [FAIL][66] ([Intel XE#301] / [Intel XE#3149]) +1 other test fail
[65]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4074-2bc418aa7efaae562e49d84e8b28f799cf624745/shard-lnl-1/igt@kms_flip@[email protected]
[66]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155951v4/shard-lnl-7/igt@kms_flip@[email protected]
* igt@kms_flip@plain-flip-ts-check@b-hdmi-a1:
- shard-adlp: [PASS][67] -> [DMESG-WARN][68] ([Intel XE#4543])
[67]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4074-2bc418aa7efaae562e49d84e8b28f799cf624745/shard-adlp-8/igt@kms_flip@[email protected]
[68]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155951v4/shard-adlp-4/igt@kms_flip@[email protected]
* igt@kms_frontbuffer_tracking@fbcdrrs-1p-offscreen-pri-indfb-draw-mmap-wc:
- shard-dg2-set2: NOTRUN -> [SKIP][69] ([Intel XE#6312]) +8 other tests skip
[69]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155951v4/shard-dg2-435/igt@kms_frontbuffer_tracking@fbcdrrs-1p-offscreen-pri-indfb-draw-mmap-wc.html
* igt@kms_frontbuffer_tracking@fbcdrrs-1p-rte:
- shard-dg2-set2: NOTRUN -> [SKIP][70] ([Intel XE#651]) +28 other tests skip
[70]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155951v4/shard-dg2-435/igt@[email protected]
* igt@kms_frontbuffer_tracking@fbcdrrs-tiling-y:
- shard-dg2-set2: NOTRUN -> [SKIP][71] ([Intel XE#658])
[71]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155951v4/shard-dg2-433/igt@[email protected]
* igt@kms_frontbuffer_tracking@psr-2p-primscrn-pri-indfb-draw-blt:
- shard-dg2-set2: NOTRUN -> [SKIP][72] ([Intel XE#653]) +26 other tests skip
[72]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155951v4/shard-dg2-466/igt@[email protected]
* igt@kms_hdr@invalid-hdr:
- shard-dg2-set2: [PASS][73] -> [SKIP][74] ([Intel XE#455])
[73]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4074-2bc418aa7efaae562e49d84e8b28f799cf624745/shard-dg2-463/igt@[email protected]
[74]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155951v4/shard-dg2-436/igt@[email protected]
* igt@kms_joiner@basic-ultra-joiner:
- shard-dg2-set2: NOTRUN -> [SKIP][75] ([Intel XE#2927])
[75]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155951v4/shard-dg2-433/igt@[email protected]
* igt@kms_pipe_stress@stress-xrgb8888-yftiled:
- shard-dg2-set2: NOTRUN -> [SKIP][76] ([Intel XE#5624])
[76]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155951v4/shard-dg2-466/igt@[email protected]
* igt@kms_pm_backlight@fade-with-suspend:
- shard-dg2-set2: NOTRUN -> [SKIP][77] ([Intel XE#870]) +1 other test skip
[77]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155951v4/shard-dg2-435/igt@[email protected]
* igt@kms_psr2_sf@fbc-pr-plane-move-sf-dmg-area:
- shard-dg2-set2: NOTRUN -> [SKIP][78] ([Intel XE#1406] / [Intel XE#1489]) +9 other tests skip
[78]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155951v4/shard-dg2-466/igt@[email protected]
* igt@kms_psr@fbc-pr-dpms:
- shard-dg2-set2: NOTRUN -> [SKIP][79] ([Intel XE#1406] / [Intel XE#2850] / [Intel XE#929]) +17 other tests skip
[79]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155951v4/shard-dg2-432/igt@[email protected]
* igt@kms_rotation_crc@bad-tiling:
- shard-dg2-set2: NOTRUN -> [SKIP][80] ([Intel XE#3414]) +2 other tests skip
[80]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155951v4/shard-dg2-435/igt@[email protected]
* igt@kms_tiled_display@basic-test-pattern:
- shard-dg2-set2: NOTRUN -> [FAIL][81] ([Intel XE#1729])
[81]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155951v4/shard-dg2-466/igt@[email protected]
* igt@kms_tv_load_detect@load-detect:
- shard-dg2-set2: NOTRUN -> [SKIP][82] ([Intel XE#330])
[82]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155951v4/shard-dg2-433/igt@[email protected]
* igt@kms_vrr@cmrr:
- shard-dg2-set2: NOTRUN -> [SKIP][83] ([Intel XE#2168])
[83]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155951v4/shard-dg2-466/igt@[email protected]
* igt@xe_copy_basic@mem-set-linear-0x369:
- shard-dg2-set2: NOTRUN -> [SKIP][84] ([Intel XE#1126])
[84]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155951v4/shard-dg2-466/igt@[email protected]
* igt@xe_copy_basic@mem-set-linear-0x8fffe:
- shard-dg2-set2: NOTRUN -> [SKIP][85] ([Intel XE#5503])
[85]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155951v4/shard-dg2-466/igt@[email protected]
* igt@xe_eu_stall@invalid-event-report-count:
- shard-dg2-set2: NOTRUN -> [SKIP][86] ([Intel XE#5626])
[86]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155951v4/shard-dg2-466/igt@[email protected]
* igt@xe_eudebug@vm-bind-clear-faultable:
- shard-dg2-set2: NOTRUN -> [SKIP][87] ([Intel XE#4837]) +17 other tests skip
[87]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155951v4/shard-dg2-463/igt@[email protected]
* igt@xe_exec_fault_mode@once-invalid-userptr-fault:
- shard-dg2-set2: NOTRUN -> [SKIP][88] ([Intel XE#288]) +28 other tests skip
[88]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155951v4/shard-dg2-466/igt@[email protected]
* igt@xe_exec_mix_modes@exec-spinner-interrupted-dma-fence:
- shard-dg2-set2: NOTRUN -> [SKIP][89] ([Intel XE#2360]) +1 other test skip
[89]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155951v4/shard-dg2-466/igt@[email protected]
* igt@xe_exec_system_allocator@threads-many-large-mmap-shared-remap-dontunmap-eocheck:
- shard-dg2-set2: NOTRUN -> [SKIP][90] ([Intel XE#4915]) +344 other tests skip
[90]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155951v4/shard-dg2-466/igt@xe_exec_system_allocator@threads-many-large-mmap-shared-remap-dontunmap-eocheck.html
* igt@xe_live_ktest@xe_migrate@xe_validate_ccs_kunit:
- shard-dg2-set2: NOTRUN -> [SKIP][91] ([Intel XE#2229])
[91]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155951v4/shard-dg2-433/igt@xe_live_ktest@xe_migrate@xe_validate_ccs_kunit.html
* igt@xe_module_load@force-load:
- shard-dg2-set2: NOTRUN -> [SKIP][92] ([Intel XE#378])
[92]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155951v4/shard-dg2-433/igt@[email protected]
* igt@xe_oa@syncs-userptr-wait-cfg:
- shard-dg2-set2: NOTRUN -> [SKIP][93] ([Intel XE#3573]) +6 other tests skip
[93]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155951v4/shard-dg2-466/igt@[email protected]
* igt@xe_pat@display-vs-wb-transient:
- shard-dg2-set2: NOTRUN -> [SKIP][94] ([Intel XE#1337])
[94]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155951v4/shard-dg2-435/igt@[email protected]
* igt@xe_pat@pat-index-xelpg:
- shard-dg2-set2: NOTRUN -> [SKIP][95] ([Intel XE#979])
[95]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155951v4/shard-dg2-433/igt@[email protected]
* igt@xe_pm@s2idle-d3cold-basic-exec:
- shard-dg2-set2: NOTRUN -> [SKIP][96] ([Intel XE#2284] / [Intel XE#366])
[96]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155951v4/shard-dg2-435/igt@[email protected]
* igt@xe_pmu@engine-activity-accuracy-90@engine-drm_xe_engine_class_video_decode0:
- shard-lnl: [PASS][97] -> [FAIL][98] ([Intel XE#6251]) +2 other tests fail
[97]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4074-2bc418aa7efaae562e49d84e8b28f799cf624745/shard-lnl-2/igt@xe_pmu@engine-activity-accuracy-90@engine-drm_xe_engine_class_video_decode0.html
[98]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155951v4/shard-lnl-2/igt@xe_pmu@engine-activity-accuracy-90@engine-drm_xe_engine_class_video_decode0.html
* igt@xe_pmu@fn-engine-activity-load:
- shard-dg2-set2: NOTRUN -> [SKIP][99] ([Intel XE#4650])
[99]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155951v4/shard-dg2-435/igt@[email protected]
* igt@xe_pmu@gt-c6-idle:
- shard-dg2-set2: NOTRUN -> [FAIL][100] ([Intel XE#6366])
[100]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155951v4/shard-dg2-433/igt@[email protected]
* igt@xe_pmu@gt-frequency:
- shard-dg2-set2: [PASS][101] -> [FAIL][102] ([Intel XE#4819]) +1 other test fail
[101]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4074-2bc418aa7efaae562e49d84e8b28f799cf624745/shard-dg2-464/igt@[email protected]
[102]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155951v4/shard-dg2-434/igt@[email protected]
* igt@xe_pxp@pxp-stale-bo-bind-post-rpm:
- shard-dg2-set2: NOTRUN -> [SKIP][103] ([Intel XE#4733]) +2 other tests skip
[103]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155951v4/shard-dg2-466/igt@[email protected]
* igt@xe_query@multigpu-query-cs-cycles:
- shard-dg2-set2: NOTRUN -> [SKIP][104] ([Intel XE#944]) +1 other test skip
[104]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155951v4/shard-dg2-466/igt@[email protected]
* igt@xe_render_copy@render-stress-2-copies:
- shard-dg2-set2: NOTRUN -> [SKIP][105] ([Intel XE#4814])
[105]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155951v4/shard-dg2-433/igt@[email protected]
* igt@xe_sriov_flr@flr-each-isolation:
- shard-dg2-set2: NOTRUN -> [SKIP][106] ([Intel XE#3342])
[106]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155951v4/shard-dg2-435/igt@[email protected]
* igt@xe_sriov_flr@flr-vfs-parallel:
- shard-dg2-set2: NOTRUN -> [SKIP][107] ([Intel XE#4273])
[107]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155951v4/shard-dg2-433/igt@[email protected]
* igt@xe_sriov_vram@vf-access-after-resize-down:
- shard-dg2-set2: NOTRUN -> [SKIP][108] ([Intel XE#6318])
[108]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155951v4/shard-dg2-464/igt@[email protected]
* igt@xe_survivability@runtime-survivability:
- shard-dg2-set2: NOTRUN -> [SKIP][109] ([Intel XE#6529])
[109]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155951v4/shard-dg2-464/igt@[email protected]
#### Possible fixes ####
* igt@kms_ccs@random-ccs-data-4-tiled-dg2-mc-ccs@pipe-b-dp-4:
- shard-dg2-set2: [INCOMPLETE][110] ([Intel XE#1727] / [Intel XE#3113] / [Intel XE#4212] / [Intel XE#4345] / [Intel XE#4522]) -> [PASS][111] +1 other test pass
[110]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4074-2bc418aa7efaae562e49d84e8b28f799cf624745/shard-dg2-464/igt@kms_ccs@[email protected]
[111]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155951v4/shard-dg2-435/igt@kms_ccs@[email protected]
* igt@kms_ccs@random-ccs-data-4-tiled-dg2-rc-ccs:
- shard-dg2-set2: [INCOMPLETE][112] ([Intel XE#2705] / [Intel XE#4212] / [Intel XE#4345]) -> [PASS][113]
[112]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4074-2bc418aa7efaae562e49d84e8b28f799cf624745/shard-dg2-433/igt@[email protected]
[113]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155951v4/shard-dg2-432/igt@[email protected]
* igt@kms_ccs@random-ccs-data-4-tiled-dg2-rc-ccs-cc:
- shard-dg2-set2: [INCOMPLETE][114] ([Intel XE#1727] / [Intel XE#3113] / [Intel XE#4345]) -> [PASS][115]
[114]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4074-2bc418aa7efaae562e49d84e8b28f799cf624745/shard-dg2-435/igt@[email protected]
[115]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155951v4/shard-dg2-466/igt@[email protected]
* igt@kms_ccs@random-ccs-data-4-tiled-dg2-rc-ccs-cc@pipe-c-hdmi-a-6:
- shard-dg2-set2: [INCOMPLETE][116] ([Intel XE#1727] / [Intel XE#3113]) -> [PASS][117]
[116]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4074-2bc418aa7efaae562e49d84e8b28f799cf624745/shard-dg2-435/igt@kms_ccs@[email protected]
[117]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155951v4/shard-dg2-466/igt@kms_ccs@[email protected]
* igt@kms_ccs@random-ccs-data-4-tiled-dg2-rc-ccs@pipe-c-dp-4:
- shard-dg2-set2: [INCOMPLETE][118] ([Intel XE#2705] / [Intel XE#4212]) -> [PASS][119]
[118]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4074-2bc418aa7efaae562e49d84e8b28f799cf624745/shard-dg2-433/igt@kms_ccs@[email protected]
[119]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155951v4/shard-dg2-432/igt@kms_ccs@[email protected]
* igt@kms_cursor_crc@cursor-suspend@pipe-a-hdmi-a-1:
- shard-adlp: [DMESG-WARN][120] ([Intel XE#2953] / [Intel XE#4173]) -> [PASS][121] +3 other tests pass
[120]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4074-2bc418aa7efaae562e49d84e8b28f799cf624745/shard-adlp-8/igt@kms_cursor_crc@[email protected]
[121]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155951v4/shard-adlp-4/igt@kms_cursor_crc@[email protected]
* igt@kms_flip@flip-vs-expired-vblank-interruptible:
- shard-dg2-set2: [FAIL][122] ([Intel XE#301]) -> [PASS][123] +1 other test pass
[122]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4074-2bc418aa7efaae562e49d84e8b28f799cf624745/shard-dg2-436/igt@[email protected]
[123]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155951v4/shard-dg2-463/igt@[email protected]
* igt@kms_flip@flip-vs-expired-vblank@b-hdmi-a1:
- shard-adlp: [DMESG-WARN][124] ([Intel XE#4543]) -> [PASS][125]
[124]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4074-2bc418aa7efaae562e49d84e8b28f799cf624745/shard-adlp-8/igt@kms_flip@[email protected]
[125]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155951v4/shard-adlp-8/igt@kms_flip@[email protected]
* igt@xe_exec_basic@multigpu-many-execqueues-many-vm-bindexecqueue-rebind:
- shard-dg2-set2: [INCOMPLETE][126] ([Intel XE#4842]) -> [PASS][127]
[126]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4074-2bc418aa7efaae562e49d84e8b28f799cf624745/shard-dg2-466/igt@xe_exec_basic@multigpu-many-execqueues-many-vm-bindexecqueue-rebind.html
[127]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155951v4/shard-dg2-433/igt@xe_exec_basic@multigpu-many-execqueues-many-vm-bindexecqueue-rebind.html
* igt@xe_exec_system_allocator@pat-index-madvise-pat-idx-uc-single-vma:
- shard-lnl: [FAIL][128] ([Intel XE#5625]) -> [PASS][129]
[128]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4074-2bc418aa7efaae562e49d84e8b28f799cf624745/shard-lnl-4/igt@xe_exec_system_allocator@pat-index-madvise-pat-idx-uc-single-vma.html
[129]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155951v4/shard-lnl-3/igt@xe_exec_system_allocator@pat-index-madvise-pat-idx-uc-single-vma.html
* igt@xe_fault_injection@probe-fail-guc-xe_guc_mmio_send_recv:
- shard-dg2-set2: [DMESG-WARN][130] ([Intel XE#5893]) -> [PASS][131] +1 other test pass
[130]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4074-2bc418aa7efaae562e49d84e8b28f799cf624745/shard-dg2-466/igt@xe_fault_injection@probe-fail-guc-xe_guc_mmio_send_recv.html
[131]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155951v4/shard-dg2-433/igt@xe_fault_injection@probe-fail-guc-xe_guc_mmio_send_recv.html
* igt@xe_pm@s4-multiple-execs:
- shard-dg2-set2: [ABORT][132] -> [PASS][133]
[132]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4074-2bc418aa7efaae562e49d84e8b28f799cf624745/shard-dg2-434/igt@[email protected]
[133]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155951v4/shard-dg2-463/igt@[email protected]
* igt@xe_pmu@engine-activity-accuracy-50@engine-drm_xe_engine_class_video_decode0:
- shard-lnl: [FAIL][134] -> [PASS][135]
[134]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4074-2bc418aa7efaae562e49d84e8b28f799cf624745/shard-lnl-3/igt@xe_pmu@engine-activity-accuracy-50@engine-drm_xe_engine_class_video_decode0.html
[135]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155951v4/shard-lnl-8/igt@xe_pmu@engine-activity-accuracy-50@engine-drm_xe_engine_class_video_decode0.html
* igt@xe_pmu@engine-activity-accuracy-90@engine-drm_xe_engine_class_video_enhance0:
- shard-lnl: [FAIL][136] ([Intel XE#6251]) -> [PASS][137] +1 other test pass
[136]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4074-2bc418aa7efaae562e49d84e8b28f799cf624745/shard-lnl-2/igt@xe_pmu@engine-activity-accuracy-90@engine-drm_xe_engine_class_video_enhance0.html
[137]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155951v4/shard-lnl-2/igt@xe_pmu@engine-activity-accuracy-90@engine-drm_xe_engine_class_video_enhance0.html
#### Warnings ####
* igt@kms_vrr@seamless-rr-switch-virtual@pipe-a-edp-1:
- shard-lnl: [FAIL][138] ([Intel XE#5862]) -> [FAIL][139] ([Intel XE#5862] / [Intel XE#6554]) +1 other test fail
[138]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4074-2bc418aa7efaae562e49d84e8b28f799cf624745/shard-lnl-8/igt@kms_vrr@[email protected]
[139]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155951v4/shard-lnl-5/igt@kms_vrr@[email protected]
[Intel XE#1124]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1124
[Intel XE#1126]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1126
[Intel XE#1135]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1135
[Intel XE#1178]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1178
[Intel XE#1337]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1337
[Intel XE#1406]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1406
[Intel XE#1489]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1489
[Intel XE#1727]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1727
[Intel XE#1729]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1729
[Intel XE#2168]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2168
[Intel XE#2229]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2229
[Intel XE#2284]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2284
[Intel XE#2360]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2360
[Intel XE#2705]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2705
[Intel XE#2850]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2850
[Intel XE#288]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/288
[Intel XE#2907]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2907
[Intel XE#2927]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2927
[Intel XE#2953]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2953
[Intel XE#301]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/301
[Intel XE#306]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/306
[Intel XE#307]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/307
[Intel XE#308]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/308
[Intel XE#3113]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/3113
[Intel XE#3149]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/3149
[Intel XE#316]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/316
[Intel XE#323]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/323
[Intel XE#330]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/330
[Intel XE#3342]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/3342
[Intel XE#3414]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/3414
[Intel XE#3573]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/3573
[Intel XE#366]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/366
[Intel XE#367]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/367
[Intel XE#373]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/373
[Intel XE#378]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/378
[Intel XE#4173]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/4173
[Intel XE#4212]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/4212
[Intel XE#4273]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/4273
[Intel XE#4331]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/4331
[Intel XE#4345]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/4345
[Intel XE#4354]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/4354
[Intel XE#4522]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/4522
[Intel XE#4543]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/4543
[Intel XE#455]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/455
[Intel XE#4650]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/4650
[Intel XE#4733]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/4733
[Intel XE#4814]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/4814
[Intel XE#4819]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/4819
[Intel XE#4837]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/4837
[Intel XE#4842]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/4842
[Intel XE#4915]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/4915
[Intel XE#5503]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/5503
[Intel XE#5624]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/5624
[Intel XE#5625]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/5625
[Intel XE#5626]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/5626
[Intel XE#5862]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/5862
[Intel XE#5893]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/5893
[Intel XE#619]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/619
[Intel XE#6251]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/6251
[Intel XE#6312]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/6312
[Intel XE#6318]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/6318
[Intel XE#6366]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/6366
[Intel XE#6507]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/6507
[Intel XE#651]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/651
[Intel XE#6529]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/6529
[Intel XE#653]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/653
[Intel XE#6554]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/6554
[Intel XE#658]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/658
[Intel XE#787]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/787
[Intel XE#870]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/870
[Intel XE#929]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/929
[Intel XE#944]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/944
[Intel XE#979]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/979
Build changes
-------------
* Linux: xe-4074-2bc418aa7efaae562e49d84e8b28f799cf624745 -> xe-pw-155951v4
IGT_8614: 8614
xe-4074-2bc418aa7efaae562e49d84e8b28f799cf624745: 2bc418aa7efaae562e49d84e8b28f799cf624745
xe-pw-155951v4: 155951v4
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155951v4/index.html