bpf: a few missing checks to avoid verbose verifier log
Eduard Zingerman
maintainerPATCH 1/1 bpf: a few missing checks to avoid verbose verifier log
There are a few places where log level is not checked before calling "verbose()". This forces programs working only at BPF_LOG_LEVEL_STATS (e.g. veristat) to allocate unnecessarily large log buffers.
Reported-by Emil Tsalapatis <[email protected]>
Signed-off-by Eduard Zingerman <[email protected]>
--- kernel/bpf/verifier.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-)
kernel/bpf/verifier.c +6 -4
@@ -10720,8 +10720,9 @@ static int check_func_call(struct bpf_verifier_env *env, struct bpf_insn *insn,return err; } -verbose (env,"Func#%d ('%s') is global and assumed valid.\n" , - subprog, sub_name); +if (env->log.level &BPF_LOG_LEVEL ) +verbose (env,"Func#%d ('%s') is global and assumed valid.\n" , + subprog, sub_name);if (env->subprog_info[subprog].changes_pkt_data)clear_all_pkt_pointers (env);/* mark global subprog for verifying after main prog */
@@ -19470,7 +19471,7 @@ static int propagate_precision(struct bpf_verifier_env *env,bt_set_frame_slot (&env->bt, fr, i); first = false; } -if (!first) +if (!first && (env->log.level &BPF_LOG_LEVEL2 ))verbose (env,"\n" ); }
@@ -23698,7 +23699,8 @@ static int do_check_common(struct bpf_verifier_env *env, int subprog)struct bpf_subprog_arg_info *arg;struct bpf_reg_state *reg; -verbose (env,"Validating %s() func#%d...\n" , sub_name, subprog); +if (env->log.level &BPF_LOG_LEVEL ) +verbose (env,"Validating %s() func#%d...\n" , sub_name, subprog); ret =btf_prepare_func_args (env, subprog);if (ret) goto out;
Signature · 1 line
2.51.1
This patch was applied to bpf/bpf-next.git (master) by Alexei Starovoitov <[email protected]>:
Hello:
This patch was applied to bpf/bpf-next.git (master) by Alexei Starovoitov <[email protected]>:
Quoted 9 lines · On Fri, 14 Nov 2025 12:05:42 -0800 you wrote:
There are a few places where log level is not checked before calling "
verbose()". This forces programs working only atBPF_LOG_LEVEL_STATS(e.g. veristat) to allocate unnecessarily large log buffers.Reported-by Emil Tsalapatis <[email protected]>Signed-off-by Eduard Zingerman <[email protected]>[...]
Here is the summary with links:
- [bpf-next,v1] bpf: a few missing checks to avoid verbose verifier log
https://git.kernel.org/bpf/bpf-next/c/e5d2e34e726b
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html