Skip to contentSkip to conversation

2.6.18-rc5-mm1, make oldconfig from 2.6.18-rc5 destroys LVM

DISCUSSION John Stoffel 2 participants 3 messages Sep 3, 2006

lore
Share & tools
lore
#0 lore raw

Andrew,

When I do a make oldconfig under 2.6.18-rc5-mm1, with my working 2.6.18-rc5 .config file (appended below), all the LVM and MD stuff gets blown away silently. It looks like the drivers/md/Kconfig didn't get updated properly when it was tweaked, possibly the new options to get rid of BLOCK devices, or the ripping out of LVM1 stuff.

It looks like instead of 'if CONFIG_BLOCK' at the top, it just needs to be 'if BLOCK' instead.

And I'd really suggest that it NOT be this silly name BLOCK, something more meaningful, like USE_BLOCK_DEVICES or something equally useful to parse.

John

Signature · 1 line
VGER BF report: U 0.499836
#1 lore raw
Quoted 11 lines · On Sat, 2 Sep 2006 20:49:04 -0400 "John Stoffel" <[email protected]> wrote:

Andrew,

When I do a make oldconfig under 2.6.18-rc5-mm1, with my working 2.6.18-rc5 .config file (appended below), all the LVM and MD stuff gets blown away silently. It looks like the drivers/md/Kconfig didn't get updated properly when it was tweaked, possibly the new options to get rid of BLOCK devices, or the ripping out of LVM1 stuff.

It looks like instead of 'if CONFIG_BLOCK' at the top, it just needs to be 'if BLOCK' instead.

ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.18-rc5/2.6.18-rc5-mm1/hot-fixes/ contains a fix for this.

Quoted 3 lines

And I'd really suggest that it NOT be this silly name BLOCK, something more meaningful, like USE_BLOCK_DEVICES or something equally useful to parse.

mm... I think CONFIG_BLOCK is a reasonable compromise between the needs for brevity and understandability.

Signature · 1 line
VGER BF report: H 0.277375
#2 lore raw
Quoted 5 lines
Quoted 5 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Andrew" == Andrew Morton <[email protected]> writes:

And I'd really suggest that it NOT be this silly name BLOCK, something more meaningful, like USE_BLOCK_DEVICES or something equally useful to parse.

Andrew> mm... I think CONFIG_BLOCK is a reasonable compromise between Andrew> the needs for brevity and understandability.

Well, maybe the hotfix patch converts all the uses of 'if BLOCK' to 'if CONFIG_BLOCK', but I still think that 'if USE_BLOCK_DEVS' would be more clear. It's not like it should be all *that* used outside of config stuff.

Oh well, thanks for your reply, now I can test 2.6.18-rc5-mm1 and see if my IRQ problem is really there or not.

John

Signature · 1 line
VGER BF report: U 0.5