Skip to contentSkip to conversation

ASoC: sun4i-spdif: Add missing kerneldoc fields for sun4i_spdif_quirks

PATCH In review Chen-Yu Tsai 4 participants 4 messages Dec 21, 2025 – Dec 22, 2025

Subsystems (3)
lore
Share & tools
lore

Chen-Yu Tsai

author maintainer
#0 lore raw

PATCH 1/1 ASoC: sun4i-spdif: Add missing kerneldoc fields for sun4i_spdif_quirks

When sun4i_spdif_quirks was recently expanded, the kerneldoc covering the structure was not expanded to match. This ends up causing a warning when the documents are built.

Add the missing fields.

Fixes 0a2319308de8 ("ASoC: sun4i-spdif: Add clock multiplier settings")
Fixes 4a5ac6cd05a7 ("ASoC: sun4i-spdif: Support SPDIF output on A523 family")
---
 sound/soc/sunxi/sun4i-spdif.c | 2 ++
 1 file changed, 2 insertions(+)
sound/soc/sunxi/sun4i-spdif.c +2 -0
index 2e7ac8ab71bb..1e755a716c63 100644
@@ -171,6 +171,8 @@
  * @reg_dac_txdata: TX FIFO offset for DMA config.
  * @has_reset: SoC needs reset deasserted.
  * @val_fctl_ftx: TX FIFO flush bitmask.
+ * @mclk_multiplier: ratio of internal MCLK divider
+ * @tx_clk_name: name of TX module clock if split clock design
  */
 struct sun4i_spdif_quirks {
 	unsigned int reg_dac_txdata;
Signature · 1 line
2.47.3
Reviewed-by on v1 1/1
#1 lore raw
Quoted 5 lines · Chen-Yu Tsai

When sun4i_spdif_quirks was recently expanded, the kerneldoc covering the structure was not expanded to match. This ends up causing a warning when the documents are built.

Quoted 8 lines

Add the missing fields.

Fixes 0a2319308de8 ("ASoC: sun4i-spdif: Add clock multiplier settings")
Fixes 4a5ac6cd05a7 ("ASoC: sun4i-spdif: Support SPDIF output on A523 family")

Hi Wens,
thanks for fixing this up.

BR,
CK

Quoted 18 lines
---
 sound/soc/sunxi/sun4i-spdif.c | 2 ++
 1 file changed, 2 insertions(+)
sound/soc/sunxi/sun4i-spdif.c +2 -1
index 2e7ac8ab71bb..1e755a716c63 100644
@@ -171,6 +171,8 @@
  * @reg_dac_txdata: TX FIFO offset for DMA config.
  * @has_reset: SoC needs reset deasserted.
  * @val_fctl_ftx: TX FIFO flush bitmask.
+ * @mclk_multiplier: ratio of internal MCLK divider
+ * @tx_clk_name: name of TX module clock if split clock design
  */
 struct sun4i_spdif_quirks {
        unsigned int reg_dac_txdata;
--
Quoted 3 lines

2.47.3

<http://www.avg.com/email-signature?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail>
Virus-free.www.avg.com
<http://www.avg.com/email-signature?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail>
<#DAB4FAD8-2DD7-40BB-A1B8-4E2AA1F9FDF2>

maintainer Acked-by on v1 1/1
#2 lore raw
In reply to Chen-Yu Tsai

Dne nedelja, 21. december 2025 ob 04:57:13 Srednjeevropski standardni čas je Chen-Yu Tsai napisal(a):

Quoted 4 lines

When sun4i_spdif_quirks was recently expanded, the kerneldoc covering the structure was not expanded to match. This ends up causing a warning when the documents are built.

Quoted 8 lines

Add the missing fields.

Fixes 0a2319308de8 ("ASoC: sun4i-spdif: Add clock multiplier settings")
Fixes 4a5ac6cd05a7 ("ASoC: sun4i-spdif: Support SPDIF output on A523 family")

Best regards,
Jernej

maintainer
#3 lore raw
In reply to Chen-Yu Tsai
Quoted 8 lines · Chen-Yu Tsai

When sun4i_spdif_quirks was recently expanded, the kerneldoc covering the structure was not expanded to match. This ends up causing a warning when the documents are built.

Add the missing fields.

[...]

Applied to

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] ASoC: sun4i-spdif: Add missing kerneldoc fields for sun4i_spdif_quirks

      commit: 6c11aa2b4cf767f5ccfe290b2572d53102dbe5ea

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark