netlink: specs: netdev: clarify the page pool API a little
Subsystems (3)
Jakub Kicinski
maintainerPATCH 1/1 netlink: specs: netdev: clarify the page pool API a little
The phrasing of the page-pool-get doc is very confusing. It's supposed to highlight that support depends on the driver doing its part but it sounds like orphaned page pools won't be visible.
The description of the ifindex is completely wrong. We move the page pool to loopback and skip the attribute if ifindex is loopback.
---
CC: [email protected]
CC: [email protected]
--- Documentation/netlink/specs/netdev.yaml | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)
Documentation/netlink/specs/netdev.yaml +4 -2
@@ -142,7 +142,7 @@ doc: >- name: ifindex doc: | ifindex of the netdev to which the pool belongs. - May be reported as 0 if the page pool was allocated for a netdev + May not be reported if the page pool was allocated for a netdev which got destroyed already (page pools may outlast their netdevs because they wait for all memory to be returned). type: u32
@@ -601,7 +601,9 @@ doc: >- name: page-pool-get doc: | Get / dump information about Page Pools. - (Only Page Pools associated with a net_device can be listed.) + Only Page Pools associated by the driver with a net_device + can be listed. ifindex will not be reported if the net_device + no longer exists. attribute-set: page-pool do: request:
Signature · 1 line
2.52.0
Quoted 9 lines · Jakub Kicinski
The phrasing of the page-pool-get doc is very confusing. It's supposed to highlight that support depends on the driver doing its part but it sounds like orphaned page pools won't be visible.
The description of the ifindex is completely wrong. We move the page pool to loopback and skip the attribute if ifindex is loopback.
Quoted 8 lines
Signed-off-by Jakub Kicinski <[email protected]>---
CC: [email protected]
CC: [email protected]--- Documentation/netlink/specs/netdev.yaml | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)
Jesper Dangaard Brouer
Acked-byQuoted 20 lines · Donald Hunter
Quoted 9 lines · Jakub Kicinski
The phrasing of the page-pool-get doc is very confusing. It's supposed to highlight that support depends on the driver doing its part but it sounds like orphaned page pools won't be visible.
The description of the ifindex is completely wrong. We move the page pool to loopback and skip the attribute if ifindex is loopback.
Quoted 8 lines
Signed-off-by Jakub Kicinski <[email protected]>---
CC: [email protected]
CC: [email protected]--- Documentation/netlink/specs/netdev.yaml | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)
Quoted 1 line
Reviewed-by Donald Hunter <[email protected]>
This patch was applied to netdev/net.git (main) by Jakub Kicinski <[email protected]>:
Hello:
This patch was applied to netdev/net.git (main)
by Jakub Kicinski <[email protected]>:
Quoted 10 lines · On Sun, 4 Jan 2026 08:52:32 -0800 you wrote:
The phrasing of the page-pool-get doc is very confusing. It's supposed to highlight that support depends on the driver doing its part but it sounds like orphaned page pools won't be visible.
The description of the ifindex is completely wrong. We move the page pool to loopback and skip the attribute if ifindex is loopback.
[...]
Here is the summary with links:
- [net] netlink: specs: netdev: clarify the page pool API a little
https://git.kernel.org/netdev/net/c/86c22d475cbc
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html