net: dlink: replace printk() with netdev_{info,dbg}() in rio_probe1()
Subsystems (2)
PATCH v2 1/1 net: dlink: replace printk() with netdev_{info,dbg}() in rio_probe1()
Replace rio_probe1() printk(KERN_INFO) messages with netdev_{info,dbg}().
Keep one netdev_info() line for device identification; move the rest to netdev_dbg() to avoid spamming the kernel log.
Log rx_timeout on a separate line since netdev_*() prefixes each message and the multi-line formatting looks broken otherwise.
No functional change intended.
Tested-on: D-Link DGE-550T Rev-A3
---
Changelog:
v2:
- Keep one netdev_inf() line; switch the rest to netdev_dbg()
v1: https://lore.kernel.org/netdev/[email protected]/
--- drivers/net/ethernet/dlink/dl2k.c | 17 +++++++---------- 1 file changed, 7 insertions(+), 10 deletions(-)
drivers/net/ethernet/dlink/dl2k.c +7 -10
@@ -279,18 +279,15 @@ rio_probe1 (struct pci_dev *pdev, const struct pci_device_id *ent) card_idx++; -printk (KERN_INFO "%s: %s, %pM, IRQ %d\n" , - dev->name, np->name, dev->dev_addr, irq); +netdev_info (dev,"%s, %pM, IRQ %d" , np->name, dev->dev_addr, irq);if (tx_coalesce >1 ) -printk (KERN_INFO "tx_coalesce:\t%d packets\n" , - tx_coalesce); -if (np->coalesce) -printk (KERN_INFO -"rx_coalesce:\t%d packets\n" -"rx_timeout: \t%d ns\n" , - np->rx_coalesce, np->rx_timeout*640 ); +netdev_dbg (dev,"tx_coalesce:\t%d packets" , tx_coalesce); +if (np->coalesce) { +netdev_dbg (dev,"rx_coalesce:\t%d packets" , np->rx_coalesce); +netdev_dbg (dev,"rx_timeout: \t%d ns" , np->rx_timeout *640 ); + }if (np->vlan) -printk (KERN_INFO "vlan(id):\t%d\n" , np->vlan); +netdev_dbg (dev,"vlan(id):\t%d" , np->vlan);return 0 ; err_out_unmap_rx:
Signature · 1 line
2.52.0
Quoted 5 lines · Yeounsu Moon
Replace
rio_probe1()printk(KERN_INFO)messages with netdev_{info,dbg}().Keep one
netdev_info()line for device identification; move the rest tonetdev_dbg()to avoid spamming the kernel log.
Quoted 7 lines
Log
rx_timeouton a separate line since netdev_*() prefixes each message and the multi-line formatting looks broken otherwise.No functional change intended.
Tested-on: D-Link DGE-550T Rev-A3
Signed-off-by Yeounsu Moon <[email protected]>
Andrew
This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <[email protected]>:
Hello:
This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <[email protected]>:
Quoted 9 lines · On Mon, 5 Jan 2026 22:05:53 +0900 you wrote:
Replace
rio_probe1()printk(KERN_INFO)messages with netdev_{info,dbg}().Keep one
netdev_info()line for device identification; move the rest tonetdev_dbg()to avoid spamming the kernel log.Log
rx_timeouton a separate line since netdev_*() prefixes each message and the multi-line formatting looks broken otherwise.[...]
Here is the summary with links:
- [net-next,v2] net: dlink: replace printk() with netdev_{info,dbg}() in rio_probe1()
https://git.kernel.org/netdev/net-next/c/b70c5c49238d
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html