Skip to contentSkip to conversation

atm: idt77252: Use sb_pool_remove()

PATCH Applied Thomas Fourier 2 participants 2 messages Jan 5 – Jan 7

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 atm: idt77252: Use sb_pool_remove()

Replacing the manual pool remove with the dedicated function. This is safer and more consistent with the rest of the code[1].

[1]; https://lore.kernel.org/all/[email protected]/

---
 drivers/atm/idt77252.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/atm/idt77252.c +1 -3
index f2e91b7d79f0..888695ccc2a7 100644
@@ -1844,7 +1844,6 @@ add_rx_skb(struct idt77252_dev *card, int queue,
 {
 	struct sk_buff *skb;
 	dma_addr_t paddr;
-	u32 handle;
 
 	while (count--) {
 		skb = dev_alloc_skb(size);
@@ -1876,8 +1875,7 @@ add_rx_skb(struct idt77252_dev *card, int queue,
 			 skb_end_pointer(skb) - skb->data, DMA_FROM_DEVICE);
 
 outpoolrm:
-	handle = IDT77252_PRV_POOL(skb);
-	card->sbpool[POOL_QUEUE(handle)].skb[POOL_INDEX(handle)] = NULL;
+	sb_pool_remove(card, skb);
 
 outfree:
 	dev_kfree_skb(skb);
Signature · 1 line
2.43.0
#1 lore raw
This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <[email protected]>:

Hello:

This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <[email protected]>:

Quoted 8 lines · On Mon, 5 Jan 2026 22:29:15 +0100 you wrote:

Replacing the manual pool remove with the dedicated function. This is safer and more consistent with the rest of the code[1].

[1]; https://lore.kernel.org/all/[email protected]/

[...]

Here is the summary with links:
- [net-next,v2] atm: idt77252: Use sb_pool_remove()

    https://git.kernel.org/netdev/net-next/c/8e7148b56023

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html