Skip to contentSkip to conversation

tools: ynl: don't install tests

PATCH Applied Jakub Kicinski 4 participants 4 messages Jan 6 – Jan 8

Subsystems (3)
lore
Share & tools
lore

Jakub Kicinski

author maintainer
#0 lore raw

PATCH 1/1 tools: ynl: don't install tests

make's install target is meant for installing the production artifacts, AFAIU. Don't install test_ynl_cli and test_ynl_ethtool from under the main YNL install target. The install target under tests/ is retained in case someone wants the tests to be installed.

Fixes 308b7dee3e5c ("tools: ynl: add YNL test framework")

---
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]

---
 tools/net/ynl/Makefile | 1 -
 1 file changed, 1 deletion(-)
tools/net/ynl/Makefile +0 -1
index 7736b492f559..c2f3e8b3f2ac 100644
@@ -51,7 +51,6 @@ install: libynl.a lib/*.h
 	@echo -e "\tINSTALL pyynl"
 	@pip install --prefix=$(DESTDIR)$(prefix) .
 	@make -C generated install
-	@make -C tests install
 
 run_tests:
 	@$(MAKE) -C tests run_tests
Signature · 1 line
2.52.0
Reviewed-by on v1 1/1
#1 lore raw
Quoted 32 lines · Jakub Kicinski

make's install target is meant for installing the production artifacts, AFAIU. Don't install test_ynl_cli and test_ynl_ethtool from under the main YNL install target. The install target under tests/ is retained in case someone wants the tests to be installed.

Fixes 308b7dee3e5c ("tools: ynl: add YNL test framework")

---
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]

---
 tools/net/ynl/Makefile | 1 -
 1 file changed, 1 deletion(-)
tools/net/ynl/Makefile +0 -1
index 7736b492f559..c2f3e8b3f2ac 100644
@@ -51,7 +51,6 @@ install: libynl.a lib/*.h
 	@echo -e "\tINSTALL pyynl"
 	@pip install --prefix=$(DESTDIR)$(prefix) .
 	@make -C generated install
-	@make -C tests install
 
 run_tests:
 	@$(MAKE) -C tests run_tests
Signature · 1 line
2.52.0
maintainer Reviewed-by on v1 1/1
#2 lore raw
In reply to Jakub Kicinski
Quoted 22 lines · Jakub Kicinski

make's install target is meant for installing the production artifacts, AFAIU. Don't install test_ynl_cli and test_ynl_ethtool from under the main YNL install target. The install target under tests/ is retained in case someone wants the tests to be installed.

Fixes 308b7dee3e5c ("tools: ynl: add YNL test framework")

---
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]

---
 tools/net/ynl/Makefile | 1 -
 1 file changed, 1 deletion(-)
tools/net/ynl/Makefile +0 -0
index 7736b492f559..c2f3e8b3f2ac 100644

tools/net/ynl/Makefile install: libynl.a lib/*.h · line 56

Quoted 7 lines
tools/net/ynl/Makefile +0 -1
@@ -51,7 +51,6 @@ install: libynl.a lib/*.h
 	@echo -e "\tINSTALL pyynl"
 	@pip install --prefix=$(DESTDIR)$(prefix) .
 	@make -C generated install
-	@make -C tests install
 
 run_tests:
 	@$(MAKE) -C tests run_tests
#3 lore raw
In reply to Jakub Kicinski
This patch was applied to netdev/net.git (main) by Jakub Kicinski <[email protected]>:

Hello:

This patch was applied to netdev/net.git (main)
by Jakub Kicinski <[email protected]>:

Quoted 10 lines · On Tue, 6 Jan 2026 08:34:26 -0800 you wrote:

make's install target is meant for installing the production artifacts, AFAIU. Don't install test_ynl_cli and test_ynl_ethtool from under the main YNL install target. The install target under tests/ is retained in case someone wants the tests to be installed.

Fixes 308b7dee3e5c ("tools: ynl: add YNL test framework")

[...]

Here is the summary with links:
- [net] tools: ynl: don't install tests

    https://git.kernel.org/netdev/net/c/790792ebc960

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html