tools/btpclient: Fix discovery filter setup
PATCH 1/1 tools/btpclient: Fix discovery filter setup
Fix transport mode test to use 'auto' only when both BREDR and LE are set.
Add an empty filter to discover all devices.
This allows to pass GAP/BROB/OBSV/BV-01-C and GAP/BROB/OBSV/BV-02-C tests with auto-pts.
--- tools/btpclient.c | 18 ++++++++++++++---- 1 file changed, 14 insertions(+), 4 deletions(-)
tools/btpclient.c +14 -4
@@ -1340,15 +1340,17 @@ static void set_discovery_filter_setup(struct l_dbus_message *message, builder =l_dbus_message_builder_new (message);l_dbus_message_builder_enter_array (builder,"{sv}" ); -l_dbus_message_builder_enter_dict (builder,"sv" );/* Be in observer mode or in general mode (default in Bluez) */ if (flags &BTP_GAP_DISCOVERY_FLAG_OBSERVATION ) { +l_dbus_message_builder_enter_dict (builder,"sv" );l_dbus_message_builder_append_basic (builder,'s' ,"Transport" );l_dbus_message_builder_enter_variant (builder,"s" ); -if (flags & (BTP_GAP_DISCOVERY_FLAG_LE | -BTP_GAP_DISCOVERY_FLAG_BREDR )) +if ((flags & (BTP_GAP_DISCOVERY_FLAG_LE | +BTP_GAP_DISCOVERY_FLAG_BREDR )) == + (BTP_GAP_DISCOVERY_FLAG_LE | +BTP_GAP_DISCOVERY_FLAG_BREDR ))l_dbus_message_builder_append_basic (builder,'s' ,"auto" );else if (flags &BTP_GAP_DISCOVERY_FLAG_LE )
@@ -1358,9 +1360,17 @@ static void set_discovery_filter_setup(struct l_dbus_message *message, "bredr");l_dbus_message_builder_leave_variant (builder); +l_dbus_message_builder_leave_dict (builder); + +/* Add empty pattern to discover all devices */ +l_dbus_message_builder_enter_dict (builder,"sv" ); +l_dbus_message_builder_append_basic (builder,'s' ,"Pattern" ); +l_dbus_message_builder_enter_variant (builder,"s" ); +l_dbus_message_builder_append_basic (builder,'s' ,"" ); +l_dbus_message_builder_leave_variant (builder); +l_dbus_message_builder_leave_dict (builder); } -l_dbus_message_builder_leave_dict (builder);l_dbus_message_builder_leave_array (builder);/* TODO add passive, limited discovery */
Signature · 1 line
2.43.0
This is automated email and please do not reply to this email!
Dear submitter,
Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=1042851
---Test result---
Test Summary:
CheckPatch PENDING 0.43 seconds GitLint PENDING 0.55 seconds BuildEll PASS 21.58 seconds BluezMake PASS 648.04 seconds MakeCheck PASS 18.90 seconds MakeDistcheck PASS 246.27 seconds CheckValgrind PASS 294.17 seconds CheckSmatch PASS 349.47 seconds bluezmakeextell PASS 181.64 seconds IncrementalBuild PENDING 0.45 seconds ScanBuild PASS 1020.91 seconds
Details
##############################
Test: CheckPatch - PENDING
Desc: Run checkpatch.pl script
Output:
##############################
Test: GitLint - PENDING
Desc: Run gitlint
Output:
##############################
Test: IncrementalBuild - PENDING
Desc: Incremental build with the patches in the series Output:
---
Regards,
Linux Bluetooth
This patch was applied to bluetooth/bluez.git (master) by Luiz Augusto von Dentz <[email protected]>:
Hello:
This patch was applied to bluetooth/bluez.git (master) by Luiz Augusto von Dentz <[email protected]>:
Quoted 9 lines · On Thu, 15 Jan 2026 15:36:09 +0100 you wrote:
Fix transport mode test to use 'auto' only when both BREDR and LE are set.
Add an empty filter to discover all devices.
This allows to pass GAP/BROB/OBSV/BV-01-C and GAP/BROB/OBSV/BV-02-C tests with auto-pts.
[...]
Here is the summary with links:
- [BlueZ] tools/btpclient: Fix discovery filter setup
https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=8d2f98ff2d5c
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html