net: fclone allocation small optimization
Subsystems (2)
PATCH 1/1 net: fclone allocation small optimization
After skb allocation, initial skb->fclone value is 0 (SKB_FCLONE_UNAVAILABLE)
We can replace one RMW sequence with a single OR instruction.
movzbl 0x7e(%r13),%eax // skb->fclone = SKB_FCLONE_ORIG; and $0xf3,%al or $0x4,%al mov %al,0x7e(%r13) -> or $0x4,0x7e(%r13) // skb->fclone |= SKB_FCLONE_ORIG;
Signed-off-by Eric Dumazet <[email protected]>
--- net/core/skbuff.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-)
net/core/skbuff.c +8 -1
@@ -723,7 +723,14 @@ struct sk_buff *__alloc_skb(unsigned int size, gfp_t gfp_mask, fclones = container_of(skb, struct sk_buff_fclones, skb1); - skb->fclone =SKB_FCLONE_ORIG ; +/* skb->fclone is a 2bits field. +* Replace expensive RMW (skb->fclone = SKB_FCLONE_ORIG) +* with a single OR. +*/ +BUILD_BUG_ON (SKB_FCLONE_UNAVAILABLE !=0 ); +DEBUG_NET_WARN_ON_ONCE (skb->fclone !=SKB_FCLONE_UNAVAILABLE ); + skb->fclone |=SKB_FCLONE_ORIG ; +refcount_set (&fclones->fclone_ref,1 ); }
Signature · 1 line
2.52.0.457.g6b5491de43-goog
This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <[email protected]>:
Hello:
This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <[email protected]>:
Quoted 4 lines · On Fri, 16 Jan 2026 16:44:02 +0000 you wrote:
After skb allocation, initial
skb->fclonevalue is 0 (SKB_FCLONE_UNAVAILABLE)We can replace one RMW sequence with a single OR instruction.
Quoted 8 lines
movzbl 0x7e(%r13),%eax // skb->fclone = SKB_FCLONE_ORIG; and $0xf3,%al or $0x4,%al mov %al,0x7e(%r13) -> or $0x4,0x7e(%r13) // skb->fclone |= SKB_FCLONE_ORIG;[...]
Here is the summary with links:
- [net-next] net: fclone allocation small optimization
https://git.kernel.org/netdev/net-next/c/79bfa5fb8587
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html