eth: bnxt: make sure we populate the qcfg defaults on old FW/HW
Jakub Kicinski
maintainerPATCH 1/1 eth: bnxt: make sure we populate the qcfg defaults on old FW/HW
The driver now depends on the core to tell it what the rx page size should be for the agg ring. We must populate the ndo_default_qcfg callback even if we don't support any queue ops.
This fixes:
Oops: divide error: 0000 [#1] SMP DEBUG_PAGEALLOC KASAN RIP: 0010:bnxt_alloc_rx_page_pool (drivers/net/ethernet/broadcom/bnxt/bnxt.c:3852)
with fw version 225.1.109.0.
---
CC: [email protected]
CC: [email protected]
CC: [email protected]
--- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 1 + 1 file changed, 1 insertion(+)
drivers/net/ethernet/broadcom/bnxt/bnxt.c +1 -0
@@ -16316,6 +16316,7 @@ static const struct netdev_queue_mgmt_ops bnxt_queue_mgmt_ops = { };static const struct netdev_queue_mgmt_ops bnxt_queue_mgmt_ops_unsupp = { + .ndo_default_qcfg = bnxt_queue_default_qcfg, };static void bnxt_remove_one (struct pci_dev *pdev)
Signature · 1 line
2.52.0
Jakub Kicinski
maintainerQuoted 5 lines · On Wed, 28 Jan 2026 11:32:58 -0800 Jakub Kicinski wrote:
The driver now depends on the core to tell it what the rx page size should be for the agg ring. We must populate the
ndo_default_qcfgcallback even if we don't support any queue ops.This fixes:
Quoted 8 lines
Oops: divide error: 0000 [#1] SMP DEBUG_PAGEALLOC KASAN RIP: 0010:bnxt_alloc_rx_page_pool (drivers/net/ethernet/broadcom/bnxt/bnxt.c:3852)with fw version 225.1.109.0.
Fixes f96e1b35779e ("eth: bnxt: support qcfg provided rx page size")Signed-off-by Jakub Kicinski <[email protected]>
Can I get an ack here? This prevents machines from booting so it'd be great to fix before too many people waste their time.
Quoted 12 lines
drivers/net/ethernet/broadcom/bnxt/bnxt.c +1
-0@@ -16316,6 +16316,7 @@ static const struct netdev_queue_mgmt_ops bnxt_queue_mgmt_ops = { };static const struct netdev_queue_mgmt_ops bnxt_queue_mgmt_ops_unsupp = { + .ndo_default_qcfg = bnxt_queue_default_qcfg, };static void bnxt_remove_one (struct pci_dev *pdev)
Quoted 10 lines · Jakub Kicinski
Quoted 8 lines · On Wed, 28 Jan 2026 11:32:58 -0800 Jakub Kicinski wrote:
The driver now depends on the core to tell it what the rx page size should be for the agg ring. We must populate the
ndo_default_qcfgcallback even if we don't support any queue ops.This fixes:
Oops: divide error: 0000 [#1] SMP DEBUG_PAGEALLOC KASAN RIP: 0010:bnxt_alloc_rx_page_pool (drivers/net/ethernet/broadcom/bnxt/bnxt.c:3852)
Quoted 8 lines
Quoted 5 lines
with fw version 225.1.109.0.
Fixes f96e1b35779e ("eth: bnxt: support qcfg provided rx page size")Signed-off-by Jakub Kicinski <[email protected]>Can I get an ack here? This prevents machines from booting so it'd be great to fix before too many people waste their time.
Yes, it looks good to me. Thanks.
Jakub Kicinski
maintainerQuoted 17 lines · On Thu, 29 Jan 2026 18:36:07 -0800 Michael Chan wrote:
Quoted 16 lines · Jakub Kicinski
Quoted 13 lines · On Wed, 28 Jan 2026 11:32:58 -0800 Jakub Kicinski wrote:
The driver now depends on the core to tell it what the rx page size should be for the agg ring. We must populate the
ndo_default_qcfgcallback even if we don't support any queue ops.This fixes:
Oops: divide error: 0000 [#1] SMP DEBUG_PAGEALLOC KASAN RIP: 0010:bnxt_alloc_rx_page_pool (drivers/net/ethernet/broadcom/bnxt/bnxt.c:3852)with fw version 225.1.109.0.
Fixes f96e1b35779e ("eth: bnxt: support qcfg provided rx page size")Signed-off-by Jakub Kicinski <[email protected]>
Quoted 5 lines
Quoted 2 lines
Can I get an ack here? This prevents machines from booting so it'd be great to fix before too many people waste their time.
Yes, it looks good to me. Thanks.
Reviewed-by Michael Chan <[email protected]>
Thank you!
This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <[email protected]>:
Hello:
This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <[email protected]>:
Quoted 9 lines · On Wed, 28 Jan 2026 11:32:58 -0800 you wrote:
The driver now depends on the core to tell it what the rx page size should be for the agg ring. We must populate the
ndo_default_qcfgcallback even if we don't support any queue ops.This fixes:
Oops: divide error: 0000 [#1] SMP DEBUG_PAGEALLOC KASAN RIP: 0010:bnxt_alloc_rx_page_pool (drivers/net/ethernet/broadcom/bnxt/bnxt.c:3852)[...]
Here is the summary with links:
- [net-next] eth: bnxt: make sure we populate the qcfg defaults on old FW/HW
https://git.kernel.org/netdev/net-next/c/3cf48c04966e
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
Quoted 9 lines · Jakub Kicinski
The driver now depends on the core to tell it what the rx page size should be for the agg ring. We must populate the
ndo_default_qcfgcallback even if we don't support any queue ops.This fixes:
Oops: divide error: 0000 [#1] SMP DEBUG_PAGEALLOC KASAN RIP: 0010:bnxt_alloc_rx_page_pool (drivers/net/ethernet/broadcom/bnxt/bnxt.c:3852)with fw version 225.1.109.0.
fwiw, looks good, thanks for the fix
Signature · 1 line
Pavel Begunkov