Skip to contentSkip to conversation

client/btpclient: Fix build warning

PATCH Applied Frédéric Danis 3 participants 3 messages Feb 17 Bluetooth drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 client/btpclient: Fix build warning

client/btpclient/gap.c:2359:3: warning: Value stored to 'reply' is never read [deadcode.DeadStores]

 2359 |     reply = l_dbus_message_new_error(ag->pending_req,
      |     ^       ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 2360 |                                     "org.bluez.Error.Rejected",
      |                                     ~~~~~~~~~~~~~~~~~~~~~~~~~~~
 2361 |                                     "Passkey mismatch");
      |                                     ~~~~~~~~~~~~~~~~~~~
1 warning generated.
---
 client/btpclient/gap.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
client/btpclient/gap.c +3 -1
index 15f0f0cbd..85cdad631 100644
@@ -2359,9 +2359,11 @@ static void btp_gap_confirm_entry_rsp(uint8_t index, const void *param,
 		reply = l_dbus_message_new_error(ag->pending_req,
 						"org.bluez.Error.Rejected",
 						"Passkey mismatch");
+		l_dbus_send(dbus, reply);
+		return;
 	}
 
-	l_dbus_send_with_reply(dbus, ag->pending_req, passkey_confirm_rsp_reply,
+	l_dbus_send_with_reply(dbus, reply, passkey_confirm_rsp_reply,
 								adapter, NULL);
 
 	return;
Signature · 1 line
2.43.0
#1 lore raw

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=1054909

---Test result---

Test Summary:

CheckPatch                    PENDING   0.41 seconds
GitLint                       PENDING   0.41 seconds
BuildEll                      PASS      20.92 seconds
BluezMake                     PASS      644.71 seconds
MakeCheck                     PASS      18.56 seconds
MakeDistcheck                 PASS      249.73 seconds
CheckValgrind                 PASS      296.52 seconds
CheckSmatch                   PASS      361.07 seconds
bluezmakeextell               PASS      184.04 seconds
IncrementalBuild              PENDING   0.40 seconds
ScanBuild                     PASS      1026.96 seconds

Details
##############################
Test: CheckPatch - PENDING
Desc: Run checkpatch.pl script
Output:

##############################
Test: GitLint - PENDING
Desc: Run gitlint
Output:

##############################
Test: IncrementalBuild - PENDING
Desc: Incremental build with the patches in the series Output:

---
Regards,
Linux Bluetooth

#2 lore raw
In reply to Frédéric Danis
This patch was applied to bluetooth/bluez.git (master) by Luiz Augusto von Dentz <[email protected]>:

Hello:

This patch was applied to bluetooth/bluez.git (master) by Luiz Augusto von Dentz <[email protected]>:

Quoted 11 lines · On Tue, 17 Feb 2026 16:36:16 +0100 you wrote:

client/btpclient/gap.c:2359:3: warning: Value stored to 'reply' is never read [deadcode.DeadStores]

 2359 |     reply = l_dbus_message_new_error(ag->pending_req,
      |     ^       ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 2360 |                                     "org.bluez.Error.Rejected",
      |                                     ~~~~~~~~~~~~~~~~~~~~~~~~~~~
 2361 |                                     "Passkey mismatch");
      |                                     ~~~~~~~~~~~~~~~~~~~

1 warning generated.

[...]

Here is the summary with links:
- [BlueZ] client/btpclient: Fix build warning

    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=99845224fd4a

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html