Skip to contentSkip to conversation

Enable all cpus in Exynos5420

PATCH Superseded Chander Kashyap 2 participants 7 messages Sep 5, 2013

Subsystems (3)

v1 of 4 Superseded Latest is v4 →

lore
Share & tools
lore
#0 lore raw

cover Enable all cpus in Exynos5420

Exynos5420 is an octacore SoC. This patch series enables the remaining 4 cores.

Chander Kashyap (2):
clocksource: mct: extend mct to support 8 local interrupts for

    Exynos5420

arm: dt: Exynos5420: populate cpu node enteries to 8 cpus

 arch/arm/boot/dts/exynos5420.dtsi |   37 +++++++++++++++++++++++++++++++++++--
 drivers/clocksource/exynos_mct.c  |    4 ++++
 2 files changed, 39 insertions(+), 2 deletions(-)
Signature · 1 line
1.7.9.5
#1 lore raw

PATCH 1/2 clocksource: mct: extend mct to support 8 local interrupts for Exynos5420

Exynos5420 is octacore SoC from Samsung. Hence extend exynos-mct clocksource driver to support 8 local interrupts.

Also extend dt entries for 8 interrupts.

---
 arch/arm/boot/dts/exynos5420.dtsi |    9 +++++++--
 drivers/clocksource/exynos_mct.c  |    4 ++++
 2 files changed, 11 insertions(+), 2 deletions(-)
arch/arm/boot/dts/exynos5420.dtsi +7 -2
index 6ce2f94..e97c87b 100644
@@ -69,7 +69,8 @@
 		compatible = "samsung,exynos4210-mct";
 		reg = <0x101C0000 0x800>;
 		interrupt-parent = <&mct_map>;
-		interrupts = <0>, <1>, <2>, <3>, <4>, <5>, <6>, <7>;
+		interrupts = <0>, <1>, <2>, <3>, <4>, <5>, <6>, <7>,
+				<8>, <9>, <10>, <11>;
 		clocks = <&clock 1>, <&clock 315>;
 		clock-names = "fin_pll", "mct";
 
@@ -84,7 +85,11 @@
 					<4 &gic 0 120 0>,
 					<5 &gic 0 121 0>,
 					<6 &gic 0 122 0>,
-					<7 &gic 0 123 0>;
+					<7 &gic 0 123 0>,
+					<8 &gic 0 128 0>,
+					<9 &gic 0 129 0>,
+					<10 &gic 0 130 0>,
+					<11 &gic 0 131 0>;
 		};
 	};
 
drivers/clocksource/exynos_mct.c +4 -0
index b2bbc41..ff4711e 100644
@@ -71,6 +71,10 @@ enum {
 	MCT_L1_IRQ,
 	MCT_L2_IRQ,
 	MCT_L3_IRQ,
+	MCT_L4_IRQ,
+	MCT_L5_IRQ,
+	MCT_L6_IRQ,
+	MCT_L7_IRQ,
 	MCT_NR_IRQS,
 };
 
Signature · 1 line
1.7.9.5
#2 lore raw

PATCH 2/2 arm: dt: Exynos5420: populate cpu node enteries to 8 cpus

In reply to Chander Kashyap

Exynos5420 is octacore SoC from samsung.
Hence populate all the cpu node enteries.

---
 arch/arm/boot/dts/exynos5420.dtsi |   28 ++++++++++++++++++++++++++++
 1 file changed, 28 insertions(+)
arch/arm/boot/dts/exynos5420.dtsi +28 -0
index e97c87b..59489f6 100644
@@ -57,6 +57,34 @@
 			reg = <0x3>;
 			clock-frequency = <1800000000>;
 		};
+
+		cpu4: cpu at 4 {
+			device_type = "cpu";
+			compatible = "arm,cortex-a7";
+			reg = <0x100>;
+			clock-frequency = <1000000000>;
+		};
+
+		cpu5: cpu at 5 {
+			device_type = "cpu";
+			compatible = "arm,cortex-a7";
+			reg = <0x101>;
+			clock-frequency = <1000000000>;
+		};
+
+		cpu6: cpu at 6 {
+			device_type = "cpu";
+			compatible = "arm,cortex-a7";
+			reg = <0x102>;
+			clock-frequency = <1000000000>;
+		};
+
+		cpu7: cpu at 7 {
+			device_type = "cpu";
+			compatible = "arm,cortex-a7";
+			reg = <0x103>;
+			clock-frequency = <1000000000>;
+		};
 	};
 
 	clock: clock-controller at 0x10010000 {
Signature · 1 line
1.7.9.5
#3 lore raw

PATCH 2/2 arm: dt: Exynos5420: populate cpu node enteries to 8 cpus

Hi Chander,

Quoted 13 lines · On Thursday 05 of September 2013 14:54:46 Chander Kashyap wrote:

Exynos5420 is octacore SoC from samsung.
Hence populate all the cpu node enteries.

---
 arch/arm/boot/dts/exynos5420.dtsi |   28 ++++++++++++++++++++++++++++
 1 file changed, 28 insertions(+)
(quoted diff) +0 -0

b/arch/arm/boot/dts/exynos5420.dtsi index e97c87b..59489f6 100644

arch/arm/boot/dts/exynos5420.dtsi line 61

Quoted 5 lines
arch/arm/boot/dts/exynos5420.dtsi +2 -0
@@ -57,6 +57,34 @@
 			reg = <0x3>;
 			clock-frequency = <1800000000>;
 		};
+
+		cpu4: cpu at 4 {

I believe this is a typo. The @unit-address suffix should match the value of reg property.

arch/arm/boot/dts/exynos5420.dtsi line 68

Quoted 7 lines
arch/arm/boot/dts/exynos5420.dtsi +7 -0
+			device_type = "cpu";
+			compatible = "arm,cortex-a7";
+			reg = <0x100>;
+			clock-frequency = <1000000000>;
+		};
+
+		cpu5: cpu at 5 {

Ditto.

arch/arm/boot/dts/exynos5420.dtsi line 75

Quoted 7 lines
arch/arm/boot/dts/exynos5420.dtsi +7 -0
+			device_type = "cpu";
+			compatible = "arm,cortex-a7";
+			reg = <0x101>;
+			clock-frequency = <1000000000>;
+		};
+
+		cpu6: cpu at 6 {

Ditto.

arch/arm/boot/dts/exynos5420.dtsi line 82

Quoted 7 lines
arch/arm/boot/dts/exynos5420.dtsi +7 -0
+			device_type = "cpu";
+			compatible = "arm,cortex-a7";
+			reg = <0x102>;
+			clock-frequency = <1000000000>;
+		};
+
+		cpu7: cpu at 7 {

Ditto.

arch/arm/boot/dts/exynos5420.dtsi line 88

Quoted 6 lines
arch/arm/boot/dts/exynos5420.dtsi +5 -0
+			device_type = "cpu";
+			compatible = "arm,cortex-a7";
+			reg = <0x103>;
+			clock-frequency = <1000000000>;
+		};
 	};

Best regards,
Tomasz

#4 lore raw

PATCH 2/2 arm: dt: Exynos5420: populate cpu node enteries to 8 cpus

Hi Tomasz,

Quoted 11 lines · Tomasz Figa

Hi Chander,

Quoted 8 lines · On Thursday 05 of September 2013 14:54:46 Chander Kashyap wrote:

Exynos5420 is octacore SoC from samsung.
Hence populate all the cpu node enteries.

---
 arch/arm/boot/dts/exynos5420.dtsi |   28 ++++++++++++++++++++++++++++
 1 file changed, 28 insertions(+)
Quoted 13 lines

arch/arm/boot/dts/exynos5420.dtsi line 61

Quoted 10 lines
(quoted diff) +0 -0

b/arch/arm/boot/dts/exynos5420.dtsi index e97c87b..59489f6 100644

arch/arm/boot/dts/exynos5420.dtsi +2 -0
@@ -57,6 +57,34 @@
                      reg = <0x3>;
                      clock-frequency = <1800000000>;
              };
+
+             cpu4: cpu at 4 {

I believe this is a typo. The @unit-address suffix should match the value of reg property.

No this is not typo. It is the MPIDR value of the cpu. (24 bits of MPIDR register).

Quoted 41 lines

arch/arm/boot/dts/exynos5420.dtsi line 68

Quoted 8 lines
arch/arm/boot/dts/exynos5420.dtsi +7 -0
+                     device_type = "cpu";
+                     compatible = "arm,cortex-a7";
+                     reg = <0x100>;
+                     clock-frequency = <1000000000>;
+             };
+
+             cpu5: cpu at 5 {

Ditto.

arch/arm/boot/dts/exynos5420.dtsi line 75

Quoted 7 lines
arch/arm/boot/dts/exynos5420.dtsi +7 -0
+                     device_type = "cpu";
+                     compatible = "arm,cortex-a7";
+                     reg = <0x101>;
+                     clock-frequency = <1000000000>;
+             };
+
+             cpu6: cpu at 6 {

Ditto.

arch/arm/boot/dts/exynos5420.dtsi line 82

Quoted 7 lines
arch/arm/boot/dts/exynos5420.dtsi +7 -0
+                     device_type = "cpu";
+                     compatible = "arm,cortex-a7";
+                     reg = <0x102>;
+                     clock-frequency = <1000000000>;
+             };
+
+             cpu7: cpu at 7 {

Ditto.

arch/arm/boot/dts/exynos5420.dtsi line 88

Quoted 6 lines
arch/arm/boot/dts/exynos5420.dtsi +5 -0
+                     device_type = "cpu";
+                     compatible = "arm,cortex-a7";
+                     reg = <0x103>;
+                     clock-frequency = <1000000000>;
+             };
      };

Best regards,
Tomasz

Signature · 2 lines
with warm regards,
Chander Kashyap
#5 lore raw

PATCH 2/2 arm: dt: Exynos5420: populate cpu node enteries to 8 cpus

Quoted 26 lines · On Thursday 05 of September 2013 15:33:17 Chander Kashyap wrote:

Hi Tomasz,

Quoted 23 lines · Tomasz Figa

Hi Chander,

Quoted 20 lines · On Thursday 05 of September 2013 14:54:46 Chander Kashyap wrote:

Exynos5420 is octacore SoC from samsung.
Hence populate all the cpu node enteries.

---

 arch/arm/boot/dts/exynos5420.dtsi |   28 ++++++++++++++++++++++++++++
 1 file changed, 28 insertions(+)
(quoted diff) +0 -0

b/arch/arm/boot/dts/exynos5420.dtsi index e97c87b..59489f6 100644

arch/arm/boot/dts/exynos5420.dtsi +0 -0
@@ -57,6 +57,34 @@
 
                      reg = <0x3>;
                      clock-frequency = <1800000000>;
 
              };
 
Quoted 8 lines
Quoted 5 lines

arch/arm/boot/dts/exynos5420.dtsi line 61

Quoted 2 lines
arch/arm/boot/dts/exynos5420.dtsi +2 -0
+
+             cpu4: cpu at 4 {

I believe this is a typo. The @unit-address suffix should match the value of reg property.

No this is not typo. It is the MPIDR value of the cpu. (24 bits of MPIDR register).

Right. This is what the reg property should be set to. However, the @unit- address prefix of node name should match the value of reg property, so if the value of reg property is 0x100, then the node should be named cpu at 100.

Best regards,
Tomasz

#6 lore raw

PATCH 2/2 arm: dt: Exynos5420: populate cpu node enteries to 8 cpus

Quoted 33 lines · Tomasz Figa
Quoted 32 lines · On Thursday 05 of September 2013 15:33:17 Chander Kashyap wrote:

Hi Tomasz,

Quoted 28 lines · Tomasz Figa

Hi Chander,

Quoted 14 lines · On Thursday 05 of September 2013 14:54:46 Chander Kashyap wrote:

Exynos5420 is octacore SoC from samsung.
Hence populate all the cpu node enteries.

---

 arch/arm/boot/dts/exynos5420.dtsi |   28 ++++++++++++++++++++++++++++
 1 file changed, 28 insertions(+)
(quoted diff) +0 -0

b/arch/arm/boot/dts/exynos5420.dtsi index e97c87b..59489f6 100644

arch/arm/boot/dts/exynos5420.dtsi line 64

Quoted 8 lines
arch/arm/boot/dts/exynos5420.dtsi +2 -0
@@ -57,6 +57,34 @@
 
                      reg = <0x3>;
                      clock-frequency = <1800000000>;
 
              };
 
+
+             cpu4: cpu at 4 {

I believe this is a typo. The @unit-address suffix should match the value of reg property.

Quoted 6 lines
Quoted 2 lines

No this is not typo. It is the MPIDR value of the cpu. (24 bits of MPIDR register).

Right. This is what the reg property should be set to. However, the @unit- address prefix of node name should match the value of reg property, so if the value of reg property is 0x100, then the node should be named cpu at 100.

Ah ok,
Thanks. I will spin out a new version and send

Quoted 4 lines

Best regards,
Tomasz

Signature · 2 lines
with warm regards,
Chander Kashyap