resolve_btfids: Fix linker flags detection
Subsystems (3)
Ihor Solodrai
reviewerPATCH v3 1/1 resolve_btfids: Fix linker flags detection
The "|| echo -lzstd" default makes zstd an unconditional link dependency of resolve_btfids. On systems where libzstd-dev is not installed and pkg-config fails, the linker fails:
ld: cannot find -lzstd: No such file or directory
libzstd is a transitive dependency of libelf, so the -lzstd flag is strictly necessary only for static builds [1].
Remove ZSTD_LIBS variable, and instead set LIBELF_LIBS depending on whether the build is static or not. Use $(HOSTPKG_CONFIG) as primary source of the flags list.
Also add a default value for HOSTPKG_CONFIG in case it's not built via the toplevel Makefile. Pass it from selftests/bpf too.
[1] https://lore.kernel.org/bpf/[email protected]/
---
v2->v3: Pass HOSTPKG_CONFIG from selftests/bpf/Makefile (Paul)
v2: https://lore.kernel.org/bpf/[email protected]/
v1->v2: Use different LDFLAGS depending on -static (Vitaly)
v1: https://lore.kernel.org/bpf/[email protected]/
--- tools/bpf/resolve_btfids/Makefile | 9 +++++++-- tools/testing/selftests/bpf/Makefile | 1 + 2 files changed, 8 insertions(+), 2 deletions(-)
tools/bpf/resolve_btfids/Makefile +7 -2
@@ -23,6 +23,7 @@ RM ?= rm HOSTCC ?= gcc HOSTLD ?= ld HOSTAR ?= ar +HOSTPKG_CONFIG ?= pkg-config CROSS_COMPILE = OUTPUT ?= $(srctree)/tools/bpf/resolve_btfids/
@@ -63,10 +64,14 @@ $(BPFOBJ): $(wildcard $(LIBBPF_SRC)/*.[ch] $(LIBBPF_SRC)/Makefile) | $(LIBBPF_OU $(abspath $@) install_headers LIBELF_FLAGS := $(shell $(HOSTPKG_CONFIG) libelf --cflags 2>/dev/null) + +ifneq ($(filter -static,$(EXTRA_LDFLAGS)),) +LIBELF_LIBS := $(shell $(HOSTPKG_CONFIG) libelf --libs --static 2>/dev/null || echo -lelf -lzstd) +else LIBELF_LIBS := $(shell $(HOSTPKG_CONFIG) libelf --libs 2>/dev/null || echo -lelf) +endif ZLIB_LIBS := $(shell $(HOSTPKG_CONFIG) zlib --libs 2>/dev/null || echo -lz) -ZSTD_LIBS := $(shell $(HOSTPKG_CONFIG) libzstd --libs 2>/dev/null || echo -lzstd) HOSTCFLAGS_resolve_btfids += -g \ -I$(srctree)/tools/include \
@@ -76,7 +81,7 @@ HOSTCFLAGS_resolve_btfids += -g \ $(LIBELF_FLAGS) \ -Wall -Werror -LIBS = $(LIBELF_LIBS) $(ZLIB_LIBS) $(ZSTD_LIBS) +LIBS = $(LIBELF_LIBS) $(ZLIB_LIBS) export srctree OUTPUT HOSTCFLAGS_resolve_btfids Q HOSTCC HOSTLD HOSTAR include $(srctree)/tools/build/Makefile.include
tools/testing/selftests/bpf/Makefile +1 -0
@@ -409,6 +409,7 @@ $(RESOLVE_BTFIDS): $(HOST_BPFOBJ) | $(HOST_BUILD_DIR)/resolve_btfids \ CC="$(HOSTCC)" LD="$(HOSTLD)" AR="$(HOSTAR)" \ LIBBPF_INCLUDE=$(HOST_INCLUDE_DIR) \ EXTRA_LDFLAGS='$(SAN_LDFLAGS) $(EXTRA_LDFLAGS)' \ + HOSTPKG_CONFIG=$(PKG_CONFIG) \ OUTPUT=$(HOST_BUILD_DIR)/resolve_btfids/ BPFOBJ=$(HOST_BPFOBJ) # Get Clang's default includes on this system, as opposed to those seen by
Signature · 1 line
2.53.0
Quoted 16 lines · Ihor Solodrai
The "|| echo -lzstd" default makes zstd an unconditional link dependency of
resolve_btfids. On systems where libzstd-dev is not installed and pkg-config fails, the linker fails:ld: cannot find -lzstd: No such file or directory
libzstd is a transitive dependency of libelf, so the -lzstd flag is strictly necessary only for static builds [1].
Remove
ZSTD_LIBSvariable, and instead setLIBELF_LIBSdepending on whether the build is static or not. Use $(HOSTPKG_CONFIG) as primary source of the flags list.Also add a default value for
HOSTPKG_CONFIGin case it's not built via the toplevelMakefile. Pass it from selftests/bpf too.
Quoted 8 lines
[1] https://lore.kernel.org/bpf/[email protected]/
Reported-by BPF CI Bot (Claude Opus 4.6) <[email protected]>Reported-by Vitaly Chikunov <[email protected]>Fixes 4021848a903e ("selftests/bpf: Pass through build flags to bpftool and resolve_btfids")Signed-off-by Ihor Solodrai <[email protected]>---
[...]
This patch was applied to bpf/bpf.git (master) by Alexei Starovoitov <[email protected]>:
Hello:
This patch was applied to bpf/bpf.git (master)
by Alexei Starovoitov <[email protected]>:
Quoted 10 lines · On Wed, 4 Mar 2026 17:47:30 -0800 you wrote:
The "|| echo -lzstd" default makes zstd an unconditional link dependency of
resolve_btfids. On systems where libzstd-dev is not installed and pkg-config fails, the linker fails:ld: cannot find -lzstd: No such file or directory
libzstd is a transitive dependency of libelf, so the -lzstd flag is strictly necessary only for static builds [1].
[...]
Here is the summary with links:
- [bpf,v3] resolve_btfids: Fix linker flags detection
https://git.kernel.org/bpf/bpf/c/b0dcdcb9ae75
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html