net: sched: cls_u32: Avoid memcpy() false-positive warning in u32_init_knode()
Subsystems (3)
PATCH v2 1/1 net: sched: cls_u32: Avoid memcpy() false-positive warning in u32_init_knode()
From: Jiayuan Chen <[email protected]>
Syzbot reported a warning in u32_init_knode() [1].
Similar to commit 7cba18332e36 ("net: sched: cls_u32: Avoid memcpy() false-positive warning") which addressed the same issue in u32_change(), use unsafe_memcpy() in u32_init_knode() to work around the compiler's inability to see into composite flexible array structs.
This silences the false-positive reported by syzbot:
memcpy: detected field-spanning write (size 32) of single field "&new->sel" at net/sched/cls_u32.c:855 (size 16)
Since the memory is correctly allocated with kzalloc_flex() using s->nkeys, this is purely a false positive and does not need a Fixes tag.
[1] https://syzkaller.appspot.com/bug?extid=d5ace703ed883df56e42
---
v1 -> v2 : Drop unnecessary commit message
https://lore.kernel.org/netdev/[email protected]/T/#t
--- net/sched/cls_u32.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)
net/sched/cls_u32.c +4 -1
@@ -852,7 +852,10 @@ static struct tc_u_knode *u32_init_knode(struct net *net, struct tcf_proto *tp,/* Similarly success statistics must be moved as pointers */ new->pcpu_success = n->pcpu_success;#endif -memcpy (&new->sel, s,struct_size (s, keys, s->nkeys)); +unsafe_memcpy (&new->sel, s,struct_size (s, keys, s->nkeys), +/* A composite flex-array structure destination, +* which was correctly sized with kzalloc_flex(), + * above. */);if (tcf_exts_init (&new->exts, net,TCA_U32_ACT ,TCA_U32_POLICE )) {kfree (new);
Signature · 1 line
2.43.0
This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <[email protected]>:
Hello:
This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <[email protected]>:
Quoted 10 lines · On Mon, 9 Mar 2026 20:39:16 +0800 you wrote:
From: Jiayuan Chen <[email protected]>
Syzbot reported a warning in
u32_init_knode()[1].Similar to commit
7cba18332e36("net: sched:cls_u32: Avoidmemcpy()false-positive warning") which addressed the same issue inu32_change(), useunsafe_memcpy()inu32_init_knode()to work around the compiler's inability to see into composite flexible array structs.[...]
Here is the summary with links:
- [net-next,v2] net: sched: cls_u32: Avoid memcpy() false-positive warning in u32_init_knode()
https://git.kernel.org/netdev/net-next/c/34bd3c6b0bd3
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html