Skip to contentSkip to conversation

thermal: ti-soc-thermal: fix incorrect entry in omap5430_adc_to_temp[]

PATCH In review Bartlomiej Zolnierkiewicz 3 participants 4 messages May 2, 2018 1 message not in the archive

Subsystems (2)
lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): CGME20180502141432eucas1p1c85aa366979b73c59a46ec0c2f7ef8e6@eucas1p1.samsung.com

#1 lore raw

PATCH v2 1/1 thermal: ti-soc-thermal: fix incorrect entry in omap5430_adc_to_temp[]

Entry for Index 941 has one zero too much. Fix it.

---
v2:
- Fix patch description.

 drivers/thermal/ti-soc-thermal/omap5-thermal-data.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/thermal/ti-soc-thermal/omap5-thermal-data.c +1 -1
Index: b/drivers/thermal/ti-soc-thermal/omap5-thermal-data.c
===================================================================
@@ -310,7 +310,7 @@ omap5430_adc_to_temp[
 	119800, 120200, 120600, 121000, 121400, 121800, 122400, 122600, 123000,
 	123400,
 	/* Index 940 - 945 */
-	123800, 1242000, 124600, 124900, 125000, 125000,
+	123800, 124200, 124600, 124900, 125000, 125000,
 };
 
 /* OMAP54xx ES2.0 data */
maintainer Acked-by on v2 1/1
#2 lore raw
Quoted 2 lines · Bartlomiej Zolnierkiewicz

Entry for Index 941 has one zero too much. Fix it.

Quoted 22 lines

---
v2:
- Fix patch description.

 drivers/thermal/ti-soc-thermal/omap5-thermal-data.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Index: b/drivers/thermal/ti-soc-thermal/omap5-thermal-data.c
===================================================================

drivers/thermal/ti-soc-thermal/omap5-thermal-data.c +1 -1
@@ -310,7 +310,7 @@ omap5430_adc_to_temp[
 	119800, 120200, 120600, 121000, 121400, 121800, 122400, 122600, 123000,
 	123400,
 	/* Index 940 - 945 */
-	123800, 1242000, 124600, 124900, 125000, 125000,
+	123800, 124200, 124600, 124900, 125000, 125000,
 };
 
 /* OMAP54xx ES2.0 data */
#3 lore raw
In reply to Bartlomiej Zolnierkiewicz
Quoted 3 lines · Bartlomiej Zolnierkiewicz

Entry for Index 941 has one zero too much. Fix it.

Good catch :)

I'm curious, how did you spot it ?

Quoted 21 lines

---
v2:
- Fix patch description.

 drivers/thermal/ti-soc-thermal/omap5-thermal-data.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Index: b/drivers/thermal/ti-soc-thermal/omap5-thermal-data.c
===================================================================

drivers/thermal/ti-soc-thermal/omap5-thermal-data.c +1 -1
@@ -310,7 +310,7 @@ omap5430_adc_to_temp[
 	119800, 120200, 120600, 121000, 121400, 121800, 122400, 122600, 123000,
 	123400,
 	/* Index 940 - 945 */
-	123800, 1242000, 124600, 124900, 125000, 125000,
+	123800, 124200, 124600, 124900, 125000, 125000,
 };
 
 /* OMAP54xx ES2.0 data */
Signature · 5 lines
 <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
#4 lore raw
Quoted 6 lines · Daniel Lezcano
Quoted 3 lines · Bartlomiej Zolnierkiewicz

Entry for Index 941 has one zero too much. Fix it.

Good catch :)

Thanks. :)

Quoted 1 line

I'm curious, how did you spot it ?

While I was reading the driver code I've noticed that omap5430_adc_to_temp[] and dra752_adc_to_temp[] look pretty similar so I've diff-ed them to find the actual differences (+ to see if one of the tables can be removed). One of such differences was the line containing the incorrect entry.

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics