bpf: Support struct btf_struct_meta via KF_IMPLICIT_ARGS
Subsystems (4)
Ihor Solodrai
reviewerPATCH v5 1/2 bpf: Support struct btf_struct_meta via KF_IMPLICIT_ARGS
The following kfuncs currently accept void *meta__ign argument:
* bpf_obj_new_impl
* bpf_obj_drop_impl
* bpf_percpu_obj_new_impl
* bpf_percpu_obj_drop_impl
* bpf_refcount_acquire_impl
* bpf_list_push_back_impl
* bpf_list_push_front_impl
* bpf_rbtree_add_impl
The __ign suffix is an indicator for the verifier to skip the argument in check_kfunc_args(). Then, in fixup_kfunc_call() the verifier may set the value of this argument to struct btf_struct_meta * kptr_struct_meta from insn_aux_data.
BPF programs must pass a dummy NULL value when calling these kfuncs.
Additionally, the list and rbtree _impl kfuncs also accept an implicit u64 argument, which doesn't require __ign suffix because it's a scalar, and BPF programs explicitly pass 0.
Add new kfuncs with KF_IMPLICIT_ARGS [1], that correspond to each _impl kfunc accepting meta__ign. The existing _impl kfuncs remain unchanged for backwards compatibility.
To support this, add "btf_struct_meta" to the list of recognized implicit argument types in resolve_btfids.
Implement is_kfunc_arg_implicit() in the verifier, that determines implicit args by inspecting both a non-_impl BTF prototype of the kfunc.
Update the special_kfunc_list in the verifier and relevant checks to support both the old _impl and the new KF_IMPLICIT_ARGS variants of btf_struct_meta users.
[1] https://lore.kernel.org/bpf/[email protected]/
---
v4->v5:
* Simplify is_kfunc_arg_implicit (Mykyta)
* Nits in patch #1 (AI)
v4: https://lore.kernel.org/bpf/[email protected]/
v3->v4:
* Move and reformat docs comments for relevant kfuncs from bpf_experimental.h to kernel/bpf/helpers.c (Jiri)
* Move BTF_ID() entries of affected kfuncs from the end of the special_kfunc_list to pair them with legacy variants (Alexei)
* Bump BTF_ID_LIST stub size to avoid compiler warnings for builds with CONFIG_DEBUG_INFO_BTF=n (kernel test robot)
* https://lore.kernel.org/bpf/[email protected]/
* Misc typos
v3: https://lore.kernel.org/bpf/[email protected]/
v1->v3: Nits suggested by AI
v1: https://lore.kernel.org/bpf/[email protected]/
--- include/linux/btf_ids.h | 2 +- kernel/bpf/helpers.c | 178 ++++++++++++++++-- kernel/bpf/verifier.c | 178 ++++++++++++------ tools/bpf/resolve_btfids/main.c | 1 + .../selftests/bpf/progs/percpu_alloc_fail.c | 4 +- 5 files changed, 287 insertions(+), 76 deletions(-)
include/linux/btf_ids.h +1 -1
@@ -217,7 +217,7 @@ BTF_SET8_END(name)#else -#define BTF_ID_LIST (name) static u32 __maybe_unused name[64]; +#define BTF_ID_LIST (name) static u32 __maybe_unused name[128];#define BTF_ID (prefix, name)#define BTF_ID_FLAGS (prefix, name, ...)#define BTF_ID_UNUSED
kernel/bpf/helpers.c +158 -20
271 lines not on this page · raw message
kernel/bpf/verifier.c +125 -53
394 lines not on this page · raw message
tools/bpf/resolve_btfids/main.c +1 -0
@@ -1065,6 +1065,7 @@ static bool is_kf_implicit_arg(const struct btf *btf, const struct btf_param *p) {static const char *const kf_implicit_arg_types[] = {"bpf_prog_aux" , +"btf_struct_meta" , };const struct btf_type *t;const char *name;
tools/testing/selftests/bpf/progs/percpu_alloc_fail.c +2 -2
@@ -110,7 +110,7 @@ int BPF_PROG(test_array_map_3) } SEC("?fentry.s/bpf_fentry_test1") -__failure __msg("arg#0 expected for bpf_percpu_obj_drop_impl()") +__failure __msg("arg#0 expected for bpf_percpu_obj_drop()") int BPF_PROG(test_array_map_4) { struct val_t __percpu_kptr *p;
@@ -124,7 +124,7 @@ int BPF_PROG(test_array_map_4) } SEC("?fentry.s/bpf_fentry_test1") -__failure __msg("arg#0 expected for bpf_obj_drop_impl()") +__failure __msg("arg#0 expected for bpf_obj_drop()") int BPF_PROG(test_array_map_5) {struct val_t *p;
Signature · 1 line
2.53.0
Ihor Solodrai
reviewerPATCH v5 2/2 selftests/bpf: Update kfuncs using btf_struct_meta to new variants
Update selftests to use the new non-_impl kfuncs marked with KF_IMPLICIT_ARGS by removing redundant declarations and macros from bpf_experimental.h (the new kfuncs are present in the vmlinux.h) and updating relevant callsites.
Fix spin_lock verifier-log matching for lock_id_kptr_preserve by accepting variable instruction numbers. The calls to kfuncs with implicit arguments do not have register moves (e.g. r5 = 0) corresponding to dummy arguments anymore, so the order of instructions has shifted.
--- .../testing/selftests/bpf/bpf_experimental.h | 156 +----------------- .../selftests/bpf/prog_tests/spin_lock.c | 5 +- .../selftests/bpf/progs/kptr_xchg_inline.c | 4 +- 3 files changed, 9 insertions(+), 156 deletions(-)
tools/testing/selftests/bpf/bpf_experimental.h +4 -152
@@ -8,156 +8,11 @@#define __contains (name, node) __attribute__((btf_decl_tag("contains:" #name ":" #node))) -/* Description -* Allocates an object of the type represented by 'local_type_id' in -* program BTF. User may use the bpf_core_type_id_local macro to pass the -* type ID of a struct in program BTF. -* -* The 'local_type_id' parameter must be a known constant. -* The 'meta' parameter is rewritten by the verifier, no need for BPF -* program to set it. -* Returns -* A pointer to an object of the type corresponding to the passed in -* 'local_type_id', or NULL on failure. -*/ -extern void *bpf_obj_new_impl (__u64 local_type_id,void *meta) __ksym; - -/* Convenience macro to wrap over bpf_obj_new_impl */ -#define bpf_obj_new (type) ((type *)bpf_obj_new_impl(bpf_core_type_id_local(type), NULL)) - -/* Description -* Free an allocated object. All fields of the object that require -* destruction will be destructed before the storage is freed. -* -* The 'meta' parameter is rewritten by the verifier, no need for BPF -* program to set it. -* Returns -* Void. -*/ -extern void bpf_obj_drop_impl(void *kptr, void *meta) __ksym; - -/* Convenience macro to wrap over bpf_obj_drop_impl */ -#define bpf_obj_drop (kptr) bpf_obj_drop_impl(kptr, NULL) - -/* Description -* Increment the refcount on a refcounted local kptr, turning the -* non-owning reference input into an owning reference in the process. -* -* The 'meta' parameter is rewritten by the verifier, no need for BPF -* program to set it. -* Returns -* An owning reference to the object pointed to by 'kptr' -*/ -extern void *bpf_refcount_acquire_impl (void *kptr,void *meta) __ksym; - -/* Convenience macro to wrap over bpf_refcount_acquire_impl */ -#define bpf_refcount_acquire (kptr) bpf_refcount_acquire_impl(kptr, NULL) - -/* Description -* Add a new entry to the beginning of the BPF linked list. -* -* The 'meta' and 'off' parameters are rewritten by the verifier, no need -* for BPF programs to set them -* Returns -* 0 if the node was successfully added -* -EINVAL if the node wasn't added because it's already in a list -*/ -extern int bpf_list_push_front_impl(struct bpf_list_head *head, - struct bpf_list_node *node, - void *meta, __u64 off) __ksym; - -/* Convenience macro to wrap over bpf_list_push_front_impl */ -#define bpf_list_push_front (head, node) bpf_list_push_front_impl(head, node, NULL, 0) - -/* Description -* Add a new entry to the end of the BPF linked list. -* -* The 'meta' and 'off' parameters are rewritten by the verifier, no need -* for BPF programs to set them -* Returns -* 0 if the node was successfully added -* -EINVAL if the node wasn't added because it's already in a list -*/ -extern int bpf_list_push_back_impl(struct bpf_list_head *head, - struct bpf_list_node *node, - void *meta, __u64 off) __ksym; - -/* Convenience macro to wrap over bpf_list_push_back_impl */ -#define bpf_list_push_back (head, node) bpf_list_push_back_impl(head, node, NULL, 0) - -/* Description -* Remove the entry at the beginning of the BPF linked list. -* Returns -* Pointer to bpf_list_node of deleted entry, or NULL if list is empty. -*/ -extern struct bpf_list_node *bpf_list_pop_front (struct bpf_list_head *head) __ksym; - -/* Description -* Remove the entry at the end of the BPF linked list. -* Returns -* Pointer to bpf_list_node of deleted entry, or NULL if list is empty. -*/ -extern struct bpf_list_node *bpf_list_pop_back (struct bpf_list_head *head) __ksym; - -/* Description -* Remove 'node' from rbtree with root 'root' -* Returns -* Pointer to the removed node, or NULL if 'root' didn't contain 'node' -*/ -extern struct bpf_rb_node *bpf_rbtree_remove (struct bpf_rb_root *root, -struct bpf_rb_node *node) __ksym; - -/* Description -* Add 'node' to rbtree with root 'root' using comparator 'less' -* -* The 'meta' and 'off' parameters are rewritten by the verifier, no need -* for BPF programs to set them -* Returns -* 0 if the node was successfully added -* -EINVAL if the node wasn't added because it's already in a tree -*/ -extern int bpf_rbtree_add_impl(struct bpf_rb_root *root, struct bpf_rb_node *node, - bool (less)(struct bpf_rb_node *a, const struct bpf_rb_node *b), - void *meta, __u64 off) __ksym; - -/* Convenience macro to wrap over bpf_rbtree_add_impl */ -#define bpf_rbtree_add (head, node, less) bpf_rbtree_add_impl(head, node, less, NULL, 0) +/* Convenience macro to wrap over bpf_obj_new */ +#define bpf_obj_new (type) ((type *)bpf_obj_new(bpf_core_type_id_local(type))) -/* Description -* Return the first (leftmost) node in input tree -* Returns -* Pointer to the node, which is _not_ removed from the tree. If the tree -* contains no nodes, returns NULL. -*/ -extern struct bpf_rb_node *bpf_rbtree_first (struct bpf_rb_root *root) __ksym; - -/* Description -* Allocates a percpu object of the type represented by 'local_type_id' in -* program BTF. User may use the bpf_core_type_id_local macro to pass the -* type ID of a struct in program BTF. -* -* The 'local_type_id' parameter must be a known constant. -* The 'meta' parameter is rewritten by the verifier, no need for BPF -* program to set it. -* Returns -* A pointer to a percpu object of the type corresponding to the passed in -* 'local_type_id', or NULL on failure. -*/ -extern void *bpf_percpu_obj_new_impl (__u64 local_type_id,void *meta) __ksym; - -/* Convenience macro to wrap over bpf_percpu_obj_new_impl */ -#define bpf_percpu_obj_new (type) ((type __percpu_kptr *)bpf_percpu_obj_new_impl(bpf_core_type_id_local(type), NULL)) - -/* Description -* Free an allocated percpu object. All fields of the object that require -* destruction will be destructed before the storage is freed. -* -* The 'meta' parameter is rewritten by the verifier, no need for BPF -* program to set it. -* Returns -* Void. -*/ -extern void bpf_percpu_obj_drop_impl(void *kptr, void *meta) __ksym; +/* Convenience macro to wrap over bpf_percpu_obj_new */ +#define bpf_percpu_obj_new (type) ((type __percpu_kptr *)bpf_percpu_obj_new(bpf_core_type_id_local(type)))struct bpf_iter_task_vma ;
@@ -167,9 +22,6 @@ extern int bpf_iter_task_vma_new(struct bpf_iter_task_vma *it,extern struct vm_area_struct *bpf_iter_task_vma_next (struct bpf_iter_task_vma *it) __ksym; extern void bpf_iter_task_vma_destroy(struct bpf_iter_task_vma *it) __ksym; -/* Convenience macro to wrap over bpf_obj_drop_impl */ -#define bpf_percpu_obj_drop (kptr) bpf_percpu_obj_drop_impl(kptr, NULL) -/* Description * Throw a BPF exception from the program, immediately terminating its * execution and unwinding the stack. The supplied 'cookie' parameter
tools/testing/selftests/bpf/prog_tests/spin_lock.c +3 -2
@@ -13,8 +13,9 @@ static struct {const char *err_msg; } spin_lock_fail_tests[] = { {"lock_id_kptr_preserve" , -"5: (bf) r1 = r0 ; R0=ptr_foo(id=2,ref_obj_id=2) " -"R1=ptr_foo(id=2,ref_obj_id=2) refs=2\n6: (85) call bpf_this_cpu_ptr#154\n" +"[0-9]\\+: (bf) r1 = r0 ; R0=ptr_foo(id=2,ref_obj_id=2)" +" R1=ptr_foo(id=2,ref_obj_id=2) refs=2\n" +"[0-9]\\+: (85) call bpf_this_cpu_ptr#154\n" "R1 type=ptr_ expected=percpu_ptr_" }, { "lock_id_global_zero","; R1=map_value(map=.data.A,ks=4,vs=4)\n2: (85) call bpf_this_cpu_ptr#154\n"
tools/testing/selftests/bpf/progs/kptr_xchg_inline.c +2 -2
@@ -25,14 +25,14 @@ __naked int kptr_xchg_inline(void) "if r0 == 0 goto 1f;" "r1 = r0;" "r2 = 0;" - "call %[bpf_obj_drop_impl];" + "call %[bpf_obj_drop];" "1:" "r0 = 0;" "exit;" : : __imm_addr(ptr), __imm(bpf_kptr_xchg), - __imm(bpf_obj_drop_impl) + __imm(bpf_obj_drop) : __clobber_all ); }
Signature · 1 line
2.53.0
Re: [PATCH bpf-next v5 2/2] selftests/bpf: Update kfuncs using btf_struct_meta to new variants
Quoted 5 lines · Ihor Solodrai
Update selftests to use the new non-_impl kfuncs marked with
KF_IMPLICIT_ARGSby removing redundant declarations and macros frombpf_experimental.h(the new kfuncs are present in thevmlinux.h) and updating relevant callsites.
Quoted 8 lines
Fix
spin_lockverifier-log matching forlock_id_kptr_preserveby accepting variable instruction numbers. The calls to kfuncs with implicit arguments do not have register moves (e.g. r5 = 0) corresponding to dummy arguments anymore, so the order of instructions has shifted.Acked-by Mykyta Yatsenko <[email protected]>Signed-off-by Ihor Solodrai <[email protected]>
jirka
Quoted 221 lines
--- .../testing/selftests/bpf/bpf_experimental.h | 156 +----------------- .../selftests/bpf/prog_tests/spin_lock.c | 5 +- .../selftests/bpf/progs/kptr_xchg_inline.c | 4 +- 3 files changed, 9 insertions(+), 156 deletions(-)tools/testing/selftests/bpf/bpf_experimental.h +4
-152@@ -8,156 +8,11 @@#define __contains (name, node) __attribute__((btf_decl_tag("contains:" #name ":" #node))) -/* Description -* Allocates an object of the type represented by 'local_type_id' in -* program BTF. User may use the bpf_core_type_id_local macro to pass the -* type ID of a struct in program BTF. -* -* The 'local_type_id' parameter must be a known constant. -* The 'meta' parameter is rewritten by the verifier, no need for BPF -* program to set it. -* Returns -* A pointer to an object of the type corresponding to the passed in -* 'local_type_id', or NULL on failure. -*/ -extern void *bpf_obj_new_impl (__u64 local_type_id,void *meta) __ksym; - -/* Convenience macro to wrap over bpf_obj_new_impl */ -#define bpf_obj_new (type) ((type *)bpf_obj_new_impl(bpf_core_type_id_local(type), NULL)) - -/* Description -* Free an allocated object. All fields of the object that require -* destruction will be destructed before the storage is freed. -* -* The 'meta' parameter is rewritten by the verifier, no need for BPF -* program to set it. -* Returns -* Void. -*/ -extern void bpf_obj_drop_impl(void *kptr, void *meta) __ksym; - -/* Convenience macro to wrap over bpf_obj_drop_impl */ -#define bpf_obj_drop (kptr) bpf_obj_drop_impl(kptr, NULL) - -/* Description -* Increment the refcount on a refcounted local kptr, turning the -* non-owning reference input into an owning reference in the process. -* -* The 'meta' parameter is rewritten by the verifier, no need for BPF -* program to set it. -* Returns -* An owning reference to the object pointed to by 'kptr' -*/ -extern void *bpf_refcount_acquire_impl (void *kptr,void *meta) __ksym; - -/* Convenience macro to wrap over bpf_refcount_acquire_impl */ -#define bpf_refcount_acquire (kptr) bpf_refcount_acquire_impl(kptr, NULL) - -/* Description -* Add a new entry to the beginning of the BPF linked list. -* -* The 'meta' and 'off' parameters are rewritten by the verifier, no need -* for BPF programs to set them -* Returns -* 0 if the node was successfully added -* -EINVAL if the node wasn't added because it's already in a list -*/ -extern int bpf_list_push_front_impl(struct bpf_list_head *head, - struct bpf_list_node *node, - void *meta, __u64 off) __ksym; - -/* Convenience macro to wrap over bpf_list_push_front_impl */ -#define bpf_list_push_front (head, node) bpf_list_push_front_impl(head, node, NULL, 0) - -/* Description -* Add a new entry to the end of the BPF linked list. -* -* The 'meta' and 'off' parameters are rewritten by the verifier, no need -* for BPF programs to set them -* Returns -* 0 if the node was successfully added -* -EINVAL if the node wasn't added because it's already in a list -*/ -extern int bpf_list_push_back_impl(struct bpf_list_head *head, - struct bpf_list_node *node, - void *meta, __u64 off) __ksym; - -/* Convenience macro to wrap over bpf_list_push_back_impl */ -#define bpf_list_push_back (head, node) bpf_list_push_back_impl(head, node, NULL, 0) - -/* Description -* Remove the entry at the beginning of the BPF linked list. -* Returns -* Pointer to bpf_list_node of deleted entry, or NULL if list is empty. -*/ -extern struct bpf_list_node *bpf_list_pop_front (struct bpf_list_head *head) __ksym; - -/* Description -* Remove the entry at the end of the BPF linked list. -* Returns -* Pointer to bpf_list_node of deleted entry, or NULL if list is empty. -*/ -extern struct bpf_list_node *bpf_list_pop_back (struct bpf_list_head *head) __ksym; - -/* Description -* Remove 'node' from rbtree with root 'root' -* Returns -* Pointer to the removed node, or NULL if 'root' didn't contain 'node' -*/ -extern struct bpf_rb_node *bpf_rbtree_remove (struct bpf_rb_root *root, -struct bpf_rb_node *node) __ksym; - -/* Description -* Add 'node' to rbtree with root 'root' using comparator 'less' -* -* The 'meta' and 'off' parameters are rewritten by the verifier, no need -* for BPF programs to set them -* Returns -* 0 if the node was successfully added -* -EINVAL if the node wasn't added because it's already in a tree -*/ -extern int bpf_rbtree_add_impl(struct bpf_rb_root *root, struct bpf_rb_node *node, - bool (less)(struct bpf_rb_node *a, const struct bpf_rb_node *b), - void *meta, __u64 off) __ksym; - -/* Convenience macro to wrap over bpf_rbtree_add_impl */ -#define bpf_rbtree_add (head, node, less) bpf_rbtree_add_impl(head, node, less, NULL, 0) +/* Convenience macro to wrap over bpf_obj_new */ +#define bpf_obj_new (type) ((type *)bpf_obj_new(bpf_core_type_id_local(type))) -/* Description -* Return the first (leftmost) node in input tree -* Returns -* Pointer to the node, which is _not_ removed from the tree. If the tree -* contains no nodes, returns NULL. -*/ -extern struct bpf_rb_node *bpf_rbtree_first (struct bpf_rb_root *root) __ksym; - -/* Description -* Allocates a percpu object of the type represented by 'local_type_id' in -* program BTF. User may use the bpf_core_type_id_local macro to pass the -* type ID of a struct in program BTF. -* -* The 'local_type_id' parameter must be a known constant. -* The 'meta' parameter is rewritten by the verifier, no need for BPF -* program to set it. -* Returns -* A pointer to a percpu object of the type corresponding to the passed in -* 'local_type_id', or NULL on failure. -*/ -extern void *bpf_percpu_obj_new_impl (__u64 local_type_id,void *meta) __ksym; - -/* Convenience macro to wrap over bpf_percpu_obj_new_impl */ -#define bpf_percpu_obj_new (type) ((type __percpu_kptr *)bpf_percpu_obj_new_impl(bpf_core_type_id_local(type), NULL)) - -/* Description -* Free an allocated percpu object. All fields of the object that require -* destruction will be destructed before the storage is freed. -* -* The 'meta' parameter is rewritten by the verifier, no need for BPF -* program to set it. -* Returns -* Void. -*/ -extern void bpf_percpu_obj_drop_impl(void *kptr, void *meta) __ksym; +/* Convenience macro to wrap over bpf_percpu_obj_new */ +#define bpf_percpu_obj_new (type) ((type __percpu_kptr *)bpf_percpu_obj_new(bpf_core_type_id_local(type)))struct bpf_iter_task_vma ;@@ -167,9 +22,6 @@ extern int bpf_iter_task_vma_new(struct bpf_iter_task_vma *it,extern struct vm_area_struct *bpf_iter_task_vma_next (struct bpf_iter_task_vma *it) __ksym; extern void bpf_iter_task_vma_destroy(struct bpf_iter_task_vma *it) __ksym; -/* Convenience macro to wrap over bpf_obj_drop_impl */ -#define bpf_percpu_obj_drop (kptr) bpf_percpu_obj_drop_impl(kptr, NULL) -/* Description * Throw a BPF exception from the program, immediately terminating its * execution and unwinding the stack. The supplied 'cookie' parameter tools/testing/selftests/bpf/prog_tests/spin_lock.c +3
-2@@ -13,8 +13,9 @@ static struct {const char *err_msg; } spin_lock_fail_tests[] = { {"lock_id_kptr_preserve" , -"5: (bf) r1 = r0 ; R0=ptr_foo(id=2,ref_obj_id=2) " -"R1=ptr_foo(id=2,ref_obj_id=2) refs=2\n6: (85) call bpf_this_cpu_ptr#154\n" +"[0-9]\\+: (bf) r1 = r0 ; R0=ptr_foo(id=2,ref_obj_id=2)" +" R1=ptr_foo(id=2,ref_obj_id=2) refs=2\n" +"[0-9]\\+: (85) call bpf_this_cpu_ptr#154\n" "R1 type=ptr_ expected=percpu_ptr_" }, { "lock_id_global_zero","; R1=map_value(map=.data.A,ks=4,vs=4)\n2: (85) call bpf_this_cpu_ptr#154\n" tools/testing/selftests/bpf/progs/kptr_xchg_inline.c +2
-2@@ -25,14 +25,14 @@ __naked int kptr_xchg_inline(void) "if r0 == 0 goto 1f;" "r1 = r0;" "r2 = 0;" - "call %[bpf_obj_drop_impl];" + "call %[bpf_obj_drop];" "1:" "r0 = 0;" "exit;" : : __imm_addr(ptr), __imm(bpf_kptr_xchg), - __imm(bpf_obj_drop_impl) + __imm(bpf_obj_drop) : __clobber_all ); }Signature · 1 line
2.53.0
Quoted 32 lines · Ihor Solodrai
The following kfuncs currently accept void
*meta__ignargument:
*bpf_obj_new_impl
*bpf_obj_drop_impl
*bpf_percpu_obj_new_impl
*bpf_percpu_obj_drop_impl
*bpf_refcount_acquire_impl
*bpf_list_push_back_impl
*bpf_list_push_front_impl
*bpf_rbtree_add_implThe
__ignsuffix is an indicator for the verifier to skip the argument incheck_kfunc_args(). Then, infixup_kfunc_call()the verifier may set the value of this argument to structbtf_struct_meta*kptr_struct_metafrominsn_aux_data.BPF programs must pass a dummy NULL value when calling these kfuncs.
Additionally, the list and rbtree
_implkfuncs also accept an implicit u64 argument, which doesn't require__ignsuffix because it's a scalar, and BPF programs explicitly pass 0.Add new kfuncs with
KF_IMPLICIT_ARGS[1], that correspond to each_implkfunc acceptingmeta__ign. The existing_implkfuncs remain unchanged for backwards compatibility.To support this, add "
btf_struct_meta" to the list of recognized implicit argument types inresolve_btfids.Implement
is_kfunc_arg_implicit()in the verifier, that determines implicit args by inspecting both a non-_impl BTF prototype of the kfunc.
Quoted 7 lines
Update the
special_kfunc_listin the verifier and relevant checks to support both the old_impland the newKF_IMPLICIT_ARGSvariants ofbtf_struct_metausers.[1] https://lore.kernel.org/bpf/[email protected]/
Signed-off-by Ihor Solodrai <[email protected]>
jirka
This series was applied to bpf/bpf-next.git (master) by Alexei Starovoitov <[email protected]>:
Hello:
This series was applied to bpf/bpf-next.git (master) by Alexei Starovoitov <[email protected]>:
Quoted 11 lines · On Fri, 27 Mar 2026 13:32:40 -0700 you wrote:
The following kfuncs currently accept void
*meta__ignargument:
*bpf_obj_new_impl
*bpf_obj_drop_impl
*bpf_percpu_obj_new_impl
*bpf_percpu_obj_drop_impl
*bpf_refcount_acquire_impl
*bpf_list_push_back_impl
*bpf_list_push_front_impl
*bpf_rbtree_add_impl[...]
Here is the summary with links:
- [bpf-next,v5,1/2] bpf: Support struct btf_struct_meta via KF_IMPLICIT_ARGS
https://git.kernel.org/bpf/bpf-next/c/d457072576a6 - [bpf-next,v5,2/2] selftests/bpf: Update kfuncs using btf_struct_meta to new variants https://git.kernel.org/bpf/bpf-next/c/101a9d9df8e7
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html