vsock: initialize child_ns_mode_locked in vsock_net_init()
Subsystems (4)
Stefano Garzarella
maintainerPATCH 1/1 vsock: initialize child_ns_mode_locked in vsock_net_init()
From: Stefano Garzarella <[email protected]>
The child_ns_mode_locked field lives in struct net, which persists across vsock module reloads. When the module is unloaded and reloaded, vsock_net_init() resets mode and child_ns_mode back to their default values, but does not reset child_ns_mode_locked.
The stale lock from the previous module load causes subsequent writes to child_ns_mode to silently fail: vsock_net_set_child_mode() sees the old lock, skips updating the actual value, and returns success when the requested mode matches the stale lock. The sysctl handler reports no error, but child_ns_mode remains unchanged.
Steps to reproduce:
$ modprobe vsock
$ echo local > /proc/sys/net/vsock/child_ns_mode
$ cat /proc/sys/net/vsock/child_ns_mode
local
$ modprobe -r vsock
$ modprobe vsock
$ echo local > /proc/sys/net/vsock/child_ns_mode
$ cat /proc/sys/net/vsock/child_ns_mode
global <--- expected "local"Fix this by initializing child_ns_mode_locked to 0 (unlocked) in vsock_net_init(), so the write-once mechanism works correctly after module reload.
--- net/vmw_vsock/af_vsock.c | 1 + 1 file changed, 1 insertion(+)
net/vmw_vsock/af_vsock.c +1 -0
@@ -2928,6 +2928,7 @@ static void vsock_net_init(struct net *net) net->vsock.mode =vsock_net_child_mode (current->nsproxy->net_ns); net->vsock.child_ns_mode = net->vsock.mode; + net->vsock.child_ns_mode_locked =0 ; }static __net_init int vsock_sysctl_init_net (struct net *net)
Signature · 1 line
2.53.0
Quoted 51 lines · Stefano Garzarella
From: Stefano Garzarella <[email protected]>
The
child_ns_mode_lockedfield lives instruct net, which persists across vsock module reloads. When the module is unloaded and reloaded,vsock_net_init()resetsmodeandchild_ns_modeback to their default values, but does not resetchild_ns_mode_locked.The stale lock from the previous module load causes subsequent writes to
child_ns_modeto silently fail:vsock_net_set_child_mode()sees the old lock, skips updating the actual value, and returns success when the requested mode matches the stale lock. The sysctl handler reports no error, butchild_ns_moderemains unchanged.Steps to reproduce:
$ modprobe vsock $ echo local > /proc/sys/net/vsock/child_ns_mode $ cat /proc/sys/net/vsock/child_ns_mode local $ modprobe -r vsock $ modprobe vsock $ echo local > /proc/sys/net/vsock/child_ns_mode $ cat /proc/sys/net/vsock/child_ns_mode global <--- expected "local"Fix this by initializing
child_ns_mode_lockedto 0 (unlocked) invsock_net_init(), so the write-once mechanism works correctly after module reload.Fixes 102eab95f025 ("vsock: lock down child_ns_mode as write-once")Reported-by Jin Liu <[email protected]>Signed-off-by Stefano Garzarella <[email protected]>--- net/vmw_vsock/af_vsock.c | 1 + 1 file changed, 1 insertion(+)net/vmw_vsock/af_vsock.c +1
-0@@ -2928,6 +2928,7 @@ static void vsock_net_init(struct net *net) net->vsock.mode =vsock_net_child_mode (current->nsproxy->net_ns); net->vsock.child_ns_mode = net->vsock.mode; + net->vsock.child_ns_mode_locked =0 ; }static __net_init int vsock_sysctl_init_net (struct net *net)Signature · 1 line
2.53.0
This patch was applied to netdev/net.git (main) by Jakub Kicinski <[email protected]>:
Hello:
This patch was applied to netdev/net.git (main)
by Jakub Kicinski <[email protected]>:
Quoted 8 lines · On Wed, 1 Apr 2026 11:21:53 +0200 you wrote:
From: Stefano Garzarella <[email protected]>
The
child_ns_mode_lockedfield lives instruct net, which persists across vsock module reloads. When the module is unloaded and reloaded,vsock_net_init()resetsmodeandchild_ns_modeback to their default values, but does not resetchild_ns_mode_locked.[...]
Here is the summary with links:
- [net] vsock: initialize child_ns_mode_locked in vsock_net_init()
https://git.kernel.org/netdev/net/c/b18c83388874
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html