net: fec: make FIXED_PHY dependency unconditional
Subsystems (2)
PATCH 1/1 net: fec: make FIXED_PHY dependency unconditional
From: Arnd Bergmann <[email protected]>
When CONFIG_FIXED_PHY is in a loadable module, the fec driver cannot be built-in any more:
x86_64-linux-ld: vmlinux.o: in function `fec_enet_mii_probe':
fec_main.c:(.text+0xc4f367): undefined reference to `fixed_phy_unregister'
x86_64-linux-ld: vmlinux.o: in function `fec_enet_close':
fec_main.c:(.text+0xc59591): undefined reference to `fixed_phy_unregister'
x86_64-linux-ld: vmlinux.o: in function `fec_enet_mii_probe.cold':
Select the fixed phy support on all targets to make this build correctly, not just on coldfire.
Notat that Essentially the stub helpers in include/linux/phy_fixed.h cannot be used correctly because of this build time dependency, and we could just remove them to hit the build failure more often when a driver uses them without the 'select FIXED_PHY'.
---
I sent the same fix for B44 earlier, see commit 3f0f591b44b0 ("net: b44:
always select CONFIG_FIXED_PHY"). I checked that there are no other conditional users of FIXED_PHY this time.
--- drivers/net/ethernet/freescale/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/ethernet/freescale/Kconfig +1 -1
@@ -28,7 +28,7 @@ config FEC depends on PTP_1588_CLOCK_OPTIONAL select CRC32 select PHYLIB - select FIXED_PHY if M5272 + select FIXED_PHY select PAGE_POOL imply PAGE_POOL_STATS imply NET_SELFTESTS
Signature · 1 line
2.39.5
Quoted 19 lines · Arnd Bergmann
From: Arnd Bergmann <[email protected]>
When
CONFIG_FIXED_PHYis in a loadable module, the fec driver cannot be built-in any more:x86_64-linux-ld: vmlinux.o: in function `fec_enet_mii_probe':
fec_main.c:(.text+0xc4f367): undefined reference to `fixed_phy_unregister'
x86_64-linux-ld: vmlinux.o: in function `fec_enet_close':
fec_main.c:(.text+0xc59591): undefined reference to `fixed_phy_unregister'
x86_64-linux-ld: vmlinux.o: in function `fec_enet_mii_probe.cold':Select the fixed phy support on all targets to make this build correctly, not just on coldfire.
Notat that Essentially the stub helpers in
include/linux/phy_fixed.hcannot be used correctly because of this build time dependency, and we could just remove them to hit the build failure more often when a driver uses them without the 'selectFIXED_PHY'.
Quoted 6 lines
Fixes dc86b621e1b4 ("net: fec: register a fixed phy using fixed_phy_register_100fd if needed")Signed-off-by Arnd Bergmann <[email protected]>---
I sent the same fix for B44 earlier, see commit3f0f591b44b0("net: b44:
always selectCONFIG_FIXED_PHY"). I checked that there are no other conditional users ofFIXED_PHYthis time.
This patch was applied to netdev/net.git (main) by Jakub Kicinski <[email protected]>:
Hello:
This patch was applied to netdev/net.git (main)
by Jakub Kicinski <[email protected]>:
Quoted 5 lines · On Thu, 2 Apr 2026 16:10:40 +0200 you wrote:
From: Arnd Bergmann <[email protected]>
When
CONFIG_FIXED_PHYis in a loadable module, the fec driver cannot be built-in any more:
Quoted 7 lines
x86_64-linux-ld: vmlinux.o: in function `fec_enet_mii_probe':
fec_main.c:(.text+0xc4f367): undefined reference to `fixed_phy_unregister'
x86_64-linux-ld: vmlinux.o: in function `fec_enet_close':
fec_main.c:(.text+0xc59591): undefined reference to `fixed_phy_unregister'
x86_64-linux-ld: vmlinux.o: in function `fec_enet_mii_probe.cold':[...]
Here is the summary with links:
- net: fec: make FIXED_PHY dependency unconditional
https://git.kernel.org/netdev/net/c/e16a0d36777b
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html